[PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised

rned by "x-enable-wce-if-config-wce" virtio-blk-device property and introduce hw_compat_4_2 with new property being off by default for all machine types <= 4.2 (but don't introduce 4.3 machine type itself yet). Signed-off-by: Evgeny Yakovlev --- hw/arm/virt.c | 1 +

[RFC PATCH] accel/kvm: respect section RO flag when mapping phys mem

off-by: Evgeny Yakovlev --- accel/kvm/kvm-all.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index d2d96d7..6f9ed24 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -407,9 +407,16 @@ err: * dirty pa

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

On 09.10.2019 22:14, Michael S. Tsirkin wrote: On Tue, Oct 08, 2019 at 02:24:16PM +0100, Stefan Hajnoczi wrote: On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device Initialization: "Devices SHOULD always

Re: [RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

On 08.10.2019 16:24, Stefan Hajnoczi wrote: On Fri, Sep 20, 2019 at 02:56:30PM +0300, Evgeny Yakovlev wrote: Virtio spec 1.1 (and earlier), 5.2.5.1 Driver Requirements: Device Initialization: "Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it if they

[PATCH] hw/vfio/pci: fix double free in vfio_msi_disable

ectors) in vfio_msi_disable_common => double free Signed-off-by: Evgeny Yakovlev --- hw/vfio/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index c5e6fe6..12fac39 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -651,6 +651,7 @@ retry: } g_

[RFC PATCH] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is also advertised

rtise F_CONFIG_WCE if config-wce argument is set for virtio-blk device. While F_WCE is advertised if underlying block backend actually has it's caching enabled. Those two things are not related to each other. Signed-off-by: Evgeny Yakovlev --- hw/block/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(

Re: [Qemu-devel] BDRV request fragmentation and vitio-blk write submission guarantees

On 19.07.2019 13:17, Stefan Hajnoczi wrote: On Thu, Jul 18, 2019 at 04:44:17PM +0300, Евгений Яковлев wrote: Hi everyone, We're currently working on implementing a qemu BDRV format driver which we are using with virtio-blk devices. I have a question concerning BDRV request fragmentation and

[Qemu-devel] [PATCH] i386/acpi: show PCI Express bus on pxb-pcie expanders

Show PCIe host bridge PNP id with PCI host bridge as a compatible id when expanding a pcie bus. Signed-off-by: Evgeny Yakovlev --- hw/i386/acpi-build.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index d281ffa..0675952

[Qemu-devel] [PATCH v2] i386/acpi: fix gint overflow in crs_range_compare

device and PCI64 hole intersection and device becomes unusable. Fix that by returning exactly fitting ranges. Also fix indentation of an entire crs_replace_with_free_ranges to make checkpatch happy. Signed-off-by: Evgeny Yakovlev --- v2: entire crs_replace_with_free_ranges was indented with 5

[Qemu-devel] [PATCH] i386/acpi: fix gint overflow in crs_range_compare

device and PCI64 hole intersection and device becomes unusable. Fix that by returning exactly fitting ranges. Signed-off-by: Evgeny Yakovlev --- hw/i386/acpi-build.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index d281ffa

[Qemu-devel] [PATCH] block/curl: wake read completion coroutine only if necessary

e coroutine, which asserts in aio_co_enter. This change attempts to fix this by waking completion coroutine only if it is not the current one. Signed-off-by: Evgeny Yakovlev <wr...@yandex-team.ru> --- block/curl.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/blo

Re: [Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

On 22.05.2017 20:44, Michael S. Tsirkin wrote: On Mon, May 22, 2017 at 02:58:56PM +0200, Igor Mammedov wrote: On Mon, 22 May 2017 14:01:15 +0300 Evgeny Yakovlev <eyakov...@virtuozzo.com> wrote: On 22.05.2017 13:35, Igor Mammedov wrote: On Mon, 22 May 2017 12:50:30 +0300 Evgeny Ya

Re: [Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

On 22.05.2017 13:35, Igor Mammedov wrote: On Mon, 22 May 2017 12:50:30 +0300 Evgeny Yakovlev <eyakov...@virtuozzo.com> wrote: When running windows 2016 server guests we have encountered a problem with ACPI representation of CPU devices. This windows version contains a hidinterrupt.sys

[Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

f some device(s) which the driver wanted to support despite the bug. For reference this is a known issue: https://bugzilla.redhat.com/show_bug.cgi?id=1377155#c31 This change works around this problem by setting qemu CPU container ACPI _HID to compatible PNP0A05. Signed-off-by: Evgeny Yakovlev <eyak

[Qemu-devel] [PATCH] change CPU container node _HID to compatible PNP0A05

are welcome. Evgeny Yakovlev (1): acpi: change CPU container node _HID to compatible PNP0A05 hw/acpi/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1

Re: [Qemu-devel] [PATCH 2/3] qapi: flatten GuestPanicInformation union

On 20.02.2017 22:58, Denis V. Lunev wrote: On 02/20/2017 08:48 PM, Eric Blake wrote: On 02/20/2017 12:21 PM, Denis V. Lunev wrote: From: Anton Nefedov Signed-off-by: Anton Nefedov Signed-off-by: Denis V. Lunev CC:

Re: [Qemu-devel] [PATCH v6 3/6] tests: in IDE and AHCI tests perform DMA write before flushing

On 15.07.2016 20:23, Eric Blake wrote: On 07/15/2016 02:08 AM, Evgeny Yakovlev wrote: + * Write sector 0 with random data to make AHCI storage dirty If we ever have a case where we open a disk without specifying -raw, the random data _might_ resemble some other format and cause probe

Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from block test traces

On 14.07.2016 19:06, Eric Blake wrote: On 07/14/2016 06:29 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> bdrv_co_flush is now skipping flushes in case underlying media has no actual changes. This affected some blkdebug testcases that were expecting error log

Re: [Qemu-devel] [PATCH v6 3/6] tests: in IDE and AHCI tests perform DMA write before flushing

On 14.07.2016 19:05, Eric Blake wrote: On 07/14/2016 06:29 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Due to changes in flush behaviour clean disks stopped generating flush_to_disk events and IDE and AHCI tests that test flush commands started t

Re: [Qemu-devel] [PATCH v5 4/4] block: ignore flush requests when storage is clean

On 08.07.2016 21:44, John Snow wrote: On 07/04/2016 10:38 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not changed. This adds additional overhead on hos

Re: [Qemu-devel] [PATCH v5 4/4] block: ignore flush requests when storage is clean

On 08.07.2016 02:04, Eric Blake wrote: On 07/04/2016 08:38 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not changed. This adds additional overhead on hos

Re: [Qemu-devel] [PATCH v5 0/4] block: ignore flush requests when storage is clean

failure handling Signed-off-by: Evgeny Yakovlev <eyakov...@virtuozzo.com> Signed-off-by: Denis V. Lunev <d...@openvz.org> CC: Kevin Wolf <kw...@redhat.com> CC: Max Reitz <mre...@redhat.com> CC: Stefan Hajnoczi <stefa...@redhat.com> CC: Fam Zheng <f...@redhat.com

Re: [Qemu-devel] [PATCH 2/3] ide: ignore retry_unit check for non-retry operations

On 28.06.2016 23:56, Paolo Bonzini wrote: On 24/06/2016 17:06, Denis V. Lunev wrote: When doing DMA request ide/core.c will set s->retry_unit to s->unit in ide_start_dma. When dma completes ide_set_inactive sets retry_unit to -1. After that ide_flush_cache runs and fails thanks to blkdebug.

Re: [Qemu-devel] [PATCH v4 3/3] tests: in IDE and AHCI tests perform DMA write before flushing

On 28.06.2016 02:19, John Snow wrote: On 06/27/2016 10:47 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Due to changes in flush behaviour clean disks stopped generating flush_to_disk events and IDE and AHCI tests that test flush commands started t

Re: [Qemu-devel] [PATCH 1/3] block: ignore flush requests when storage is clean

On 24.06.2016 18:31, Eric Blake wrote: On 06/24/2016 09:06 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not changed. This adds additional overhead on hos

Re: [Qemu-devel] [PATCH v2 1/1] cpu: report hyperv feature words through qom

On 23.06.2016 00:01, Eduardo Habkost wrote: On Mon, Jun 20, 2016 at 06:29:40PM +0300, Denis V. Lunev wrote: From: Evgeny Yakovlev <eyakov...@virtuozzo.com> This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will