[Qemu-devel] [PATCH v4 1/2] Add a git-publish configuration file

to create the Cc list. [1]: https://github.com/stefanha/git-publish Signed-off-by: Fam Zheng <f...@redhat.com> --- .gitpublish | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 .gitpublish diff --git a/.gitpublish b/.gitpublish ne

[Qemu-devel] [PATCH v4 0/2] Add git-publish config file

v4: Fix prefixes. [Stefan] Keep rich profiles. [Paolo] v3: Fix trivial hunk placement. [Michael] Fix PPC sub-list. [Michael] v2: Add README paragraph [Marc-Andr??, Stefan] Fix 'trivial' profile [Marc-Andr??] Rename profiles [Stefan] Fam Zheng (2): Add a git-publish

[Qemu-devel] [PATCH v4 2/2] README: Document 'git-publish' workflow

Signed-off-by: Fam Zheng <f...@redhat.com> --- README | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/README b/README index 2c8e1c8cc4..7833b97365 100644 --- a/README +++ b/README @@ -56,7 +56,7 @@ The QEMU source code is maintained

Re: [Qemu-devel] [PATCH v4 RFC 0/3] util/uri.c: Coding style format

On Sun, 02/25 21:56, Thomas Huth wrote: > On 25.02.2018 05:57, no-re...@patchew.org wrote: > > LINKppc-softmmu/qemu-system-ppc > > collect2: error: ld returned 1 exit status > > make[1]: *** [Makefile:193: qemu-system-ppc] Error 1 > > make: *** [Makefile:404: subdir-ppc-softmmu] Error 2 > >

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

On Wed, 02/14 14:37, Philippe Mathieu-Daudé wrote: > On 02/13/2018 02:34 PM, Stefan Hajnoczi wrote: > > From: Fam Zheng <f...@redhat.com> > > > > git-publish [1] is a convenient tool to send patches and has been > > popular among QEMU developers. Recently it has

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

On Wed, 02/14 15:08, Paolo Bonzini wrote: > On 13/02/2018 19:09, Daniel P. Berrangé wrote: > > Why is a custom entry needed for block here (and other things > > below). Won't running get_maintainer.pl already correctly > > report when a patch needs cc'ing to qemu-bl...@nongnu.org > > based on

Re: [Qemu-devel] [PATCH] docker: dump 'config.log' if ./configure fails

On Thu, 02/15 14:23, Philippe Mathieu-Daudé wrote: > Suggested-by: Eric Blake > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/common.rc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/docker/common.rc

Re: [Qemu-devel] [PATCH] maintainers: Add myself as a OpenBSD maintainer

On Fri, 02/16 14:44, Philippe Mathieu-Daudé wrote: > On 02/16/2018 02:41 PM, Kamil Rytarowski wrote: > > On 16.02.2018 18:30, Philippe Mathieu-Daudé wrote: > >> But before announcing the host OS being supported again, I'd rather see > >> reproducible build/tests logs, in a (public - if possible)

Re: [Qemu-devel] [PATCH] vl: introduce vm_shutdown()

On Tue, 02/20 13:10, Stefan Hajnoczi wrote: > 1. virtio_scsi_handle_cmd_vq() racing with iothread_stop_all() hits the >virtio_scsi_ctx_check() assertion failure because the BDS AioContext >has been modified by iothread_stop_all(). Does this patch fix the issue completely? IIUC

Re: [Qemu-devel] [PATCH v2] linux-user: Support f_flags in statfs when available.

On Thu, 02/22 10:18, Shea Levy wrote: > Hello, > > These tabs match the existing style of linux-user/syscall.h, should I > remove them? > In practice, following the style of the surrounding code is usually preferred, and we ignore these errors in such cases. Fam

Re: [Qemu-devel] [PATCH v4 00/22] re-factor softfloat and add fp16 functions

On Mon, 02/19 13:56, Peter Maydell wrote: > On 17 February 2018 at 13:23, Alex Bennée wrote: > > Peter Maydell writes: > >> If you persuade git to use the --minimal, --patience or --histogram > >> git diff option when generating these patches

Re: [Qemu-devel] [PATCH 0/5] Block patches

On Wed, Feb 14, 2018 at 9:25 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Wed, Feb 14, 2018 at 08:48:20AM +0800, Fam Zheng wrote: >> On Tue, 02/13 17:34, Stefan Hajnoczi wrote: >> > The following changes since commit >> > fb68096da3d35e64c88cd610c1f

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

On Wed, Feb 14, 2018 at 9:34 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Wed, Feb 14, 2018 at 09:01:11AM +0800, Fam Zheng wrote: > Fam, if you want it dropped, let me know. Otherwise, we can leave it > in if there is no further discussion. Yeah, I think we can drop blo

Re: [Qemu-devel] [PATCH v2] iotests: Test creating overlay when guest running

Ping? On Thu, Jan 4, 2018 at 6:18 AM, Eric Blake <ebl...@redhat.com> wrote: > On 12/24/2017 08:51 PM, Fam Zheng wrote: >> Signed-off-by: Fam Zheng <f...@redhat.com> >> >> --- >> >> v2: Actually test the thing. [Kevin] >> --- >> tests/qem

Re: [Qemu-devel] [PATCH 1/5] Add a git-publish configuration file

On Tue, 02/13 18:09, Daniel P. Berrangé wrote: > On Tue, Feb 13, 2018 at 05:34:25PM +, Stefan Hajnoczi wrote: > > From: Fam Zheng <f...@redhat.com> > > > > git-publish [1] is a convenient tool to send patches and has been > > popular among QEMU developers. Re

Re: [Qemu-devel] [PATCH 0/5] Block patches

On Tue, 02/13 17:34, Stefan Hajnoczi wrote: > The following changes since commit fb68096da3d35e64c88cd610c1fa42766c58e92a: > > Revert "tests: use memfd in vhost-user-test" (2018-02-13 09:51:52 +) > > are available in the Git repository at: > > git://github.com/stefanha/qemu.git

[Qemu-devel] [PATCH v2] block/nvme: fix Coverity reports

From: Paolo Bonzini <pbonz...@redhat.com> 1) string not null terminated in sysfs_find_group_file 2) NULL pointer dereference and dead local variable in nvme_init. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- v2: Fix erro

Re: [Qemu-devel] [PATCH RESEND v12 11/30] sdhci: replace DMA magic value by BLOCK_SIZE_MASK

On Mon, 02/12 15:00, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Alistair Francis Hmm.. Something is going weird here. It's still not in the archive

Re: [Qemu-devel] [PATCH v12 00/30] SDHCI: clean v1/2 Specs, UHS-I cards tuning sequence

On Fri, 02/09 11:54, Philippe Mathieu-Daudé wrote: > This series is expected to be taken by Paolo. > > It includes the last versions of both series: > - SDHCI: clean v1/v2 Specs (part 2) > - SDHCI: add tuning sequence for UHS-I cards (part 3) > > Since v11: > - rebased due to conflict (IMX_USDHC

Re: [Qemu-devel] [PULL v3 00/20] Miscellaneous patches for 2018-02-07

On Sat, 02/10 07:28, Markus Armbruster wrote: > Peter Maydell writes: > > > On 9 February 2018 at 05:03, Markus Armbruster wrote: > >> The following changes since commit > >> 008a51bbb343972dd8cf09126da8c3b87f4e1c96: > >> > >> Merge

Re: [Qemu-devel] Functional tests (AKA Avocado-based tests)

On Thu, Jan 18, 2018 at 5:07 PM, Amador Pahim wrote: > Expanding on that, the vmimage lib downloads and caches the so called > "cloud images" from distros own repositories. Here's[1] some > documentation with usage examples, including one example on how to add > your own image

Re: [Qemu-devel] [PATCH v6 00/28] Migration: postcopy failure recovery

On Fri, Feb 9, 2018 at 2:07 PM, Peter Xu wrote: > On Thu, Feb 08, 2018 at 03:25:21AM -0800, no-re...@patchew.org wrote: >> Hi, >> >> This series failed docker-mingw@fedora build test. Please find the testing >> commands and >> their output below. If you have Docker installed,

[Qemu-devel] [PATCH v7 3/3] docs: Document share-rw property more thoroughly

Suggested-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- docs/qemu-block-drivers.texi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/qemu-block-drivers.texi b/docs/qemu-block-drivers.texi index cd74767ed3..f1793

[Qemu-devel] [PATCH v7 1/3] qemu-img.texi: Clean up parameter list

Split options out of the "@table @var" section and create a "@table @option", then use whitespaces and blank lines consistently. Suggested-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat

[Qemu-devel] [PATCH v7 0/3] qemu-img: Document --force-share / -U

v7: Tweak wording again "allowing concurrent writers" -> "allowing other QEMU processes to open it in write mode". [Eric, Stefan, Kevin] Add patch to document share-rw. [Stefan] v6: Tweak wording ("concurrent writers"). [Max] Fam Zheng (3): qemu-img.tex

[Qemu-devel] [PATCH v7 2/3] qemu-img: Document --force-share / -U

Signed-off-by: Fam Zheng <f...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> --- qemu-img.texi | 8 1 file changed, 8 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 60a0e080c6..8a26400adb 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

Re: [Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

On Thu, 02/01 11:44, Stefan Hajnoczi wrote: > On Wed, Jan 31, 2018 at 03:22:49PM +0100, Kevin Wolf wrote: > > Am 31.01.2018 um 15:12 hat Stefan Hajnoczi geschrieben: > > > There should be a separate paragraph in docs/qemu-block-drivers.texi > > > explaining that share-rw=on can be used safely with

Re: [Qemu-devel] [PATCH 3/3] build-sys: enable sanitizers by default with --enable-debug

On Thu, 02/08 20:03, Marc-André Lureau wrote: > Hi > > On Thu, Feb 8, 2018 at 6:46 PM, Paolo Bonzini wrote: > > On 08/02/2018 17:23, Marc-André Lureau wrote: > >> The original commit 247724cb302af5d70c8853154b640dfabf2bbb56 was meant > >> to enable sanitizers by default when

Re: [Qemu-devel] [PATCH] block: unify blocksize types

On Thu, 02/08 14:28, Piotr Sarna wrote: > BlockSizes structure used in block size probing has uint32_t types > for logical and physical sizes. These fields are wrongfully assigned > to uint16_t in BlockConf, which results, among other errors, > in assigning 0 instead of 65536 (which will be the

[Qemu-devel] [PULL 16/16] docs: Add docs/devel/testing.rst

on how to run existing tests and how to write new test cases, without going into the frameworks themselves. The VM based testing section is moved from tests/vm/README which now is a single line pointing to the new doc. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PULL 14/16] docs: Add section for NVMe VFIO driver

Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-9-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- docs/qemu-block-drivers.texi | 37

[Qemu-devel] [PULL 12/16] qemu-img: Map bench buffer

Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-7-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- qemu-img.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) d

[Qemu-devel] [PULL 09/16] block: Add VFIO based NVMe driver

Bonzini <pbonz...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Message-Id: <20180116060901.17413-4-f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- MAINTAINERS |6 + block/Makefi

[Qemu-devel] [PULL 10/16] block: Introduce buf register API

Allow block driver to map and unmap a buffer for later I/O, as a performance hint. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-5-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.

[Qemu-devel] [PULL 08/16] util: Introduce vfio helpers

This is a library to manage the host vfio interface, which could be used to implement userspace device driver code in QEMU such as NVMe or net controllers. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <201801160

[Qemu-devel] [PULL 07/16] stubs: Add stubs for ram block API

These functions will be wanted by block-obj-y but the actual definition is in obj-y, so stub them to keep the linker happy. Signed-off-by: Fam Zheng <f...@redhat.com> Acked-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id: <20180110091846.10699-2-f...@redhat.com> Reviewed-b

Re: [Qemu-devel] [PATCH v3] docs: Add docs/devel/testing.rst

On Wed, 02/07 15:31, Paolo Bonzini wrote: > On 01/02/2018 03:20, Fam Zheng wrote: > > To make our efforts on QEMU testing easier to consume by contributors, > > let's add a document. For example, Patchew reports build errors on > > patches that should be relatively easy to

[Qemu-devel] [PULL 13/16] block: Move NVMe constants to a separate header

Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-8-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- block/nvme.c | 7 +- hw

[Qemu-devel] [PULL 05/16] coroutine-lock: make qemu_co_enter_next thread-safe

mments of qemu_co_queue_next and qemu_co_queue_restart_all are adjusted to clarify the difference. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id: <20180203153935.8056-5-pbonz...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Fam Zheng <

[Qemu-devel] [PULL 15/16] qapi: Add NVMe driver options to the schema

Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-10-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- qapi/block-core.json | 17 - 1 file changed, 16 insertions

[Qemu-devel] [PULL 11/16] block/nvme: Implement .bdrv_(un)register_buf

Forward these two calls to the IOVA manager. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-6-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- block/nvme.c | 24

[Qemu-devel] [PULL 03/16] lockable: add QemuLockable

<pbonz...@redhat.com> Message-Id: <20180203153935.8056-3-pbonz...@redhat.com> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.

[Qemu-devel] [PULL 01/16] docker: change Fedora base image to fedora:27

ot;test-debug" test was failing. Use "27" to improve reproducibility and make it clear when the image is obsolete. Cc: Fam Zheng <f...@redhat.com> Cc: Marc-André Lureau <marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id:

[Qemu-devel] [PULL 06/16] curl: convert to CoQueue

edhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id: <20180203153935.8056-6-pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- block/curl.c | 20 1 file changed, 4 insert

[Qemu-devel] [PULL 04/16] coroutine-lock: convert CoQueue to use QemuLockable

. Use QemuLockable so that the CoQueue can interchangeably use CoMutex or QemuMutex. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id: <20180203153935.8056-4-pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com&g

[Qemu-devel] [PULL 02/16] test-coroutine: add simple CoMutex test

com> Message-Id: <20180203153935.8056-2-pbonz...@redhat.com> Reviewed-by: Richard Henderson <richard.hender...@linaro.org> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- tests/test-coroutine.c | 50

[Qemu-devel] [PULL 00/16] Docker and block patches

Fam Zheng (10): stubs: Add stubs for ram block API util: Introduce vfio helpers block: Add VFIO based NVMe driver block: Introduce buf register API block/nvme: Implement .bdrv_(un)register_buf qemu-img: Map bench buffer block

Re: [Qemu-devel] [PATCH 1/2] scsi: add unrealize method for SCSI devices

evices is kept in scsi-bus.c. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com>

Re: [Qemu-devel] [PATCH 2/2] scsi: add block job opblockers for scsi-block

Suggested-by: Karen Noel <kn...@redhat.com> :) > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Though I have one comment below. > --- > block/block-backend.c | 9 ++ > hw/scsi/scsi-disk.c| 62 >

Re: [Qemu-devel] [PATCH] block: early check for blockers on drive-mirror

r(DriveMirror *arg, Error **errp) > return; > } > > +/* Early check to avoid creating target */ > +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) { > +return; > +} > + > aio_context = bdrv_get_aio_context(bs); >

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

On Wed, Feb 7, 2018 at 9:10 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 07.02.2018 um 13:39 hat Fam Zheng geschrieben: >> On Wed, Feb 7, 2018 at 6:51 PM, Kevin Wolf <kw...@redhat.com> wrote: >> > Am 07.02.2018 um 02:48 hat Fam Zheng geschrieben: >> >> O

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

On Wed, Feb 7, 2018 at 6:51 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 07.02.2018 um 02:48 hat Fam Zheng geschrieben: >> On Tue, Feb 6, 2018 at 11:32 PM, Kevin Wolf <kw...@redhat.com> wrote: >> > Am 18.04.2017 um 16:30 hat Fam Zheng geschrieben: >> >

Re: [Qemu-devel] [PATCH v5 0/5] coroutine-lock: polymorphic CoQueue

On Sat, 02/03 10:39, Paolo Bonzini wrote: > There are cases in which a queued coroutine must be restarted from > non-coroutine context (with qemu_co_enter_next). In this cases, > qemu_co_enter_next also needs to be thread-safe, but it cannot use a > CoMutex and so cannot qemu_co_queue_wait. This

Re: [Qemu-devel] [PATCH for-2.9-rc5 v4 2/2] block: Drain BH in bdrv_drained_begin

On Tue, Feb 6, 2018 at 11:32 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 18.04.2017 um 16:30 hat Fam Zheng geschrieben: >> During block job completion, nothing is preventing >> block_job_defer_to_main_loop_bh from being called in a nested >> aio_poll(), which is a tr

[Qemu-devel] [PATCH v3 2/2] README: Document 'git-publish' workflow

Signed-off-by: Fam Zheng <f...@redhat.com> --- README | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/README b/README index b92a07a61a..d1a944ce20 100644 --- a/README +++ b/README @@ -56,7 +56,7 @@ The QEMU source code is maintained under t

[Qemu-devel] [PATCH v3 0/2] Add git-publish config file

v3: Fix trivial hunk placement. [Michael] Fix PPC sub-list. [Michael] v2: Add README paragraph [Marc-André, Stefan] Fix 'trivial' profile [Marc-André] Rename profiles [Stefan] Fam Zheng (2): Add a git-publish configuration file README: Document 'git-publish' workflow

[Qemu-devel] [PATCH v3 1/2] Add a git-publish configuration file

is a handy method to create the Cc list. [1]: https://github.com/stefanha/git-publish Signed-off-by: Fam Zheng <f...@redhat.com> --- .gitpublish | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 .gitpublish diff

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

On Wed, Jan 31, 2018 at 6:06 PM, Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > Hi > > On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng <f...@redhat.com> wrote: >> git-publish [1] is a convenient tool to send patches and has been >> popular among QEMU devel

Re: [Qemu-devel] [PATCH] Add a git-publish configuration file

On Thu, Feb 1, 2018 at 6:46 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Wed, Jan 31, 2018 at 11:06:05AM +0100, Marc-André Lureau wrote: >> Hi >> >> On Wed, Jan 31, 2018 at 6:33 AM, Fam Zheng <f...@redhat.com> wrote: >> > git-publish [1] is a co

Re: [Qemu-devel] [PATCH v4 0/5] coroutine-lock: polymorphic CoQueue

gt; > total: 1 errors, 0 warnings, 74 lines checked I think we should fix this one too. Otherwise, Reviewed-by: Fam Zheng <f...@redhat.com> > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHEC

[Qemu-devel] [PATCH v2 0/2] Add git-publish config file

v2: Add README paragraph [Marc-André, Stefan] Fix 'trivial' profile [Marc-André] Rename profiles [Stefan] Fam Zheng (2): Add a git-publish configuration file README: Document 'git-publish' workflow .gitpublish | 58 ++ README

[Qemu-devel] [PATCH v2 2/2] README: Document 'git-publish' workflow

Signed-off-by: Fam Zheng <f...@redhat.com> --- .gitpublish | 1 + README | 30 +- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/.gitpublish b/.gitpublish index 170bd2ed48..7542e878fc 100644 --- a/.gitpublish +++ b/.gitpublish @@ -26,6

[Qemu-devel] [PATCH v3] iotests: Fix CID for VMDK afl image

unc $ mv fix.vmdk afl9.vmdk $ bzip2 afl9.vmdk Signed-off-by: Fam Zheng <f...@redhat.com> --- v3: Skip test when ENOMEM. [Max, Eric] v2: Fix commit message "qcow2 -> vmdk". [Kevin] Revert 76bf133c4. --- tests/qemu-iotests/059 | 5 ++--

[Qemu-devel] [PATCH v2 1/2] Add a git-publish configuration file

is a handy method to create the Cc list. [1]: https://github.com/stefanha/git-publish Signed-off-by: Fam Zheng <f...@redhat.com> --- .gitpublish | 57 + 1 file changed, 57 insertions(+) create mode 100644 .gitpublish diff --git a/.gitp

Re: [Qemu-devel] [PATCH v2 02/19] Clean up includes

On Wed, Jan 31, 2018 at 11:48 PM, Thomas Huth wrote: > On 31.01.2018 15:48, Markus Armbruster wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes, with

[Qemu-devel] [PATCH v3] docs: Add docs/devel/testing.rst

on how to run existing tests and how to write new test cases, without going into the frameworks themselves. The VM based testing section is moved from tests/vm/README which now is a single line pointing to the new doc. Signed-off-by: Fam Zheng <f...@redhat.com> Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v2] docs: Add docs/devel/testing.rst

On Wed, Jan 31, 2018 at 10:24 PM, Eric Blake <ebl...@redhat.com> wrote: > On 01/30/2018 09:28 PM, Fam Zheng wrote: >> To make our efforts on QEMU testing easier to consume by contributors, >> let's add a document. For example, Patchew reports build errors on >> patche

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

On Thu, Feb 1, 2018 at 2:58 AM, Max Reitz <mre...@redhat.com> wrote: > On 2018-01-30 07:25, Fam Zheng wrote: >> This reverts commit 76bf133c4 which updated the reference output, and >> fixed the reference image, because the code path we want to exercise is >> actu

Re: [Qemu-devel] [PATCH v2] docs: Add docs/devel/testing.rst

On Wed, Jan 31, 2018 at 9:49 PM, Andrew Jones <drjo...@redhat.com> wrote: > On Wed, Jan 31, 2018 at 11:28:00AM +0800, Fam Zheng wrote: >> +On top of libqtest, a higher level library, ``libqos``, was created to >> +encapsulate common tasks of device drivers, such

[Qemu-devel] [PATCH] Add a git-publish configuration file

is a handy method to create the Cc list. [1]: https://github.com/stefanha/git-publish Signed-off-by: Fam Zheng <f...@redhat.com> --- .gitpublish | 57 + 1 file changed, 57 insertions(+) create mode 100644 .gitpublish diff --git a/.gitp

[Qemu-devel] [PATCH v2] docs: Add docs/devel/testing.rst

on how to run existing tests and how to write new test cases, without going into the frameworks themselves. The VM based testing section is moved from tests/vm/README which now is a single line pointing to the new doc. Signed-off-by: Fam Zheng <f...@redhat.com> --- v2: Fix spelling

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 6:36 PM, Alex Bennée <alex.ben...@linaro.org> wrote: > Fam Zheng <f...@redhat.com> writes: >> +Prerequisites >> +- >> + >> +Install "docker" with the system package manager and start the Docker >> service &

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 7:04 PM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Jan 29, 2018 at 11:31:33AM +0800, Fam Zheng wrote: > > Thanks for writing this! > > I have only reviewed some parts in detail. Thanks for the review! I've made all the fixes (except f

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 10:51 PM, Eric Blake <ebl...@redhat.com> wrote: > On 01/28/2018 09:31 PM, Fam Zheng wrote: >> To make our efforts on QEMU testing easier to consume by contributors, >> let's add a document. For example, Patchew reports build errors on >> patch

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

On Tue, Jan 30, 2018 at 9:48 PM, Eric Blake <ebl...@redhat.com> wrote: > On 01/30/2018 12:25 AM, Fam Zheng wrote: >> This reverts commit 76bf133c4 which updated the reference output, and >> fixed the reference image, because the code path we want to exercise is >> actu

[Qemu-devel] [Bug 1745312] Re: Regression report: Disk subsystem I/O failures/issues surfacing in DOS/early Windows [two separate issues: one bisected, one root-caused]

QEMU ignores the CHS numbers in VMDK images. From the report, it seems VirtualBox uses it. So like what you've discovered, for QEMU the right thing to do for such a guest would be setting the correct values explicitly from the command line, rather than let it decide (guess). I have no idea about

Re: [Qemu-devel] [PATCH v5 2/2] qemu-img: Document --force-share / -U

On Tue, Jan 30, 2018 at 12:01 AM, Max Reitz <mre...@redhat.com> wrote: > On 2017-12-26 03:52, Fam Zheng wrote: >> Signed-off-by: Fam Zheng <f...@redhat.com> >> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> >> Reviewed-by: Kashyap Chamarthy <kcham..

[Qemu-devel] [PATCH v6 2/2] qemu-img: Document --force-share / -U

Signed-off-by: Fam Zheng <f...@redhat.com> Signed-off-by: Kevin Wolf <kw...@redhat.com> --- qemu-img.texi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 60a0e080c6..ec7e2f5d1e 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@

[Qemu-devel] [PATCH v6 0/2] qemu-img: Document --force-share / -U

v6: Tweak wording ("concurrent writers"). [Max] Fam Zheng (2): qemu-img.texi: Clean up parameter list qemu-img: Document --force-share / -U qemu-img.texi | 73 +-- 1 file changed, 46 insertions(+), 27 deletions(-) -- 2.14.3

[Qemu-devel] [PATCH v6 1/2] qemu-img.texi: Clean up parameter list

Split options out of the "@table @var" section and create a "@table @option", then use whitespaces and blank lines consistently. Suggested-by: Kevin Wolf <kw...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat

Re: [Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

On Mon, Jan 29, 2018 at 11:49 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 24.01.2018 um 05:42 hat Fam Zheng geschrieben: >> The descriptor block in the image, which includes the CID to verify, has been >> invalid since the reference image was added. Since commit 9877

[Qemu-devel] [PATCH] iotests: Fix CID for VMDK afl image

unc $ mv fix.vmdk afl9.vmdk $ bzip2 afl9.vmdk Signed-off-by: Fam Zheng <f...@redhat.com> --- v2: Fix commit message "qcow2 -> vmdk". [Kevin] Revert 76bf133c4. --- tests/qemu-iotests/059.out | 2 +- tests/qemu-iotests/sample_images/afl9.vmdk.bz2 |

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 2:56 PM, Thomas Huth <th...@redhat.com> wrote: > On 29.01.2018 04:31, Fam Zheng wrote: > [...] >> +1. Create a new source file. For example, ``tests/test-foo.c``. > [...] >> +1. Create a new source file for the test. (More than one file can be ad

Re: [Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

On Mon, Jan 29, 2018 at 11:31 AM, Fam Zheng <f...@redhat.com> wrote: > +VM testing > +== I should have noted that this section is not new but an md->rst convert of ./tests/vm/README. The latter should be made a pointer to this one once it is merged. Fam

[Qemu-devel] [PATCH] docs: Add docs/devel/testing.rst

on how to run existing tests and how to write new test cases, without going into the frameworks themselves. Signed-off-by: Fam Zheng <f...@redhat.com> --- To reviewers: though we don't have dedicate maintainers on tests or docs, there are a few sections that are closely related to maintained

Re: [Qemu-devel] [PATCH 2/5] lockable: add QemuLockable

On Fri, Jan 26, 2018 at 1:59 AM, Paolo Bonzini wrote: > QemuLockable is a polymorphic lock type that takes an object and > knows which function to use for locking and unlocking. The > implementation could use C11 _Generic, but since the support is > not very widespread I am

Re: [Qemu-devel] [PATCH 2/5] lockable: add QemuLockable

On Fri, Jan 26, 2018 at 1:59 AM, Paolo Bonzini wrote: > diff --git a/include/qemu/lockable.h b/include/qemu/lockable.h > new file mode 100644 > index 00..f527d0ddb2 > --- /dev/null > +++ b/include/qemu/lockable.h > @@ -0,0 +1,88 @@ > +/* > + * Polymorphic locking

Re: [Qemu-devel] [PATCH v2 0/4] coroutine-lock: polymorphic CoQueue

On Tue, Jan 16, 2018 at 10:23 PM, Paolo Bonzini wrote: > There are cases in which a queued coroutine must be restarted from > non-coroutine context (with qemu_co_enter_next). In this cases, > qemu_co_enter_next also needs to be thread-safe, but it cannot use a > CoMutex and

Re: [Qemu-devel] [PULL 00/14] Block and docker patches

On Thu, Jan 25, 2018 at 9:51 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 25 January 2018 at 05:46, Fam Zheng <f...@redhat.com> wrote: >> The following changes since commit 834a336eb911db8a8ca00e760ee6a85faca19414: >> >> Merge remote-tracking bran

[Qemu-devel] [PULL 13/14] docs: Add section for NVMe VFIO driver

Signed-off-by: Fam Zheng <f...@redhat.com> Message-Id: <20180110091846.10699-9-f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-9-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- doc

[Qemu-devel] [PULL 09/14] block: Introduce buf register API

Allow block driver to map and unmap a buffer for later I/O, as a performance hint. Signed-off-by: Fam Zheng <f...@redhat.com> Message-Id: <20180110091846.10699-5-f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-5-f...@r

[Qemu-devel] [PULL 12/14] block: Move NVMe constants to a separate header

Signed-off-by: Fam Zheng <f...@redhat.com> Message-Id: <20180110091846.10699-8-f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-8-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- block/nvme.c

[Qemu-devel] [PULL 05/14] curl: convert to CoQueue

edhat.com> Message-Id: <20180116142316.30486-5-pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- block/curl.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/block/curl.c b

[Qemu-devel] [PULL 14/14] qapi: Add NVMe driver options to the schema

Signed-off-by: Fam Zheng <f...@redhat.com> Message-Id: <20180110091846.10699-10-f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-10-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- qapi/block-core.

[Qemu-devel] [PULL 03/14] coroutine-lock: convert CoQueue to use QemuLockable

. Use QemuLockable so that the CoQueue can interchangeably use CoMutex or QemuMutex. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id: <20180116142316.30486-3-pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com>

[Qemu-devel] [PULL 08/14] block: Add VFIO based NVMe driver

Bonzini <pbonz...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> Message-Id: <20180110091846.10699-4-f...@redhat.com> Message-Id: <20180116060901.17413-4-f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com

[Qemu-devel] [PULL 11/14] qemu-img: Map bench buffer

Signed-off-by: Fam Zheng <f...@redhat.com> Message-Id: <20180110091846.10699-7-f...@redhat.com> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> Message-Id: <20180116060901.17413-7-f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> --- qemu-img.c |

[Qemu-devel] [PULL 04/14] coroutine-lock: make qemu_co_enter_next thread-safe

mments of qemu_co_queue_next and qemu_co_queue_restart_all are adjusted to clarify the difference. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id: <20180116142316.30486-4-pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@

[Qemu-devel] [PULL 02/14] lockable: add QemuLockable

cquire it. The next patch will do this for CoQueue. Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Message-Id: <20180116142316.30486-2-pbonz...@redhat.com> Reviewed-by: Fam Zheng <f...@redhat.com> Signed-off-by: Fam Zheng <f...@redhat.com> ---

<    4   5   6   7   8   9   10   11   12   13   >