Re: [Qemu-devel] [PATCH] handle_aiocb_rw() can't distinguish betweenan error and 0 bytes transferred

2015-09-30 Thread Guangmu Zhu
, are some other Windows types such as DWORD not preferred to standard C types? I will send a v3 patch based on your fix after a week for I'll travel for a week in coming National Day holiday. Thanks again for you patient. Sincerely. Guangmu Zhu Hi, thanks

Re: [Qemu-devel] [PATCH] No FreeWriterMetadata() after GatherWriterMetadata() in requester.cpp

2015-09-28 Thread Guangmu Zhu
I sent the patch some days ago and received no response. I have no idea if this means the patch is not Ok or just no one had interest in it... Sincerely. Guangmu Zhu -- FreeWriterMetadata() should be called if GatherWriterMetadata() succeeded. Signed

[Qemu-devel] [PATCH] handle_aiocb_rw() can't distinguish between an error and 0 bytes transferred

2015-09-25 Thread Guangmu Zhu
The handle_aiocb_rw() can't distinguish between an error and 0 bytes transferred. diff --git a/block/raw-win32.c b/block/raw-win32.c index 68f2338..569dda2 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -60,11 +60,13 @@ typedef struct BDRVRawState { * Returns the number of bytes

Re: [Qemu-devel] [PATCH] handle_aiocb_rw() can't distinguish between an error and 0 bytes transferred

2015-09-25 Thread Guangmu Zhu
Correct patch format. Signed-off-by: Guangmu Zhu <guangmu...@gmail.com> --- block/raw-win32.c | 48 ++-- 1 file changed, 30 insertions(+), 18 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index 68f2338..569dda2 100644 --- a

Re: [Qemu-devel] [PATCH] No FreeWriterMetadata() after GatherWriterMetadata() in requester.cpp

2015-09-25 Thread Guangmu Zhu
Correct patch format. Signed-off-by: Guangmu Zhu <guangmu...@gmail.com> --- qga/vss-win32/requester.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 9b3e310..337f722 100644 --- a/qga/vss-win32/request

[Qemu-devel] [PATCH] No FreeWriterMetadata() after GatherWriterMetadata() in requester.cpp

2015-09-25 Thread Guangmu Zhu
FreeWriterMetadata() should be called if GatherWriterMetadata() succeeded. diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 9b3e310..337f722 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -47,6 +47,7 @@ static struct QGAVSSContext {

Re: [Qemu-devel] No error report when using the qemu-img.exetoconvert a disk to vmdk format which is saved on a disk that has nomorespace

2015-09-24 Thread Guangmu Zhu
Hi Kevin, I tried the patch you provide, and I haven't seen that problem yet. If the disk space is full, an error will be reported with the message "Invalid argument" and the program will stop. Will you merge the patch to the master? Thanks. Guangmu Zhu diff --git a/block/raw

Re: [Qemu-devel] No error report when using the qemu-img.exe toconvert a disk to vmdk format which is saved on a disk that has no morespace

2015-09-23 Thread Guangmu Zhu
emu_coroutine_enter(co->coroutine, NULL); } 5. Finally the return value(zero) will be stored in "co.ret" in function "bdrv_co_io_em". However, what would happen if the req haven't done but the function "bdrv_co_io_em" returned? The write operation would return

Re: [Qemu-devel] No error report when using the qemu-img.exe toconvert a disk to vmdk format which is saved on a disk that has no morespace

2015-09-23 Thread Guangmu Zhu
Correct a mistake: So though the "count" would be "-EINVAL" if error occurred while writing some file, the return value will always be zero. Maybe I missed something? Sorry. Guangmu Zhu - Thanks for your reply. I read t

Re: [Qemu-devel] No error report when using the qemu-img.exe toconvert a disk to vmdk format which is saved on a disk that has no morespace

2015-09-23 Thread Guangmu Zhu
If the "BlockDriver" is "bdrv_vmdk", the function "vmdk_co_write" will be called instead. In function "vmdk_write_extent" I see "ret = bdrv_pwrite(extent->file, write_offset, write_buf, write_len);". So the "

Re: [Qemu-devel] No error report when using the qemu-img.exetoconvert a disk to vmdk format which is saved on a disk that has nomorespace

2015-09-23 Thread Guangmu Zhu
I'll try the patch and report in a week for I'm too busy these days. And if I could, I would like to help to maintain the Windows backend. Sincerely. Guangmu Zhu - Am 23.09.2015 um 13:30 hat Guangmu Zhu geschrieben: > If the "Blo

[Qemu-devel] No error report when using the qemu-img.exe to convert a disk to vmdk format which is saved on a disk that has no more space

2015-09-22 Thread Guangmu Zhu
t_blk); ++ 1833: ++ 1834:bdrv_set_on_error(out_bs, BLOCKDEV_ON_ERROR_REPORT, BLOCKDEV_ON_ERROR_REPORT); Thanks, Guangmu Zhu