Re: [Qemu-devel] [Qemu-block] [PATCH v2] nvme: add Get/Set Feature Timestamp support

2019-06-04 Thread Heitke, Kenneth
On 6/4/2019 3:13 AM, Klaus Birkelund wrote: On Tue, Jun 04, 2019 at 10:46:45AM +0200, Kevin Wolf wrote: Am 04.06.2019 um 10:28 hat Klaus Birkelund geschrieben: On Mon, Jun 03, 2019 at 09:30:53AM -0600, Heitke, Kenneth wrote: On 6/3/2019 5:14 AM, Kevin Wolf wrote: Am 28.05.2019 um 08:18

Re: [Qemu-devel] [PATCH v2] nvme: add Get/Set Feature Timestamp support

2019-06-03 Thread Heitke, Kenneth
On 6/3/2019 5:14 AM, Kevin Wolf wrote: Am 28.05.2019 um 08:18 hat Klaus Birkelund geschrieben: On Mon, May 20, 2019 at 11:40:30AM -0600, Kenneth Heitke wrote: Signed-off-by: Kenneth Heitke diff --git a/hw/block/nvme.h b/hw/block/nvme.h index 56c9d4b4b1..d7277e72b7 100644 ---

Re: [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB

2019-05-18 Thread Heitke, Kenneth
On 5/18/2019 1:39 AM, Klaus Birkelund Jensen wrote: `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of `qemu_iovec_*from*_buf` when the request involved the controller memory buffer. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-17 Thread Heitke, Kenneth
On 5/17/2019 12:24 AM, Klaus Birkelund wrote: On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote: Hi Kenneth, On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: Hi Klaus, thank you for you review. I have one comment inline On 5/14/2019 12:02 AM, Klaus Birkelund

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-17 Thread Heitke, Kenneth
On 5/17/2019 12:24 AM, Klaus Birkelund wrote: On Fri, May 17, 2019 at 07:35:04AM +0200, Klaus Birkelund wrote: Hi Kenneth, On Thu, May 16, 2019 at 05:24:47PM -0600, Heitke, Kenneth wrote: Hi Klaus, thank you for you review. I have one comment inline On 5/14/2019 12:02 AM, Klaus Birkelund

Re: [Qemu-devel] [Qemu-block] [PATCH] nvme: add Get/Set Feature Timestamp support

2019-05-16 Thread Heitke, Kenneth
Hi Klaus, thank you for you review. I have one comment inline On 5/14/2019 12:02 AM, Klaus Birkelund wrote: On Fri, Apr 05, 2019 at 03:41:17PM -0600, Kenneth Heitke wrote: Signed-off-by: Kenneth Heitke --- hw/block/nvme.c | 120 +-