[Qemu-devel] [PATCH v2] configure: Check if struct fsxattr is available from linux header

nu.org CC: Markus Armbruster <arm...@redhat.com> CC: Peter Maydell <peter.mayd...@linaro.org> CC: Stefan Weil <s...@weilnetz.de> Signed-off-by: Jan Vesely <jano.ves...@gmail.com> --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/confi

Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

On Fri, 2016-04-29 at 15:49 +0100, Peter Maydell wrote: > On 29 April 2016 at 15:31, Stefan Weil wrote: > > > > Is it a bug of the system headers? Or simply a design which > > requires users to be careful when including certain header files? > > > > Both

[Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

r <arm...@redhat.com> CC: Peter Maydell <peter.mayd...@linaro.org> CC: Stefan Weil <s...@weilnetz.de> Signed-off-by: Jan Vesely <jano.ves...@gmail.com> --- One can argue that the failure only happens for invalid linux-headers, xfsprogs combinations, feel free to reject the p

Re: [Qemu-devel] [PATCH] po/Makefile: call rm -f directly

On Sat, 2016-03-19 at 21:58 -0400, Jan Vesely wrote: > Default variables are undefined in rules.mak and this is what the > rest > of the build system uses. > Fixes make clean in ./po/ > > Signed-off-by: Jan Vesely <jano.ves...@gmail.com> > --- >  po/Makefile | 2 +-

Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

On Tue, 2016-04-12 at 17:09 -0400, Jan Vesely wrote: > On Sat, 2016-03-19 at 21:18 -0400, Jan Vesely wrote: > > > > Fixes build with new linux headers. > > > > Signed-off-by: Jan Vesely <jano.ves...@gmail.com> > > --- > > linux-headers-4.5 and xfspr

Re: [Qemu-devel] [PATCH] configure: Check if struct fsxattr is available from linux header

On Sat, 2016-03-19 at 21:18 -0400, Jan Vesely wrote: > Fixes build with new linux headers. > > Signed-off-by: Jan Vesely <jano.ves...@gmail.com> > --- > linux-headers-4.5 and xfsprogs-3.2.4 in my case > >  configure | 18 ++ >  1 file changed, 18

[Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration

Signed-off-by: Jan Vesely jano.ves...@gmail.com --- v2: add usb_mouse_properties use macros for bmAttributes v3: rebase v4: add compat property rebase hw/i386/pc_piix.c | 4 hw/usb/dev-hid.c | 71 ++- 2 files changed, 74

[Qemu-devel] [PATCH v3 3/3] usb-hid: Add high speed keyboard configuration

Signed-off-by: Jan Vesely jano.ves...@gmail.com --- v2: rebase v3: add compat property rebase hw/i386/pc_piix.c | 4 hw/usb/dev-hid.c | 66 ++- 2 files changed, 69 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw

[Qemu-devel] [PATCH v3 1/3] usb-hid: Move descriptor decision to usb-hid initfn

Signed-off-by: Jan Vesely jano.ves...@gmail.com --- v2: rebase v3: fixup error handling hw/usb/dev-hid.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 467ec86..5d37d63 100644 --- a/hw/usb

Re: [Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration

On Fri, 2014-09-26 at 09:06 +0200, Gerd Hoffmann wrote: On Do, 2014-09-25 at 17:38 -0400, Jan Vesely wrote: v2: add usb_mouse_properties use macros for bmAttributes v3: rebase v4: rebase patch looks good, the only thing missing is the compat property, to make sure qemu machine

[Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

v2: rebase Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 467ec86..90746ed 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev

[Qemu-devel] [PATCH v2 3/3] usb-hid: Add high speed keyboard configuration

v2: rebase Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index a946528..7b67489 100644 --- a/hw/usb/dev-hid.c

[Qemu-devel] [PATCH v4 2/3] usb-hid: Add high speed mouse configuration

v2: add usb_mouse_properties use macros for bmAttributes v3: rebase v4: rebase Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 71 +++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b

Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

Hi Gerd, sorry for taking so long to get back to this. My schedule has been super busy past couple of months. I have rebased the patches and moved the usb version desc selection to hid_initfn as you suggested. I also made the changes follow the tablet example as closely as possible I tested the

[Qemu-devel] [PATCH 3/3] usb-hid: Add high speed keyboard configuration

Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 643b013..ac7e393 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb

[Qemu-devel] [PATCH v3 2/3] usb-hid: Add high speed mouse configuration

v2: add usb_mouse_properties use macros for bmAttributes v3: rebase Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 71 +++- 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev

[Qemu-devel] [PATCH 1/3] usb-hid: Move descriptor decision to usb-hid initfn

Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 38 +- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 67a57f1..b3d02b2 100644 --- a/hw/usb/dev-hid.c +++ b/hw/usb/dev-hid.c

[Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration

v2: add usb_mouse_properties use macros for bmAttributes Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 73 +--- 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c

[Qemu-devel] [PATCH v2 2/2] usb-hid: Add high speed keyboard configuration

v2: add usb_keyboard_properties use macros for bmAttributes Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 73 +--- 1 file changed, 65 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c

[Qemu-devel] [PATCH 1/2] usb-hid: Add high speed mouse configuration

Signed-off-by: Jan Vesely jano.ves...@gmail.com --- Tested on Ubuntu, Fedora, and HelenOS. hw/usb/dev-hid.c | 67 +--- 1 file changed, 59 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 2966066..954cde1

[Qemu-devel] [PATCH 2/2] usb-hid: Add high speed keyboard configuration

Signed-off-by: Jan Vesely jano.ves...@gmail.com --- Tested on Ubuntu, Fedora, and HelenOS. hw/usb/dev-hid.c | 67 +--- 1 file changed, 59 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 954cde1..53e7bd3

Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

glad I could help the original bug report is here: https://bugs.launchpad.net/qemu/+bug/757654 should I update it? or will it be updated when the patch reaches master? j. On Mon, May 9, 2011 at 1:43 PM, Gerd Hoffmann kra...@redhat.com wrote: On 05/09/11 12:16, Jan Vesely wrote: UHCI host

Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

UHCI host controller status register indicates error and an interrupt is triggered on BABBLE and STALL errors. Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb-uhci.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index a65e0b3

Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

hi, using the modified (single line) patch only works half-way, it sets the value in status register (guess that's what that line does :)) but hw interrupt is not generated. I tried adding uhci_update_irq and this patch: diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index a65e0b3..1e9c1e7 100644

Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

On Sat, Apr 16, 2011 at 8:33 AM, Brad Hards br...@frogmouth.net wrote: On Sat, 16 Apr 2011 06:57:00 am Jan Vesely wrote: +        s-status |= UHCI_STS_USBERR; This is per UHCI 1.1D Section 4.1.5. Looks good. +        *int_mask |= 0x02; +        if (td-ctrl TD_CTRL_IOC

[Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

Hi, I'm sending a patch for bug #757654. The bug does not really break anything it just makes USB error detection harder. It's a quick fix and might need some polishing but it works (I am currently using it). thx, jan PS: I guess you need this line: Signed-off-by: Jan Vesely jano.ves