[Qemu-devel] [PATCH v3] Fix input-linux reading from device

2017-03-27 Thread Javier Celaya
to be read to fill up a whole event, and then handle it. Changes from v1 to v2: - Fix: Calculate offset on each iteration Changes from v2 to v3: - Fix coding style - Store offset instead of bytes to be read Signed-off-by: Javier Celaya <jcel...@gmail.com> --- ui/input-linux.c | 17 --

Re: [Qemu-devel] [PATCH v2] Fix input-linux reading from device

2017-03-27 Thread Javier Celaya
Hi Javi 2017-03-27 12:11 GMT+02:00 Gerd Hoffmann <kra...@redhat.com>: > On So, 2017-03-26 at 11:53 +0200, Javier Celaya wrote: > > The evdev devices in input-linux.c are read in blocks of one whole > > event. If there are not enough bytes available, they are discarded, >

[Qemu-devel] [PATCH v2] Fix input-linux reading from device

2017-03-26 Thread Javier Celaya
to be read to fill up a whole event, and then handle it. Signed-off-by: Javier Celaya <jcel...@gmail.com> --- ui/input-linux.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/ui/input-linux.c b/ui/input-linux.c index ac31f47719..02b0d4b2fe 100644 --- a/ui

[Qemu-devel] [PATCH] Fix input-linux reading from device

2017-03-25 Thread Javier Celaya
to be read to fill up a whole event, and then handle it. Signed-off-by: Javier Celaya <jcel...@gmail.com> --- ui/input-linux.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ui/input-linux.c b/ui/input-linux.c index ac31f47719..33bcdb00c6 100644 --- a/ui

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-28 Thread Javier Celaya
/26/2015 01:48 AM, Javier Celaya wrote: Sorry, I forgot to patch the command-line help. Hope it helps. Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. How is libvirt going to introspect whether the command line supports

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-26 Thread Javier Celaya
Sorry, I forgot to patch the command-line help. Hope it helps. El Viernes, 23 de enero de 2015 09:25:38 Eric Blake escribió: On 01/23/2015 07:06 AM, Javier Celaya wrote: Hello, this is the patch with the version check. Christophe, can you check that the version is the correct one

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-23 Thread Javier Celaya
have a working version check now. Given that lz4 support is optional, spice_server_set_image_compression should probably error out if we try to set lz4 but it's not supported. Ack Christophe From 896a3ea776ee95653a7cb8a0c90111a89b57c73f Mon Sep 17 00:00:00 2001 From: Javier Celaya

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Javier Celaya
Sure, for the help text of the image-compression option, thanks. El Jueves, 8 de enero de 2015 12:48:57 Fabio Fantoni escribió: Il 08/01/2015 11:50, Javier Celaya ha scritto: Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select

[Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Javier Celaya
Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so it should be guarded with conditional compilation. How do you think this