Re: [PATCH V2] hw/intc: Handle software disabling of APIC correctly

2022-10-25 Thread Jay Khandkar
On Wed, Sep 07, 2022 at 11:14:11PM +0530, Jay Khandkar wrote: > When the local APIC is in a software disabled state, all local interrupt > sources must be masked and all attempts to unmask them should be > ignored. Currently, we don't do either. Fix this by handling it &g

Re: [PATCH] hw/intc: Handle software disabling of APIC correctly

2022-09-07 Thread Jay Khandkar
Have sent in v2. On Wed, Aug 17, 2022 at 4:20 PM Michael S. Tsirkin wrote: > On Fri, Jul 29, 2022 at 11:04:47PM +0530, Jay Khandkar wrote: > > On Fri, Jul 29, 2022 at 06:09:01PM +0100, Peter Maydell wrote: > > > On Tue, 12 Jul 2022 at 19:38, Jay Khandkar > wrote: > >

[PATCH V2] hw/intc: Handle software disabling of APIC correctly

2022-09-07 Thread Jay Khandkar
When the local APIC is in a software disabled state, all local interrupt sources must be masked and all attempts to unmask them should be ignored. Currently, we don't do either. Fix this by handling it correctly in apic_mem_write(). Signed-off-by: Jay Khandkar --- hw/intc/apic.c | 8 1

Re: [PATCH] hw/intc: Handle software disabling of APIC correctly

2022-07-29 Thread Jay Khandkar
On Fri, Jul 29, 2022 at 06:09:01PM +0100, Peter Maydell wrote: > On Tue, 12 Jul 2022 at 19:38, Jay Khandkar wrote: > > > > When the local APIC is in a software disabled state, all local interrupt > > sources must be masked and all attempts to unmask them should be > > i

Re: [PATCH] hw/intc: Handle software disabling of APIC correctly

2022-07-29 Thread Jay Khandkar
Ping? On Tue, 12 Jul 2022, 19:49 Jay Khandkar, wrote: > When the local APIC is in a software disabled state, all local interrupt > sources must be masked and all attempts to unmask them should be > ignored. Currently, we don't do either. Fix this by handling it > correctly in ap

[PATCH] hw/intc: Handle software disabling of APIC correctly

2022-07-12 Thread Jay Khandkar
When the local APIC is in a software disabled state, all local interrupt sources must be masked and all attempts to unmask them should be ignored. Currently, we don't do either. Fix this by handling it correctly in apic_mem_write(). Signed-off-by: Jay Khandkar --- hw/intc/apic.c | 16