From: Jes Sorensen jes.soren...@redhat.com
Per default VNC is enabled.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
Makefile.objs | 19 ++-
configure | 37 +
monitor.c | 16
vl.c | 10
On 03/11/11 14:36, Anthony Liguori wrote:
diff --git a/monitor.c b/monitor.c
index 22ae3bb..4425315 100644
--- a/monitor.c
+++ b/monitor.c
@@ -441,6 +441,7 @@ void monitor_protocol_event(MonitorEvent event,
QObject *data)
case QEVENT_RESUME:
event_name = RESUME;
From: Jes Sorensen jes.soren...@redhat.com
Per default VNC is enabled.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
Makefile.objs | 19 ++-
configure | 37 +
console.h | 26 --
monitor.c
On 03/11/11 15:39, Anthony Liguori wrote:
+#ifdef CONFIG_VNC
/* init remote displays */
if (vnc_display) {
vnc_display_init(ds);
@@ -3088,6 +3095,7 @@ int main(int argc, char **argv, char **envp)
printf(VNC server running on `%s'\n,
From: Jes Sorensen jes.soren...@redhat.com
Per default VNC is enabled.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
Makefile.objs | 19 ++-
configure | 37 +
console.h | 26 --
monitor.c
On 03/11/11 15:55, Anthony Liguori wrote:
On 03/11/2011 08:54 AM, Jes Sorensen wrote:
On 03/11/11 15:39, Anthony Liguori wrote:
+#ifdef CONFIG_VNC
/* init remote displays */
if (vnc_display) {
vnc_display_init(ds);
@@ -3088,6 +3095,7 @@ int main(int argc, char
On 03/11/11 16:50, Anthony Liguori wrote:
On 03/11/2011 09:11 AM, Peter Maydell wrote:
(Also the -nographic running of serial over stdio doesn't let
you kill qemu with ^C, the way -serial stdio does, which is
just annoyingly inconsistent...)
So if we want to have another mode that has
From: Jes Sorensen jes.soren...@redhat.com
This removes various code duplication from console.e and sdl.c
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
console.c | 45 +
console.h |3 +++
ui/sdl.c | 21 -
3 files
On 03/10/11 22:04, Stefan Hajnoczi wrote:
On Thu, Mar 10, 2011 at 7:57 PM, SAURAV LAHIRI saurav_lah...@yahoo.com
wrote:
The high level use case is that of being able to backup user specified disks
of a VM without having to bring down the VM.
Excellent, that sounds exactly like Jes is
On 03/11/11 00:21, Anthony Liguori wrote:
On 03/09/2011 09:54 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensenjes.soren...@redhat.com
client_migrate_info was merged badly,
It wasn't merged badly, it was implemented badly. The initial
description confused me because it sounded like a
On 03/07/11 21:10, Michael Roth wrote:
+#define VA_PIDFILE /var/run/qemu-va.pid
+#define VA_HDR_LEN_MAX 4096 /* http header limit */
+#define VA_CONTENT_LEN_MAX 2*1024*1024 /* rpc/http send limit */
+#define VA_CLIENT_JOBS_MAX 5 /* max client rpcs we can queue */
+#define VA_SERVER_JOBS_MAX 5
On 03/07/11 21:10, Michael Roth wrote:
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
qemu-va.c | 247
+
1 files changed, 247 insertions(+), 0 deletions(-)
create mode 100644 qemu-va.c
diff --git a/qemu-va.c
On 03/07/11 11:01, Kevin Wolf wrote:
Am 03.03.2011 14:13, schrieb jes.soren...@redhat.com:
@@ -591,6 +592,12 @@ int do_snapshot_blkdev(Monitor *mon, const QDict
*qdict, QObject **ret_data)
goto out;
}
+strncpy(old_filename, bs-filename, sizeof(old_filename));
+
From: Jes Sorensen jes.soren...@redhat.com
In case we cannot open the newly created snapshot image, try to fall
back to the original image file and continue running on that, which
should prevent the guest from aborting.
This is a corner case which can happen if the admin by mistake
specifies
On 03/07/11 17:34, Anthony Liguori wrote:
On 03/07/2011 09:27 AM, jes.soren...@redhat.com wrote:
if (ret != 0) {
-abort();
+qerror_report(QERR_OPEN_FILE_FAILED, filename);
+error_printf(do_snapshot_blkdev(): Unable to open newly
created
+
From: Jes Sorensen jes.soren...@redhat.com
In case we cannot open the newly created snapshot image, try to fall
back to the original image file and continue running on that, which
should prevent the guest from aborting.
This is a corner case which can happen if the admin by mistake
specifies
On 03/02/11 14:49, Michael Roth wrote:
On 03/02/2011 07:18 AM, Jes Sorensen wrote:
I think we need two types for sure, even for the video case, we will
still need a control channel as well. However, I don't think it is
desirable to split things up more than we have to, so if we can keep
From: Jes Sorensen jes.soren...@redhat.com
In case we cannot open the newly created snapshot image, try to fall
back to the original image file and continue running on that, which
should prevent the guest from aborting.
This is a corner case which can happen if the admin by mistake
specifies
On 03/03/11 14:06, Stefan Hajnoczi wrote:
On Thu, Mar 3, 2011 at 10:44 AM, jes.soren...@redhat.com wrote:
+char old_filename[1024];
+
+old_filename[1023] = '\0';
if (!filename) {
qerror_report(QERR_MISSING_PARAMETER, snapshot_file);
@@ -591,6 +594,10 @@ int
From: Jes Sorensen jes.soren...@redhat.com
Optional feature allowing a user to generate the probe list to match
the name of the binary, in case they wish to install qemu under a
different name than qemu-{system,user},arch
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
scripts/tracetool
On 02/28/11 18:44, Anthony Liguori wrote:
On Feb 28, 2011 10:44 AM, Jes Sorensen jes.soren...@redhat.com wrote:
Separating host-side virtagent and other tasks from core QEMU
=
To improve auditing of the core QEMU code, it would
On 03/01/11 13:07, Dor Laor wrote:
On 02/28/2011 07:44 PM, Anthony Liguori wrote:
I'm very nervous about having a large number of daemons necessary to run
QEMU. I think a reasonable approach would be a single front-end daemond.
s/daemon/son processes/
Qemu is the one that should spawn them
On 03/01/11 15:25, Dor Laor wrote:
On 03/01/2011 02:40 PM, Anthony Liguori wrote:
On Mar 1, 2011 7:07 AM, Dor Laor dl...@redhat.com
Qemu is the one that should spawn them and they should be transparent
from the management. This way running qemu stays the same and qemu just
need to add the
On 03/01/11 15:25, Dor Laor wrote:
On 03/01/2011 02:40 PM, Anthony Liguori wrote:
Spice is the logical place to start, no? It's the largest single
dependency we have and it does some scary things with qemu_mutex. I
would use spice as a way to prove the concept.
I agree it is desirable to
On 03/02/11 11:42, Dor Laor wrote:
On 03/02/2011 12:28 PM, Jes Sorensen wrote:
On 03/01/11 15:25, Dor Laor wrote:
I agree it is desirable to the this for spice but it is allot more
complex than virtagent isolation. Spice is performance sensitive and
contains much more state. It needs
On 03/02/11 11:56, Dor Laor wrote:
On 03/02/2011 12:25 PM, Jes Sorensen wrote:
On 03/01/11 15:25, Dor Laor wrote:
Using shared memory this way should allow us to implement the video
clients without performance loss, in fact it should be beneficial since
it would allow them to run fully
On 03/02/11 11:58, Alon Levy wrote:
On Wed, Mar 02, 2011 at 11:25:44AM +0100, Jes Sorensen wrote:
I had a few thoughts about this already, which I think will work for
both spice and vnc. What we could do is to expose the video memory via
shared memory. That way a spice or vnc daemon could get
On 03/02/11 14:13, Michael Roth wrote:
On 03/02/2011 04:19 AM, Jes Sorensen wrote:
It is absolutely vital for me that we do not make things much more
complicated for users with this move. I don't want to get into a
situation where we start forcing external packages or daemons in order
to run
Hi,
On last week's call we discussed the issue of splitting non core
features of QEMU into it's own process to reduce the security risks etc.
I wrote up a summary of my thoughts on this to try to cover the various
issues. Feedback welcome and hopefully we can continue the discussion on
a future
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
linux-aio.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/linux-aio.c b/linux-aio.c
index 68f4b3d..d9c0225 100644
--- a/linux-aio.c
+++ b/linux-aio.c
@@ -32,6 +32,7
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Current AIO code returns -EINVAL on every error, even on write. In
order to be able to report some more sensible error messages, I
suggest we change it to return -ENOSPC if we are failing on a write
request and we had a partial write. It matches
On 02/22/11 12:44, Kevin Wolf wrote:
@@ -62,6 +63,9 @@ static void qemu_laio_process_completion(struct
qemu_laio_state *s,
if (ret != -ECANCELED) {
if (ret == laiocb-nbytes)
ret = 0;
+else if ((laiocb-type == QEMU_AIO_WRITE) (ret = 0)
+
On 02/18/11 15:57, Anthony Liguori wrote:
On 02/18/2011 08:30 AM, Jes Sorensen wrote:
However if there's an agent connection, it could be arranged in a way
allowing the host to reconnect to the guest agent. In that way it really
shouldn't be a big deal as long as our agent commands aren't too
On 02/21/11 14:36, Michael Roth wrote:
On 02/21/2011 02:32 AM, Jes Sorensen wrote:
Well that isn't really different from the current setup - if QEMU
migrates, the admin tool has to connect to the new QEMU process and
issue the fsthaw command there instead.
Another thing to consider
On 02/17/11 15:39, Michael Roth wrote:
On 02/17/2011 02:26 AM, Jes Sorensen wrote:
On 02/16/11 18:22, Michael Roth wrote:
worry is that we are adding a lot of complexity into QEMU on the host
side which is going to be difficult to audit, especially with things
like the HTML and XML processing
On 02/18/11 15:07, Anthony Liguori wrote:
On 02/18/2011 06:45 AM, Jes Sorensen wrote:
It may not be so fundamental, but it still makes me wary. XMLRPC
handling is quite high level and introduces the potential of errors that
are outside of our direct control. Personally I don't see the big
On 02/16/11 18:22, Michael Roth wrote:
We've seen similar behavior. I think it comes down to qemu-va being
linked against shared objects in the host that don't necessarily
coincide with what's in the guest. It's somewhat misleading that we
currently build qemu-va along with the binary, since
On 02/17/11 13:16, Paolo Bonzini wrote:
On 02/15/2011 01:34 PM, jes.soren...@redhat.com wrote:
-if [ -z $binary ]; then
+if [ -z $probeprefix -a -z $binary ]; then
echo --binary is required for SystemTAP tapset generator
exit 1
fi
--binary is always
From: Jes Sorensen jes.soren...@redhat.com
Optional feature allowing a user to generate the probe list to match
the name of the binary, in case they wish to install qemu under a
different name than qemu-{system,user},arch
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
scripts/tracetool
On 02/17/11 13:29, Paolo Bonzini wrote:
On 02/17/2011 01:19 PM, Jes Sorensen wrote:
On 02/17/11 13:16, Paolo Bonzini wrote:
On 02/15/2011 01:34 PM, jes.soren...@redhat.com wrote:
-if [ -z $binary ]; then
+if [ -z $probeprefix -a -z $binary ]; then
echo --binary is required
On 01/17/11 14:14, Michael Roth wrote:
These patches apply to master (1-14-2011), and can also be obtained from:
git://repo.or.cz/qemu/mdroth.git virtagent_v6
CHANGES IN V6:
- Added a sentinel value to reliably detect the start of an http hdr. Used
to skip past partially sent http
From: Jes Sorensen jes.soren...@redhat.com
Optional feature allowing a user to generate the probe list to match
the name of the binary, in case they wish to install qemu under a
different name than qemu-{system,user},arch
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
scripts/tracetool
From: Jes Sorensen jes.soren...@redhat.com
Optional feature allowing a user to generate the probe list to match
the name of the binary, in case they wish to install qemu under a
different name than qemu-{system,user},arch
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
scripts/tracetool
From: Jes Sorensen jes.soren...@redhat.com
Pointed out by Markus
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
hmp-commands.hx |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 38e1eb7..372bef4 100644
--- a/hmp
From: Jes Sorensen jes.soren...@redhat.com
Hi
This is a first attempt to add fsfreeze support to virtagent. The idea
is for the guest agent to walk the list of locally mounted file
systems in the guest, and issuing an ioctl to freeze them. The host
can then do a live snapshot of the guest
On 02/03/11 18:41, Michael Roth wrote:
On 02/02/2011 02:48 AM, Jes Sorensen wrote:
Yes very much so[1] - one reason why it would be nice to have virtagent
use threads to execute the actual commands. We should probably add a
flag to agent commands indicating whether they issue disk I/O
From: Jes Sorensen jes.soren...@redhat.com
This patch adds the following monitor commands:
agent_fsfreeze:
- Freezes all local file systems in the guest. Command will print
the number of file systems that were frozen.
agent_fsthaw:
- Thaws all local file systems in the guest. Command
On 02/03/11 19:11, Michael Roth wrote:
@@ -217,6 +221,186 @@ static xmlrpc_value *va_hello(xmlrpc_env *env,
return result;
}
+
+/*
+ * Walk the mount table and build a list of local file systems
+ */
+
+struct direntry {
+char *dirname;
+char *devtype;
+struct
From: Jes Sorensen jes.soren...@redhat.com
Implement freeze/thaw support in the guest, allowing the host to
request the guest freezes all it's file systems before a live snapshot
is performed.
- fsfreeze(): Walk the list of mounted local real file systems,
and freeze them
From: Jes Sorensen jes.soren...@redhat.com
Implement freeze/thaw support in the guest, allowing the host to
request the guest freezes all it's file systems before a live snapshot
is performed.
- fsfreeze(): Walk the list of mounted local real file systems,
and freeze them
From: Jes Sorensen jes.soren...@redhat.com
This patch adds the following monitor commands:
agent_fsfreeze:
- Freezes all local file systems in the guest. Command will print
the number of file systems that were frozen.
agent_fsthaw:
- Thaws all local file systems in the guest. Command
On 02/01/11 17:50, Michael Roth wrote:
On 02/01/2011 04:58 AM, jes.soren...@redhat.com wrote:
+enum vs_fsfreeze_status {
+FREEZE_ERROR = -1,
+FREEZE_THAWED = 0,
+FREEZE_INPROGRESS = 1,
+FREEZE_FROZEN = 2,
+FREEZE_THAWINPROGRESS = 3,
+};
Any reason for vs_* vs. va_*?
From: Jes Sorensen jes.soren...@redhat.com
Hi
This is a first attempt to add fsfreeze support to virtagent. The idea
is for the guest agent to walk the list of locally mounted file
systems in the guest, and issuing an ioctl to freeze them. The host
can then do a live snapshot of the guest
On 02/02/11 08:57, Stefan Hajnoczi wrote:
On Tue, Feb 1, 2011 at 10:58 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Implement freeze/thaw support in the guest, allowing the host to
request the guest freezes all it's file systems before a live snapshot
From: Jes Sorensen jes.soren...@redhat.com
Hi
This is a first attempt to add fsfreeze support to virtagent. The idea
is for the guest agent to walk the list of locally mounted file
systems in the guest, and issuing an ioctl to freeze them. The host
can then do a live snapshot of the guest
From: Jes Sorensen jes.soren...@redhat.com
Implement freeze/thaw support in the guest, allowing the host to
request the guest freezes all it's file systems before a live snapshot
is performed.
- fsfreeze(): Walk the list of mounted local real file systems,
and freeze them
From: Jes Sorensen jes.soren...@redhat.com
This patch adds the following monitor commands:
agent_fsfreeze:
- Freezes all local file systems in the guest. Command will print
the number of file systems that were frozen.
agent_fsthaw:
- Thaws all local file systems in the guest. Command
On 02/01/11 12:25, Vasiliy G Tolstov wrote:
Hello. Very nice feature. Sorry for offropic, but can this feature can
be used to modify partiotion table on already mounted device (for
example root on ext3? )
Thank You.
No it cannot, that would be a totally different issue that wouldn't be
On 02/01/11 15:12, Stefan Hajnoczi wrote:
On Tue, Feb 1, 2011 at 10:58 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
Implement freeze/thaw support in the guest, allowing the host to
request the guest freezes all it's file systems before a live snapshot
On 02/01/11 15:16, Stefan Hajnoczi wrote:
On Tue, Feb 1, 2011 at 10:58 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen jes.soren...@redhat.com
This is a first attempt to add fsfreeze support to virtagent. The idea
is for the guest agent to walk the list of locally mounted file
systems
On 02/01/11 15:34, Stefan Hajnoczi wrote:
On Tue, Feb 1, 2011 at 2:26 PM, Jes Sorensen jes.soren...@redhat.com wrote:
I have to admit you lost me here, where do you get that 500ms time from?
Is that the XMLRPC polling time or? I just used the example code from
other agent calls.
500 ms
On 02/01/11 15:48, Adam Litke wrote:
On Tue, 2011-02-01 at 11:58 +0100, jes.soren...@redhat.com wrote:
+/*
+ * va_fsfreeze(): Walk list of mounted file systems in the guest, and
+ * freeze the ones which are real local file systems.
+ * rpc return values: Number of file systems frozen, -1
From: Jes Sorensen jes.soren...@redhat.com
qemu_spice_set_passwd() and qemu_spice_set_pw_expire() dummy functions
needs to be inline, in order to handle the case where they are called
without checking the return value.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
ui/qemu-spice.h
From: Jes Sorensen jes.soren...@redhat.com
Move size after the two pointers in struct Qcow2Cache to get better
packing of struct elements on 64 bit architectures.
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
block/qcow2-cache.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
On 01/24/11 15:50, Chunqiang Tang wrote:
I think the root of the problem is that your series didn't maintain
bisectability.
IOW, each patch needs to be able to be applied one at a time such that
at each point, the build doesn't break and functionality doesn't break.
Otherwise, tools like
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
qemu-common.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index c766b99..505e576 100644
--- a/qemu-common.h
+++ b/qemu-common.h
On 01/24/11 18:47, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
qemu_toupper() - whats the problem?
If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
will not match any input.
Right, so one has to be careful when adding new suffix constants
On 01/24/11 18:28, Stefan Weil wrote:
There was some discussion regarding this patch set.
I agree with Markus that part of the first patch
should be removed: don't change char to unsigned char.
The unsigned char should definitely go in, leaving it as a signed char
doesn't serve any purpose.
On 01/25/11 11:14, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
On 01/24/11 18:28, Stefan Weil wrote:
There was some discussion regarding this patch set.
I agree with Markus that part of the first patch
should be removed: don't change char to unsigned char
On 01/25/11 11:17, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
On 01/24/11 18:47, Markus Armbruster wrote:
Jes Sorensen jes.soren...@redhat.com writes:
qemu_toupper() - whats the problem?
If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
Hello,
Please find attached my notes from the weekly QEMU/KVM call January 25,
2011. My apologies if I got something wrong.
Jes
- QEMU 0.14/0.15 releases
- Feb 1st 2011 branch to stable tree for 0.14. Anthony would like to
do a formal release quickly, so hopefully within 1-2 weeks after
(-)
Looks good!
Acked-by: Jes Sorensen jes.soren...@redhat.com
On 01/17/11 14:15, Michael Roth wrote:
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
Makefile.target |2 +-
configure | 32
2 files changed, 33 insertions(+), 1 deletions(-)
Please make building qemu-va optional, so the build doesn't
On 01/21/11 18:55, Michael Roth wrote:
On 01/21/2011 10:38 AM, Jes Sorensen wrote:
+#includexmlrpc-c/base.h
+#includexmlrpc-c/server.h
+
+#define GUEST_AGENT_SERVICE_ID virtagent
+#define GUEST_AGENT_PATH /tmp/virtagent-guest.sock
+#define HOST_AGENT_SERVICE_ID virtagent-host
+#define
From: Jes Sorensen jes.soren...@redhat.com
Hi,
Here is an updated version of the strtosz() fixes that were discussed
earlier. Per discussing with Anthony on irc, he is ok with them going
in like this.
This is a respin to fix a patch conflict in the block tree, and it
pulls the two patch sets
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/cutils.c b/cutils.c
index a067cf4..78d35e2 100644
--- a/cutils.c
+++ b/cutils.c
@@ -323,16 +323,14 @@ int64_t
From: Jes Sorensen jes.soren...@redhat.com
isspace() behavior is undefined for signed char.
Bug pointed out by Eric Blake, thanks!
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/cutils.c b/cutils.c
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cutils.c b/cutils.c
index 78d35e2..369a016 100644
--- a/cutils.c
+++ b/cutils.c
@@ -304,8 +304,8 @@ int64_t
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cutils.c b/cutils.c
index 369a016..8d562b2 100644
--- a/cutils.c
+++ b/cutils.c
@@ -324,26 +324,26
On 01/24/11 17:08, Markus Armbruster wrote:
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cutils.c b/cutils.c
On 01/24/11 17:10, Markus Armbruster wrote:
jes.soren...@redhat.com writes:
From: Jes Sorensen jes.soren...@redhat.com
isspace() behavior is undefined for signed char.
Bug pointed out by Eric Blake, thanks!
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |7
On 01/24/11 17:39, Markus Armbruster wrote:
+case STRTOSZ_DEFSUFFIX_TB:
mul = 1ULL 40;
break;
default:
Phony abstraction. And it leaks: code here assumes the
STRTOSZ_DEFSUFFIX_T* are all upper case.
qemu_toupper() - whats the problem?
If a
On 01/24/11 17:51, Michael Roth wrote:
On 01/24/2011 04:16 AM, Jes Sorensen wrote:
It's obviously contentious, and it is not core functionality. In order
to get the patches adapted upstream it would easy the process to remove
it and keep it as a separate patch.
Fair enough, the proposed
On 01/21/11 18:26, Michael Roth wrote:
On 01/21/2011 10:30 AM, Jes Sorensen wrote:
On 01/17/11 14:14, Michael Roth wrote:
diff --git a/qemu-ioh.c b/qemu-ioh.c
index cc71470..001e7a2 100644
--- a/qemu-ioh.c
+++ b/qemu-ioh.c
@@ -22,7 +22,11 @@
* THE SOFTWARE.
*/
#include qemu-ioh.h
On 01/17/11 14:14, Michael Roth wrote:
diff --git a/qemu-ioh.c b/qemu-ioh.c
index cc71470..001e7a2 100644
--- a/qemu-ioh.c
+++ b/qemu-ioh.c
@@ -22,7 +22,11 @@
* THE SOFTWARE.
*/
#include qemu-ioh.h
+#include qemu-char.h
#include qlist.h
+#ifdef CONFIG_EVENTFD
+#include
diff --git a/virtagent-server.h b/virtagent-server.h
new file mode 100644
index 000..9f68921
--- /dev/null
+++ b/virtagent-server.h
@@ -0,0 +1,34 @@
+/*
+ * virt-agent - host/guest RPC daemon functions
+ *
+ * Copyright IBM Corp. 2010
+ *
+ * Authors:
+ * Michael Roth
On 01/17/11 14:15, Michael Roth wrote:
Add RPC to retrieve a guest file. This interface is intended
for smaller reads like peeking at logs and /proc and such.
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
---
virtagent-server.c | 59
On 01/17/11 14:15, Michael Roth wrote:
Utilize the getfile RPC to provide a means to view text files in the
guest. Getfile can handle binary files as well but we don't advertise
that here due to the special handling requiring to store it and provide
it back to the user (base64 encoding it for
On 01/18/11 21:39, Anthony Liguori wrote:
On 01/18/2011 02:36 PM, Jes Sorensen wrote:
On 01/18/11 21:30, Anthony Liguori wrote:
On 01/18/2011 10:53 AM, Eric Blake wrote:
And it does, via the toupper() added earlier in the series (and which
has separately been pointed out that using
On 01/18/11 10:20, Markus Armbruster wrote:
diff --git a/cutils.c b/cutils.c
index 328738c..f2c8bbd 100644
--- a/cutils.c
+++ b/cutils.c
@@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end,
const char default_suffix)
}
}
switch (toupper(d)) {
-
On 01/18/11 17:50, Anthony Liguori wrote:
On 01/18/2011 03:20 AM, Markus Armbruster wrote:
jes.soren...@redhat.com writes:
From: Jes Sorensenjes.soren...@redhat.com
Signed-off-by: Jes Sorensenjes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+),
On 01/18/11 21:30, Anthony Liguori wrote:
On 01/18/2011 10:53 AM, Eric Blake wrote:
On 01/18/2011 09:50 AM, Anthony Liguori wrote:
@@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char
**end, const char default_suffix)
}
}
switch (toupper(d)) {
From: Jes Sorensen jes.soren...@redhat.com
Bug pointed out by Erik Blake, thanks!
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cutils.c b/cutils.c
index 7984bc1..f97ef39 100644
--- a/cutils.c
+++ b
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/cutils.c b/cutils.c
index f97ef39..f7aa90c 100644
--- a/cutils.c
+++ b/cutils.c
@@ -323,16 +323,14 @@ ssize_t
From: Jes Sorensen jes.soren...@redhat.com
Fix issue with signed char and isspace() as well as clean up switch
statement using toupper().
V2 of the patch fixes some types in the commit messages and spells
Eric correctly. My apologies for getting it wrong.
Jes Sorensen (2):
strtosz() use
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/cutils.c b/cutils.c
index f97ef39..f7aa90c 100644
--- a/cutils.c
+++ b/cutils.c
@@ -323,16 +323,14 @@ ssize_t
From: Jes Sorensen jes.soren...@redhat.com
Bug pointed out by Eric Blake, thanks!
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cutils.c b/cutils.c
index 7984bc1..f97ef39 100644
--- a/cutils.c
+++ b
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/cutils.c b/cutils.c
index f7aa90c..328738c 100644
--- a/cutils.c
+++ b/cutils.c
@@ -304,8 +304,8 @@ ssize_t
From: Jes Sorensen jes.soren...@redhat.com
Another two cleanups to strtosz() suggested by Alex Williamson.
I had reversed the use of the names of the return arguments to modf(),
and use the STRTOSZ_DESUFFIX_ macros in the switch() statement.
Cheers,
Jes
Jes Sorensen (2):
strtosz(): Fix name
From: Jes Sorensen jes.soren...@redhat.com
Signed-off-by: Jes Sorensen jes.soren...@redhat.com
---
cutils.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/cutils.c b/cutils.c
index 328738c..f2c8bbd 100644
--- a/cutils.c
+++ b/cutils.c
@@ -324,26 +324,26
201 - 300 of 894 matches
Mail list logo
