Re: [PATCH 2/6] io: add QIOChannelRDMA class

2024-06-10 Thread Jinpu Wang
On Tue, Jun 4, 2024 at 2:14 PM Gonglei wrote: > > From: Jialin Wang > > Implement a QIOChannelRDMA subclass that is based on the rsocket > API (similar to socket API). > > Signed-off-by: Jialin Wang > Signed-off-by: Gonglei > --- > include/io/channel-rdma.h | 152 + >

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-06-06 Thread Jinpu Wang
Hi Gonglei, hi folks on the list, On Tue, Jun 4, 2024 at 2:14 PM Gonglei wrote: > > From: Jialin Wang > > Hi, > > This patch series attempts to refactor RDMA live migration by > introducing a new QIOChannelRDMA class based on the rsocket API. > > The /usr/include/rdma/rsocket.h provides a

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Jinpu Wang
On Wed, May 29, 2024 at 11:35 AM Gonglei (Arei) wrote: > > > > -Original Message- > > From: Jinpu Wang [mailto:jinpu.w...@ionos.com] > > Sent: Wednesday, May 29, 2024 5:18 PM > > To: Gonglei (Arei) > > Cc: Greg Sword ; Peter Xu ; > > Yu

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Jinpu Wang
Hi Gonglei, On Wed, May 29, 2024 at 10:31 AM Gonglei (Arei) wrote: > > > > > -Original Message- > > From: Greg Sword [mailto:gregswo...@gmail.com] > > Sent: Wednesday, May 29, 2024 2:06 PM > > To: Jinpu Wang > > Subject: Re: [PATCH-for-9.1

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-29 Thread Jinpu Wang
On Wed, May 29, 2024 at 8:08 AM Greg Sword wrote: > > On Wed, May 29, 2024 at 12:33 PM Jinpu Wang wrote: > > > > On Wed, May 29, 2024 at 4:43 AM Gonglei (Arei) > > wrote: > > > > > > Hi, > > > > > > > -Original Message-

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-28 Thread Jinpu Wang
On Wed, May 29, 2024 at 4:43 AM Gonglei (Arei) wrote: > > Hi, > > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Tuesday, May 28, 2024 11:55 PM > > > > > Exactly, not so compelling, as I did it first only on servers > > > > > widely used for production in our

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-28 Thread Jinpu Wang
Hi Gonglei, On Tue, May 28, 2024 at 11:06 AM Gonglei (Arei) wrote: > > Hi Peter, > > > -Original Message- > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Wednesday, May 22, 2024 6:15 AM > > To: Yu Zhang > > Cc: Michael Galaxy ; Jinpu W

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-13 Thread Jinpu Wang
Hi Peter, Hi Chuan, On Thu, May 9, 2024 at 4:14 PM Peter Xu wrote: > > On Thu, May 09, 2024 at 04:58:34PM +0800, Zheng Chuan via wrote: > > That's a good news to see the socket abstraction for RDMA! > > When I was developed the series above, the most pain is the RDMA migration > > has no

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-06 Thread Jinpu Wang
Hi Peter, hi Daniel, On Mon, May 6, 2024 at 5:29 PM Peter Xu wrote: > > On Mon, May 06, 2024 at 12:08:43PM +0200, Jinpu Wang wrote: > > Hi Peter, hi Daniel, > > Hi, Jinpu, > > Thanks for sharing this test results. Sounds like a great news. > > What's your plan next

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-06 Thread Jinpu Wang
Hi Peter, hi Daniel, On Fri, May 3, 2024 at 4:33 PM Peter Xu wrote: > > On Fri, May 03, 2024 at 08:40:03AM +0200, Jinpu Wang wrote: > > I had a brief check in the rsocket changelog, there seems some > > improvement over time, > > might be worth revisiting this. due t

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-03 Thread Jinpu Wang
Hi Daniel, On Wed, May 1, 2024 at 6:00 PM Daniel P. Berrangé wrote: > > On Wed, May 01, 2024 at 11:31:13AM -0400, Peter Xu wrote: > > What I worry more is whether this is really what we want to keep rdma in > > qemu, and that's also why I was trying to request for some serious > > performance

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-02 Thread Jinpu Wang
Hi Peter On Thu, May 2, 2024 at 6:20 PM Peter Xu wrote: > > On Thu, May 02, 2024 at 03:30:58PM +0200, Jinpu Wang wrote: > > Hi Michael, Hi Peter, > > > > > > On Thu, May 2, 2024 at 3:23 PM Michael Galaxy wrote: > > > > > > Yu Zhang / Jin

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-02 Thread Jinpu Wang
Hi Michael, Hi Peter, On Thu, May 2, 2024 at 3:23 PM Michael Galaxy wrote: > > Yu Zhang / Jinpu, > > Any possibility (at your lesiure, and within the disclosure rules of > your company, IONOS) if you could share any of your performance > information to educate the group? > > NICs have indeed

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-11 Thread Jinpu Wang
Hi Peter, On Tue, Apr 9, 2024 at 9:47 PM Peter Xu wrote: > > On Tue, Apr 09, 2024 at 09:32:46AM +0200, Jinpu Wang wrote: > > Hi Peter, > > > > On Mon, Apr 8, 2024 at 6:18 PM Peter Xu wrote: > > > > > > On Mon, Apr 08, 2024 at 04:07:20PM

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-09 Thread Jinpu Wang
Hi Peter, On Mon, Apr 8, 2024 at 6:18 PM Peter Xu wrote: > > On Mon, Apr 08, 2024 at 04:07:20PM +0200, Jinpu Wang wrote: > > Hi Peter, > > Jinpu, > > Thanks for joining the discussion. > > > > > On Tue, Apr 2, 2024 at 11:24 PM Peter Xu wrote: > > >

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-08 Thread Jinpu Wang
to outperform RDMAs, then it may make > little sense to maintain multiple protocols, considering RDMA migration > code is so special so that it has the most custom code comparing to other > protocols. +cc some guys from Huawei. I'm surprised RDMA users are rare, I guess maybe many are just working with different code base. > > Thanks, > > -- > Peter Xu Thx! Jinpu Wang >

[RFC] Convert VMWARE vmdk (snapshot) to raw disk

2024-02-16 Thread Jinpu Wang
e us some suggestions? Thx! Jinpu Wang

Re: [PATCH v2] target/i386: Export GDS_NO bit to guests

2023-09-14 Thread Jinpu Wang
Hi Paolo, Ping! Thx! On Tue, Aug 15, 2023 at 7:44 AM Xiaoyao Li wrote: > > On 8/15/2023 12:54 PM, Pawan Gupta wrote: > > Gather Data Sampling (GDS) is a side-channel attack using Gather > > instructions. Some Intel processors will set ARCH_CAP_GDS_NO bit in > > MSR IA32_ARCH_CAPABILITIES to

Re: RFC: guest INTEL GDS mitigation status on patched host

2023-08-14 Thread Jinpu Wang
.msr = { -- 2.34.1 For the change Pawan provided, I tested on Icelake server, it works as expected. Somehow I'm not cc for the patch, but please consider it tested Reported-by: Jack Wang Tested-by: Jack Wang Thx! Jinpu Wang while if I patches QEMU below: On Fri, Aug 11, 2023 at 3:12 PM J

RFC: guest INTEL GDS mitigation status on patched host

2023-08-11 Thread Jinpu Wang
ort of GDS_NO, but seems qemu side doesn't pass the info to guest, that's why it is unknown. IMO qemu should pass GDS_NO if the host is already patched. Is Intel or anyone already working on the qemu patch? I know it's not a must, but good to do. Thx! Jinpu Wang @ IONOS Cloud

Re: an issue for device hot-unplug

2023-04-04 Thread Jinpu Wang
I'll open a bug in the > bug tracker and let you know. > We opened an issue here: https://gitlab.com/qemu-project/qemu/-/issues/1577 Regards! Jinpu Wang > Best regards, > Yu Zhang > > On Mon, Apr 3, 2023 at 6:32 PM Laurent Vivier wrote: >> >> Hi Yu, >> >

Re: an issue for device hot-unplug

2023-04-04 Thread Jinpu Wang
Hi Yu, On Mon, Apr 3, 2023 at 6:59 PM Yu Zhang wrote: > > Dear Laurent, > > Thank you for your quick reply. We used qemu-7.1, but it is reproducible with > qemu from v6.2 to the recent v8.0 release candidates. > I found that it's introduced by the commit 9323f892b39 (between v6.2.0-rc2 > and

Re: RFC: sgx-epc is not listed in machine type help

2022-04-28 Thread Jinpu Wang
On Fri, Apr 29, 2022 at 4:22 AM Yang Zhong wrote: > > On Thu, Apr 28, 2022 at 02:56:50PM +0200, Jinpu Wang wrote: > > On Thu, Apr 28, 2022 at 2:32 PM Yang Zhong wrote: > > > > > > On Thu, Apr 28, 2022 at 02:18:54PM +0200, Jinpu Wang wrote: > > > >

Re: RFC: sgx-epc is not listed in machine type help

2022-04-28 Thread Jinpu Wang
Hi Daniel, On Thu, Apr 28, 2022 at 2:33 PM Daniel P. Berrangé wrote: > > On Thu, Apr 28, 2022 at 02:18:54PM +0200, Jinpu Wang wrote: > > On Thu, Apr 28, 2022 at 2:05 PM Yang Zhong wrote: > > > > > > On Thu, Apr 28, 2022 at 01:59:33PM +0200, Jinpu Wang wr

Re: RFC: sgx-epc is not listed in machine type help

2022-04-28 Thread Jinpu Wang
On Thu, Apr 28, 2022 at 2:32 PM Yang Zhong wrote: > > On Thu, Apr 28, 2022 at 02:18:54PM +0200, Jinpu Wang wrote: > > On Thu, Apr 28, 2022 at 2:05 PM Yang Zhong wrote: > > > > > > On Thu, Apr 28, 2022 at 01:59:33PM +0200, Jinpu Wang wrote: > > > > Hi

Re: RFC: sgx-epc is not listed in machine type help

2022-04-28 Thread Jinpu Wang
On Thu, Apr 28, 2022 at 2:05 PM Yang Zhong wrote: > > On Thu, Apr 28, 2022 at 01:59:33PM +0200, Jinpu Wang wrote: > > Hi Yang, hi Paolo, > > > > We noticed sgx-epc machine type is not listed in the output of > > "qemu-system-x86_64 -M ?", snip > &

RFC: sgx-epc is not listed in machine type help

2022-04-28 Thread Jinpu Wang
this would cause confusion to users, is there a reason behind this? Thanks! Jinpu Wang @ IONOS Cloud

Re: [PATCH 2/2] migration/rdma: set the REUSEADDR option for destination

2022-02-02 Thread Jinpu Wang
On Wed, Feb 2, 2022 at 11:15 AM Dr. David Alan Gilbert wrote: > > * Jack Wang (jinpu.w...@ionos.com) wrote: > > This allow address could be reused to avoid rdma_bind_addr error > > out. > > In what case do you get the error - after a failed migrate and then a > retry? Yes, what I saw is in case

Re: [PATCH 1/2] migration/rdma: Increase the backlog from 5 to 128

2022-02-02 Thread Jinpu Wang
e we first increase it to 20 or 32? or so to avoid memory > > overhead if we are not > > using these many connections at the same time. > > Can you explain why you're requiring more than 1? Is this with multifd > patches? no, I'm not using multifs patches, just code reading, I fe

Re: [PATCH 2/2] migration/rdma: set the REUSEADDR option for destination

2022-02-01 Thread Jinpu Wang
ms ok to me. I feel it's cleaner to do it with a variable than force conversion of 1 to void *. It's bound to the cm_id which is newly created a few lines above, so does not affect core rdma transport. > > Thanks, > Pankaj Thanks for the review! Jinpu Wang > > > +if (r

Re: [PATCH 1/2] migration/rdma: Increase the backlog from 5 to 128

2022-02-01 Thread Jinpu Wang
On Tue, Feb 1, 2022 at 7:19 PM Pankaj Gupta wrote: > > > So it can handle more incoming requests. > > > > Signed-off-by: Jack Wang > > --- > > migration/rdma.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/migration/rdma.c b/migration/rdma.c > > index