tion because
it is normally part of the Python stdlib, and always having it allows us
a more consistent cross-platform environment.
Signed-off-by: John Snow
---
tests/docker/dockerfiles/debian-all-test-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-hexagon-cross.docker | 3 ++-
tests/doc
xpat to provide "pyexpat" *
(* Or whichever version is current for NetBSD.)
Signed-off-by: John Snow
---
python/scripts/mkvenv.py | 277 +++
python/setup.cfg | 9 ++
python/tests/flake8.sh | 1 +
python/tests/isort.sh| 1 +
pytho
to the correct, configured
python and can be used by e.g. manual tests to invoke the correct,
configured Python unambiguously.
Signed-off-by: John Snow
---
configure | 72 -
.gitlab-ci.d/buildtest-template.yml | 4 +-
2 files changed, 21 in
Rely on the diagnosis information from mkvenv so it can be removed from
the configure script.
Signed-off-by: John Snow
---
configure | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/configure b/configure
index ae55de1408..0881fffc14 100755
--- a/configure
+++ b
NetBSD removes some packages from the Python stdlib, but only
re-packages them for Python 3.10. Switch to using Python 3.10.
Signed-off-by: John Snow
---
tests/vm/netbsd | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index 0b9536ca17..13eae109c0 100755
On Thu, Apr 20, 2023, 5:19 AM Philippe Mathieu-Daudé
wrote:
> On 17/4/23 19:44, Alex Bennée wrote:
> >
> > John Snow writes:
> >
> >> On Mon, Apr 17, 2023 at 9:43 AM Alex Bennée
> wrote:
> >>>
> >>> From: Kautuk Consul
> >>
On Mon, Apr 17, 2023 at 9:43 AM Alex Bennée wrote:
>
> This is the current state of my testing tree. It contains a few
> patches that didn't make it into 8.0 and more testing fixes including
> a bump to the avocado release including Thomas' --max-parallel-tasks
> hack to avoid running the tests in
On Mon, Apr 17, 2023 at 9:43 AM Alex Bennée wrote:
>
> From: Kautuk Consul
>
> Avocado version 101.0 has a fix to re-compute the checksum
> of an asset file if the algorithm used in the *-CHECKSUM
> file isn't the same as the one being passed to it by the
> avocado user (i.e. the avocado_qemu pyt
poses of a throwaway VM, there's not really a speed
difference for who is responsible for installing pip; us (needs
py310-pip) or Python (needs py310-expat).
Signed-off-by: John Snow
---
tests/vm/netbsd | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
i
as a fallback.
As a coincidence, it also gives us a pretty good place to do all kinds
of other "in-venv" setup that we might want to do later; for instance
meson and sphinx bootstrapping might be good candidates.
Signed-off-by: John Snow
---
python/scripts/mkve
.)
Signed-off-by: John Snow
---
configure | 34 +-
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 800b5850f4..03278fd891 100755
--- a/configure
+++ b/configure
@@ -608,7 +608,6 @@ check_py_version() {
python=
first_python=
if
tion because
it is normally part of the Python stdlib, and always having it allows us
a more consistent cross-platform environment.
Signed-off-by: John Snow
---
tests/docker/dockerfiles/debian-all-test-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-hexagon-cross.docker | 3 ++-
tests/doc
NetBSD removes some packages from the Python stdlib, but only
re-packages them for Python 3.10. Switch to using Python 3.10.
Signed-off-by: John Snow
---
tests/vm/netbsd | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vm/netbsd b/tests/vm/netbsd
index 0b9536ca17..13eae109c0 100755
.whl file instead. This will
remove some of the `--no-use-pep517` hackiness and alleviates the
requirement that users install the python3 'wheel' dependency.
- Most of this logic can be moved into mkvenv.py, *especially* if the
meson git submodule is removed.
Signed-of
NetBSD debundles pyexpat from python, but ensurepip needs pyexpat. Try
our best to offer a helpful error message instead of just failing
catastrophically.
Signed-off-by: John Snow
---
python/scripts/mkvenv.py | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git
xpat to provide "pyexpat" *
(* Or whichever version is current for NetBSD.)
Signed-off-by: John Snow
---
python/scripts/mkvenv.py | 379 +++
1 file changed, 379 insertions(+)
create mode 100644 python/scripts/mkvenv.py
diff --git a/python/scripts/m
to address that discrepancy in the future so
that it will be possible to re-use the same venv for
qemu.git/python/qemu self-tests to introduce them to make check as "make
check-python".
Signed-off-by: John Snow
---
docs/devel/acpi-bits.rst | 6 +++-
edge cases.
Changes yet to come for further revisions to this series:
- Need to add Sphinx support.
- Need to add nested venv support.
- PyPI support? (To drop meson git submodule?)
- Installing meson from vendored .whl files for tarballs?
(To drop --no-use-pep517 hack?)
John Snow (10):
p
.] ?"
I was slightly apprehensive about this as it felt "hackier", but it is
indeed a lot less code and much faster. It's probably low-risk. Should
we do that instead, or should we just scrap any fix at all under the
premise that Debian 10 support is dropped anyway?
On Thu, Apr 13, 2023 at 5:43 PM John Snow wrote:
>
> The tests will fail mysteriously with EOFError otherwise, because the VM
> fails to boot and quickly disconnects from the QMP socket. Skip these
> tests when we didn't compile with slirp.
>
Full disclosure: I only
The tests will fail mysteriously with EOFError otherwise, because the VM
fails to boot and quickly disconnects from the QMP socket. Skip these
tests when we didn't compile with slirp.
Fixes: c8cb603293fd (tests/avocado: Test Xen guest support under KVM)
Signed-off-by: John Snow
---
On Wed, Mar 29, 2023 at 8:56 AM Paolo Bonzini wrote:
>
> BTW, another way to repair Debian 10's pip is to create a symbolic link
> to sys.base_prefix + '/share/python-wheels' in sys.prefix +
> '/share/python-wheels'. Since this is much faster, perhaps it can be
> done unconditionally and checkpip
On Wed, Mar 29, 2023 at 8:56 AM Paolo Bonzini wrote:
>
> On 3/28/23 23:11, John Snow wrote:
> > +for entry_point in entry_points:
> > +# Python 3.8 doesn't have 'module' or 'attr' attributes
> > +
On Wed, Mar 29, 2023 at 8:47 AM Daniel P. Berrangé wrote:
>
> Currently our NetBSD VM recipe requests instal of the python37 package
> and explicitly tells QEMU to use that version of python. Since the
> NetBSD base ISO was updated to version 9.3 though, the default system
> python version is 3.9
On Wed, Mar 29, 2023, 9:32 AM Daniel P. Berrangé
wrote:
> On Wed, Mar 29, 2023 at 03:27:53PM +0200, Paolo Bonzini wrote:
> > On 3/29/23 14:53, Daniel P. Berrangé wrote:
> > > I would love to see a day where configure isn't involved in the
> > > build process. Obviously we can't put this new logic
ce 4.0)
> #
> # @persistent: true if the bitmap was stored on disk, is scheduled to be
> stored
> # on disk, or both. (since 4.0)
> --
> 2.39.2
>
Reviewed-By: John Snow
On Wed, Mar 29, 2023, 9:02 AM Paolo Bonzini wrote:
> Thanks for posting this!
>
> On 3/28/23 23:11, John Snow wrote:
> > This series is in RFC state; some notable things:
> > - So far, only meson is included in this setup.
> > - There's a ton of debugging prints e
On Wed, Mar 29, 2023, 8:56 AM Paolo Bonzini wrote:
> On 3/28/23 23:11, John Snow wrote:
> > +# venv class is cute and toggles this off before post_setup,
> > +# but we need it to decide if we want to generate shims or not.
>
> Ha, yeah that's
gured Python unambiguously.
Signed-off-by: John Snow
---
configure | 155 +++-
.gitlab-ci.d/buildtest-template.yml | 2 +-
2 files changed, 108 insertions(+), 49 deletions(-)
diff --git a/configure b/configure
index 05bed4f4a11..1ec054775f6 1
This script will be responsible for building a Python virtual
environment at configure time. As such, it exists outside of the
installable python packages and *must* be runnable with minimal
dependencies.
Signed-off-by: John Snow
---
python/scripts/mkvenv.py | 445
our oldest platforms.)
Signed-off-by: John Snow
---
tests/docker/dockerfiles/debian-all-test-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-hexagon-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-riscv64-cross.docker | 3 ++-
tests/docker/dockerfiles/debian-tricore-cross.docker | 3
r most platforms; the asterisk is Debian.)
- No new configure flags (...yet.)
John Snow (3):
python: add mkvenv.py
tests: add python3-venv dependency
configure: install meson to a python virtual environment
configure | 155 --
.gitlab-ci.d/buildtest
On Mon, Mar 20, 2023 at 8:20 AM Vladimir Sementsov-Ogievskiy
wrote:
>
> On 20.03.23 13:54, Daniel P. Berrangé wrote:
> > The default message recv limit in asyncio is smaller than our needs, so
> > when opening connections we override it. This was done when opening a
> > connection using a socket a
On Thu, Mar 16, 2023 at 4:54 AM Philippe Mathieu-Daudé
wrote:
>
> On 16/3/23 00:02, John Snow wrote:
> > On Wed, Mar 15, 2023 at 5:17 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> +Jan
> >>
> >> On 22/2/23 15:37, Paolo Bonzini wrote:
>
On Wed, Mar 15, 2023 at 8:13 AM Philippe Mathieu-Daudé
wrote:
>
> On 15/3/23 12:16, Daniel P. Berrangé wrote:
> > On Wed, Mar 15, 2023 at 08:43:33AM +0100, Philippe Mathieu-Daudé wrote:
> >> Hi Marco,
> >>
> >> (+Python experts)
> >>
> >> On 13/3/23 18:25, Marco Liebel wrote:
> >>> Replace python
On Wed, Mar 15, 2023 at 5:17 PM Philippe Mathieu-Daudé
wrote:
>
> +Jan
>
> On 22/2/23 15:37, Paolo Bonzini wrote:
> > From: John Snow
> >
> > The pipenv tool was nice in theory, but in practice it's just too hard
> > to update selectively, and it
On Wed, Feb 22, 2023 at 2:15 AM Markus Armbruster wrote:
>
> John Snow writes:
>
> > On Tue, Feb 21, 2023, 1:50 AM Markus Armbruster wrote:
> >
> >> John Snow writes:
> >>
> >> > Once upon a time, "sphinx-build" on certain RPM plat
t
for you to fetch changes up to 6832189fd791622c30e7bbe3a12b76be14dc1158:
python: drop pipenv (2023-02-22 23:35:03 -0500)
Python
Only minor testing updates.
----
Jo
The pipenv tool was nice in theory, but in practice it's just too hard
to update selectively, and it makes using it a pain. The qemu.qmp repo
dropped pipenv support a while back and it's been functioning just fine,
so I'm backporting that change here to qemu.git.
Signed-off-by: Joh
Pylint 2.16 adds a few new checks that cause the optional check-tox CI
job to fail.
1. The superfluous-parens check seems to be a bit more aggressive,
2. broad-exception-raised is new; it discourages "raise Exception".
Fix these minor issues and turn the lights green.
Signed-off-by:
On Tue, Feb 21, 2023, 6:03 AM Paolo Bonzini wrote:
> On 2/21/23 02:24, John Snow wrote:
> > At the moment, we look for just "python3" and "python", which is good
> > enough almost all of the time. But ... if you are on a platform that
> > uses an older
On Tue, Feb 21, 2023, 1:42 AM Markus Armbruster wrote:
> John Snow writes:
>
> > On Wed, Feb 15, 2023 at 8:39 AM Markus Armbruster
> wrote:
> >>
> >> I had a few suggestions, but none of them requires a respin. Let's
> >> discuss them, and then
On Tue, Feb 21, 2023, 6:31 AM Paolo Bonzini wrote:
> On 2/21/23 02:24, John Snow wrote:
> > Once upon a time, "sphinx-build" on certain RPM platforms invoked
> > specifically a Python 2.x version, while "sphinx-build-3" was a distro
> > shim for the Pyt
On Tue, Feb 21, 2023, 1:50 AM Markus Armbruster wrote:
> John Snow writes:
>
> > Once upon a time, "sphinx-build" on certain RPM platforms invoked
> > specifically a Python 2.x version, while "sphinx-build-3" was a distro
> > shim for the Python
ince it is safe under our supported platform policy, bump our minimum
supported version of Python to 3.7.
Signed-off-by: John Snow
---
docs/conf.py | 4 ++--
configure| 8
python/Makefile | 10 +-
python/setup.cfg | 7 +++
python
hon that we
cannot use.
- In the event that no suitable python is found, the first python found
is the version used to generate the human-readable error message.
- The error message isn't printed right away to allow later
configuration code to pick up an explicitly configured python.
On Wed, Feb 15, 2023 at 8:39 AM Markus Armbruster wrote:
>
> I had a few suggestions, but none of them requires a respin. Let's
> discuss them, and then I merge.
Hiya, I lost track of things a little due to the other Python
discussion. Who is waiting for whom?
--js
the way forward is to work with Paolo to implement
a proper venv solution for the build tree that will help mitigate the
fallout from (2) by automating the use of a pip-provided Sphinx in the
cases where the distro-provided version is insufficient.
OK, seeya later!
--js
John Snow (6):
configu
.
Signed-off-by: John Snow
---
configure | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 6abf5a72078..0d0cca53f09 100755
--- a/configure
+++ b/configure
@@ -1059,7 +1059,10 @@ fi
if ! check_py_version "$python"; then
error_exit &
27;sphinx-build' prior to 'sphinx-build-3',
which will prefer pip/venv installed versions of sphinx if they're
available.
This adds an extremely convenient ability to test document building
ability in QEMU across multiple versions of Sphinx for the purposes of
compatibility
likely the safest option if you don't have a lot
of Python knowhow.
Signed-off-by: John Snow
---
tests/docker/dockerfiles/centos8.docker | 4
1 file changed, 4 insertions(+)
diff --git a/tests/docker/dockerfiles/centos8.docker
b/tests/docker/dockerfiles/centos8.docker
index a3bf
, meanwhile, is just to prove that bumping our dependency does
not introduce any regressions in our test suite or developer
processes. It also is meant to demonstrate the relatively small changes
needed to begin utilizing 3.7 as a minimum.
Signed-off-by: John Snow
---
tests/docker/dockerfiles/centos8
Sementsov-Ogievskiy
I think I came to the same conclusions:
https://gitlab.com/jsnow/qemu/-/commit/19bac2ea70cbb5ada4f94d6223cdc96f51a2b3d9
Reviewed-by: John Snow
> ---
> python/qemu/utils/qemu_ga_client.py | 6 +++---
> tests/qemu-iotests/iotests.py | 4 ++--
> 2 files change
On Wed, Feb 15, 2023 at 8:26 AM Vladimir Sementsov-Ogievskiy
wrote:
>
> Now make check-dev called in python/ directory fails due to this error.
> Let's fix it.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: John Snow
I've got a similar patch queued alre
On Mon, Feb 20, 2023 at 1:16 AM Thomas Huth wrote:
>
> On 17/02/2023 21.46, John Snow wrote:
> > On Thu, Feb 16, 2023 at 5:58 AM Thomas Huth wrote:
> >>
> >> On 15/02/2023 20.05, Markus Armbruster wrote:
> >>> The discussion under PATCH 6 makes me think
On Mon, Feb 20, 2023 at 3:12 AM Philippe Mathieu-Daudé
wrote:
>
> On 17/2/23 11:31, Fiona Ebner wrote:
> > Fixes: e4baa9f00b ("AHCI: Replace DPRINTF with trace-events")
> > Signed-off-by: Fiona Ebner
> > ---
> >
> > Or should it be sorted alphabetically below execute_ncq_command_unsup?
> > I felt
On Tue, Feb 14, 2023 at 12:26 PM Kevin Wolf wrote:
>
> Am 14.02.2023 um 15:03 hat Paolo Bonzini geschrieben:
> > In the case of Python the issue is not the interpreter per se, though
> > there are a couple new feature in Python 3.7 that are quite nice (for
> > example improved data classes[1] or c
On Thu, Feb 16, 2023 at 5:58 AM Thomas Huth wrote:
>
> On 15/02/2023 20.05, Markus Armbruster wrote:
> > The discussion under PATCH 6 makes me think there's a bit of confusion
> > about the actual impact of dropping support for Python 3.6. Possibly
> > because it's spelled out in the commit messa
;
> > Or should it be sorted alphabetically below execute_ncq_command_unsup?
>
> No, there is no convention...
>
> > I felt read and write belong close together and this reflects the
> > positions in the code.
>
> probably for this reason.
>
> Reviewed-by: Philippe Mathieu-Daudé
>
> Thanks!
>
Reviewed-by: John Snow
On Fri, Feb 17, 2023, 12:14 PM Daniel P. Berrangé
wrote:
> On Fri, Feb 17, 2023 at 11:35:44AM -0500, John Snow wrote:
> > On Thu, Feb 16, 2023, 2:44 PM Daniel P. Berrangé
> > wrote:
> >
> > > On Thu, Feb 16, 2023 at 01:15:30PM -0500, John Snow wrote:
> > >
On Thu, Feb 16, 2023, 2:44 PM Daniel P. Berrangé
wrote:
> On Thu, Feb 16, 2023 at 01:15:30PM -0500, John Snow wrote:
> > On Wed, Feb 15, 2023 at 2:25 PM Alex Bennée
> wrote:
> > >
> > > The 22.04 LTS release has been out for almost a year now so its time
> >
On Wed, Feb 15, 2023 at 2:25 PM Alex Bennée wrote:
>
> The 22.04 LTS release has been out for almost a year now so its time
> to update all the remaining images to the current LTS. We can also
> drop some hacks we need for older clang TSAN support.
We still support Ubuntu 20.04 until 2024 though,
On Wed, Feb 15, 2023, 5:53 AM Fiona Ebner wrote:
> Am 14.02.23 um 19:21 schrieb John Snow:
> > On Thu, Feb 2, 2023 at 7:08 AM Fiona Ebner wrote:
> >>
> >> Hi,
> >> over the years we've got 1-2 dozen reports[0] about suddenly
> >> missing/cor
On Fri, Feb 10, 2023 at 5:30 AM Paolo Bonzini wrote:
>
> On 2/10/23 00:32, John Snow wrote:
> >> It's possible to teach lcitool to use pip instead to install
> >> docutils, sphinx and sphinx-rtd-theme
> >
> > I will say that once upon a time, Peter Mayd
On Fri, Feb 10, 2023 at 5:38 AM Daniel P. Berrangé wrote:
>
> On Thu, Feb 09, 2023 at 10:40:32AM -0500, John Snow wrote:
> > This is just a proof-of-concept patch, as these files are lcitool
> > generated. The real fix will involve updating the lcitool configuration
> >
On Fri, Feb 10, 2023 at 2:45 PM Eric Blake wrote:
>
> On Thu, Feb 09, 2023 at 10:40:30AM -0500, John Snow wrote:
> > At the moment, we look for just "python3" and "python", which is good
> > enough almost all of the time. But ... if you are on a platform th
On Wed, Feb 15, 2023 at 4:43 AM Markus Armbruster wrote:
>
> John Snow writes:
>
> > This patch creates a new type, QAPIExpression, which represents a parsed
> > expression complete with QAPIDoc and QAPISourceInfo.
> >
> > This patch turns parser.exprs into
On Wed, Feb 15, 2023, 8:36 AM Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > John Snow writes:
> >
> >> Pylint under 3.6 does not believe that Collection is subscriptable at
> >> runtime. It is, making this a Pylint
> >> bug
We can remove this alias as it only has two usages now, and no longer
pays for the confusion of "yet another type".
Signed-off-by: John Snow
---
scripts/qapi/expr.py | 13 +++--
scripts/qapi/parser.py | 5 ++---
2 files changed, 5 insertions(+), 13 deletions(-)
diff --git
New versions of flake8 don't like same-line comments. (It's a version
newer than what fc37 ships, but it still makes my life easier to fix it
now.)
Signed-off-by: John Snow
Reviewed-by: Markus Armbruster
---
scripts/qapi/.flake8 | 3 ++-
1 file changed, 2 insertions(+), 1 deletio
.13.9 was
released 2022-05-13, about seven months after the bug was closed.
The least-annoying fix here is to just use the more specific type
Sequence, only because it seems to work in 3.6.
Signed-off-by: John Snow
---
scripts/qapi/expr.py | 6 +++---
1 file changed, 3 insertions(+), 3 dele
" all the
way through expr.py and into schema.py. Several assertions around
packing and unpacking this data can be removed as a result.
Signed-off-by: John Snow
---
scripts/qapi/expr.py | 82 +-
scripts/qapi/parser.py | 46 ++--
sc
Newer versions of pylint disable the "no-self-use" message by
default. Older versions don't, though. If we leave the suppressions in,
pylint yelps about useless options. Just tell pylint to shush.
Signed-off-by: John Snow
Reviewed-by: Markus Armbruster
---
scripts/qapi/pylintr
x27;s no intermediate state where it's
needed now.
- Minor style issues.
John Snow (6):
qapi: Update flake8 config
qapi: update pylint configuration
qapi: Add minor typing workaround for 3.6
qapi/parser: add QAPIExpression type
qapi: remove _JSONObject
qapi: remove JSON
it's worth with mypy's
current expressive power. As such, declare this "done enough for now".
Signed-off-by: John Snow
---
scripts/qapi/parser.py | 4
1 file changed, 4 deletions(-)
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index d570086e1a9..878f90b
On Thu, Feb 9, 2023 at 7:31 PM John Snow wrote:
>
> Howdy, this series increases our minimum python version to 3.7.
>
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/771780626
> (All green!)
> GL: https://gitlab.com/jsnow/qemu/-/commits/python-require-37
>
> Patch
On Thu, Feb 2, 2023 at 7:08 AM Fiona Ebner wrote:
>
> Hi,
> over the years we've got 1-2 dozen reports[0] about suddenly
> missing/corrupted MBR/partition tables. The issue seems to be very rare
> and there was no success in trying to reproduce it yet. I'm asking here
> in the hope that somebody h
On Thu, Feb 9, 2023 at 3:46 PM Stefan Hajnoczi wrote:
>
> Hi,
> For those using the https://github.com/stefanha/patches tool to work
> with QEMU patch series, please update your configuration file to the new
> patches.json URL:
>
> $ $EDITOR ~/.patchesrc
> [fetch]
> url=https://patches.qemu.
On Fri, Feb 10, 2023, 11:26 AM John Snow wrote:
>
>
> On Fri, Feb 10, 2023, 10:44 AM Markus Armbruster
> wrote:
>
>> John Snow writes:
>>
>> > mypy can only narrow the type of `Mapping[str, ...].keys() & Set[str]`
>> > to `AbstractSet[str]`
On Sat, Feb 11, 2023, 5:06 AM Markus Armbruster wrote:
> John Snow writes:
>
> > --3b01fe05f45a096a
> > Content-Type: text/plain; charset="UTF-8"
> >
> > On Fri, Feb 10, 2023, 7:33 AM Markus Armbruster
> wrote:
> >
> &
On Sat, Feb 11, 2023, 1:49 AM Markus Armbruster wrote:
> John Snow writes:
>
> > This patch creates a new type, QAPIExpression, which represents a parsed
> > expression complete with QAPIDoc and QAPISourceInfo.
> >
> > This patch turns parser.exprs into a list of Q
On Tue, Feb 14, 2023, 11:49 AM John Snow wrote:
>
>
> On Mon, Feb 13, 2023, 8:20 AM Markus Armbruster wrote:
>
>> *** BLURB HERE ***
>>
>
> 🤫
>
>
>> Markus Armbruster (2):
>> docs/devel/qapi-code-gen: Belatedly update features documentation
&
On Mon, Feb 13, 2023, 8:20 AM Markus Armbruster wrote:
> *** BLURB HERE ***
>
🤫
> Markus Armbruster (2):
> docs/devel/qapi-code-gen: Belatedly update features documentation
> docs/devel/qapi-code-gen: Fix a missing 'may', clarify SchemaInfo
>
> docs/devel/qapi-code-gen.rst | 16 --
On Fri, Feb 10, 2023, 2:45 AM Thomas Huth wrote:
> On 10/02/2023 01.31, John Snow wrote:
> > If we begin requiring Python 3.7+, a few platforms are going to need to
> > install an additional package.
> >
> > This is at least mildly annoying to the user (and I hate
On Fri, Feb 10, 2023, 11:32 AM Peter Maydell
wrote:
> On Fri, 10 Feb 2023 at 16:01, John Snow wrote:
> > On Fri, Feb 10, 2023, 5:41 AM Peter Maydell
> wrote:
> >> On Fri, 10 Feb 2023 at 00:31, John Snow wrote:
> >> This confuses me. We work fine with Python 3.6
On Fri, Feb 10, 2023, 10:44 AM Markus Armbruster wrote:
> John Snow writes:
>
> > mypy can only narrow the type of `Mapping[str, ...].keys() & Set[str]`
> > to `AbstractSet[str]` and not a `Set[str]`. As a result, if the type of
> > an expression is changed to a Mapp
On Fri, Feb 10, 2023, 11:17 AM Paolo Bonzini wrote:
> On Fri, Feb 10, 2023 at 4:28 PM John Snow wrote:
> > PS, while you're here, how does this new loop interfere with your
> "custom python specified" flag for meson? I think meson uses the version of
> python *it*
On Fri, Feb 10, 2023, 5:41 AM Peter Maydell
wrote:
> On Fri, 10 Feb 2023 at 00:31, John Snow wrote:
> >
> > CentOS 8 does not ship with a sphinx new enough for our purposes (It
> > necessarily uses Python 3.6), so drop this from this build. We can
> > resume building
On Fri, Feb 10, 2023, 5:46 AM Paolo Bonzini wrote:
> On 2/10/23 01:31, John Snow wrote:
> > At the moment, we look for just "python3" and "python", which is good
> > enough almost all of the time. But ... if you are on a platform that
> > uses an older
On Fri, Feb 10, 2023, 7:33 AM Markus Armbruster wrote:
> Another observation...
>
> John Snow writes:
>
> > Primarily, this reduces a nesting level of a particularly long
> > block. It's mostly code movement, but a new docstring is created.
> >
> > It
CentOS 8 does not ship with a sphinx new enough for our purposes (It
necessarily uses Python 3.6), so drop this from this build. We can
resume building docs on CentOS 9 if we wish, but we also currently test
and build docs on Fedora, Ubuntu, Alpine and Debian.
Signed-off-by: John Snow
The pipenv tool was nice in theory, but in practice it's just too hard
to update selectively, and it makes using it a pain. The qemu.qmp repo
dropped pipenv support a while back and it's been functioning just fine,
so I'm backporting that change here to qemu.git.
Signed-of
Pylint 2.16 adds a few new checks that cause the optional check-tox CI
job to fail.
1. The superfluous-parens check seems to be a bit more aggressive,
2. broad-exception-raised is new; it discourages "raise Exception".
Fix these minor issues and turn the lights green.
Signed-off-by:
r how to install
newer Python packages.
Signed-off-by: John Snow
---
configure | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index ea8c973d13b..bf512273f44 100755
--- a/configure
+++ b/configure
@@ -1058,7 +1058,10 @@ fi
if ! check_py_version &qu
e it is safe to under our supported platform policy, bump our
minimum supported version of Python to 3.7.
Signed-off-by: John Snow
---
docs/conf.py | 4 ++--
configure| 8
python/Makefile | 10 +-
python/setup.cfg | 7 +++
python
ration code to pick up an explicitly configured python.
Signed-off-by: John Snow
---
configure | 33 +
1 file changed, 25 insertions(+), 8 deletions(-)
diff --git a/configure b/configure
index 64960c6000f..ea8c973d13b 100755
--- a/configure
+++ b/configure
@@ -592,
This is just a proof-of-concept patch, as these files are lcitool
generated. The real fix will involve updating the lcitool configuration
and updating these files that way.
This is just to prove that bumping our dependency works.
Signed-off-by: John Snow
---
tests/docker/dockerfiles/centos8
sage for patch 7 with explicit version info
- Added DO-NOT-MERGE to patch 5's title
- Tested tests/vm/freebsd, netbsd, and openbsd in addition to full CI
RFC:
- Patch 5 is just a proof-of-concept; we need to update lcitool instead.
- Cleber, I need to update your ansible scripts. How do I tes
On Thu, Feb 9, 2023 at 5:43 PM Paolo Bonzini wrote:
>
>
>
> Il gio 9 feb 2023, 16:40 John Snow ha scritto:
>>
>> CentOS 8 does not ship with a sphinx new enough for our purposes (It
>> necessarily uses Python 3.6), so drop this from this build. We can
>> re
On Thu, Feb 9, 2023 at 1:03 PM Daniel P. Berrangé wrote:
>
> On Thu, Feb 09, 2023 at 11:40:57AM -0500, John Snow wrote:
> > On Thu, Feb 9, 2023 at 11:27 AM Daniel P. Berrangé
> > wrote:
> > >
> > > On Thu, Feb 09, 2023 at 10:40:34AM -0500, John Snow wrote:
&
601 - 700 of 4328 matches
Mail list logo
