Re: [PATCH v15 05/14] migration: convert socket backend to accept MigrateAddress

t; required for socket connection into well defined SocketAddress struct. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v14 04/14] fixup! migration: convert migration 'uri' into 'MigrateAddress'

Daniel P. Berrangé wrote: > On Thu, Oct 19, 2023 at 04:23:43PM -0300, Fabiano Rosas wrote: >> Signed-off-by: Fabiano Rosas >> --- >> migration/file.c | 2 +- >> migration/file.h | 1 + >> migration/migration.c | 6 ++ >> 3 files changed, 8 insertions(+), 1 deletion(-) > > Reviewed-

Re: [PATCH v15 03/14] migration: convert migration 'uri' into 'MigrateAddress'

; > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v15 04/14] fixup! migration: convert migration 'uri' into 'MigrateAddress'

Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Merged with previous.

Re: [PATCH v15 02/14] fixup! migration: New QAPI type 'MigrateAddress'

Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas > Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Merging with previous one.

Re: [PATCH v4 5/5] migration: Change ram_save_queue_pages() retval to bool

Peter Xu wrote: > After we have errp which contains the more detailed error message, make > ram_save_queue_pages() returns bool in its stack. > > Signed-off-by: Peter Xu > --- > migration/ram.h | 4 ++-- > migration/migration.c | 16 > migration/ram.c | 18 +

Re: [PATCH v4 4/5] migration: Change ram_dirty_bitmap_reload() retval to bool

eter Xu Reviewed-by: Juan Quintela

Re: [PATCH v4 2/5] migration: Allow network to fail even during recovery

migrate-pause when needed. > > After bouncing back to PAUSED stage, one can recover again. > > Reported-by: Xiaohui Li > Reviewed-by: Fabiano Rosas > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2111332 > Signed-off-by: Peter Xu Review

Re: [PATCH v4 1/5] migration: Refactor error handling in source return path

gt; We need to re-export qemu_file_get_error_obj() to do the last one. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Patch is really long. And you stated in the commit how to split it to make it more "digestable".

Re: [PATCH V2 5/6] cpr: reboot mode

guest RAM to the > file, the memory backend must be shared, and the @x-ignore-shared migration > capability must be set. Guest RAM must be non-volatile across reboot, such > as by backing it with a dax device, but this is not enforced. The restarted > qemu arguments must match those used

Re: [PATCH V2 6/6] tests/qtest: migration: add reboot mode test

Steve Sistare wrote: > Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela

Re: [PATCH V2 1/6] migration: mode parameter

s added, except that the mode is > shown by the 'info migrate' command. > > Signed-off-by: Steve Sistare Reviewed-by: Juan Quintela As nobody complained for this on v1, I will consider it done.

Re: [PATCH 5/5] migration: Print expected-downtime on completion

Joao Martins wrote: > Right now, migration statistics either print downtime or expected > downtime depending on migration completing of in progress. Also in the > beginning of migration by printing the downtime limit as expected > downtime, when estimation is not available. > > The pending_size is

Re: [PATCH v2 5/5] migration: Add tracepoints for downtime checkpoints

time measurements necessary. > > Drop loadvm_postcopy_handle_run_bh() tracepoint alongside, because they > service the same purpose, which was only for postcopy. We then have > unified prefix for all downtime relevant tracepoints. > > Co-developed-by: Joao Martins > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [PATCH v2 4/5] migration: migration_stop_vm() helper

Peter Xu wrote: > Provide a helper for non-COLO use case of migration to stop a VM. This > prepares for adding some downtime relevant tracepoints to migration, where > they may or may not apply to COLO. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela

Re: [PATCH v2 3/5] migration: Add per vmstate downtime tracepoints

> concurrently. > > Tracking both sides make sense because device load() and save() can be > imbalanced, one device can save() super fast, but load() super slow, vice > versa. We can't figure that out without tracing both. > > Signed-off-by: Peter Xu Reviewed-by: Ju

Re: [PATCH v2 2/5] migration: Add migration_downtime_start|end() helpers

Peter Xu wrote: > Unify the three users on recording downtimes with the same pair of helpers. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela queued.

Re: [PATCH v2 1/5] migration: Set downtime_start even for postcopy

p the temporary variable > in postcopy_start() along the way. > > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela queued.

Re: [PATCH v3 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

Markus Armbruster wrote: > Peter Xu writes: > >> On Wed, Oct 11, 2023 at 04:21:02PM +0200, Markus Armbruster wrote: >> IIRC both of them used to be the goals: either allow compat properties for >> old machine types, or specify migration parameters in cmdline for easier >> debugging and tests. I

Re: [PATCH 00/52] migration/rdma: Error handling fixes

Daniel P. Berrangé wrote: > On Wed, Oct 04, 2023 at 08:00:34PM +0200, Juan Quintela wrote: >> Daniel P. Berrangé wrote: >> > On Tue, Sep 19, 2023 at 12:49:46PM -0400, Peter Xu wrote: >> >> On Mon, Sep 18, 2023 at 04:41:14PM +0200, Markus Armbruster wrote: &

Re: [PATCH] ppc: qtest already exports qtest_rtas_call()

David Gibson wrote: > On Mon, Oct 30, 2023 at 05:41:36PM +0100, Cédric le Goater wrote: >> On 10/30/23 17:38, Juan Quintela wrote: >> > Having two functions with the same name is a bad idea. As spapr only >> > uses the function locally, made it static. >> > &

[PULL 34/38] migration: migration_rate_limit_reset() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-9-quint...@redhat.com> --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 2 +- migration/migration.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff

[PULL 25/38] migration: Deprecate old compression method

Acked-by: Stefan Hajnoczi Acked-by: Peter Xu Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-6-quint...@redhat.com> --- docs/about/deprecated.rst | 8 + qapi/migration.json | 63 ++- mig

[PULL 09/38] migration: Remove save_page_use_compression()

After previous patch, we disable the posiblity that we use compression together with xbzrle. So we can use directly migrate_compress(). Once there, now we don't need the rs parameter, so remove it. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724

[PULL 37/38] migration: Remove transferred atomic counter

After last commit, it is a write only variable. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-12-quint...@redhat.com> --- migration/migration-stats.h | 4 migration/multifd.c | 3 --- migration/ram.c | 1 - 3 files chan

[PULL 36/38] migration: Use migration_transferred_bytes()

s two values are used to: a - present to the user b - calculate the rate_limit So a few KB here and there is not going to make a difference. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-11-quint...@redhat.com> --- migration/migration.c | 2 +- migr

[PULL 24/38] migration: Deprecate block migration

It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-5-quint...@redhat.com> ---

[PULL 28/38] qemu_file: Use a stat64 for qemu_file_transferred

This way we can read it from any thread. I checked that it gives the same value as the current one. We never use two qemu_files at the same time. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-3-quint...@redhat.com> --- migration/migration-stats

[PULL 23/38] migration: migrate 'blk' command option is deprecated.

Use blocked-mirror with NBD instead. Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-4-quint...@redhat.com> --- docs/about/deprecated.rst | 9 + qapi/migration.json

[PULL 27/38] qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_buffer

We only call qemu_file_transferred_* on the sending side. Remove the increment at qemu_file_fill_buffer() and add asserts to qemu_file_transferred* functions. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-2-quint...@redhat.com> --- migratio

[PULL 11/38] migration: Simplify compress_page_with_multithread()

Move the goto to a while true. Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-6-quint...@redhat.com> --- migration/ram-compress.c | 48 1 file changed, 24 insertions(+), 24 del

[PULL 30/38] migration: Use the number of transferred bytes directly

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-5-quint...@redhat.com> --- migration/migration-stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration-stats.c b/migration/migration-stats.c index 4cc989d975..1

[PULL 21/38] qemu-iotests: Filter warnings about block migration being deprecated

Create a new filter that removes the two warnings for test 183. Reviewed-by: Hanna Czenczek Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-2-quint...@redhat.com> --- tests/qemu-iotests/183 | 2 +- tests/qemu-iotests/common.filter | 7 +++ 2 files chan

[PULL 14/38] migration: Export send_queued_data()

This function is only used for compression. So we rename it as compress_send_queued_data(). We put it on ram-compress.h because we are moving it later to ram-compress.c. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-9-quint...@redhat.

[PULL 22/38] migration: migrate 'inc' command option is deprecated.

Use blockdev-mirror with NBD instead. Reviewed-by: Thomas Huth Acked-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231018115513.2163-3-quint...@redhat.com> --- docs/about/deprecated.rst | 8 qapi/migration.json

[PULL 32/38] qemu-file: Remove _noflush from qemu_file_transferred_noflush()

qemu_file_transferred() don't exist anymore, so we can reuse the name. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-7-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 9 - migration/bloc

[PULL 29/38] qemu_file: total_transferred is not used anymore

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-4-quint...@redhat.com> --- migration/qemu-file.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 384985f534..641ab703cc 100644 --- a/migratio

[PULL 33/38] migration: migration_transferred_bytes() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-8-quint...@redhat.com> --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 6 +++--- migration/migration.c | 6 +++--- 3 files changed, 7 insertions(+), 9 del

[PULL 08/38] migration: Give one error if trying to set COMPRESSION and XBZRLE

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-3-quint...@redhat.com> --- migration/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/options.c b/migration/options.c index b8c3c3218d..37fa1cfe74 100644 --- a/mig

[PULL 35/38] qemu-file: Simplify qemu_file_get_error()

If we pass a NULL error is the same that returning directly the value. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-10-quint...@redhat.com> --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migratio

[PULL 38/38] qemu-file: Make qemu_fflush() return errors

check for f->last_error because qemu_fflush() returns it at the beggining of the function. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-13-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qe

[PULL 02/38] migration/doc: Add documentation for backwards compatiblity

State what are the requeriments to get migration working between qemu versions. And once there explain how one is supposed to implement a new feature/default value and not break migration. Reviewed-by: Vladimir Sementsov-Ogievskiy Acked-by: Peter Xu Signed-off-by: Juan Quintela Message-ID

[PULL 17/38] migration: Rename ram_compressed_pages() to compress_ram_pages()

We are moving to have all functions exported from ram-compress.c to start with compress_. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-12-quint...@redhat.com> --- migration/ram-compress.h | 2 +- migration/ram-compress.c | 2 +- migration

[PULL 31/38] qemu_file: Remove unused qemu_file_transferred()

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231025091117.6342-6-quint...@redhat.com> --- migration/qemu-file.h | 18 -- migration/qemu-file.c | 7 --- 2 files changed, 25 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-

[PULL 00/38] Migration 20231031 patches

ation PULL for 20231020. - I removed vmstate_register(big problems with s390x) - I added yet more countes (juan) CI: https://gitlab.com/juan.quintela/qemu/-/pipelines/1055797950 Please apply. Thanks, Juan. ---- Juan Quintela (34): mig

[PULL 04/38] migration/doc: We broke backwards compatibility

it does a hard reboot. Acked-by: Peter Xu Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-5-quint...@redhat.com> --- docs/devel/migration.rst | 202 +++ 1 file changed, 202 insertions(+) diff --git a/docs/devel

[PULL 26/38] migration: Stop migration immediately in RDMA error paths

an Li (Fujitsu) Cc: Markus Armbruster Cc: Juan Quintela Cc: Fabiano Rosas Reported-by: Thomas Huth Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231024163933.516546-1-pet...@redhat.com> --- migration

[PULL 05/38] migration: Receiving a zero page non zero is an error

e: commit a1febc4950f2c6232c002f401d7cd409f6fa6a88 Author: Richard Henderson Date: Mon Aug 29 11:46:14 2016 -0700 cutils: Export only buffer_is_zero Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20231019085259.13307-2-quint...@redhat.com> ---

[PULL 20/38] migration: set file error on subsection loading

From: Marc-André Lureau commit 13cde50889237 ("vmstate: Return error in case of error") sets QemuFile error to stop reading from it and report to the caller (checked by unit tests). We should do the same on subsection loading error. Signed-off-by: Marc-André Lureau Reviewed-by: Jua

[PULL 15/38] migration: Move ram_flush_compressed_data() to ram-compress.c

As we export it, rename it compress_flush_data(). Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-10-quint...@redhat.com> --- migration/ram-compress.h | 1 + migration/ram-compress.c | 9 + migration/ram.c | 17 --

[PULL 10/38] migration: Make compress_data_with_multithreads return bool

Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-5-quint...@redhat.com> --- migration/ram-compress.h | 4 ++-- migration/ram-compress.c | 17 ++--- migration/ram.c | 3 +-- 3 files changed, 13 inse

[PULL 19/38] migration: rename vmstate_save_needed->vmstate_section_needed

From: Marc-André Lureau The function is used on save at this point. The following commits will use it on load. Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231024084043.2926316-5-marcandre.lur...@redhat.com> --- include/mig

[PULL 13/38] migration: Create compress_update_rates()

So we can move more compression_counters stuff to ram-compress.c. Create compression_counters struct to add the stuff that was on MigrationState. Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-8-quint...@redhat.

[PULL 16/38] migration: Merge flush_compressed_data() and compress_flush_data()

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-11-quint...@redhat.com> --- migration/ram-compress.h | 1 - migration/ram-compress.c | 17 ++--- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/migration/ram-compre

[PULL 07/38] migration: Give one error if trying to set MULTIFD and XBZRLE

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-2-quint...@redhat.com> --- migration/options.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/options.c b/migration/options.c index 42fb818956..b8c3c3218d 100644 --- a/mig

[PULL 18/38] migration/ram: Fix compilation with -Wshadow=local

From: Thomas Huth Rename the variable here to avoid that it shadows a variable from the beginning of the function scope. With this change the code now successfully compiles with -Wshadow=local. Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID

[PULL 06/38] migration: Rename ram_handle_compressed() to ram_handle_zero()

Now that we know it only handles zero, we can remove the ch parameter. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20231019085259.13307-3-quint...@redhat.com> --- migration/ram.h | 2 +- migration/ram.c | 10 +- migration/rdma.

[PULL 12/38] migration: Move busy++ to migrate_with_multithread

And now we can simplify save_compress_page(). Reviewed-by: Lukas Straub Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231019110724.15324-7-quint...@redhat.com> --- migration/ram-compress.c | 1 + migration/ram.c | 8 ++-- 2 files changed, 3 inse

[PULL 01/38] migration/doc: Add contents

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-2-quint...@redhat.com> --- docs/devel/migration.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst index c3e1400c0c..4d6a98ae58 100644 ---

[PULL 03/38] migration/doc: How to migrate when hosts have different features

Sometimes devices have different features depending of things outside of qemu. For instance the kernel. Document how to handle that cases. Acked-by: Peter Xu Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20231018112827.1325-4-quint...@redhat.com> --- docs

[PATCH] ppc: qtest already exports qtest_rtas_call()

er command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. make: *** [Makefile:162: run-ninja] Error 1 Signed-off-by: Juan Quintela --- include/hw/ppc/spapr_rtas.h | 10 -- hw/ppc/spapr_rtas.c | 4 ++-- 2 files changed, 2 insertions(+), 12

Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info

@redhat.com/ > > Cc: Joe Jin > Signed-off-by: Dongli Zhang > Reviewed-by: Daniel P. Berrangé > Reviewed-by: David Woodhouse Reviewed-by: Juan Quintela But I wonder how I did get CC'd on this patch O:-) Later, Juan.

QEMU developers fortnightly conference call for 2023-10-31

Hi If you have any topics for this week Conference call, please answer to this email. Thanks, Juan. QEMU developers fortnightly conference call Tuesday 2023-10-31 ⋅ 14:00 – 15:00 Central European Time - Madrid Location https://meet.jit.si/kvmcallmeeting https://www.google.com/url?q=https

Re: [PULL 00/39] Migration 20231024 patches

Stefan Hajnoczi wrote: > On Tue, 24 Oct 2023 at 23:45, Juan Quintela wrote: >> >> The following changes since commit a95260486aa7e78d7c7194eba65cf03311ad94ad: >> >> Merge tag 'pull-tcg-20231023' of https://gitlab.com/rth7680/qemu into >> staging (202

Re: [PATCH v2 3/3] util/uuid: Remove UUID_FMT_LEN

Cédric Le Goater wrote: > Dangerous and now unused. > > Cc: Fam Zheng > Signed-off-by: Cédric Le Goater Reviewed-by: Juan Quintela

Re: [PATCH 2/2] vfio/pci: Fix buffer overrun when writing the VF token

io/pci: add support for VF token") > Cc: Alex Williamson > Signed-off-by: Cédric Le Goater Reviewed-by: Juan Quintela For what is worth O:-)

Re: [PATCH 1/2] util/uuid: Add UUID_STR_LEN definition

est-uuid.c | 2 +- > util/uuid.c | 2 +- > 8 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/include/qemu/uuid.h b/include/qemu/uuid.h Reviewed-by: Juan Quintela

[PATCH v2 10/12] migration: Use migration_transferred_bytes()

s two values are used to: a - present to the user b - calculate the rate_limit So a few KB here and there is not going to make a difference. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration.c | 2 +- migration/ram.c | 6 +++--- 2 files changed, 4 insertions(

[PATCH v2 03/12] qemu_file: total_transferred is not used anymore

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 384985f534..641ab703cc 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -41,9 +41,6

[PATCH v2 12/12] qemu-file: Make qemu_fflush() return errors

check for f->last_error because qemu_fflush() returns it at the beggining of the function. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- In v2: Now that we call always qemu_fflush() for all files, we can simplify qemu_fclose() --- migrat

[PATCH v2 09/12] qemu-file: Simplify qemu_file_get_error()

If we pass a NULL error is the same that returning directly the value. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 0158db2a54

[PATCH v2 04/12] migration: Use the number of transferred bytes directly

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration-stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration-stats.c b/migration/migration-stats.c index 4cc989d975..1d9197b4c3 100644 --- a/migration/migration-stats.c +++ b

[PATCH v2 05/12] qemu_file: Remove unused qemu_file_transferred()

Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/qemu-file.h | 18 -- migration/qemu-file.c | 7 --- 2 files changed, 25 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-file.h index a29c37b0d0..8b71152754 100644 --- a/migration/qemu

[PATCH v2 02/12] qemu_file: Use a stat64 for qemu_file_transferred

This way we can read it from any thread. I checked that it gives the same value as the current one. We never use two qemu_files at the same time. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/qemu-file.c | 5 +++-- 2 files

[PATCH v2 11/12] migration: Remove transferred atomic counter

After last commit, it is a write only variable. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/multifd.c | 3 --- migration/ram.c | 1 - 3 files changed, 8 deletions(-) diff --git a/migration/migration-stats.h b

[PATCH v2 01/12] qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_buffer

We only call qemu_file_transferred_* on the sending side. Remove the increment at qemu_file_fill_buffer() and add asserts to qemu_file_transferred* functions. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration

[PATCH v2 08/12] migration: migration_rate_limit_reset() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 2 +- migration/migration.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration

[PATCH v2 00/12] migration: Yet another round of atomic counters

have three atomic counters: - multifd_bytes - rdma_bytes - qemu_file_trasferred And we only need to setup one (and only one) of these each time that we sent anything. Please review. Later, Juan. Juan Quintela (12): qemu-file: Don't increment qemu_file_transferred at qemu_file_fill_b

[PATCH v2 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush()

qemu_file_transferred() don't exist anymore, so we can reuse the name. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- v2: Update the documentation (thanks fabiano) --- migration/qemu-file.h | 9 - migration/block.c | 4 ++-- migration/qemu-file.c | 2 +- migr

[PATCH v2 07/12] migration: migration_transferred_bytes() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 6 +++--- migration/migration.c | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/migration/migration-stats.h b/migration

Re: [PATCH 02/12] qemu_file: Use a stat64 for qemu_file_transferred

Eric Blake wrote: > On Tue, Oct 24, 2023 at 05:10:32PM +0200, Juan Quintela wrote: >> This way we can read it from any thread. >> I checked that it gives the same value than the current one. We never > > s/than/as/ Done >> use to qemu_files at the same time. > > s/to/two/ Done Thanks.

Re: [PATCH 01/12] qemu-file: We only call qemu_file_transferred_* on the sending side

Fabiano Rosas wrote: > Juan Quintela writes: > >> Remove the increase in qemu_file_fill_buffer() and add asserts to >> qemu_file_transferred* functions. > > Patch looks ok, but I would rewrite the whole commit message like this: > > Don't increment qemu_file_t

Re: [PATCH v3 1/1] migration: vmstate_register() check that instance_id is valid

Peter Xu wrote: >> > IIUC you want to suggest using vmstate_register_any(), but I think it's all >> > fine to do vmstate_register(VMSTATE_INSTANCE_ID_ANY)? You didn't have a >> > commit message, so I am guessing.. >> >> This is v3. v1 and v2 had much more messages, so I thought this was not >>

Re: [PATCH v2] migration: Stop migration immediately in RDMA error paths

Peter Xu wrote: > On Tue, Oct 24, 2023 at 06:16:27PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > In multiple places, RDMA errors are handled in a strange way, where it only >> > sets qemu_file_set_error() but not stop the migration immediately. >> > &g

Re: [PATCH v3] migration: Stop migration immediately in RDMA error paths

immediately. > > Cc: Zhijian Li (Fujitsu) > Cc: Markus Armbruster > Cc: Juan Quintela > Cc: Fabiano Rosas > Reported-by: Thomas Huth > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela queued.

Re: [PATCH v2] migration: Stop migration immediately in RDMA error paths

immediately. > > Cc: Zhijian Li (Fujitsu) > Cc: Markus Armbruster > Cc: Juan Quintela > Cc: Fabiano Rosas > Reported-by: Thomas Huth > Signed-off-by: Peter Xu > --- > > v2: > - One more line squashed into to fix the build error... Please ignore v1, >

Re: [PATCH v3 1/1] migration: vmstate_register() check that instance_id is valid

Peter Xu wrote: > On Tue, Oct 24, 2023 at 05:03:36PM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> include/migration/vmstate.h | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/include/migration/vmstate.h b/include/

[PATCH 03/12] qemu_file: total_transferred is not used anymore

Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 1 file changed, 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 384985f534..641ab703cc 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -41,9 +41,6 @@ struct QEMUFile

[PATCH 11/12] migration: Remove transferred atomic counter

After last commit, it is a write only variable. Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/multifd.c | 3 --- migration/ram.c | 1 - 3 files changed, 8 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration-stats.h

[PATCH 05/12] qemu_file: Remove unused qemu_file_transferred()

Signed-off-by: Juan Quintela --- migration/qemu-file.h | 18 -- migration/qemu-file.c | 7 --- 2 files changed, 25 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-file.h index a29c37b0d0..8b71152754 100644 --- a/migration/qemu-file.h +++ b/migration/qemu

[PATCH 08/12] migration: migration_rate_limit_reset() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 2 +- migration/migration.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration

[PATCH 10/12] migration: Use migration_transferred_bytes()

s two values are used to: a - present to the user b - calculate the rate_limit So a few KB here and there is not going to make a difference. Signed-off-by: Juan Quintela --- migration/migration.c | 2 +- migration/ram.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --

[PATCH 12/12] qemu-file: Make qemu_fflush() return errors

check for f->last_error because qemu_fflush() returns it at the beggining of the function. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- In v2: Now that we call always qemu_fflush() for all files, we can simplify qemu_fclose() --- migration/qemu-file.h | 2 +- m

[PATCH 01/12] qemu-file: We only call qemu_file_transferred_* on the sending side

Remove the increase in qemu_file_fill_buffer() and add asserts to qemu_file_transferred* functions. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 3fb25148d1

[PATCH 06/12] qemu-file: Remove _noflush from qemu_file_transferred_noflush()

qemu_file_transferred() don't exist anymore, so we can reuse the name. Signed-off-by: Juan Quintela --- v2: Update the documentation (thanks fabiano) --- migration/qemu-file.h | 9 - migration/block.c | 4 ++-- migration/qemu-file.c | 2 +- migration/savevm.c

[PATCH 02/12] qemu_file: Use a stat64 for qemu_file_transferred

This way we can read it from any thread. I checked that it gives the same value than the current one. We never use to qemu_files at the same time. Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 migration/qemu-file.c | 5 +++-- 2 files changed, 7 insertions(+), 2

[PATCH 07/12] migration: migration_transferred_bytes() don't need the QEMUFile

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Juan Quintela --- migration/migration-stats.h | 4 +--- migration/migration-stats.c | 6 +++--- migration/migration.c | 6 +++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/migration/migration-stats.h b/migration

[PATCH 04/12] migration: Use the number of transferred bytes directly

s. Signed-off-by: Juan Quintela --- migration/migration-stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration-stats.c b/migration/migration-stats.c index 4cc989d975..1d9197b4c3 100644 --- a/migration/migration-stats.c +++ b/migration/migration-stats.c @@ -

[PATCH 09/12] qemu-file: Simplify qemu_file_get_error()

If we pass a NULL error is the same that returning dirrectly the value. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 0158db2a54

[PATCH 00/12] migration: Yet another round of atomic counters

these each time that we sent anything. Please review. Later, Juan. Juan Quintela (12): qemu-file: We only call qemu_file_transferred_* on the sending side qemu_file: Use a stat64 for qemu_file_transferred qemu_file: total_transferred is not used anymore migration: Use the number of

<    1   2   3   4   5   6   7   8   9   10   >