Re: [RFC] migration/block-dirty-bitmap: make loading bitmap for device with iothread future-proof

2023-07-31 Thread Juan Quintela
Fiona Ebner wrote: > The bdrv_create_dirty_bitmap() function (which is also called by > bdrv_dirty_bitmap_create_successor()) uses bdrv_getlength(bs). This is > a wrapper around a coroutine, and when not called in coroutine context > would use bdrv_poll_co(). Such a call would trigger an assert()

Re: [PATCH 2/3] tests/migration: Add -fno-stack-protector

2023-07-31 Thread Juan Quintela
-by: Akihiko Odaki Reviewed-by: Juan Quintela For whatever is related to migration. My liker options skills are (very) rusty, so I will let others decided if this is the correct way to do it O:-)

Re: [PATCH 00/26] Migration PULL 2023-07-24

2023-07-30 Thread Juan Quintela
Thomas Huth wrote: > On 24/07/2023 15.06, Juan Quintela wrote: >> Hi >> This is the migration PULL request. > > Maybe it would better to use "PULL" instead of "PATCH" in the subject? G. Resending. Thanks. >> Now a not on CI, thas has been re

Re: How to tame CI?

2023-07-26 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Jul 26, 2023 at 02:00:03PM +0100, Peter Maydell wrote: >> On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: >> > To make things easier, this is the part that show how it breaks (this is >> > the gcov test): >> > >> &

[PULL 04/25] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-07-26 Thread Juan Quintela
ewed-by: Markus Armbruster Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Signed-off-by: Juan Quintela --- qapi/migration.json| 34 +++--- migration/migration-hmp-cmds.c | 8 migration/option

[PULL 23/25] qemu-file: Simplify qemu_file_shutdown()

2023-07-26 Thread Juan Quintela
Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-20-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 9a89e17924..4c577bdff8 100644

[PULL 24/25] qemu-file: Make qemu_file_get_error_obj() static

2023-07-26 Thread Juan Quintela
It was not used outside of qemu_file.c anyways. Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-21-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/mig

[PULL 22/25] qemu_file: Make qemu_file_is_writable() static

2023-07-26 Thread Juan Quintela
It is not used outside of qemu_file, and it shouldn't. Signed-off-by: Juan Quintela Message-ID: <20230530183941.7223-19-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) d

[PULL 07/25] migration: Refactor auto-converge capability logic

2023-07-26 Thread Juan Quintela
Huang(黄勇) Acked-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Signed-off-by: Juan Quintela --- migration/ram.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 0ada

[PULL 19/25] qtest/migration-tests.c: use "-incoming defer" for postcopy tests

2023-07-26 Thread Juan Quintela
expected usage. Signed-off-by: Wei Wang Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-ID: <20230606101910.20456-3-wei.w.w...@intel.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t

[PULL 13/25] migration-test: Create arch_opts

2023-07-26 Thread Juan Quintela
This will contain the options needed for both source and target. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-6-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 30 +++--- 1 file changed, 15 insertions(+), 15 del

[PULL 25/25] migration/rdma: Split qemu_fopen_rdma() into input/output functions

2023-07-26 Thread Juan Quintela
This is how everything else in QEMUFile is structured. As a bonus they are three less lines of code. Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-17-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 12 mig

[PULL 18/25] migration: enforce multifd and postcopy preempt to be set before incoming

2023-07-26 Thread Juan Quintela
eviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-ID: <20230606101910.20456-2-wei.w.w...@intel.com> Signed-off-by: Juan Quintela Acked-by: Juan Quintela --- migration/options.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/migration/options.c b/migration

[PULL 16/25] docs/migration: Update postcopy bits

2023-07-26 Thread Juan Quintela
n/postcopy: unsentmap is not necessary for postcopy"). Touch up the postcopy section to remove "network connection" failures as downside, because now it's not fatal and can be recovered. Suggested by Laszlo. Acked-by: Laszlo Ersek Signed-off-by: Peter Xu Reviewed

[PULL 20/25] qemu-file: Rename qemu_file_transferred_ fast -> noflush

2023-07-26 Thread Juan Quintela
Fast don't say much. Noflush indicates more clearly that it is like qemu_file_transferred but without the flush. Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20230530183941.7223-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 11 +-- mig

[PULL 21/25] migration: Change qemu_file_transferred to noflush

2023-07-26 Thread Juan Quintela
We do a qemu_fclose() just after that, that also does a qemu_fflush(), so remove one qemu_fflush(). Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20230530183941.7223-3-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PULL 15/25] migration: skipped field is really obsolete.

2023-07-26 Thread Juan Quintela
pseries is completely broken with this patch. This effectively reverts commit f1c72795af573b24a7da5eb52375c9aba8a37972. Reviewed-by: Daniel P. Berrangé Message-ID: <20230612193344.3796-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10

[PULL 02/25] migration/multifd: Protect accesses to migration_threads

2023-07-26 Thread Juan Quintela
cleanup of multifd threads. Fixes: 671326201d ("migration: Introduce interface query-migrationthreads") Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <20230607161306.31425-3-faro...@suse.de> Signed-off-by: Juan Quintela --- migration/t

[PULL 03/25] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-07-26 Thread Juan Quintela
Armbruster Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Signed-off-by: Juan Quintela --- softmmu/dirtylimit.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/softmmu/dirtylimit.c b/softmmu/di

[PULL 11/25] migration-test: Be consistent for ppc

2023-07-26 Thread Juan Quintela
It makes no sense that we don't have the same configuration on both sides. Reviewed-by: Laurent Vivier Message-ID: <20230608224943.3877-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PULL 17/25] migration: Update error description whenever migration fails

2023-07-26 Thread Juan Quintela
us GK Message-ID: <20230621130940.178659-2-tejus...@nutanix.com> Signed-off-by: Juan Quintela --- migration/migration.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 1ea7512291..5528acb65e 100644 ---

[PULL 08/25] migration: Put the detection logic before auto-converge checking

2023-07-26 Thread Juan Quintela
ff-by: Hyman Huang(黄勇) Reviewed-by: Juan Quintela Message-ID: <168733225273.5845.1587182678887974167...@git.sr.ht> Signed-off-by: Juan Quintela --- migration/ram.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[PULL 05/25] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-07-26 Thread Juan Quintela
e migration by qmp migrate-set-parameters. This two parameters are used to help implement the dirty page rate limit algo of migration. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Sig

[PULL 10/25] migration: Extend query-migrate to provide dirty page limit info

2023-07-26 Thread Juan Quintela
Quintela Message-ID: <168733225273.5845.1587182678887974167...@git.sr.ht> Signed-off-by: Juan Quintela --- qapi/migration.json| 16 +- include/sysemu/dirtylimit.h| 2 ++ migration/migration-hmp-cmds.c | 10 + migration/migration.c

[PULL 09/25] migration: Implement dirty-limit convergence algo

2023-07-26 Thread Juan Quintela
8887974167...@git.sr.ht> Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 3 +++ migration/ram.c| 36 softmmu/dirtylimit.c | 29 + migration/trace-events | 1 + 4 files changed, 69 i

[PULL 14/25] migration-test: machine_opts is really arch specific

2023-07-26 Thread Juan Quintela
And it needs to be in both source and target, so put it on arch_opts. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-7-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff -

[PULL 06/25] migration: Introduce dirty-limit capability

2023-07-26 Thread Juan Quintela
using migrate-set-capabilities, and set the parameters "x-vcpu-dirty-limit-period", "vcpu-dirty-limit" suitably to speed up convergence. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.

[PULL 01/25] migration/multifd: Rename threadinfo.c functions

2023-07-26 Thread Juan Quintela
From: Fabiano Rosas We're about to add more functions to this file so make it use the same coding style as the rest of the code. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Message-Id: <20230607161306.3142

[PULL 00/25] Migration 20230726 patches

2023-07-26 Thread Juan Quintela
Implement dirty-limit convergence algo migration: Extend query-migrate to provide dirty page limit info Juan Quintela (11): migration-test: Be consistent for ppc migration-test: Make machine_opts regular with other options migration-test: Create arch_opts migration-test: machine_opts is r

[PULL 12/25] migration-test: Make machine_opts regular with other options

2023-07-26 Thread Juan Quintela
Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20230608224943.3877-5-quint...@redhat.com> --- tests/qtest/migration-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 2296

How to tame CI?

2023-07-26 Thread Juan Quintela
Hi Now a not on CI, thas has been really bad. After too many problems with last PULLS, I decided to learn to use qemu CI. On one hand, it is not so difficult, even I can use it O:-) On the other hand, the amount of problems that I got is inmense. Some of them dissapear when I rerun the check

[PATCH 14/26] migration-test: machine_opts is really arch specific

2023-07-24 Thread Juan Quintela
And it needs to be in both source and target, so put it on arch_opts. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-7-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff -

[PATCH 24/26] qemu-file: Simplify qemu_file_shutdown()

2023-07-24 Thread Juan Quintela
Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-20-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 9a89e17924..4c577bdff8 100644

[PATCH 10/26] migration: Extend query-migrate to provide dirty page limit info

2023-07-24 Thread Juan Quintela
Quintela Message-ID: <168733225273.5845.1587182678887974167...@git.sr.ht> Signed-off-by: Juan Quintela --- qapi/migration.json| 16 +- include/sysemu/dirtylimit.h| 2 ++ migration/migration-hmp-cmds.c | 10 + migration/migration.c

[PATCH 19/26] migration: enforce multifd and postcopy preempt to be set before incoming

2023-07-24 Thread Juan Quintela
eviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-ID: <20230606101910.20456-2-wei.w.w...@intel.com> Signed-off-by: Juan Quintela Acked-by: Juan Quintela --- migration/options.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/migration/options.c b/migration

[PATCH 18/26] migration: Update error description whenever migration fails

2023-07-24 Thread Juan Quintela
us GK Message-ID: <20230621130940.178659-2-tejus...@nutanix.com> Signed-off-by: Juan Quintela --- migration/migration.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 1ea7512291..5528acb65e 100644 ---

[PATCH 25/26] qemu-file: Make qemu_file_get_error_obj() static

2023-07-24 Thread Juan Quintela
It was not used outside of qemu_file.c anyways. Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-21-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/mig

[PATCH 12/26] migration-test: Make machine_opts regular with other options

2023-07-24 Thread Juan Quintela
Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <20230608224943.3877-5-quint...@redhat.com> --- tests/qtest/migration-test.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 2296

[PATCH 23/26] qemu_file: Make qemu_file_is_writable() static

2023-07-24 Thread Juan Quintela
It is not used outside of qemu_file, and it shouldn't. Signed-off-by: Juan Quintela Message-ID: <20230530183941.7223-19-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) d

[PATCH 20/26] qtest/migration-tests.c: use "-incoming defer" for postcopy tests

2023-07-24 Thread Juan Quintela
expected usage. Signed-off-by: Wei Wang Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-ID: <20230606101910.20456-3-wei.w.w...@intel.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t

[PATCH 15/26] migration.json: Don't use space before colon

2023-07-24 Thread Juan Quintela
So all the file is consistent. Reviewed-by: Markus Armbruster Message-ID: <20230612191604.2219-1-quint...@redhat.com> Signed-off-by: Juan Quintela --- qapi/migration.json | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/qapi/migration.json

[PATCH 00/26] Migration PULL 2023-07-24

2023-07-24 Thread Juan Quintela
migration: Put the detection logic before auto-converge checking migration: Implement dirty-limit convergence algo migration: Extend query-migrate to provide dirty page limit info Juan Quintela (12): migration-test: Be consistent for ppc migration-test: Make machine_opts regular with oth

[PATCH 11/26] migration-test: Be consistent for ppc

2023-07-24 Thread Juan Quintela
It makes no sense that we don't have the same configuration on both sides. Reviewed-by: Laurent Vivier Message-ID: <20230608224943.3877-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 07/26] migration: Refactor auto-converge capability logic

2023-07-24 Thread Juan Quintela
Huang(黄勇) Acked-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Signed-off-by: Juan Quintela --- migration/ram.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 0ada

[PATCH 22/26] migration: Change qemu_file_transferred to noflush

2023-07-24 Thread Juan Quintela
We do a qemu_fclose() just after that, that also does a qemu_fflush(), so remove one qemu_fflush(). Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20230530183941.7223-3-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 17/26] docs/migration: Update postcopy bits

2023-07-24 Thread Juan Quintela
n/postcopy: unsentmap is not necessary for postcopy"). Touch up the postcopy section to remove "network connection" failures as downside, because now it's not fatal and can be recovered. Suggested by Laszlo. Acked-by: Laszlo Ersek Signed-off-by: Peter Xu Reviewed

[PATCH 13/26] migration-test: Create arch_opts

2023-07-24 Thread Juan Quintela
This will contain the options needed for both source and target. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-6-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 30 +++--- 1 file changed, 15 insertions(+), 15 del

[PATCH 05/26] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-07-24 Thread Juan Quintela
e migration by qmp migrate-set-parameters. This two parameters are used to help implement the dirty page rate limit algo of migration. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Sig

[PATCH 04/26] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-07-24 Thread Juan Quintela
ewed-by: Markus Armbruster Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Signed-off-by: Juan Quintela --- qapi/migration.json| 34 +++--- migration/migration-hmp-cmds.c | 8 migration/option

[PATCH 21/26] qemu-file: Rename qemu_file_transferred_ fast -> noflush

2023-07-24 Thread Juan Quintela
Fast don't say much. Noflush indicates more clearly that it is like qemu_file_transferred but without the flush. Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20230530183941.7223-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 11 +-- mig

[PATCH 02/26] migration/multifd: Protect accesses to migration_threads

2023-07-24 Thread Juan Quintela
cleanup of multifd threads. Fixes: 671326201d ("migration: Introduce interface query-migrationthreads") Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <20230607161306.31425-3-faro...@suse.de> Signed-off-by: Juan Quintela --- migration/t

[PATCH 26/26] migration/rdma: Split qemu_fopen_rdma() into input/output functions

2023-07-24 Thread Juan Quintela
This is how everything else in QEMUFile is structured. As a bonus they are three less lines of code. Reviewed-by: Peter Xu Message-ID: <20230530183941.7223-17-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/qemu-file.h | 1 - migration/qemu-file.c | 12 mig

[PATCH 16/26] migration: skipped field is really obsolete.

2023-07-24 Thread Juan Quintela
pseries is completely broken with this patch. This effectively reverts commit f1c72795af573b24a7da5eb52375c9aba8a37972. Reviewed-by: Daniel P. Berrangé Message-ID: <20230612193344.3796-2-quint...@redhat.com> Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10

[PATCH 08/26] migration: Put the detection logic before auto-converge checking

2023-07-24 Thread Juan Quintela
ff-by: Hyman Huang(黄勇) Reviewed-by: Juan Quintela Message-ID: <168733225273.5845.1587182678887974167...@git.sr.ht> Signed-off-by: Juan Quintela --- migration/ram.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index

[PATCH 09/26] migration: Implement dirty-limit convergence algo

2023-07-24 Thread Juan Quintela
8887974167...@git.sr.ht> Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/migration.c | 3 +++ migration/ram.c| 36 softmmu/dirtylimit.c | 29 + migration/trace-events | 1 + 4 files changed, 69 i

[PATCH 06/26] migration: Introduce dirty-limit capability

2023-07-24 Thread Juan Quintela
using migrate-set-capabilities, and set the parameters "x-vcpu-dirty-limit-period", "vcpu-dirty-limit" suitably to speed up convergence. Signed-off-by: Hyman Huang(黄勇) Acked-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.

[PATCH 03/26] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-07-24 Thread Juan Quintela
Armbruster Reviewed-by: Peter Xu Reviewed-by: Juan Quintela Message-Id: <168618975839.6361.1740763387474768865...@git.sr.ht> Signed-off-by: Juan Quintela --- softmmu/dirtylimit.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/softmmu/dirtylimit.c b/softmmu/di

[PATCH 01/26] migration/multifd: Rename threadinfo.c functions

2023-07-24 Thread Juan Quintela
From: Fabiano Rosas We're about to add more functions to this file so make it use the same coding style as the rest of the code. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu Message-Id: <20230607161306.3142

Re: [PATCH] tests/avocado/migration: Remove the malfunctioning s390x tests

2023-07-24 Thread Juan Quintela
already do such tests in the migration *qtest*, so it is unnecessary > to redo such a test here, thus let's simply remove this test. > > Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela > --- > I'm tempted to remove this file completely - what test coverage do &

2023-07-25 QEMU developers fortnightly conference call for agenda

2023-07-24 Thread juan . quintela
Hi If you have topics for this week call, please let's us now. Later, Juan. QEMU developers fortnightly conference call Tuesday 2023-07-25 ⋅ 15:00 – 16:00 Central European Time - Madrid Location https://meet.jit.si/kvmcallmeeting https://www.google.com/url?q=https%3A%2F%2Fmeet.jit.si%2Fkvm

Re: [PATCH v2 2/4] virtio-mem: Skip most of virtio_mem_unplug_all() without plugged memory

2023-07-06 Thread Juan Quintela
David Hildenbrand wrote: > On 06.07.23 10:15, Juan Quintela wrote: >> David Hildenbrand wrote: >>> Already when starting QEMU we perform one system reset that ends up >>> triggering virtio_mem_unplug_all() with no actual memory plugged yet. >>> That, in turn

Re: [PATCH v2 1/4] softmmu/physmem: Warn with ram_block_discard_range() on MAP_PRIVATE file mapping

2023-07-06 Thread Juan Quintela
David Hildenbrand wrote: > On 06.07.23 10:10, Juan Quintela wrote: >> David Hildenbrand wrote: >>> ram_block_discard_range() cannot possibly do the right thing in >>> MAP_PRIVATE file mappings in the general case. >>> >>> To achieve the documented

Re: [PATCH v2 4/4] virtio-mem: Support "x-ignore-shared" migration

2023-07-06 Thread Juan Quintela
y in the > template (requested-size=0) and use private anonymous memory. > > Tested-by: Mario Casquero > Signed-off-by: David Hildenbrand After very nice explanation. Reviewed-by: Juan Quintela

Re: [PATCH 2/2] migration: unexport migrate_fd_error()

2023-07-06 Thread Juan Quintela
Laszlo Ersek wrote: > The only migrate_fd_error() call sites are in "migration/migration.c", > which is also where we define migrate_fd_error(). Make the function > static, and remove its declaration from "migration/migration.h". > > Cc: Juan Quintela (mainta

Re: [PATCH 1/2] migration: factor out "resume_requested" in qmp_migrate()

2023-07-06 Thread Juan Quintela
Laszlo Ersek wrote: > It cuts back on those awkward, duplicated !(has_resume && resume) > expressions. > > Cc: Juan Quintela (maintainer:Migration) > Cc: Leonardo Bras (reviewer:Migration) > Cc: Peter Xu (reviewer:Migration) > Cc: qemu-triv...@nongnu.org > Bugzi

Re: [PATCH v2 4/4] virtio-mem: Support "x-ignore-shared" migration

2023-07-06 Thread Juan Quintela
David Hildenbrand wrote: > To achieve desired "x-ignore-shared" functionality, we should not > discard all RAM when realizing the device and not mess with > preallocation/postcopy when loading device state. In essence, we should > not touch RAM content. > > As "x-ignore-shared" gets set after real

Re: [PATCH v2 3/4] migration/ram: Expose ramblock_is_ignored() as migrate_ram_is_ignored()

2023-07-06 Thread Juan Quintela
David Hildenbrand wrote: > virtio-mem wants to know whether it should not mess with the RAMBlock > content (e.g., discard RAM, preallocate memory) on incoming migration. > > So let's expose that function as migrate_ram_is_ignored() in > migration/misc.h Reviewed-by: Juan Quintela

Re: [PATCH v2 2/4] virtio-mem: Skip most of virtio_mem_unplug_all() without plugged memory

2023-07-06 Thread Juan Quintela
in that case. > > Let's optimize virtio_mem_unplug_all() for the case that no memory is > plugged. This will be beneficial for x-ignore-shared support as well. > > Tested-by: Mario Casquero > Signed-off-by: David Hildenbrand It works, so ... Reviewed-by: Juan Quintela

Re: [PATCH v2 1/4] softmmu/physmem: Warn with ram_block_discard_range() on MAP_PRIVATE file mapping

2023-07-06 Thread Juan Quintela
; * Postcopy live migration > * virtio-balloon inflation/deflation or free-page-reporting > * virtio-mem > > So at least warn that there is something possibly dangerous is going on > when using ram_block_discard_range() in these cases. > > Acked-by: Peter Xu > Tested-by: Mario Cas

Re: [PATCH v2 1/1] pcie: Add hotplug detect state register to cmask

2023-07-06 Thread Juan Quintela
qbus_set_hotplug_handler(BUS(pci_bridge_get_sec_bus(PCI_BRIDGE(dev))), I agree that this is (at least) a step on the right direction. I wmould had expected to have to need some check related to the value of: { "ICH9-LPC", ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, "off" } But I will not claim _any_ understanding of the PCI specification. So: Reviewed-by: Juan Quintela about that it fixes the migration bug.

Re: [PATCH] pc-bios/s390-ccw: Get rid of the the __u* types

2023-06-27 Thread Juan Quintela
m/linux/kernel/git/torvalds/linux.git/diff/drivers/s390/cio/cio.h?id=cd6b4f27b9bb2a > > So we should get rid of the __u* in the s390-ccw bios now finally, too. > > Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela

Re: [PATCH 4/6] tests/qtest: migration: Use migrate_incoming_qmp where appropriate

2023-06-27 Thread Juan Quintela
Fabiano Rosas wrote: > Use the new migrate_incoming_qmp helper in the places that currently > open-code calling migrate-incoming. > > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH 2/6] tests/qtest: migration: Expose migrate_set_capability

2023-06-27 Thread Juan Quintela
Fabiano Rosas wrote: > The following patch will make use of this function from within > migrate-helpers.c, so move it there. > > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PULL 00/30] Next patches

2023-06-27 Thread Juan Quintela
Richard Henderson wrote: > On 6/22/23 18:54, Juan Quintela wrote: >> The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: >>Merge tag 'q800-for-8.1-pull-request' >> ofhttps://github.com/vivier/qemu-m68k into staging (2023-06-22 >>

Re: [PATCH 1/6] migration: Set migration status early in incoming side

2023-06-27 Thread Juan Quintela
Fabiano Rosas wrote: > We are sending a migration event of MIGRATION_STATUS_SETUP at > qemu_start_incoming_migration but never actually setting the state. > > This creates a window between qmp_migrate_incoming and > process_incoming_migration_co where the migration status is still > MIGRATION_STAT

Re: [PATCH v2 08/26] tests/qtests: clean-up and fix leak in generic_fuzz

2023-06-27 Thread Juan Quintela
gt; +.name = g_strdup(name->str), > .description = "Predefined generic-fuzz config.", > .get_init_cmdline = generic_fuzz_predefined_config_cmdline, > .pre_fuzz = generic_pre_fuzz, Once that you are here, what about? (Yes, I didn't care abou

Re: [PATCH v2 6/6] qemu-keymap: properly check return from xkb_keymap_mod_get_index

2023-06-27 Thread Juan Quintela
Alex Bennée wrote: > We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers > as an overly wide shift attempt. > > Signed-off-by: Alex Bennée Reviewed-by: Juan Quintela

Re: [PULL 00/30] Next patches

2023-06-26 Thread Juan Quintela
Richard Henderson wrote: > On 6/22/23 18:54, Juan Quintela wrote: >> The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: >>Merge tag 'q800-for-8.1-pull-request' >> ofhttps://github.com/vivier/qemu-m68k into staging (2023-06-22 >>

Re: [PULL 00/30] Next patches

2023-06-26 Thread Juan Quintela
Richard Henderson wrote: > On 6/26/23 00:01, Juan Quintela wrote: >> Richard Henderson wrote: >>> On 6/22/23 18:54, Juan Quintela wrote: >>>> The following changes since commit >>>> b455ce4c2f300c8ba47cba7232dd03261368a4cb: >>>>

QEMU developers call for 2023-06-27

2023-06-25 Thread juan . quintela
Hi Remember that this week we have the call that we postponed for KVM Forum. In it Oracle wants to discuss how to move to integrate their Live Update series. Please, remember to join. Later, Juan. QEMU developers fortnightly conference call Tuesday 2023-06-27 ⋅ 15:00 – 16:00 Central European

Re: [PULL 00/30] Next patches

2023-06-25 Thread Juan Quintela
Richard Henderson wrote: > On 6/22/23 18:54, Juan Quintela wrote: >> The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: >>Merge tag 'q800-for-8.1-pull-request' >> ofhttps://github.com/vivier/qemu-m68k into staging (2023-06-22 >>

Re: [PULL 00/30] Next patches

2023-06-23 Thread Juan Quintela
Richard Henderson wrote: > On 6/22/23 18:54, Juan Quintela wrote: >> The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: >>Merge tag 'q800-for-8.1-pull-request' >> ofhttps://github.com/vivier/qemu-m68k into staging (2023-06-22 >>

[PATCH v2 5/5] migration: Deprecate old compression method

2023-06-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 +++ qapi/migration.json | 102 -- migration/options.c | 13 + 3 files changed, 86 insertions(+), 37 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about

[PATCH v2 1/5] migration: Use proper indentation for migration.json

2023-06-22 Thread Juan Quintela
We broke it with dirtyrate limit patches. Signed-off-by: Juan Quintela --- qapi/migration.json | 67 ++--- 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 6ff39157ba..ad8cc57071 100644 --- a

[PATCH v2 4/5] migration: Deprecate block migration

2023-06-22 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 30 +- migration

[PATCH v2 0/5] Migration deprecated parts

2023-06-22 Thread Juan Quintela
we do here? This part is not urget, because management apps have a working option that are already using "defer", and the code simplifacation if we remove it is not so big. So we can leave it until 9.0 or whatever we think fit. What do you think? Later, Juan. Juan Quintel

[PATCH v2 2/5] migration: migrate 'inc' command option is deprecated.

2023-06-22 Thread Juan Quintela
Set the 'block_incremental' migration parameter to 'true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 12 ++-- migration/migration.c | 6 ++ 3 files changed, 23 insertions(+), 2 deletions(-

[PATCH v2 3/5] migration: migrate 'blk' command option is deprecated.

2023-06-22 Thread Juan Quintela
Set the 'block' migration capability to 'true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 10 +++--- migration/migration.c | 5 + 3 files changed, 19 insertions(+), 3 deletions(-) dif

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote: >> Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri >> has been specified on the command line? > > Yeah, actually already in a pull (even though the pr may need a new one..): > > https://lore.k

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: >> >> Only "defer" is recommended. After setting all migation parameters, >> >

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:44PM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 8 >> qapi/migration.json | 92 --- >> migration/

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-22 Thread Juan Quintela
Thomas Huth wrote: > On 12/06/2023 21.33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 8 >> qapi/migration.json | 92 --- >> migration/options.c | 1

Re: [RFC 5/6] migration: Deprecate block migration

2023-06-22 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Mon, Jun 12, 2023 at 09:33:43PM +0200, Juan Quintela wrote: >> It is obsolete. It is better to use driver_mirror+NBD instead. >> >> CC: Kevin Wolf >> CC: Eric Blake >> CC: Stefan Hajnoczi >> CC: Hanna Czencz

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > > Signed-off-by: Juan Quintela Nack myself. Dropped on next submissiong. keyfile properties sug

Re: [RFC 3/6] migration: migrate 'blk' command option is deprecated.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:41PM +0200, Juan Quintela wrote: >> Use 'migrate_set_capability block true' instead. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 +++ >> qapi/mi

Re: [RFC 2/6] migration: migrate 'inc' command option is deprecated.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:40PM +0200, Juan Quintela wrote: >> Use 'migrate_set_parameter block_incremental true' instead. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7

Re: [RFC 1/6] migration: skipped field is really obsolete.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:39PM +0200, Juan Quintela wrote: >> Has return zero for more than 10 years. Just mark it deprecated. > > Specifically we introduced the field in 1.5.0 > > commit f1c72795af573b24a7da5eb52375c9aba8a37972 > Auth

Re: [PATCH] migration.json: Don't use space before colon

2023-06-22 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> So all the file is consistent. >> >> Signed-off-by: Juan Quintela > > Reviewed-by: Markus Armbruster > > Queued. thanks! My deprecated series depend on this, so I will got it through the migration tree if you don't care. Thanks, Juan.

[PULL 18/30] migration-test: dirtylimit checks for x86_64 arch before

2023-06-22 Thread Juan Quintela
So no need to assert we are in x86_64. Once there, refactor the function to remove useless variables. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-11-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 5 + 1 file changed, 1 insertion

[PULL 15/30] migration-test: Create kvm_opts

2023-06-22 Thread Juan Quintela
So arch_dirty_ring option becomes one option like the others. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-8-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests

<    4   5   6   7   8   9   10   11   12   13   >