[Bug 1916501] Re: qemu-img convert segfaults with specific URL

2021-03-02 Thread Julio Faracco
Guys, when I run with valgrind, I always get this when segfault occurs: ==74885== Invalid read of size 8 ==74885==at 0x1DC87D: curl_multi_do (curl.c:410) ==74885==by 0x23B949: aio_dispatch_handler (aio-posix.c:329) ==74885==by 0x23C0A1: aio_dispatch_handlers (aio-posix.c:372)

[PATCH] riscv: Add OpenTitan Big Number (OTBN) device address

2020-07-06 Thread Julio Faracco
This commit adds basics skecthes to implemente a OTBN unit. OTBN has address 0x5000 and size 0x40. For further reference, see OTBN docummentation: https://docs.opentitan.org/hw/ip/otbn/doc/ Signed-off-by: Julio Faracco --- hw/riscv/opentitan.c | 5 - include/hw/riscv

[PATCH] i386: Remove unused define's from hax and hvf

2020-03-23 Thread Julio Faracco
Commit acb9f95a removed boundary checks for ID and VCPU ID. After that, the max definitions of that boundaries are not required anymore. This commit is only a code cleanup. Signed-off-by: Julio Faracco --- target/i386/hax-i386.h | 2 -- target/i386/hvf/hvf-i386.h | 2 -- 2 files changed, 4

Re: [PATCH v4] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-02 Thread Julio Faracco
Em seg., 2 de mar. de 2020 às 17:13, Julio Faracco escreveu: > > When HAX is enabled (--enable-hax), GCC 9.2.1 reports issues with > snprintf(). Replacing old snprintf() by g_strdup_printf() fixes the > problem with boundary checks of vm_id and vcpu_id and finally the > warnings

[PATCH v4] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-02 Thread Julio Faracco
~~~~ Signed-off-by: Julio Faracco --- v1-v2: Add assert() as Richard Henderson suggested. v2-v3: Fix code syntax alignment with vm_id and snprintf() function. v3-v4: Replacing snprintf() by g_strdup_printf() from linux and windows. --- --- target/i386/hax-posix.c | 33 ++

Re: [PATCH v3] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-01 Thread Julio Faracco
-- Julio Cesar Faracco Em dom., 1 de mar. de 2020 às 21:05, Paolo Bonzini escreveu: > > On 01/03/20 20:21, Julio Faracco wrote: > > +assert(vm_id < 0); > > + > > +if (snprintf(name, sizeof HAX_VM_DEVFS, "/dev/hax_vm/vm%02d", > > +

[PATCH v3] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-01 Thread Julio Faracco
__fmt, __va_arg_pack ()); |~~~~~ Signed-off-by: Julio Faracco --- v1-v2: Add assert() as Richard Henderson suggested. v2-v3: Fix code syntax alignment with vm_id and snprintf() function. --- target/i386/hax-posix.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/target/i386/

[PATCH v2] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-01 Thread Julio Faracco
__fmt, __va_arg_pack ()); |~~~~~ Signed-off-by: Julio Faracco --- v1-v2: Add assert() as Richard Henderson suggested. --- target/i386/hax-posix.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/target/i386/hax-posix.c b/target/i386/hax-posix.c index a5426a6dac..dc51d7 1006

[PATCH] i386: Fix GCC warning with snprintf when HAX is enabled

2020-03-01 Thread Julio Faracco
17 67 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^~~~ 68 |__bos (__s), __fmt, __va_arg_pack ()); |~~~~~ Signed-off-by: Julio Faracco --- target/i

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2019-01-09 Thread Julio Faracco
** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809304 Title: qemu-img convert is freezing for some DMG files. Status in QEMU: Fix

Re: [Qemu-devel] [Qemu-block] [PATCH] dmg: fix binary search

2019-01-02 Thread Julio Faracco
Hi Stefan, I created a simple DMG file from MacOS to reproduce the problem: https://bugs.launchpad.net/qemu/+bug/1809304 Em qua, 2 de jan de 2019 às 08:47, Stefan Hajnoczi escreveu: > On Fri, Dec 21, 2018 at 09:58:03PM +0800, yuchenlin wrote: > > There is a possible hang in original binary

[Qemu-devel] [PATCH] dmg: Fixing wrong dmg block type value for block terminator.

2018-12-28 Thread Julio Faracco
This is a trivial patch to fix a wrong value for block terminator. The old value was 0x7fff which is wrong. It was not affecting the code because QEMU dmg block is not handling block terminator right now. Neverthless, it should be fixed. Signed-off-by: Julio Faracco --- block/dmg.c | 2

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2018-12-24 Thread Julio Faracco
Additional info: tested with version 3.0.0. So, before pushing my commits. Conclusion: This is not a new bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809304 Title: qemu-img convert is

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2018-12-24 Thread Julio Faracco
Hi Yu-Chen. The series looks good. It fixed the problems related to zero chunk. Nice work! I added a comment that I reviewed your patch considering my scenarios here. At least, It contributes to merge your changes. -- You received this bug notification because you are a member of qemu-

Re: [Qemu-devel] [PATCH v2 3/3] dmg: don't skip zero chunk

2018-12-24 Thread Julio Faracco
Looks good to me. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:03, yuchenlin escreveu: > The dmg file has many tables which describe: "start from sector XXX to > sector XXX, the compression method is XXX and where the compressed data > resides on&quo

Re: [Qemu-devel] [PATCH v2 2/3] dmg: use enumeration type instead of hard coding number

2018-12-24 Thread Julio Faracco
Looks good to me. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:03, yuchenlin escreveu: > Signed-off-by: yuchenlin > --- > block/dmg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/dmg.c b/block/dmg.c > index 0e05702f

Re: [Qemu-devel] [PATCH v2 1/3] dmg: fix binary search

2018-12-24 Thread Julio Faracco
Looks good to me. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:04, yuchenlin escreveu: > There is a possible hang in original binary search implementation. That is > if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. > > The chunk1 will be still 4, and so on

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] dmg: fixing reading in dmg

2018-12-24 Thread Julio Faracco
The series looks good to me. I tested with existing DMGs and DMGs that I created by myself. Both are working fine now. Reviewed-by: Julio Faracco Em dom, 23 de dez de 2018 às 01:01, yuchenlin escreveu: > There are two bugs in dmg reading. > > First, it may hang in binary search. thi

[Qemu-devel] [Bug 1809304] Re: qemu-img convert is freezing for some DMG files.

2018-12-21 Thread Julio Faracco
I'm almost sure that we need other improvements beyond fixing binary search deadlock. It is returning read errors when you apply your patch. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809304

[Qemu-devel] [Bug 1809304] [NEW] qemu-img convert is freezing for some DMG files.

2018-12-20 Thread Julio Faracco
Public bug reported: Recently, I created a file using hdiutil from MacOS (using Zlib compression): $ hdiutil create -volname MyVolName -srcfolder /path/to/my/vol/ -ov -format UDZO myvolname.dmg But, when I try to convert this volume using qemu-img convert, this command is freezing. I'm using

[Qemu-devel] [PATCH v3 3/4] dmg: including dmg-lzfse module inside dmg block driver.

2018-11-05 Thread Julio Faracco
This commit includes the support to new module dmg-lzfse into dmg block driver. It includes the support for block type ULFO (0x8007). Signed-off-by: Julio Faracco --- block/dmg.c | 28 block/dmg.h | 3 +++ 2 files changed, 31 insertions(+) diff --git a/block

[Qemu-devel] [PATCH v3 4/4] dmg: exchanging hardcoded dmg UDIF block types to enum.

2018-11-05 Thread Julio Faracco
This change is better to understand what kind of block type is being handled by the code. Using a syntax similar to the DMG documentation is easier than tracking all hex values assigned to a block type. Signed-off-by: Julio Faracco --- block/dmg.c | 43

[Qemu-devel] [PATCH v3 0/4] Adding LZFSE compression support for DMG block driver.

2018-11-05 Thread Julio Faracco
repo), can be found at: https://github.com/lzfse/lzfse v1-v2: Fixing some error handlings from dmg-lzfse.c v2-v3: Master rebasing suggestion from Stefan. Julio Faracco (4): block: adding lzfse decompressing support as a module. configure: adding support to lzfse library. dmg: including dmg

[Qemu-devel] [PATCH v3 2/4] configure: adding support to lzfse library.

2018-11-05 Thread Julio Faracco
This commit includes the support to lzfse opensource library. With this library dmg block driver can decompress images with this type of compression inside. Signed-off-by: Julio Faracco --- block/Makefile.objs | 2 ++ configure | 31 +++ 2 files changed

[Qemu-devel] [PATCH v3 1/4] block: adding lzfse decompressing support as a module.

2018-11-05 Thread Julio Faracco
QEMU dmg support includes zlib and bzip2, but it does not contains lzfse support. This commit adds the source file to extend compression support for new DMGs. Signed-off-by: Julio Faracco --- block/dmg-lzfse.c | 49 +++ 1 file changed, 49 insertions

[Qemu-devel] [PATCH v2 4/4] dmg: exchanging hardcoded dmg UDIF block types to enum.

2018-08-16 Thread Julio Faracco
This change is better to understand what kind of block type is being handled by the code. Using a syntax similar to the DMG documentation is easier than tracking all hex values assigned to a block type. Signed-off-by: Julio Faracco --- block/dmg.c | 43

[Qemu-devel] [PATCH v2 0/4] Adding LZFSE compression support for DMG block driver.

2018-08-16 Thread Julio Faracco
repo), can be found at: https://github.com/lzfse/lzfse Julio Faracco (4): block: adding lzfse decompressing support as a module. configure: adding support to lzfse library. dmg: including dmg-lzfse module inside dmg block driver. dmg: exchanging hardcoded dmg UDIF block types to enum

[Qemu-devel] [PATCH v2 2/4] configure: adding support to lzfse library.

2018-08-16 Thread Julio Faracco
This commit includes the support to lzfse opensource library. With this library dmg block driver can decompress images with this type of compression inside. Signed-off-by: Julio Faracco --- block/Makefile.objs | 2 ++ configure | 31 +++ 2 files changed

[Qemu-devel] [PATCH v2 3/4] dmg: including dmg-lzfse module inside dmg block driver.

2018-08-16 Thread Julio Faracco
This commit includes the support to new module dmg-lzfse into dmg block driver. It includes the support for block type ULFO (0x8007). Signed-off-by: Julio Faracco --- block/dmg.c | 28 block/dmg.h | 3 +++ 2 files changed, 31 insertions(+) diff --git a/block

[Qemu-devel] [PATCH v2 1/4] block: adding lzfse decompressing support as a module.

2018-08-16 Thread Julio Faracco
QEMU dmg support includes zlib and bzip2, but it does not contains lzfse support. This commit adds the source file to extend compression support for new DMGs. Signed-off-by: Julio Faracco --- block/dmg-lzfse.c | 49 +++ 1 file changed, 49 insertions

Re: [Qemu-devel] [PATCH 2/4] configure: adding support to lzfse library.

2018-08-14 Thread Julio Faracco
Em seg, 13 de ago de 2018 às 11:10, Kevin Wolf escreveu: > > Am 10.08.2018 um 06:07 hat Julio Faracco geschrieben: > > This commit includes the support to lzfse opensource library. With this > > library dmg block driver can decompress images with this type of >

[Qemu-devel] [PATCH 3/4] dmg: including dmg-lzfse module inside dmg block driver.

2018-08-09 Thread Julio Faracco
This commit includes the support to new module dmg-lzfse into dmg block driver. It includes the support for block type ULFO (0x8007). Signed-off-by: Julio Faracco --- block/dmg.c | 28 block/dmg.h | 3 +++ 2 files changed, 31 insertions(+) diff --git a/block

[Qemu-devel] [PATCH 2/4] configure: adding support to lzfse library.

2018-08-09 Thread Julio Faracco
This commit includes the support to lzfse opensource library. With this library dmg block driver can decompress images with this type of compression inside. Signed-off-by: Julio Faracco --- block/Makefile.objs | 2 ++ configure | 32 2 files changed

[Qemu-devel] [PATCH 4/4] dmg: exchanging hardcoded dmg UDIF block types to enum.

2018-08-09 Thread Julio Faracco
This change is better to understand what kind of block type is being handled by the code. Using a syntax similar to the DMG documentation is easier than tracking all hex values assigned to a block type. Signed-off-by: Julio Faracco --- block/dmg.c | 43

[Qemu-devel] [PATCH 0/4] Adding LZFSE compression support for DMG block driver.

2018-08-09 Thread Julio Faracco
repo), can be found at: https://github.com/lzfse/lzfse Julio Faracco (4): block: adding lzfse decompressing support as a module. configure: adding support to lzfse library. dmg: including dmg-lzfse module inside dmg block driver. dmg: exchanging hardcoded dmg UDIF block types to enum

[Qemu-devel] [PATCH 1/4] block: adding lzfse decompressing support as a module.

2018-08-09 Thread Julio Faracco
QEMU dmg support includes zlib and bzip2, but it does not contains lzfse support. This commit adds the source file to extend compression support for new DMGs. Signed-off-by: Julio Faracco --- block/dmg-lzfse.c | 54 +++ 1 file changed, 54 insertions

Re: [Qemu-devel] Segmentation Fault running Raspberry Pi OS.

2016-11-11 Thread Julio Faracco
+svn231177-1) 4.9.3 20150529 (prerelease) I'm still need to test raspbian yet. -- Julio Cesar Faracco 2016-11-10 4:39 GMT-02:00 Stefan Weil <s...@weilnetz.de>: > On 11/09/16 22:35, Julio Faracco wrote: >> >> Hi guys, >> >> I was developing a simple OS for Raspberry Pi

[Qemu-devel] Segmentation Fault running Raspberry Pi OS.

2016-11-09 Thread Julio Faracco
Hi guys, I was developing a simple OS for Raspberry Pi 2. When I was debugging my OS using "-s -S" options for QEMU, I was getting a segfault: Segmentation fault (core dumped). After that, I decided to run QEMU (for ARM using a raspi2 machine) inside GDB. $ gdb ./arm-softmmu/qemu-system-arm

Re: [Qemu-devel] [PATCH] qapi: Adding websocket information inside VncInfo structure.

2015-10-19 Thread Julio Faracco
Thanks Erik and Gerd for you feedback... I will rebase the changes consider the opinions... I agree about VncInfo2... because some structures are ready to use, including websocket. Without adding new fields or other changes. Julio Cesar Faracco 2015-10-19 6:17 GMT-02:00 Gerd Hoffmann

[Qemu-devel] [PATCH] qapi: Adding websocket information inside VncInfo structure.

2015-10-16 Thread Julio Faracco
irm that a websocket service is running, checking the ports that are opened. This commit introduce two new fields inside "VncInfo" either: "webservice" which contains the port as a string and the boolean value "has_websocket" that copies the status of ws_enabled from VNC Disp

Re: [Qemu-devel] Segmentation Fault while running tests.

2015-08-05 Thread Julio Faracco
Thanks for your clarification, Peter. Julio Cesar Faracco

[Qemu-devel] Segmentation Fault while running tests.

2015-08-04 Thread Julio Faracco
Hi guys. I'm trying to run the QEMU tests for i386 and x86_64 architectures but they are returning some errors. I'm using the most update version from git tree and my system is Ubuntu 14.04. Take a look at this segfault errors. $ make test [...] ../../i386-linux-user/qemu-i386 ./test-mmap

Re: [Qemu-devel] [PATCH 2/2] qcow2-snapshot: Fixing bug of creating snapshots with the same name.

2015-01-27 Thread Julio Faracco
Hi Max. Yes, you are right! The main problem about this issue is deleting the first occurence of the snapshot with that name. Considering I have 3 snapshots with the name 'foo', you need to have the option to choose what snapshot (what 'foo's) you want to remove or, as you said, do not remove

[Qemu-devel] [PATCH 2/2] qcow2-snapshot: Fixing bug of creating snapshots with the same name.

2015-01-22 Thread Julio Faracco
TAG VM SIZEDATE VM CLOCK 1 foo220M 2015-01-21 16:22:41 00:02:50.862 Signed-off-by: Julio Faracco jcfara...@gmail.com --- block/qcow2-snapshot.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/qcow2

[Qemu-devel] [PATCH 1/2] qcow2-snapshot: Change filter function to avoid NULL parameter when a snapshot will be created.

2015-01-22 Thread Julio Faracco
This is a trivial patch to change the filter 'find_snapshot_by_id_and_name' to 'find_snapshot_by_id_or_name'. The field 'Name' is not required. So this change avoid NULL parameters. And use the correct function to filter. Signed-off-by: Julio Faracco jcfara...@gmail.com --- block/qcow2