Re: [PATCH v2 1/1] security-process: update process information

ails. > > Signed-off-by: Prasad J Pandit Reviewed-by: Konrad Rzeszutek Wilk Thank you!

Re: [PATCH v1 1/1] security-process: update process information

ails. > > Signed-off-by: Prasad J Pandit Thank you for doing it! Reviewed-by: Konrad Rzeszutek Wilk with one change below. > --- > contribute/security-process.md | 134 - > 1 file changed, 80 insertions(+), 54 deletions(-) > > Update v1: incorp

Re: About 'qemu-security' mailing list

. monster snip.. > > Maybe we could start with a moderated list and improvise as we go forward? > > I really think that encryption of the details of a vulnerability is > important, if somehow it gets intercepted - which is not that difficult > with e-mail - then there is the potential for a

Re: [PATCH 13/13] microvm/acpi: use GSI 16-23 for virtio

On Thu, Mar 19, 2020 at 09:01:17AM +0100, Gerd Hoffmann wrote: > With ACPI enabled and IO-APIC being properly declared in the ACPI tables > we can use interrupt lines 16-23 for virtio and avoid shared interrupts. 7 interrupt lines? Is there a specific requirements of which ones should be assigned

Re: [Qemu-devel] [multiprocess RFC PATCH 36/37] multi-process: add the concept description to docs/devel/qemu-multiprocess

On Thu, Mar 07, 2019 at 03:21:47PM +0100, Thomas Huth wrote: > On 07/03/2019 15.16, Kevin Wolf wrote: > > Am 07.03.2019 um 09:14 hat Thomas Huth geschrieben: > >> On 07/03/2019 08.22, elena.ufimts...@oracle.com wrote: > >>> From: Elena Ufimtseva > >>> > >>> TODO: Make relevant changes to the doc.

Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

On Fri, Jul 13, 2018 at 04:44:49PM +0200, Paolo Bonzini wrote: > On 13/07/2018 16:11, konrad.w...@oracle.com wrote: > > (Apologies if this comes out as HTML, using Thunderbird instead of mutt > > here).. > > > >> +    uint64_t pred_cmd; > >> +    uint64_t arch_capabilities; > > > > Could this be

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

On Wed, Jun 13, 2018 at 05:21:29PM +0100, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 12:09:59PM -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, Jun 13, 2018 at 11:19:49AM +0100, Daniel P. Berrangé wrote: > > > On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rz

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

On Wed, Jun 13, 2018 at 11:19:49AM +0100, Daniel P. Berrangé wrote: > On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > > > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

On Mon, Jun 04, 2018 at 06:15:09PM -0300, Eduardo Habkost wrote: > On Mon, Jun 04, 2018 at 04:22:05PM -0400, Konrad Rzeszutek Wilk wrote: > > On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > > > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

On Mon, Jun 04, 2018 at 05:07:01PM -0300, Eduardo Habkost wrote: > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > > AMD future CPUs expose _two_ ways to utilize the Intel equivalant > > of the Speculative Store Bypass Disable. The first is via >

Re: [Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

On Mon, Jun 04, 2018 at 09:54:40AM +0100, Daniel P. Berrangé wrote: > On Fri, Jun 01, 2018 at 11:38:08AM -0400, Konrad Rzeszutek Wilk wrote: > > AMD future CPUs expose _two_ ways to utilize the Intel equivalant > > of the Speculative Store Bypass Disable. The first is via >

[Qemu-devel] [PATCH 2/2] i386: Define AMD's no SSB mitigation needed.

is available at https://bugzilla.kernel.org/show_bug.cgi?id=199889 Signed-off-by: Konrad Rzeszutek Wilk --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index f91990c..43b1532 100644 --- a/target/i386/cpu.c +++ b/target

[Qemu-devel] [PATCH QEMU] Patches for new AMD CPU bits.

insertion(+), 1 deletion(-) Konrad Rzeszutek Wilk (2): i386: define the AMD 'amd-ssbd' CPUID feature bit i386: Define AMD's no SSB mitigation needed.

[Qemu-devel] [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit

: 124441_AMD64_SpeculativeStoreBypassDisable_Whitepaper_final.pdf gives priority of SPEC CTRL MSR over the VIRT SPEC CTRL MSR. A copy of this document is available at https://bugzilla.kernel.org/show_bug.cgi?id=199889 Anyhow, this means that on future AMD CPUs there will be _two_ ways to deal with SSBD. Signed-off-by: Konrad Rzeszutek Wilk

Re: [Qemu-devel] CVE-2018-7550 (was: multiboot: bss_end_addr can be zero / cleanup)

On March 14, 2018 1:23:51 PM EDT, Kevin Wolf wrote: >Am 21.12.2017 um 18:25 hat Jack Schwartz geschrieben: >> Properly account for the possibility of multiboot kernels with a zero >> bss_end_addr. The Multiboot Specification, section 3.1.3 allows for >> kernels without a bss

Re: [Qemu-devel] [Xen-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

On Sun, Oct 15, 2017 at 03:31:15AM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 13, 2017 at 03:46:39PM -0700, Stefano Stabellini wrote: > > On Fri, 13 Oct 2017, Jan Beulich wrote: > > > >>> On 13.10.17 at 13:13, wrote: > > > > To Jan, Andrew, Stefano and Anthony, > > >

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

On Thu, Oct 12, 2017 at 08:45:44PM +0800, Haozhong Zhang wrote: > On 10/10/17 12:05 -0400, Konrad Rzeszutek Wilk wrote: > > On Tue, Sep 12, 2017 at 11:15:09AM +0800, Haozhong Zhang wrote: > > > On 09/11/17 11:52 -0700, Stefano Stabellini wrote: > > > > CC'ing xen-de

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

On Tue, Sep 12, 2017 at 11:15:09AM +0800, Haozhong Zhang wrote: > On 09/11/17 11:52 -0700, Stefano Stabellini wrote: > > CC'ing xen-devel, and the Xen tools and x86 maintainers. > > > > On Mon, 11 Sep 2017, Igor Mammedov wrote: > > > On Mon, 11 Sep 2017 12:41:47 +0800 > > > Haozhong Zhang

Re: [Qemu-devel] [PATCH] pixman: drop submodule

On Fri, Sep 01, 2017 at 12:50:23PM +0200, Gerd Hoffmann wrote: > Drop pixman submodule and support for the "internal" pixman build. > pixman should be reasonable well established meanwhile that we don't > need the fallback submodule any more. While being at it also drop > some #ifdefs for pixman

Re: [Qemu-devel] [PATCH v2 0/4] i386/kvm: advertise Hyper-V frequency MSRs

On Tue, Aug 08, 2017 at 09:50:53PM -0300, Marcelo Tosatti wrote: > On Mon, Aug 07, 2017 at 10:56:59AM +0200, Ladi Prosek wrote: > > This is the QEMU part of the changes required for nested Hyper-V to read > > timestamps with RDTSC + TSC page. Without exposing the frequency MSRs, > > Windows with

Re: [Qemu-devel] [PATCH] x86: Increase max vcpu number to 352

On Wed, Aug 09, 2017 at 11:58:20PM -0400, Lan Tianyu wrote: > Intel Xeon phi chip will support 352 logical threads. For HPC > usage case, it will create a huge VM with vcpus number as same as host > cpus. This patch is to increase max vcpu number to 352. There is this ioctl called

Re: [Qemu-devel] Fwd: [RFC PATCH 0/2] Allow RedHat PCI bridges reserve more buses than necessary during init

On Wed, Jul 19, 2017 at 09:38:50PM +0300, Alexander Bezzubikov wrote: > 2017-07-19 21:18 GMT+03:00 Konrad Rzeszutek Wilk <konrad.w...@oracle.com>: > > > On Wed, Jul 19, 2017 at 05:14:41PM +, Alexander Bezzubikov wrote: > > > ср, 19 июля 2017 г. в 16:57, Konrad Rz

Re: [Qemu-devel] [RFC PATCH 0/2] Allow RedHat PCI bridges reserve more buses than necessary during init

On Wed, Jul 19, 2017 at 05:14:41PM +, Alexander Bezzubikov wrote: > ср, 19 июля 2017 г. в 16:57, Konrad Rzeszutek Wilk <konrad.w...@oracle.com>: > > > On Wed, Jul 19, 2017 at 04:20:12PM +0300, Aleksandr Bezzubikov wrote: > > > Now PCI bridges (and PCIE root port

Re: [Qemu-devel] [RFC PATCH 0/2] Allow RedHat PCI bridges reserve more buses than necessary during init

On Wed, Jul 19, 2017 at 04:20:12PM +0300, Aleksandr Bezzubikov wrote: > Now PCI bridges (and PCIE root port too) get a bus range number in system > init, > basing on currently plugged devices. That's why when one wants to hotplug > another bridge, > it needs his child bus, which the parent is

Re: [Qemu-devel] [RFC PATCH 2/2] pci: enable RedHat pci bridges to reserve more buses

On Wed, Jul 19, 2017 at 04:20:14PM +0300, Aleksandr Bezzubikov wrote: > In case of RedHat PCI bridges reserve additional buses, which number is > provided It is "Red Hat" > in a vendor-specific capability. And perhaps also a #define ? > > Signed-off-by: Aleksandr Bezzubikov

Re: [Qemu-devel] [Qemu-block] Behavior of QMP "query-block"

On Fri, May 26, 2017 at 10:02:32PM +0200, Kevin Wolf wrote: > Am 26.05.2017 um 18:55 hat John Snow geschrieben: > > On 05/26/2017 07:40 AM, Kevin Wolf wrote: > > > There is one completely crazy thing that Xen does with respect to disks. > > > Instead of having support for their PV disks (i.e.

Re: [Qemu-devel] [RFC QEMU PATCH v2 01/10] nvdimm xen: disable label support on Xen

On Mon, Mar 20, 2017 at 08:12:40AM +0800, Haozhong Zhang wrote: > If xen_enabled(), memory_region_get_ram_ptr() always returns NULL and > nvdimm_realize() cannot get the correct pointer to the label area. This > commit disables the label support for Xen accelerator to workaround > this issue. > >

Re: [Qemu-devel] [RFC Design Doc v3] Enable Shared Virtual Memory feature in pass-through scenarios

.snip.. > > > Shared Virtual Memory feature in pass-through scenarios is actually SVM > > > virtualization. It is to let application programs(running in guest)share > > > their > > > virtual address with assigned device(e.g. graphics processors or > > > accelerators). > > > > I think I am

Re: [Qemu-devel] [RFC Design Doc v3] Enable Shared Virtual Memory feature in pass-through scenarios

On Wed, Nov 30, 2016 at 08:49:24AM +, Liu, Yi L wrote: > What's changed from v2: > a) Detailed feature description > b) refine description in "Address translation in virtual SVM" > b) "Terms" is added > > Content > === > 1. Feature description > 2.

Re: [Qemu-devel] [RFC QEMU PATCH 1/8] nvdimm: do not initialize label_data if label_size is zero

On Mon, Oct 10, 2016 at 08:34:16AM +0800, Haozhong Zhang wrote: > When memory-backend-xen is used, the label_data pointer can not be got > via memory_region_get_ram_ptr(). We will use other functions to get Could you explain why it cannot be retrieved via that way? > label_data once we introduce

Re: [Qemu-devel] [Xen-devel] stack size limit issues with xen + qemu + rbd

On Fri, Sep 16, 2016 at 04:55:17PM -0400, Chris Patterson wrote: > I have spent some time investigating a case where qemu is failing to > register xenstore watches for a PV guest once I enable vfb (and > thereby triggering the creation of a qemu instance). > > The qemu logs show something along

Re: [Qemu-devel] [Xen-devel] [RFC] e1000: Don't save writes to ICS/ICR masked by IMS

On Thu, Sep 01, 2016 at 10:57:48AM -0700, Ed Swierk wrote: > Windows 8, 10 and Server 2012 guests hang intermittently while booting > on Xen 4.5.3 with 1 vCPU and 4 e1000 vNICs, shortly after the Windows > logo appears and the little dots start spinning. > > Running strace on qemu shows its main

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

On Thu, Sep 01, 2016 at 02:11:31PM +0200, Olaf Hering wrote: > Implement SUSE specific unplug protocol for emulated PCI devices > in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. > This protocol was implemented and used since Xen 3.0.4. > It is used in all SUSE/SLES/openSUSE releases up

Re: [Qemu-devel] [Xen-devel] [PATCH RESEND] fix MSI injection on Xen

On Wed, Jan 13, 2016 at 02:59:09PM +, Stefano Stabellini wrote: > On Xen MSIs can be remapped into pirqs, which are a type of event > channels. It's mostly for the benefit of PCI passthrough devices, to > avoid the overhead of interacting with the emulated lapic. > > However remapping

Re: [Qemu-devel] [RFC PATCH 0/3] x86: Add support for guest DMA dirty page tracking

> You can create a dummy device in guest for the duration of migration. > Use guest agent to move IP address there and that should be enough to trick > most guests. If you are doing this - why not bond the physical NIC with an virtual device and unplug the physical NIC?

Re: [Qemu-devel] [RFC PATCH 0/3] x86: Add support for guest DMA dirty page tracking

On Sun, Dec 13, 2015 at 01:28:09PM -0800, Alexander Duyck wrote: > This patch set is meant to be the guest side code for a proof of concept > involving leaving pass-through devices in the guest during the warm-up > phase of guest live migration. In order to accomplish this I have added a What

Re: [Qemu-devel] [Xen-devel] [Patch V1 3/3] xen: add pvUSB backend

On Thu, Sep 03, 2015 at 12:45:13PM +0200, Juergen Gross wrote: > Add a backend for para-virtualized USB devices for xen domains. > > The backend is using host-libusb to forward USB requests from a > domain via libusb to the real device(s) passed through. > > Signed-off-by: Juergen Gross

Re: [Qemu-devel] [Xen-devel] [Patch V1 2/3] xen/usb: add capability for passing through isoc jobs to host devices

On Thu, Sep 03, 2015 at 12:45:12PM +0200, Juergen Gross wrote: > When Xen is using the qemu usb framework for pure passthrough of I/Os > to host devices the handling of isoc jobs is rather complicated if > multiple isoc frames are transferred with one call. > > Instead of calling the framework

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

On Tue, Sep 15, 2015 at 11:07:02AM +0100, Stefano Stabellini wrote: > CC Konrad > > On Mon, 14 Sep 2015, Paolo Bonzini wrote: > > On 10/09/2015 19:15, Stefano Stabellini wrote: > > > + > > > +switch (reg->size) { > > > +case 1: rc = xen_host_pci_get_byte(>real_device, offset, > >

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

On Tue, Sep 15, 2015 at 02:28:51PM +0100, Stefano Stabellini wrote: > On Tue, 15 Sep 2015, Konrad Rzeszutek Wilk wrote: > > On Tue, Sep 15, 2015 at 11:07:02AM +0100, Stefano Stabellini wrote: > > > CC Konrad > > > > > > On Mon, 14 Sep 2015, Paolo Bonzin

Re: [Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values.

tags) and stuck it in: git://xenbits.xen.org/people/konradwilk/qemu.git for-stefano-xen-2015-09-08-tag and also tested it. > Thanks! > > - Stefano > > On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote: > > Hey! > > > > Since v1: > > (http://lists.xen.org/archi

[Qemu-devel] [PATCH v2 05/10] xen/pt: Log xen_host_pci_get in two init functions

To help with troubleshooting in the field. Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen_pt_config_init.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/xen/xen_pt_config

[Qemu-devel] [PATCH v2 04/10] xen/pt: Remove XenPTReg->data field.

it' we used u32 for the Capabilities Pointer register, but said register is an an u16. - In 'xen_pt_msgdata_reg_write' we used u32 but should have only use u16. Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen_pt.h | 6 +++- hw/xen/xen_pt_config

[Qemu-devel] [PATCH v2 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap

n the fact that Xen 4.6 has a new function: commit 504ed2053362381ac01b98db9313454488b7db40 "tools/libxc: Expose new hypercall xc_reserved_device_memory_map" and check for that. Suggested-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wi

[Qemu-devel] [PATCH v2 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.

: Use xen_host_pci_get_[byte|word] instead of dev.config" we will hit - so this sync up the function to the rest of them. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen_pt_config_init.c | 2

[Qemu-devel] [PATCH v2 09/10] xen/pt: Check for return values for xen_host_pci_[get|set] in init

and if we have failures we call xen_pt_destroy introduced in 'xen/pt: Move bulk of xen_pt_unregister_device in its own routine.' and free all of the allocated structures. Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@o

[Qemu-devel] [PATCH v2 10/10] xen/pt: Don't slurp wholesale the PCI configuration registers

Instead we have the emulation registers ->init functions which consult the host values to see what the initial value should be and they are responsible for populating the dev.config. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk

[Qemu-devel] [PATCH v2 02/10] xen/pt: Sync up the dev.config and data values.

t;size in the ->init routines. The author tried to fiddle with QEMU_BUILD_BUG to make this work but failed. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Reported-by: Sander Eikelenboom <li...@eikelenboom.it> Signed-off-by: Konrad Rzeszutek Wilk

[Qemu-devel] [PATCH v2 5/6] xen/pt/msi: Add the register value when printing logging and error messages

We would like to know what the MSI register value is to help in troubleshooting in the field. As such modify the logging logic to include such details in xen_pt_msgctrl_reg_write. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <

[Qemu-devel] [PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size

ort of thing we still return an error. Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen_pt_config_init.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index aff51b8..55be4ee 100644

[Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI + more logging on errors.

insertions(+), 11 deletions(-) Konrad Rzeszutek Wilk (6): xen/pt: Update comments with proper function name. xen/pt: Make xen_pt_msi_set_enable static xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure xen: use errno instead of rc

[Qemu-devel] [PATCH v2 1/6] xen/pt: Update comments with proper function name.

It has changed but the comments still refer to the old names. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen_pt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[Qemu-devel] [PATCH v2 2/6] xen/pt: Make xen_pt_msi_set_enable static

As we do not use it outside our code. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen_pt.h | 1 - hw/xen/xen_pt_msi.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[Qemu-devel] [PATCH v2 06/10] xen/pt: Log xen_host_pci_get/set errors in MSI code.

We seem to only use these functions when de-activating the MSI - so just log errors. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen_pt_msi.c | 18 ++ 1 file changed, 1

[Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values.

move XenPTReg->data field. Stefano asked me to s/word/half-word/g s/dbword/word/ - which this does. Please review. The patches are also available at: >From Konrad Rzeszutek Wilk <konrad.w...@oracle.com> # This line is ignored. From: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>

[Qemu-devel] [PATCH v2 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

However the init routines assume that on errors the return code is -1 (as the libxc API is) - while those xen_host_* routines follow another paradigm - negative errno on return, 0 on success. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszute

[Qemu-devel] [PATCH v2 01/10] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

have to use a cast to thwart compiler warnings in the meantime. We also truncated 'flags' to 'flag' to make the code fit within the 80 characters. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/

[Qemu-devel] [PATCH v2 07/10] xen/pt: Make xen_pt_unregister_device idempotent

-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xen-host-pci-device.c | 5 + hw/xen/xen-host-pci-device.h | 1 + hw/xen/xen_pt.c | 20 ++-- hw/xen/xen_pt.h | 2

[Qemu-devel] [PATCH v2 08/10] xen/pt: Move bulk of xen_pt_unregister_device in its own routine.

This way we can call it if we fail during init. This code movement introduces no changes. Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> --- hw/xen/xe

Re: [Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent

@@ -818,10 +819,13 @@ static void xen_pt_unregister_device(PCIDevice *d) { XenPCIPassthroughState *s = XEN_PT_DEVICE(d); uint8_t machine_irq = s-machine_irq; -uint8_t intx = xen_pt_pci_intx(s); +uint8_t intx; int rc; -if (machine_irq) { + /*

Re: [Qemu-devel] [PATCH v1 03/10] xen/pt: Check if reg-init function sets the 'data' past the reg-size

On Fri, Jul 17, 2015 at 05:03:44PM +0100, Stefano Stabellini wrote: On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: It should never happen, but in case it does (an developer adds a new register and the 'init_val' expands past the register size) we want to report. The code will only write

Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size

On Wed, Aug 12, 2015 at 08:53:44AM +, Wu, Feng wrote: -Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Wednesday, August 12, 2015 4:43 PM To: Wu, Feng Cc: stefano.stabell...@eu.citrix.com; xen-de...@lists.xensource.com; qemu-devel@nongnu.org

Re: [Qemu-devel] [PATCH v1 03/10] xen/pt: Check if reg-init function sets the 'data' past the reg-size

On Fri, Jul 17, 2015 at 05:03:44PM +0100, Stefano Stabellini wrote: On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: It should never happen, but in case it does (an developer adds a new register and the 'init_val' expands past the register size) we want to report. The code will only write

Re: [Qemu-devel] [PATCH v1 05/10] xen/pt: Remove XenPTReg-data field.

On Fri, Jul 17, 2015 at 05:30:39PM +0100, Stefano Stabellini wrote: On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: We do not want to have two entries to cache the guest configuration registers: XenPTReg-data and dev.config. Instead we want to use only the dev.config. To do without

[Qemu-devel] [PATCH] Follow-on to Remove XenPTReg-data and use dev.config for guest configuration values.

overwritting with emulated registers. hw/xen/xen_pt.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) Konrad Rzeszutek Wilk (1): xen/pt: Don't slurp wholesale the PCI configuration registers

[Qemu-devel] [PATCH] xen/pt: Don't slurp wholesale the PCI configuration registers

Instead we have the emulation registers -init functions which consult the host values to see what the initial value should be and they are responsible for populating the dev.config. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.c | 7 +-- 1 file changed, 1

Re: [Qemu-devel] [PATCH RFC 4/6] xen: Print and use errno where applicable.

On Thu, Jul 02, 2015 at 12:00:29PM +0100, Stefano Stabellini wrote: On Wed, 1 Jul 2015, Konrad Rzeszutek Wilk wrote: On Wed, Jul 01, 2015 at 02:01:07PM +0100, Stefano Stabellini wrote: On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: In Xen 4.6 commit

[Qemu-devel] [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.

xen_host_pci_get_[byte|word] instead of dev.config we will hit - so this sync up the function to the rest of them. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw

[Qemu-devel] [PATCH v1 2/6] xen/pt: Make xen_pt_msi_set_enable static

As we do not use it outside our code. Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.h | 1 - hw/xen/xen_pt_msi.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/xen

[Qemu-devel] [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages

We would like to know what the MSI register value is to help in troubleshooting in the field. As such modify the logging logic to include such details in xen_pt_msgctrl_reg_write. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 6 +++--- 1 file

[Qemu-devel] [PATCH v1 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

However the init routines assume that on errors the return code is -1 (as the libxc API is) - while those xen_host_* routines follow another paradigm - negative errno on return, 0 on success. Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk

[Qemu-devel] [PATCH v1 1/6] xen/pt: Update comments with proper function name.

It has changed but the comments still refer to the old names. Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt.c b

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1 6/8] xen/pt: Make xen_pt_unregister_device idempotent

@@ -858,15 +863,20 @@ static void xen_pt_unregister_device(PCIDevice *d) machine_irq, errno); } } +s-machine_irq = 0; } /* delete all emulated config registers */ xen_pt_config_delete(s); -

[Qemu-devel] [PATCH v1 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap

with an old toolstack in which the Exx value is in rc or the newer, we add an wrapper around the xc_domain_add_to_physmap (called xen_xc_domain_add_to_physmap) which will always return the EXX. Suggested-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk

[Qemu-devel] [PATCH v1] Cleanups + various fixes due to libxl ABI + more logging on errors.

deletions(-) Konrad Rzeszutek Wilk (6): xen/pt: Update comments with proper function name. xen/pt: Make xen_pt_msi_set_enable static xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure xen: use errno instead of rc for xc_domain_add_to_physmap xen/pt/msi

[Qemu-devel] [PATCH v1 01/10] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

have to use a cast to thwart compiler warnings in the meantime. We also truncated 'flags' to 'flag' to make the code fit within the 80 characters. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.c | 24 +++--- hw/xen/xen_pt_config_init.c | 77

[Qemu-devel] [PATCH v1 10/10] xen/pt: Check for return values for xen_host_pci_[get|set] in init

and if we have failures we call xen_pt_destroy introduced in 'xen/pt: Move bulk of xen_pt_unregister_device in its own routine.' and free all of the allocated structures. Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

[Qemu-devel] [PATCH v1 06/10] xen/pt: Log xen_host_pci_get in two init functions

To help with troubleshooting in the field. Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen

[Qemu-devel] [PATCH v1 03/10] xen/pt: Check if reg-init function sets the 'data' past the reg-size

we still return an error. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index 3938afd..09309ba 100644 --- a/hw/xen

[Qemu-devel] [PATCH v1 04/10] xen/pt: Use xen_host_pci_get_[byte, word, long] instead of xen_host_pci_get_long

using an size mask and never modify the bits past 16-bit (reg-size is 2). This patch fixes the warnings by reading the value using the proper size. Note that the check for size is still left in-case the developer sets bits past the reg-size in the -init routines. Signed-off-by: Konrad Rzeszutek

[Qemu-devel] [PATCH v1 07/10] xen/pt: Log xen_host_pci_get/set errors in MSI code.

We seem to only use these functions when de-activating the MSI - so just log errors. Reviewed-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_msi.c | 18 ++ 1 file changed, 14 insertions(+), 4

[Qemu-devel] [PATCH v1 02/10] xen/pt: Sync up the dev.config and data values.

] Reported-by: Sander Eikelenboom li...@eikelenboom.it Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 48 - 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen

[Qemu-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent

-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen-host-pci-device.c | 5 + hw/xen/xen-host-pci-device.h | 1 + hw/xen/xen_pt.c | 22 -- hw/xen/xen_pt.h | 2 ++ 4 files changed, 24 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-host

[Qemu-devel] [PATCH v1] Remove XenPTReg-data and use dev.config for guest configuration values.

files changed, 288 insertions(+), 117 deletions(-) Konrad Rzeszutek Wilk (10): xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config xen/pt: Sync up the dev.config and data values. xen/pt: Check if reg-init function sets the 'data' past the reg-size xen/pt: Use

[Qemu-devel] [PATCH v1 05/10] xen/pt: Remove XenPTReg-data field.

(uint8_t, uint16_t, etc) and as well and pre-computed location. Alternatively we could compute the offset in dev.config by using the XenPTRRegInfo and XenPTRegGroup every time but this way we have the pre-computed values. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen

[Qemu-devel] [PATCH v1 09/10] xen/pt: Move bulk of xen_pt_unregister_device in its own routine.

This way we can call it if we fail during init. This code movement introduces no changes. Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.c | 119

Re: [Qemu-devel] [PATCH RFC 4/6] xen: Print and use errno where applicable.

On Wed, Jul 01, 2015 at 02:01:07PM +0100, Stefano Stabellini wrote: On Mon, 29 Jun 2015, Konrad Rzeszutek Wilk wrote: In Xen 4.6 commit cd2f100f0f61b3f333d52d1737dd73f02daee592 libxc: Fix do_memory_op to return negative value on errors made the libxc API less odd-ball: On errors, return

[Qemu-devel] [PATCH RFC 1 7/8] xen/pt: Move bulk of xen_pt_unregister_device in its own routine.

This way we can call it if we fail during init. This code movement introduces no changes. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.c | 119 +--- 1 file changed, 62 insertions(+), 57 deletions(-) diff --git

[Qemu-devel] [PATCH RFC 1 8/8] xen/pt: Check for return values for xen_host_pci_[get|set] in init

and if we have failures we call xen_pt_destroy introduced in 'xen/pt: Move bulk of xen_pt_unregister_device in its own routine.' and free all of the allocated structures. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.c | 32 +--- 1 file

[Qemu-devel] [PATCH RFC v1] Sync dev.config with XenPTReg-data field.

+++ hw/xen/xen_pt.h | 2 + hw/xen/xen_pt_config_init.c | 135 ++--- hw/xen/xen_pt_msi.c | 18 +++-- 6 files changed, 231 insertions(+), 87 deletions(-) Konrad Rzeszutek Wilk (8): xen/pt: Use xen_host_pci_get_[byte

[Qemu-devel] [PATCH RFC 1 6/8] xen/pt: Make xen_pt_unregister_device idempotent

-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen-host-pci-device.c | 5 + hw/xen/xen-host-pci-device.h | 1 + hw/xen/xen_pt.c | 22 -- hw/xen/xen_pt.h | 2 ++ 4 files changed, 24 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-host

[Qemu-devel] [PATCH RFC 1 4/8] xen/pt: Log xen_host_pci_get in two init functions

To help with troubleshooting in the field. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index bc871c9..62b6a7b 100644 --- a/hw/xen

[Qemu-devel] [PATCH RFC 1 5/8] xen/pt: Log xen_host_pci_get/set errors in MSI code.

We seem to only use these functions when de-activating the MSI - so just log errors. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_msi.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt_msi.c b/hw/xen

[Qemu-devel] [PATCH RFC 1 1/8] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

have to use a cast to thwart compiler warnings in the meantime. We also truncated 'flags' to 'flag' to make the code fit within the 80 characters. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.c | 22 +++-- hw/xen/xen_pt_config_init.c | 77

[Qemu-devel] [PATCH RFC 1 2/8] xen/pt: Sync up the dev.config and data values.

,fbcff] [The DEBUG is to illustate what the hvmloader was doing] Reported-by: Sander Eikelenboom li...@eikelenboom.it Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 45 - 1 file changed, 44 insertions(+), 1

[Qemu-devel] [PATCH RFC 1 3/8] xen/pt: Check if reg-init is past the reg-size

It should never happen, but in case it does we want to report. The code will only write up to reg-size so there is no runtime danger. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH RFC 5/6] xen/pt/msi: Add the register value when printing logging and error messages

We would like to know what the MSI register value is to help in troubleshooting in the field. As such modify the logging logic to include such details in xen_pt_msgctrl_reg_write. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt_config_init.c | 6 +++--- 1 file

[Qemu-devel] [PATCH RFC 2/6] xen/pt: Make xen_pt_msi_set_enable static

As we do not use it outside our code. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- hw/xen/xen_pt.h | 1 - hw/xen/xen_pt_msi.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index 393f36c..09358b1 100644 --- a/hw/xen

[Qemu-devel] [PATCH RFC 4/6] xen: Print and use errno where applicable.

with an old toolstack in which the Exx value is in rc or the newer, we print both and return the -EXX depending on rc == -1 condition. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- xen-hvm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xen-hvm.c

[Qemu-devel] [PATCH RFC 6/6] xen: Add backtrace for serious issues.

When debugging issues that caused the emulator to kill itself or skipping certain operations (unable to write to host registers) an stack trace will most definitly aid in debugging the problem. As such this patch uses the most basic backtrace to print out details. Signed-off-by: Konrad Rzeszutek

  1   2   3   >