Reviewed-by: Konstantin Kostiuk
On Tue, May 14, 2024 at 1:58 PM Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/qerror.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
Reviewed-by: Konstantin Kostiuk
On Tue, May 14, 2024 at 1:58 PM Markus Armbruster wrote:
> Some, but not all error messages are of the form
>
> Guest agent command failed, error was ''
>
> For instance, command guest-exec can fail with an error message like
>
>
Reviewed-by: Konstantin Kostiuk
On Tue, May 14, 2024 at 2:03 PM Markus Armbruster wrote:
> When guest-set-user-password's argument @password can't be converted
> from UTF-8 to UTF-16, we report something like
>
> Guest agent command failed, error was 'Invalid sequence i
From: Andrey Drobyshev
There's no need to check for the existence of the "chpasswd", "pw"
executables, as the exec() call will do that for us.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https
From: Andrey Drobyshev
Also remove the G_GNUC_UNUSED attribute added in the previous commit from
the helper.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-4-andrey.drobys...@virtuozzo.com
s returned
by statvfs(3).
While here, also tweak the docs to reflect better where those values
come from.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-2-andrey.drobys...@virtuozzo.com
Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-3-andrey.drobys...@virtuozzo.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 150 +++
1 file changed, 150 insertions(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
From: aidaleuc
Signed-off-by: Aidan Leuck
Tested-by: Dehan Meng
Reviewed-by: Konstantin Kostiuk
Link: https://lore.kernel.org/r/20240424144029.30665-3-aidan_le...@selinc.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-windows-ssh.c | 712 +
qga
From: Andrey Drobyshev
There's no need to check for the existence of "/sbin/hwclock", the
exec() call will do that for us.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-5-and
The following changes since commit 9c6c079bc6723da8061ccfb44361d67b1dd785dd:
Merge tag 'pull-target-arm-20240430' of
https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-04-30
09:58:54 -0700)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git
one write to /sys/power/state.
Let's just use g_file_set_contents() to simplify things here.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-7-and
From: Andrey Drobyshev
There's no need to check for the existence of the hook executable, as the
exec() call will do that for us.
Signed-off-by: Andrey Drobyshev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Konstantin Kostiuk
Link:
https://lore.kernel.org/r/20240320161648.158226-6
-by: Aidan Leuck
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Dehan Meng
Reviewed-by: Konstantin Kostiuk
Link: https://lore.kernel.org/r/20240424144029.30665-2-aidan_le...@selinc.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-common-ssh.c | 50 +
Hi Paolo,
Are you ok if I merge this patch with other QGA patches?
Or don't you agree with this version of the patch?
Best Regards,
Konstantin Kostiuk.
On Fri, Apr 26, 2024 at 3:15 PM Konstantin Kostiuk
wrote:
> Compilation QGA without system and user fails
> ./configure --disable-
Reviewed-by: Konstantin Kostiuk
On Fri, Apr 26, 2024 at 7:23 PM Thomas Huth wrote:
> According to the comment in qga/meson.build, the test got disabled
> since there were problems with the fuzzing job. But instead of
> disabling this test completely, we should still be fine running
Signed-off-by: Konstantin Kostiuk
---
stubs/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/stubs/meson.build b/stubs/meson.build
index 8ee1fd5753..3b9d42023c 100644
--- a/stubs/meson.build
+++ b/stubs/meson.build
@@ -21,12 +21,12 @@ if have_block
stub_ss.add(f
v1 -> v2:
- Added the link failure output
Konstantin Kostiuk (1):
stubs: Add missing qga stubs
stubs/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
--
2.44.0
On Fri, Apr 26, 2024 at 2:08 PM Philippe Mathieu-Daudé
wrote:
> On 25/4/24 13:04, Konstantin Kostiuk wrote:
> > Compilation QGA without system and user fails
> > ./configure --disable-system --disable-user --enable-guest-agent
>
> So this config isn't tested on CI.
>
&g
Compilation QGA without system and user fails
./configure --disable-system --disable-user --enable-guest-agent
Fixes: 3a15604900c4f433c970cc6294520a98f201287e
Signed-off-by: Konstantin Kostiuk
---
stubs/meson.build | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/stubs
To series:
Reviewed-by: Konstantin Kostiuk
On Wed, Mar 20, 2024 at 6:17 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> v3 -> v4:
> * Patch 1/7:
> - Replaced "since 8.3" with "since 9.0" as we're now at v9.0.0-rc0;
> - Ren
On Tue, Apr 23, 2024 at 6:02 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
>
Please resend with the real name in Signed-off-by
Assuming this changes:
Reviewed-by: Konstantin Kostiuk
> ---
> qga/commands-windows-ssh.c | 712 +++
On Tue, Apr 23, 2024 at 6:01 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
>
Please resend with the real name in Signed-off-by
Assuming this changes:
Reviewed-by: Konstantin Kostiuk
> ---
> qga/commands-common-ssh.c | 50 +
On Mon, Apr 22, 2024 at 9:25 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
> ---
> qga/commands-windows-ssh.c | 712 +
> qga/commands-windows-ssh.h | 26 ++
> qga/meson.build| 7 +-
> qga/qapi-schema.json | 17 +-
> 4 files
proper
permissions
to make the SSH server happy.
[image: Screenshot_20240422_112242.png]
[image: Screenshot_20240422_112352.png]
Best Regards,
Konstantin Kostiuk.
On Fri, Mar 29, 2024 at 5:32 PM wrote:
> From: aidaleuc
>
> This patch aims to implement guest-ssh-add-authorized-ke
Hi Aidan,
Thank you for these patches. Currently, I don't have any comments.
I asked QE from my team to test this patch and wait for feedback.
Also, QEMU is in the code freeze stage now, so I plan to merge all QGA
patches after release.
Best Regards,
Konstantin Kostiuk.
On Tue, Apr 16, 2024
> create mode 100644 qga/commands-common-ssh.h
>
> Kostiantyn, if you take this patch, please amend the commit
> description and prefix the subject with 'qga: ' :)
>
I will do this.
Best Regards,
Konstantin Kostiuk.
> Thanks,
>
> Phil.
>
>
Hi Andrey,
I am ok with these changes.
No need new iteration with the version change, I will update before merging.
I will merge it after release.
Best Regards,
Konstantin Kostiuk.
On Mon, Apr 1, 2024 at 5:49 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> On 3/22
On Tue, Mar 19, 2024 at 8:18 PM wrote:
> From: aidaleuc
>
> Signed-off-by: aidaleuc
> ---
> qga/commands-posix-ssh.c | 47 +--
> qga/commands-ssh-core.c| 52 +++
> qga/commands-ssh-core.h| 20 ++
> qga/commands-windows-ssh.c | 686 +
>
age-ID: <20240222152835.72095-3-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
Link: https://lore.kernel.org/r/20240304134532.28506-3-kkost...@redhat.com
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 48 +---
1
From: Philippe Mathieu-Daudé
Most of the code base use the 'const' qualifier *before*
the type being qualified. Use the same style to unify.
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240222152835.72095-2-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Yan Vuge
The following changes since commit 7489f7f3f81dcb776df8c1b9a9db281fc21bf05f:
Merge tag 'hw-misc-20240309' of https://github.com/philmd/qemu into staging
(2024-03-09 20:12:21 +)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-2024-03-11-2
From: Dehan Meng
Add support of Windows Server 2025 in get-osinfo command
Signed-off-by: Dehan Meng
Message-ID: <20240222152835.72095-4-phi...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Yan Vugenfirer
Link: https://lore.kernel
Hi Markus,
I will merge qga-related patches in my PULL.
Best Regards,
Konstantin Kostiuk.
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> We use doc comment "Returns" sections both for success and error
> response. This series moves the latter to new "Errors
Respin of Philippe's v3 to fix multidimensional array compilation error.
Supersedes: <20240222025437.58996-1-dem...@redhat.com>
Supersedes: <20240222152835.72095-1-phi...@linaro.org>
Dehan Meng (1):
qga-win: Add support of Windows Server 2025 in get-osinfo command
Philippe Mathieu-Daudé (2):
From: Philippe Mathieu-Daudé
Most of the code base use the 'const' qualifier *before*
the type being qualified. Use the same style to unify.
Signed-off-by: Philippe Mathieu-Daudé
Message-ID: <20240222152835.72095-2-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Kons
From: Dehan Meng
Add support of Windows Server 2025 in get-osinfo command
Signed-off-by: Dehan Meng
Message-ID: <20240222152835.72095-4-phi...@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32
age-ID: <20240222152835.72095-3-phi...@linaro.org>
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 52 +---
1 file changed, 25 insertions(+), 27 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-w
For series
Reviewed-by: Konstantin Kostiuk
On Fri, Mar 1, 2024 at 7:29 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> v1 --> v2:
> * Replace commit for guest-get-fsinfo: instead of reporting statvfs(3)
>values directly, keep the old ones but add an a
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 12
> 1 file changed, 12 deletions(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Drop "on success" where it is redundant with "Returns:".
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 16
> 1 file
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 22 ++
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/qga/qapi-sche
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> "Returns:" sections of guest-fsfreeze-freeze and
> guest-fsfreeze-freeze-list describe both command behavior and success
> response. Move behavior out, so "Returns:" is
Reviewed-by: Konstantin Kostiuk
On Tue, Feb 27, 2024 at 1:39 PM Markus Armbruster wrote:
> Documentation claims the command can "return NULL". "NULL" doesn't
> exist in JSON. "null" does, but the command returns lists, and null
> isn't. Correct
Best Regards,
Konstantin Kostiuk.
On Mon, Feb 26, 2024 at 7:02 PM Andrey Drobyshev <
andrey.drobys...@virtuozzo.com> wrote:
> Since the commit 25b5ff1a86 ("qga: add mountpoint usage info to
> GuestFilesystemInfo") we have 2 values reported in guest-get-fsinfo:
> u
imensional array must have bounds for all dimensions except the
first
I think we can do the same as with Win10 and create 2 variables:
WIN_SERVER_VERSION_MATRIX and WIN_CLIENT_VERSION_MATRIX
If you want I can fix this by myself.
Best Regards,
Konstantin Kostiuk.
{
> /
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 22, 2024 at 5:29 PM Philippe Mathieu-Daudé
wrote:
> From: Dehan Meng
>
> Add support of Windows Server 2025 in get-osinfo command
>
> Signed-off-by: Dehan Meng
> Message-ID: <20240222025352.58859-2-dem...@redhat.com>
&
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 22, 2024 at 5:28 PM Philippe Mathieu-Daudé
wrote:
> ga_get_win_name() iterates over all elements in the arrays by
> checking the 'version' field is non-NULL. Since the arrays are
> guarded by a NULL terminating element, we don't need t
Reviewed-by: Konstantin Kostiuk
On Thu, Feb 22, 2024 at 5:28 PM Philippe Mathieu-Daudé
wrote:
> Most of the code base use the 'const' qualifier *before*
> the type being qualified. Use the same style to unify.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> qga/com
On Wed, Feb 21, 2024 at 11:51 AM Dehan Meng wrote:
> Add support of Windows Server 2025 in get-osinfo command
>
> Signed-off-by: Dehan Meng
> ---
> qga/commands-win32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index
Reviewed-by: Konstantin Kostiuk
On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 20 +++
Reviewed-by: Konstantin Kostiuk
On Mon, Feb 5, 2024 at 9:47 AM Markus Armbruster wrote:
> The command's doc comment describes the argument, but it's not marked
> up as such. Easy enough to fix.
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 19 ++
From: Nick Briggs
Solaris has net/if_arp.h and netinet/if_ether.h rather than net/ethernet.h,
but does not define ETHER_ADDR_LEN, instead providing ETHERADDRL.
Signed-off-by: Nick Briggs
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-posix.c | 5 -
1
:
https://learn.microsoft.com/en-us/windows/win32/api/winioctl/ns-winioctl-volume_disk_extents
Signed-off-by: Peng Ji
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/commands-win32.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qga/commands-win32.c b/qga
From: "Angel M. Villegas"
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1757
Updates to qga help output and documentation for --allow-rpcs and --blocks-rpcs
Signed-off-by: "Angel M. Villegas"
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
--
From: Samuel Tardieu
guest-exec invocation does not need the full path of the executable to
execute. Using only the command names ensures correct execution of the
test on systems not adhering to the FHS.
Signed-off-by: Samuel Tardieu
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Philippe
The following changes since commit 11be70677c70fdccd452a3233653949b79e97908:
Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into
staging (2024-01-29 10:53:56 +)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-2024-01-30
Reviewed-by: Konstantin Kostiuk
On Mon, Jan 29, 2024 at 1:50 PM Markus Armbruster wrote:
> Documentation of type BlockdevOptionsIscsi describes the type's
> purpose after its members. Everywhere else, we do it the other way
> round. Move it for consistency.
>
> Signed
Reviewed-by: Konstantin Kostiuk
On Mon, Jan 29, 2024 at 1:50 PM Markus Armbruster wrote:
> Documentation of commands guest-ssh-get-authorized-keys,
> guest-ssh-add-authorized-keys, and guest-ssh-remove-authorized-keys
> describes the command's purpose after its arguments. Everyw
Reviewed-by: Konstantin Kostiuk
On Thu, Jan 11, 2024 at 10:18 PM Nick Briggs
wrote:
> Solaris has net/if_arp.h and netinet/if_ether.h rather than net/ethernet.h,
> but does not define ETHER_ADDR_LEN, instead providing ETHERADDRL.
>
> Signed-off-by: Nick Briggs
> ---
> qg
Reviewed-by: Konstantin Kostiuk
On Wed, Jan 3, 2024 at 7:34 PM Philippe Mathieu-Daudé
wrote:
> On 3/1/24 17:51, Samuel Tardieu wrote:
> > guest-exec invocation does not need the full path of the executable to
> > execute. Using only the command names ensures correct execution
Reviewed-by: Konstantin Kostiuk
On Wed, Jan 10, 2024 at 9:42 AM Peng Ji wrote:
> ping !
> please review this patch :
> https://patchew.org/QEMU/20231227071540.4035803-1-peng...@smartx.com/
>
> thanks
>
>
>
> On Fri, Jan 5, 2024 at 9:47 PM Philippe Mathieu-Daudé
&
Hi Dehan,
Thanks for your patch
Please see my comment below
On Fri, Nov 24, 2023 at 5:40 AM Dehan Meng wrote:
> The Route information of the Linux VM needs to be used
> by administrators and users when debugging network problems
> and troubleshooting.
>
> Signed-off-by: Dehan Meng
> ---
>
Hi Stefan,
Thanks for your patch.
PULL was sent with Marc-André patch
https://patchew.org/QEMU/20231125173011.374840-1-kkost...@redhat.com/
Best Regards,
Konstantin Kostiuk.
On Sat, Nov 25, 2023 at 5:29 PM Stefan Weil via
wrote:
> Meson setup failed:
>
> qga/meson.build:148
PULL sent
https://patchew.org/QEMU/20231125173011.374840-1-kkost...@redhat.com/
On Sat, Nov 25, 2023 at 7:15 PM Konstantin Kostiuk
wrote:
> Reviewed-by: Konstantin Kostiuk
>
> On Thu, Nov 2, 2023 at 4:10 PM wrote:
>
>> From: Marc-André Lureau
>>
>> Program
The following changes since commit 4705fc0c8511d073bee4751c3c974aab2b10a970:
Merge tag 'pull-for-8.2-fixes-231123-1' of https://gitlab.com/stsquad/qemu
into staging (2023-11-24 08:00:18 -0500)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git
From: Marc-André Lureau
Program wixl found: YES (/usr/bin/wixl)
../qga/meson.build:149:16: ERROR: Unknown variable "project".
Fixes: e20d68aa0b9 ("configure, meson: use command line options to configure
qemu-ga")
Signed-off-by: Marc-André Lureau
Reviewed-by: Konstantin
Reviewed-by: Konstantin Kostiuk
On Thu, Nov 2, 2023 at 4:10 PM wrote:
> From: Marc-André Lureau
>
> Program wixl found: YES (/usr/bin/wixl)
>
> ../qga/meson.build:149:16: ERROR: Unknown variable "project".
>
> Fixes: e20d68aa0b9 ("configure, meson: use comm
Reviewed-by: Konstantin Kostiuk
On Tue, Nov 7, 2023 at 12:18 PM Thomas Huth wrote:
> contrib/systemd/qemu-guest-agent.service , tests/data/test-qga-config
> and tests/data/test-qga-os-release belong to the guest agent, so make
> sure that these files are covered here, too.
>
Reviewed-by: Konstantin Kostiuk
On Tue, Oct 31, 2023 at 1:11 PM Markus Armbruster wrote:
> When the PID passed to guest-exec-status does not exist, we report
>
> "Invalid parameter 'pid'"
>
> Improve this to
>
> "PID 1234 does not exist&q
On Mon, Oct 30, 2023 at 6:32 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
>
>
> On 10/26/23 11:16, Konstantin Kostiuk wrote:
> >
> > I think it is better to check that timeout <= 10 sec in the case of
> > Windows.
> > Anyway this is a VSS
On Wed, Oct 25, 2023 at 5:01 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> VSS requestor calls abort after the timeout of the backup operation
> expires. In the result later the process hangs on some internal VSS
> lock. Cancel async snapshot before abort.
>
Can you share some
I think it is better to check that timeout <= 10 sec in the case of Windows.
Anyway this is a VSS limitation and FS will be unfrozen earlier if timeout
> 10 sec,
this can cause some misunderstanding from a user.
timeout option sounds good in the guest-fsfreeze-freeze command.
In
Reviewed-by: Konstantin Kostiuk
On Wed, Oct 25, 2023 at 5:01 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> VSS requestor calls abort after the timeout of the backup operation
> expires. In the result later the process hangs on some internal VSS
> lock. Cancel
On Wed, Oct 25, 2023 at 5:01 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> In qmp_guest_set_user_password() we have a part of code that we can reuse
> in the future commits. Move this code to a separate function.
>
> Signed-off-by: Alexander Ivanov
> ---
> qga/commands-posix.c
On Wed, Oct 25, 2023 at 5:01 PM Alexander Ivanov <
alexander.iva...@virtuozzo.com> wrote:
> We need to terminate processes executed with guest-exec command. Add
> guest-exec-terminate command for process termination by PID.
>
> Signed-off-by: Alexander Ivanov
> ---
> qga/commands-common.h | 2
Reviewed-by: Konstantin Kostiuk
On Fri, Oct 13, 2023 at 11:50 AM Emmanouil Pitsidianakis <
manos.pitsidiana...@linaro.org> wrote:
> In preparation of raising -Wimplicit-fallthrough to 5, replace all
> fall-through comments with the fallthrough attribute pseudo-keyword.
&g
Reviewed-by: Konstantin Kostiuk
On Fri, Oct 13, 2023 at 6:53 PM Angel M. Villegas
wrote:
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1757
>
> Updates to qga help output and documentation for --allow-rpcs and
> --blocks-rpcs
>
> Signed-off-by: Angel M. Ville
merged
On Sun, Oct 1, 2023 at 9:39 PM Daniel Xu wrote:
> These are two small fixes that fell out of [0]. Since we are not moving
> forward with that patchset, I thought it would be good to at least send
> the fixes that came out of it.
>
> See commits for more details.
>
> [0]:
>
-by: Daniel Xu
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Konstantin Kostiuk
---
qga/qapi-schema.json | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index b720dd4379..876e2a8ea8 100644
--- a/qga/qapi-schema.json
+++ b/qga
The following changes since commit cea3ea670fe265421131aad90c36fbb87bc4d206:
Merge tag 'pull-vfio-20231009' of https://github.com/legoater/qemu into
staging (2023-10-09 10:11:35 -0400)
are available in the Git repository at:
https://github.com/kostyanf14/qemu.git tags/qga-pull-2023-10-11
not get run if the command
doesn't write to the stream.
Fix by making free() unconditional.
Reviewed-by: Konstantin Kostiuk
Signed-off-by: Daniel Xu
Signed-off-by: Konstantin Kostiuk
---
qga/commands.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qga/commands.c b/qga/comm
From: Akihiko Odaki
GUID_DEVINTERFACE_DISK and GUID_DEVINTERFACE_STORAGEPORT are already
defined by MinGW-w64. They are not only unnecessary, but can lead to
duplicate definition errors at link time with some unknown condition.
Signed-off-by: Akihiko Odaki
Reviewed-by: Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk
On Sun, Oct 1, 2023 at 9:39 PM Daniel Xu wrote:
> If output is being captured for a guest-exec invocation, the out-data
> and err-data fields of guest-exec-status are only populated after the
> process is reaped. This is somewhat counter intuitive and
/Features/VirtioSerial
Is this solution good for your project?
Best Regards,
Konstantin Kostiuk.
On Mon, Sep 18, 2023 at 8:17 PM Daniel Xu wrote:
> Hi Daniel,
>
> On Mon, Sep 18, 2023 at 04:14:47PM +0100, Daniel P. Berrangé wrote:
> > On Mon, Sep 18, 2023 at 04:54:22AM -0600,
Reviewed-by: Konstantin Kostiuk
On Mon, Sep 18, 2023 at 2:00 PM Daniel Xu wrote:
> If capture-output is requested but one of the channels goes unused (eg.
> we attempt to capture stderr but the command never writes to stderr), we
> can leak memory.
>
> guest_exec_output_watch(
Hi Akihiko,
Thanks for ping.
I will merge this commit with other qga fixes.
Best Regards,
Konstantin Kostiuk.
On Thu, Sep 21, 2023 at 10:58 AM Akihiko Odaki
wrote:
> On 2022/11/17 18:45, Konstantin Kostiuk wrote:
> > Reviewed-by: Konstantin Kostiuk > <mailto:kkos
Hi, Efim
Thanks for your contribution.
I think your patch is a partial solution because other network managers can
be used
for example systemd-networkd or dhcpcd. Maybe a better solution is
After=network.target.
Do you have any other suggestions?
Best Regards,
Konstantin Kostiuk.
On Wed, Aug
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/install.cpp | 12 ++--
qga/vss-win32/requester.cpp | 9 +
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/qga/vss-win32/install.cpp b/qga/vss
Reviewed-by: Thomas Huth
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/meson.build | 2 +-
qga/vss-win32/vss-debug.cpp | 39 +
qga/vss-win32/vss-debug.h | 25
3 files changed, 65 insertions(+), 1 deletion(-)
create mode
-by: Konstantin Kostiuk
---
docs/interop/qemu-ga.rst | 5 +++
qga/main.c | 85 +---
2 files changed, 84 insertions(+), 6 deletions(-)
diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
index a9183802d1..461c5a35ee 100644
--- a/docs/interop
Reviewed-by: Marc-André Lureau
Signed-off-by: Konstantin Kostiuk
---
tests/unit/test-qga.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index 360b4cab23..671e83cb86 100644
--- a/tests/unit/test-qga.c
+++ b
Add several qga_debug() statements in functions.
Reviewed-by: Thomas Huth
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/install.cpp | 35 +++
qga/vss-win32/provider.cpp | 3 +++
qga/vss-win32/requester.cpp | 34 ++
3
Reviewed-by: Marc-André Lureau
Signed-off-by: Konstantin Kostiuk
---
qga/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 2b992a55b3..121ff7a748 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -395,7 +395,7 @@ static gint ga_strcmp
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Signed-off-by: Konstantin Kostiuk
---
qga/vss-win32/requester.cpp | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
index e85b9bc633..f3eafacfc1
Konstantin Kostiuk (7):
qga: Rename ga_disable_not_allowed -> ga_disable_not_allowed_freeze
qga: Add new option --allow-rpcs
qga: Add tests for --allow-rpcs option
QGA VSS: Add wrapper to send log to debugger and stderr
QGA VSS: Replace 'fprintf(stderr' with qga_de
Hi Thomas,
Do you have any other comments about this commit?
On Mon, Jul 10, 2023 at 12:16 PM Konstantin Kostiuk
wrote:
> Add several qga_debug() statements in functions.
>
> Signed-off-by: Konstantin Kostiuk
> ---
> qga/vss-win32/install.cpp | 35 +++
The allow-rpcs option accepts a comma-separated list of RPCs to
enable. This option is opposite to --block-rpcs. Using --block-rpcs
and --allow-rpcs at the same time is not allowed.
resolves: https://gitlab.com/qemu-project/qemu/-/issues/1505
Signed-off-by: Konstantin Kostiuk
---
docs/interop
Signed-off-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
---
tests/unit/test-qga.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index 360b4cab23..671e83cb86 100644
--- a/tests/unit/test-qga.c
+++ b
ile specified
v1: https://patchew.org/QEMU/20230706083035.623802-1-kkost...@redhat.com/
Konstantin Kostiuk (3):
qga: Rename ga_disable_not_allowed -> ga_disable_not_allowed_freeze
qga: Add new option --allow-rpcs
qga: Add tests for --allow-rpcs option
docs/interop/qemu-ga.rst | 5 +++
qga/
Signed-off-by: Konstantin Kostiuk
Reviewed-by: Marc-André Lureau
---
qga/main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qga/main.c b/qga/main.c
index 2b992a55b3..121ff7a748 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -395,7 +395,7 @@ static gint ga_strcmp
1 - 100 of 378 matches
Mail list logo
