Re: [PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

2021-03-30 Thread Luis Henriques
On Mon, Mar 29, 2021 at 03:51:51PM -0400, Vivek Goyal wrote: > On Mon, Mar 29, 2021 at 04:35:57PM +0100, Luis Henriques wrote: > > On Thu, Mar 25, 2021 at 11:38:52AM -0400, Vivek Goyal wrote: > > > When posix access acls are set on a file, it can lead to adjusting file > >

Re: [PATCH v5 5/5] virtiofsd: Switch creds, drop FSETID for system.posix_acl_access xattr

2021-03-29 Thread Luis Henriques
that instead. That's an TODO item for future when idmapped mount > support is introduced. > > Reported-by: Luis Henriques > Signed-off-by: Vivek Goyal > --- > include/standard-headers/linux/fuse.h | 7 + > tools/virtiofsd/passthrough_ll.c | 42 +

Re: [PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-23 Thread Luis Henriques
On Fri, Feb 19, 2021 at 11:50:54AM +, Luis Henriques wrote: > Vivek Goyal writes: > > > Hi, > > > > This is V2 of the patches. Changes since v1 are. > > > > - Rebased on top of latest master. > > - Took care of Miklos's comments to block acl xat

Re: [PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-19 Thread Luis Henriques
Miklos Szeredi writes: > On Fri, Feb 19, 2021 at 3:34 PM Vivek Goyal wrote: >> >> On Fri, Feb 19, 2021 at 11:50:54AM +, Luis Henriques wrote: >> > Vivek Goyal writes: >> > >> > > Hi, >> > > >> > > This is V2 of the pa

Re: [PATCH v2 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-19 Thread Luis Henriques
Vivek Goyal writes: > Hi, > > This is V2 of the patches. Changes since v1 are. > > - Rebased on top of latest master. > - Took care of Miklos's comments to block acl xattrs if user > explicitly disabled posix acl. > > Luis Henriques reported that fstest

Re: [PATCH 0/3] virtiofsd: Add options to enable/disable posix acl

2021-02-17 Thread Luis Henriques
Vivek Goyal writes: > Luis Henriques reported that fstest generic/099 fails with virtiofs. > Little debugging showed that we don't enable acl support. So this > patch series provides option to enable/disable posix acl support. By > default it is disabled. > > I have run b