p support for grants. */
+memory_region_init_ram(_grants, NULL, "xen.grants", block_len,
+ _fatal);
+memory_region_add_subregion(sysmem, XEN_GRANT_ADDR_OFF, _grants);
}
void arch_handle_ioreq(XenIOState *state, ioreq_t *req)
--
2.40.1
Reviewed-by: Manos Pitsidianakis
On Thu, 16 May 2024 18:48, "Edgar E. Iglesias" wrote:
From: "Edgar E. Iglesias"
Add a second mapcache for grant mappings. The mapcache for
grants needs to work with XC_PAGE_SIZE granularity since
we can't map larger ranges than what has been granted to us.
Like with foreign mappings
F: include/hw/usb.h
F: include/hw/usb/
USB (serial adapter)
-R: Gerd Hoffmann
M: Samuel Thibault
S: Maintained
F: hw/usb/dev-serial.c
--
2.45.0
Reviewed-by: Manos Pitsidianakis
rtio-gpu.h
@@ -2595,7 +2594,6 @@ F: include/hw/virtio/virtio-blk-common.h
vhost-user-gpu
M: Marc-André Lureau
-R: Gerd Hoffmann
S: Maintained
F: docs/interop/vhost-user-gpu.rst
F: contrib/vhost-user-gpu
--
2.45.0
Reviewed-by: Manos Pitsidianakis
@@ F: qapi/ui.json
F: docs/spice-port-fqdn.txt
Graphics
-M: Gerd Hoffmann
M: Marc-André Lureau
S: Odd Fixes
F: ui/
--
2.45.0
Reviewed-by: Manos Pitsidianakis
On Mon, 20 May 2024 00:27, Dmitry Osipenko
wrote:
From: Antonio Caggiano
Request Venus when initializing VirGL and if venus=true flag is set for
virtio-gpu-gl device.
Signed-off-by: Antonio Caggiano
Signed-off-by: Huang Rui
Signed-off-by: Dmitry Osipenko
---
hw/display/virtio-gpu-gl.c
VirtIOGPU *g);
void virtio_gpu_virgl_reset(VirtIOGPU *g);
int virtio_gpu_virgl_init(VirtIOGPU *g);
void virtio_gpu_virgl_deinit(VirtIOGPU *g);
-int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g);
+GArray *virtio_gpu_virgl_get_capsets(VirtIOGPU *g);
#endif
--
2.44.0
Reviewed-by: Manos Pitsidianakis
AINERS
> ...
> > @@ -2388,7 +2387,6 @@ F: hw/virtio/virtio-mem-pci.c
> > F: include/hw/virtio/virtio-mem.h
> >
> > virtio-snd
> > -M: Gerd Hoffmann
> > R: Manos Pitsidianakis
> > S: Supported
>
> I think the status should be downgraded to Orp
On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote:
>
> On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote:
> > On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland
> > wrote:
> > >
> > > On 25/04/2024 07:30, Manos Pitsidianakis wrote:
> &
On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland
wrote:
>
> On 25/04/2024 07:30, Manos Pitsidianakis wrote:
>
> > On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland
> > wrote:
> >>
> >> On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote:
> >>
&
On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland
wrote:
>
> On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote:
>
> > On 23/4/24 11:18, Manos Pitsidianakis wrote:
> >> On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis
> >> wrote:
> >>>
> >>>
On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis
wrote:
>
> On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote:
> >
> > On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote:
> > > On 22/4/24 23:02, Michael S. Tsirkin wrote:
> > > > O
On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote:
>
> On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote:
> > On 22/4/24 23:02, Michael S. Tsirkin wrote:
> > > On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote:
> > > > Since VirtIO devices can change
: Philippe Mathieu-Daudé
---
Reviewed-by: Manos Pitsidianakis
Thanks for the explanation on v2 btw. virtio_is_big_endian()'s doc
should probably reflect it's not just about legacy devices (virtio sound
isn't legacy) but about target originating data streams too
On Mon, 22 Apr 2024 16:13, Philippe Mathieu-Daudé wrote:
Since VirtIO devices can change endianness at runtime,
we need to use the device endianness, not the target
one.
Hey Philippe, can you clarify what do you mean by they can change
endianness at runtime?
The target's one is used
Extract audio card removal logic out of the device unrealize callback so
that it can be re-used in follow up commits.
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/hw/audio/virtio-snd.c b/hw
Extract audio card setup logic out of the device realize callback so
that it can be re-used in follow up commits.
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.c | 72 ---
1 file changed, 41 insertions(+), 31 deletions(-)
diff --git a/hw
ERROR: AddressSanitizer: heap-buffer-overflow [..snip..] in
virtio_snd_handle_rx_xfer().
Closes #2296.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2296
Reported-by: Zheyu Ma
Suggested-by: Zheyu Ma
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.
Factor out virtio_snd_config value validation in a separate function, in
order to re-use it in follow up commits.
Signed-off-by: Manos Pitsidianakis
---
hw/audio/virtio-snd.c | 47 ++-
1 file changed, 29 insertions(+), 18 deletions(-)
diff --git a/hw
Changing the number of streams via virtio_snd_set_config() did not
re-configure the audio card, leaving it in an invalid state.
Reported in https://gitlab.com/qemu-project/qemu/-/issues/2296
Manos Pitsidianakis (4):
virtio-snd: add virtio_snd_is_config_valid()
virtio-snd: factor card setup
s/Resolved:/Resolves:/
Cc: qemu-triv...@nongnu.org
Signed-off-by: Manos Pitsidianakis
---
docs/devel/submitting-a-patch.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/devel/submitting-a-patch.rst
b/docs/devel/submitting-a-patch.rst
index c641d948f1..83e9092b8c
On Fri, 5 Apr 2024 at 14:07, Michael S. Tsirkin wrote:
>
> On Fri, Apr 05, 2024 at 01:54:46PM +0300, Manos Pitsidianakis wrote:
> > ping
>
> confused at this point.
> Do you mind sending a patchset with everything in the correct order?
> Tag it PATCH repost so peo
ping
On Sun, 24 Mar 2024 12:04, Manos Pitsidianakis
wrote:
This is a logic fix for the error handling in the TX/RX virt queue
handlers. A potential invalid address dereference was reported and fixed
by Zheyu Ma in <20240322110827.568412-1-zheyum...@gmail.com>. This patch
moves the i
-posix.c:372:9
#8 0x57cea3979385 in aio_dispatch_handlers qemu/util/aio-posix.c:414:20
#9 0x57cea3978eb1 in aio_dispatch qemu/util/aio-posix.c:424:5
#10 0x57cea3a1eede in aio_ctx_dispatch qemu/util/async.c:360:5
Signed-off-by: Zheyu Ma
Reviewed-by: Manos Pitsidianakis
---
Changes in v2
rns, so the queue must be empty at any other point of the device's
lifetime.
Signed-off-by: Manos Pitsidianakis
---
include/hw/audio/virtio-snd.h | 16 +++-
hw/audio/virtio-snd.c | 137 +++---
2 files changed, 77 insertions(+), 76 deletions(-)
diff --
ndling for invalid
transfers
From: Zheyu Ma
Date: Fri, 22 Mar 2024 12:08:27 +0100
Message-Id: <20240322110827.568412-1-zheyum...@gmail.com>
Manos Pitsidianakis (1):
virtio-snd: rewrite invalid tx/rx message handling
include/hw/audio/virtio-snd.h | 16 +++-
hw/audio/
think
the invalid queue should be moved to the device struct since it's not
stream specific.
Cc'ing qemu-stable because this bug is present in current versions.
Please make the same changes to virtio_snd_handle_rx_xfer() as well and
send a v2, cc'ing qemu-stable. With those changes you can add:
t; the case of the custom runners we also move the free floating variable
> to the runner template.
>
> Signed-off-by: Alex Bennée
>
> ---
> v2
> - make custom runners follow the legacy options
> ---
Reviewed-by: Manos Pitsidianakis
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
xen_arch_set_memory() is not arch-specific anymore. Being
called once, inline it in xen_set_memory().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/xen/xen-hvm-common.h | 3 -
hw/xen/xen-hvm-common.c | 104
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé wrote:
hw/i386/xen/xen-hvm-common.c content is target agnostic,
and should be common to all targets. Merge both files.
Remove the now unnecessary xen_register_framebuffer() stub.
ARM targets now inherit the common xen_memory_listener.
waddr start_addr = section->offset_within_address_space;
-ram_addr_t size = int128_get64(section->size);
-bool log_dirty = memory_region_is_logging(section->mr, DIRTY_MEMORY_VGA);
-hvmmem_type_t mem_type;
-
-if (!memory_region_is_ram(section->mr)) {
-return;
-}
-
-if (log_dirty != add) {
-return;
-}
-
-trace_xen_client_set_memory(start_addr, size, log_dirty);
-
-start_addr &= page_mask;
-size = ROUND_UP(size, page_size);
-
-if (add) {
-if (!memory_region_is_rom(section->mr)) {
-xen_add_to_physmap(state, start_addr, size,
- section->mr, section->offset_within_region);
-} else {
-mem_type = HVMMEM_ram_ro;
-if (xen_set_mem_type(xen_domid, mem_type,
- start_addr >> target_page_bits,
- size >> target_page_bits)) {
-DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n",
-start_addr);
-}
-}
-} else {
-if (xen_remove_from_physmap(state, start_addr, size) < 0) {
-DPRINTF("physmapping does not exist at "HWADDR_FMT_plx"\n",
start_addr);
-}
-}
-}
-
void xen_arch_handle_ioreq(XenIOState *state, ioreq_t *req)
{
switch (req->type) {
diff --git a/hw/i386/xen/meson.build b/hw/i386/xen/meson.build
index 3f0df8bc07..d38759cfe4 100644
--- a/hw/i386/xen/meson.build
+++ b/hw/i386/xen/meson.build
@@ -1,6 +1,7 @@
i386_ss.add(when: 'CONFIG_XEN', if_true: files(
'xen_apic.c',
'xen_pvdevice.c',
+ 'xen-hvm-common.c',
))
i386_ss.add(when: ['CONFIG_XEN', xen], if_true: files(
'xen-hvm.c',
--
2.41.0
Reviewed-by: Manos Pitsidianakis
INIT(_physmap);
}
#endif
@@ -595,7 +598,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion
**ram_memory)
xen_register_ioreq(state, max_cpus, _memory_listener);
-QLIST_INIT(_physmap);
xen_read_physmap(state);
suspend.notify = xen_suspend_notifier;
--
2.41.0
Revie
)
{
XenPhysmap *physmap = NULL;
unsigned int len, num, i;
@@ -573,7 +573,7 @@ static void xen_read_physmap(XenIOState *state)
free(entries);
}
#else
-static void xen_read_physmap(XenIOState *state)
+void xen_read_physmap(XenIOState *state)
{
}
#endif
--
2.41.0
Reviewed-by: Manos
ryListener xen_memory_listener = {
+const MemoryListener xen_memory_listener = {
.name = "xen-memory",
.region_add = xen_region_add,
.region_del = xen_region_del,
--
2.41.0
Reviewed-by: Manos Pitsidianakis
type(xen_domid, mem_type,
- start_addr >> TARGET_PAGE_BITS,
- size >> TARGET_PAGE_BITS)) {
+ start_addr >> target_page_bits,
+ size >> target_page_bits)) {
DPRINTF("xen_set_mem_type error, addr: "HWADDR_FMT_plx"\n",
start_addr);
}
--
2.41.0
Reviewed-by: Manos Pitsidianakis
, length);
+start = xen_phys_offset_to_gaddr(start, length, TARGET_PAGE_MASK);
if (length == 0) {
length = TARGET_PAGE_SIZE;
--
2.41.0
Reviewed-by: Manos Pitsidianakis
size = TARGET_PAGE_ALIGN(size);
+size = ROUND_UP(size, TARGET_PAGE_SIZE);
if (add) {
if (!memory_region_is_rom(section->mr)) {
--
2.41.0
Reviewed-by: Manos Pitsidianakis
Hello Vikram,
Series doesn't apply on master. Can you rebase and also provide a
base-commit with --base= when you use git-format-patch? This
will help git rebase if there are any conflicts found locally.
Thanks,
On Wed, 28 Feb 2024 00:34, Vikram Garhwal wrote:
Hi,
This patch series add
On Tue, 20 Feb 2024 12:36, "Michael S. Tsirkin" wrote:
On Tue, Feb 20, 2024 at 10:52:08AM +0200, Manos Pitsidianakis wrote:
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
Acked-by: Michael S. Tsir
and removes all
resources owned by the vhost device parameter.
Also, add a test to verify that the new
function in the API behaves as expected.
Signed-off-by: Albert Esteve
Acked-by: Stefan Hajnoczi
---
Reviewed-by: Manos Pitsidianakis
hw/display/virtio-dmabuf.c| 21
Hello Albert,
This is a point of confusion for me; Volker recently pointed out in a
patch for virtio-snd that all its code runs under the BQL. Is this code
ever called without BQL, for example do the backend read/write functions
from vhost-user.c run without the BQL?
On Mon, 19 Feb 2024
On Mon, 19 Feb 2024 16:34, Albert Esteve wrote:
Change VirtioSharedObject value type from
a generic pointer to a union storing the different
supported underlying types, which makes naming
less confusing.
With the update, use the chance to add kdoc
to both the SharedObjectType enum and
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
pc-bios/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pc-bios/README b/pc-bios/README
index 4189bb28cc..b8a0210d24 100644
--- a/p
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/exec/plugin-gen.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/exec/plugin-gen.h b/include/exec/plugin-gen.h
index c455
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/hw/arm/omap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h
index 067e9419f7..2f59
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
scripts/ci/gitlab-pipeline-status | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/ci/gitlab-pipeline-status
b/scripts/ci/gitlab-pi
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/hw/net/npcm_gmac.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/net/npcm_gmac.h b/include/hw/net/npcm_gmac.h
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/hw/cxl/cxl_device.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
target/s390x/cpu_features_def.h.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/cpu_features_def.h.inc
b/target
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/hw/xen/interface/arch-x86/xen-x86_64.h | 2 +-
include/hw/xen/interface/arch-x86/xen.h| 2 +-
include/hw/xen/interface/event_channel.h
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
tests/avocado/acpi-bits/bits-tests/smbios.py2 | 2 +-
tests/avocado/mem-addr-space-check.py | 6 +++---
tests/avocado/reverse_debugging.py| 2
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
accel/tcg/ldst_atomicity.c.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/ldst_atomicity.c.inc b/accel/tcg/ldst_atomicity
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
target/sparc/asi.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/sparc/asi.h b/target/sparc/asi.h
index 3270ed0c7f..a668
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
hw/sh4/sh7750_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sh4/sh7750_regs.h b/hw/sh4/sh7750_regs.h
index edb5d18f00..946a
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
qapi/ui.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qapi/ui.json b/qapi/ui.json
index b6d7e142b7..1448eaca73 100644
--- a/qapi/u
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
docs/devel/ci-jobs.rst.inc | 2 +-
docs/devel/docs.rst | 2 +-
docs/devel/testing.rst | 2 +-
docs/interop/prl-xml.txt| 2 +-
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
target/m68k/cpu.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/target/m68k/cpu.h b/target/m68k/cpu.h
index aca4aa610b..57e3b6d3ce
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/hw/riscv/virt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/riscv/virt.h b/include/hw/riscv/virt.h
index f897
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/hw/ppc/ppc4xx.h | 2 +-
hw/ppc/ppc405.h | 2 +-
target/ppc/translate/vmx-impl.c.inc | 2 +-
3 files changed, 3 insertions
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
qemu-options.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 8547254dbf..9be1e5817c
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
include/exec/memory.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 177be23db7..8626
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
target/hexagon/idef-parser/macros.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hexagon/idef-parser/macros.inc
b/target/hexago
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Manos Pitsidianakis (21):
docs: correct typos
tests: correct typos
Xen headers: correct typos
accel/tcg: correct typos
loongson3: correct typos
ppc: correct typos
sh4: correct typos
i
Correct typos automatically found with the `typos` tool
<https://crates.io/crates/typos>
Signed-off-by: Manos Pitsidianakis
---
hw/mips/loongson3_bootp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/mips/loongson3_bootp.h b/hw/mips/loongson3_bootp.h
Hello Volker,
On Sun, 18 Feb 2024 at 10:34, Volker Rümelin wrote:
>
> So far, only rudimentary checks have been made to ensure that
> the guest only performs state transitions permitted in
> virtio-v1.2-csd01 5.14.6.6.1 PCM Command Lifecycle.
5.14.6.6.1 is non-normative in virtio v1.2. You can
Hello Volker, thanks for working on this,
On Sun, 18 Feb 2024 at 10:33, Volker Rümelin wrote:
>
> A malicious guest may trigger a segmentation fault in the tx/rx xfer
> handlers. On handler entry the stream variable is initialized with
> NULL. If the first element of the virtio queue has an
n░support
---8<--
Since it uses the meson.build AST to find those values, only hard-coded
binary names are selected and the description is non-exhaustive.
Signed-off-by: Manos Pitsidianakis
---
Makefile
+++ b/accel/Kconfig
@@ -16,3 +16,4 @@ config KVM
config XEN
bool
select FSDEV_9P if VIRTFS
+select XEN_BUS
--
2.43.0
Reviewed-by: Manos Pitsidianakis
+++ b/qapi/common.json
@@ -107,10 +107,14 @@
#
# @16: 16.0GT/s
#
+# @32: 32.0GT/s
+#
+# @64: 64.0GT/s
+#
# Since: 4.0
##
{ 'enum': 'PCIELinkSpeed',
- 'data': [ '2_5', '5', '8', '16' ] }
+ 'data': [ '2_5', '5', '8', '16', '32', '64' ] }
##
# @PCIELinkWidth:
--
2.43.1
Reviewed-by: Manos Pitsidianakis
bdir('arm')
subdir('avr')
subdir('cris')
--
2.41.0
LGTM in general overall. In case this wasn't discussed already, would it
be a good idea to name the target x-any if it ends up in a stable
release?
Regardless of my inlined style comments:
Reviewed-by: Manos Pitsidianakis
Arguments `ram_block` are reassigned to local declarations `block`
without further use. Remove re-assignment to reduce noise.
Signed-off-by: Manos Pitsidianakis
---
system/physmem.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/system/physmem.c b/system/physmem.c
been sent in a separate patch, here it is just for
> completness)
> qemu-img: refresh options/--help for "check" command
> qemu-img: simplify --repair error message
> qemu-img: refresh options/--help for "commit" command
> qemu-img: refresh options/--help for
s->host_features);
virtio_init(vdev, VIRTIO_ID_BLOCK, s->config_size);
--
2.43.0
virtio_block_ops and methods are moved around without changes in the
diff, is that on purpose? If no the patch and history would be less
noisy.
Regardless:
Reviewed-by: Manos Pitsidianakis
();
+aio_co_reschedule_self(iohandler_get_aio_context());
}
} else {
/*
--
2.43.0
Reviewed-by: Manos Pitsidianakis
ring ->realize() */
r = blk_set_aio_context(s->conf.conf.blk, s->vq_aio_context[0],
_err);
if (r < 0) {
--
2.43.0
Reviewed-by: Manos Pitsidianakis
static void virtio_blk_dma_restart_cb(void *opaque, bool
running,
VirtIOBlockReq *next = rq->next;
uint16_t idx = virtio_get_queue_index(rq->vq);
+assert(idx < num_queues);
rq->next = vq_rq[idx];
vq_rq[idx] = rq;
rq = next;
--
2.43
struct VirtIOBlockReq *rq; /* protected by rq_lock */
VirtIOBlkConf conf;
unsigned short sector_mask;
bool original_wce;
--
2.43.0
Reviewed-by: Manos Pitsidianakis
Good morning Alex,
Just one observation,
On Sun, 04 Feb 2024 13:06, Alex Bennée wrote:
Hi,
I'm trying to get an understanding of the blob allocation and mapping
flow for virtio-gpu for Vulkan and Rutabaga. Having gotten all the
various libraries setup I'm still seeing failures when running a
ted with that resource_id is then leaked.
This commit overrides the resource_destroy class method introduced in
the previous commit to fix this.
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu-rutabaga.c | 47
1 file changed, 35 insertions(+), 12 deleti
-by: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
include/hw/virtio/virtio-gpu.h | 3 +++
hw/display/virtio-gpu.c| 25 ++---
2 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h
index
for implementations in the future.
Reviewed-by: Marc-André Lureau
Signed-off-by: Manos Pitsidianakis
---
hw/display/virtio-gpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
index f8a675eb30..2b73ae585b 100644
--- a/hw
rences:
- addressed review comments re: using the Error API for the
resource_destroy method.
Manos Pitsidianakis (3):
hw/display/virtio-gpu.c: use reset_bh class method
virtio-gpu.c: add resource_destroy class method
virtio-gpu-rutabaga.c: override resource_destroy method
include/hw/virtio/virtio
On Tue, 30 Jan 2024 at 15:10, Marc-André Lureau
wrote:
>
> Hi
>
> On Tue, Jan 30, 2024 at 5:01 PM Manos Pitsidianakis
> wrote:
> >
> > On Tue, 30 Jan 2024 at 14:50, Marc-André Lureau
> > wrote:
> > >
> > > Hi
> > >
> >
On Tue, 30 Jan 2024 at 14:50, Marc-André Lureau
wrote:
>
> Hi
>
> On Mon, Jan 29, 2024 at 7:46 PM Manos Pitsidianakis
> wrote:
> >
> > When the Rutabaga GPU device frees resources, it calls
> > rutabaga_resource_unref for that resource_id. However, when th
On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote:
>
> On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis
> wrote:
> >
> > On Tue, 30 Jan 2024 at 12:42, Peter Maydell
> > wrote:
> > >
> > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis
> >
On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote:
>
> On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis
> wrote:
> >
> > On Tue, 30 Jan 2024 at 12:34, Peter Maydell
> > wrote:
> > >
> > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis
> >
On Tue, 30 Jan 2024 at 12:34, Peter Maydell wrote:
>
> On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis
> wrote:
> >
> > Check if a file argument is a cover letter patch produced by
> > git-format-patch --cover-letter; It is initialized with subject suffix "
&g
On Tue, 30 Jan 2024 12:15, "Daniel P. Berrangé" wrote:
On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote:
Check if a file argument is a cover letter patch produced by
git-format-patch --cover-letter; It is initialized with subject suffix "
*** SUBJECT HER
On Tue, 30 Jan 2024 11:59, "Daniel P. Berrangé" wrote:
On Tue, Jan 30, 2024 at 11:54:51AM +0200, Manos Pitsidianakis wrote:
On Tue, 30 Jan 2024 11:47, "Daniel P. Berrangé" wrote:
> On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote:
> > On Tue, 3
Check if a file argument is a cover letter patch produced by
git-format-patch --cover-letter; It is initialized with subject suffix "
*** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they
exist, warn the user.
Signed-off-by: Manos Pitsidianakis
---
Rang
On Tue, 30 Jan 2024 11:47, "Daniel P. Berrangé" wrote:
On Tue, Jan 30, 2024 at 10:51:58AM +0200, Manos Pitsidianakis wrote:
On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote:
>
> On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote:
> > Check if a fi
uot;
@@ -21,6 +22,9 @@
#include "qemu/rcu_queue.h"
#include "hw/hyperv/hyperv.h"
#include "qom/object.h"
+#include "target/i386/kvm/hyperv-proto.h"
+#include "target/i386/cpu.h"
+#include "exec/cpu-all.h"
struct SynICState {
DeviceState parent_obj;
--
2.41.0
Reviewed-by: Manos Pitsidianakis
On Tue, 30 Jan 2024 at 10:12, Daniel P. Berrangé wrote:
>
> On Tue, Jan 30, 2024 at 09:56:15AM +0200, Manos Pitsidianakis wrote:
> > Check if a file argument is a cover letter patch produced by
> > git-format-patch --cover-letter; It is initialized with subject suffix &quo
Check if a file argument is a cover letter patch produced by
git-format-patch --cover-letter; It is initialized with subject suffix "
*** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they
exist, warn the user.
Signed-off-by: Manos Pitsidianakis
---
script
ppropriate.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
include/hw/block/block.h | 4 ++--
hw/block/block.c | 25 +++--
hw/block/m25p80.c| 3 ++-
hw/block/pflash_cfi01.c | 4 ++--
hw/block/pflash_cfi02.c | 2 +-
5 files c
Add a simple method to return some kind of human readable identifier for
use in error messages.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Manos Pitsidianakis
---
include/hw/qdev-core.h | 14 ++
hw/core/qdev.c | 8
2 files changed, 22 insertions(+)
diff --git
et_human_name
(thanks Phil Mathieu-Daudé )
Manos Pitsidianakis (2):
hw/core/qdev.c: add qdev_get_human_name()
hw/block/block.c: improve confusing blk_check_size_and_read_all()
error
include/hw/block/block.h | 4 ++--
include/hw/qdev-core.h | 14 ++
On Tue, 30 Jan 2024 03:26, Gurchetan Singh wrote:
On Mon, Jan 29, 2024 at 7:46 AM Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> wrote:
When the Rutabaga GPU device frees resources, it calls
rutabaga_resource_unref for that resource_id. However, when the generic
VirtIOGPU fun
-by: Manos Pitsidianakis
---
hw/xen/trace-events | 11 +
hw/xen/xen-mapcache.c | 54 +++
2 files changed, 35 insertions(+), 30 deletions(-)
diff --git a/hw/xen/trace-events b/hw/xen/trace-events
index 67a6c41926..a65dc0e55f 100644
--- a/hw/xen
ormat.
> Use error_printf() & friends to print additional information.
This commit changes fprintfs that report warnings and errors to the
appropriate report functions.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Manos Pitsidianakis
---
hw/xen/xen-hvm-common.c | 12 ++--
hw/xen/xe
1 - 100 of 551 matches
Mail list logo
