Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Marc Marí
On Wed, 22 Jul 2015 00:24:34 -0400 Kevin O'Connor ke...@koconnor.net wrote: On Tue, Jul 21, 2015 at 06:03:41PM +0200, Marc Marí wrote: From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e

Re: [Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 21:44:49 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/21/15 18:03, Marc Marí wrote: From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e. there is no select register

Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 21:53:06 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/21/15 18:18, Stefan Hajnoczi wrote: On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí mar...@redhat.com wrote: From: Gerd Hoffmann kra...@redhat.com This is what it takes to have a sorted fw_cfg file directory

Re: [Qemu-devel] [RFC 7/7] fw_cfg DMA for x86

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 18:14:40 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 21 July 2015 at 17:03, Marc Marí mar...@redhat.com wrote: Enable fw_cfg for x86 machines. Create new machine to avoid incompatibilites. @@ -1391,7 +1399,14 @@ FWCfgState *pc_memory_init(MachineState

Re: [Qemu-devel] [RFC 4/7] enable fw_cfg dma for arm virt

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 18:04:31 +0100 Peter Maydell peter.mayd...@linaro.org wrote: On 21 July 2015 at 17:03, Marc Marí mar...@redhat.com wrote: From: Gerd Hoffmann kra...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/fw_cfg.txt | 6 ++ hw/arm/virt.c

Re: [Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-22 Thread Marc Marí
On Tue, 21 Jul 2015 22:36:39 +0200 Laszlo Ersek ler...@redhat.com wrote: On 07/21/15 22:16, Kevin O'Connor wrote: On Tue, Jul 21, 2015 at 10:06:51PM +0200, Laszlo Ersek wrote: On 07/21/15 18:26, Stefan Hajnoczi wrote: On Tue, Jul 21, 2015 at 5:03 PM, Marc Marí mar...@redhat.com wrote

[Qemu-devel] [RFC 5/7] fw_cfg file sort

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann kra...@redhat.com This is what it takes to have a sorted fw_cfg file directory. Entries are inserted at the correct place instead of being appended to the end in case sorting is enabled. Compatibility fluff (enable sorting for new machine types only) isn't there yet.

[Qemu-devel] [RFC 7/7] fw_cfg DMA for x86

2015-07-21 Thread Marc Marí
Enable fw_cfg for x86 machines. Create new machine to avoid incompatibilites. Signed-off-by: Marc Marí mar...@redhat.com --- hw/i386/pc.c | 21 ++--- hw/i386/pc_piix.c| 25 +++-- hw/i386/pc_q35.c | 26 -- include/hw/i386

[Qemu-devel] [RFC 3/7] fw_cfg dma: adapt to vmstate changes

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann kra...@redhat.com --- hw/nvram/fw_cfg.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 5bcd0e0..0f35931 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -515,8 +515,16 @@

[Qemu-devel] [RFC 2/7] fw_cfg dma interface

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann kra...@redhat.com First draft of a fw_cfg dma interface. Designed as add-on to the extisting fw_cfg interface, i.e. there is no select register. There are four 32bit registers: Target address (low and high bits), transfer length, control register. See docs/specs/fw_cfg.txt

[Qemu-devel] [RFC 4/7] enable fw_cfg dma for arm virt

2015-07-21 Thread Marc Marí
From: Gerd Hoffmann kra...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/fw_cfg.txt | 6 ++ hw/arm/virt.c | 11 --- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt index 64d9192..eac83a1

[Qemu-devel] [RFC 0/7] fw_cfg dma interface

2015-07-21 Thread Marc Marí
functions Gerd Hoffmann (4): fw_cfg dma interface fw_cfg dma: adapt to vmstate changes enable fw_cfg dma for arm virt fw_cfg file sort Marc Marí (2): Add offset register to fw_cfg DMA interface fw_cfg DMA for x86 docs/specs/fw_cfg.txt | 52 hw/arm/virt.c

[Qemu-devel] [RFC 1/7] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-07-21 Thread Marc Marí
From: Gabriel L. Somlo so...@cmu.edu Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo so...@cmu.edu Signed-off-by:

[Qemu-devel] [RFC 6/7] Add offset register to fw_cfg DMA interface

2015-07-21 Thread Marc Marí
Signed-off-by: Marc Marí mar...@redhat.com --- hw/nvram/fw_cfg.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 83205e0..9a39d45 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -47,8 +47,9 @@ #define

Re: [Qemu-devel] [PATCH] libqos: Solve bug in interrupt checking when using MSIX in virtio-pci.c

2015-03-10 Thread Marc Marí
El Tue, 10 Mar 2015 16:50:48 -0400 John Snow js...@redhat.com escribió: On 02/24/2015 01:09 PM, John Snow wrote: On 02/24/2015 11:34 AM, Marc Marí wrote: The MSIX interrupt was always acked without checking its value, which caused a race condition. If the ISR was raised between

[Qemu-devel] [PATCH v5 3/5] libqos: Remove PCI assumptions in constants of virtio driver

2015-02-24 Thread Marc Marí
Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 11 ++- 3 files

[Qemu-devel] [PATCH v5 0/5] libqos: Virtio MMIO driver

2015-02-24 Thread Marc Marí
to a race condition Changes for version 5: - Change function generic_alloc_init_flags in tests/libqos/malloc-generic.c to compile with changes from commit f6f363c1f4f962aee9f69c67ab2f3ff58c30f8c1. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Marc Marí (5): libqos: Change use

[Qemu-devel] [PATCH v5 4/5] libqos: Add malloc generic

2015-02-24 Thread Marc Marí
This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/malloc-generic.c | 39

[Qemu-devel] [PATCH v5 1/5] libqos: Change use of pointers to uint64_t in virtio

2015-02-24 Thread Marc Marí
Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 20

Re: [Qemu-devel] [PATCH v4 0/5] libqos: Virtio MMIO driver

2015-02-24 Thread Marc Marí
El Thu, 19 Feb 2015 18:46:44 +0100 Kevin Wolf kw...@redhat.com escribió: Am 18.02.2015 um 18:07 hat Stefan Hajnoczi geschrieben: On Fri, Jan 23, 2015 at 05:38:48PM +0100, Marc Marí wrote: Add virtio-mmio support to libqos and test case for virtio-blk. Changes for version 3: - Fix

[Qemu-devel] [PATCH v5 5/5] libqos: Add virtio MMIO support

2015-02-24 Thread Marc Marí
Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 198 tests/libqos/virtio-mmio.h | 46 ++ tests/virtio

[Qemu-devel] [PATCH v5 2/5] tests: Prepare virtio-blk-test for multi-arch implementation

2015-02-24 Thread Marc Marí
Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 154 +++ 1 file changed, 89 insertions(+), 65 deletions(-) diff --git a/tests

[Qemu-devel] [PATCH] libqos: Solve bug in interrupt checking when using MSIX in virtio-pci.c

2015-02-24 Thread Marc Marí
The MSIX interrupt was always acked without checking its value, which caused a race condition. If the ISR was raised between the read and the acking, the ISR was never detected and it timed out. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 16

[Qemu-devel] [PATCH] tests: Check QVIRTIO_F_ANY_LAYOUT flag in virtio-blk test

2015-02-24 Thread Marc Marí
Check the QVIRTIO_F_ANY_LAYOUT flag before performing operations with 2 descriptor layout. This is to follow the specification strictly. This patch depends on: [PATCH v5 0/5] libqos: Virtio MMIO driver Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 98

Re: [Qemu-devel] virtio-blk-test failure

2015-02-23 Thread Marc Marí
El Mon, 23 Feb 2015 17:22:57 -0500 John Snow js...@redhat.com escribió: I've been seeing this failure pop up very occasionally and I can usually get the test to pass again by just re-running, but every now and again: GTESTER check-qtest-x86_64 blkdebug: Suspended request 'A' blkdebug:

Re: [Qemu-devel] QEMU and Real Time OS

2015-01-30 Thread Marc Marí
El Fri, 30 Jan 2015 08:37:47 +0100 Jan Kiszka jan.kis...@siemens.com escribió: On 2015-01-30 00:06, Paolo Bonzini wrote: On 29/01/2015 20:37, Marc Marí wrote: Is this an expected behaviour? I can't see why. I'd like to know if there is a certain reason why it doesn't work

Re: [Qemu-devel] QEMU and Real Time OS

2015-01-30 Thread Marc Marí
El Fri, 30 Jan 2015 11:36:37 +0100 Frederic Konrad fred.kon...@greensocs.com escribió: On 30/01/2015 11:26, Marc Marí wrote: El Fri, 30 Jan 2015 08:37:47 +0100 Jan Kiszka jan.kis...@siemens.com escribió: On 2015-01-30 00:06, Paolo Bonzini wrote: On 29/01/2015 20:37, Marc Marí wrote

[Qemu-devel] QEMU and Real Time OS

2015-01-29 Thread Marc Marí
Hi I tried to run a Linux Kernel with Preempt RT patch on a QEMU emulated machine using TCG (ARM guest, x86_64 guest). I expected the guest to have high latencies, but more or less constant. But I found, using cyclictest, a lot of randomness and a lot of difference between the average and the

Re: [Qemu-devel] [PATCH v2 06/15] libqos: Update QGuestAllocator to be opaque

2015-01-27 Thread Marc Marí
, size_t page_size); + #endif Reviewed-by: Marc Marí marc.mari.barc...@gmail.com

[Qemu-devel] VersatilePB bug (or undefined behaviour)

2015-01-27 Thread Marc Marí
Hi I was investigating a bit with a versatilepb machine, and I was trying to boot a Linux system with a root file system through NFS. It worked with Linux 3.2, but it didn't work with any later Linux version. This was the error: [0.594471] smc91x: not found (-16). [0.59] smc91x:

[Qemu-devel] [PATCH v4 1/5] libqos: Change use of pointers to uint64_t in virtio

2015-01-23 Thread Marc Marí
Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 20

[Qemu-devel] [PATCH v4 4/5] libqos: Add malloc generic

2015-01-23 Thread Marc Marí
This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/malloc-generic.c | 50

[Qemu-devel] [PATCH v4 5/5] libqos: Add virtio MMIO support

2015-01-23 Thread Marc Marí
Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 198 tests/libqos/virtio-mmio.h | 46 ++ tests/virtio

[Qemu-devel] [PATCH v4 0/5] libqos: Virtio MMIO driver

2015-01-23 Thread Marc Marí
to a race condition Marc Marí (5): libqos: Change use of pointers to uint64_t in virtio tests: Prepare virtio-blk-test for multi-arch implementation libqos: Remove PCI assumptions in constants of virtio driver libqos: Add malloc generic libqos: Add virtio MMIO support tests/Makefile

[Qemu-devel] [PATCH v4 3/5] libqos: Remove PCI assumptions in constants of virtio driver

2015-01-23 Thread Marc Marí
Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 11 ++- 3 files

[Qemu-devel] [PATCH v4 2/5] tests: Prepare virtio-blk-test for multi-arch implementation

2015-01-23 Thread Marc Marí
Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 154 +++ 1 file changed, 89 insertions(+), 65 deletions(-) diff --git a/tests

[Qemu-devel] acpi tcg test errors when compiled with clang

2015-01-22 Thread Marc Marí
While I was searching for other errors in make check, I set up a few machines on top of virtualbox to compile and check qemu master, and make check failed in a few of them when compiling with clang ( 3.5) (gcc works perfectly). I found two errors in acpi/tcg test in tests/bios-tables-test.c ---

Re: [Qemu-devel] [PATCH 01/14] libqos: Split apart pc_alloc_init

2015-01-13 Thread Marc Marí
El Mon, 12 Jan 2015 22:34:26 -0500 John Snow js...@redhat.com escribió: Move the list-specific initialization over into malloc.c, to keep all of the list implementation details within the same file. The allocation and freeing of these structures are now both back within the same layer.

[Qemu-devel] Linux 3.4, VersatilePB and PCI

2015-01-13 Thread Marc Marí
Hi In short: I have a Linux 3.4 kernel on top of a VersatilePB machine that fails to mount root file system with message: sym53c8xx :00:0c.0: BAR 0: can't reserve [io 0x4400-0x44ff] after booting with: qemu-system-arm -M versatilepb -serial telnet::,server -kernel vmlinuz-3.4.0

Re: [Qemu-devel] Linux 3.4, VersatilePB and PCI

2015-01-13 Thread Marc Marí
El Tue, 13 Jan 2015 10:06:00 + Peter Maydell peter.mayd...@linaro.org escribió: On 13 January 2015 at 09:05, Marc Marí marc.mari.barc...@gmail.com wrote: Hi In short: I have a Linux 3.4 kernel on top of a VersatilePB machine that fails to mount root file system with message

Re: [Qemu-devel] Linux 3.4, VersatilePB and PCI

2015-01-13 Thread Marc Marí
El Tue, 13 Jan 2015 10:46:20 + Peter Maydell peter.mayd...@linaro.org escribió: On 13 January 2015 at 10:35, Marc Marí marc.mari.barc...@gmail.com wrote: I was fearing that answer :). No, I can't. I want to compare the behaviour of a normal Linux 3.4 with another modified Linux 3.4

Re: [Qemu-devel] [PATCH v3 0/5] libqos: Virtio MMIO driver

2015-01-05 Thread Marc Marí
El Wed, 3 Dec 2014 10:31:32 +0100 Marc Marí marc.mari.barc...@gmail.com escribió: Add virtio-mmio support to libqos and test case for virtio-blk. This series depends on patch libqos: Convert malloc-pc allocator to a generic allocator Changes from version 2: - Fix leaks and minor bugs

[Qemu-devel] [PATCH v3 1/5] libqos: Change use of pointers to uint64_t in virtio

2014-12-03 Thread Marc Marí
Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 20

[Qemu-devel] [PATCH v3 0/5] libqos: Virtio MMIO driver

2014-12-03 Thread Marc Marí
Add virtio-mmio support to libqos and test case for virtio-blk. This series depends on patch libqos: Convert malloc-pc allocator to a generic allocator Changes from version 2: - Fix leaks and minor bugs - Extract basic test case to a function Marc Marí (5): libqos: Change use of pointers

[Qemu-devel] [PATCH v3 3/5] libqos: Remove PCI assumptions in constants of virtio driver

2014-12-03 Thread Marc Marí
Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 11 ++- 3 files

[Qemu-devel] [PATCH v3 4/5] libqos: Add malloc generic

2014-12-03 Thread Marc Marí
This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/malloc-generic.c | 50

[Qemu-devel] [PATCH v3 2/5] tests: Prepare virtio-blk-test for multi-arch implementation

2014-12-03 Thread Marc Marí
Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 146 +++ 1 file changed, 85 insertions(+), 61 deletions(-) diff --git a/tests

[Qemu-devel] [PATCH v3 5/5] libqos: Add virtio MMIO support

2014-12-03 Thread Marc Marí
Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 190 tests/libqos/virtio-mmio.h | 46 +++ tests/virtio

Re: [Qemu-devel] [PATCH RFC for-2.2] virtio-blk: force 1st s/g to match header

2014-11-28 Thread Marc Marí
El Fri, 28 Nov 2014 11:43:59 + Stefan Hajnoczi stefa...@gmail.com escribió: On Fri, Nov 28, 2014 at 7:05 AM, Jason Wang jasow...@redhat.com wrote: On Fri, Nov 28, 2014 at 9:16 AM, Fam Zheng f...@redhat.com wrote: On Thu, 11/27 23:13, Michael S. Tsirkin wrote: On Thu, Nov 27,

Re: [Qemu-devel] [PATCH v2 5/5] libqos: Add virtio MMIO support

2014-11-24 Thread Marc Marí
El Mon, 24 Nov 2014 11:59:19 + Stefan Hajnoczi stefa...@redhat.com escribió: On Sun, Nov 23, 2014 at 12:41:25PM +0100, Marc Marí wrote: El Mon, 17 Nov 2014 15:48:09 + Stefan Hajnoczi stefa...@gmail.com escribió: On Sat, Nov 01, 2014 at 06:02:30PM +0100, Marc Marí wrote

Re: [Qemu-devel] [PATCH v2 5/5] libqos: Add virtio MMIO support

2014-11-23 Thread Marc Marí
El Mon, 17 Nov 2014 15:48:09 + Stefan Hajnoczi stefa...@gmail.com escribió: On Sat, Nov 01, 2014 at 06:02:30PM +0100, Marc Marí wrote: +static void mmio_basic(void) +{ +QVirtioMMIODevice *dev; +QVirtQueue *vq; +QGuestAllocator *alloc; +QVirtioBlkReq req

Re: [Qemu-devel] [PATCH v2 0/5] libqos: Virtio MMIO driver

2014-11-17 Thread Marc Marí
El Sat, 1 Nov 2014 18:02:25 +0100 Marc Marí marc.mari.barc...@gmail.com escribió: Add virtio-mmio support to libqos and test case for virtio-blk. Ping! It has been two weeks. Is it in somebody's todo list? Thanks Marc

Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64_t in virtio

2014-11-17 Thread Marc Marí
El Mon, 17 Nov 2014 15:16:21 + Stefan Hajnoczi stefa...@gmail.com escribió: On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Marí wrote: Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions

[Qemu-devel] [PATCH v2 5/5] libqos: Add virtio MMIO support

2014-11-01 Thread Marc Marí
Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 190 tests/libqos/virtio-mmio.h | 46 +++ tests/virtio

[Qemu-devel] [PATCH v2 3/5] libqos: Remove PCI assumptions in constants of virtio driver

2014-11-01 Thread Marc Marí
Convert PCI-specific constants names of libqos virtio driver. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 30 +++--- tests/libqos/virtio-pci.h | 24 tests/virtio-blk-test.c | 10 +- 3 files

[Qemu-devel] [PATCH v2 2/5] tests: Prepare virtio-blk-test for multi-arch implementation

2014-11-01 Thread Marc Marí
Modularize functions in virtio-blk-test and add PCI suffix for PCI specific components. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 57 +++ 1 file changed, 38 insertions(+), 19 deletions(-) diff --git a/tests

[Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64_t in virtio

2014-11-01 Thread Marc Marí
Convert use of pointers in functions of virtio to uint64_t in order to make it platform-independent. Add casting from pointers (in PCI functions) to uint64_t and vice versa through uintptr_t. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 20

[Qemu-devel] [PATCH v2 4/5] libqos: Add malloc generic

2014-11-01 Thread Marc Marí
This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/malloc-generic.c | 50

Re: [Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-24 Thread Marc Marí
El Thu, 23 Oct 2014 18:49:03 -0400 John Snow js...@redhat.com escribió: Reviewed-by: John Snow js...@redhat.com Did you mean this for the v2, which has the extra free? Marc

Re: [Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-22 Thread Marc Marí
+void alloc_uninit(QGuestAllocator *allocator) +{ +MemBlock *node; +MemBlock *tmp; +QAllocOpts mask; + +/* Check for guest leaks, and destroy the list. */ +QTAILQ_FOREACH_SAFE(node, allocator-used, MLIST_ENTNAME, tmp) { +if (allocator-opts

[Qemu-devel] [PATCH] libqos: Convert malloc-pc allocator to a generic allocator

2014-10-18 Thread Marc Marí
the allocator parameters. As a result, only the allocator initalizer and unitializer are arch dependent. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile |2 +- tests/libqos/malloc-pc.c | 280 +- tests/libqos/malloc-pc.h

Re: [Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver

2014-10-03 Thread Marc Marí
El Thu, 2 Oct 2014 13:02:25 +0100 Stefan Hajnoczi stefa...@redhat.com escribió: On Thu, Sep 04, 2014 at 06:24:37PM +0200, Marc Marí wrote: @@ -60,25 +60,25 @@ static void qvirtio_pci_assign_device(QVirtioDevice *d, void *data) *vpcidev = (QVirtioPCIDevice *)d; } -static uint8_t

Re: [Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-15 Thread Marc Marí
El Mon, 15 Sep 2014 14:47:41 -0700 Peter Maydell peter.mayd...@linaro.org escribió: On 11 September 2014 02:40, Marc Marí marc.mari.barc...@gmail.com wrote: Increase the clock step to avoid Travis failure in some builds due to overagressive timeout. Signed-off-by: Marc Marí

[Qemu-devel] [TRIVIAL][PATCH v2] libqos virtio: Increase ISR timeout

2014-09-11 Thread Marc Marí
Increase the clock step to avoid Travis failure in some builds due to overagressive timeout. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c

[Qemu-devel] [TRIVIAL][PATCH] libqos virtio: Increase ISR timeout

2014-09-09 Thread Marc Marí
Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c index 128dbd0..9b6de2c 100644 --- a/tests/libqos/virtio.c +++ b/tests/libqos/virtio.c @@ -82,7

[Qemu-devel] [PATCH 1/3] libqos: Remove PCI assumptions in virtio driver

2014-09-04 Thread Marc Marí
Change name of constants. Modularize virtio-blk-test. Change prototypes. Solve small bugs. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 50 + tests/libqos/virtio-pci.h | 24 tests/libqos/virtio.c

[Qemu-devel] [PATCH 2/3] libqos: Add malloc generic

2014-09-04 Thread Marc Marí
This malloc is a basic interface implementation that works for any platform. It should be replaced in the future for a real malloc implementation for each of the platforms. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/malloc-generic.c | 54

[Qemu-devel] [PATCH 3/3] libqos: Add virtio MMIO support

2014-09-04 Thread Marc Marí
Add virtio MMIO support. Add virtio-blk-test MMIO test case. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile |4 +- tests/libqos/virtio-mmio.c | 191 tests/libqos/virtio-mmio.h | 46 +++ tests/virtio

[Qemu-devel] [PATCH 0/3] Virtio MMIO libqos driver

2014-09-04 Thread Marc Marí
Add virtio-mmio support to libqos. Based on virtio-pci libqos patches. Marc Marí (3): libqos: Remove PCI assumptions in virtio driver libqos: Add malloc generic libqos: Add virtio MMIO support tests/Makefile|4 +- tests/libqos/malloc-generic.c | 54 +++ tests

[Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-01 Thread Marc Marí
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754

[Qemu-devel] [PATCH v8 0/7] Virtio PCI libqos driver

2014-09-01 Thread Marc Marí
: Solve bugs (qvirtio_pci_config_readq endianness) v8: Solve bugs (qvirtio_pci_config_readq endianness) Marc Marí (7): tests: Functions bus_foreach and device_find from libqos virtio API tests: Add virtio device initialization libqos: Added basic virtqueue support to virtio implementation

[Qemu-devel] [PATCH v8 2/7] tests: Add virtio device initialization

2014-09-01 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 71 + tests/libqos/virtio

[Qemu-devel] [PATCH v8 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-09-01 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64

[Qemu-devel] [PATCH v8 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-09-01 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com

[Qemu-devel] [PATCH v8 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-09-01 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 82

[Qemu-devel] [PATCH v8 6/7] libqos: Added MSI-X support

2014-09-01 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/pci.c| 111 +++- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c

[Qemu-devel] [PATCH v8 7/7] libqos: Added EVENT_IDX support

2014-09-01 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 +- tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 124

Re: [Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-01 Thread Marc Marí
El Mon, 1 Sep 2014 18:09:09 +0200 Greg Kurz gk...@linux.vnet.ibm.com escribió: On Mon, 1 Sep 2014 12:07:58 +0200 Marc Marí marc.mari.barc...@gmail.com wrote: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- Hi Marc, I gave

Re: [Qemu-devel] [PATCH v8 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-09-01 Thread Marc Marí
El Mon, 1 Sep 2014 18:27:34 +0200 Marc Marí marc.mari.barc...@gmail.com escribió: El Mon, 1 Sep 2014 18:09:09 +0200 Greg Kurz gk...@linux.vnet.ibm.com escribió: On Mon, 1 Sep 2014 12:07:58 +0200 Marc Marí marc.mari.barc...@gmail.com wrote: Reviewed-by: Stefan Hajnoczi stefa...@redhat.com

[Qemu-devel] [PATCH v7 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-08-29 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64

[Qemu-devel] [PATCH v7 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-08-29 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 82

[Qemu-devel] [PATCH v7 0/7] Virtio PCI libqos driver

2014-08-29 Thread Marc Marí
: Solve bugs (qvirtio_pci_config_readq endianness) Marc Marí (7): tests: Functions bus_foreach and device_find from libqos virtio API tests: Add virtio device initialization libqos: Added basic virtqueue support to virtio implementation libqos: Added indirect descriptor support to virtio

[Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 73 + tests/libqos/virtio

[Qemu-devel] [PATCH v7 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-08-29 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com

[Qemu-devel] [PATCH v7 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-08-29 Thread Marc Marí
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754

[Qemu-devel] [PATCH v7 6/7] libqos: Added MSI-X support

2014-08-29 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/pci.c| 111 +++- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c

[Qemu-devel] [PATCH v7 7/7] libqos: Added EVENT_IDX support

2014-08-29 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 +- tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 124

Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Marc Marí
El Fri, 29 Aug 2014 16:49:36 +0100 Stefan Hajnoczi stefa...@gmail.com escribió: On Fri, Aug 29, 2014 at 12:40:43PM +0200, Marc Marí wrote: +static uint64_t qvirtio_pci_config_readq(QVirtioDevice *d, void *addr) +{ +QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d; +int i

Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Marc Marí
El Fri, 29 Aug 2014 17:59:37 +0200 Paolo Bonzini pbonz...@redhat.com escribió: Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto: for (i = 0; i 8; ++i) { quad.bytes[i] = qpci_io_readb(dev-pdev, addr + i); } if (qtest_big_endian() != qtest_host_endian()) { quad.u64 =

[Qemu-devel] [PATCH v6 0/7] Virtio PCI libqos driver

2014-08-25 Thread Marc Marí
v3: Solved problems, added indirect descriptor support and test for configuration changes v4: Solved bugs, changed some interfaces, added MSI-X and event_idx support. v5: Simplified virtio-blk-test, solved bugs, avoid patches already merged. v6: Solve bugs (qpci_iomap changed prototype) Marc

[Qemu-devel] [PATCH v6 2/7] tests: Add virtio device initialization

2014-08-25 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 67 + tests/libqos/virtio

[Qemu-devel] [PATCH v6 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-08-25 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Marc Marí marc.mari.barc...@gmail.com

[Qemu-devel] [PATCH v6 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-08-25 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 82 + tests/libqos/virtio-pci.h |2 + tests/libqos

[Qemu-devel] [PATCH v6 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-08-25 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64 + tests/libqos/virtio.h | 22

[Qemu-devel] [PATCH v6 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-08-25 Thread Marc Marí
Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754 100644 --- a/tests/virtio-blk-test.c +++ b/tests

[Qemu-devel] [PATCH v6 7/7] libqos: Added EVENT_IDX support

2014-08-25 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 +- tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 124

[Qemu-devel] [PATCH v6 6/7] libqos: Added MSI-X support

2014-08-25 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/pci.c| 111 +++- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c

Re: [Qemu-devel] [RFC] qapi: New command query-mtree

2014-08-20 Thread Marc Marí
El Wed, 20 Aug 2014 13:09:20 -0600 Eric Blake ebl...@redhat.com escribió: On 08/20/2014 11:46 AM, Marc Marí wrote: Add command query-mtree to get the memory tree of the guest. As we were looking for a flexible solution on accessing the guest memory from qtests, Stefan came with the idea

[Qemu-devel] [PATCH v5 0/7] Virtio PCI libqos driver

2014-08-18 Thread Marc Marí
v3: Solved problems, added indirect descriptor support and test for configuration changes v4: Solved bugs, changed some interfaces, added MSI-X and event_idx support. v5: Simplified virtio-blk-test, solved bugs, avoid patches already merged. Marc Marí (5): libqos: Added basic virtqueue

[Qemu-devel] [PATCH v5 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-08-18 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Signed-off-by: Marc Marí marc.mari.barc...@gmail.com --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64 + tests/libqos/virtio.h | 22

<    1   2   3   4   >