On Wed, Apr 27, 2022 at 01:32:23PM +0200, Paolo Bonzini wrote:
Use qdev_new instead of distinguishing isa_create_simple/pci_create_simple.
Signed-off-by: Paolo Bonzini
By trying to rebase my series on top of this series I noticed this patch
breaks almost everything.
---
hw/audio/soundhw.c
On Wed, Apr 27, 2022 at 01:32:25PM +0200, Paolo Bonzini wrote:
-audio is used like "-audio pa,model=sb16". It is almost as simple as
-soundhw, but it reuses the -audiodev parsing machinery and attaches an
audiodev to the newly-created device. The main 'feature' is that
it knows about adding
On Mon, Apr 25, 2022 at 06:05:56PM +0100, Mark Cave-Ayland wrote:
On 25/04/2022 09:21, Martin Kletzander wrote:
I wanted to deal with https://bugzilla.redhat.com/2043498 and I got a
suggesstion that removing deprecated features could actually make it
easier to propagate the error. In the end
On Mon, Apr 25, 2022 at 03:06:14PM +0100, Daniel P. Berrangé wrote:
On Mon, Apr 25, 2022 at 10:21:50AM +0200, Martin Kletzander wrote:
Many machine types have default audio devices with no way to set the underlying
audiodev. Instead of adding an option for each and every one of them this new
On Mon, Apr 25, 2022 at 02:42:53PM +0100, Daniel P. Berrangé wrote:
On Mon, Apr 25, 2022 at 10:21:48AM +0200, Martin Kletzander wrote:
This will enable removing deprecated default audiodev support.
I did not figure out how to make the audiodev represented as an
interface node, so
The caller would already fail, but this way the message can better
express the reason for the failure.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2043498
Signed-off-by: Martin Kletzander
---
audio/spiceaudio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
This will enable removing deprecated default audiodev support.
I did not figure out how to make the audiodev represented as an
interface node, so this is a workaround. I am not sure what would be
the proper way.
Signed-off-by: Martin Kletzander
---
tests/qtest/ac97-test.c | 3
Signed-off-by: Martin Kletzander
---
hw/ppc/prep.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index bf622aa38fab..52d801afb307 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -46,6 +46,7 @@
#include "elf.h"
#include "qemu/uni
Signed-off-by: Martin Kletzander
---
audio/audio.c | 13 -
audio/audio.h | 1 -
audio/audio_legacy.c| 555
audio/meson.build | 1 -
docs/about/deprecated.rst | 7 -
docs/about/removed
Signed-off-by: Martin Kletzander
---
hw/arm/integratorcp.c | 8 +++-
hw/arm/musicpal.c | 8 +++-
hw/arm/omap2.c| 8
hw/arm/realview.c | 3 +++
hw/arm/spitz.c| 10 +++---
hw/arm/versatilepb.c | 3 +++
hw/arm/vexpress.c | 3 +++
hw/arm/xlnx
Signed-off-by: Martin Kletzander
---
hw/input/tsc210x.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
index f16a8090b7c7..f0b02bc72280 100644
--- a/hw/input/tsc210x.c
+++ b/hw/input/tsc210x.c
@@ -1098,6 +1098,14 @@ static void tsc210x_init
Now that all callers support error reporting with errp and all machine-default
devices use an explicit audiodev, this can be changed. To make the detection
easier make AUD_register_card() return false on error.
Signed-off-by: Martin Kletzander
---
audio/audio.c| 7 +--
audio
No return values are used anywhere, so switch the functions to be void
and add support for error reporting using errp for use in next patches.
Signed-off-by: Martin Kletzander
---
hw/audio/hda-codec.c | 32 ++--
hw/audio/intel-hda.c | 4 +---
hw/audio/intel-hda.h
this little helper makes it easy to create a dummy audiodev (driver=none) in
case there is no default-audiodev specified for the machine. To make sure users
are not surprised by no sound output a helping message is also printed out.
Signed-off-by: Martin Kletzander
---
audio/audio.c | 34
Now that audiodev= is required and audio_init() will not be called
without and AudioDev we can remove the fallback functionality and error
out in case audio drivers fail initialisation or when the driver does
not exist.
Signed-off-by: Martin Kletzander
---
audio/audio.c | 146
Many machine types have default audio devices with no way to set the underlying
audiodev. Instead of adding an option for each and every one of them this new
property can be used as a default during machine initialisation when creating
such devices.
Signed-off-by: Martin Kletzander
---
hw/core
There was no way to set this and we need that for it to be able to properly
initialise.
Signed-off-by: Martin Kletzander
---
hw/display/xlnx_dp.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index 9bb781e31254..b16d6be2b5cc 100644
things properly, I am not sure whether I
handled everything correctly, hence the RFC.
Any comments are very much appreciated. Thanks and have a nice day ;)
Martin Kletzander (18):
hw/audio: Remove -soundhw support
hw/input/tsc210x: Extract common init code into new function
hw/audio: Simplify
This deduplicates several lines and will make future changes more
concise.
Signed-off-by: Martin Kletzander
---
hw/input/tsc210x.c | 68 --
1 file changed, 24 insertions(+), 44 deletions(-)
diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
index
Signed-off-by: Martin Kletzander
---
ui/vnc.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index badf1d7664fe..2e7af139b030 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -4188,12 +4188,15 @@ void vnc_display_open(const char *id, Error **errp
Since all callers require a valid audiodev this function can now safely
abort in case of missing AudioState.
Signed-off-by: Martin Kletzander
---
audio/audio.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index b95aca444382
One thing I am not sure about is whether to keep the aliases of ac97 and
es1370 in the qdev_alias_table.
Signed-off-by: Martin Kletzander
---
docs/about/deprecated.rst | 9 -
docs/about/removed-features.rst | 10 +
docs/qdev-device-use.txt
Since there is no fallback mechanism and default-guessing this is now
not used and can be safely removed.
Signed-off-by: Martin Kletzander
---
audio/alsaaudio.c | 1 -
audio/audio_int.h | 1 -
audio/coreaudio.m | 1 -
audio/dbusaudio.c | 1 -
audio/dsoundaudio.c | 1 -
audio/jackaudio.c
This will be used in future commit.
Signed-off-by: Martin Kletzander
---
hw/audio/lm4549.c | 3 ++-
hw/audio/lm4549.h | 3 ++-
hw/audio/pl041.c | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/audio/lm4549.c b/hw/audio/lm4549.c
index 32b1481b5614..418041bc9c6c 100644
On Mon, Apr 29, 2019 at 08:58:37AM +, Vladimir Sementsov-Ogievskiy wrote:
29.04.2019 10:27, Martin Kletzander wrote:
On Wed, Apr 24, 2019 at 09:19:17AM +0200, Kevin Wolf wrote:
Am 24.04.2019 um 08:40 hat Vladimir Sementsov-Ogievskiy geschrieben:
23.04.2019 18:08, Kevin Wolf wrote:
>
On Wed, Apr 24, 2019 at 09:19:17AM +0200, Kevin Wolf wrote:
Am 24.04.2019 um 08:40 hat Vladimir Sementsov-Ogievskiy geschrieben:
23.04.2019 18:08, Kevin Wolf wrote:
> Am 23.04.2019 um 16:26 hat Martin Kletzander geschrieben:
>> On Tue, Apr 23, 2019 at 02:12:18PM +0200, Kevin Wolf wrot
On Wed, Apr 24, 2019 at 09:19:17AM +0200, Kevin Wolf wrote:
Am 24.04.2019 um 08:40 hat Vladimir Sementsov-Ogievskiy geschrieben:
23.04.2019 18:08, Kevin Wolf wrote:
> Am 23.04.2019 um 16:26 hat Martin Kletzander geschrieben:
>> On Tue, Apr 23, 2019 at 02:12:18PM +0200, Kevin Wolf wrot
On Tue, Apr 23, 2019 at 02:12:18PM +0200, Kevin Wolf wrote:
Am 23.04.2019 um 13:30 hat Martin Kletzander geschrieben:
Hi,
I am using qemu-img with nbdkit to transfer a disk image and the update it with
extra data from newer snapshots. The end image cannot be transferred because
the snapshots
Hi,
I am using qemu-img with nbdkit to transfer a disk image and the update it with
extra data from newer snapshots. The end image cannot be transferred because
the snapshots will be created later than the first transfer and we want to save
some time up front. You might think of it as a
On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote:
On Fri, Jan 18, 2019 at 10:39:35AM +0100, Erik Skultety wrote:
Hi,
this is a summary of a private discussion I've had with guys CC'd on this email
about finding a solution to [1] - basically, the default permissions on
/dev/sev
On Fri, Jan 18, 2019 at 11:17:11AM +, Daniel P. Berrangé wrote:
On Fri, Jan 18, 2019 at 12:11:50PM +0100, Martin Kletzander wrote:
On Fri, Jan 18, 2019 at 10:16:38AM +, Daniel P. Berrangé wrote:
> I've just realized there is a potential 3rd solution. Remember there is
> actually n
On Thu, May 31, 2018 at 09:33:54AM +0200, Laszlo Ersek wrote:
adding qemu-devel, Paolo and Gerd; comments below:
On 05/30/18 23:08, Martin Kletzander wrote:
On Wed, May 30, 2018 at 11:02:59AM -0400, John Ferlan wrote:
On 05/21/2018 11:00 AM, Martin Kletzander wrote:
We are still hoping all
On Mon, Dec 11, 2017 at 03:03:34PM +0800, Rogue S.T wrote:
Hello, friends.
I encounter a problem when i use ivshmem with my guest, my ivshmem server is
not start, and output a error : Example code, do not use in production ,cannot
bind.
Detail distribution:
Today, I know ivshmem from a topic
On Thu, Oct 06, 2016 at 11:40:36AM +0200, Kevin Wolf wrote:
Recently we moved a few options from QemuOptsLists in blockdev.c to
bdrv_runtime_opts in block.c in order to make them accissble using
blockdev-add. However, this has the side effect that these options are
missing from
On Fri, Feb 19, 2016 at 07:16:12AM +0100, John Obaterspok wrote:
2016-02-18 15:15 GMT+01:00 Martin Kletzander <mklet...@redhat.com>:
On Thu, Feb 18, 2016 at 12:59:52PM +0100, John Obaterspok wrote:
2016-02-18 11:25 GMT+01:00 Martin Kletzander <mklet...@redhat.com>:
On Thu,
On Sun, Feb 14, 2016 at 01:41:41PM +0800, Peter Xu wrote:
For ARM platform, we still do not have any interface to query
whether current QEMU/host support specific GIC version. This
patchset is trying to add one QMP interface for that. By querying
the GIC capability using the new interface, one
On Mon, Jul 20, 2015 at 09:43:23AM +0100, Frediano Ziglio wrote:
The new spice-server function to limit the number of monitors (0.12.6)
changed while development from spice_qxl_set_monitors_config_limit to
spice_qxl_max_monitors (accepted upstream).
By mistake I post patch with former name.
This
On Thu, Jul 09, 2015 at 02:24:51PM +0200, Maxime Leroy wrote:
Hi Martin, Michael,
On Thu, Jul 9, 2015 at 2:00 PM, Martin Kletzander mklet...@redhat.com wrote:
On Thu, Jul 09, 2015 at 10:06:35AM +0300, Michael S. Tsirkin wrote:
On Thu, Jul 09, 2015 at 12:00:59AM +0200, Maxime Leroy wrote
On Thu, Jul 09, 2015 at 10:06:35AM +0300, Michael S. Tsirkin wrote:
On Thu, Jul 09, 2015 at 12:00:59AM +0200, Maxime Leroy wrote:
Hi Michael,
On Wed, Jul 8, 2015 at 4:29 PM, Michael S. Tsirkin m...@redhat.com wrote:
On Thu, May 28, 2015 at 09:23:06AM +0800, Ouyang Changchun wrote:
Based on
On Tue, Jun 23, 2015 at 02:13:21PM +0200, Piotr Rybicki wrote:
Hello.
Problem description:
When i start qemu via libvirt with vnc websocket defined, it is not
possible to live migrate to host where other qemu process is running
with the same display id.
migration error is:
error: internal
Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it
according to the comment above as currently the build fails with
gcc-5.1.0.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
target-arm/op_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Jun 02, 2015 at 09:10:23AM +0100, Peter Maydell wrote:
On 2 June 2015 at 09:05, Martin Kletzander mklet...@redhat.com wrote:
Boolean value '!arm_current_el(env)' can never be equal to 3. Fix it
according to the comment above as currently the build fails with
gcc-5.1.0.
Signed-off
On Tue, Apr 14, 2015 at 10:07:00AM -0600, Eric Blake wrote:
[adding qemu]
On 04/14/2015 09:58 AM, Marc-André Lureau wrote:
Hi
On Tue, Apr 14, 2015 at 4:25 PM, Martin Kletzander mklet...@redhat.com
wrote:
Is this not exposed in any way in QEMU? Do we really need to use this
(what we're
On Tue, Aug 26, 2014 at 10:33:27AM +0100, Stefan Hajnoczi wrote:
On Mon, Aug 25, 2014 at 5:40 PM, Marina Zhurakhinskaya
mari...@redhat.com wrote:
- Original Message -
From: Stefan Hajnoczi stefa...@gmail.com
To: Martin Kletzander mklet...@redhat.com
Cc: qemu-devel qemu-devel@nongnu.org
On Thu, Aug 21, 2014 at 09:06:39PM +0100, Stefan Hajnoczi wrote:
Dear mentors and core contributors,
Outreach Program for Women is starting the next round in October 2014.
OPW funds women to work on open source software for 12 weeks with the
help of mentors:
On Mon, Feb 10, 2014 at 10:49:35PM -0800, Peter Crosthwaite wrote:
This was guarding against a full fifo rather than an empty fifo when
popping. Fix.
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
---
Reviewed-by: Martin Kletzander mklet...@redhat.com
With this patch qemu
On Tue, Feb 04, 2014 at 07:05:24AM +0100, Martin Kletzander wrote:
On Tue, Feb 04, 2014 at 11:40:41AM +1000, Peter Crosthwaite wrote:
On Tue, Feb 4, 2014 at 4:45 AM, Dr. David Alan Gilbert
dgilb...@redhat.com wrote:
(cc'ing in Peter Crosthwaite and Michael Tokarev due to a serial fifo
Hello,
current HEAD (2f61120c10da9128357510debc8e66880cd2bfdc) segfaults when
I'm trying to do the following:
I add this to qemu's command-line:
-chardev spiceport,id=charserial0,name=org.qemu.console.serial.0 \
-device isa-serial,chardev=charserial0,id=serial0
and then use spicy to connect
On Tue, Feb 04, 2014 at 11:40:41AM +1000, Peter Crosthwaite wrote:
On Tue, Feb 4, 2014 at 4:45 AM, Dr. David Alan Gilbert
dgilb...@redhat.com wrote:
(cc'ing in Peter Crosthwaite and Michael Tokarev due to a serial fifo change
- see below!)
* Martin Kletzander (mklet...@redhat.com) wrote
On Fri, Jan 31, 2014 at 10:20:42AM -0700, Eric Blake wrote:
On 01/31/2014 09:49 AM, Martin Kletzander wrote:
Introduce 'query-chardev-backends' QMP command which lists all
supported character device backends.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
v2:
- Version
Introduce 'query-chardev-backends' QMP command which lists all
supported character device backends.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
v3:
- Omit commas at the end of list in JSON
v2:
- Version changed from 1.8.0 to 2.0
qapi-schema.json | 22 ++
qemu
Introduce 'query-chardev-backends' QMP command which lists all
supported character device backends.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
qapi-schema.json | 22 ++
qemu-char.c | 19 +++
qmp-commands.hx | 41
Introduce 'query-chardev-backends' QMP command which lists all
supported character device backends.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
v2:
- Version changed from 1.8.0 to 2.0
qapi-schema.json | 22 ++
qemu-char.c | 19 +++
qmp
On 06/20/2013 09:54 AM, Markus Armbruster wrote:
All I wanted to do is exit(1) instead of abort() on guest memory
allocation failure [07/08]. But that lead me into a minor #ifdef bog,
and here's what I brought back. Enjoy!
Testing:
* Christian Borntraeger reports v1 works fine under LPAR
On 06/12/2013 04:29 PM, chandrashekar shastri wrote:
Hi All,
Upstream : virt-install and virt-manager fails to install the guest with
the error qemu: could not load PC BIOS 'bios.bin'
You are missing bios package for that. This depends on the distro
you're using, but probably
Hi everybody,
while coding the support for Jason's dump-guest-core option I realized
there is (probably) a problem with the way QEMU parses additional
machine options ('dump-guest-core', 'kvm_shadow_mem' etc.). Running QEMU
with option to -machine works ok, but using '-M' (as libvirt does) works
On 08/22/2012 05:15 PM, Jan Kiszka wrote:
On 2012-08-22 17:05, Martin Kletzander wrote:
Hi everybody,
while coding the support for Jason's dump-guest-core option I realized
there is (probably) a problem with the way QEMU parses additional
machine options ('dump-guest-core', 'kvm_shadow_mem
57 matches
Mail list logo
