Re: [Qemu-devel] [PATCH 5/8] disas: lm32: QOMify target specific disas setup

2015-07-12 Thread Michael Walle
Am 12. Juli 2015 04:00:02 MESZ, schrieb Peter Crosthwaite : >From: Peter Crosthwaite > >Move the target_disas() lm32 specifics to the QOM disas_set_info hook >and delete the #ifdef specific code in disas.c. > >Cc: Michael Walle >Signed-off-by: Peter Crosthwaite Acked-by: Michael Walle

Re: [Qemu-devel] Are "info pic" and "info irq" still of any use?

2015-03-31 Thread Michael Walle
Am 2015-03-31 11:56, schrieb Markus Armbruster: [..] * lm32-softmmu This is lm32_hmp_info_pic(), lm32_hmp_info_irq(). Both do nothing when !pic. Set by init() method of "lm32-pic". Thus, two cases: - Machines sporting an "lm32-pic" These are lm32-evr, lm32-uclinux, milkymi

[Qemu-devel] [RFC PATCH] qtest: new functions for pulsed IRQs

2015-02-24 Thread Michael Walle
It is only possible to retrieve the current state of an interrupt line. But there are devices which just pulses the interrupt line. Introduce a latch which is set by qtest and which can be cleared by the test case. Signed-off-by: Michael Walle --- tests/libqtest.c | 19

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Michael Walle
Am 2015-02-20 16:37, schrieb Radim Krčmář: 2015-02-20 23:40+0900, Peter Maydell: On 20 February 2015 at 23:18, Radim Krčmář wrote: > man gcc: > Warn if in a loop with constant number of iterations the compiler > detects undefined behavior in some statement during one or more of > the iter

Re: [Qemu-devel] [PATCH 2/2] milkymist-pfpu: fix GCC 5.0.0 aggressive-loop-optimizations warning

2015-02-20 Thread Michael Walle
Am 2015-02-20 15:36, schrieb Paolo Bonzini: On 20/02/2015 15:18, Radim Krčmář wrote: man gcc: Warn if in a loop with constant number of iterations the compiler detects undefined behavior in some statement during one or more of the iterations. Refactored the code a bit to avoid the GCC war

[Qemu-devel] [PULL RESEND 0/2] lm32: milkymist fixes and MAINTAINERS update

2014-12-30 Thread Michael Walle
5:17 +0100) -------- Michael Walle (2): milkymist: softmmu: fix event handling MAINTAINERS: add myself to lm32 and milkymist MAINTAINERS | 6 +- hw/input/milkymist-softusb.c | 19 --- 2 files changed, 17 insertions(+), 8 deletions(-) -- 2.1.4

Re: [Qemu-devel] [PULL 0/2] lm32: milkymist fixes and MAINTAINERS update

2014-12-30 Thread Michael Walle
Oh sorry. Something went wrong with the pull request. I'll make a new one asap. -michael

[Qemu-devel] [PULL 0/2] lm32: milkymist fixes and MAINTAINERS update

2014-12-29 Thread Michael Walle
) are available in the git repository at: git://github.com/mwalle/qemu.git for you to fetch changes up to 4eab7a0a2394275a611a19aef6619402ad524b63: MAINTAINERS: add myself to lm32 and milkymist (2014-12-29 17:25:17 +0100) -------- Mic

[Qemu-devel] [PULL 2/2] MAINTAINERS: add myself to lm32 and milkymist

2014-12-29 Thread Michael Walle
Add myself to lm32 and milkymist files. Signed-off-by: Michael Walle --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01cfb05..7fc3cdb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -98,8 +98,12 @@ LM32 M: Michael Walle S

[Qemu-devel] [PULL 1/2] milkymist: softmmu: fix event handling

2014-12-29 Thread Michael Walle
Keys which send more than one scancode (esp. windows key) weren't handled correctly since commit 1ff5eedd. Two events were put into the input event queue but only one was processed. This fixes this by fetching all pending events in the callback handler. Signed-off-by: Michael Walle Cc:

Re: [Qemu-devel] [RfC PATCH 1/3] configure: opengl overhaul

2014-12-15 Thread Michael Walle
Am 2014-12-11 12:05, schrieb Gerd Hoffmann: Rename config option from "glx" to "opengl", glx will not be the only option for opengl in near future. Also switch over to pkg-config for opengl support detection. I'm ok with that, although it is a revert of b1e5fff4afd0c47148b0d9f9341887ae2c3eb9a

[Qemu-devel] [PATCH] MAINTAINERS: add myself to lm32 and milkymist

2014-11-02 Thread Michael Walle
Add myself to lm32 and milkymist files. Signed-off-by: Michael Walle --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 94366ef..584a174 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -98,8 +98,12 @@ LM32 M: Michael Walle S

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-10-05 Thread Michael Walle
Am Sonntag, 5. Oktober 2014, 22:48:05 schrieb Peter Maydell: > On 5 October 2014 22:36, Peter Maydell wrote: > > On 5 October 2014 22:00, Michael Walle wrote: > >> I can confirm that your patch makes qemu stop one instruction earlier. > >> Without your patch the prog

[Qemu-devel] [PATCH] milkymist: softmmu: fix event handling

2014-10-05 Thread Michael Walle
Keys which send more than one scancode (esp. windows key) weren't handled correctly since commit 1ff5eedd. Two events were put into the input event queue but only one was processed. Fixes this by fetching all pending events in the callback handler. Signed-off-by: Michael Walle Cc: Gerd Hof

Re: [Qemu-devel] [PATCH] gdbstub: Allow target CPUs to specify watchpoint STOP_BEFORE_ACCESS flag

2014-10-05 Thread Michael Walle
Am Freitag, 12. September 2014, 19:04:17 schrieb Peter Maydell: > GDB assumes that watchpoint set via the gdbstub remote protocol will > behave in the same way as hardware watchpoints for the target. In > particular, whether the CPU stops with the PC before or after the insn > which triggers the wa

Re: [Qemu-devel] hid keyboard event handling

2014-10-01 Thread Michael Walle
Am 2014-10-01 16:17, schrieb Gerd Hoffmann: Hi, My input device model (milkymist-softusb.c) polls (hid_keyboard_poll()) exactly once per event callback. Actually, i don't see any other way to do it because the hid_keyboard_poll() always succeeds even if there is no event in the queue. You c

[Qemu-devel] hid keyboard event handling

2014-10-01 Thread Michael Walle
Hi Gerd, i have another issue. This time with the hid keyboard rework (commit 1ff5eedd). Before this commit, a press of, for example the windows key, resulted in two calls of the hs->event() callback. Eg. there were two events queued and two callbacks. But after your commit, two events are qu

[Qemu-devel] ui/gtk.c does not check qemu_chr_be_can_write()

2014-09-29 Thread Michael Walle
Hi Anthony, Hi Gerd, the GTK frontend does not respect the the "chr_can_read" hook. The frontend just writes characters to the device using qemu_chr_be_write() without checking if the device can receive any input (qemu_chr_be_can_write()). At least for my device model (hw/char/milkymist-uart

Re: [Qemu-devel] [PATCH 20/23] target-lm32: Use cpu_exec_interrupt qom hook

2014-09-14 Thread Michael Walle
Am Samstag, 13. September 2014, 09:45:31 schrieb Richard Henderson: > Cc: Michael Walle > Signed-off-by: Richard Henderson Acked-by: Michael Walle > --- > cpu-exec.c| 7 --- > target-lm32/cpu-qom.h | 1 + > target-lm32/cpu.c | 1 + > targe

[Qemu-devel] [PULL 4/4] lm32: remove lm32_sys

2014-05-24 Thread Michael Walle
Since we have now semihosting on the lm32 target, this device is no longer needed. Remove it. Signed-off-by: Michael Walle --- hw/misc/Makefile.objs |1 - hw/misc/lm32_sys.c| 179 - target-lm32/README| 10 --- trace-events

[Qemu-devel] [PULL 2/4] target-lm32: add semihosting support

2014-05-24 Thread Michael Walle
Intercept certain system calls if semihosting is enabled. This should behave like the GDB simulator. Signed-off-by: Michael Walle --- qemu-options.hx |3 +- target-lm32/Makefile.objs |1 + target-lm32/README|9 ++ target-lm32/cpu.h |1 + target-lm32

[Qemu-devel] [PULL 3/4] test: lm32: use semihosting for testing

2014-05-24 Thread Michael Walle
Instead of the lm32-sys device, use semihosting to print to the host console and exit the test. Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile | 15 +- tests/tcg/lm32/crt.S|4 +-- tests/tcg/lm32/helper.S | 65

[Qemu-devel] [PULL 1/4] test: lm32: make test cases independent

2014-05-24 Thread Michael Walle
Make test cases independent from from each other. Eg. if a test case needs a specific value in register A, don't rely on the fact that it is already set by the preceding test case. Signed-off-by: Michael Walle --- tests/tcg/lm32/test_lb.S |4 tests/tcg/lm32/test_lbu.S |

[Qemu-devel] [PULL 0/4] lm32: semihosting support

2014-05-24 Thread Michael Walle
19:43:52 +0200) -------- Michael Walle (4): test: lm32: make test cases independent target-lm32: add semihosting support test: lm32: use semihosting for testing lm32: remove lm32_sys hw/misc/Makefile.objs |

Re: [Qemu-devel] [PATCH 2/4] target-lm32: add semihosting support

2014-04-28 Thread Michael Walle
Am 2014-04-28 19:27, schrieb Peter Maydell: On 22 April 2014 19:18, Michael Walle wrote: Intercept certain system calls if semihosting is enabled. This should behave like the GDB simulator. @@ -608,8 +609,20 @@ static void dec_scall(DisasContext *dc) break; case 7

[Qemu-devel] [PATCH 2/4] target-lm32: add semihosting support

2014-04-22 Thread Michael Walle
Intercept certain system calls if semihosting is enabled. This should behave like the GDB simulator. Signed-off-by: Michael Walle --- qemu-options.hx |3 +- target-lm32/Makefile.objs |1 + target-lm32/README|9 ++ target-lm32/helper.h |1 + target-lm32

[Qemu-devel] [PATCH 1/4] test: lm32: make test cases independent

2014-04-22 Thread Michael Walle
Make test cases independent from from each other. Eg. if a test case needs a specific value in register A, don't rely on the fact that it is already set by the preceding test case. Signed-off-by: Michael Walle --- tests/tcg/lm32/test_lb.S |4 tests/tcg/lm32/test_lbu.S |

[Qemu-devel] [PATCH 0/4] Semihosting support for LatticeMico32

2014-04-22 Thread Michael Walle
days. Michael Walle (4): test: lm32: make test cases independent target-lm32: add semihosting support test: lm32: use semihosting for testing lm32: remove lm32_sys hw/misc/Makefile.objs |1 - hw/misc/lm32_sys.c | 180 qemu-optio

[Qemu-devel] [PATCH 3/4] test: lm32: use semihosting for testing

2014-04-22 Thread Michael Walle
Instead of the lm32-sys device, use semihosting to print to the host console and exit the test. Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile | 15 +- tests/tcg/lm32/crt.S|4 +-- tests/tcg/lm32/helper.S | 65

[Qemu-devel] [PATCH 4/4] lm32: remove lm32_sys

2014-04-22 Thread Michael Walle
Since we have now semihosting on the lm32 target, this device is no longer needed. Remove it. Signed-off-by: Michael Walle --- hw/misc/Makefile.objs |1 - hw/misc/lm32_sys.c| 180 - target-lm32/README| 10 --- trace-events

Re: [Qemu-devel] [RFC qom-cpu 00/41] QOM CPUState, part 13: Emptying CPU_COMMON

2014-02-07 Thread Michael Walle
Am 2013-09-04 11:04, schrieb Andreas Färber: On part 11, rth said for alpha that using CPUAlphaState in DisasContext was bad and that the relevant fields should be copied into DisasContext instead; a few targets still have an env field though and use it for register access and cpu_abort(), so I

[Qemu-devel] [PULL v5 02/12] tests: lm32: new rule for single test cases

2014-02-04 Thread Michael Walle
Introduce new target "check_%" to run individual test caes, eg. make check_mmu Signed-off-by: Michael Walle Reviewed-by: Peter Maydell --- tests/tcg/lm32/Makefile |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm3

[Qemu-devel] [PULL v5 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2014-02-04 Thread Michael Walle
From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael

[Qemu-devel] [PULL v5 09/12] lm32_sys: print test result on stderr

2014-02-04 Thread Michael Walle
Do not use qemu_log(). Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 16dc254..b2e157c 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -80,7 +80,7 @@ static void

[Qemu-devel] [PULL v5 05/12] milkymist-vgafb: swap pixel data in source buffer

2014-02-04 Thread Michael Walle
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, use lduw_be_p() to read the value. Cc: Paolo Bonzini Signed-off-by: Michael Walle --- hw/display/milkymist

[Qemu-devel] [PULL v5 00/12] target-lm32 updates

2014-02-04 Thread Michael Walle
--- Antony Pavlov (1): milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() Michael Walle (11): lm32_sys: increase test case name length limit tests: lm32: new rule for single test cases lm32_uart/lm32_juart: use qe

[Qemu-devel] [PULL v5 10/12] lm32_sys: dump cpu state if test case fails

2014-02-04 Thread Michael Walle
This will ease debugging the test cases. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index b2e157c..e394f2e 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -82,6 +82,9 @@ static

[Qemu-devel] [PULL v5 07/12] target-lm32: move model features to LM32CPU

2014-02-04 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Reviewed-by: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/cpu-qom.h |6 ++ target-lm32/cpu.c | 187

[Qemu-devel] [PULL v5 06/12] target-lm32: kill cpu_abort() calls

2014-02-04 Thread Michael Walle
-off-by: Michael Walle Reviewed-by: Andreas Färber --- target-lm32/translate.c | 72 ++- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 6ea0ecd..e292e1c 100644 --- a/target-lm32

[Qemu-devel] [PULL v5 01/12] lm32_sys: increase test case name length limit

2014-02-04 Thread Michael Walle
The new MMU tests use longer names. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 9bdb781..16dc254 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -42,7

[Qemu-devel] [PULL v5 08/12] target-lm32: add breakpoint/watchpoint support

2014-02-04 Thread Michael Walle
This patch adds in-target breakpoint and watchpoint support. Signed-off-by: Michael Walle --- target-lm32/TODO|2 -- target-lm32/cpu.c |1 + target-lm32/cpu.h | 27 -- target-lm32/helper.c| 90

[Qemu-devel] [PULL v5 12/12] hw/lm32: print error if cpu model is not found

2014-02-04 Thread Michael Walle
QEMU crashed if a the given cpu_model is not found. Signed-off-by: Michael Walle Reviewed-by: Peter Maydell --- hw/lm32/lm32_boards.c | 10 ++ hw/lm32/milkymist.c |5 + 2 files changed, 15 insertions(+) diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c index

[Qemu-devel] [PULL v5 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all()

2014-02-04 Thread Michael Walle
qemu_chr_fe_write() may return EAGAIN. Therefore, use qemu_chr_fe_write_all(). Signed-off-by: Michael Walle Reviewed-by: Peter Maydell --- hw/char/lm32_juart.c |2 +- hw/char/lm32_uart.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw

[Qemu-devel] [PULL v5 11/12] target-lm32: stop VM on illegal or unknown instruction

2014-02-04 Thread Michael Walle
Instead of translating the instruction to a no-op, pause the VM and display a message to the user. As a side effect, this also works for instructions where the operands are only known at runtime. Signed-off-by: Michael Walle --- target-lm32/helper.h|1 + target-lm32/op_helper.c | 17

Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-02-04 Thread Michael Walle
Am 2014-02-03 23:59, schrieb Peter Maydell: On 3 February 2014 22:39, Michael Walle wrote: Am 2014-02-01 21:31, schrieb Michael Walle: Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell: On 20 January 2014 19:34, Michael Walle wrote: > Do not use qemu_log(). > > Sign

Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-02-03 Thread Michael Walle
Am 2014-02-01 21:31, schrieb Michael Walle: Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell: On 20 January 2014 19:34, Michael Walle wrote: > Do not use qemu_log(). > > Signed-off-by: Michael Walle > --- > > hw/misc/lm32_sys.c |2 +- > 1 file chang

Re: [Qemu-devel] [PULL v4 00/12] target-lm32 updates

2014-02-01 Thread Michael Walle
Am Samstag, 1. Februar 2014, 19:21:28 schrieb Peter Maydell: > On 20 January 2014 19:34, Michael Walle wrote: > > Hi Anthony, > > > > this is a pull request for various updates and fixes for the > > LatticeMico32 target. > > > > Please pull. > > Apo

Re: [Qemu-devel] [PULL v4 11/12] target-lm32: stop VM on illegal or unknown instruction

2014-02-01 Thread Michael Walle
Am Samstag, 1. Februar 2014, 19:06:40 schrieb Peter Maydell: > On 20 January 2014 19:34, Michael Walle wrote: > > Instead of translating the instruction to a no-op, pause the VM and > > display a message to the user. > > > > As a side effect, this also works for inst

Re: [Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-02-01 Thread Michael Walle
Am Samstag, 1. Februar 2014, 19:00:01 schrieb Peter Maydell: > On 20 January 2014 19:34, Michael Walle wrote: > > Do not use qemu_log(). > > > > Signed-off-by: Michael Walle > > --- > > > > hw/misc/lm32_sys.c |2 +- > > 1 file changed, 1 inse

[Qemu-devel] [PULL v4 06/12] target-lm32: kill cpu_abort() calls

2014-01-20 Thread Michael Walle
-off-by: Michael Walle Reviewed-by: Andreas Färber --- target-lm32/translate.c | 72 ++- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 6ea0ecd..e292e1c 100644 --- a/target-lm32

[Qemu-devel] [PULL v4 05/12] milkymist-vgafb: swap pixel data in source buffer

2014-01-20 Thread Michael Walle
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, swap the bytes if we are building for a little-endian host. Cc: Paolo Bonzini Signed-off-by: Michael Walle

[Qemu-devel] [PULL v4 07/12] target-lm32: move model features to LM32CPU

2014-01-20 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Reviewed-by: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/cpu-qom.h |6 ++ target-lm32/cpu.c | 187

[Qemu-devel] [PULL v4 01/12] lm32_sys: increase test case name length limit

2014-01-20 Thread Michael Walle
The new MMU tests use longer names. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 9bdb781..8176cdb 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -42,7

[Qemu-devel] [PULL v4 09/12] lm32_sys: print test result on stderr

2014-01-20 Thread Michael Walle
Do not use qemu_log(). Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 8176cdb..6af0cca 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -80,7 +80,7 @@ static void

[Qemu-devel] [PULL v4 11/12] target-lm32: stop VM on illegal or unknown instruction

2014-01-20 Thread Michael Walle
Instead of translating the instruction to a no-op, pause the VM and display a message to the user. As a side effect, this also works for instructions where the operands are only known at runtime. Signed-off-by: Michael Walle --- target-lm32/helper.h|1 + target-lm32/op_helper.c | 17

[Qemu-devel] [PULL v4 10/12] lm32_sys: dump cpu state if test case fails

2014-01-20 Thread Michael Walle
This will ease debugging the test cases. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 6af0cca..1fd69ff 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -81,6 +81,9 @@ static

[Qemu-devel] [PULL v4 08/12] target-lm32: add breakpoint/watchpoint support

2014-01-20 Thread Michael Walle
This patch adds in-target breakpoint and watchpoint support. Signed-off-by: Michael Walle --- target-lm32/TODO|2 -- target-lm32/cpu.c |1 + target-lm32/cpu.h | 27 -- target-lm32/helper.c| 89

[Qemu-devel] [PULL v4 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all()

2014-01-20 Thread Michael Walle
qemu_chr_fe_write() may return EAGAIN. Therefore, use qemu_chr_fe_write_all(). Signed-off-by: Michael Walle --- hw/char/lm32_juart.c |2 +- hw/char/lm32_uart.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index

[Qemu-devel] [PULL v4 00/12] target-lm32 updates

2014-01-20 Thread Michael Walle
cpu model is not found (2014-01-20 19:49:13 +0100) Antony Pavlov (1): milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() Michael Walle (11): lm32_sys: increase test case name length limit tests: lm

[Qemu-devel] [PULL v4 12/12] hw/lm32: print error if cpu model is not found

2014-01-20 Thread Michael Walle
QEMU crashed if a the given cpu_model is not found. Signed-off-by: Michael Walle --- hw/lm32/lm32_boards.c | 10 ++ hw/lm32/milkymist.c |5 + 2 files changed, 15 insertions(+) diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c index c032bb8..5e22e9b 100644 --- a/hw

[Qemu-devel] [PULL v4 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2014-01-20 Thread Michael Walle
From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael

[Qemu-devel] [PULL v4 02/12] tests: lm32: new rule for single test cases

2014-01-20 Thread Michael Walle
Introduce new target "check_%" to run indiviudal test caes, eg. make check_mmu Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm32/Makefile index 9a00ef7..19e0664 100644 --- a

Re: [Qemu-devel] [PULL v3 00/12] target-lm32 updates

2013-12-12 Thread Michael Walle
Hi Anthony, Am Donnerstag, 28. November 2013, 19:43:10 schrieben Sie: > Hi Anthony, > > This is a pull for various updates and fixes for the LatticeMico32 target. > > Please pull. > > changes since v2: > - rebased > - replaced ifdef HOST_WORDS_BIGENDIAN with be16_to_cpu() in >"milkymist-

Re: [Qemu-devel] [PATCH] target-lm32: Use new qemu_ld/st opcodes

2013-12-12 Thread Michael Walle
Hi Richard, Am Samstag, 7. Dezember 2013, 03:03:21 schrieb Richard Henderson: > Cc: Michael Walle > Signed-off-by: Richard Henderson > --- > target-lm32/translate.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/target-lm32/tran

[Qemu-devel] [PULL v3 09/12] lm32_sys: print test result on stderr

2013-11-28 Thread Michael Walle
Do not use qemu_log(). Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 8176cdb..6af0cca 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -80,7 +80,7 @@ static void

[Qemu-devel] [PULL v3 12/12] hw/lm32: print error if cpu model is not found

2013-11-28 Thread Michael Walle
QEMU crashed if a the given cpu_model is not found. Signed-off-by: Michael Walle --- hw/lm32/lm32_boards.c | 10 ++ hw/lm32/milkymist.c |5 + 2 files changed, 15 insertions(+) diff --git a/hw/lm32/lm32_boards.c b/hw/lm32/lm32_boards.c index c032bb8..5e22e9b 100644 --- a/hw

[Qemu-devel] [PULL v3 00/12] target-lm32 updates

2013-11-28 Thread Michael Walle
- Antony Pavlov (1): milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() Michael Walle (11): lm32_sys: increase test case name length limit tests: lm32: new rule for single test cases lm32_uart/lm32_juart: use qemu_chr_fe_wri

[Qemu-devel] [PULL v3 03/12] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2013-11-28 Thread Michael Walle
From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael

[Qemu-devel] [PULL v3 02/12] tests: lm32: new rule for single test cases

2013-11-28 Thread Michael Walle
Introduce new target "check_%" to run indiviudal test caes, eg. make check_mmu Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm32/Makefile index 9a00ef7..19e0664 100644 --- a

[Qemu-devel] [PULL v3 04/12] lm32_uart/lm32_juart: use qemu_chr_fe_write_all()

2013-11-28 Thread Michael Walle
qemu_chr_fe_write() may return EAGAIN. Therefore, use qemu_chr_fe_write_all(). Signed-off-by: Michael Walle --- hw/char/lm32_juart.c |2 +- hw/char/lm32_uart.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index

[Qemu-devel] [PULL v3 10/12] lm32_sys: dump cpu state if test case fails

2013-11-28 Thread Michael Walle
This will ease debugging the test cases. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 6af0cca..1fd69ff 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -81,6 +81,9 @@ static

[Qemu-devel] [PULL v3 05/12] milkymist-vgafb: swap pixel data in source buffer

2013-11-28 Thread Michael Walle
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, swap the bytes if we are building for a little-endian host. Cc: Paolo Bonzini Signed-off-by: Michael Walle

[Qemu-devel] [PULL v3 08/12] target-lm32: add breakpoint/watchpoint support

2013-11-28 Thread Michael Walle
This patch adds in-target breakpoint and watchpoint support. Signed-off-by: Michael Walle --- target-lm32/TODO|2 -- target-lm32/cpu.c |1 + target-lm32/cpu.h | 27 -- target-lm32/helper.c| 89

[Qemu-devel] [PULL v3 07/12] target-lm32: move model features to LM32CPU

2013-11-28 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Reviewed-by: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/cpu-qom.h |6 ++ target-lm32/cpu.c | 187

[Qemu-devel] [PULL v3 06/12] target-lm32: kill cpu_abort() calls

2013-11-28 Thread Michael Walle
-off-by: Michael Walle Reviewed-by: Andreas Färber --- target-lm32/translate.c | 72 ++- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 6ea0ecd..e292e1c 100644 --- a/target-lm32

[Qemu-devel] [PULL v3 01/12] lm32_sys: increase test case name length limit

2013-11-28 Thread Michael Walle
The new MMU tests use longer names. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 9bdb781..8176cdb 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -42,7

[Qemu-devel] [PULL v3 11/12] target-lm32: stop VM on illegal or unknown instruction

2013-11-28 Thread Michael Walle
Instead of translating the instruction to a no-op, pause the VM and display a message to the user. As a side effect, this also works for instructions where the operands are only known at runtime. Signed-off-by: Michael Walle --- target-lm32/helper.h|1 + target-lm32/op_helper.c | 17

Re: [Qemu-devel] [PATCH v2] target-lm32: move model features to LM32CPU

2013-11-17 Thread Michael Walle
Am 2013-10-14 23:46, schrieb Michael Walle: This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Cc: Andreas Färber Signed-off-by: Michael Walle --- changes since v1: - instead of storing a pointer to the cpu definitions

[Qemu-devel] [PATCH v2] target-lm32: move model features to LM32CPU

2013-10-14 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Cc: Andreas Färber Signed-off-by: Michael Walle --- changes since v1: - instead of storing a pointer to the cpu definitions, register individual cpu types and store

Re: [Qemu-devel] [PULL v2 05/11] milkymist-vgafb: swap pixel data in source buffer

2013-10-14 Thread Michael Walle
Am Montag, 14. Oktober 2013, 19:05:25 schrieb Richard Henderson: > On 10/14/2013 09:29 AM, Michael Walle wrote: > > +#ifndef HOST_WORDS_BIGENDIAN > > +rgb565 = bswap16(rgb565); > > +#endif > > be16_to_cpu, no ifdef needed. > > > r~ Thanks. I'll update the patch. -- michael

Re: [Qemu-devel] [PULL v2 00/11] target-lm32 updates

2013-10-14 Thread Michael Walle
Am Montag, 14. Oktober 2013, 18:29:24 schrieb Michael Walle: > This is a pull for various updates and fixes for the LatticeMico32 target. > > Please pull. > > changes since v1: > - rebased > - dropped patch "target-lm32: register helper functions". This is &g

[Qemu-devel] [PULL v2 09/11] lm32_sys: print test result on stderr

2013-10-14 Thread Michael Walle
Do not use qemu_log(). Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 8176cdb..6af0cca 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -80,7 +80,7 @@ static void

[Qemu-devel] [PULL v2 08/11] target-lm32: add breakpoint/watchpoint support

2013-10-14 Thread Michael Walle
This patch adds in-target breakpoint and watchpoint support. Signed-off-by: Michael Walle --- target-lm32/TODO|2 -- target-lm32/cpu.c |1 + target-lm32/cpu.h | 27 -- target-lm32/helper.c| 89

[Qemu-devel] [PULL v2 05/11] milkymist-vgafb: swap pixel data in source buffer

2013-10-14 Thread Michael Walle
In commit fc97bb5ba3e7239c0b6d24095df6784868dfebbf the lduw_raw() call was eliminated. But we are reading from the target buffer a 16-bit value, which is in big-endian format. Therefore, swap the bytes if we are building for a little-endian host. Cc: Paolo Bonzini Signed-off-by: Michael Walle

[Qemu-devel] [PULL v2 02/11] tests: lm32: new rule for single test cases

2013-10-14 Thread Michael Walle
Introduce new target "check_%" to run indiviudal test caes, eg. make check_mmu Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm32/Makefile index 9a00ef7..19e0664 100644 --- a

[Qemu-devel] [PULL v2 10/11] lm32_sys: dump cpu state if test case fails

2013-10-14 Thread Michael Walle
This will ease debugging the test cases. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 6af0cca..1fd69ff 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -81,6 +81,9 @@ static

[Qemu-devel] [PULL v2 11/11] target-lm32: stop VM on illegal or unknown instruction

2013-10-14 Thread Michael Walle
Instead of translating the instruction to a no-op, pause the VM and display a message to the user. As a side effect, this also works for instructions where the operands are only known at runtime. Signed-off-by: Michael Walle --- target-lm32/helper.h|1 + target-lm32/op_helper.c | 17

[Qemu-devel] [PULL v2 07/11] target-lm32: move model features to LM32CPU

2013-10-14 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Cc: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/cpu-qom.h |1 + target-lm32/cpu.h | 12 +--- target-lm32/helper.c| 15

[Qemu-devel] [PULL v2 06/11] target-lm32: kill cpu_abort() calls

2013-10-14 Thread Michael Walle
: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/translate.c | 72 ++- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 6ea0ecd..eda8caa 100644 --- a/target-lm32/translate.c

[Qemu-devel] [PULL v2 03/11] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2013-10-14 Thread Michael Walle
From: Antony Pavlov qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite Acked-by: Peter Crosthwaite Signed-off-by: Antony Pavlov Signed-off-by: Michael

[Qemu-devel] [PULL v2 00/11] target-lm32 updates

2013-10-14 Thread Michael Walle
on (2013-10-14 18:23:08 +0200) Antony Pavlov (1): milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write() Michael Walle (10): lm32_sys: increase test case name length limit tests: lm32: new rule for single test cases lm32_uart/lm32_ju

[Qemu-devel] [PULL v2 04/11] lm32_uart/lm32_juart: use qemu_chr_fe_write_all()

2013-10-14 Thread Michael Walle
qemu_chr_fe_write() may return EAGAIN. Therefore, use qemu_chr_fe_write_all(). Signed-off-by: Michael Walle --- hw/char/lm32_juart.c |2 +- hw/char/lm32_uart.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index

[Qemu-devel] [PULL v2 01/11] lm32_sys: increase test case name length limit

2013-10-14 Thread Michael Walle
The new MMU tests use longer names. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 9bdb781..8176cdb 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -42,7

[Qemu-devel] [PULL 02/11] tests: lm32: new rule for single test cases

2013-09-25 Thread Michael Walle
Introduce new target "check_%" to run indiviudal test caes, eg. make check_mmu Signed-off-by: Michael Walle --- tests/tcg/lm32/Makefile |3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/tcg/lm32/Makefile b/tests/tcg/lm32/Makefile index 9a00ef7..19e0664 100644 --- a

[Qemu-devel] [PULL 05/11] target-lm32: register helper functions

2013-09-25 Thread Michael Walle
This has been forgotton in the initial commit. Fix it. Reported-by: Richard Henderson Signed-off-by: Michael Walle --- target-lm32/translate.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 6ea0ecd..9605494 100644 --- a/target

[Qemu-devel] [PULL 01/11] lm32_sys: increase test case name length limit

2013-09-25 Thread Michael Walle
The new MMU tests use longer names. Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 9bdb781..8176cdb 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -42,7

[Qemu-devel] [RFC PATCH] target-lm32: stop VM on illegal or unknown instruction

2013-09-25 Thread Michael Walle
Instead of translating the instruction to a no-op, pause the VM and display a message to the user. As a side effect, this also works for instructions where the operands are only known at runtime. Signed-off-by: Michael Walle I have some doubt about the implementation of the "ill" h

[Qemu-devel] [PULL 07/11] target-lm32: kill cpu_abort() calls

2013-09-25 Thread Michael Walle
: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/translate.c | 72 ++- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/target-lm32/translate.c b/target-lm32/translate.c index 9605494..1d94d52 100644 --- a/target-lm32/translate.c

[Qemu-devel] [PULL 10/11] lm32_sys: print test result on stderr

2013-09-25 Thread Michael Walle
Do not use qemu_log(). Signed-off-by: Michael Walle --- hw/misc/lm32_sys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 8176cdb..6af0cca 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -80,7 +80,7 @@ static void

[Qemu-devel] [PULL 08/11] target-lm32: move model features to LM32CPU

2013-09-25 Thread Michael Walle
This allows us to completely remove CPULM32State from DisasContext. Instead, copy the fields we need to DisasContext. Cc: Andreas Färber Signed-off-by: Michael Walle --- target-lm32/cpu-qom.h |1 + target-lm32/cpu.h | 12 +--- target-lm32/helper.c| 15

<    1   2   3   4   5   >