Hi Eric,
> On 8 Feb 2024, at 15:55, Eric Auger wrote:
>
> Hi Miguel,
>
> On 2/27/23 17:37, Miguel Luis wrote:
>> This series adds ARMv8.3/8.4 nested virtualization support in KVM mode.
>>
>> To enable nested virtualization for a guest, the host must expose EL2
also works around what Marc Z and I think is
> a KVM bug that otherwise causes boot of the L2 kernel to hang
> * patch 3 is a GIC bug which is not FEAT_NV specific but for
> some reason only manifests when booting an L1 kernel under NV
>
I've successfully replicated this setup and
> On 6 Dec 2023, at 14:25, Michal Suchánek wrote:
>
> On Wed, Dec 06, 2023 at 01:17:08PM -0100, Miguel Luis wrote:
>> Hi!
>>
>> On 04/12/2023 18:40, Philippe Mathieu-Daudé wrote:
>>> Unplugging vCPU triggers the following assertion in
>>
Hi!
On 04/12/2023 18:40, Philippe Mathieu-Daudé wrote:
> Unplugging vCPU triggers the following assertion in
> tcg_register_thread():
>
> 796 void tcg_register_thread(void)
> 797 {
> ...
> 812 /* Claim an entry in tcg_ctxs */
> 813 n = qatomic_fetch_inc(_cur_ctxs);
> 814
> On 16 Oct 2023, at 10:01, Miguel Luis wrote:
>
> Hi Salil,
>
>> On 16 Oct 2023, at 09:52, Salil Mehta wrote:
>>
>> Hi Miguel,
>>
>>> From: Miguel Luis
>>> Sent: Friday, October 13, 2023 5:34 PM
>>> To: Salil Mehta
&
Hi Salil,
> On 16 Oct 2023, at 09:52, Salil Mehta wrote:
>
> Hi Miguel,
>
>> From: Miguel Luis
>> Sent: Friday, October 13, 2023 5:34 PM
>> To: Salil Mehta
>> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Marc Zyngier
>> ; jean-phili...
5 +-
> include/hw/acpi/cpu_hotplug.h | 4 ++
> include/hw/acpi/generic_event_device.h | 5 ++
> include/hw/core/cpu.h | 1 +
> include/sysemu/kvm.h | 16 +++
> system/physmem.c | 29
> 15 files changed, 184 insertions(+), 27 deletions(-)
>
I tested it for Arm64, make check, boot/reboot, live migration and found no
issues,
so for this, please feel free to add:
Tested-by: Miguel Luis
Thank you,
Miguel
> --
> 2.34.1
>
Hi Salil,
> On 12 Oct 2023, at 17:54, Salil Mehta wrote:
>
> Hi Miguel,
>
>> From: Miguel Luis
>> Sent: Thursday, October 12, 2023 6:02 PM
>> To: Salil Mehta
>> Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; Marc Zyngier
>> ; jean-phili...
d=4481#c5
> [9]
> https://cloud.google.com/kubernetes-engine/docs/concepts/verticalpodautoscaler
> [10]
> https://docs.aws.amazon.com/eks/latest/userguide/vertical-pod-autoscaler.html
> [11] https://lkml.org/lkml/2019/7/10/235
> [12] https://lists.cs.columbia.edu/pipermail/kv
Hi Eric,
Thanks in advance for your comment.
> On 6 Jul 2023, at 08:16, Eric Auger wrote:
>
> Hi Miguel,
>
> On 2/27/23 17:37, Miguel Luis wrote:
>> From: Haibo Xu
>>
>> KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2.
>> EL
Hi Marc,
> On 6 Mar 2023, at 13:32, Marc Zyngier wrote:
>
> On Mon, 06 Mar 2023 14:02:33 +,
> Peter Maydell wrote:
>>
>> On Mon, 27 Feb 2023 at 16:37, Miguel Luis wrote:
>>>
>>> From: Haibo Xu
>>>
>>> Use the
Hi Peter,
> On 6 Mar 2023, at 13:02, Peter Maydell wrote:
>
> On Mon, 27 Feb 2023 at 16:37, Miguel Luis wrote:
>>
>> From: Haibo Xu
>>
>> Use the VGIC maintenance IRQ if VHE is requested. As per the ARM GIC
>> Architecture Specification for
Hi Richard,
> On 27 Feb 2023, at 18:26, Richard Henderson
> wrote:
>
> On 2/27/23 06:37, Miguel Luis wrote:
>> -if (vms->virt && (kvm_enabled() || hvf_enabled())) {
>> +if (vms->virt && (kvm_enabled() || hvf_enabled())
>> +
Hi Richard,
> On 27 Feb 2023, at 18:24, Richard Henderson
> wrote:
>
> On 2/27/23 06:37, Miguel Luis wrote:
>> From: Haibo Xu
>> KVM_CAP_ARM_EL2 must be supported by the cpu to enable ARM_FEATURE_EL2.
>> EL2 bits on ID_AA64PFR0 state unsupported on the v
Hi Cornelia,
> On 27 Feb 2023, at 15:49, Cornelia Huck wrote:
>
> On Mon, Feb 27 2023, Miguel Luis wrote:
>
>> From: Haibo Xu
>>
>> linux-headers define host properties needed for the VMM to interact with
>> KVM, so let's include them *while* they're no
From: Haibo Xu
Introduce query support for KVM_CAP_ARM_EL2.
Ref:
https://lore.kernel.org/qemu-devel/65b8771bfecada08bf02c9cf87c2f0f9cdf943b3.1617281290.git.haibo...@linaro.org/
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
---
target/arm/kvm64.c | 5 +
target/arm/kvm_arm.h | 12
From: Haibo Xu
VHE enablement if host supports EL2.
Ref:
https://lore.kernel.org/qemu-devel/b7c2626e6c720ccc43e57197dff3dac72d613640.1616052890.git.haibo...@linaro.org/
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
---
hw/arm/virt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
-...@kernel.org/
Miguel Luis (5):
linux-headers: [kvm,arm64] add the necessary definitions to match host
kernel
hw/intc/gicv3: add support for setting KVM vGIC maintenance IRQ
target/arm/kvm: add helper to detect EL2 when using KVM
target/arm: enable feature ARM_FEATURE_EL2 if EL2
://lore.kernel.org/qemu-devel/49a4944e2f148c56938380b981afe154b7a8b7ee.1617281290.git.haibo...@linaro.org/
Signed-off-by: Haibo Xu
[Miguel Luis: avoid direct usage of helpers (_check_attr(); _access())]
Signed-off-by: Miguel Luis
---
hw/arm/virt.c | 5 +
hw/intc
/636b5932e4cf061b6f97516e82d4319c1d29b871.1616052889.git.haibo...@linaro.org/
Signed-off-by: Haibo Xu
Signed-off-by: Miguel Luis
---
linux-headers/asm-arm64/kvm.h | 2 ++
linux-headers/linux/kvm.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm64/kvm.h
[Miguel Luis: use of ID_AA64PFR0 for cpu features]
Signed-off-by: Miguel Luis
---
target/arm/cpu.h | 2 +-
target/arm/kvm64.c | 16
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 9aeed3c848..de2a88b43e 100644
--- a/target
//
00F0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 //
-0100: 00 00 00 00 00 00 00 00 00 00 00 00 //
+0100: 00 00 00 00 00 00 00 00 00 00 00 00 51 45 4D 55 // QEMU
+0110: 00 00 00 00
MADT has been updated with the GIC Structures from ACPI 6.0 Errata A
and so MADT revision and GICC Structure must be updated also.
Fixes: 37f33084ed2e ("acpi: arm/virt: madt: use build_append_int_noprefix() API
to compose MADT table")
Signed-off-by: Miguel Luis
Reviewed-by: Ani Sinh
/sites/default/files/resources/ACPI_6_0_Errata_A.PDF
This patch series originates from a previous RFC [1] discussion. Reviewed-by
tags were kept on patches 2/4 and 3/4.
[1]: https://lists.gnu.org/archive/html/qemu-devel/2022-10/msg01326.html
Miguel Luis (4):
tests/acpi: virt: allow acpi MADT and
a
supplemental vendor-specific hypervisor API. Firmware implementers would
place zero bytes into this field, denoting that no hypervisor is present in
the actual firmware."
Signed-off-by: Miguel Luis
Reviewed-by: Ani Sinha
---
hw/acpi/aml-build.c | 13 ++---
hw/arm/vi
Step 3 from bios-tables-test.c documented procedure.
Signed-off-by: Miguel Luis
---
tests/qtest/bios-tables-test-allowed-diff.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b
> On 11 Oct 2022, at 05:02, Ani Sinha wrote:
>
> On Mon, Oct 10, 2022 at 6:53 PM Miguel Luis wrote:
>>
>> Update the Fixed ACPI Description Table (FADT) to revision 6.0 of the ACPI
>> specification adding the field "Hypervisor Vendor Identity" that was mis
i Sinha's suggestion [2] of using "QEMU" for the
hypervisor vendor ID.
[1]: https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg00911.html
[2]: https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg00989.html
Signed-off-by: Miguel Luis
---
hw/acpi/aml-build.c | 13 +
//
00F0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 //
-0100: 00 00 00 00 00 00 00 00 00 00 00 00 //
+0100: 00 00 00 00 00 00 00 00 00 00 00 00 51 45 4D 55 // QEMU
+0110: 00 00 00 00
elcome.
Thanks in advance.
Miguel
[1]: https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg00989.html
Miguel Luis (4):
tests/acpi: virt: allow acpi MADT and FADT changes
acpi: fadt: support revision 6.0 of the ACPI specification
acpi: arm/
MADT has been updated with the GIC Structures from ACPI 6.0 Errata A
and so MADT revision and GICC Structure must be updated also.
Fixes: 37f33084ed2e ("acpi: arm/virt: madt: use build_append_int_noprefix() API
to compose MADT table")
Signed-off-by: Miguel Luis
Reviewed-by: Ani Sinh
Step 3 from bios-tables-test.c documented procedure.
Signed-off-by: Miguel Luis
---
tests/qtest/bios-tables-test-allowed-diff.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b
> On 7 Oct 2022, at 15:21, Ani Sinha wrote:
>
> On Fri, Oct 7, 2022 at 8:16 PM Miguel Luis wrote:
>>
>> The ACPI GTDT table contains two invalid 64-bit physical addresses according
>> to
>> the ACPI spec. 6.5 [1]. Those are the Counter Control Base physic
00 00 00 00 00 00 00 1A 00 00 00 00 00 00 00 //
-0050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 //
+0050: FF FF FF FF FF FF FF FF 00 00 00 00 00 00 00 00 //
Signed-off-by: Miguel Luis
Acked-by: Ani Sinha
---
tests/data/acpi/virt
Step 3 from bios-tables-test.c documented procedure.
Signed-off-by: Miguel Luis
Acked-by: Ani Sinha
---
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
0x0.
[1]:
https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#gtdt-table-structure
Changelog:
v2:
Updated with collected tags from v1.
v1: https://lists.nongnu.org/archive/html/qemu-devel/2022-09/msg02847.html
Miguel Luis (3):
tests/acpi: virt: allow acpi GTDT changes
begin()/acpi_table_end() instead of build_header()")
Signed-off-by: Miguel Luis
Reviewed-by: Ani Sinha
---
hw/arm/virt-acpi-build.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 9b3aee01bf..13c6e3e468 100644
--
> On 21 Sep 2022, at 03:39, Ani Sinha wrote:
>
>
>
> On Tue, 20 Sep 2022, Miguel Luis wrote:
>
>> Step 6 & 7 of the bios-tables-test.c documented procedure.
>>
>> Differences between disassembled ASL files for GTDT:
>>
&
Hi Ani,
> On 7 Oct 2022, at 04:25, Ani Sinha wrote:
>
>
>
> On Thu, 6 Oct 2022, Miguel Luis wrote:
>
>> Update the Fixed ACPI Description Table (FADT) to revision 6.0 of the ACPI
>> specification adding the field "Hypervisor Vendor Identity" that was
0 00 00 00 00 //
-0100: 00 00 00 00 00 00 00 00 00 00 00 00 //
+0100: 00 00 00 00 00 00 00 00 00 00 00 00 74 63 67 00 // tcg.
+0110: 00 00 00 00 //
Signed-off-by: Miguel Luis
---
tests/
MADT has been updated with the GIC Structures from ACPI 6.0 Errata A
and so MADT revision and GICC Structure must be updated also.
Fixes: 37f33084ed2e ("acpi: arm/virt: madt: use build_append_int_noprefix() API
to compose MADT table")
Signed-off-by: Miguel Luis
---
hw/arm/virt-ac
ion name. This would
provide values like 'KVM' for example when KVM is used.
Ref: https://uefi.org/sites/default/files/resources/ACPI_6_0_Errata_A.PDF
Open to discussion, your comments, thoughts and suggestions are very welcome.
Thanks in advance.
Miguel
Miguel Luis (4):
tests/acpi: virt: allo
ide that information?
On this RFC there's the suggestion of having this information in sync by the
current acceleration name. This also seems to imply that QEMU, which generates
the FADT table, and the FADT consumer need to be in sync with the values of this
field.
Signed-off-by: Miguel Luis
---
Step 3 from bios-tables-test.c documented procedure.
Signed-off-by: Miguel Luis
---
tests/qtest/bios-tables-test-allowed-diff.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b
Step 3 from bios-tables-test.c documented procedure.
Signed-off-by: Miguel Luis
---
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h
b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b
00 00 00 00 00 00 00 1A 00 00 00 00 00 00 00 //
-0050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 //
+0050: FF FF FF FF FF FF FF FF 00 00 00 00 00 00 00 00 //
Signed-off-by: Miguel Luis
---
tests/data/acpi/virt/GTDT
begin()/acpi_table_end() instead of build_header()")
Signed-off-by: Miguel Luis
---
hw/arm/virt-acpi-build.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 9b3aee01bf..13c6e3e468 100644
--- a/hw/arm/virt-acpi-bui
0x0.
[1]:
https://uefi.org/specs/ACPI/6.5/05_ACPI_Software_Programming_Model.html#gtdt-table-structure
Miguel Luis (3):
tests/acpi: virt: allow acpi GTDT changes
acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses
tests/acpi: virt: update ACPI GTDT binaries
hw/arm/virt-acpi
48 matches
Mail list logo
