[Qemu-devel] [PATCH] block/xen_disk: Convert atoi use to qemu_strtol to allow error checking

2018-03-16 Thread Nia Alarie
Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- hw/block/xen_disk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index f74fcd42d1..a9ec0ad6eb 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -32,6

[Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

2018-03-16 Thread Nia Alarie
If qemu_strtoi indicates an error, return the default value. Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- audio/audio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 6eccdb17ee..d6e91901aa 100644 --- a/audio/audio.c +++ b

[Qemu-devel] [PATCH] net/slirp: Convert atoi to qemu_strtoi to allow error checking

2018-03-16 Thread Nia Alarie
Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- net/slirp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index 8991816bbf..e938944bd4 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -486,7 +486,9 @@ void hmp_hostfwd_remove(Monitor *mon,

[Qemu-devel] [PATCH v2] 9p: Convert use of atoi to qemu_strtoi to allow error checking

2018-03-12 Thread Nia Alarie
Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- hw/9pfs/9p.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 48fa48e720..254385dfa4 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -15,6 +15,7 @@ #include #include &quo

[Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-11 Thread Nia Alarie
Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- hw/9pfs/9p.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 48fa48e720..64f3bb976c 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -15,6 +15,7 @@ #include #inclu

[Qemu-devel] [PATCH] s390x/virtio: Convert virtio-ccw from *_exit to *_unrealize

2018-03-07 Thread Nia Alarie
Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- hw/s390x/virtio-ccw.c | 34 +- hw/s390x/virtio-ccw.h | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 8f7fbc2ab7..e51fbefd23

[Qemu-devel] [PATCH v3 2/2] s390x: Change return type of virtio_ccw_exit to void.

2018-03-06 Thread Nia Alarie
Allows a branch to be removed - this function always returns 0. Signed-off-by: Nia Alarie <nia.ala...@gmail.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> --- hw/s390x/virtio-ccw.c | 6 +++--- hw/s390x/virtio-ccw.h | 2 +- 2 files changed, 4 insertions(+), 4 deleti

[Qemu-devel] [PATCH v3 1/2] s390x/sclpconsole: Remove dead code - remove exit handlers

2018-03-06 Thread Nia Alarie
The other event handlers (quiesce and cpu) do not define these handlers, and this one does nothing, so it can be removed. Signed-off-by: Nia Alarie <nia.ala...@gmail.com> Reviewed-by: Christian Borntraeger <borntrae...@de.ibm.com> --- hw/char/sclpconsole-lm.c | 6 ---

[Qemu-devel] [PATCH v2] s390x/sclpconsole: Remove dead code - delete error handlers

2018-03-05 Thread Nia Alarie
The other event handlers (quiesce and cpu) do not define these handlers, and this one does nothing, so it can be removed. virtio_ccw_exit always returns 0, so change its return type to void. Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- hw/char/sclpconsole-lm.c | 6

[Qemu-devel] [PATCH] s390x/sclpconsole: Remove dead code - make _error functions void

2018-03-04 Thread Nia Alarie
These functions always return 0. By changing their return type to void, some dead code can be removed. Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- hw/char/sclpconsole-lm.c | 3 +-- hw/char/sclpconsole.c | 3 +-- hw/s390x/event-facility.c | 6 +- hw

[Qemu-devel] [PATCH] PPC: e500: Add check for NULL return value from qemu_find_file.

2018-03-03 Thread Nia Alarie
This prints a message and exits if the e500 BIOS firmware can't be found, to avoid dereferencing a null pointer. Signed-off-by: Nia Alarie <nia.ala...@gmail.com> --- hw/ppc/e500.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index a40d3ec3e3..6ce0