Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

On Mon, Feb 17, 2020 at 06:03:40AM -0600, Eric Blake wrote: > On 2/17/20 2:06 AM, Niels de Vos wrote: > > On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote: > > > block.c already defaults to 0 if we don't provide a callback; there's > > > no need to write a

Re: [GEDI] [PATCH 12/17] gluster: Support BDRV_ZERO_OPEN

On Fri, Jan 31, 2020 at 11:44:31AM -0600, Eric Blake wrote: > Since gluster already copies file-posix for lseek usage in block > status, it also makes sense to copy it for learning if the image > currently reads as all zeroes. > > Signed-off-by: Eric Blake > --- > block/gluster.c | 20

Re: [GEDI] [PATCH 07/17] gluster: Drop useless has_zero_init callback

On Fri, Jan 31, 2020 at 11:44:26AM -0600, Eric Blake wrote: > block.c already defaults to 0 if we don't provide a callback; there's > no need to write a callback that always fails. > > Signed-off-by: Eric Blake Reviewed-by: Niels de Vos > --- > block/gluster.c | 14 --

Re: [Qemu-devel] [PATCH] block: gluster: Probe alignment limits

On Wed, Aug 21, 2019 at 07:04:17PM +0200, Max Reitz wrote: > On 17.08.19 23:21, Nir Soffer wrote: > > Implement alignment probing similar to file-posix, by reading from the > > first 4k of the image. > > > > Before this change, provisioning a VM on storage with sector size of > > 4096 bytes would

Re: [Qemu-devel] [PATCH 1/6] configure: Only generate GLUSTERFS variables if glusterfs is usable

On Fri, Jun 14, 2019 at 09:24:27AM +0200, Philippe Mathieu-Daudé wrote: > It is pointless and confusing to have GLUSTERFS variables > in config-host.mak when glusterfs is not usable. > > Signed-off-by: Philippe Mathieu-Daudé Looks good to me, thanks. Reviewed-by:

Re: [Qemu-devel] [QEMU PATCH] MAINTAINERS: Downgrade status of block sections without "M:" to "Odd Fixes"

/patch/10613297/#22409943 > > Signed-off-by: Thomas Huth Thanks, this counts for the Gluster part: Reviewed-by: Niels de Vos > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 66ddbda9c9..899a4cd5

Re: [Qemu-devel] [Qemu-block] [PATCH RFC] block/gluster: limit the transfer size to 512 MiB

n the Gluster volumes. For VM images shards of 256MB are recommeneded (I think). When sharding is enabled, the writes will be limited to that size as well, hence the problem is not noticed on (most) production deployments. Reviewed-by: Niels de Vos > > > block/gluster.c | 16

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] block: Gluster 6 compatibility

On Mon, Mar 11, 2019 at 12:10:06PM +0100, Kevin Wolf wrote: > Am 09.03.2019 um 10:40 hat Niels de Vos geschrieben: > > On Fri, Mar 08, 2019 at 02:11:51PM +0100, Kevin Wolf wrote: > > > Am 05.03.2019 um 16:46 hat Niels de Vos geschrieben: > > > > Gluster 6 is

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/2] block: Gluster 6 compatibility

On Fri, Mar 08, 2019 at 02:11:51PM +0100, Kevin Wolf wrote: > Am 05.03.2019 um 16:46 hat Niels de Vos geschrieben: > > Gluster 6 is currently available as release candidate. There have been a > > few changes to libgfapi.so that need to be adapted by consuming projects > > like

[Qemu-devel] [PATCH v5 1/2] block/gluster: Handle changed glfs_ftruncate signature

and needs to be adopted. Signed-off-by: Prasanna Kumar Kalever Signed-off-by: Niels de Vos -- v5: pass default NULL arguments through macro (Daniel P. Berrangé) v4: rebase to current master branch v3: define old backwards compatible glfs_ftruncate() macro, from Eric Blake v2: do a compile check

[Qemu-devel] [PATCH v2 0/2] block: Gluster 6 compatibility

). The following two changes should be sufficient to consume Gluster 6 once it is released. These have been tested on CentOS-7 with Gluster 5 and Gluster 6 (minimal manual qemu-img tests only). This v2 post contains changes suggested by Daniel P. Berrangé and Kevin Wolf. Thanks! Cheers, Niels Niels de Vos

[Qemu-devel] [PATCH v2 2/2] gluster: the glfs_io_cbk callback function pointer adds pre/post stat args

that includes these new arguments. With an additional detection in ./configure, the new arguments can conditionally get included in the glfs_io_cbk handler. Signed-off-by: Niels de Vos -- v2: correct typo in commit message (Kevin Wolf) --- block/gluster.c | 6 +- configure | 24

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] gluster: the glfs_io_cbk callback function pointer adds pre/post stat args

On Tue, Mar 05, 2019 at 11:29:34AM +0100, Kevin Wolf wrote: > Am 04.03.2019 um 17:21 hat Niels de Vos geschrieben: > > The glfs_*_async() functions do a callback once finished. This callback > > has changed its arguments, pre- and post-stat structures have been > > added. T

Re: [Qemu-devel] [PATCH 1/2] block/gluster: Handle changed glfs_ftruncate signature

On Mon, Mar 04, 2019 at 04:41:44PM +, Daniel P. Berrangé wrote: > On Mon, Mar 04, 2019 at 05:21:02PM +0100, Niels de Vos wrote: > > From: Prasanna Kumar Kalever > > > > New versions of Glusters libgfapi.so have an updated glfs_ftruncate() > > function that retu

[Qemu-devel] [PATCH 0/2] block: Gluster 6 compatibility

). The following two changes should be sufficient to consume Gluster 6 once it is released. These have been tested on CentOS-7 with Gluster 5 and Gluster 6 (minimal manual qemu-img tests only). Cheers, Niels Niels de Vos (2): block/gluster: Handle changed glfs_ftruncate signature gluster: the glfs_io_cbk

[Qemu-devel] [PATCH 2/2] gluster: the glfs_io_cbk callback function pointer adds pre/post stat args

that includes these new arguments. With an additional detection in ./configure, the new arguments can conditionally get included in the glfs_io_cbk handler. Signed-off-by: Niels de Vos --- block/gluster.c | 6 +- configure | 24 2 files changed, 29 insertions(+), 1

[Qemu-devel] [PATCH 1/2] block/gluster: Handle changed glfs_ftruncate signature

and needs to be adopted. Signed-off-by: Prasanna Kumar Kalever Signed-off-by: Niels de Vos --- v4: rebase to current master branch v3: define old backwards compatible glfs_ftruncate() macro, from Eric Blake v2: do a compile check as suggested by Eric Blake --- block/gluster.c | 11

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer

On Tue, Jan 08, 2019 at 08:12:16PM +0100, Kevin Wolf wrote: > Am 08.01.2019 um 18:18 hat Markus Armbruster geschrieben: > > This patch series got stuck. > > > > Markus Armbruster writes: > > > > > Fam Zheng writes: > > > > > >> On Tue, 09/25 07:00, Markus Armbruster wrote: > > >>> Jeff Cody

Re: [Qemu-devel] [Qemu-block] [PATCH v3 7/9] gluster: Support auto-read-only option

; > +s->fd = glfs_open(s->glfs, gconf->path, open_flags); > +ret = s->fd ? 0 : -errno; > +} > } > > s->supports_seek_data = qemu_gluster_test_seek(s->fd); > -- Looks good to me, thanks. Reviewed-by: Niels de Vos

Re: [Qemu-devel] [Qemu-block] [PATCH v2 7/8] gluster: Support auto-read-only option

On Fri, Oct 12, 2018 at 12:31:21PM -0500, Eric Blake wrote: > On 10/12/18 6:55 AM, Kevin Wolf wrote: > > If read-only=off, but auto-read-only=on is given, open the file > > read-write if we have the permissions, but instead of erroring out for > > read-only files, just degrade to read-only. > > >

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] MAINTAINERS: Remove myself as block maintainer

On Tue, Sep 25, 2018 at 01:32:04PM +0800, Fam Zheng wrote: > On Tue, 09/25 07:00, Markus Armbruster wrote: > > Jeff Cody writes: > > > > > I'll not be involved in day-to-day qemu development. Remove > > > myself as maintainer from the remainder of the network block drivers > > > (and vhdx), and

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

On Tue, Jul 31, 2018 at 03:51:22PM -0400, Jeff Cody wrote: > On Tue, Jul 31, 2018 at 11:18:02AM +0200, Niels de Vos wrote: > > On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote: > > > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > > > > On 07/

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote: > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > > On 07/28/2018 02:50 AM, Niels de Vos wrote: > > >> > > >>Part of me wishes that libgfapi had just created a new function > > >

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

On Sat, Jul 28, 2018 at 12:18:39AM -0400, Jeff Cody wrote: > On Fri, Jul 27, 2018 at 08:24:05AM -0500, Eric Blake wrote: > > On 07/27/2018 03:19 AM, Niels de Vos wrote: > > >From: Prasanna Kumar Kalever > > > > > >New versions of Glusters libgfapi.so have an up

[Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

and needs to be adopted. Signed-off-by: Prasanna Kumar Kalever Signed-off-by: Niels de Vos --- v2: do a compile check as suggested by Eric Blake v3: define old backwards compatible glfs_ftruncate() macro, from Eric Blake --- block/gluster.c | 11 +-- configure | 18 ++ 2

[Qemu-devel] [PATCH v2] block/gluster: defend on legacy ftruncate api use

and needs to be adopted. Signed-off-by: Prasanna Kumar Kalever Signed-off-by: Niels de Vos -- v2: do a compile check as suggested by Eric Blake --- block/gluster.c | 15 +-- configure | 18 ++ 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/block

Re: [Qemu-devel] [PATCH] block/gluster: defend on legacy ftruncate api use

On Thu, Apr 12, 2018 at 11:21:42AM -0500, Eric Blake wrote: > n 04/12/2018 08:31 AM, Niels de Vos wrote: > > This change looks good to me, but a commit message would have been > > helpful. I suggest something like this: > > > > Gluster 4.0 changed the signature of glf

Re: [Qemu-devel] [PATCH] block/gluster: defend on legacy ftruncate api use

library. Thanks! Reviewed-by: Niels de Vos <nde...@redhat.com> On Thu, Apr 12, 2018 at 04:46:14PM +0530, Prasanna Kumar Kalever wrote: > Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> > --- > block/gluster.c | 15 +-- > configure

[Qemu-devel] [PATCH v3] gluster: add support for PREALLOC_MODE_FALLOC

50759 Signed-off-by: Niels de Vos <nde...@redhat.com> --- v3 typo fixes spotted by Jeff Cody and Eric Blake: - typo in the commit message (Eric) - copy/paste mistake causing incorrect if-statement (Jeff) v2 changes requested by Jeff Cody: - add CONFIG_GLUSTERFS_FALLOCATE - remove unneeded wrapper

Re: [Qemu-devel] [PATCH] block/gluster: glfs_lseek() workaround

On Wed, May 24, 2017 at 04:50:03PM -0400, Jeff Cody wrote: > On Wed, May 24, 2017 at 11:02:02AM +0200, Niels de Vos wrote: > > On Tue, May 23, 2017 at 01:27:50PM -0400, Jeff Cody wrote: > > > On current released versions of glusterfs, glfs_lseek() will sometimes > >

Re: [Qemu-devel] [PATCH] block/gluster: glfs_lseek() workaround

in this case, and we'll treat it like H4. Unfortunately some > + * versions of libgfapi will return offs < start, so an assert here > + * will unneccesarily abort QEMU. */ > +return -EIO; > +} > > if (offs > start) { > /* > -- > 2.9.3 > You might want to explain the problem a little different in the commit message. It is fine too if you think it would become too detailed, my explanation is in the archives now in any case. Reviewed-by: Niels de Vos <nde...@redhat.com>

Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

On Thu, May 18, 2017 at 01:54:36PM -0400, Jeff Cody wrote: > On Thu, May 18, 2017 at 11:54:22AM +0200, Niels de Vos wrote: > > Add missing support for "preallocation=falloc" to the Gluster block > > driver. This change bases its logic on that of block/fil

Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

On Thu, May 18, 2017 at 09:30:53AM -0500, Eric Blake wrote: > On 05/18/2017 04:54 AM, Niels de Vos wrote: > > Add missing support for "preallocation=falloc" to the Gluster block > > driver. This change bases its logic on that of block/file-posix.c and > > remove

[Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

50759 Signed-off-by: Niels de Vos <nde...@redhat.com> --- v2 changes requested by Jeff Cody: - add CONFIG_GLUSTERFS_FALLOCATE - remove unneeded wrapper qemu_gluster_zerofill() block/gluster.c | 76 ++--- configure | 6 + 2 files

Re: [Qemu-devel] [PATCH] gluster: add support for PREALLOC_MODE_FALLOC

On Tue, May 16, 2017 at 11:42:37AM -0400, Jeff Cody wrote: > On Mon, May 15, 2017 at 09:11:36PM +0200, Niels de Vos wrote: > > Add missing support for "preallocation=falloc" to the Gluster block > > driver. This change bases its logic on that of block/fil

[Qemu-devel] [PATCH] gluster: add support for PREALLOC_MODE_FALLOC

aramoorthi <sasun...@redhat.com> URL: https://bugzilla.redhat.com/1450759 Signed-off-by: Niels de Vos <nde...@redhat.com> --- block/gluster.c | 61 +++-- 1 file changed, 38 insertions(+), 23 deletions(-) diff --git a/block/gluster.c b

Re: [Qemu-devel] [Qemu-block] [PATCH 14/31] gluster: Switch to .bdrv_co_block_status()

t; block/gluster.c | 47 +++ > 1 file changed, 23 insertions(+), 24 deletions(-) Looks good to me, thanks. Reviewed-by: Niels de Vos <nde...@redhat.com> > diff --git a/block/gluster.c b/block/gluster.c > index 1d4e2f7..3f252c6 100644 > --- a/block/gluster.c >

Re: [Qemu-devel] [Qemu-block] [PATCH 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json()

On Fri, Mar 03, 2017 at 09:35:16AM +0100, Markus Armbruster wrote: > Niels de Vos <nde...@redhat.com> writes: > > > On Fri, Mar 03, 2017 at 08:38:45AM +0100, Markus Armbruster wrote: > >> Niels de Vos <nde...@redhat.com> writes: > >> > >>

Re: [Qemu-devel] [Qemu-block] [PATCH 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json()

On Fri, Mar 03, 2017 at 08:38:45AM +0100, Markus Armbruster wrote: > Niels de Vos <nde...@redhat.com> writes: > > > On Thu, Mar 02, 2017 at 10:44:03PM +0100, Markus Armbruster wrote: > >> To reproduce, run > >> > >> $ valgrind qemu-system-x86_64

Re: [Qemu-devel] [Qemu-block] [PATCH 12/15] gluster: Plug memory leaks in qemu_gluster_parse_json()

On Thu, Mar 02, 2017 at 10:44:03PM +0100, Markus Armbruster wrote: > To reproduce, run > > $ valgrind qemu-system-x86_64 --nodefaults -S --drive > driver=gluster,volume=testvol,path=/a/b/c,server.0.type=xxx > > Signed-off-by: Markus Armbruster > --- > block/gluster.c |

Re: [Qemu-devel] [Qemu-block] [PATCH 10/15] gluster: Drop assumptions on SocketTransport names

;u.tcp.host, > (int)port); > } > -- > 2.7.4 Instead of the strings for "unix" and "tcp", I would have liked #define's. Unfortunately it seems that these are not available in public headers :-/ If this is easier to understand, I don't have any objections. Reviewed-by: Niels de Vos <nde...@redhat.com>

Re: [Qemu-devel] [Qemu-block] [PATCH 11/15] gluster: Don't duplicate qapi-util.c's qapi_enum_parse()

> -error_setg(_err, QERR_INVALID_PARAMETER_VALUE, > - GLUSTER_OPT_TYPE, "tcp or unix"); > +if (local_err) { > +error_append_hint(_err, > + "Parameter '%s' may be 'tcp' or 'unix'\n", > + GLUSTER_OPT_TYPE); > error_append_hint(_err, GERR_INDEX_HINT, i); > goto out; > } > -- > 2.7.4 > > Looks good to me. Reviewed-by: Niels de Vos <nde...@redhat.com>

Re: [Qemu-devel] [PATCH v2 1/1] block/gluster: memory usage: use one glfs instance per volume

On Thu, Oct 27, 2016 at 08:54:50PM +0530, Prasanna Kumar Kalever wrote: > Currently, for every drive accessed via gfapi we create a new glfs > instance (call glfs_new() followed by glfs_init()) which could consume > memory in few 100 MB's, from the table below it looks like for each > instance

Re: [Qemu-devel] semantics of FIEMAP without FIEMAP_FLAG_SYNC (was Re: [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server)

On Wed, Jul 20, 2016 at 10:30:25PM +1000, Dave Chinner wrote: > On Wed, Jul 20, 2016 at 05:19:37AM -0400, Paolo Bonzini wrote: > > Adding ext4 and XFS guys (Lukas and Dave respectively). As a quick recap, > > the > > issue here is the semantics of FIEMAP and SEEK_HOLE/SEEK_DATA, which we use >

Re: [Qemu-devel] Automated testing of block/gluster.c with upstream Gluster

On Wed, Jun 29, 2016 at 09:39:22AM +0200, Lukáš Doktor wrote: > Dne 28.6.2016 v 17:56 Niels de Vos napsal(a): > > On Tue, Jun 28, 2016 at 05:20:03PM +0200, Lukáš Doktor wrote: > > > Dne 28.6.2016 v 16:10 Kevin Wolf napsal(a): > > > > Am 28.06.2016 um 11:0

Re: [Qemu-devel] Automated testing of block/gluster.c with upstream Gluster

On Tue, Jun 28, 2016 at 05:20:03PM +0200, Lukáš Doktor wrote: > Dne 28.6.2016 v 16:10 Kevin Wolf napsal(a): > > Am 28.06.2016 um 11:02 hat Niels de Vos geschrieben: > > > Hi, > > > > > > it seems we broke the block/gluster.c functionality with a recent patch

Re: [Qemu-devel] Automated testing of block/gluster.c with upstream Gluster

CentOS repositories. Because the tests will run in the CentOS CI, I'd prefer to use as few external tools as possible. Thanks for the idea, Niels > 28 Июн 2016 г. 12:10 пользователь "Niels de Vos" <nde...@redhat.com> > написал: > > > Hi, > > > > it

[Qemu-devel] Automated testing of block/gluster.c with upstream Gluster

Hi, it seems we broke the block/gluster.c functionality with a recent patch in upstream Gluster. In order to prevent this from happening in the future, I would like to setup a Jenkins job that installs a plan CentOS with its version of QEMU, and nightly builds of upstream Gluster. Getting a

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.7 v2 06/17] gluster: Implement .bdrv_lockf

On Fri, Apr 15, 2016 at 11:27:56AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > block/gluster.c | 30 ++ > 1 file changed, 30 insertions(+) The Gluster changes look good to me. Reviewed-by: Niels de Vos <nde...@r

Re: [Qemu-devel] [PATCH for-2.7 1/1] block/gluster: add support for selecting debug logging level

> 3 - Critical > 4 - Error > 5 - Warning > 6 - Notice > 7 - Info > 8 - Debug > 9 - Trace > > (From: glusterfs/logging.h) > > Signed-off-by: Jeff Cody <jc...@redhat.com> Thanks, this is something I wanted to get done for a long time

Re: [Qemu-devel] [PATCH for-2.6 1/2] block/gluster: return correct error value

ror being EPERM (i.e. 1). Instead, set > it to the proper error result. > > Signed-off-by: Jeff Cody <jc...@redhat.com> Looks good to me. Reviewed-by: Niels de Vos <nde...@redhat.com> > --- > block/gluster.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [Qemu-devel] [PATCH for-2.6 2/2] block/gluster: prevent data loss after i/o error

On Wed, Apr 06, 2016 at 08:44:18AM -0400, Jeff Cody wrote: > On Wed, Apr 06, 2016 at 01:02:16PM +0200, Kevin Wolf wrote: > > [ Adding some CCs ] > > > > Am 06.04.2016 um 05:29 hat Jeff Cody geschrieben: > > > Upon receiving an I/O error after an fsync, by default gluster will > > > dump its

Re: [Qemu-devel] [PATCH v3] block/gluster: add support for SEEK_DATA/SEEK_HOLE

On Tue, Mar 15, 2016 at 03:52:02PM -0400, Jeff Cody wrote: > On Tue, Mar 15, 2016 at 03:50:17PM -0400, Jeff Cody wrote: > > On Thu, Mar 10, 2016 at 07:38:00PM +0100, Niels de Vos wrote: > > > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes > > > i

[Qemu-devel] [PATCH v3] block/gluster: add support for SEEK_DATA/SEEK_HOLE

GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes it possible to detect sparse areas in files. Signed-off-by: Niels de Vos <nde...@redhat.com> --- Tested by compiling and running "qemu-img map gluster://..." with a build of the current master branch of

Re: [Qemu-devel] [PATCH v2] block/gluster: add support for SEEK_DATA/SEEK_HOLE

On Wed, Mar 09, 2016 at 10:46:02AM -0500, Jeff Cody wrote: > On Wed, Mar 09, 2016 at 01:30:14PM +0100, Niels de Vos wrote: > > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes > > it possible to detect sparse areas in files. > > > > Signe

[Qemu-devel] [PATCH v2] block/gluster: add support for SEEK_DATA/SEEK_HOLE

GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes it possible to detect sparse areas in files. Signed-off-by: Niels de Vos <nde...@redhat.com> --- Tested by compiling and running "qemu-img map gluster://..." with a build of the current master branch of

Re: [Qemu-devel] [Qemu-block] [PATCH] block/gluster: add support for SEEK_DATA/SEEK_HOLE

On Tue, Mar 08, 2016 at 01:53:26PM +0100, Kevin Wolf wrote: > Am 08.03.2016 um 05:21 hat Niels de Vos geschrieben: > > On Mon, Mar 07, 2016 at 01:27:38PM -0500, Jeff Cody wrote: > > > On Mon, Mar 07, 2016 at 07:04:15PM +0100, Niels de Vos wrote: > > > > GlusterFS 3.8

Re: [Qemu-devel] [Qemu-block] [PATCH] block/gluster: add support for SEEK_DATA/SEEK_HOLE

On Tue, Mar 08, 2016 at 07:33:26AM -0500, Jeff Cody wrote: > On Tue, Mar 08, 2016 at 05:21:48AM +0100, Niels de Vos wrote: > > On Mon, Mar 07, 2016 at 01:27:38PM -0500, Jeff Cody wrote: > > > On Mon, Mar 07, 2016 at 07:04:15PM +0100, Niels de Vos wrote: > > > >

Re: [Qemu-devel] [Qemu-block] [PATCH] block/gluster: add support for SEEK_DATA/SEEK_HOLE

On Mon, Mar 07, 2016 at 01:27:38PM -0500, Jeff Cody wrote: > On Mon, Mar 07, 2016 at 07:04:15PM +0100, Niels de Vos wrote: > > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes > > it possible to detect sparse areas in files. > > > > Signe

Re: [Qemu-devel] glusterfs-api.pc versioning breaks QEMU

On Thu, Apr 09, 2015 at 06:12:38PM +0200, Andreas Färber wrote: Hello, Hi! Sorry for the late response, I'm travelling and have a rather full agenda. Testing QEMU v2.3.0-rc2, I have run into QEMU's glusterfs support being broken on openSUSE Tumbleweed, resulting in its configure complaining:

Re: [Qemu-devel] [PATCH 1/1] Use pci.0 as bus-name for PCI-busses like qemu-kvm does already

On Sat, Jan 29, 2011 at 9:44 PM, Blue Swirl blauwir...@gmail.com wrote: On Fri, Jan 28, 2011 at 3:54 PM, Niels de Vos de...@fedoraproject.org wrote: From: Niels de Vos ni...@nixpanic.net This should fix issues with qemu-system-{arm,ppc} and possibly others where libvirt passes bus=pci.0

Re: [Qemu-devel] [PATCH 0/1] qemu-system-$ARCH incompatible with qemu-kvm and bus=pci.0 parameter

On Fri, Jan 28, 2011 at 4:12 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Jan 28, 2011 at 03:54:01PM +, Niels de Vos wrote: Hi there, obviously qemu-system-$ARCH, qemu-kvm and libvirt disagree about the most suitable name for the PCI-bus. qemu-kvm and libvirt work nicely

[Qemu-devel] [PATCH 0/1] qemu-system-$ARCH incompatible with qemu-kvm and bus=pci.0 parameter

solution would be to match any bus-names from the command line appended with .0 to their non-numbered equivalent. I'm looking for thoughts and guidance on this issue. It can well be that qemu is not the right place to fix this, and I should look into libvirt instead. Many thanks, Niels -- Niels de

[Qemu-devel] [PATCH 1/1] Use pci.0 as bus-name for PCI-busses like qemu-kvm does already

From: Niels de Vos ni...@nixpanic.net This should fix issues with qemu-system-{arm,ppc} and possibly others where libvirt passes bus=pci.0 in the -device options. Reference: - https://bugzilla.redhat.com/show_bug.cgi?id=667345 Signed-off-by: Niels de Vos de...@fedoraproject.org --- hw

[Qemu-devel] [PATCH] Fix compiler warning on parsing the -usbdevice parameter

-off-by: Niels de Vos nixpa...@users.sourceforge.net diff --git a/hw/usb-bus.c b/hw/usb-bus.c index 89e2ea6..d058e14 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -275,7 +275,7 @@ USBDevice *usbdevice_create(const char *cmdline) len = sizeof(driver); pstrcpy(driver, len

[Qemu-devel] Re: [PATCH] Fix compiler warning on parsing the -usbdevice parameter

Ah, just noticed this warning is only in Jans git... For those who were wondering :) Cheers, Niels On 3/7/10, Niels de Vos nixpa...@users.sourceforge.net wrote: With the added checks on the parameter for -usbdevice, the following warning got introduced: hw/usb-bus.c: In function

Re: [Qemu-devel] Re: EHCI support in QEMU

On Wed, Mar 3, 2010 at 11:58 PM, David S. Ahern daah...@cisco.com wrote: On 03/03/2010 04:47 PM, Jan Kiszka wrote: Thanks for your work, David and Niels! I assume that David based this on Niels' patch, so there is nothing to be merged? David's version built for me, so I pushed      

Re: [Qemu-devel] Re: EHCI support in QEMU

Hello Jan and Taimoor, On Mon, Feb 15, 2010 at 9:36 AM, Jan Kiszka jan.kis...@siemens.com wrote: I downloaded version 0.12.2 of QEMU and I am unable to find EHCI support in it. Does QEMU support EHCI emulation? Do I need to download some other patch for it? QEMU documentation also does not