On Mon, Mar 11, 2024 at 18:51:18 +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 11.03.24 00:07, Peter Krempa wrote:
> > On Thu, Mar 07, 2024 at 22:42:56 +0300, Vladimir Sementsov-Ogievskiy wrote:
[...]
> > Libvirt can adapt to any option that will give us the above seman
On Thu, Mar 07, 2024 at 22:42:56 +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 04.03.24 14:09, Peter Krempa wrote:
> > On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
> > > Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > > On 03.
On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
> Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > On 03.11.23 18:56, Markus Armbruster wrote:
> > > Kevin Wolf writes:
[...]
> > > Is the job abstraction a failure?
> > >
> > > We have
> > >
> > >
On Thu, Jan 11, 2024 at 17:46:50 +0100, Thomas Huth wrote:
> We can get rid of the "power5+" / "power7+" hack in qom/object.c
> by using CPU aliases for those names instead (first patch).
>
> I think in the long run, we should get rid of the names with a "+"
> in it completely, so the second
On Tue, Dec 05, 2023 at 18:14:40 +0100, Peter Krempa wrote:
> Please see patches for rationale.
>
> Libvirt patches using this new flag will be posted soon-ish (after
> cleanup).
>
> v3:
> - changed name of flag to 'backing-mask-protocol' (Eric)
> - decided to k
On Tue, Dec 05, 2023 at 18:14:40 +0100, Peter Krempa wrote:
> Please see patches for rationale.
>
> Libvirt patches using this new flag will be posted soon-ish (after
> cleanup).
https://lists.libvirt.org/archives/list/de...@lists.libvirt.org/message/GCCZP5ANYTPVXCIEYGSM5NWYCGDL23V6/
versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/monitor/block-hmp-cmds.c | 2 +-
block/stream.c | 10 +-
blockdev.c
versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block.c| 37 +-
block/commit.c | 6
in 'hmp_block_stream'
- changed version in docs to 9.0 as getting this into RC 3 probably
isn't realistic
Peter Krempa (2):
block: commit: Allow users to request only format driver names in
backing file format
block: stream: Allow users to request only format driver names in
backing file format
On Thu, Nov 30, 2023 at 13:24:18 -0600, Eric Blake wrote:
> On Thu, Nov 30, 2023 at 05:06:03PM +0100, Peter Krempa wrote:
> > Introduce a new flag 'backing_file_format_no_protocol' for the
> > block-commit QMP command which instructs the internals to use 'raw'
> > instead o
with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/monitor/block-hmp-cmds.c | 2 +-
block/stream.c | 10
Please see patches for rationale.
Libvirt patches using this new flag will be posted soon-ish (after
cleanup).
v2:
- fixed mistaken argument order in 'hmp_block_stream'
- changed version in docs to 9.0 as getting this into RC 3 probably
isn't realistic
Peter Krempa (2):
block: commit
with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block.c| 37 +-
block/commit.c
On Tue, Nov 28, 2023 at 20:10:10 +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 24.11.23 17:52, Peter Krempa wrote:
> > Introduce a new flag 'backing_file_format_no_protocol' for the
> > block-commit QMP command which instructs the internals to use 'raw'
> > instead of the pr
with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
---
block.c| 37 +-
block/commit.c | 6 -
blockdev.c
Please see patches for rationale.
Libvirt patches using this new flag will be posted soon-ish (after
cleanup).
Peter Krempa (2):
block: commit: Allow users to request only format driver names in
backing file format
block: stream: Allow users to request only format driver names
with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
---
block/monitor/block-hmp-cmds.c | 2 +-
block/stream.c | 10 +-
blockdev.c | 7
On Thu, Sep 14, 2023 at 09:44:16 +, Миронов Сергей Владимирович wrote:
> No checks, dereferencing possible.
>
>
> Return value of a function 'virDomainChrSourceDefNew'
> is dereferenced at qemu_command.c without checking
> for NULL, but it is usually checked for this function.
This
CC-ing qemu-devel with a patch solely for libvirt doesn't make sense.
Also 'libvirt-security' list is private and is is intended as a first
contact list for stuff to be embargoed. It makes little sense to include
it when posting to the public 'libvir-list'.
On Thu, Sep 14, 2023 at 09:44:13
The 15.3 version is EOL now:
https://get.opensuse.org/leap/15.3
Switch the dockerfile to 15.4.
Signed-off-by: Peter Krempa
Reviewed-by: Daniel P. Berrangé
---
tests/docker/dockerfiles/opensuse-leap.docker | 8 ++---
tests/lcitool/mappings.yml| 36
Update to commit which has fixes needed for OpenSUSE 15.4 and
re-generate output files.
Signed-off-by: Peter Krempa
---
.gitlab-ci.d/cirrus/freebsd-12.vars | 16 ++
.gitlab-ci.d/cirrus/freebsd-13.vars | 16 ++
.gitlab-ci.d/cirrus/macos-12.vars | 16 ++
tests
v2:
- update 'libvirt-ci' submodule first
- fix forgotten explicit mappings for 15.4
Peter Krempa (2):
tests: libvirt-ci: Update to commit '51dad419'
tests: lcitool: Switch to OpenSUSE Leap 15.4
.gitlab-ci.d/cirrus/freebsd-12.vars | 16 ++
.gitlab-ci.d/cirrus/freebsd-13.vars
The 15.3 version is EOL now:
https://get.opensuse.org/leap/15.3
Switch the dockerfile to 15.4.
Signed-off-by: Peter Krempa
---
tests/docker/dockerfiles/opensuse-leap.docker | 25 +--
tests/lcitool/refresh | 2 +-
2 files changed, 13 insertions(+), 14
On Tue, Mar 07, 2023 at 10:40:23 +0100, Markus Armbruster wrote:
> [Resent with cc: qemu-devel and adjusted subject, sorry for the noise]
>
> abologna at redhat.com (Andrea Bolognani) writes:
>
> > On Mon, Feb 27, 2023 at 06:25:23PM +0100, Peter Krempa wrote:
> >> On
On Tue, Feb 28, 2023 at 09:12:34 +0100, Peter Krempa wrote:
> Report which machine types support ACPI so that management applications
> can properly use the 'acpi' property even on platforms such as ARM where
> support for ACPI depends on the machine type and thus checking presence
>
-by: Peter Krempa
Acked-by: Markus Armbruster
---
Diff to v1:
- Fix spelling of 'ACPI' in 'machine.json'
- Removed addition of a field to 'struct MachineClass' which was not
used in the final version
hw/core/machine-qmp-cmds.c | 1 +
qapi/machine.json | 4 +++-
2 files changed, 4
-by: Peter Krempa
---
Libvirt intends to use this information to unbreak configs of ARM
machines with machine type which doesn't support ACPI. Historically
we'd use '-no-acpi' as the default was to enable ACPI. Conversion
to the modern equivalent '-machine acpi=' unfortunately didn't really
allow
---
> v2: Fixed stypid copy-n-paste bug (Thanks to Sunil for spotting it!)
>
> docs/about/deprecated.rst | 6 ++
> softmmu/vl.c | 1 +
> 2 files changed, 7 insertions(+)
For now libvirt is still using '-no-acpi' but it will be an easy fix.
I'll send patches on monday. On behalf of libvirt:
Reviewed-by: Peter Krempa
On Tue, Feb 14, 2023 at 09:54:22 +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Mon, Feb 13, 2023 at 05:01:01PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> >> The device field is redundant, because QOM path always include device
> >> ID when this ID exist.
> >
> >
On Mon, Jan 23, 2023 at 15:01:37 +0100, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > After recent header file inclusion rework the build fails when the blkio
> > module is enabled:
> >
> > ../block/blkio.c: In function ‘blkio_detach_aio_context’:
>
));
| ^~~~
| |
| int
Fix it by including 'block/block-io.h' which contains the required
declarations.
Fixes: e2c1c34f139f49ef909bb4322607fb8b39002312
Signed-off-by: Peter Krempa
---
block/blkio.c | 2 ++
1 file
On Thu, Dec 29, 2022 at 12:49:13 +0100, Thomas Huth wrote:
> The HPET setting has been turned into a machine property a while ago
> already, so we should finally do the next step and deprecate the
> legacy CLI option, too.
>
> Signed-off-by: Thomas Huth
> ---
> v2:
> - Rebased to current
On Wed, Jul 27, 2022 at 21:33:40 +0200, Kevin Wolf wrote:
> Am 08.07.2022 um 06:17 hat Stefan Hajnoczi geschrieben:
> > libblkio (https://gitlab.com/libblkio/libblkio/) is a library for
> > high-performance disk I/O. It currently supports io_uring and
> > virtio-blk-vhost-vdpa with additional
On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote:
> Libvirt provides QMP passthrough APIs for the QEMU driver and these are
> exposed in virsh. It is not especially pleasant, however, using the raw
> QMP JSON syntax. QEMU has a tool 'qmp-shell' which can speak QMP and
> exposes a
On Fri, May 27, 2022 at 12:35:45 +0200, Claudio Fontana wrote:
> On 5/27/22 12:20 PM, Peter Krempa wrote:
> > On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote:
> >> Libvirt provides QMP passthrough APIs for the QEMU driver and these are
> >> exposed in
On Fri, May 27, 2022 at 10:47:58 +0100, Daniel P. Berrangé wrote:
> Libvirt provides QMP passthrough APIs for the QEMU driver and these are
> exposed in virsh. It is not especially pleasant, however, using the raw
> QMP JSON syntax. QEMU has a tool 'qmp-shell' which can speak QMP and
> exposes a
> ---
> target/i386/cpu.c | 4 ++--
> target/i386/cpu.h | 2 ++
> target/i386/kvm/kvm-cpu.c | 19 ++++---
> 3 files changed, 16 insertions(+), 9 deletions(-)
Tested-by: Peter Krempa
With this patch it no longer abort()s on my Ryzen 3900X
On Sun, Mar 20, 2022 at 20:39:14 +0100, Paolo Bonzini wrote:
> KVM support for AMX includes a new system attribute, KVM_X86_XCOMP_GUEST_SUPP.
> Commit 19db68ca68 ("x86: Grant AMX permission for guest", 2022-03-15) however
> did not fully consider the behavior on older kernels. First, it warns
>
On Tue, Mar 08, 2022 at 12:34:38 +0100, Paolo Bonzini wrote:
> From: Yang Zhong
>
> Kernel allocates 4K xstate buffer by default. For XSAVE features
> which require large state component (e.g. AMX), Linux kernel
> dynamically expands the xstate buffer only after the process has
> acquired the
On Thu, Feb 24, 2022 at 09:02:02 +, Daniel P. Berrangé wrote:
> On Thu, Feb 24, 2022 at 02:06:53PM +0800, Zhenzhong Duan wrote:
> > While there are mixed use of traditional -device option and JSON
> > syntax option, QEMU reports conflict, e.x:
> >
> > /usr/libexec/qemu-kvm -nodefaults \
> >
On Wed, Feb 23, 2022 at 17:46:49 +0800, Zhenzhong Duan wrote:
> While libvirt does not support all the qemu parameters in standand
> xml syntax, such as hostfwd. We have to use to
> passthrough the parameters. E.x:
>
>
>
>
>
>
On Mon, Feb 07, 2022 at 16:50:28 +0530, Ani Sinha wrote:
> On Mon, Feb 7, 2022 at 3:12 PM Peter Krempa wrote:
> >
> > On Mon, Feb 07, 2022 at 10:36:42 +0100, Peter Krempa wrote:
> > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote:
> > > &g
On Mon, Feb 07, 2022 at 10:36:42 +0100, Peter Krempa wrote:
> On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote:
> > On Mon, 7 Feb 2022 09:14:37 +0100
> > Igor Mammedov wrote:
[...]
> Even if we change it in libvirt right away, changing qemu will break
> forward
On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote:
> On Mon, 7 Feb 2022 09:14:37 +0100
> Igor Mammedov wrote:
>
> > On Sat, 5 Feb 2022 13:45:24 +0100
> > Philippe Mathieu-Daudé wrote:
> >
> > > Previously CPUs were exposed in the QOM tree at a path
> > >
> > >
On Mon, Dec 06, 2021 at 10:02:44 +0100, Thomas Huth wrote:
> On 06/12/2021 09.57, Peter Krempa wrote:
> > On Mon, Dec 06, 2021 at 09:47:58 +0100, Thomas Huth wrote:
> > > On 06/12/2021 09.40, Thomas Huth wrote:
> > > > The HPET setting has been turned into
On Mon, Dec 06, 2021 at 09:47:58 +0100, Thomas Huth wrote:
> On 06/12/2021 09.40, Thomas Huth wrote:
> > The HPET setting has been turned into a machine property a while ago
> > already, so we should finally do the next step and deprecate the
> > legacy CLI option, too.
> > While we're at it, add
On Mon, Nov 08, 2021 at 13:05:10 +0100, Kevin Wolf wrote:
> Am 06.11.2021 um 07:34 hat Markus Armbruster geschrieben:
> > Kevin Wolf writes:
> > > Am 05.11.2021 um 11:08 hat Markus Armbruster geschrieben:
> > >> Kevin Wolf writes:
> > >> > Am 04.11.2021 um 13:13 hat Markus Armbruster
), though I'm not completely sure if we
>have gotten rid of the final users of -drive. (CCing Peter Krempa for
>details.)
Libvirt uses JSON exclusively with -object (starting from qemu-6.0) and
with -device (starting from qemu-6.2).
We could also easily do -netdev if JSON support will be ad
RRP_GUARD()
> - Replaced error handling patch for qdev_set_id() with Damien's
> - Drop the deprecation patch until libvirt uses the new JSON syntax
Series:
Tested-by: Peter Krempa
-by: Peter Krempa
> Markus Armbruster (5):
> qapi: Enable enum member introspection to show more than name
> qapi: Add feature flags to enum members
> qapi: Move compat policy from QObject to generic visitor
> qapi: Implement deprecated-input={reject,crash} for enum values
>
On Fri, Sep 24, 2021 at 11:04:25 +0200, Kevin Wolf wrote:
> Directly call qdev_device_add_from_qdict() for QMP device_add instead of
> first going through QemuOpts and converting back to QDict.
>
> Note that this changes the behaviour of device_add, though in ways that
> should be considered bug
On Thu, Sep 30, 2021 at 16:17:44 -0400, Laine Stump wrote:
> On 9/30/21 1:09 PM, Laurent Vivier wrote:
> > If we want to save a snapshot of a VM to a file, we used to follow the
> > following steps:
> >
> > 1- stop the VM:
> > (qemu) stop
> >
> > 2- migrate the VM to a file:
> > (qemu)
On Mon, Sep 20, 2021 at 11:08:59 +0200, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > On Wed, Sep 15, 2021 at 21:24:21 +0200, Markus Armbruster wrote:
> >> The next commit will add feature flags to enum members. There's a
> >> problem, though: query-q
On Wed, Sep 15, 2021 at 21:24:22 +0200, Markus Armbruster wrote:
> This is quite similar to commit 84ab008687 "qapi: Add feature flags to
> struct members", only for enums instead of structs.
For now in libvirt I've implemented the validator for the 'deprecated'
flag:
On Wed, Sep 15, 2021 at 21:24:21 +0200, Markus Armbruster wrote:
> The next commit will add feature flags to enum members. There's a
> problem, though: query-qmp-schema shows an enum type's members as an
> array of member names (SchemaInfoEnum member @values). If it showed
> an array of objects
On Wed, Aug 04, 2021 at 12:34:31 +0200, Kevin Wolf wrote:
> We could in theory keep allowing redundant completion requests when the
> completion mode doesn't conflict, but I don't see the point of that.
I don't see either. Especially since ...
> Unless libvirt can actually issue multiple
On Thu, Jul 22, 2021 at 16:39:26 +0200, Paolo Bonzini wrote:
> On 22/07/21 10:19, Peter Krempa wrote:
> > This patch breaks detection of certain machine options features in
> > libvirt which were being detected from 'query-command-line-options'.
> >
> > I presum
adding libvirt-list
On Thu, Jul 08, 2021 at 17:17:37 +0200, Paolo Bonzini wrote:
> From: Gerd Hoffmann
>
> Drop one more shared library dependency (libusb) from core qemu.
>
> Signed-off-by: Gerd Hoffmann
> Reviewed-by: Jose R. Ziviani
> Message-Id:
CC libvir-list
On Tue, Jul 06, 2021 at 12:01:37 +0200, Paolo Bonzini wrote:
> Switch from QemuOpts to keyval. This enables the introduction
> of non-scalar machine properties, and JSON syntax in the future.
>
> For JSON syntax to be supported right now, we would have to
> consider what would
On Sat, Jul 17, 2021 at 12:09:20 +0200, Mahmoud Mandour wrote:
> Signed-off-by: Mahmoud Mandour
> ---
> docs/system/deprecated.rst | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index e2e0090878..aaf0ee5777 100644
> ---
d -sdl and -curses top-level options.
>
> Thomas Huth (3):
> softmmu/vl: Add a "grab-mod" parameter to the -display sdl option
> softmmu/vl: Deprecate the old grab options
> softmmu/vl: Deprecate the -sdl and -curses option
libvirt doesn't use any of those old options any more so:
on behalf of libvirt:
ACKed-by: Peter Krempa
Hi,
recently I've got a report that an upgrade of libvirt (and qemu) caused
a guest-visible change in the SCSI disk identification when a very long
serial number is used.
I've traced it back to the point where libvirt started to use the
'device_id=' property of the SCSI disk to pass in the alias
On Wed, May 19, 2021 at 17:32:01 -0400, John Snow wrote:
> Based loosely on libvirt's template, written by Peter Krempa.
>
> CC: Peter Krempa
> Signed-off-by: John Snow
> ---
> .gitlab/issue_templates/bug.md | 52 ++
> 1 file changed, 52 in
On Mon, May 03, 2021 at 13:21:47 -0500, Eric Blake wrote:
> On 4/29/21 4:59 AM, Markus Armbruster wrote:
[...]
> > qemu-img backing file without format (since 5.1)
> >
> >
> > The use of ``qemu-img create``, ``qemu-img rebase``, or
sertions(+), 3593 deletions(-)
> delete mode 100644 block/sheepdog.c
Libvirt will need to adjust one test case (lock it to qemu-6.0 test
data), but other than that, this change is okay with us.
ACKed-by: Peter Krempa
On Fri, Apr 30, 2021 at 09:42:05 +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote:
> >> The scsi=on|off property was deprecated in QEMU 5.0 and can be removed
> >> completely at this point.
> >>
> >> Drop the
code
again to see whether we do the correct thing if it's no longer
available.
>
> Cc: Markus Armbruster
> Cc: Christoph Hellwig
> Cc: Peter Krempa
> Cc: Dr. David Alan Gilbert
> Signed-off-by: Stefan Hajnoczi
> ---
> docs/specs/tpm.rst | 2 +-
> docs/s
y enabling O_DIRECT and linux_aio
> unconditionally for drive_backup target. But actually this just shows
> that using drive-backup in blockdev era is a bad idea. So let's motivate
> everyone (including Virtuozzo of course) to move to new interfaces and
> avoid problems with all that outdated option inheritance.
libvirt never used 'drive-backup' thus
Reviewed-by: Peter Krempa
;
> Signed-off-by: Marc-André Lureau
> ---
> v3:
> - back to passing an error string, but appended to the error message.
Reviewed-by: Peter Krempa
On Fri, Mar 12, 2021 at 09:46:54 +0100, Paolo Bonzini wrote:
> On 12/03/21 09:14, Markus Armbruster wrote:
> > Paolo Bonzini writes:
> >
> > > On 11/03/21 15:08, Markus Armbruster wrote:
> > > > > I would rather keep the OptsVisitor here. Do the same check for JSON
> > > > > syntax that you
On Thu, Mar 11, 2021 at 12:41:42 +0100, Kevin Wolf wrote:
> Am 11.03.2021 um 12:24 hat Peter Krempa geschrieben:
> > On Thu, Mar 11, 2021 at 09:37:11 +0100, Kevin Wolf wrote:
> > > Am 11.03.2021 um 08:47 hat Peter Krempa geschrieben:
> > > > On Wed, Mar 10, 2021 at 18
On Thu, Mar 11, 2021 at 09:37:11 +0100, Kevin Wolf wrote:
> Am 11.03.2021 um 08:47 hat Peter Krempa geschrieben:
> > On Wed, Mar 10, 2021 at 18:30:44 +0100, Kevin Wolf wrote:
> > > Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben:
> > > > On 10/0
On Wed, Mar 10, 2021 at 18:30:44 +0100, Kevin Wolf wrote:
> Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben:
> > On 10/03/21 15:22, Peter Krempa wrote:
[...]
> The keyval parser would create a list if multiple values are given for
> the same key. Some care needs to be taken
On Wed, Mar 10, 2021 at 15:31:57 +0100, Paolo Bonzini wrote:
> On 10/03/21 15:22, Peter Krempa wrote:
> > I've stumbled upon a regression with this patchset applied:
> >
> > error: internal error: process exited while connecting to monitor:
> > qemu-system-x86_64: -obj
On Mon, Mar 08, 2021 at 17:54:10 +0100, Kevin Wolf wrote:
> This series adds a QAPI type for the properties of all user creatable
> QOM types and finally makes the --object command line option (in all
> binaries) and the object-add monitor commands (in QMP and HMP) use the
> new ObjectOptions
On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
> >> >> Drop the
On Mon, Mar 01, 2021 at 12:07:26 +0100, Kevin Wolf wrote:
> Am 25.02.2021 um 18:02 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > 24.02.2021 15:33, Kevin Wolf wrote:
> > > Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > > 08.02.2021 21:44, Alberto Garcia wrote:
> > >
2021-February/msg01212.html
Libvirt's test pass after it without any change, so on behalf of libvirt
ACKed-by: Peter Krempa
On Mon, Feb 22, 2021 at 19:22:49 +0100, Peter Krempa wrote:
> On Mon, Feb 22, 2021 at 18:42:00 +0100, Paolo Bonzini wrote:
> > On 22/02/21 15:57, Markus Armbruster wrote:
> > > * The block layer's pseudo-protocol "json:" (which can get embedded in
> > >
On Mon, Feb 22, 2021 at 18:42:00 +0100, Paolo Bonzini wrote:
> On 22/02/21 15:57, Markus Armbruster wrote:
> > * The block layer's pseudo-protocol "json:" (which can get embedded in
> >image headers)
>
> If it gets embedded in image headers, I don't think we'll be able to
> deprecate it ever.
On Mon, Feb 22, 2021 at 15:57:22 +0100, Markus Armbruster wrote:
> We use JSON in several external interfaces:
>
> * QMP
>
> * The guest agent's QMP
>
> * QAPIfied command line options when the option argument starts with
> '{'
>
> * The block layer's pseudo-protocol "json:" (which can get
On Tue, Feb 16, 2021 at 17:38:37 +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> qmp_disable_command() now takes an optional error string to return a
> more explicit error message.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1928806
>
> Signed-off-by:
On Fri, Feb 12, 2021 at 12:38:10 -0600, Eric Blake wrote:
> On 2/12/21 11:34 AM, Peter Krempa wrote:
>
> Long subject line; if it's okay with you, I'd prefer to use:
>
> migration: dirty-bitmap: Use struct for alias map inner members
>
> > Currently the alias mapping
Verify that the modification of the bitmap persistence over migration
which is controlled via BitmapMigrationBitmapAliasTransform works
properly.
Based on TestCrossAliasMigration
Signed-off-by: Peter Krempa
---
tests/qemu-iotests/300 | 91 ++
tests/qemu
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so pass a copy of the whole
BitmapMigrationBitmapAlias QAPI struct into the map.
Signed-off-by: Peter Krempa
into a squashed image) but currently it would need to create another set
of persistent bitmaps and merge them.
This patch adds a 'transform' property to the alias map which allows to
override the persistence of migrated bitmaps both on the source and
destination sides.
Signed-off-by: Peter Krempa
See 2/2 for explanation.
Peter Krempa (3):
migration: dirty-bitmap: Convert alias map inner members to
BitmapMigrationBitmapAlias
migration: dirty-bitmap: Allow control of bitmap persistence
qemu-iotests: 300: Add test case for modifying persistence of bitmap
migration/block-dirty
On Wed, Feb 10, 2021 at 18:26:57 +0100, Kevin Wolf wrote:
> Am 08.02.2021 um 19:44 hat Alberto Garcia geschrieben:
> > Hi,
> >
> > this series allows changing bs->file using x-blockdev-reopen. Read
> > here for more details:
> >
> >
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so convert the members to a
struct.
Signed-off-by: Peter Krempa
Reviewed-by: Eric Blake
Reviewed-by: Vladimir
See 2/2 for explanation.
Peter Krempa (2):
migration: dirty-bitmap: Convert alias map inner members to a struct
migration: dirty-bitmap: Allow control of bitmap persistance
migration/block-dirty-bitmap.c | 73 +-
qapi/migration.json| 20
into a squashed image) but currently it would need to create another set
of persistent bitmaps and merge them.
This patch adds a 'transform' property to the alias map which allows to
override the persistance of migrated bitmaps both on the source and
destination sides.
Signed-off-by: Peter Krempa
---
v2
On Wed, Feb 03, 2021 at 14:27:49 +0100, Peter Krempa wrote:
> On Wed, Feb 03, 2021 at 16:23:21 +0300, Vladimir Sementsov-Ogievskiy wrote:
> > 03.02.2021 16:00, Peter Krempa wrote:
> > > Bitmap's source persistence is transported over the migration stream and
> > &
On Wed, Feb 03, 2021 at 16:23:21 +0300, Vladimir Sementsov-Ogievskiy wrote:
> 03.02.2021 16:00, Peter Krempa wrote:
> > Bitmap's source persistence is transported over the migration stream and
> > the destination mirrors it. In some cases the destination might want to
> >
into a squashed image) but currently it would need to create another set
of persistent bitmaps and merge them.
This adds 'dest-persistent' optional property to
'BitmapMigrationBitmapAlias' which when present overrides the bitmap
presence state from the source.
Signed-off-by: Peter Krempa
---
migration
See 2/2 for explanation.
Please let me know if I need to add any tests for this.
Peter Krempa (2):
migration: dirty-bitmap: Convert alias map inner members to a struct
migration: dirty-bitmap: Allow control of bitmap persistence on
destination
migration/block-dirty-bitmap.c | 67
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so convert the members to a
struct.
Signed-off-by: Peter Krempa
---
migration/block-dirty-bitmap.c | 37
On Fri, Jan 15, 2021 at 11:43:10 +0100, Peter Krempa wrote:
> On Fri, Jan 15, 2021 at 10:02:04 +, Peter Maydell wrote:
> > On Thu, 14 Jan 2021 at 23:48, Igor Mammedov wrote:
[...]
> Removing the 'x-' will fix it only starting with qemu-6.0 and any
> downstream which backpo
On Fri, Jan 15, 2021 at 10:02:04 +, Peter Maydell wrote:
> On Thu, 14 Jan 2021 at 23:48, Igor Mammedov wrote:
> >
> > Add documentation for '-machine memory-backend' CLI option and
> > how to use it.
> >
> > And document that x-use-canonical-path-for-ramblock-id,
> > is considered to be
On Mon, Jan 11, 2021 at 17:27:29 -0500, Igor Mammedov wrote:
> Add documentation for '-machine memory-backend' CLI option and
> how to use it.
>
> PS:
> While at it add a comment to x-use-canonical-path-for-ramblock-id,
> to make sure it won't go away by accident.
This should also be the main
On Thu, Dec 10, 2020 at 17:26:52 +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
Hi,
>
> I have an idea, that not storing backing filename in qcow2 image at all may
> be a good thing. I'll give some reasons and want to know what do you think
> about it.
>
> 1. Libvirt has to manage and
1 - 100 of 375 matches
Mail list logo
