On Tue, Dec 08, 2020 at 11:13:07 +0300, Roman Bolshakov wrote:
> On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote:
> > On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote:
> > > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote:
> > &g
On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote:
> On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote:
> > There's no generic way to query current accel and its properties via QOM
> > because there's no link between an accel and current machine.
> >
> > The change adds
On Tue, Dec 01, 2020 at 11:42:18 +0300, Andrey Gruzdev wrote:
> On 01.12.2020 10:08, Peter Krempa wrote:
> > On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote:
> > > This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas
> > > he's
[.
On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote:
> This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's
> implemented in his series '[PATCH v0 0/4] migration: add background snapshot'.
Hi,
I gave this a try when attempting to implement the libvirt code for
On Mon, Nov 30, 2020 at 13:25:20 +0100, Kevin Wolf wrote:
> This series adds a QAPI type for the properties of all user creatable
> QOM types and finally makes QMP object-add use the new ObjectOptions
> union so that QAPI introspection can be used for user creatable objects.
FYI, here's a libvirt
On Mon, Nov 30, 2020 at 10:21:08 +0100, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote:
> >> Peter Krempa writes:
[...]
> > I know it's hard to enforce, but probably the cheapest in terms
On Fri, Nov 27, 2020 at 15:53:16 +, Daniel Berrange wrote:
> On Fri, Nov 27, 2020 at 01:18:09PM +0100, Peter Krempa wrote:
> > On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote:
[...]
> IIUC, this all relies on us importing a dump of the latest QEMU
&g
On Fri, Nov 27, 2020 at 16:44:05 +0100, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote:
> >> On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote:
[...]
> > As you can see this has a
On Fri, Nov 27, 2020 at 14:45:12 +0300, Roman Bolshakov wrote:
> On Fri, Nov 27, 2020 at 12:21:54PM +0100, Peter Krempa wrote:
> > On Fri, Nov 27, 2020 at 10:50:59 +, Daniel Berrange wrote:
> > > Copying libvir-list for the deprecation warning.
> > >
> > >
On Fri, Nov 27, 2020 at 10:50:59 +, Daniel Berrange wrote:
> Copying libvir-list for the deprecation warning.
>
>
> On Mon, Nov 16, 2020 at 04:10:11PM +0300, Roman Bolshakov wrote:
> > 'query-accel' QMP command should be used instead.
> >
> > Signed-off-by: Roman Bolshakov
> > ---
> >
On Fri, Nov 27, 2020 at 11:21:39 +0300, Andrey Gruzdev wrote:
> On 26.11.2020 18:47, Peter Krempa wrote:
> > On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote:
> > > This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas
> > > he's
>
On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote:
> This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's
> implemented in his series '[PATCH v0 0/4] migration: add background snapshot'.
>
> Currently the only way to make (external) live VM snapshot is using
On Fri, Nov 13, 2020 at 10:46:02 +0100, Kevin Wolf wrote:
> Am 12.11.2020 um 19:34 hat Eric Blake geschrieben:
> > On 11/12/20 11:28 AM, Kevin Wolf wrote:
> > > Introduce alias definitions for object types (structs and unions). This
> > > allows using the same QAPI type and visitor for many syntax
ased VM definition in
the test-suite, so our mips support is rather theoretical.
On behalf of libvirt:
ACKed-by: Peter Krempa
| 6 +-
> nbd/server.c | 19 --
> qemu-nbd.c | 18 -
> 5 files changed, 58 insertions(+), 29 deletions(-)
Reviewed-by: Peter Krempa
On Fri, Oct 23, 2020 at 13:36:46 -0500, Eric Blake wrote:
> Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to
> 5.2, we can still tweak the interface. Allowing 'bitmaps':['str'] is
> nicer than 'bitmap':'str'. This wires up the qapi and qemu-nbd
> changes to permit passing
On Fri, Oct 23, 2020 at 19:27:55 +0200, Igor Mammedov wrote:
> On Fri, 23 Oct 2020 11:54:40 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Fri, Oct 23, 2020 at 09:47:14AM +0300, Marcel Apfelbaum wrote:
> > > Hi David,
> > >
> > > On Fri, Oct 23, 2020 at 6:49 AM David Gibson wrote:
> > >
> > >
nterpretation for these machine types, so we
don't need to add any compatibility. Obviously users of these machine
types might end up with broken configs if they were using them, but
that's qemu's decision.
On behalf of libvirt:
ACKed-by: Peter Krempa
On Tue, Sep 22, 2020 at 18:42:52 +0100, Daniel Berrange wrote:
> On Tue, Sep 22, 2020 at 01:09:06PM -0400, Neal Gompa wrote:
> > On Tue, Sep 22, 2020 at 12:16 PM Daniel P. Berrangé
> > wrote:
> > >
> > > 2 years back I proposed dropping the sheepdog mailing list from the
> > > MAINTAINERS file,
On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote:
> Some general comments on using the patch:
>
> * For libguestfs I chose to add
>
> -compat deprecated-input=reject,deprecated-output=hide
>
> This is only enabled in developer builds of libguestfs when we
> are running
On Mon, Sep 14, 2020 at 10:47:55 +0200, Markus Armbruster wrote:
> Policy is separate for input and output.
>
> Input policy can be "accept" (accept silently), or "reject" (reject
> the request with an error).
>
> Output policy can be "accept" (pass on unchanged), or "hide" (filter
> out the
On Thu, Aug 20, 2020 at 09:41:14 -0500, Eric Blake wrote:
> On 8/20/20 6:05 AM, Kevin Wolf wrote:
>
> > As long as we can keep the compatibility code local to qmp_nbd_*(), I
> > don't think it's too bad. In particular because it's already written.
> >
> > Instead of adjusting libvirt to changes
inactive_all(), but bdrv_invalidate_cache_all() attempts to reload
> them (which fails, because they are still present in memory).
>
I've tested it with same commands as I've used before and now the 'cont'
succeeds and also the bitmaps after the cont call are loaded and active
at least according to 'query-named-block-nodes'
Tested-by: Peter Krempa
On Tue, Jul 07, 2020 at 12:33:31 +0200, Kevin Wolf wrote:
> Am 07.07.2020 um 08:38 hat Peter Krempa geschrieben:
> > On Mon, Jul 06, 2020 at 18:15:55 +0200, Kevin Wolf wrote:
> > > Am 03.07.2020 um 18:02 hat Daniel P. Berrangé geschrieben:
[...]
> > IMO we really wan
e 5.1)
> +^^
> +
> +The SPI mode of the 'sd-card' device is deprecated.
libvirt didn't implement this knob so it's okay to remove it without
replacement.
ACKed-by: Peter Krempa
ld use 'scsi-hd' or
> 'scsi-cd' as appropriate to get a SCSI hard disk or CD-ROM as needed.
>
> +``ssi-sd`` (since 5.1)
> +'
> +
> +The 'ssi-sd' (SSI to SD card adapter) device is deprecated.
libvirt didn't allow configuring this device yet, so from our view it's
okay to remove it.
ACKed-by: Peter Krempa
On Mon, Jul 06, 2020 at 18:15:55 +0200, Kevin Wolf wrote:
> Am 03.07.2020 um 18:02 hat Daniel P. Berrangé geschrieben:
> > On Fri, Jul 03, 2020 at 04:49:33PM +0100, Dr. David Alan Gilbert wrote:
> > > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > > On Thu, Jul 02, 2020 at 01:12:52PM
On Fri, Jul 03, 2020 at 17:10:12 +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > On Fri, Jul 03, 2020 at 04:49:33PM +0100, Dr. David Alan Gilbert wrote:
> > > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > > On Thu, Jul 02, 2020 at 01:12:52PM
On Mon, May 18, 2020 at 16:52:45 +0200, Peter Krempa wrote:
> On Wed, May 13, 2020 at 23:49:17 -0400, John Snow wrote:
> > Hi,
> >
> > This is a new (very small) block job that writes a pattern into a
> > bitmap. The only pattern implemented is the top allocation inf
On Mon, Jun 08, 2020 at 13:30:48 +0300, Vladimir Sementsov-Ogievskiy wrote:
> 08.06.2020 12:38, Peter Krempa wrote:
> > On Sat, Jun 06, 2020 at 09:55:13 +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > 05.06.2020 13:59, Peter Krempa wrote:
[...]
> >
> > It's
On Sat, Jun 06, 2020 at 09:55:13 +0300, Vladimir Sementsov-Ogievskiy wrote:
> 05.06.2020 13:59, Peter Krempa wrote:
> > On Fri, Jun 05, 2020 at 12:07:47 +0200, Kevin Wolf wrote:
> > > Am 05.06.2020 um 11:58 hat Peter Krempa geschrieben:
> > > > On Fri, Jun 05, 2020
On Fri, Jun 05, 2020 at 12:07:47 +0200, Kevin Wolf wrote:
> Am 05.06.2020 um 11:58 hat Peter Krempa geschrieben:
> > On Fri, Jun 05, 2020 at 11:44:07 +0200, Kevin Wolf wrote:
[...]
> > The above was actually inspired by a very recent problem I have in my
> > attempt to
On Fri, Jun 05, 2020 at 11:44:07 +0200, Kevin Wolf wrote:
> Am 05.06.2020 um 11:24 hat Peter Krempa geschrieben:
> > On Fri, Jun 05, 2020 at 11:01:23 +0200, Kevin Wolf wrote:
> > > Am 04.06.2020 um 18:22 hat Peter Krempa geschrieben:
> > > > On Thu, Jun 04, 2020 at 13
On Fri, Jun 05, 2020 at 11:01:23 +0200, Kevin Wolf wrote:
> Am 04.06.2020 um 18:22 hat Peter Krempa geschrieben:
> > On Thu, Jun 04, 2020 at 13:31:45 +0200, Kevin Wolf wrote:
> > > Am 04.06.2020 um 11:16 hat Peter Krempa geschrieben:
> > > > On Thu, Jun 04, 2020 at 11
On Thu, Jun 04, 2020 at 13:31:45 +0200, Kevin Wolf wrote:
> Am 04.06.2020 um 11:16 hat Peter Krempa geschrieben:
> > On Thu, Jun 04, 2020 at 11:12:31 +0200, Kevin Wolf wrote:
> > > Am 18.05.2020 um 22:49 hat Eric Blake geschrieben:
> > > > > +
> > &g
On Thu, Jun 04, 2020 at 11:12:31 +0200, Kevin Wolf wrote:
> Am 18.05.2020 um 22:49 hat Eric Blake geschrieben:
> > > +
> > > +/* NB: new bitmap is anonymous and enabled */
> > > +cluster_size = bdrv_dirty_bitmap_granularity(target_bitmap);
> > > +new_bitmap =
On Tue, Jun 02, 2020 at 12:56:32 +0200, Max Reitz wrote:
> On 18.05.20 18:26, Peter Krempa wrote:
> > On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote:
> >> This command allows mapping block node names to aliases for the purpose
> >> of block dirty bitmap mi
On Wed, May 27, 2020 at 10:51:21 +0200, Aleksandar Markovic wrote:
> уто, 26. мај 2020. у 15:04 Aleksandar Markovic
> је написао/ла:
> >
> > уто, 26. мај 2020. у 14:50 Peter Krempa је написао/ла:
> > >
> > > On Tue, May 26, 2020 at 14:37
On Tue, May 26, 2020 at 14:37:41 +0200, Aleksandar Markovic wrote:
> > >
> > > +mips ``fulong2e`` machine (since 5.1)
> > > +'
> > > +
> > > +This machine has been renamed ``fuloong2e``.
> > > +
> >
> > Libvirt doesn't have any special handling for this machine
On Tue, May 26, 2020 at 12:47:22 +0200, Philippe Mathieu-Daudé wrote:
> We always miswrote the Fuloong machine... Fix its name.
> Add an machine alias to the previous name for backward
> compatibility.
>
> Suggested-by: Aleksandar Markovic
> Message-id: <20200510210128.18343-5-f4...@amsat.org>
On Mon, May 18, 2020 at 15:49:02 -0500, Eric Blake wrote:
> On 5/13/20 10:49 PM, John Snow wrote:
[...]
> > +
> > +/* NB: new bitmap is anonymous and enabled */
> > +cluster_size = bdrv_dirty_bitmap_granularity(target_bitmap);
> > +new_bitmap = bdrv_create_dirty_bitmap(bs,
On Mon, May 18, 2020 at 20:52:32 +0300, Vladimir Sementsov-Ogievskiy wrote:
> [add Nikolay]
>
> 18.05.2020 19:26, Peter Krempa wrote:
> > On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote:
[...]
> > Is there any difference of handling of persistent and non-p
On Wed, May 13, 2020 at 16:56:10 +0200, Max Reitz wrote:
> This command allows mapping block node names to aliases for the purpose
> of block dirty bitmap migration.
>
> This way, management tools can use different node names on the source
> and destination and pass the mapping of how bitmaps are
snapshot outside of libvirt.
I've dusted-off my patches for using this blockjob for this very
specific case and it works for me.
Tested-by: Peter Krempa
For now I'll continue the integration with other blockjobs where we
merge bitmaps.
On Thu, May 07, 2020 at 16:49:14 +0200, Gerd Hoffmann wrote:
> Hi,
>
> For usb device pass-through (aka -device usb-host) it would be very
> useful to pass file handles from libvirt to qemu. The workflow would
> change from ...
>
> (1) libvirt enables access to /dev/usb/$bus/$dev
> (2)
On Tue, May 05, 2020 at 10:11:03 +0200, Kevin Wolf wrote:
> Am 03.04.2020 um 19:58 hat Eric Blake geschrieben:
> > Creating an image that requires format probing of the backing image is
> > inherently unsafe (we've had several CVEs over the years based on
> > probes leaking information to the
On Tue, Mar 17, 2020 at 12:54:25 +0100, Markus Armbruster wrote:
> This series extends QMP introspection to cover deprecation.
> Additionally, new option -compat lets you configure what to do when
> deprecated interfaces get used. This is intended for testing users of
> the management interfaces.
This was indeed caused by libvirt starting to use -blockdev. The issue
is that qemu's 'auto-read-only' property which is used by libvirt for
the backing files doesn't properly work if the 'host_device' backend
encounters a read-only LV.
The above situation also happens if you have an read-only LV
On Fri, Apr 03, 2020 at 14:02:47 +0300, Vladimir Sementsov-Ogievskiy wrote:
> 19.12.2019 13:36, Peter Krempa wrote:
> > On Thu, Dec 19, 2019 at 11:51:01 +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > Hi all!
> > >
> > > It's a continuation for
> > >
lways keeps its block nodes in the
> AioContext of the the requested iothread without guest interaction.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/155 | 32 +++-
> tests/qemu-iotests/155.out | 4 ++--
> 2 files changed, 25 insertions(+), 11 deletions(-)
Reviewed-by: Peter Krempa
6
> 2 files changed, 1 insertion(+), 16 deletions(-)
Tested-by: Peter Krempa
Unfortunately I don't feel confident enough in the intricacies of the
aio contexts. Nevertheless Fixing bugs by deleting code is awesome!
+++
> tests/qemu-iotests/155.out | 4 +--
> 2 files changed, 53 insertions(+), 7 deletions(-)
Reviewed-by: Peter Krempa
t; === Invalid command - snapshot node used as backing hd ===
>
> { 'execute': 'blockdev-snapshot', 'arguments': { 'node': 'virtio0',
> 'overlay':'snap_11' } }
> -{"error": {"class": "GenericError", "desc": "Node 'snap_11' is busy: node is
> used as backing hd of 'snap_12'"}}
> +{"error": {"class": "GenericError", "desc": "The overlay is already in use"}}
Would probably prevent these test changes.
Reviewed-by: Peter Krempa
Tested-by: Peter Krempa
rtions(+), 1 deletion(-)
Reviewed-by: Peter Krempa
On Tue, Mar 10, 2020 at 12:38:25 +0100, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf
> ---
> include/block/block_int.h | 3 +++
> block.c | 6 ++
> 2 files changed, 5 insertions(+), 4 deletions(-)
Reviewed-by: Peter Krempa
On Thu, Mar 05, 2020 at 13:50:56 +0100, Kevin Wolf wrote:
> This series allows libvirt to fix a regression that its switch from
> drive-mirror to blockdev-mirror caused: It currently requires that the
> backing chain of the target image is already available when the mirror
> operation is started.
On Tue, Mar 03, 2020 at 17:34:35 +0100, Markus Armbruster wrote:
> Based-on: <20200227144531.24309-1-arm...@redhat.com>
>
> This series extends QMP introspection to cover deprecation.
> Additionally, new option -compat lets you configure what to do when
> deprecated interfaces get used. This is
On Thu, Feb 27, 2020 at 19:18:02 +0100, Kevin Wolf wrote:
> Kevin Wolf (2):
> iotests: Refactor blockdev-reopen test for iothreads
> block: bdrv_reopen() with backing file in different AioContext
Thanks for the patches. It fixes the problem we've talked about:
Tested-by: Peter Krempa
layer
which uses a 'file-posix' file child which was opened with the
'auto-read-only' property set.
Signed-off-by: Peter Krempa
---
block/qcow2.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 3c754f616b..3640e8c07d 100644
Add another step in the reopen process where driver can execute code
after permission changes are comitted.
Signed-off-by: Peter Krempa
---
block.c | 9 +
include/block/block_int.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/block.c b/block.c
index
See patch 2/2 for explanation. Also please excuse the lack of tests
caused by my ignorance of not figuring out where to put them.
Peter Krempa (2):
block: Introduce 'bdrv_reopen_commit_post' step
block/qcow2: Move bitmap reopen into bdrv_reopen_commit_post
block.c | 9
On Wed, Feb 26, 2020 at 20:39:26 -0600, Eric Blake wrote:
> There are many existing qcow2 images that specify a backing file but
> no format. This has been the source of CVEs in the past, but has
> become more prominent of a problem now that libvirt has switched to
> -blockdev. With older
-
> include/block/block.h | 4 ++--
> block.c | 13 ++---
> block/qcow2.c | 2 +-
> block/stream.c| 2 +-
> blockdev.c| 3 ++-
> qemu-img.c| 4 ++--
> 6 files changed, 18 insertions(+), 10 deletions(-)
Reviewed-by: Peter Krempa
out_basefmt, true);
or just the above line.
> } else {
> ret = bdrv_change_backing_file(bs, NULL, NULL, false);
> }
I feel that this deprecation will be at least partially controversial,
but in my opinion it's the correct thing to do.
Reviewed-by: Peter Krempa
after you address the issue above.
On Tue, Feb 25, 2020 at 12:50:21 +, Daniel Berrange wrote:
> On Mon, Feb 24, 2020 at 06:10:46PM +0100, Peter Krempa wrote:
> > On Mon, Feb 24, 2020 at 14:24:15 +, Daniel Berrange wrote:
> > > On Mon, Feb 24, 2020 at 02:34:16PM +0100, Peter Krempa wrote:
[...]
> &
On Mon, Feb 24, 2020 at 10:08:31 -0600, Eric Blake wrote:
> On 2/24/20 5:38 AM, Peter Krempa wrote:
> > On Sat, Feb 22, 2020 at 05:23:41 -0600, Eric Blake wrote:
> > > Creating an image that requires format probing of the backing image is
> > > inherently unsafe (
On Mon, Feb 24, 2020 at 14:24:15 +, Daniel Berrange wrote:
> On Mon, Feb 24, 2020 at 02:34:16PM +0100, Peter Krempa wrote:
> > On Wed, Feb 19, 2020 at 13:12:53 -0600, Eric Blake wrote:
[...]
> > I'll reiterate the historical state of the problem because I think it'
On Wed, Feb 19, 2020 at 13:12:53 -0600, Eric Blake wrote:
> [adding qemu]
Adding Daniel as he objected to qemu-img.
>
> On 2/19/20 12:57 PM, Peter Krempa wrote:
[...]
> > Additionally I think that we could just get rid of the copy of the image
> > detection copy i
On Mon, Feb 24, 2020 at 12:01:45 +0100, Peter Krempa wrote:
> On Sat, Feb 22, 2020 at 05:23:38 -0600, Eric Blake wrote:
[...]
> > libvirt HAS to use blockdev-open on the backing chain and supply a
> > backing format there, and thus has to probe images. If libvirt ever
> &g
On Sat, Feb 22, 2020 at 05:23:41 -0600, Eric Blake wrote:
> Creating an image that requires format probing of the backing image is
> inherently unsafe (we've had several CVEs over the years based on
> probes leaking information to the guest on a subsequent boot). If our
> probing algorithm ever
On Sat, Feb 22, 2020 at 05:23:38 -0600, Eric Blake wrote:
> In the past, we have had CVEs caused by qemu probing one image type
> when an image started out as another but the guest was able to modify
> content. The solution to those CVEs was to encode backing format
> information into qcow2, to
On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote:
>
>
> On 1/27/20 5:36 AM, Maxim Levitsky wrote:
> > This patch series is bunch of cleanups
> > to the hmp monitor code.
> >
> > This series only touched blockdev related hmp handlers.
> >
> > No functional changes expected other that
> >
When a management application manages node names there's no reason to
recurse into backing images in the output of query-named-block-nodes.
Add a parameter to the command which will return just the top level
structs.
Signed-off-by: Peter Krempa
---
Diff to v1:
- rewrote setting
On Wed, Jan 15, 2020 at 16:07:37 +0100, Igor Mammedov wrote:
> Deprecation period is ran out and it's a time to flip the switch
> introduced by cd5ff8333a.
> Disable legacy option for new machine types and amend documentation.
>
> Signed-off-by: Igor Mammedov
> ---
> CC: peter.mayd...@linaro.org
On Fri, Dec 20, 2019 at 10:06:17 +, Vladimir Sementsov-Ogievskiy wrote:
> 20.12.2019 12:56, Peter Krempa wrote:
> > On Fri, Dec 20, 2019 at 09:39:17 +, Vladimir Sementsov-Ogievskiy wrote:
> >> 19.12.2019 18:55, Nir Soffer wrote:
> >>> On Thu, Dec 19, 2019
On Fri, Dec 20, 2019 at 09:39:17 +, Vladimir Sementsov-Ogievskiy wrote:
> 19.12.2019 18:55, Nir Soffer wrote:
> > On Thu, Dec 19, 2019 at 5:17 PM Vladimir Sementsov-Ogievskiy
> > wrote:
> >>
> >> 19.12.2019 17:59, Nir Soffer wrote:
> >>> On Thu, Dec 19, 2019 at 4:04 PM Kevin Wolf wrote:
>
On Thu, Dec 19, 2019 at 11:51:01 +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> It's a continuation for
> "bitmap migration bug with -drive while block mirror runs"
> <315cff78-dcdb-a3ce-2742-da3cc9f0c...@redhat.com>
> https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg07241.html
On Tue, Dec 17, 2019 at 16:11:37 +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On 12/17/19 1:36 AM, Markus Armbruster wrote:
> >
> >> Un-snipping the QAPI schema change:
> >
> > Sorry about that...
> >
> >>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index
On Fri, Dec 13, 2019 at 15:56:08 +0100, Paolo Bonzini wrote:
> On 13/12/19 15:46, Stefan Hajnoczi wrote:
> > The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough
> > support. Deprecate this feature in QEMU too.
> >
> > Signed-off-by: Stefan Hajnoczi
> > ---
> >
When a management application manages node names there's no reason to
recurse into backing images in the output of query-named-block-nodes.
Add a parameter to the command which will return just the top level
structs.
Signed-off-by: Peter Krempa
---
block.c | 5 +++--
block
On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote:
> Am 11.12.2019 um 10:33 hat Peter Krempa geschrieben:
> > On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote:
> > > Commit 7a9877a026 "block: Accept device model name for
> > >
On Wed, Dec 11, 2019 at 12:32:10 +, Daniel Berrange wrote:
> On Wed, Dec 11, 2019 at 01:24:17PM +0100, Kevin Wolf wrote:
> > Am 11.12.2019 um 11:51 hat Peter Krempa geschrieben:
> > > On Wed, Dec 11, 2019 at 11:14:39 +0100, Kevin Wolf wrote:
[...]
> > > Well, in s
On Wed, Dec 11, 2019 at 09:12:41 +0100, Markus Armbruster wrote:
> I went through the QAPI schema looking for deprecated stuff not
> mentioned in qemu-deprecated.texi. Here's what I found:
>
> Commit b33945cfff "block: Accept device model name for
> blockdev-open/close-tray" (v2.8.0)
On Thu, Dec 05, 2019 at 17:37:11 -0500, John Snow wrote:
> This has come up in the past, and I believe we discussed this at KVM
> Forum, too:
>
> There have been requests from oVirt (via Nir Soffer) to add some offline
> bitmap manipulation functionality. In the past, our stance has generally
>
On Fri, Nov 08, 2019 at 09:53:10 +0100, Kevin Wolf wrote:
> Kevin Wolf (2):
> block: Remove 'backing': null from bs->{explicit_,}options
> iotests: Test multiple blockdev-snapshot calls
Hi,
I'm not sure how the freeze rules for qemu are at this point thus:
Will this patchset make it into
273 b/tests/qemu-iotests/273
> new file mode 100755
> index 00..60076de7ce
> --- /dev/null
> +++ b/tests/qemu-iotests/273
> @@ -0,0 +1,76 @@
> +#!/usr/bin/env bash
> +#
> +# Test large write to a qcow2 image
Cut?
Rest looks good
Reviewed-by: Peter Krempa
> +#
&g
l take effect again and the node
> incorrectly loses its backing file.
>
> Fix bdrv_open_inherited() to remove the 'backing' option from
> bs->options and bs->explicit_options even for the case where it
> specifies that no backing file is wanted.
>
> Reported-by: Peter Krempa
>
On Fri, Nov 08, 2019 at 13:56:03 +, Vladimir Sementsov-Ogievskiy wrote:
> 08.11.2019 16:27, Peter Krempa wrote:
> > On Fri, Nov 08, 2019 at 13:16:55 +0300, Vladimir Sementsov-Ogievskiy wrote:
[...]
> > Note that 'block-commit' and 'drive-mirror' commands are used by libvirt
On Fri, Nov 08, 2019 at 13:16:54 +0300, Vladimir Sementsov-Ogievskiy wrote:
> To correspond to blockdev-mirror command and make it possible to
> deprecate implicit filters in the next commit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> qapi/block-core.json | 7 +++
> blockdev.c
On Fri, Nov 08, 2019 at 13:16:55 +0300, Vladimir Sementsov-Ogievskiy wrote:
> To get rid of implicit filters related workarounds in future let's
> deprecate them now.
>
> Deprecation warning breaks some bash iotests output, so fix it here
> too: in most of cases just add filter-node-name in test.
On Thu, Oct 31, 2019 at 23:02:45 +0100, Paolo Bonzini wrote:
> On 31/10/19 11:58, John Snow wrote:
> > It's an old compatibility shim that just delegates to ide-cd or ide-hd.
> > I'd like to refactor these some day, and getting rid of the super-object
> > will make that easier.
> >
> > Either
On Thu, Oct 10, 2019 at 14:08:12 -0400, John Snow wrote:
> On 10/10/19 7:54 AM, Peter Krempa wrote:
> > On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
> >> On 10/10/19 1:26 PM, Peter Krempa wrote:
[...]
> > To be honest, I didn't re
On Fri, Oct 11, 2019 at 10:50:23 +0200, Markus Armbruster wrote:
> Add 'features' field in the schema for commands and add a feature flag
> to advertise that the fix for savevm [1] is present.
>
> [1] https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03487.html
>
> Based-on:
ons(+), 33 deletions(-)
Reviewed-by: Peter Krempa
signature.asc
Description: PGP signature
On Thu, Oct 10, 2019 at 15:53:30 +0200, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > Signed-off-by: Peter Krempa
> > ---
> > tests/qapi-schema/qapi-schema-test.json | 26 ++
> > tests/qapi-schema/qapi-schema-test.out | 29 +++
On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
> On 10/10/19 1:26 PM, Peter Krempa wrote:
> > On Thu, Oct 10, 2019 at 13:22:37 +0200, Philippe Mathieu-Daudé wrote:
> > > On 10/10/19 12:43 AM, John Snow wrote:
> > > > It's an old compatibility s
will make that easier.
> >
> > Either way, we don't need this.
> >
> > Libvirt-checked-by: Peter Krempa
>
> Peter made a comment regarding Laszlo's Regression-tested-by tag:
>
> [...] nobody else is using
> this convention (there are exactly 0 instances
-command' backdoor which is used to call this command in
modern use.
Signed-off-by: Peter Krempa
---
qapi/misc.json | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/qapi/misc.json b/qapi/misc.json
index 6bd11f50e6..5d0070aa43 100644
--- a/qapi/misc.json
+++ b/qapi
Signed-off-by: Peter Krempa
---
tests/qapi-schema/qapi-schema-test.json | 26 ++
tests/qapi-schema/qapi-schema-test.out | 29 +
tests/qapi-schema/test-qapi.py | 4
tests/test-qmp-cmds.c | 28
4
.
Signed-off-by: Peter Krempa
---
docs/devel/qapi-code-gen.txt | 7 ---
qapi/introspect.json | 6 +-
scripts/qapi/commands.py | 3 ++-
scripts/qapi/doc.py| 3 ++-
scripts/qapi/expr.py | 17 -
scripts/qapi/introspect.py | 7
101 - 200 of 375 matches
Mail list logo
