[Qemu-devel] [PATCH] block: curl: Allow passing cookies via QCryptoSecret

Since cookies can contain sensitive data (session ID, etc ...) it is desired to hide them from the prying eyes of users. Add a possibility to pass them via the secret infrastructure. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1447413 Signed-off-by: Peter Krempa <pkre...@redhat.

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

On Tue, Apr 04, 2017 at 15:19:02 +0200, Kevin Wolf wrote: > Am 03.04.2017 um 14:51 hat Peter Krempa geschrieben: > > On Mon, Apr 03, 2017 at 10:15:42 +0200, Kevin Wolf wrote: > > > Am 31.03.2017 um 19:43 hat Max Reitz geschrieben: > > > > On 31.03.2

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

On Mon, Apr 03, 2017 at 15:00:41 +0200, Kevin Wolf wrote: > Am 03.04.2017 um 14:39 hat Max Reitz geschrieben: > > On 03.04.2017 10:15, Kevin Wolf wrote: > > > Am 31.03.2017 um 19:43 hat Max Reitz geschrieben: > > > > [...] > > > > >> So in theory all that's necessary is to set share-rw=on for

Re: [Qemu-devel] nbd: Possible regression in 2.9 RCs

On Mon, Apr 03, 2017 at 10:15:42 +0200, Kevin Wolf wrote: > Am 31.03.2017 um 19:43 hat Max Reitz geschrieben: > > On 31.03.2017 18:03, Ciprian Barbu wrote: [...] > > So this doesn't work: > > > > $ x86_64-softmmu/qemu-system-x86_64 \ > > -blockdev node-name=image,driver=qcow2,\ > >

Re: [Qemu-devel] [libvirt] Fail to start 2nd guest

On Mon, Feb 27, 2017 at 13:31:30 +, Stefan Hajnoczi wrote: > On Mon, Feb 27, 2017 at 08:50:03PM +0800, Xiong Zhou wrote: > > On Mon, Feb 27, 2017 at 10:11:04AM +, Stefan Hajnoczi wrote: > > > On Mon, Feb 27, 2017 at 05:40:50PM +0800, Xiong Zhou wrote: [...] > > > > sh-4.2# virsh start

Re: [Qemu-devel] Non-flat command line option argument syntax

On Thu, Feb 02, 2017 at 20:42:33 +0100, Markus Armbruster wrote: [...] > === Comparison === > > In my opinion, dotted keys are weird and ugly, but at least they don't > add to the quoting mess. Structured values look better, except when > they do add to the quoting mess. From libvirt's point

Re: [Qemu-devel] [PATCH] spapr: Don't support query-hotpluggable-cpus on earlier pseries machine types

On Tue, Aug 02, 2016 at 16:20:50 +1000, David Gibson wrote: > On Tue, Aug 02, 2016 at 10:34:34AM +0530, Bharata B Rao wrote: > > On Tue, Aug 02, 2016 at 02:25:08PM +1000, David Gibson wrote: > > > On Power, support for vCPU hotplug is new in qemu 2.7. However, we > > > currently implement the

Re: [Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list

On Wed, Jul 20, 2016 at 11:00:05 +1000, David Gibson wrote: > On Tue, Jul 19, 2016 at 01:52:40PM +0200, Peter Krempa wrote: > > On Mon, Jul 18, 2016 at 19:19:19 +1000, David Gibson wrote: > > > The spapr implementation of query-hotpluggable-cpus builds the list of > > &

Re: [Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list

On Mon, Jul 18, 2016 at 19:19:19 +1000, David Gibson wrote: > The spapr implementation of query-hotpluggable-cpus builds the list of > hotpluggable cores from the end (most removed from the list head) > because that's the easiest way with a singly linked list. Because it > also traverses the

Re: [Qemu-devel] [RFC 2/2] qmp: Implement cpu-add in terms of query-hotpluggable-cpus when available

On Tue, Jul 19, 2016 at 09:51:00 +0200, Igor Mammedov wrote: > On Tue, 19 Jul 2016 09:32:08 +0530 > Bharata B Rao <bhar...@linux.vnet.ibm.com> wrote: > > On Mon, Jul 18, 2016 at 04:01:18PM +0200, Peter Krempa wrote: > > > On Mon, Jul 18, 2016 at 19:19:2

Re: [Qemu-devel] [RFC 0/2] cpu-add compatibility for query-hotpluggable-cpus implementations

On Mon, Jul 18, 2016 at 18:20:35 +0200, Igor Mammedov wrote: > On Mon, 18 Jul 2016 17:06:18 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > On Mon, Jul 18, 2016 at 19:19:18 +1000, David Gibson wrote: [...] > > First of the problem is the missing link between the NUMA

Re: [Qemu-devel] [RFC 0/2] cpu-add compatibility for query-hotpluggable-cpus implementations

On Mon, Jul 18, 2016 at 19:19:18 +1000, David Gibson wrote: > I'm not entirely sure if this is a good idea, and if it is whether > this is a good approach to it. But I'd like to discuss it and see if > anyone has better ideas. > > As you may know we've hit a bunch of complications with cpu_index

Re: [Qemu-devel] [RFC 2/2] qmp: Implement cpu-add in terms of query-hotpluggable-cpus when available

On Mon, Jul 18, 2016 at 19:19:20 +1000, David Gibson wrote: > We've recently added a new device_add based cpu hotplug > implementation, with the spapr machine type being the first user. In > order to overcome the limitations of the old cpu_add interface, it > works very differently. That's going

Re: [Qemu-devel] [RFC PATCH 2/2] numa: Add node_id data in query-hotpluggable-cpus

On Fri, Jul 08, 2016 at 14:10:59 +0200, Igor Mammedov wrote: > On Fri, 8 Jul 2016 14:04:23 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > > On Fri, Jul 08, 2016 at 13:54:58 +0200, Igor Mammedov wrote: > > > On Thu, 7 Jul 2016 17:17:14 +0200 > > >

Re: [Qemu-devel] [RFC PATCH 2/2] numa: Add node_id data in query-hotpluggable-cpus

On Fri, Jul 08, 2016 at 14:06:31 +0200, Igor Mammedov wrote: > On Fri, 8 Jul 2016 09:46:00 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > [...] > > Note: For libvirt it's a no-go to start a throwaway qemu process just to > > query the information and t

Re: [Qemu-devel] [RFC PATCH 2/2] numa: Add node_id data in query-hotpluggable-cpus

On Fri, Jul 08, 2016 at 13:54:58 +0200, Igor Mammedov wrote: > On Thu, 7 Jul 2016 17:17:14 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > > Add a helper that looks up the NUMA node for a given CPU and use it to > > fill the node_id in the PPC and X86 impls

Re: [Qemu-devel] [RFC PATCH 2/2] numa: Add node_id data in query-hotpluggable-cpus

On Fri, Jul 08, 2016 at 12:23:08 +1000, David Gibson wrote: > On Thu, 7 Jul 2016 17:17:14 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > > Add a helper that looks up the NUMA node for a given CPU and use it to > > fill the node_id in the PPC and X86 impls

Re: [Qemu-devel] [RFC PATCH 0/2] cpu hotplug: Extend data provided by query-hotpluggable-cpus

On Thu, Jul 07, 2016 at 17:17:12 +0200, Peter Krempa wrote: > Few entries that would help me in adding the stuff to libvirt. I forgot to mention that I didn't really test the PPC64 stuff as I currently don't have a box at hand.

[Qemu-devel] [RFC PATCH 2/2] numa: Add node_id data in query-hotpluggable-cpus

Add a helper that looks up the NUMA node for a given CPU and use it to fill the node_id in the PPC and X86 impls of query-hotpluggable-cpus. Signed-off-by: Peter Krempa <pkre...@redhat.com> --- hw/i386/pc.c | 7 +++ hw/ppc/spapr.c| 8 ++-- include/sysemu/numa.

[Qemu-devel] [RFC PATCH 0/2] cpu hotplug: Extend data provided by query-hotpluggable-cpus

Few entries that would help me in adding the stuff to libvirt. Peter Krempa (2): qapi: Add vcpu id to query-hotpluggable-cpus output numa: Add node_id data in query-hotpluggable-cpus hmp.c | 1 + hw/i386/pc.c | 8 hw/ppc/spapr.c| 9

[Qemu-devel] [RFC PATCH 1/2] qapi: Add vcpu id to query-hotpluggable-cpus output

-by: Peter Krempa <pkre...@redhat.com> --- hmp.c| 1 + hw/i386/pc.c | 1 + hw/ppc/spapr.c | 1 + qapi-schema.json | 2 ++ 4 files changed, 5 insertions(+) diff --git a/hmp.c b/hmp.c index 0cf5baa..613601e 100644 --- a/hmp.c +++ b/hmp.c @@ -2450,6 +2450,7 @

Re: [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus

of 'core' to match current code > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > qmp-commands.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Oops; thanks for cleaning up after me. Reviewed-by: Peter Krempa <pkre...@redhat.com>

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

On Fri, Jun 24, 2016 at 16:56:21 +1000, David Gibson wrote: > On Fri, 24 Jun 2016 07:41:11 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > > On Fri, Jun 24, 2016 at 14:56:51 +1000, David Gibson wrote: > > > > [...] > > > > > > Y

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

On Fri, Jun 24, 2016 at 14:56:51 +1000, David Gibson wrote: [...] > > You are correct - query-commands says whether 'query-hotpluggable-cpus' > > exists as a command. But that is insufficient. See my review, or the > > v2 patch, where the above poor wording was corrected to say what was > >

[Qemu-devel] [PATCH v2 2/2] qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore

struct CPUCore uses 'id' suffix in the property name. As docs for query-hotpluggable-cpus state that the cpu core properties should be passed back to device_add by management in case new members are added and thus the names for the fields should be kept in sync. Signed-off-by: Peter Krempa <p

[Qemu-devel] [PATCH v2 0/2] qapi: Fix up cpu hotplug property names and add witness for cpu hotplug support

Version 2: - fix typos/incompetence/drowsiness based language errors in commit message - select version 1 as prefered way - add -id suffix to all members of CpuInstanceProperties - note in qapi-schema the need to keep members in sync - fix output text field names in HMP impl Peter Krempa (2

[Qemu-devel] [PATCH v2 1/2] qapi: Report support for -device cpu hotplug in query-machines

"is-default": true, "cpu-max": 255, "alias": "pseries" }, Signed-off-by: Peter Krempa <pkre...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> --- qapi-schema.json | 5 - vl.c | 1 + 2 files changed, 5 insertion

[Qemu-devel] [PATCH 2/3] [VARIANT 1] qapi: Change 'core' to 'core-id' in 'CpuInstanceProperties'

struct CPUCore uses 'core-id' as the property name. As docs for query-hotpluggable-cpus state that the cpu core properties should be passed back to device_add by management in case new members are added and thus the names for the fields should be kept in sync. Signed-off-by: Peter Krempa <p

[Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

ot;: true, "cpu-max": 255, "alias": "pseries" }, Signed-off-by: Peter Krempa <pkre...@redhat.com> --- qapi-schema.json | 5 - vl.c | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-sch

[Qemu-devel] [PATCH 3/3] [VARIANT 2] qapi: Change 'core-id' to 'core' in 'struct CPUCore'

CpuInstanceProperties uses 'core' as the property name. As docs for query-hotpluggable-cpus state that the cpu core properties should be passed back to device_add by management in case new members are added and thus the names for the fields should be kept in sync. Signed-off-by: Peter Krempa

[Qemu-devel] [PATCH 0/3] qapi: Fix up cpu hotplug property names and add witness for cpu hotplug support

to be used with -device and those reported by query-hotpluggable-cpus. Peter Krempa (3): qapi: Report support for -device cpu hotplug in query-machines VARIANT 1: qapi: Change 'core' to 'core-id' in 'CpuInstanceProperties' VARIANT 2: qapi: Change 'core-id' to 'core' in 'struct CPUCore' hmp.c

Re: [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

On Thu, Jun 02, 2016 at 18:31:04 +0200, Igor Mammedov wrote: > On Thu, 2 Jun 2016 17:05:06 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > On Thu, Jun 02, 2016 at 11:53:22 -0300, Eduardo Habkost wrote: > > > On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wr

Re: [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr

On Thu, Jun 02, 2016 at 11:53:22 -0300, Eduardo Habkost wrote: > (CCing libvirt folks) > > BTW: > > On Thu, Jun 02, 2016 at 02:22:22PM +0200, Igor Mammedov wrote: > [...] > > > /* Special cases: */ > > > if (!strcmp(name, "xlevel")) { > > > numvalue = strtoul(val, ,

Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 15:20:51 +0200, Igor Mammedov wrote: > On Thu, 12 May 2016 13:04:23 +0200 > Peter Krempa <pkre...@redhat.com> wrote: > > > On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > > > I don't think we should do that, unless users al

Re: [Qemu-devel] [libvirt] [RFC 12/42] pc: initialize legacy hotplug only for 2.6 and older machine types

On Thu, May 12, 2016 at 07:52:23 -0300, Eduardo Habkost wrote: > I don't think we should do that, unless users already had time to > update their scripts and libvirt had time to implement code > supporting the new method. > > I believe libvirt (and people's scripts) use maxcpus only when > they

[Qemu-devel] [PATCH] audio: pa: Set volume of recording stream instead of recording device

which was released on 2011-09-27. Signed-off-by: Peter Krempa <pkre...@redhat.com> --- This patch is keeping the old coding style by keeping the space after function name so that the styles are not mixed in this file. audio/paaudio.c | 11 +-- configure | 4 ++-- 2 files chan

Re: [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB

On Wed, Feb 24, 2016 at 18:54:45 +0100, Max Reitz wrote: > On 23.02.2016 18:16, Kevin Wolf wrote: > > Now that we can use drive_add to create new nodes without a BB, we also > > want to be able to delete such nodes again. > > > > Signed-off-by: Kevin Wolf > > --- > >

Re: [Qemu-devel] KVM call for agenda for 2016-03-01

On Thu, Feb 25, 2016 at 09:40:34 +0100, Thomas Huth wrote: > On 23.02.2016 16:33, Juan Quintela wrote: > > > > Hi > > > > Please, send any topic that you are interested in covering. > > > > At the end of Monday I will send an email with the agenda or the > > cancellation of the call, so hurry

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

On Fri, Jan 22, 2016 at 16:31:04 +0100, Markus Armbruster wrote: > "Denis V. Lunev" writes: > > On 01/19/2016 09:11 PM, Markus Armbruster wrote: > >> "Denis V. Lunev" writes: [...] > >> This would be like HMP savevm with the following differences: > >> > >> *

Re: [Qemu-devel] [PATCH 2/8] qmp: create qmp_savevm command

On Tue, Jan 19, 2016 at 19:11:05 +0100, Markus Armbruster wrote: > "Denis V. Lunev" writes: > > > On 01/18/2016 06:58 PM, Markus Armbruster wrote: > >> "Denis V. Lunev" writes: ... > > The overloaded interface you propose is more complex than it seems. You

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

On Wed, Dec 16, 2015 at 16:11:08 +0100, Igor Mammedov wrote: > On Fri, 11 Dec 2015 09:27:57 +0530 > Bharata B Rao wrote: > > > On Thu, Dec 10, 2015 at 01:35:05PM +0100, Igor Mammedov wrote: > > > On Thu, 10 Dec 2015 11:45:35 +0530 > > > Bharata B Rao

Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state

On Wed, Dec 16, 2015 at 12:32:13 +0300, Denis V. Lunev wrote: > On 12/16/2015 12:12 PM, Paolo Bonzini wrote: > > > > On 16/12/2015 10:00, Denis V. Lunev wrote: > >> With pvpanic or HyperV panic devices could be moved into the paused state > >> with ' preserve'. In this state VM reacts only to > >>

Re: [Qemu-devel] [PATCH 1/1] qmp: process system-reset event in paused state

On Wed, Dec 16, 2015 at 10:12:20 +0100, Paolo Bonzini wrote: > > > On 16/12/2015 10:00, Denis V. Lunev wrote: > > With pvpanic or HyperV panic devices could be moved into the paused state > > with ' preserve'. In this state VM reacts only to > > 'virsh destroy' or 'continue'. > > > > 'virsh

Re: [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug

On Fri, Nov 20, 2015 at 18:24:29 +0530, Bharata B Rao wrote: > This patchset adds CPU hotplug support for sPAPR PowerPC guests using > device_add and device_del commands > > (qemu) device_add POWER8-powerpc64-cpu,id=cpu0 Is there a reason why this uses 'device_add' rather than the 'cpu_add'

Re: [Qemu-devel] [PATCH 3/3] block/gluster: add support for multiple gluster servers

On Thu, Nov 05, 2015 at 07:45:50 -0500, Prasanna Kumar Kalever wrote: > On Thursday, November 5, 2015 6:07:06 PM, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple volfile servers to the gluster > > block backend of QEMU with tcp|rdma transport types and their port

Re: [Qemu-devel] [PATCH v9 3/3] block/gluster: add support for multiple gluster servers

On Wed, Oct 21, 2015 at 19:04:11 +0530, Prasanna Kumar Kalever wrote: ... > --- > block/gluster.c | 420 > +-- > qapi/block-core.json | 62 +++- > 2 files changed, 433 insertions(+), 49 deletions(-) > > diff --git a/block/gluster.c

Re: [Qemu-devel] [PATCH v7 1/1] block/gluster: add support for multiple gluster backup volfile servers

On Wed, Oct 14, 2015 at 12:36:58 +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currenly VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple volfile servers to the gluster > block backend of QEMU with tcp|rdma transport types and their port numbers. > > Problem: > > Currenly VM Image on gluster volume is specified like

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

[ trimmed the CC list for this ] On Wed, Oct 07, 2015 at 06:15:59 -0400, Prasanna Kalever wrote: > Hi Peter & Kevin, > > Thanks for your detailed review comments. I shall try to incorporate these > changes as a next patch-set. > > - Prasanna Kumar Kalever > > Please don't top post on

Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

On Tue, Sep 22, 2015 at 04:06:54 -0400, Prasanna Kalever wrote: > > > On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > > This patch adds a way to specify multiple backup volfile servers to the > > > gluster > > > block backend of QEMU with tcp|rdma transport types and their port > > >

Re: [Qemu-devel] [PATCH 1/1] block/gluster: add support for multiple gluster backup volfile servers

On Tue, Sep 08, 2015 at 18:34:09 +0530, Prasanna Kumar Kalever wrote: > This patch adds a way to specify multiple backup volfile servers to the > gluster > block backend of QEMU with both tcp and rdma transport types. > > Problem: > > Currenly VM Image on gluster volume is specified like this:

[Qemu-devel] [PATCH v2] util: socket: Add missing localaddr and localport option for DGRAM socket

://bugzilla.redhat.com/show_bug.cgi?id=1220252 Signed-off-by: Peter Krempa pkre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- Notes: Version 2: - improved commit message as suggested by Markus Cc: Markus Armbruster arm...@redhat.com util/qemu-sockets.c | 6 ++ 1 file changed, 6

[Qemu-devel] [PATCH] util: socket: Add missing localaddr and localport option for DGRAM socket

...@redhat.com Date: Thu Feb 12 17:52:20 2015 +0100 QemuOpts: Drop qemu_opt_set(), rename qemu_opt_set_err(), fix use Add the two fields so that the options can again be parsed correctly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1220252 Signed-off-by: Peter Krempa pkre...@redhat.com

Re: [Qemu-devel] [PATCH 1/2] qemu-options.hx: improve -m description

On Thu, Feb 26, 2015 at 14:49:15 -0500, Luiz Capitulino wrote: Add memory hotplug options to the command-line format. Also, add a complete command-line example and improve description. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx | 23 ++-

Re: [Qemu-devel] [PATCH 2/2] docs: add memory-hotplug.txt

On Thu, Feb 26, 2015 at 14:49:16 -0500, Luiz Capitulino wrote: This document describes how to use memory hotplug in QEMU. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- docs/memory-hotplug.txt | 77 + 1 file changed, 77

[Qemu-devel] [PATCHv3 0/2] pc: Fix startup with memory hotplug enabled

Tweak error messages to make sense and add check to verify that maxmem_size is properly aligned right away rather than just crashing afterwards. Peter Krempa (2): vl.c: Fix error messages when parsing maxmem parameters pc: memory: Validate alignment of maxram_size to page size hw/i386/pc.c

[Qemu-devel] [PATCHv3 1/2] vl.c: Fix error messages when parsing maxmem parameters

Produce more human readable error messages and fix few spelling mistakes. Also remove a redundant check for the max memory size. Signed-off-by: Peter Krempa pkre...@redhat.com --- Notes: Version 3: - forgot a word in one of the error messages Version 2: - fixed spacing

Re: [Qemu-devel] [PATCH v3 4/7] monitor: use cc-get_arch_id as the cpu index

On Thu, Jan 29, 2015 at 15:12:49 +0100, Igor Mammedov wrote: On Wed, 14 Jan 2015 15:27:27 +0800 Zhu Guihua zhugh.f...@cn.fujitsu.com wrote: From: Gu Zheng guz.f...@cn.fujitsu.com Use cc-get_arch_id as the cpu index to avoid the cpu index duplicated issue in the QMP/HMP command output.

[Qemu-devel] [PATCHv3 2/2] pc: memory: Validate alignment of maxram_size to page size

was originally added on the commandline qemu exits on the assertion failure. Signed-off-by: Peter Krempa pkre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- hw/i386/pc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c7af6aa..8cf405a 100644

[Qemu-devel] [PATCHv2 0/2] pc: Fix startup with memory hotplug enabled

Tweak error messages to make sense and add check to verify that maxmem_size is properly aligned right away rather than just crashing afterwards. Peter Krempa (2): vl.c: Fix error messages when parsing maxmem parameters pc: memory: Validate alignment of maxram_size to page size hw/i386/pc.c

[Qemu-devel] [PATCHv2 1/2] vl.c: Fix error messages when parsing maxmem parameters

Produce more human readable error messages and fix few spelling mistakes. Also remove a redundant check for the max memory size. Signed-off-by: Peter Krempa pkre...@redhat.com --- Notes: Version 2: - fixed spacing in error message - changed control flow to allow maxmem == ram_size

[Qemu-devel] [PATCHv2 2/2] pc: memory: Validate alignment of maxram_size to page size

was originally added on the commandline qemu exits on the assertion failure. Signed-off-by: Peter Krempa pkre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- hw/i386/pc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index c7af6aa..8cf405a 100644

Re: [Qemu-devel] [PATCHv2 1/2] vl.c: Fix error messages when parsing maxmem parameters

On Wed, Jan 28, 2015 at 13:29:41 +0100, Igor Mammedov wrote: On Wed, 28 Jan 2015 09:35:03 +0100 Peter Krempa pkre...@redhat.com wrote: Produce more human readable error messages and fix few spelling mistakes. Also remove a redundant check for the max memory size. Signed-off

Re: [Qemu-devel] [PATCH 1/2] vl.c: Fix error messages when parsing maxmem parameters

On Tue, Jan 27, 2015 at 11:15:41 -0700, Eric Blake wrote: On 01/26/2015 08:31 AM, Peter Krempa wrote: Produce more human readable error messages and fix few spelling mistakes. Also remove a redundant check for the max memory size. Signed-off-by: Peter Krempa pkre...@redhat.com

[Qemu-devel] [PATCH 1/2] vl.c: Fix error messages when parsing maxmem parameters

Produce more human readable error messages and fix few spelling mistakes. Also remove a redundant check for the max memory size. Signed-off-by: Peter Krempa pkre...@redhat.com --- vl.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/vl.c b/vl.c index

[Qemu-devel] [PATCH 2/2] pc: memory: Validate alignment of maxram_size to page size

was originally added on the commandline qemu exits on the assertion failure. Signed-off-by: Peter Krempa pkre...@redhat.com --- hw/i386/pc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e07f1fa..157eefe 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c

[Qemu-devel] [PATCH 0/2] pc: Fix startup with memory hotplug enabled

Tweak error messages to make sense and add check to verify that maxmem_size is properly aligned right away rather than just crashing afterwards. Peter Krempa (2): vl.c: Fix error messages when parsing maxmem parameters pc: memory: Validate alignment of maxram_size to page size hw/i386/pc.c

Re: [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible

On 05/14/14 14:36, Stefan Hajnoczi wrote: On Mon, May 12, 2014 at 10:07:07AM -0600, Eric Blake wrote: On 05/09/2014 01:03 PM, Stefan Hajnoczi wrote: From: Peter Krempa pkre...@redhat.com The docs for glfs_init suggest that the function sets errno on every failure. In fact it doesn't

[Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

The docs for glfs_init suggest that the function sets errno on every failure. In fact it doesn't. As other functions such as qemu_gluster_open() in the gluster block code report their errors based on this fact we need to make sure that errno is set on each failure. This fixes a crash of

Re: [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

On 05/09/14 13:39, Stefan Hajnoczi wrote: On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote: ... Please use scripts/checkpatch.pl to check coding style in the future. I added {} around the if statement body. QEMU always uses curlies even for 1-statement bodies. Ah, right

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

On 05/31/13 14:36, Eric Blake wrote: On 05/28/2013 12:34 AM, Gerd Hoffmann wrote: Fill unset CharDriverState-filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty

Re: [Qemu-devel] [PATCH 2/2] chardev: fix info chardev output

On 05/31/13 15:21, Gerd Hoffmann wrote: Hi, Hi, Please double-check. Current master (87d23f78aa79b72da022afda358bbc8a8509ca70 to be exact) works just fine for me. libvirt works, including a serial line redirected to pty, and 'info chardev' looks sane too. sorry for the fuzz. :/

Re: [Qemu-devel] [libvirt] [PATCH 2/4] QMP: add cpu-add command

On 04/30/13 15:46, Eduardo Habkost wrote: (CCing libvir-list) On Tue, Apr 30, 2013 at 08:34:01AM +0200, Igor Mammedov wrote: Adds cpu-add id=xxx QMP command. cpu-add's id argument is a CPU number in a range [0..max-cpus) Example QMP command: - { execute: cpu-add, arguments: { id: 2 } } -

Re: [Qemu-devel] [PATCH v2] New cpu-max field in query-machines QMP command output

On 04/09/13 15:06, Luiz Capitulino wrote: On Mon, 08 Apr 2013 11:14:32 -0600 Eric Blake ebl...@redhat.com wrote: On 04/08/2013 10:41 AM, Michal Novotny wrote: Alter the query-machines QMP command to output information about maximum number of CPUs for each machine type with default value set

Re: [Qemu-devel] virtio-rng and fd passing

On 03/01/13 21:04, Anthony Liguori wrote: Eric Blake ebl...@redhat.com writes: Stefan Berger and I discovered on IRC that virtio-rng is unable to support fd passing. We attempted: qemu-system-x86_64 ... -add-fd set=4,fd=34,opaque=RDONLY:/dev/urandom -object

<    1   2   3   4