Re: [PATCH v3] arm: Remove swift-bmc machine

2022-02-18 Thread Philippe Mathieu-Daudé via
On 17/2/22 11:31, Joel Stanley wrote: It was scheduled for removal in 7.0. Signed-off-by: Joel Stanley -- v2: also remove from docs/about/deprecated.rst v3: remove strap define, add note to removed-features.rst --- docs/about/deprecated.rst | 7 docs/about/removed-features.rst |

Re: [PATCH 2/2] qapi: Fix stale reference to scripts/qapi.py in a comment

2022-02-18 Thread Philippe Mathieu-Daudé via
On 18/2/22 15:55, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qapi/qapi-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v3 2/7] malta: Move PCI interrupt handling from gt64xxx_pci to piix4

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 23:45, Bernhard Beschow wrote: Handling PCI interrupts in piix4 increases cohesion and reduces differences between piix4 and piix3. Signed-off-by: Bernhard Beschow --- hw/isa/piix4.c | 55 ++ hw/mips/gt64xxx_pci.c | 60

Re: [PATCH v3 3/7] hw/isa/piix4: Resolve redundant i8259[] attribute

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 23:45, Bernhard Beschow wrote: This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx_pci to piix4" where i8259[] was moved from MaltaState to PIIX4State to make the code movement more obvious. However, i8259[] seems redundant to *isa, so remove it.

Re: [PATCH v3 7/7] hw/mips/gt64xxx_pci: Resolve gt64120_register()

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 23:45, Bernhard Beschow wrote: Now that gt64120_register() lost its pic parameter, there is an opportunity to remove it. gt64120_register() is old style by wrapping qdev API, and the new style is to use qdev directly. So take the opportunity and modernize the code. Suggested-by:

Re: [PATCH v3 6/7] hw/isa/piix4: Replace some magic IRQ constants

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 23:45, Bernhard Beschow wrote: This is a follow-up on patch "malta: Move PCI interrupt handling from gt64xxx_pci to piix4". gt64xxx_pci used magic constants, and probably didn't want to use piix4-specific constants. Now that the interrupt handing resides in piix4, its constants can be

Re: [PATCH] tests/tcg/s390x: Build tests with debian11

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 12:51, David Hildenbrand wrote: We need a newer compiler to build upcoming tests that test for z15 features with -march=z15. So let's do it similar to arm64 and powerpc, using an environment based on debian11 to build tests only. Cc: Thomas Huth Cc: Cornelia Huck Cc: Richard

Re: QEMU's Haiku CI image

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 17:32, Thomas Huth wrote: On 16/02/2022 16.52, Alexander von Gluck IV wrote: February 16, 2022 6:31 AM, "Thomas Huth" wrote: while researching the different "sed" options on our supported build platform today, I started "make vm-build-haiku.x86_64" in my QEMU build directory for

Re: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 17:42, Akihiko Odaki wrote: On 2022/02/17 0:08, Philippe Mathieu-Daudé wrote: On 16/2/22 11:19, Richard Henderson wrote: On 2/16/22 04:01, Philippe Mathieu-Daudé via wrote: GCC 10.1 introduced the -moutline-atomics option on Aarch64. This options is enabled by default, and triggers

Re: [PULL 0/5] 9p queue 2022-02-10

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 11:30, Christian Schoenebeck wrote: On Dienstag, 15. Februar 2022 08:01:37 CET Greg Kurz wrote: On Mon, 14 Feb 2022 17:43:51 +0300 Vitaly Chikunov wrote: Why g_new0 and not just g_malloc0? This is smallest code change, which seems appropriate for a bug fix. I prefer g_new0() for

Re: Undelivered Mail Returned to Sender

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 14:54, Joseph Fitzgerald (KM1P) wrote: Thank you for this trouble report. We recommend that Philippe subscribe to the qemu mailing list via a "real" mailing address rather than his f4...@amsat.org mail alias/forwarding address. Sigh, OK :( There is some combination of the Free

Re: [PATCH v2] tests/qemu-iotests: Rework the checks and spots using GNU sed

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 13:54, Thomas Huth wrote: Instead of failing the iotests if GNU sed is not available (or skipping them completely in the check-block.sh script), it would be better to simply skip the bash-based tests that rely on GNU sed, so that the other tests could still be run. Thus we now

Re: [PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 11:19, Richard Henderson wrote: On 2/16/22 04:01, Philippe Mathieu-Daudé via wrote: GCC 10.1 introduced the -moutline-atomics option on Aarch64. This options is enabled by default, and triggers a link failure:    Undefined symbols for architecture arm64

Re: [PATCH 1/6] arm: Remove swift-bmc machine

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 10:21, Cédric Le Goater wrote: From: Joel Stanley It was scheduled for removal in 7.0. Signed-off-by: Joel Stanley Message-Id: <20220216080947.65955-1-j...@jms.id.au> Signed-off-by: Cédric Le Goater --- docs/about/deprecated.rst | 7 - docs/system/arm/aspeed.rst | 1 -

Re: [PATCH 2/6] ast2600: Add Secure Boot Controller model

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 10:21, Cédric Le Goater wrote: From: Joel Stanley Just a stub that indicates the system has booted in secure boot mode. Used for testing the driver: https://lore.kernel.org/all/20211019080608.283324-1-j...@jms.id.au/ Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater

Re: [PATCH 3/6] aspeed: rainier: Add i2c LED devices

2022-02-16 Thread Philippe Mathieu-Daudé via
On 16/2/22 10:21, Cédric Le Goater wrote: From: Joel Stanley This helps quieten booting the current Rainier kernel. Signed-off-by: Joel Stanley Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/arm/aspeed.c

Re: [PATCH 1/4] python/utils: add enboxify() text decoration utility

2022-02-15 Thread Philippe Mathieu-Daudé via
On 16/2/22 00:53, John Snow wrote: On Tue, Feb 15, 2022 at 5:55 PM Eric Blake wrote: On Tue, Feb 15, 2022 at 05:08:50PM -0500, John Snow wrote: print(enboxify(msg, width=72, name="commit message")) ┏━ commit message ━┓ ┃ enboxify() takes a

Re: [PATCH] migration: Remove load_state_old and minimum_version_id_old

2022-02-15 Thread Philippe Mathieu-Daudé via
On 15/2/22 18:57, Peter Maydell wrote: There are no longer any VMStateDescription structs in the tree which use the load_state_old support for custom handling of incoming migration from very old QEMU. Remove the mechanism entirely. This includes removing one stray useless setting of

[PATCH v2 7/8] audio: Rename coreaudio extension to use Objective-C compiler

2022-02-15 Thread Philippe Mathieu-Daudé via
The coreaudio library includes Objective-C declarations (using the caret '^' symbol to declare block references [*]). When building with a C compiler we get: [175/839] Compiling C object libcommon.fa.p/audio_coreaudio.c.o In file included from

[PATCH v2 6/8] configure: Pass filtered QEMU_OBJCFLAGS to meson

2022-02-15 Thread Philippe Mathieu-Daudé via
Filter unsupported Objective-C options, to avoid 'unknown-warning-option' warnings when using Clang: [34/373] Compiling Objective-C object libcommon.fa.p/audio_coreaudio.m.o warning: unknown warning option '-Wold-style-declaration'; did you mean '-Wout-of-line-declaration'?

[PATCH v2 5/8] meson: Log QEMU_CXXFLAGS content in summary

2022-02-15 Thread Philippe Mathieu-Daudé via
Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index 287be51ff2..215c253683 100644 --- a/meson.build +++ b/meson.build @@ -3305,6 +3305,7 @@ if link_args.length() > 0 summary_info += {'LDFLAGS': '

[PATCH v2 2/8] osdep: Ignore 'unguarded-availability-new' warnings on macOS Catalina

2022-02-15 Thread Philippe Mathieu-Daudé via
When building with GCC on macOS Catalina we get 2254 times: include/qemu/osdep.h:780:5: warning: 'pthread_jit_write_protect_np' is only available on macOS 11.0 or newer [-Wunguarded-availability-new] pthread_jit_write_protect_np(true); ^~~~ Fix by using a

[PATCH v2 0/8] buildsys: More fixes to use GCC on macOS

2022-02-15 Thread Philippe Mathieu-Daudé via
Few fixes to be able to use GCC extensions which are not available on Clang. Since RFC: - Split Clang __builtin_available() patch - Do not un-inline qemu_thread_jit_execute/write - Do not use #pragma diagnostic - Demote ui/cocoa key arrays to static const - Lookup scripts/entitlement.sh script

[PATCH v2 8/8] ui/cocoa: Constify qkeycode translation arrays

2022-02-15 Thread Philippe Mathieu-Daudé via
Reported-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daudé --- ui/cocoa.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 30702d31a5..7a3a610212 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -651,7 +651,7 @@ QemuCocoaView *cocoaView;

[PATCH v2 1/8] osdep: Avoid using Clang-specific __builtin_available()

2022-02-15 Thread Philippe Mathieu-Daudé via
Remove the Clang specific __builtin_available() to allow building with GCC, otherwise we get: include/qemu/osdep.h: In function 'qemu_thread_jit_write': include/qemu/osdep.h:787:9: warning: implicit declaration of function '__builtin_available'; did you mean '__builtin_scalbl'?

[PATCH v2 3/8] meson: Resolve the entitlement.sh script once for good

2022-02-15 Thread Philippe Mathieu-Daudé via
Commit 235b523dba ("meson: Use find_program() to resolve the entitlement.sh script") didn't correctly fixed the issue, as the script is still resolved for each target. Move the check earlier, before processing each target. Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 5 - 1 file

[PATCH v2 4/8] configure: Disable out-of-line atomic operations on Aarch64

2022-02-15 Thread Philippe Mathieu-Daudé via
GCC 10.1 introduced the -moutline-atomics option on Aarch64. This options is enabled by default, and triggers a link failure: Undefined symbols for architecture arm64: "___aarch64_cas1_acq_rel", referenced from: _qmp_migrate_recover in migration_migration.c.o

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

2022-02-15 Thread Philippe Mathieu-Daudé via
On 15/2/22 14:45, Peter Maydell wrote: On Tue, 15 Feb 2022 at 13:18, Christian Schoenebeck wrote: On Dienstag, 15. Februar 2022 13:06:25 CET Philippe Mathieu-Daudé via wrote: We globally ignore the 'initializer overrides' warnings in C code since commit c1556a812a ("configure: Disable (

Re: [PATCH 2/4] osdep: Un-inline qemu_thread_jit_execute/write

2022-02-15 Thread Philippe Mathieu-Daudé via
On 15/2/22 14:09, Akihiko Odaki wrote: On Tue, Feb 15, 2022 at 9:06 PM Philippe Mathieu-Daudé wrote: qemu_thread_jit_execute() and qemu_thread_jit_write() call pthread_jit_write_protect_np() which is declared in "pthread.h". Since we don't want all C files to preprocess unused headers, avoid

Re: [RFC PATCH 0/4] buildsys: More fixes to use GCC on macOS

2022-02-15 Thread Philippe Mathieu-Daudé via
On 15/2/22 14:06, Akihiko Odaki wrote: On Tue, Feb 15, 2022 at 9:06 PM Philippe Mathieu-Daudé wrote: Few fixes to be able to use GCC extensions which are not available on Clang. Philippe Mathieu-Daudé (4): osdep: Avoid using Clang-specific __builtin_available() osdep: Un-inline

Re: [RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

2022-02-15 Thread Philippe Mathieu-Daudé via
On 15/2/22 14:19, Akihiko Odaki wrote: On Tue, Feb 15, 2022 at 9:35 PM Peter Maydell wrote: On Tue, 15 Feb 2022 at 12:13, Philippe Mathieu-Daudé via wrote: We globally ignore the 'initializer overrides' warnings in C code since commit c1556a812a ("configure: Disable (clang) initia

[RFC PATCH 3/4] audio: Rename coreaudio extension to use Objective-C compiler

2022-02-15 Thread Philippe Mathieu-Daudé via
The coreaudio library includes Objective-C declarations (using the caret '^' symbol to declare block references [*]). When building with a C compiler we get: [175/839] Compiling C object libcommon.fa.p/audio_coreaudio.c.o In file included from

[RFC PATCH 4/4] ui/cocoa: Ignore 'initializer overrides' warnings

2022-02-15 Thread Philippe Mathieu-Daudé via
We globally ignore the 'initializer overrides' warnings in C code since commit c1556a812a ("configure: Disable (clang) initializer-overrides warnings"). Unfortunately the ${gcc_flags} variable is not propagated to Objective-C flags ($OBJCFLAGS). Instead of reworking the configure script to test

[PATCH 2/4] osdep: Un-inline qemu_thread_jit_execute/write

2022-02-15 Thread Philippe Mathieu-Daudé via
qemu_thread_jit_execute() and qemu_thread_jit_write() call pthread_jit_write_protect_np() which is declared in "pthread.h". Since we don't want all C files to preprocess unused headers, avoid adding yet another header here and move the function definitions to osdep.c, un-inlining them.

[RFC PATCH 0/4] buildsys: More fixes to use GCC on macOS

2022-02-15 Thread Philippe Mathieu-Daudé via
Few fixes to be able to use GCC extensions which are not available on Clang. Philippe Mathieu-Daudé (4): osdep: Avoid using Clang-specific __builtin_available() osdep: Un-inline qemu_thread_jit_execute/write audio: Rename coreaudio extension to use Objective-C compiler ui/cocoa: Ignore

[RFC PATCH 1/4] osdep: Avoid using Clang-specific __builtin_available()

2022-02-15 Thread Philippe Mathieu-Daudé via
Replace MAC_OS_X_VERSION_MAX_ALLOWED upper check by the lower one (MAC_OS_X_VERSION_MIN_REQUIRED) and remove the Clang specific __builtin_available() to allow building with GCC. Remove the Clang specific __builtin_available() to allow building with GCC, otherwise we get: include/qemu/osdep.h:

Re: qdev instance_init vs realize split

2022-02-15 Thread Philippe Mathieu-Daudé via
On 15/2/22 11:19, Damien Hedde wrote: Hi, I'm wondering if there are rules or convention about what we put in the instance_init() vs realize() for simple devices ? (For complex ones we generally have no choice to put everything in realize()) See Peter's recommendations here:

[PATCH v6 15/15] gitlab-ci: Support macOS 12 via cirrus-run

2022-02-15 Thread Philippe Mathieu-Daudé via
Add support for macOS 12 build on Cirrus-CI, similarly to commit 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"), but with the following differences: - Enable modules (configure --enable-modules) - Do not run softfloat3 tests (make check-softfloat) - Run Aarch64 qtests instead

[PATCH v6 13/15] ui/cocoa: Fix the leak of qemu_console_get_label

2022-02-15 Thread Philippe Mathieu-Daudé via
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220213021329.2066-1-akihiko.od...@gmail.com> [PMD: Use g_autofree, suggested by Zoltan BALATON] Signed-off-by: Philippe Mathieu-Daudé --- ui/cocoa.m | 4 +++- 1 file changed, 3 insertions(+),

[PATCH v6 10/15] ui/cocoa: Remove allowedFileTypes restriction in SavePanel

2022-02-15 Thread Philippe Mathieu-Daudé via
setAllowedFileTypes is deprecated in macOS 12. Per Akihiko Odaki [*]: An image file, which is being chosen by the panel, can be a raw file and have a variety of file extensions and many are not covered by the provided list (e.g. "udf"). Other platforms like GTK can provide an option to

[PATCH v6 11/15] ui/cocoa: Add Services menu

2022-02-15 Thread Philippe Mathieu-Daudé via
From: Akihiko Odaki Services menu functionality of Cocoa is described at: https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/ Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v6 08/15] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-15 Thread Philippe Mathieu-Daudé via
When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElementMaster ^

[PATCH v6 09/15] audio/dbus: Fix building with modules on macOS

2022-02-15 Thread Philippe Mathieu-Daudé via
When configuring QEMU with --enable-modules we get on macOS: --- stderr --- Dependency ui-dbus cannot be satisfied ui-dbus depends on pixman and opengl, so add these dependencies to audio-dbus. Fixes: 739362d420 ("audio: add "dbus" audio backend") Reviewed-by: Li Zhang Signed-off-by:

[PATCH v6 06/15] hvf: Remove deprecated hv_vcpu_flush() calls

2022-02-15 Thread Philippe Mathieu-Daudé via
When building on macOS 11 [*], we get: In file included from ../target/i386/hvf/hvf.c:59: ../target/i386/hvf/vmx.h:174:5: error: 'hv_vcpu_flush' is deprecated: first deprecated in macOS 11.0 - This API has no effect and always returns HV_UNSUPPORTED [-Werror,-Wdeprecated-declarations]

[PATCH v6 07/15] block/file-posix: Remove a deprecation warning on macOS 12

2022-02-15 Thread Philippe Mathieu-Daudé via
When building on macOS 12 we get: block/file-posix.c:3335:18: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations] kernResult = IOMasterPort( MACH_PORT_NULL, ); ^~~~ IOMainPort Replace by

[PATCH v6 14/15] lcitool: Refresh

2022-02-15 Thread Philippe Mathieu-Daudé via
Run 'make lcitool-refresh' again. Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/ubuntu1804.docker | 2 -- tests/docker/dockerfiles/ubuntu2004.docker | 2 -- 2 files changed, 4 deletions(-) diff --git a/tests/docker/dockerfiles/ubuntu1804.docker

[PATCH v6 01/15] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-15 Thread Philippe Mathieu-Daudé via
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Christian Schoenebeck Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220213021215.1974-1-akihiko.od...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v6 12/15] ui/cocoa: Do not alert even without block devices

2022-02-15 Thread Philippe Mathieu-Daudé via
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220213021418.2155-1-akihiko.od...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- ui/cocoa.m | 5 - 1 file changed, 5 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index becca58cb7..6cadd43309 100644 ---

[PATCH v6 03/15] tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directives

2022-02-15 Thread Philippe Mathieu-Daudé via
Since we already use -Wno-unknown-pragmas, we can also use -Wno-ignored-pragmas. This silences hundred of warnings using clang 13 on macOS Monterey: [409/771] Compiling C object tests/fp/libtestfloat.a.p/berkeley-testfloat-3_source_test_az_f128_rx.c.o

[PATCH v6 00/15] host: Support macOS 12

2022-02-15 Thread Philippe Mathieu-Daudé via
Few patches to be able to build QEMU on macOS 12 (Monterey). Since v5: - Fixed failed rebase between patches 10 and 16 (Akihiko) - Include "ui/cocoa: Fix the leak of qemu_console_get_label" Since v4: - Use MAC_OS_X_VERSION_MIN_REQUIRED definition (Akihiko) - Include patches from Akihiko Since

[PATCH v6 04/15] hvf: Use standard CR0 and CR4 register definitions

2022-02-15 Thread Philippe Mathieu-Daudé via
From: Cameron Esfahani No need to have our own definitions of these registers. Signed-off-by: Cameron Esfahani Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h | 17 + target/i386/hvf/x86.c | 6 +++---

[PATCH v6 05/15] hvf: Make hvf_get_segments() / hvf_put_segments() local

2022-02-15 Thread Philippe Mathieu-Daudé via
Both hvf_get_segments/hvf_put_segments() functions are only used within x86hvf.c: do not declare them as public API. Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/x86hvf.c | 4 ++-- target/i386/hvf/x86hvf.h | 2 -- 2 files

[PATCH v6 02/15] configure: Allow passing extra Objective C compiler flags

2022-02-15 Thread Philippe Mathieu-Daudé via
We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment variables, or via configure --extra-cflags / --extra-cxxflags / --extra-ldflags options. Provide similar behavior for Objective C: use existing flags from $OBJCFLAGS, or passed via --extra-objcflags. Signed-off-by: Philippe

Re: [PATCH] ui/cocoa: Fix the leak of qemu_console_get_label

2022-02-15 Thread Philippe Mathieu-Daudé via
On 13/2/22 12:11, BALATON Zoltan wrote: On Sun, 13 Feb 2022, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index ac18e14ce01..fdf52a7c2f7 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m

Re: [PULL 15/28] tests: Update CentOS 8 container to CentOS Stream 8

2022-02-14 Thread Philippe Mathieu-Daudé via
Hi Thomas, On 9/2/22 15:15, Alex Bennée wrote: From: Thomas Huth Support for CentOS 8 has stopped at the end of 2021, so let's switch to the Stream variant instead. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

Re: [PATCH v5 10/16] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-14 Thread Philippe Mathieu-Daudé via
On 15/2/22 07:53, Akihiko Odaki wrote: On Tue, Feb 15, 2022 at 3:57 AM Philippe Mathieu-Daudé wrote: When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations]

[NOTFORMERGE PATCH 1/1] target: Add system emulation aiming to target any architecture

2022-02-14 Thread Philippe Mathieu-Daudé via
Add the 'any'-architecture target. - Only consider 64-bit targets - Do not use any hardware accelerator (except qtest) - For architecture constants, use: . max of supported targets phys/virt address space . max of supported targets MMU modes . min of supported targets variable page bits

[NOTFORMERGE PATCH 0/1] target: Toward heterogeneous machine

2022-02-14 Thread Philippe Mathieu-Daudé via
Hi, following last week KVM call [1], I'm posting my playground machine to slowly work toward heterogeneous QEMU. This is orthogonal to Paolo / Markus / Daniel effort to have a qemu-system-qmp CLI entrypoint [2]. After refactoring a bit the headers to remove target-specific dependencies, we can

Re: [PATCH v6 09/11] 9p: darwin: Implement compatibility for mknodat

2022-02-14 Thread Philippe Mathieu-Daudé via
On 10/2/22 14:29, Will Cohen wrote: From: Keno Fischer Darwin does not support mknodat. However, to avoid race conditions with later setting the permissions, we must avoid using mknod on the full path instead. We could try to fchdir, but that would cause problems if multiple threads try to

Re: [PATCH 1/3] ui/console: fix crash when using gl context with non-gl listeners

2022-02-14 Thread Philippe Mathieu-Daudé via
On 14/2/22 21:13, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau The commit 7cc712e98 ("ui: dispatch GL events to all listener") mechanically replaced the dpy_gl calls with a dispatch loop, using the same pre-conditions. However, it didn't take into account that all listeners do

Re: [PATCH 1/1] vdpa: Make ncs autofree

2022-02-14 Thread Philippe Mathieu-Daudé via
On 14/2/22 20:34, Eugenio Pérez wrote: Simplifying memory management. Signed-off-by: Eugenio Pérez --- net/vhost-vdpa.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v5 15/16] lcitool: refresh

2022-02-14 Thread Philippe Mathieu-Daudé via
Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/dockerfiles/ubuntu1804.docker | 2 -- tests/docker/dockerfiles/ubuntu2004.docker | 2 -- 2 files changed, 4 deletions(-) diff --git a/tests/docker/dockerfiles/ubuntu1804.docker b/tests/docker/dockerfiles/ubuntu1804.docker index

[PATCH v5 14/16] ui/cocoa: Do not alert even without block devices

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Message-Id: <20220213021418.2155-1-akihiko.od...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- ui/cocoa.m | 5 - 1 file changed, 5 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index becca58cb7..6cadd43309 100644 ---

[PATCH v5 13/16] ui/cocoa: Add Services menu

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Akihiko Odaki Services menu functionality of Cocoa is described at: https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/ Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v5 10/16] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-14 Thread Philippe Mathieu-Daudé via
When building on macOS 12 we get: audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations] kAudioObjectPropertyElementMaster ^

[PATCH v5 09/16] block/file-posix: Remove a deprecation warning on macOS 12

2022-02-14 Thread Philippe Mathieu-Daudé via
When building on macOS 12 we get: block/file-posix.c:3335:18: warning: 'IOMasterPort' is deprecated: first deprecated in macOS 12.0 [-Wdeprecated-declarations] kernResult = IOMasterPort( MACH_PORT_NULL, ); ^~~~ IOMainPort Replace by

[PATCH v5 01/16] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Akihiko Odaki Signed-off-by: Akihiko Odaki Reviewed-by: Christian Schoenebeck Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220213021215.1974-1-akihiko.od...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v5 11/16] audio/dbus: Fix building with modules on macOS

2022-02-14 Thread Philippe Mathieu-Daudé via
When configuring QEMU with --enable-modules we get on macOS: --- stderr --- Dependency ui-dbus cannot be satisfied ui-dbus depends on pixman and opengl, so add these dependencies to audio-dbus. Fixes: 739362d420 ("audio: add "dbus" audio backend") Reviewed-by: Li Zhang Signed-off-by:

[PATCH v5 12/16] ui/cocoa: Remove allowedFileTypes restriction in SavePanel

2022-02-14 Thread Philippe Mathieu-Daudé via
setAllowedFileTypes is deprecated in macOS 12. Per Akihiko Odaki [*]: An image file, which is being chosen by the panel, can be a raw file and have a variety of file extensions and many are not covered by the provided list (e.g. "udf"). Other platforms like GTK can provide an option to

[PATCH v5 05/16] hvf: Fix OOB write in RDTSCP instruction decode

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Cameron Esfahani A guest could craft a specific stream of instructions that will have QEMU write 0xF9 to inappropriate locations in memory. Add additional asserts to check for this. Generate a #UD if there are more than 14 prefix bytes. Found by Julian Stecklina Signed-off-by: Cameron

[PATCH v5 16/16] gitlab-ci: Support macOS 12 via cirrus-run

2022-02-14 Thread Philippe Mathieu-Daudé via
Add support for macOS 12 build on Cirrus-CI, similarly to commit 0e103a65ba1 ("gitlab: support for ... macOS 11 via cirrus-run"), but with the following differences: - Enable modules (configure --enable-modules) - Do not run softfloat3 tests (make check-softfloat) - Run Aarch64 qtests instead

[PATCH v5 08/16] hvf: Remove deprecated hv_vcpu_flush() calls

2022-02-14 Thread Philippe Mathieu-Daudé via
When building on macOS 11 [*], we get: In file included from ../target/i386/hvf/hvf.c:59: ../target/i386/hvf/vmx.h:174:5: error: 'hv_vcpu_flush' is deprecated: first deprecated in macOS 11.0 - This API has no effect and always returns HV_UNSUPPORTED [-Werror,-Wdeprecated-declarations]

[PATCH v5 04/16] hvf: Use standard CR0 and CR4 register definitions

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Cameron Esfahani No need to have our own definitions of these registers. Signed-off-by: Cameron Esfahani Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h | 17 + target/i386/hvf/x86.c | 6 +++---

[PATCH v5 07/16] hvf: Make hvf_get_segments() / hvf_put_segments() local

2022-02-14 Thread Philippe Mathieu-Daudé via
Both hvf_get_segments/hvf_put_segments() functions are only used within x86hvf.c: do not declare them as public API. Reviewed-by: Roman Bolshakov Tested-by: Roman Bolshakov Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/x86hvf.c | 4 ++-- target/i386/hvf/x86hvf.h | 2 -- 2 files

[PATCH v5 06/16] hvf: Enable RDTSCP support

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Cameron Esfahani Pass through RDPID and RDTSCP support in CPUID if host supports it. Correctly detect if CPU_BASED_TSC_OFFSET and CPU_BASED2_RDTSCP would be supported in primary and secondary processor-based VM-execution controls. Enable RDTSCP in secondary processor controls if RDTSCP

[PATCH v5 03/16] tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directives

2022-02-14 Thread Philippe Mathieu-Daudé via
Since we already use -Wno-unknown-pragmas, we can also use -Wno-ignored-pragmas. This silences hundred of warnings using clang 13 on macOS Monterey: [409/771] Compiling C object tests/fp/libtestfloat.a.p/berkeley-testfloat-3_source_test_az_f128_rx.c.o

[PATCH v5 00/16] host: Support macOS 12

2022-02-14 Thread Philippe Mathieu-Daudé via
Few patches to be able to build QEMU on macOS 12 (Monterey). This basically consists of adapting deprecated APIs. CI job added to avoid bitrotting. Since v4: - Use MAC_OS_X_VERSION_MIN_REQUIRED definition (Akihiko) - Include patches from Akihiko Since v3: - Fix --enable-modules - Ignore

[PATCH v2 11/14] target: Use forward declared type instead of structure type

2022-02-14 Thread Philippe Mathieu-Daudé via
The CPU / CPU state are forward declared. $ git grep -E 'struct [A-Za-z]+CPU\ \*' target/arm/hvf_arm.h:16:void hvf_arm_set_cpu_features_from_host(struct ARMCPU *cpu); target/openrisc/cpu.h:234:int (*cpu_openrisc_map_address_code)(struct OpenRISCCPU *cpu, target/openrisc/cpu.h:238:

[PATCH v5 02/16] configure: Allow passing extra Objective C compiler flags

2022-02-14 Thread Philippe Mathieu-Daudé via
We can pass C/CPP/LD flags via CFLAGS/CXXFLAGS/LDFLAGS environment variables, or via configure --extra-cflags / --extra-cxxflags / --extra-ldflags options. Provide similar behavior for Objective C: use existing flags from $OBJCFLAGS, or passed via --extra-objcflags. Signed-off-by: Philippe

[PATCH v2 10/14] target/hexagon: Add missing 'hw/core/cpu.h' include

2022-02-14 Thread Philippe Mathieu-Daudé via
HexagonCPU field parent_class is of type CPUClass, which is declared in "hw/core/cpu.h". Signed-off-by: Philippe Mathieu-Daudé --- target/hexagon/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h index 096aa2deb6..76cd1d5021 100644 ---

[PATCH v2 13/14] target: Introduce and use OBJECT_DECLARE_CPU_TYPE() macro

2022-02-14 Thread Philippe Mathieu-Daudé via
Replace the boilerplate code to declare CPU QOM types and macros, and forward-declare the CPU instance type. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 18 ++ target/alpha/cpu-qom.h | 3 +-- target/alpha/cpu.h | 2 --

[PATCH v2 12/14] target: Use CPUArchState as interface to target-specific CPU state

2022-02-14 Thread Philippe Mathieu-Daudé via
While CPUState is our interface with generic code, CPUArchState is our interface with target-specific code. Use CPUArchState as an abstract type, defined by each target. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/exec/poison.h | 2 --

[PATCH v2 09/14] target: Include missing 'cpu.h'

2022-02-14 Thread Philippe Mathieu-Daudé via
These target-specific files use the target-specific CPU state but lack to include "cpu.h"; i.e.: ../target/riscv/pmp.h:61:23: error: unknown type name 'CPURISCVState' void pmpcfg_csr_write(CPURISCVState *env, uint32_t reg_index, ^ ../target/nios2/mmu.h:43:18:

[PATCH v2 14/14] target: Use ArchCPU as interface to target CPU

2022-02-14 Thread Philippe Mathieu-Daudé via
ArchCPU is our interface with target-specific code. Use it as a forward-declared opaque pointer (abstract type), having its structure defined by each target. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 4 ++-- include/qemu/typedefs.h | 1 + target/alpha/cpu.h | 2 +-

[PATCH v2 07/14] target/i386/tcg/sysemu: Include missing 'exec/exec-all.h' header

2022-02-14 Thread Philippe Mathieu-Daudé via
excp_helper.c requires "exec/exec-all.h" for tlb_set_page_with_attrs() and misc_helper.c for tlb_flush(). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/tcg/sysemu/excp_helper.c | 1 + target/i386/tcg/sysemu/misc_helper.c | 1 + 2 files changed, 2

[PATCH v2 05/14] cpu: Add missing 'exec/exec-all.h' and 'qemu/accel.h' headers

2022-02-14 Thread Philippe Mathieu-Daudé via
cpu.c requires "exec/exec-all.h" to call tlb_flush() and "qemu/accel.h" to call accel_cpu_realizefn(). Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpu.c b/cpu.c index d5d4cbf8cb..d564886149 100644 ---

[PATCH v2 06/14] target/i386/cpu: Ensure accelerators set CPU addressble physical bits

2022-02-14 Thread Philippe Mathieu-Daudé via
The only accelerator allowed to use zero as default value is TCG. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index aa9e636800..16523a78d9 100644 ---

[PATCH v2 08/14] Hexagon (target/hexagon) convert to OBJECT_DECLARE_TYPE

2022-02-14 Thread Philippe Mathieu-Daudé via
From: Taylor Simpson Suggested-by: Richard Henderson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20220211033034.21107-1-tsimp...@quicinc.com> [PMD: Add missing "qom/object.h" include] Signed-off-by: Philippe Mathieu-Daudé ---

[PATCH v2 04/14] exec/cpu_ldst: Include 'cpu.h' to get target_ulong definition

2022-02-14 Thread Philippe Mathieu-Daudé via
Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/exec/cpu_ldst.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h index da987fe8ad..6adacf8928 100644 --- a/include/exec/cpu_ldst.h +++ b/include/exec/cpu_ldst.h

[PATCH v2 01/14] meson: Display libfdt as disabled when system emulation is disabled

2022-02-14 Thread Philippe Mathieu-Daudé via
When configuring QEMU with --disable-system, meson keeps showing libfdt as "auto". Mark it as disabled instead. Acked-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index

[PATCH v2 03/14] hw/tricore: Remove unused and incorrect header

2022-02-14 Thread Philippe Mathieu-Daudé via
TriCore boards certainly don't need the ARM loader API :) Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- include/hw/tricore/triboard.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/tricore/triboard.h

[PATCH v2 02/14] hw/m68k/mcf: Add missing 'exec/hwaddr.h' header

2022-02-14 Thread Philippe Mathieu-Daudé via
hwaddr type is defined in "exec/hwaddr.h". Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- include/hw/m68k/mcf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/m68k/mcf.h b/include/hw/m68k/mcf.h index decf17ce42..8cbd587bbf

[PATCH v2 00/14] target: Use ArchCPU & CPUArchState as abstract interface to target CPU

2022-02-14 Thread Philippe Mathieu-Daudé via
Missing review: 10, 13, 14 Since v1: - Include Hexagon OBJECT_DECLARE_TYPE() patch - Add missing includes to Hexagon - Introduce OBJECT_DECLARE_CPU_TYPE() macro - Use OBJECT_DECLARE_CPU_TYPE() Kind of respin of the "exec: Move translation declarations to 'translate-all.h'" series, but without

Re: [PATCH v4 05/13] hvf: Fix OOB write in RDTSCP instruction decode

2022-02-14 Thread Philippe Mathieu-Daudé via
Hi Cameron, On 11/2/22 17:34, Philippe Mathieu-Daudé wrote: From: Cameron Esfahani A guest could craft a specific stream of instructions that will have QEMU write 0xF9 to inappropriate locations in memory. Add additional asserts to check for this. Generate a #UD if there are more than 14

Re: [PATCH v4 10/13] audio/coreaudio: Remove a deprecation warning on macOS 12

2022-02-14 Thread Philippe Mathieu-Daudé via
On 12/2/22 16:23, Akihiko Odaki wrote: On 2022/02/12 1:34, Philippe Mathieu-Daudé via wrote: When building on macOS 12 we get:    audio/coreaudio.c:50:5: error: 'kAudioObjectPropertyElementMaster' is deprecated: first deprecated in macOS 12.0 [-Werror,-Wdeprecated-declarations

Re: [PATCH v4 01/13] lcitool: refresh

2022-02-14 Thread Philippe Mathieu-Daudé via
On 12/2/22 16:14, Akihiko Odaki wrote: On 2022/02/12 1:34, Philippe Mathieu-Daudé via wrote: Signed-off-by: Philippe Mathieu-Daudé ---   tests/docker/dockerfiles/ubuntu1804.docker | 2 --   tests/docker/dockerfiles/ubuntu2004.docker | 2 --   2 files changed, 4 deletions(-) diff --git a/tests

Re: [PATCH] ui/cocoa: Do not alert even without block devices

2022-02-14 Thread Philippe Mathieu-Daudé via
On 13/2/22 03:14, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 5 - 1 file changed, 5 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index ac18e14ce01..271a2676026 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1715,11 +1715,6 @@ static void

Re: [PATCH] ui/cocoa: Add Services menu

2022-02-14 Thread Philippe Mathieu-Daudé via
On 14/2/22 10:13, Akihiko Odaki wrote: Services menu functionality of Cocoa is described at: https://developer.apple.com/design/human-interface-guidelines/macos/extensions/services/ Signed-off-by: Akihiko Odaki --- ui/cocoa.m | 4 1 file changed, 4 insertions(+) Reviewed-by: Philippe

Re: [PATCH] MAINTAINERS: Add Akihiko Odaki to macOS-relateds

2022-02-14 Thread Philippe Mathieu-Daudé via
On 13/2/22 03:12, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2fd74c46426..5aefb5b431a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2333,6 +2333,7 @@ F: audio/alsaaudio.c Core

Re: [PATCH] MAINTAINERS: no need to add my name explicitly as a reviewer for VIOT tables

2022-02-14 Thread Philippe Mathieu-Daudé via
On 14/2/22 13:01, Ani Sinha wrote: I am already listed as a reviewer for ACPI/SMBIOS subsystem. There is no need to again add me as a reviewer for ACPI/VIOT. Signed-off-by: Ani Sinha --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index

<    1   2   3   4   5   6   7   8   9   10   >