L, NULL); }
> EOF
>if compile_object "$libssh_cflags -DHAVE_LIBSSH_0_8"; then
> libssh_cflags="-DHAVE_LIBSSH_0_8 $libssh_cflags"
> + else
> +# If this is not libssh 0.8, this is likely 0.7
> +libssh_version="0.7"
>fi
Not sure why this though -- please leave it out, and just log the
version as found.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
s="-DHAVE_SSH_GET_SERVER_PUBLICKEY $libssh_cflags"
>fi
> + if ! compile_object "$libssh_cflags"; then
> +error_exit "cannot use with libssh (is it broken?)"
> + fi
Ugh no, this is way more twisted and complex than really needed.
Instead, just add another build time check for
ssh_session_is_known_server, and change check_host_key_knownhosts to
use it only when found.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
pto?
>
> $ pkg-config --libs libssh openssl
> -lssh -lssl -lcrypto
Definitely not! The crypto library is an internal implementation of
libssh, so please do not assume libssh is built against openssl.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
ER_PUBLICKEY"; then
> +libssh_cflags="-DHAVE_SSH_GET_SERVER_PUBLICKEY $libssh_cflags"
> + fi
Why try to compile it twice? If the check for ssh_get_server_publickey
works, then it is available...
Just add an additional HAVE_SSH_GET_SERVER_PUBLICKEY define when this
test succeeds, and change the usage of ssh_get_server_publickey based
on this.
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
On Monday, 29 July 2019 12:57:40 CEST Markus Armbruster wrote:
> Pino Toscano writes:
>
> > On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote:
> >> On 7/26/19 9:09 AM, Pino Toscano wrote:
> >> > Add a 'private-key' option which represents
On Friday, 26 July 2019 16:24:34 CEST Eric Blake wrote:
> On 7/26/19 9:09 AM, Pino Toscano wrote:
> > Add a 'private-key' option which represents the path of a private key
> > to use for authentication, and 'private-key-secret' as the name of an
> > object
On Friday, 26 July 2019 16:27:11 CEST Richard W.M. Jones wrote:
> On Fri, Jul 26, 2019 at 04:09:52PM +0200, Pino Toscano wrote:
> > These two patches add the password and private key authentication
> > methods to the ssh block driver, using secure objects for
> > passwords/pa
Add a 'private-key' option which represents the path of a private key
to use for authentication, and 'private-key-secret' as the name of an
object with its passphrase.
Signed-off-by: Pino Toscano
---
block/ssh.c | 98
Add a 'password-secret' option which represents the name of an object
with the password of the user.
Signed-off-by: Pino Toscano
---
block/ssh.c | 35 ---
block/trace-events | 1 +
docs/qemu-block-drivers.texi | 7 +--
These two patches add the password and private key authentication
methods to the ssh block driver, using secure objects for
passwords/passphrases.
Pino Toscano (2):
ssh: implement password authentication
ssh: implement private key authentication
block/ssh.c | 133
On Monday, 24 June 2019 14:20:11 CEST Max Reitz wrote:
> On 23.06.19 19:18, Peter Maydell wrote:
> > On Fri, 21 Jun 2019 at 14:23, Max Reitz wrote:
> >>
> >> The following changes since commit
> >> 33d609990621dea6c7d056c86f707b8811320ac1:
> >>
> >> Merge remote-tracking branch 'remotes/kevin/t
On Thursday, 20 June 2019 14:58:40 CEST Max Reitz wrote:
> On 20.06.19 11:49, Pino Toscano wrote:
> > On Tuesday, 18 June 2019 15:14:30 CEST Max Reitz wrote:
> >> On 18.06.19 11:24, Pino Toscano wrote:
> >>> Rewrite the implementation of the ssh block driver to use l
Adjust the various Docker/Travis scripts to use libssh when available
instead of libssh2. The mingw/mxe testing is dropped for now, as there
are no packages for it.
Signed-off-by: Pino Toscano
Tested-by: Philippe Mathieu-Daudé
Acked-by: Alex Bennée
---
Changes from v10:
- improve error message
On Tuesday, 18 June 2019 15:14:30 CEST Max Reitz wrote:
> On 18.06.19 11:24, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh2. The libssh library has various advantages over libssh2:
> > - easier API for authen
arious Docker/Travis scripts to use libssh when available
instead of libssh2. The mingw/mxe testing is dropped for now, as there
are no packages for it.
Signed-off-by: Pino Toscano
Tested-by: Philippe Mathieu-Daudé
Acked-by: Alex Bennée
---
Changes from v9:
- restored "default" case in t
On Thursday, 13 June 2019 21:31:40 CEST Max Reitz wrote:
> On 13.06.19 15:20, Pino Toscano wrote:
> > -switch (r) {
> > -case LIBSSH2_KNOWNHOST_CHECK_MATCH:
> > +switch (state) {
> > +case SSH_KNOWN_HOSTS_OK:
> > /* OK */
> > -
ckages of libssh (not volunteering myself, sorry).
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
arious Docker/Travis scripts to use libssh when available
instead of libssh2. The mingw/mxe testing is dropped for now, as there
are no packages for it.
Signed-off-by: Pino Toscano
Tested-by: Philippe Mathieu-Daudé
Acked-by: Alex Bennée
---
Changes from v8:
- use a newer key type in iotest 207
- i
APIs/features available in libssh 0.8 conditionally, to support
older versions (which are not recommended though).
Adjust the various Docker/Travis scripts to use libssh when available
instead of libssh2.
Signed-off-by: Pino Toscano
---
Changes from v7:
- #if HAVE_LIBSSH_0_8 -> #if
APIs/features available in libssh 0.8 conditionally, to support
older versions (which are not recommended though).
Adjust the various Docker/Travis scripts to use libssh when available
instead of libssh2.
Signed-off-by: Pino Toscano
---
Changes from v6:
- fixed few checkpatch style issues
On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote:
> On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh2. The libssh library has various advantages over libssh2:
&
APIs/features available in libssh 0.8 conditionally, to support
older versions (which are not recommended though).
Signed-off-by: Pino Toscano
---
Changes from v5:
- adapt to newer tracing APIs
- disable ssh compression (mimic what libssh2 does by default)
- use build time checks for libssh 0.8
Kerberos authentication can be enabled once the libssh bug for it [1] is
fixed.
The development version of libssh (i.e. the future 0.8.x) supports
fsync, so reuse the build time check for this.
[1] https://red.libssh.org/issues/242
Signed-off-by: Pino Toscano
---
Changes from v4:
- fix wrong usages
On Tuesday, 13 February 2018 19:49:12 CET Max Reitz wrote:
> On 2018-01-18 17:44, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh2. The libssh library has various advantages over libssh2:
> > - easier API fo
On Wednesday, 21 March 2018 14:45:38 CET Eric Blake wrote:
> [adding qemu lists]
>
> On 03/21/2018 07:51 AM, Richard W.M. Jones wrote:
> > On Wed, Mar 21, 2018 at 01:44:17PM +0100, Pino Toscano wrote:
> >> Newer versions of qemu use file locking for the images by default,
Kerberos authentication can be enabled once the libssh bug for it [1] is
fixed.
The development version of libssh (i.e. the future 0.8.x) supports
fsync, so reuse the build time check for this.
[1] https://red.libssh.org/issues/242
Signed-off-by: Pino Toscano
---
Changes from v3:
- fix socket
On Monday, 18 December 2017 20:55:19 CET Jeff Cody wrote:
> On Wed, Nov 15, 2017 at 05:26:48PM +0100, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh2. The libssh library has various advantages over libssh2:
>
Kerberos authentication can be enabled once the libssh bug for it [1] is
fixed.
The development version of libssh (i.e. the future 0.8.x) supports
fsync, so reuse the build time check for this.
[1] https://red.libssh.org/issues/242
Signed-off-by: Pino Toscano
---
Changes from v2:
- used again an own
fr_FR - Laurent Vivier
> * it- Pino Toscano
> * zh_CN - Fam Zheng
>
> Reported-by: Kevin Wolf
> Cc: Fam Zheng
> Cc: Pino Toscano
> Cc: Laurent Vivier
> Signed-off-by: Stefan Hajnoczi
> ---
> [...]
> diff --git a/po/it.po b/po/it.po
> index 8eadf2f..
On Friday, 21 October 2016 16:20:30 CEST Eric Blake wrote:
> On 10/18/2016 06:22 AM, Pino Toscano wrote:
> > On Tuesday, 18 October 2016 06:13:30 CEST Eric Blake wrote:
> >> On 10/18/2016 04:17 AM, Pino Toscano wrote:
> >>> qmp_output_start_struct() and qmp_ou
On Friday, 21 October 2016 12:25:40 CEST Daniel P. Berrange wrote:
> On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh2. The libssh library has various advantages over libssh2:
&
On Friday, 21 October 2016 13:02:21 CEST Richard W.M. Jones wrote:
> On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh2. The libssh library has various advantages over libssh2:
&
Kerberos authentication can be enabled once the libssh bug for it [1] is
fixed.
The development version of libssh (i.e. the future 0.8.x) supports
fsync, so reuse the build time check for this.
[1] https://red.libssh.org/issues/242
Signed-off-by: Pino Toscano
---
Changes from v1:
- fixed jumbo
On Thursday, 20 October 2016 18:04:34 CEST Stefan Weil wrote:
> Am 20.10.2016 um 17:15 schrieb Pino Toscano:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh. The libssh library has various advantages over libssh:
>
> libssh inste
On Thursday, 20 October 2016 16:32:50 CEST Richard W.M. Jones wrote:
> On Thu, Oct 20, 2016 at 05:15:24PM +0200, Pino Toscano wrote:
> > Rewrite the implementation of the ssh block driver to use libssh instead
> > of libssh. The libssh library has various advantages over libssh:
&
Kerberos authentication can be enabled once the libssh bug for it [1] is
fixed.
The development version of libssh (i.e. the future 0.8.x) supports
fsync, so reuse the build time check for this.
[1] https://red.libssh.org/issues/242
Signed-off-by: Pino Toscano
---
block/Makefile.objs | 6 +-
block
On Tuesday, 18 October 2016 06:13:30 CEST Eric Blake wrote:
> On 10/18/2016 04:17 AM, Pino Toscano wrote:
> > qmp_output_start_struct() and qmp_output_start_list() create a new
> > QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
> > where it is sa
The 'obj' result of the visitor was not properly freed, like done in
other places doing a similar job.
Signed-off-by: Pino Toscano
---
Changes in v2:
- added Signed-off-by
block/qapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qapi.c b/block/qapi.c
index 6f947e
tion is to qobject_decref() them.
Signed-off-by: Pino Toscano
---
Changes in v2:
- added Signed-off-by
qapi/qmp-output-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/qmp-output-visitor.c b/qapi/qmp-output-visitor.c
index 9e3b67c..eedf256 100644
--- a/qapi/qmp-output-visitor.c
+++ b/qapi/
On Tuesday, 18 October 2016 11:44:26 CEST Kevin Wolf wrote:
> Am 18.10.2016 um 11:18 hat Pino Toscano geschrieben:
> > The 'obj' result of the visitor was not properly freed, like done in
> > other places doing a similar job.
> > ---
> > block/qapi.c |
qmp_output_start_struct() and qmp_output_start_list() create a new
QObject (QDict, QList) and push it to the stack of the QmpOutputVisitor,
where it is saved as 'value'. When freeing the iterator in
qmp_output_free(), these values are never freed properly.
The simple solution is to qobject_decref
The 'obj' result of the visitor was not properly freed, like done in
other places doing a similar job.
---
block/qapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qapi.c b/block/qapi.c
index 6f947e3..50d3090 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -698,6 +698,7 @@ void bdrv_
On Tuesday, 12 April 2016 16:57:42 CEST Pino Toscano wrote:
> to overcome the limitations of the options handling [1], I'm planning
> to move more options for iSCSI also as block options, so it is possible
> to specify them with -drive.
>
> The only patch in this series is
rgetid);
> +g_free(targetid);
> if (opts == NULL) {
> opts = QTAILQ_FIRST(&list->head);
> if (!opts) {
... the commit message seems to suggest that it applies to all the
iSCSI parameter, but it actually works on the authentication-related
ones.
IMHO a better way would be using convert_target_to_id directly in
iscsi_open on iscsi_url->target (right after the url parsing) passing
the converted id to parse_initiator_name, iscsi_set_targetname,
parse_chap, and parse_header_digest: this way it can apply to all the
parameters.
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
.
[1] http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg06501.html
Thanks,
Pino Toscano (1):
iscsi: allow "initiator-name" as block option
block/iscsi.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
--
2.5.5
s.nongnu.org/archive/html/qemu-devel/2015-11/msg06501.html
Signed-off-by: Pino Toscano
---
block/iscsi.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 302baf8..4a1c300 100644
--- a/block/iscsi.c
+++ b/block/iscsi.
On Tuesday 01 December 2015 10:27:28 Markus Armbruster wrote:
> Beware, I know next to nothing about iSCSI.
>
> Pino Toscano writes:
>
> > Hi,
> >
> > while testing the integration of QEMU with iSCSI, I was setting up an
> > environment with both target an
eject
colons in id:
- if so, then there should be a way to allow them only in id of -iscsi
(since colons can be part of IQNs)
- if not, whether allowing them could cause regressions in option
parsing
Thanks,
--
Pino Toscano
signature.asc
Description: This is a digitally signed message part.
48 matches
Mail list logo
