Re: [Qemu-devel] [PATCH v13 0/6] fsdev: qmp interface for io throttling

2017-12-06 Thread Pradeep Jagadeesh
On 12/6/2017 5:49 PM, Eric Blake wrote: On 12/06/2017 10:15 AM, Pradeep Jagadeesh wrote: I didn't have time to follow the thread, but it's been a month without activity... where do we stand now ? I've merged I/O throttle for fsdev in 2.9, is there a chance we get the QMP/HMP part in 2.12

Re: [Qemu-devel] [PATCH v13 0/6] fsdev: qmp interface for io throttling

2017-12-06 Thread Pradeep Jagadeesh
On 12/6/2017 5:07 PM, Greg Kurz wrote: On Mon, 2 Oct 2017 10:33:26 -0400 Pradeep Jagadeesh <pradeepkiruv...@gmail.com> wrote: These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface

Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure

2017-11-13 Thread Pradeep Jagadeesh
On 10/13/2017 4:26 PM, Eric Blake wrote: [adding Markus, and block list] On 10/13/2017 09:16 AM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits structure. { 'struct': 'BlockIOThrottle', - 'data

Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure

2017-11-06 Thread Pradeep Jagadeesh
On 11/6/2017 10:35 AM, Manos Pitsidianakis wrote: On Fri, Oct 13, 2017 at 09:26:17AM -0500, Eric Blake wrote: [adding Markus, and block list] On 10/13/2017 09:16 AM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote: This patch factors out code to use

Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code

2017-11-02 Thread Pradeep Jagadeesh
On 11/2/2017 12:00 PM, Alberto Garcia wrote: On Thu 02 Nov 2017 11:55:26 AM CET, Pradeep Jagadeesh wrote: -if (arg->has_iops_rd_max_length) { -cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length; -} -if (arg->has_iops_wr_max_length) { -cf

Re: [Qemu-devel] [PATCH v13 3/6] qmp: factor out throttle code to reuse code

2017-11-02 Thread Pradeep Jagadeesh
On 10/13/2017 4:29 PM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:29 PM CEST, Pradeep Jagadeesh wrote: -if (arg->has_iops_rd_max_length) { -cfg.buckets[THROTTLE_OPS_READ].burst_length = arg->iops_rd_max_length; -} -if (arg->has_iops_wr_max_length) { -cf

Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure

2017-11-02 Thread Pradeep Jagadeesh
On 10/13/2017 4:26 PM, Eric Blake wrote: [adding Markus, and block list] On 10/13/2017 09:16 AM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits structure. { 'struct': 'BlockIOThrottle', - 'data

Re: [Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

2017-09-25 Thread Pradeep Jagadeesh
On 9/23/2017 12:33 PM, Manos Pitsidianakis wrote: On Fri, Sep 22, 2017 at 01:31:58PM +0200, Pradeep Jagadeesh wrote: On 9/18/2017 6:20 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:05AM -0400, Pradeep Jagadeesh wrote: This patch factors out the duplicate throttle code

[Qemu-devel] [PATCH v12 3/6] qmp: factor out throttle code to reuse code

2017-09-22 Thread Pradeep Jagadeesh
This patch reuses the code to set throttle limits. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- blockdev.c | 53 +++-- 1 file changed, 3 insertions(+), 50 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9

[Qemu-devel] [PATCH v12 5/6] fsdev: QMP interface for throttling

2017-09-22 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Dr. Davi

[Qemu-devel] [PATCH v12 6/6] fsdev: hmp interface for throttling

2017-09-22 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- hmp-commands-info.hx | 18 +++

[Qemu-devel] [PATCH v12 1/6] throttle: factor out duplicate code

2017-09-22 Thread Pradeep Jagadeesh
This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> Reviewed-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v12 2/6] qmp: Use ThrottleLimits structure

2017-09-22 Thread Pradeep Jagadeesh
This patch factors out code to use the ThrottleLimits structure. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- qapi/block-core.json | 75 +++- 1 file changed, 3 insertions(+), 72 deletions(-) diff --git a/qapi/block-cor

[Qemu-devel] [PATCH v12 4/6] hmp: create a throttle initialization function for code reuse

2017-09-22 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> Reviewed-by: Greg Kurz <gr...@kaod.org> A

[Qemu-devel] [PATCH v12 0/6] fsdev: qmp interface for io throttling

2017-09-22 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (6): throttle: factor out duplicate code qmp: Use ThrottleLimits structure qmp: factor out throttle code to reuse code hmp: create a throttle initialization function for code reuse fsdev: QMP interface for throttling fsdev: hmp interface

Re: [Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

2017-09-22 Thread Pradeep Jagadeesh
On 9/18/2017 6:20 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:05AM -0400, Pradeep Jagadeesh wrote: This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Re

Re: [Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

2017-09-20 Thread Pradeep Jagadeesh
On 9/18/2017 6:20 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:05AM -0400, Pradeep Jagadeesh wrote: This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Re

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-20 Thread Pradeep Jagadeesh
On 9/18/2017 6:04 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:06AM -0400, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Kurz <gr...@kaod.org&

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-19 Thread Pradeep Jagadeesh
On 9/18/2017 7:10 PM, Eric Blake wrote: On 09/14/2017 05:40 AM, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits strurcture. s/strurcture/structure/ Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Kurz <gr...

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-19 Thread Pradeep Jagadeesh
On 9/18/2017 6:25 PM, Manos Pitsidianakis wrote: On Thu, Sep 14, 2017 at 06:40:06AM -0400, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Kurz <gr...@kaod.org&

Re: [Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-14 Thread Pradeep Jagadeesh
On 9/14/2017 1:19 PM, Greg Kurz wrote: On Thu, 14 Sep 2017 06:40:06 -0400 Pradeep Jagadeesh <pradeepkiruv...@gmail.com> wrote: This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: G

[Qemu-devel] [PATCH v11 4/6] hmp: create a throttle initialization function for code reuse

2017-09-14 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> Reviewed-by: Greg Kurz <gr...@kaod.org> A

[Qemu-devel] [PATCH v11 1/6] throttle: factor out duplicate code

2017-09-14 Thread Pradeep Jagadeesh
This patch factors out the duplicate throttle code that was still present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> Reviewed-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v11 0/6] fsdev: qmp interface for io throttling

2017-09-14 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (6): throttle: factor out duplicate code qmp: Use ThrottleLimits structure qmp: factor out throttle code to reuse code hmp: create a throttle initialization function for code reuse fsdev: QMP interface for throttling fsdev: hmp interface

[Qemu-devel] [PATCH v11 5/6] fsdev: QMP interface for throttling

2017-09-14 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Dr. Davi

[Qemu-devel] [PATCH v11 6/6] fsdev: hmp interface for throttling

2017-09-14 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> --- hmp-commands-info.hx | 18 hmp-commands.hx | 19

[Qemu-devel] [PATCH v11 3/6] qmp: factor out throttle code to reuse code

2017-09-14 Thread Pradeep Jagadeesh
This patch reuses the code to set throttle limits. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> Reviewed-by: Greg Kurz <gr...@kaod.org> --- blockdev.c | 53 +++--

[Qemu-devel] [PATCH v11 2/6] qmp: Use ThrottleLimits structure

2017-09-14 Thread Pradeep Jagadeesh
This patch factors out code to use the ThrottleLimits strurcture. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Kurz <gr...@kaod.org> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Alberto Garcia <be...@igalia.com> Reviewed-by

Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling

2017-09-11 Thread Pradeep Jagadeesh
On 9/8/2017 2:34 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> writes: On 9/8/2017 12:02 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: [...] diff --git a/qmp.c b/qmp.c index b86201e..eed91e5 100644 --- a/qmp.c

Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling

2017-09-08 Thread Pradeep Jagadeesh
On 9/8/2017 2:34 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> writes: On 9/8/2017 12:02 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: [...] diff --git a/qmp.c b/qmp.c index b86201e..eed91e5 100644 --- a/qmp.c

Re: [Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling

2017-09-08 Thread Pradeep Jagadeesh
On 9/8/2017 12:02 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the re

Re: [Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io throttling

2017-09-06 Thread Pradeep Jagadeesh
On 9/5/2017 11:19 PM, Eric Blake wrote: On 09/04/2017 11:07 AM, Pradeep Jagadeesh wrote: These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface to set the io throttle parameters of a fsdev

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Pradeep Jagadeesh
On 9/5/2017 11:34 AM, Alberto Garcia wrote: On Tue 05 Sep 2017 11:13:09 AM CEST, Pradeep Jagadeesh wrote: a) Declare an Error, pass it _and then handle it_ (if you don't handle it, you're leaking it): Here you have no other way to know if qmp_query_fsdev_io_throttle() fails, so you should

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Pradeep Jagadeesh
On 9/5/2017 11:07 AM, Alberto Garcia wrote: On Tue 05 Sep 2017 10:28:02 AM CEST, Pradeep Jagadeesh wrote: +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict) +{ +Error *err = NULL; +IOThrottleList *fsdev_list, *info; +fsdev_list = qmp_query_fsdev_io_throttle

Re: [Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-05 Thread Pradeep Jagadeesh
On 9/5/2017 9:53 AM, Alberto Garcia wrote: On Mon 04 Sep 2017 06:07:47 PM CEST, Pradeep Jagadeesh wrote: +void hmp_info_fsdev_iothrottle(Monitor *mon, const QDict *qdict) +{ +Error *err = NULL; +IOThrottleList *fsdev_list, *info; +fsdev_list = qmp_query_fsdev_io_throttle

[Qemu-devel] [PATCH v10 3/6] throttle: move out function to reuse the code

2017-09-04 Thread Pradeep Jagadeesh
This patch move out the throttle code to util/throttle.c to maximize the reusability of the code.The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- blockdev.c

[Qemu-devel] [PATCH v10 4/6] hmp: create a throttle initialization function for code reusability

2017-09-04 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp.c | 19 +-- 1

[Qemu-devel] [PATCH v10 2/6] qmp: Create IOThrottle structure

2017-09-04 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Ku

[Qemu-devel] [PATCH v10 0/6] fsdev: qmp interface for io throttling

2017-09-04 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (6): throttle: factor out duplicate code qmp: Create IOThrottle structure throttle: move out function to reuse the code hmp: create a throttle initialization function for code reusability fsdev: QMP interface for throttling fsdev: hmp interface

[Qemu-devel] [PATCH v10 5/6] fsdev: QMP interface for throttling

2017-09-04 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- Ma

[Qemu-devel] [PATCH v10 6/6] fsdev: hmp interface for throttling

2017-09-04 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp-commands-info.hx | 18 hmp-commands.hx | 19 + hmp.c

[Qemu-devel] [PATCH v10 1/6] throttle: factor out duplicate code

2017-09-04 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- blockdev.c | 44 +--

Re: [Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling

2017-09-04 Thread Pradeep Jagadeesh
On 8/30/2017 11:38 AM, Alberto Garcia wrote: On Tue 29 Aug 2017 04:23:06 PM CEST, Pradeep Jagadeesh wrote: +static void print_fsdev_throttle_config(Monitor *mon, IOThrottle *fscfg, + Error *err) +{ +monitor_printf(mon, "%s",

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-09-01 Thread Pradeep Jagadeesh
On 8/31/2017 3:34 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote: On 8/30/2017 5:10 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote: Thanks for the steps, I did reproduce the issue easily. Looking into the code

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-08-31 Thread Pradeep Jagadeesh
On 8/31/2017 3:34 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:12:22 PM CEST, Pradeep Jagadeesh wrote: On 8/30/2017 5:10 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote: Thanks for the steps, I did reproduce the issue easily. Looking into the code

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-08-30 Thread Pradeep Jagadeesh
On 8/30/2017 5:10 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 05:07:29 PM CEST, Pradeep Jagadeesh wrote: Thanks for the steps, I did reproduce the issue easily. Looking into the code, may be we also need to try the same with the block devices. I did some tests and it was working fine, so

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-08-30 Thread Pradeep Jagadeesh
On 8/30/2017 4:54 PM, Alberto Garcia wrote: On Wed 30 Aug 2017 02:10:53 PM CEST, Pradeep Jagadeesh wrote: I'm trying to read from an 9p share that has limits set with hmp fsdev_set_io_throttle and I'm having some problems. Here's one simple way to reproduce it: 1) Launch qemu

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-08-30 Thread Pradeep Jagadeesh
On 8/30/2017 2:07 PM, Alberto Garcia wrote: On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote: These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. I'm trying to read from an 9p share that has limits set

Re: [Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-08-29 Thread Pradeep Jagadeesh
On 8/29/2017 4:36 PM, Alberto Garcia wrote: On Tue 29 Aug 2017 04:23:01 PM CEST, Pradeep Jagadeesh wrote: These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface to set the io throttle parameters

[Qemu-devel] [PATCH v8 2/6] qmp: Create IOThrottle structure

2017-08-29 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Ku

[Qemu-devel] [PATCH v8 6/6] fsdev: QMP interface for throttling

2017-08-29 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- Ma

[Qemu-devel] [PATCH v8 1/6] throttle: factor out duplicate code

2017-08-29 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- blockdev.c | 44 +--

[Qemu-devel] [PATCH v8 3/6] throttle: move out function to reuse the code

2017-08-29 Thread Pradeep Jagadeesh
This patch move out the throttle code to util/throttle.c to maximize the reusability of the code.The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- blockdev.c | 53 +++- includ

[Qemu-devel] [PATCH v8 4/6] hmp: create a throttle initialization function for code reusability

2017-08-29 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp.c | 19 +-- 1

[Qemu-devel] [PATCH v8 5/6] fsdev: hmp interface for throttling

2017-08-29 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp-commands-info.hx | 18 +++ hmp-commands.hx | 19 hmp.c

[Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-08-29 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (6): throttle: factor out duplicate code qmp: Create IOThrottle structure throttle: move out function to reuse the code hmp: create a throttle initialization function for code reusability fsdev: hmp interface for throttling fsdev: QMP interface

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-10 Thread Pradeep Jagadeesh
On 8/8/2017 5:18 PM, Markus Armbruster wrote: Alberto Garcia <be...@igalia.com> writes: On Tue 08 Aug 2017 02:30:43 PM CEST, Pradeep Jagadeesh wrote: On 8/8/2017 1:30 PM, Alberto Garcia wrote: On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: Awkward question for a v7, bu

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-08 Thread Pradeep Jagadeesh
On 8/8/2017 1:30 PM, Alberto Garcia wrote: On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: Awkward question for a v7, but here goes anyway: why is IOThrottle worth its very own .json file? I feel this is a common throttle structure that is used by block devices as well as fsdev,

Re: [Qemu-devel] [PATCH V8 5/6] fsdev: QMP interface for throttling

2017-08-07 Thread Pradeep Jagadeesh
On 8/7/2017 2:44 PM, Eric Blake wrote: On 08/07/2017 07:37 AM, Pradeep Jagadeesh wrote: This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device

[Qemu-devel] [PATCH V8 6/6] fsdev: hmp interface for throttling

2017-08-07 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp-commands-info.hx | 18 +++ hmp-commands.hx | 19 hmp.c

[Qemu-devel] [PATCH V8 1/6] throttle: factor out duplicate code

2017-08-07 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- blockdev.c | 44 +--

[Qemu-devel] [PATCH V8 5/6] fsdev: QMP interface for throttling

2017-08-07 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- Ma

[Qemu-devel] [PATCH V8 4/6] hmp: create a throttle initialization function for code reusability

2017-08-07 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp.c | 19 +-- 1

[Qemu-devel] [PATCH v8 0/6] fsdev: qmp interface for io throttling

2017-08-07 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (6): throttle: factor out duplicate code qmp: Create IOThrottle structure throttle: move out function to reuse the code hmp: create a throttle initialization function for code reusability fsdev: QMP interface for throttling fsdev: hmp interface

[Qemu-devel] [PATCH V8 3/6] throttle: move out function to reuse the code

2017-08-07 Thread Pradeep Jagadeesh
This patch move out the throttle code to util/throttle.c to maximize the reusability of the code.The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- blockdev.c | 53 +++- includ

[Qemu-devel] [PATCH V8 2/6] qmp: Create IOThrottle structure

2017-08-07 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Ku

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-07 Thread Pradeep Jagadeesh
On 7/6/2017 7:55 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required

Re: [Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling

2017-08-07 Thread Pradeep Jagadeesh
On 7/6/2017 8:15 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Fails to compile, first error: /work/armbr

Re: [Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code

2017-08-07 Thread Pradeep Jagadeesh
On 7/10/2017 4:41 PM, Eric Blake wrote: On 07/04/2017 10:30 AM, Pradeep Jagadeesh wrote: This patch factor out the duplicate throttle code that was present in s/This patch factor/Factor/ It's okay to write commit messages in the imperative tense; the easiest way I know to start a good

Re: [Qemu-devel] [PATCH v7 6/6] fsdev: QMP interface for throttling

2017-08-07 Thread Pradeep Jagadeesh
On 7/6/2017 8:47 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the re

Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

2017-08-07 Thread Pradeep Jagadeesh
On 7/7/2017 8:14 AM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface to set the io throttle para

Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

2017-07-14 Thread Pradeep Jagadeesh
On 7/14/2017 4:26 PM, Manos Pitsidianakis wrote: On Fri, Jul 14, 2017 at 03:15:06PM +0200, Pradeep Jagadeesh wrote: Hi Manos, Thanks for sharing the link to your code patch. On 7/14/2017 2:22 PM, Manos Pitsidianakis wrote: Hello Pradeep, you might be interested in my work on refactoring

Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

2017-07-14 Thread Pradeep Jagadeesh
Hi Manos, Thanks for sharing the link to your code patch. On 7/14/2017 2:22 PM, Manos Pitsidianakis wrote: Hello Pradeep, you might be interested in my work on refactoring the block layer's throttling interface in my series:

Re: [Qemu-devel] [PATCH v7 6/6] fsdev: QMP interface for throttling

2017-07-07 Thread Pradeep Jagadeesh
On 7/6/2017 8:47 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the re

Re: [Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

2017-07-07 Thread Pradeep Jagadeesh
On 7/7/2017 8:14 AM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface to set the io throttle para

[Qemu-devel] [PATCH v7 0/6] fsdev: qmp interface for io throttling

2017-07-04 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (6): throttle: factor out duplicate code qmp: Create IOThrottle structure throttle: move out function to reuse the code hmp: create a throttle initialization function for code reusability fsdev: hmp interface for throttling fsdev: QMP interface

[Qemu-devel] [PATCH v7 6/6] fsdev: QMP interface for throttling

2017-07-04 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- Ma

[Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-07-04 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Ku

[Qemu-devel] [PATCH v7 5/6] fsdev: hmp interface for throttling

2017-07-04 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp-commands-info.hx | 18 +++ hmp-commands.hx | 19 hmp.c

[Qemu-devel] [PATCH v7 1/6] throttle: factor out duplicate code

2017-07-04 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- blockdev.c | 44 +--

[Qemu-devel] [PATCH v7 4/6] hmp: create a throttle initialization function for code reusability

2017-07-04 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Acked-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp.c | 19 +-- 1

[Qemu-devel] [PATCH v7 3/6] throttle: move out function to reuse the code

2017-07-04 Thread Pradeep Jagadeesh
This patch move out the throttle code to util/throttle.c to maximize the reusability of the code.The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- blockdev.c | 53 +++- includ

Re: [Qemu-devel] [PATCH v6 5/6] fsdev: hmp interface for throttling

2017-07-03 Thread Pradeep Jagadeesh
On 6/30/2017 11:33 AM, Dr. David Alan Gilbert wrote: * Pradeep Jagadeesh (pradeepkiruv...@gmail.com) wrote: This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp-commands-info.hx | 18 ++ hmp-comma

[Qemu-devel] [PATCH 3/6] throttle: move out function to reuse the code

2017-06-29 Thread Pradeep Jagadeesh
This patch move out the throttle code to util/throttle.c to maximize the reusability of the code.The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- blockdev.c | 53 +++- includ

[Qemu-devel] [PATCH v6 5/6] fsdev: hmp interface for throttling

2017-06-29 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp-commands-info.hx | 18 ++ hmp-commands.hx | 19 +++ hmp.c

[Qemu-devel] [PATCH v6 6/6] fsdev: QMP interface for throttling

2017-06-29 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- Ma

[Qemu-devel] [PATCH v6 0/6] fsdev: qmp interface for io throttling

2017-06-29 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (6): throttle: factor out duplicate code qmp: Create IOThrottle structure throttle: move out function to reuse the code hmp: create a throttle initialization function for code reusability fsdev: hmp interface for throttling fsdev: QMP interface

[Qemu-devel] [PATCH v6 1/6] throttle: factor out duplicate code

2017-06-29 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Alberto Garcia <be...@igalia.com> --- blockdev.c | 44 +--

[Qemu-devel] [PATCH v6 4/6] hmp: create a throttle initialization function

2017-06-29 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH v6 2/6] qmp: Create IOThrottle structure

2017-06-29 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Ku

Re: [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-29 Thread Pradeep Jagadeesh
On 6/21/2017 12:00 PM, Greg Kurz wrote: On Wed, 21 Jun 2017 10:34:42 +0200 Pradeep Jagadeesh <pradeep.jagade...@huawei.com> wrote: On 6/20/2017 6:05 PM, Greg Kurz wrote: On Mon, 19 Jun 2017 09:11:34 -0400 Pradeep Jagadeesh <pradeepkiruv...@gmail.com> wrote: This patc

Re: [Qemu-devel] [PATCH v5 1/5] throttle: factor out duplicate code

2017-06-29 Thread Pradeep Jagadeesh
On 6/22/2017 4:38 PM, Markus Armbruster wrote: Pradeep Jagadeesh <pradeepkiruv...@gmail.com> writes: This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> ---

Re: [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-21 Thread Pradeep Jagadeesh
On 6/20/2017 6:05 PM, Greg Kurz wrote: On Mon, 19 Jun 2017 09:11:34 -0400 Pradeep Jagadeesh <pradeepkiruv...@gmail.com> wrote: This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. The text is obviously wrong. I don't s

[Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

2017-06-19 Thread Pradeep Jagadeesh
This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- blockdev.c | 53 +++-

[Qemu-devel] [PATCH v5 4/5] fsdev: hmp interface for throttling

2017-06-19 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev throttle functionality Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- hmp-commands-info.hx | 18 ++ hmp-commands.hx | 19 +++ hmp.c

[Qemu-devel] [PATCH v5 5/5] fsdev: QMP interface for throttling

2017-06-19 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- Ma

[Qemu-devel] [PATCH v5 0/5] fsdev: qmp interface for io throttling

2017-06-19 Thread Pradeep Jagadeesh
and fsdev files. Pradeep Jagadeesh (5): throttle: factor out duplicate code qmp: Create IOThrottle structure qmp: refactor duplicate code fsdev: hmp interface for throttling fsdev: QMP interface for throttling Makefile| 3 + blockdev.c

[Qemu-devel] [PATCH v5 2/5] qmp: Create IOThrottle structure

2017-06-19 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> Reviewed-by: Greg Ku

[Qemu-devel] [PATCH v5 1/5] throttle: factor out duplicate code

2017-06-19 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh <pradeep.jagade...@huawei.com> --- blockdev.c | 44 +--- fsdev/qemu-fsdev-throttle.c

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-06-09 Thread Pradeep Jagadeesh
On 6/9/2017 11:07 AM, Greg Kurz wrote: GEN qmp-commands.h /tmp/qemu-test/src/qapi-schema.json:85: No such file or directory: qapi/fsdev.json Makefile:438: recipe for target 'qmp-commands.h' failed Please fix that. Ho ok, I will have a look. How are you trying to compile, using "make

  1   2   3   >