[Qemu-devel] [PATCH v2 0/2] HMP: support specifying dump format for dump-guest-memory

2014-04-17 Thread Qiao Nuohan
The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html ChangLog: Changes from v7 to v8: 1. add a patch to fix doc of dump-guest-memory Qiao Nuohan (2): HMP: fix doc of dump-guest-memory HMP: support specifying dump format for dump-guest-memory hmp

[Qemu-devel] [PATCH v2 2/2] HMP: support specifying dump format for dump-guest-memory

2014-04-17 Thread Qiao Nuohan
this feature is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04235.html Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Suggested-by: Christian Borntraeger borntrae...@de.ibm.com --- hmp-commands.hx | 13 ++--- hmp.c | 25 ++--- 2 files

[Qemu-devel] [PATCH v2 1/2] HMP: fix doc of dump-guest-memory

2014-04-17 Thread Qiao Nuohan
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- hmp-commands.hx | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index f3fc514..c242770 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -999,25 +999,26 @@ ETEXI

[Qemu-devel] [PATCH v2 0/2] HMP: support specifying dump format for dump-guest-memory

2014-04-16 Thread Qiao Nuohan
The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html ChangLog: Changes from v7 to v8: 1. add a patch to fix doc of dump-guest-memory Qiao Nuohan (2): HMP: fix doc of dump-guest-memory HMP: support specifying dump format for dump-guest-memory hmp

[Qemu-devel] [PATCH v2 1/2] HMP: fix doc of dump-guest-memory

2014-04-16 Thread Qiao Nuohan
Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- hmp-commands.hx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 0da8f28..ca5737b 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1000,10 +1000,10 @@ ETEXI

[Qemu-devel] [PATCH v2 2/2] HMP: support specifying dump format for dump-guest-memory

2014-04-16 Thread Qiao Nuohan
this feature is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04235.html Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Suggested-by: Christian Borntraeger borntrae...@de.ibm.com --- hmp-commands.hx | 13 ++--- hmp.c | 25 ++--- 2 files

[Qemu-devel] [PATCH] HMP: support specifying dump format for dump-guest-memory

2014-04-01 Thread Qiao Nuohan
this feature is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04235.html Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Suggested-by: Christian Borntraeger borntrae...@de.ibm.com --- hmp-commands.hx | 11 +++ hmp.c | 25 - 2 files changed

Re: [Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format

2014-02-17 Thread Qiao Nuohan
the error message because of the incompatible type. And I have fixed patches and sent them to the qemu list. P.S. lzo/snappy will need '--enable-lzo' or '--enable-snappy' at configure. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v10 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-12 Thread Qiao Nuohan
} +- { return: { formats: +[elf, kdump-zlib, kdump-lzo, kdump-snappy] } + +EQMP + +{ .name = netdev_add, .args_type = netdev:O, .mhandler.cmd_new = qmp_netdev_add, -- Regards Qiao Nuohan From c729625031c88b0bf32bae50c39f81585303cc52

[Qemu-devel] [PATCH v10 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Qiao Nuohan
-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c | 33 + qapi-schema.json | 23 +++ qmp-commands.hx | 20 3 files changed, 76 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index 2ebbb23..3a8d55e

[Qemu-devel] [PATCH v9 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Qiao Nuohan
-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c | 33 + qapi-schema.json |9 + qmp-commands.hx | 23 +++ 3 files changed, 65 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index 2ebbb23..3a8d55e 100644

Re: [Qemu-devel] [PATCH v3 0/1] Detect arch for dump compressed header.

2014-02-10 Thread Qiao Nuohan
for it. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Qiao Nuohan
is better, but I want to check whether Eric has some comments on it. Thanks, Laszlo -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-10 Thread Qiao Nuohan
easily when bisecting. Yes, I can. But what's the problem with patch 13? For me having Eric's ACK is enough for applying it. Anything else will be done by QMP introspection. Hello Eric, Need your review here, thanks a lot!! -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v3 0/1] Detect arch for dump compressed header.

2014-02-09 Thread Qiao Nuohan
+ 3 files changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Sorry for replying later. The patch seems good to me and works well on my machine. P.S. I have no idea about where to find queued patches, could you give some hint? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v8 08/13] dump: add API to write dump header

2014-01-28 Thread Qiao Nuohan
On 01/28/2014 09:37 PM, Laszlo Ersek wrote: I seem to recall that Qiao Nuohan stated that he (*) couldn't test this feature on any other architecture than i686/x86_64. So my proposal is, let's not block the series based on just this one point. Let's review it and allow it to be merged

Re: [Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-27 Thread Qiao Nuohan
is: http://lists.gnu.org/archive/html/qemu-devel/2014-01/msg02139.html -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH 07/13 v7] dump: add members to DumpState and init some of them

2014-01-23 Thread Qiao Nuohan
), but it looks OK to me. I see, moving them into if(format...) {...} block would be better. But, I have no idea of regression-testing (perf-wise), would you mind give some hint? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH 00/13 v7] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-21 Thread Qiao Nuohan
+- include/sysemu/dump.h | 138 +++ qapi-schema.json | 38 ++- qmp-commands.hx | 38 ++- 7 files changed, 1228 insertions(+), 20 deletions(-) -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH 00/13 v7] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-21 Thread Qiao Nuohan
can check the differences between the reset patches with the last version. And thanks again. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH 00/13 v7] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-17 Thread Qiao Nuohan
the guest should only be x86/x86_64, actually, I get no knowledge about other arch, so what I can do now is just make x86/x86_64 works and be tested. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

2014-01-13 Thread Qiao Nuohan
(to send over the fd later), in doCoreDump(), it also passes O_TRUNC. OK. Do you mean because of O_TRUNC,seek will exceed the end of the file that may cause some problem? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

2014-01-13 Thread Qiao Nuohan
bytes with the value 0 until data is actually written into the gap. http://pubs.opengroup.org/onlinepubs/9699919799/functions/lseek.html So this is fine. Thanks for your explanation. I think it would be better to abandon the non-flat mode to avoid potential risk. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

2014-01-13 Thread Qiao Nuohan
. The flat (non-seekable) format was a surprise to me -- I wouldn't have thought that any debugger could directly consume that format. The flat-mode comes from makedumpfile as kdump-compressed format, and crash utility has already supported it. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes

2014-01-06 Thread Qiao Nuohan
directly. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore

2014-01-06 Thread Qiao Nuohan
*buf here, but it certainly doesn't warrant a respin. Acked, I will reflect it in later version. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer

2014-01-06 Thread Qiao Nuohan
preferable. Addition to a pointer-to-void is a constraint violation in standard C (... operand shall be a pointer to an object type ...), ie. it's a gcc extension here, but I guess we can live with it. Using s-note_size as limit seems correct. Acked. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 05/11] dump: add support for lzo/snappy

2014-01-06 Thread Qiao Nuohan
for compile tools [$cross_prefix] echo --cc=CC use C compiler CC [$cc] ... cut -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v6 00/11] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-06 Thread Qiao Nuohan
Hello Eric, Luiz and Laszlo, What do you think about my series? And I have add the light-weight introspection in the last patch, do you have some comments on it? On 01/05/2014 03:27 PM, Qiao Nuohan wrote: Hi, all The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2013

Re: [Qemu-devel] [PATCH v6 00/11] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-06 Thread Qiao Nuohan
On 01/07/2014 03:27 PM, Laszlo Ersek wrote: I haven't finished reviewing it yet, but thus far (up to including patch 05) I'm OK with it. I see, thanks for your work. -- Regards Qiao Nuohan

[Qemu-devel] [PATCH v6 06/11] dump: add API to write dump header

2014-01-05 Thread Qiao Nuohan
the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-by: Qiao Nuohan

[Qemu-devel] [PATCH v6 05/11] dump: add support for lzo/snappy

2014-01-05 Thread Qiao Nuohan
kdump-compressed format supports three compression format, zlib/lzo/snappy. Currently, only zlib is available. This patch is used to support lzo/snappy. '--enable-lzo/--enable-snappy' is needed to be specified with configure to make lzo/snappy available for qemu Signed-off-by: Qiao Nuohan qiaonuo

[Qemu-devel] [PATCH v6 03/11] dump: Add API to write vmcore

2014-01-05 Thread Qiao Nuohan
; int64_t buf_size; }; Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index 89baeab..764db39 100644 --- a/dump.c +++ b/dump.c @@ -726,6 +726,34 @@ static int

[Qemu-devel] [PATCH v6 11/11] Add 'query-dump-guest-memory-capability' command

2014-01-05 Thread Qiao Nuohan
, capabilities: [ {available: true, format: elf}, {available: true, format: kdump-zlib}, {available: true, format: kdump-lzo}, {available: true, format: kdump-snappy} ] } Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c | 38

[Qemu-devel] [PATCH v6 00/11] Make 'dump-guest-memory' dump in kdump-compressed format

2014-01-05 Thread Qiao Nuohan
. 3. Address Andreas's comment: remove useless include. Qiao Nuohan (11): dump: Add argument to write_elfxx_notes dump: Add API to write header of flatten format dump: Add API to write vmcore dump: Add API to write elf notes to buffer dump: add support for lzo/snappy dump: add API

[Qemu-devel] [PATCH v6 02/11] dump: Add API to write header of flatten format

2014-01-05 Thread Qiao Nuohan
buf_size; /* = -1 */ }; Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c| 40 include/sysemu/dump.h | 17 + 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index 1fa12a2

[Qemu-devel] [PATCH v6 04/11] dump: Add API to write elf notes to buffer

2014-01-05 Thread Qiao Nuohan
-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index 764db39..3b9cf00 100644 --- a/dump.c +++ b/dump.c @@ -76,6 +76,9 @@ typedef struct DumpState { int64_t begin; int64_t

[Qemu-devel] [PATCH v6 10/11] dump: Make kdump-compressed format available for 'dump-guest-memory'

2014-01-05 Thread Qiao Nuohan
and makedumpfile, and it can be smaller than the ELF format because of the compression support. 2. The kdump-compressed format is the 6th edition. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c | 163 -- hmp-commands.hx

[Qemu-devel] [PATCH v6 08/11] dump: Add APIs to operate DataCache

2014-01-05 Thread Qiao Nuohan
DataCache is used to store data temporarily, then the data will be written to vmcore. These functions will be called later when writing data of page to vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c| 52

[Qemu-devel] [PATCH v6 09/11] dump: Add API to write dump pages

2014-01-05 Thread Qiao Nuohan
functions are used to write page to vmcore. vmcore is written page by page. page desc is used to store the information of a page, including a page's size, offset, compression format, etc. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c| 258

[Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes

2014-01-05 Thread Qiao Nuohan
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding parameter WriteCoreDumpFunction f makes it available to choose the method of writing elf notes Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- dump.c | 16 1 files changed, 8

[Qemu-devel] [PATCH v6 07/11] dump: Add API to write dump_bitmap

2014-01-05 Thread Qiao Nuohan
functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format, which is used to indicate whether the corresponded page is existed in vmcore. 1st and 2nd dump_bitmap are same, because dump level is specified to 1 here. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-12-12 Thread Qiao Nuohan
command? On 07/09/2013 03:30 PM, Qiao Nuohan wrote: Hi, all The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg03866.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here: http

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-08-01 Thread Qiao Nuohan
waiting for introspection. And your patches seem good to me. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-08-01 Thread Qiao Nuohan
On 08/02/2013 11:41 AM, Amos Kong wrote: On Fri, Aug 02, 2013 at 11:25:17AM +0800, Qiao Nuohan wrote: On 07/31/2013 09:10 PM, Luiz Capitulino wrote: QMP introspection didn't make it for 1.6. Thanks for your info. I will still wait for introspection. Can you help to review if the output

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-08-01 Thread Qiao Nuohan
On 07/31/2013 09:10 PM, Luiz Capitulino wrote: QMP introspection didn't make it for 1.6. Thanks for your info. I will still wait for introspection. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-31 Thread Qiao Nuohan
Hello Luiz and Amos, My patches are waiting for introspection. But now I cannot quite catch the situation of introspection, so I hope to get some information about current state from you. It will be very appreciated. On 07/09/2013 03:36 PM, Qiao Nuohan wrote: On 07/09/2013 03:30 PM, Qiao

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-15 Thread Qiao Nuohan
On 07/09/2013 03:36 PM, Qiao Nuohan wrote: Still waiting for introspection... And comments about format will be very helpful. Hi Stefan and others, What do you think about the process of creating vmcore in kdump-compressed format? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages

2013-07-15 Thread Qiao Nuohan
in structure used by kdump format. Thanks for pointing it out. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format

2013-07-15 Thread Qiao Nuohan
On 07/16/2013 10:06 AM, Stefan Hajnoczi wrote: On Tue, Jul 09, 2013 at 03:30:07PM +0800, Qiao Nuohan wrote: +static int write_start_flat_header(int fd) +{ +char buf[MAX_SIZE_MDF_HEADER]; +MakedumpfileHeader mh; Why is buf[] necessary? You can write mh directly. The size of header

[Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-09 Thread Qiao Nuohan
-made ones accoring. 3. Address Andreas's comment: remove useless include. Qiao Nuohan (9): dump: Add argument to write_elfxx_notes dump: Add API to write header of flatten format dump: Add API to write vmcore dump: Add API to write elf notes to buffer dump: add API to write dump header

[Qemu-devel] [PATCH v5 6/9] dump: Add API to write dump_bitmap

2013-07-09 Thread Qiao Nuohan
functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format, which is used to indicate whether the corresponded page is existed in vmcore. Dump level 1 is chosen, so 1st and 2nd dump_bitmap are same. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe

[Qemu-devel] [PATCH v5 1/9] dump: Add argument to write_elfxx_notes

2013-07-09 Thread Qiao Nuohan
write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding argument WriteCoreDumpFunction f makes it available to choose the way of writing elf notes when calling these two functions. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe

[Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages

2013-07-09 Thread Qiao Nuohan
functions are used to write page desc and page data to vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- configure | 50 + dump.c| 264 + include

[Qemu-devel] [PATCH v5 3/9] dump: Add API to write vmcore

2013-07-09 Thread Qiao Nuohan
; int64_t buf_size; }; Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index f04d4fc..6f14b8d 100644 --- a/dump.c

[Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format

2013-07-09 Thread Qiao Nuohan
-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 40 include/sysemu/dump.h | 17 + 2 files changed, 57 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index

[Qemu-devel] [PATCH v5 7/9] dump: Add APIs to operate DataCache

2013-07-09 Thread Qiao Nuohan
DataCache is used to store data temporarily, then the data will be written to vmcore. These functions will be called later when writing data of page to vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 52

[Qemu-devel] [PATCH v5 9/9] dump: Make kdump-compressed format available for 'dump-guest-memory'

2013-07-09 Thread Qiao Nuohan
, and it can be smaller than the ELF format because of the compression support. 2. The kdump-compressed format is the 5th edition. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Signed-off-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 154

[Qemu-devel] [PATCH v5 4/9] dump: Add API to write elf notes to buffer

2013-07-09 Thread Qiao Nuohan
-note_buf will be used later. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/dump.c b/dump.c index 6f14b8d..d7b3624 100644 --- a/dump.c

[Qemu-devel] [PATCH v5 5/9] dump: add API to write dump header

2013-07-09 Thread Qiao Nuohan
the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-by: Qiao Nuohan

Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-09 Thread Qiao Nuohan
On 07/09/2013 03:30 PM, Qiao Nuohan wrote: The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg03866.html Hi all, Still waiting for introspection... And comments about format will be very helpful. Thanks! -- Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-03 Thread Qiao Nuohan
and size of a data block. struct makedumpfile_data_header { int64_t offset; int64_t buf_size; }; For more information, please refer to makedumpfile http://sourceforge.net/projects/makedumpfile/ -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Qiao Nuohan
. But now we only need to exclude zero pages and there's formal mechanism between qemu and linux kernel, so without metadata can also satisfy our need. Think over all of the above, I still chose kdump-compressed format. What's your opinion about this? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-27 Thread Qiao Nuohan
for your comments! -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-19 Thread Qiao Nuohan
On 06/14/2013 02:12 AM, Luiz Capitulino wrote: I've started reviewing this, but I'm out of cycles for this week. Hi Luiz, No comments yet? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-19 Thread Qiao Nuohan
Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-10 Thread Qiao Nuohan
app like libvirt to know whether or not a given QEMU version supports your new argument. Thanks for your explanation. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-09 Thread Qiao Nuohan
will choose to wait. However, I cannot figure out how long it will take, why not get the parts not related to introspection settled first? Seems Amos's draft will not change qapi-schema.json. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-06-04 Thread Qiao Nuohan
new constants by using the ready-made ones accoring. 3. Address Andreas's comment: remove useless include. Qiao Nuohan (9): dump: Add API to manipulate dump_bitmap dump: Add API to manipulate cache_data dump: Move struct definition into dump_memroy.h dump: Add API to create header

Re: [Qemu-devel] [PATCH 3/9 v3] Move includes and struct definition to dump.h

2013-05-27 Thread Qiao Nuohan
conflict only with removing useless headers. So I will create another head file and move what I want into it. P.S. RAMBlock, what I want, may cause conflict. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-22 Thread Qiao Nuohan
Hi eric and luiz, Does you have some comments on this version? -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Qiao Nuohan
. Well, I have got no reason to object. And thanks. -- Regards Qiao Nuohan

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Qiao Nuohan
Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com --- target-i386/arch_memory_mapping.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH] Fix mask of pte index

2013-05-21 Thread Qiao Nuohan
On 05/22/2013 09:21 AM, Qiao Nuohan wrote: Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed by: Jesse Larrew jlar

[Qemu-devel] [PATCH] Fix mask of pte index

2013-05-20 Thread Qiao Nuohan
Function walk_pte needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. --- target-i386/arch_memory_mapping.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-19 Thread Qiao Nuohan
Ping. Any other comments? On 05/17/2013 11:24 AM, Qiao Nuohan wrote: Hi, all The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg01947.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64

Re: [Qemu-devel] [PATCH 1/9 v2] Add API to manipulate dump_bitmap

2013-05-17 Thread Qiao Nuohan
On 05/17/2013 04:20 PM, Andreas Färber wrote: Jens and me have been working towards removing the dependency on CONFIG_HAVE_CORE_DUMP. Would there be any issue building this code unconditionally using obj-y += dump_bitmap.o ? No problems will be involved. -- Regards Qiao Nuohan

[Qemu-devel] [PATCH 3/9 v3] Move includes and struct definition to dump.h

2013-05-16 Thread Qiao Nuohan
Move includes and definition of struct DumpState into include/sysemu/dump.h. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 29 - include/sysemu/dump.h | 30

[Qemu-devel] [PATCH 7/9 v3] Add API to free memory used by creating header, bitmap and page

2013-05-16 Thread Qiao Nuohan
When calling create_header, create_dump_bitmap and create_pages, some memory spaces are allocated. The following patch will use this function to free these memory. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c | 19

[Qemu-devel] [PATCH 1/9 v3] Add API to manipulate dump_bitmap

2013-05-16 Thread Qiao Nuohan
Struct dump_bitmap is associated with a tmp file which is used to store bitmap in kdump-compressed format temporarily. The following patch will use these functions to gather data of bitmap and cache them into tmp files. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang

[Qemu-devel] [PATCH 5/9 v3] Add API to create data of dump bitmap

2013-05-16 Thread Qiao Nuohan
Functions in this patch are used to gather data of 1st and 2nd dump bitmap in kdump-compressed format. The following patch will use these functions to gather data of dump bitmap, then cache them into tmp files. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan

[Qemu-devel] [PATCH 2/9 v3] Add API to manipulate cache_data

2013-05-16 Thread Qiao Nuohan
Struct cache_data is associated with a tmp file which is used to store page desc and page data in kdump-compressed format temporarily. The following patch will use these function to gather data of page and cache them in tmp files. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed

[Qemu-devel] [PATCH 0/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-16 Thread Qiao Nuohan
useless include. Qiao Nuohan (9): Add API to manipulate dump_bitmap Add API to manipulate cache_data Move includes and struct definition to dump.h Add API to create header of vmcore Add API to create data of dump bitmap Add API to create page Add API to free buf used by creating header

[Qemu-devel] [PATCH 6/9 v3] Add API to create page

2013-05-16 Thread Qiao Nuohan
Functions in this patch are used to gather data of page desc and page data in kdump-compressed format. The following patch will use these functions to gather data of page, then cache them into tmp files Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan

[Qemu-devel] [PATCH 4/9 v3] Add API to create header of vmcore

2013-05-16 Thread Qiao Nuohan
Functions in this patch are used to gather data of header and sub header in kdump-compressed format. The following patch will use these functions to gather data of header, then cache them into struct DumpState. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan

[Qemu-devel] [PATCH 8/9 v3] Add API to write header, bitmap and page into vmcore

2013-05-16 Thread Qiao Nuohan
The following patch will use these functions to write cached data into vmcore. Header is cached in DumpState, and bitmap and page are cached in tmp files. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 259

[Qemu-devel] [PATCH 9/9 v3] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-16 Thread Qiao Nuohan
the ELF format because of the compression support. 2. The kdump-compressed format is the 5th edition. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Signed-off-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- configure | 50 dump.c| 102

[Qemu-devel] [PATCH 0/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-14 Thread Qiao Nuohan
available. Changelog: Changes from v1 to v2: 1. Address Eric Daniel's comment: fix manner of string copy. 2. Address Eric's comment: replace reinventing new constants by using the ready-made ones accoring. 3. Address Andreas's comment: remove useless include. Qiao Nuohan (9): Add API

[Qemu-devel] [PATCH 3/9 v2] Move includes and struct definition to dump.h

2013-05-14 Thread Qiao Nuohan
Move includes and definition of struct DumpState into include/sysemu/dump.h. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 29 - include/sysemu/dump.h | 30

[Qemu-devel] [PATCH 4/9 v2] Add API to create header of vmcore

2013-05-14 Thread Qiao Nuohan
Add API to create header, sub header of vmcore in kdump-compressed format. The data is store in struct DumpState. The following patch will use this function to gather data of header, then write them into vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan

[Qemu-devel] [PATCH 2/9 v2] Add API to manipulate cache_data

2013-05-14 Thread Qiao Nuohan
-stub.o LIBS+=$(libs_softmmu) diff --git a/cache_data.c b/cache_data.c new file mode 100644 index 000..469ed94 --- /dev/null +++ b/cache_data.c @@ -0,0 +1,121 @@ +/* + * QEMU cache data + * + * Copyright Fujitsu, Corp. 2013 + * + * Authors: + * Qiao Nuohan qiaonuo...@cn.fujitsu.com

[Qemu-devel] [PATCH 5/9 v2] Add API to create data of dump bitmap

2013-05-14 Thread Qiao Nuohan
Add API to get data of the 1st and 2nd dump bitmap and save them into tmp files. The following patch will use these functions to gather data of dump bitmap, then write them into vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com

[Qemu-devel] [PATCH 6/9 v2] Add API to create page

2013-05-14 Thread Qiao Nuohan
Add API to get data of page desc and page data and save them into tmp files. The following patch will use these functions to gather data of page desc and page data, then write them into vmcore Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com

[Qemu-devel] [PATCH 8/9 v2] Add API to write header, bitmap and page into vmcore

2013-05-14 Thread Qiao Nuohan
The following patch will use these functions to write cached data into vmcore. Header is cached in DumpState, and bitmap and page are cached in tmp files. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c| 259

[Qemu-devel] [PATCH 7/9 v2] Add API to free buf used by creating header, bitmap and page

2013-05-14 Thread Qiao Nuohan
When calling create_header, create_dump_bitmap and create_pages, some memory spaces are allocated. The following patch will use this function to free these spaces. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- dump.c | 19

[Qemu-devel] [PATCH 9/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-14 Thread Qiao Nuohan
the ELF format because of the compression support. 2. The kdump-compressed format is the 5th edition. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Signed-off-by: Zhang Xiaohe zhan...@cn.fujitsu.com --- configure | 50 +++ dump.c| 106

[Qemu-devel] [PATCH 1/9 v2] Add API to manipulate dump_bitmap

2013-05-14 Thread Qiao Nuohan
Struct dump_bitmap is associated with a tmp file, and the tmp file can be used to save data of bitmap in kdump-compressed format temporarily. The following patch will use these functions to get the data of bitmap and cache them into tmp files. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com

Re: [Qemu-devel] [PATCH 9/9 v2] Make monitor command 'dump-guest-memory' dump in kdump-compressed format

2013-05-14 Thread Qiao Nuohan
On 05/15/2013 10:55 AM, Eric Blake wrote: On 05/14/2013 08:29 PM, Qiao Nuohan wrote: Make monitor command 'dump-guest-memory' dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1

[Qemu-devel] [PATCH 4/9] Add API to create header of vmcore

2013-05-07 Thread Qiao Nuohan
Add API to create header, sub header of vmcore in kdump-compressed format. The data is store in struct DumpState. The following patch will use this function to gather data of header, then write them into vmcore. Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan

[Qemu-devel] [PATCH 6/9] Add API to create page

2013-05-07 Thread Qiao Nuohan
Add API to get data of page desc and page data and save them into tmp files. The following patch will use these functions to gather data of page desc and page data, then write them into vmcore Signed-off-by: Qiao Nuohan qiaonuo...@cn.fujitsu.com Reviewed-by: Zhang Xiaohe zhan...@cn.fujitsu.com

  1   2   >