arily changed the 185 test output to make it pass for the QEMU
> 2.12 release but now it's time to address this issue.
>
Verified on s390x. Thx
Reviewed-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
> Cc: QingFeng Hao <ha...@linux.vnet.ibm.com>
> Signed-off-by:
在 2018/4/24 19:49, Dr. David Alan Gilbert 写道:
> * QingFeng Hao (ha...@linux.vnet.ibm.com) wrote:
>>
>>
>> 在 2018/4/13 16:05, Perez Blanco, Ricardo (Nokia - BE/Antwerp) 写道:
>>> Dear all,
>>>
>>> Here you can find my first contribution to qemu. Pleas
lue->name, errp));
> +}
> +if (g_ascii_strncasecmp(entry->value->type, "uint", 4) == 0) {
> + Error **errp = NULL;
> +entry->value->value = g_strdup_printf("%lu",
> +object_property_get_uint(obj, entry->value->name, errp));
> +}
> +if (g_ascii_strncasecmp(entry->value->type, "bool", 4) == 0) {
> +Error **errp = NULL;
> +entry->value->value = g_strdup_printf("%s",
> + (object_property_get_bool(obj, entry->value->name, errp) ==
> true)
> +? "true" : "false");
> +}
> +
> }
>
> return props;
> --
> 1.8.3.1
>
>
--
Regards
QingFeng Hao
在 2018/4/18 22:04, Dr. David Alan Gilbert 写道:
> * QingFeng Hao (ha...@linux.vnet.ibm.com) wrote:
>> Hi all,
>> I did some investigation and found that "virsh qemu-monitor-command"
>> supports qom-get,
>> but qemu hmp doesn't. However, in hmp.c there are qom
nodefaults -machine accel=qtest -no-shutdown -nographic -monitor
stdio -serial none -hda /root/t.qcow2
"info qtree" can only get a few properties.
Thanks a lot!
--
Regards
QingFeng Hao
not optimal, so make the test pass again.
>
> Fixes: 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce
> vm_shutdown()")
> Cc: Kevin Wolf <kw...@redhat.com>
> Cc: QingFeng Hao <ha...@linux.vnet.ibm.com>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com
not optimal, so make the test pass again.
>
> Fixes: 4486e89c219c0d1b9bd8dfa0b1dd5b0d51ff2268 ("vl: introduce
> vm_shutdown()")
> Cc: Kevin Wolf <kw...@redhat.com>
> Cc: QingFeng Hao <ha...@linux.vnet.ibm.com>
> Signed-off-by: Stefan Hajnoczi <stefa...@red
在 2018/3/26 18:29, Kevin Wolf 写道:
Am 23.03.2018 um 04:43 hat QingFeng Hao geschrieben:
Test case 185 failed since commit 4486e89c219 --- "vl: introduce vm_shutdown()".
It's because of the newly introduced function vm_shutdown calls bdrv_drain_all,
which is called later by bdrv
在 2018/3/23 18:04, Stefan Hajnoczi 写道:
On Fri, Mar 23, 2018 at 3:43 AM, QingFeng Hao <ha...@linux.vnet.ibm.com> wrote:
Test case 185 failed since commit 4486e89c219 --- "vl: introduce vm_shutdown()".
It's because of the newly introduced function vm_shutdown calls bdrv_
's comment.
* Change 185.out accordingly as job's status is changed as well.
Change Log (v1):
* Remove the call to bdrv_drain_all in vm_shutdown to make case 185 passed.
QingFeng Hao (1):
iotests: fix test case 185
blockjob.c | 10 +-
include/block/blockjob.h | 5 +
bs' status are changed as well.
The fix is to not resume the jobs that are already yielded and also change
185.out accordingly.
Suggested-by: Stefan Hajnoczi <stefa...@gmail.com>
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
---
blockjob.c | 10 +-
in
在 2018/3/21 11:12, QingFeng Hao 写道:
在 2018/3/20 22:31, Stefan Hajnoczi 写道:
On Tue, Mar 20, 2018 at 11:11:01AM +0100, Kevin Wolf wrote:
Am 19.03.2018 um 18:53 hat Christian Borntraeger geschrieben:
On 03/19/2018 05:10 PM, Stefan Hajnoczi wrote:
On Mon, Mar 19, 2018 at 9:35 AM, QingFeng
在 2018/3/20 22:31, Stefan Hajnoczi 写道:
On Tue, Mar 20, 2018 at 11:11:01AM +0100, Kevin Wolf wrote:
Am 19.03.2018 um 18:53 hat Christian Borntraeger geschrieben:
On 03/19/2018 05:10 PM, Stefan Hajnoczi wrote:
On Mon, Mar 19, 2018 at 9:35 AM, QingFeng Hao <ha...@linux.vnet.ibm.com>
bs' status are changed as well.
Thus, let's not call bdrv_drain_all in vm_shutdown.
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
---
cpus.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index 2e6701795b..ae2962508c 100644
--- a/cpu
t;seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event":
"BLOCK_JOB_COMPLETED", "data": {"device": "disk", "len": 4194304, "offset":
4194304, "speed": 65536, "type": "mirror"}}
在 2018/3/6 15:56, Christian Borntraeger 写道:
Nack. This will be fixed by
s390/ipl: only print boot menu error if -boot menu=on was specified
You are right. After I applied that patch, the case is passed.
Please ignore this patch. Thanks
On 03/06/2018 08:54 AM, QingFeng Hao wrote:
In s390x
i-hd,drive=drive_sysdisk,bus=scsi0.0,id=sysdisk,bootindex=0
-nographic
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
---
tests/qemu-iotests/200 | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/200 b/tests/qemu-iotests/200
index ddbdedc476..7e53bd7774 100755
在 2017/11/8 3:35, Eric Blake 写道:
On 11/07/2017 05:00 AM, QingFeng Hao wrote:
+
+##
+# @GuestPanicInformationS390:
+#
+# S390 specific guest panic information (PSW)
+#
+# Since: 2.11
+##
+{'struct': 'GuestPanicInformationS390',
+ 'data': { 'psw-mask': 'uint64',
+ 'psw-addr': 'uint64
qemu_system_guest_panicked has to parse the 'reason' before
it prints it, but
qemu_system_guest_panicked is a common function and we don't want to do
more arch
related handling there.
Thanks!
--
Regards
QingFeng Hao
Reviewed-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
for the series of patches.
Thanks
在 2017/9/13 17:10, Cornelia Huck 写道:
Recent changes in s390x made pci support dependant on the zpci cpu
feature, which is not provided on all models (and not on by default).
This means we cannot inst
在 2017/9/6 15:32, Cornelia Huck 写道:
On Wed, 6 Sep 2017 15:19:01 +0800
QingFeng Hao <ha...@linux.vnet.ibm.com> wrote:
在 2017/9/5 23:16, Cornelia Huck 写道:
The default cpu model on s390x does not provide zPCI, which is
not yet wired up on tcg. Moreover, virtio-ccw is the standard
on s39
dev/null
+++ b/tests/qemu-iotests/051.s390-ccw-virtio.out
[...]
--
Regards
QingFeng Hao
+-
7 files changed, 936 insertions(+), 7 deletions(-)
create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out
create mode 100644 tests/qemu-iotests/067.s390-ccw-virtio.out
--
Regards
QingFeng Hao
在 2017/7/5 23:15, Stefan Hajnoczi 写道:
On Tue, Jul 04, 2017 at 03:23:49PM +0200, QingFeng Hao wrote:
This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw.
It's based on commit c324fd0a39c by Stefan Hajnoczi.
Thanks!
Change history:
v4:
Got Cornelia Huck's Reviewed
在 2017/7/4 22:04, Christian Borntraeger 写道:
On 07/04/2017 03:23 PM, QingFeng Hao wrote:
This patch is based on a similar patch from Stefan Hajnoczi -
commit c324fd0a39c ("virtio-pci: use ioeventfd even when KVM is disabled")
Do not check kvm_eventfds_enabled() when KVM is disa
hurt and qemu-iotests 068 can pass with
skipping iothread arguments.
I have tested that virtio-scsi-ccw works under tcg both with and without
iothread.
This patch fixes qemu-iotests 068, which was accidentally merged early
despite the dependency on ioeventfd.
Signed-off-by: QingFeng Hao <h
Huck's comment to check
if kvm is enabled in s390_assign_subch_ioeventfd instead of
kvm_s390_assign_subch_ioeventfd to as the former is a general one.
v2:
Remove Stefan from sign-off list and change the patch's commit message
according to Christian Borntraeger's comment.
QingFeng Hao
在 2017/7/4 17:34, Cornelia Huck 写道:
On Tue, 4 Jul 2017 10:32:31 +0200
QingFeng Hao <ha...@linux.vnet.ibm.com> wrote:
This patch is based on a similar patch from Stefan Hajnoczi -
commit c324fd0a39c (" virtio-pci: use ioeventfd even when KVM is disabled)
Do not check kvm_event
ests 068, which was accidentally merged early
despite the dependency on ioeventfd.
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
---
hw/s390x/virtio-ccw.c | 2 +-
target/s390x/cpu.h| 6 +-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s39
of
kvm_s390_assign_subch_ioeventfd to as the former is a general one.
v2:
Remove Stefan from sign-off list and change the patch's commit message
according to Christian Borntraeger's comment.
QingFeng Hao (1):
virtio-scsi-ccw: use ioeventfd even when KVM is disabled
hw/s390x/virtio-ccw.c | 2
在 2017/7/4 15:06, Christian Borntraeger 写道:
On 07/04/2017 05:41 AM, QingFeng Hao wrote:
在 2017/7/3 18:20, Christian Borntraeger 写道:
On 07/03/2017 10:51 AM, QingFeng Hao wrote:
This patch is based on a similar patch from Stefan Hajnoczi -
commit c324fd0a39c (" virtio-pci: use ioeventfd
在 2017/7/3 19:48, Cornelia Huck 写道:
On Mon, 3 Jul 2017 09:38:36 +0200
QingFeng Hao <ha...@linux.vnet.ibm.com> wrote:
Do not check kvm_eventfds_enabled() when KVM is disabled since it
always returns 0. Since commit
8c56c1a592b5092d91da8d8943c1d6462a6f ("memory: emulat
在 2017/7/3 18:20, Christian Borntraeger 写道:
On 07/03/2017 10:51 AM, QingFeng Hao wrote:
This patch is based on a similar patch from Stefan Hajnoczi -
commit c324fd0a39c (" virtio-pci: use ioeventfd even when KVM is disabled)
Do not check kvm_eventfds_enabled() when KVM is disabled
This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw.
It's based on commit c324fd0a39c by Stefan Hajnoczi.
Thanks!
Change history:
v2:
Remove Stefan from sign-off list and change the patch's commit message
according to Christian Borntraeger's comment.
QingFeng Hao (1
ests 068, which was accidentally merged early
despite the dependency on ioeventfd.
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
---
hw/s390x/virtio-ccw.c | 2 +-
target/s390x/kvm.c| 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s39
在 2017/7/3 16:21, Christian Borntraeger 写道:
On 07/03/2017 10:08 AM, QingFeng Hao wrote:
在 2017/7/3 15:41, Christian Borntraeger 写道:
On 07/03/2017 09:38 AM, QingFeng Hao wrote:
Do not check kvm_eventfds_enabled() when KVM is disabled since it
always returns 0. Since commit
在 2017/7/3 15:41, Christian Borntraeger 写道:
On 07/03/2017 09:38 AM, QingFeng Hao wrote:
Do not check kvm_eventfds_enabled() when KVM is disabled since it
always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f
("memory: emulate ioeventfd") it has been possi
ion/misc.h | 1 -
migration/migration.c| 20 +---
qemu-options.hx | 8
vl.c | 26 +-
4 files changed, 30 insertions(+), 25 deletions(-)
--
Regards
QingFeng Hao
read0 work even
when KVM is disabled.
I have tested that virtio-scsi-ccw works under tcg both with and without
iothread.
This patch fixes qemu-iotests 068, which was accidentally merged early
despite the dependency on ioeventfd.
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
Signe
This commit fixes iotest 068 for s390x as s390x uses virtio-scsi-ccw.
The related commit is c324fd0a39c for other platforms by Stefan Hajnoczi.
Thanks!
QingFeng Hao (1):
virtio-scsi-ccw: use ioeventfd even when KVM is disabled
hw/s390x/virtio-ccw.c | 2 +-
target/s390x/kvm.c| 3 +++
2
在 2017/6/28 18:22, Kevin Wolf 写道:
Am 28.06.2017 um 12:11 hat QingFeng Hao geschrieben:
在 2017/6/24 0:21, Kevin Wolf 写道:
From: Stefan Hajnoczi <stefa...@redhat.com>
Old kvm.ko versions only supported a tiny number of ioeventfds so
virtio-pci avoids ioeventfds when kvm_has_many_ioev
在 2017/6/28 18:22, Kevin Wolf 写道:
Am 28.06.2017 um 12:11 hat QingFeng Hao geschrieben:
在 2017/6/24 0:21, Kevin Wolf 写道:
From: Stefan Hajnoczi <stefa...@redhat.com>
Old kvm.ko versions only supported a tiny number of ioeventfds so
virtio-pci avoids ioeventfds when kvm_has_many_ioev
gt;k->ioeventfd_enabled-->virtio_pci_ioeventfd_enabled
virtio_pci_ioeventfd_enabled checks flag VIRTIO_PCI_FLAG_USE_IOEVENTFD
which was
cleared in virtio_pci_realize if this patch isn't applied.
Thanks!
--
Regards
QingFeng Hao
在 2017/6/7 20:18, Dr. David Alan Gilbert 写道:
* QingFeng Hao (ha...@linux.vnet.ibm.com) wrote:
在 2017/6/6 20:49, Kevin Wolf 写道:
Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben:
I can't tell for postcopy_ram_listen_thread() - commit 660819b didn't
seem to remove a qemu_fclose() call
在 2017/6/6 20:49, Kevin Wolf 写道:
Am 06.06.2017 um 07:24 hat QingFeng Hao geschrieben:
In load_snapshot, mis->from_src_file is freed twice, the first free is by
qemu_fclose, the second is by migration_incoming_state_destroy and
it causes Illegal instruction exception. The fix is just to rem
path
unconditionally".
Change Log(v2):
Got reviewed-by from Dr. David Alan Gilbert and Peter Xu.
Thanks!
QingFeng Hao (1):
qemu/migration: fix the double free problem on from_src_file
migration/savevm.c | 1 -
1 file changed, 1 deletion(-)
--
2.11.2
+fi; exec "$QEMU_PROG" $QEMU_OPTIONS "$@" )
QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) quit
-*** done
+(qemu) *** done
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Reviewed-by
在 2017/6/6 11:50, Peter Xu 写道:
On Tue, Jun 06, 2017 at 11:38:05AM +0800, QingFeng Hao wrote:
在 2017/6/6 11:03, Peter Xu 写道:
On Mon, Jun 05, 2017 at 12:48:51PM +0200, QingFeng Hao wrote:
In load_vmstate, mis->from_src_file is freed twice, the first free is by
qemu_fclose, the sec
在 2017/6/6 11:03, Peter Xu 写道:
On Mon, Jun 05, 2017 at 12:48:51PM +0200, QingFeng Hao wrote:
In load_vmstate, mis->from_src_file is freed twice, the first free is by
qemu_fclose, the second is by migration_incoming_state_destroy and
it causes Illegal instruction exception. The fix is j
在 2017/6/5 19:08, Dr. David Alan Gilbert 写道:
* QingFeng Hao (ha...@linux.vnet.ibm.com) wrote:
In load_vmstate, mis->from_src_file is freed twice, the first free is by
qemu_fclose, the second is by migration_incoming_state_destroy and
it causes Illegal instruction exception. The fix is j
+fi; exec "$QEMU_PROG" $QEMU_OPTIONS "$@" )
QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) quit
-*** done
+(qemu) *** done
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
---
migration/savevm.c | 1 -
1 file changed, 1 deletion(-)
diff --
path
unconditionally".
Thanks!
QingFeng Hao (1):
qemu/migration: fix the double free problem on from_src_file
migration/savevm.c | 1 -
1 file changed, 1 deletion(-)
--
2.11.2
在 2017/3/16 16:01, Juan Quintela 写道:
QingFeng Hao <ha...@linux.vnet.ibm.com> wrote:
This problem affects s390x only if we are running without KVM.
Basically, S390CPU.irqstate is unused if we do not use KVM,
and thus no buffer is allocated.
This causes size=0, first_elem=NULL and n_e
在 2017/3/14 22:13, Dr. David Alan Gilbert 写道:
* QingFeng Hao (ha...@linux.vnet.ibm.com) wrote:
This problem affects s390x only if we are running without KVM.
Basically, S390CPU.irqstate is unused if we do not use KVM,
and thus no buffer is allocated.
This causes size=0, first_elem=NULL
Hi All,
This patch is to fix the failed iotests case 68 and 91 and has been
tested. It's based on commit dd4d2578215 "Merge remote-tracking branch
'remotes/kraxel/tags/pull-fixes-20170309-1' into staging" and according
to Halil and Dave's comments. Also thanks for Fam and Kevin.
QingF
back to the old behavior and support
VMS_VBUFFER with size 0 and nullptr.
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com>
---
migration/vmstate.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
在 2017/3/9 19:45, Halil Pasic 写道:
On 03/09/2017 03:55 AM, QingFeng Hao wrote:
在 2017/3/8 19:33, Halil Pasic 写道:
On 03/08/2017 08:05 AM, QingFeng Hao wrote:
在 2017/3/7 18:19, Halil Pasic 写道:
On 03/07/2017 11:05 AM, Kevin Wolf wrote:
Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben
在 2017/3/8 19:33, Halil Pasic 写道:
On 03/08/2017 08:05 AM, QingFeng Hao wrote:
在 2017/3/7 18:19, Halil Pasic 写道:
On 03/07/2017 11:05 AM, Kevin Wolf wrote:
Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben:
On 03/07/2017 10:29 AM, Kevin Wolf wrote:
Am 07.03.2017 um 03:53 hat QingFeng Hao
在 2017/3/7 18:19, Halil Pasic 写道:
On 03/07/2017 11:05 AM, Kevin Wolf wrote:
Am 07.03.2017 um 10:54 hat Halil Pasic geschrieben:
On 03/07/2017 10:29 AM, Kevin Wolf wrote:
Am 07.03.2017 um 03:53 hat QingFeng Hao geschrieben:
I am not very clear about the logic in vmstate.c, but from its
在 2017/3/7 14:37, Fam Zheng 写道:
On Tue, 03/07 03:53, QingFeng Hao wrote:
Hi All,
I am not sure if the fix is correct because I am not very clear about the
logic in vmstate.c. From my test, once size=0, the iotests case 68 failed
due to the assert. So just send this draft patch for your
ranch
'remotes/dgibson/tags/ppc-for-2.9-20170303' into staging".
Thanks!
QingFeng Hao (1):
vmstate: fix the failure of iotests cases 68 and 91
migration/vmstate.c | 8
1 file changed, 8 insertions(+)
--
2.8.4
e
+./common.qemu: line 110: write error: Broken pipe
+./common.qemu: line 110: write error: Broken pipe
+./common.qemu: line 110: write error: Broken pipe
+./common.qemu: line 110: write error: Broken pipe
+Timeout waiting for completed on handle 0
Signed-off-by: QingFeng Ha
to little-endian before storing to disk.
Cc: qemu-sta...@nongnu.org
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
Signed-off-by: Jing Liu <liuj...@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kw...@redhat.com>
Reviewed-by: Fam Zheng <f...@redhat.com>
---
block
!
QingFeng Hao
Cc: qemu-sta...@nongnu.org
QingFeng Hao (1):
block/vmdk: Fix the endian problem of buf_len and lba
block/vmdk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.8.4
to little-endian before storing to disk.
Cc: qemu-sta...@nongnu.org
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
Signed-off-by: Jing Liu <liuj...@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kw...@redhat.com>
---
block/vmdk.c | 4 ++--
1 file changed, 2 insertio
reading offset 0 of
tests/qemu-iotests/scratch/blockdev-target.img: Invalid argument
Thanks!
QingFeng Hao (1):
block/vmdk: Fix the endian problem of buf_len and lba
block/vmdk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.8.4
it from little-endian to cpu endian.
If the cpu is big-endian like s390, the problem will happen and
the data length read by vmdk_read_extent will become invalid!
The fix is to add the conversion in vmdk_write_extent.
Signed-off-by: QingFeng Hao <ha...@linux.vnet.ibm.com>
Signed-off-by: Jing Liu
-iotests/scratch/blockdev-target.img: Invalid argument
+qemu-img: Error while reading offset 0 of
tests/qemu-iotests/scratch/blockdev-target.img: Invalid argument
QingFeng Hao (1):
block/vmdk: Fix the endian problem of buf_len
block/vmdk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
68 matches
Mail list logo
