Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-21 Thread Ravi Bangoria
Hi Cedric, On 4/21/21 12:01 PM, Cédric Le Goater wrote: On 4/21/21 8:20 AM, Ravi Bangoria wrote: Hi David, On 4/19/21 10:23 AM, David Gibson wrote: On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability

Re: [PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-21 Thread Ravi Bangoria
Hi David, On 4/19/21 10:23 AM, David Gibson wrote: On Mon, Apr 12, 2021 at 05:14:33PM +0530, Ravi Bangoria wrote: As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd DAWR is present, otherwise not. Use

[PATCH v5 1/3] Linux headers: update from 5.12-rc3

2021-04-12 Thread Ravi Bangoria
Update against Linux 5.12-rc3 Signed-off-by: Ravi Bangoria --- include/standard-headers/drm/drm_fourcc.h | 23 - include/standard-headers/linux/input.h| 2 +- .../standard-headers/rdma/vmw_pvrdma-abi.h| 7 ++ linux-headers/asm-generic/unistd.h| 4 +- linux

[PATCH v5 2/3] ppc: Rename current DAWR macros and variables

2021-04-12 Thread Ravi Bangoria
Power10 is introducing second DAWR. Use real register names (with suffix 0) from ISA for current macros and variables used by Qemu. One exception to this is KVM_REG_PPC_DAWR[X]. This is from kernel uapi header and thus not changed in kernel as well as Qemu. Signed-off-by: Ravi Bangoria Reviewed

[PATCH v5 0/3] ppc: Enable 2nd DAWR support on Power10

2021-04-12 Thread Ravi Bangoria
patch. (Sync headers from v5.12-rc3) [1] https://git.kernel.org/torvalds/c/bd1de1a0e6eff Ravi Bangoria (3): Linux headers: update from 5.12-rc3 ppc: Rename current DAWR macros and variables ppc: Enable 2nd DAWR support on p10 hw/ppc/spapr.c| 7 +- hw/ppc/

[PATCH v5 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-12 Thread Ravi Bangoria
bit in guest DT using cap-dawr1 machine capability. Though, watchpoint on powerpc TCG guest is not supported and thus 2nd DAWR is not enabled for TCG mode. Signed-off-by: Ravi Bangoria Reviewed-by: Greg Kurz --- hw/ppc/spapr.c | 7 ++- hw/ppc/spapr_caps.c | 32

Re: [PATCH v4 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-07 Thread Ravi Bangoria
+static void cap_dawr1_apply(SpaprMachineState *spapr, uint8_t val, + Error **errp) +{ +ERRP_GUARD(); +if (!val) { +return; /* Disable by default */ +} + +if (tcg_enabled()) { +error_setg(errp, "DAWR1 not supported in TCG."); +

[PATCH v4 3/3] ppc: Enable 2nd DAWR support on p10

2021-04-05 Thread Ravi Bangoria
bit in guest DT using cap-dawr1 machine capability. Though, watchpoint on powerpc TCG guest is not supported and thus 2nd DAWR is not enabled for TCG mode. Signed-off-by: Ravi Bangoria --- hw/ppc/spapr.c | 7 ++- hw/ppc/spapr_caps.c | 32

[PATCH v4 2/3] ppc: Rename current DAWR macros and variables

2021-04-05 Thread Ravi Bangoria
Power10 is introducing second DAWR. Use real register names (with suffix 0) from ISA for current macros and variables used by Qemu. One exception to this is KVM_REG_PPC_DAWR[X]. This is from kernel uapi header and thus not changed in kernel as well as Qemu. Signed-off-by: Ravi Bangoria Reviewed

[PATCH v4 1/3] Linux headers: update from 5.12-rc3

2021-04-05 Thread Ravi Bangoria
Update against Linux 5.12-rc3 Signed-off-by: Ravi Bangoria --- include/standard-headers/drm/drm_fourcc.h | 23 - include/standard-headers/linux/input.h| 2 +- .../standard-headers/rdma/vmw_pvrdma-abi.h| 7 ++ linux-headers/asm-generic/unistd.h| 4 +- linux

[PATCH v4 0/3] ppc: Enable 2nd DAWR support on Power10

2021-04-05 Thread Ravi Bangoria
when host kvm supports it. User has to manually enable it with -machine cap-dawr1=on if he wishes to use it. - Split the header file changes into separate patch. (Sync headers from v5.12-rc3) [1] https://git.kernel.org/torvalds/c/bd1de1a0e6eff Ravi Bangoria (3): Linux headers: up

Re: [PATCH v3 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-31 Thread Ravi Bangoria
On 3/31/21 5:06 AM, David Gibson wrote: On Tue, Mar 30, 2021 at 06:48:38PM +0200, Greg Kurz wrote: On Tue, 30 Mar 2021 15:23:50 +0530 Ravi Bangoria wrote: As per the PAPR, bit 0 of byte 64 in pa-features property indicates availability of 2nd DAWR registers. i.e. If this bit is set, 2nd

[PATCH v3 1/3] Linux headers: update from 5.12-rc3

2021-03-30 Thread Ravi Bangoria
Update against Linux 5.12-rc3 Signed-off-by: Ravi Bangoria --- include/standard-headers/drm/drm_fourcc.h | 23 - include/standard-headers/linux/input.h| 2 +- .../standard-headers/rdma/vmw_pvrdma-abi.h| 7 ++ linux-headers/asm-generic/unistd.h| 4 +- linux

[PATCH v3 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-30 Thread Ravi Bangoria
bit in guest DT using cap-dawr1 machine capability. Though, watchpoint on powerpc TCG guest is not supported and thus 2nd DAWR is not enabled for TCG mode. Signed-off-by: Ravi Bangoria --- hw/ppc/spapr.c | 11 ++- hw/ppc/spapr_caps.c | 32

[PATCH v3 0/3] ppc: Enable 2nd DAWR support on Power10

2021-03-30 Thread Ravi Bangoria
s from v5.12-rc3) [1] https://git.kernel.org/torvalds/c/bd1de1a0e6eff Ravi Bangoria (3): Linux headers: update from 5.12-rc3 ppc: Rename current DAWR macros and variables ppc: Enable 2nd DAWR support on p10 hw/ppc/spapr.c| 11 ++- hw/ppc/spapr_

[PATCH v3 2/3] ppc: Rename current DAWR macros and variables

2021-03-30 Thread Ravi Bangoria
Power10 is introducing second DAWR. Use real register names (with suffix 0) from ISA for current macros and variables used by Qemu. One exception to this is KVM_REG_PPC_DAWR[X]. This is from kernel uapi header and thus not changed in kernel as well as Qemu. Signed-off-by: Ravi Bangoria

Re: [PATCH v2 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-29 Thread Ravi Bangoria
Hi David, @@ -241,6 +241,31 @@ static void spapr_dt_pa_features(SpaprMachineState *spapr, /* 60: NM atomic, 62: RNG */ 0x80, 0x00, 0x80, 0x00, 0x00, 0x00, /* 60 - 65 */ }; +uint8_t pa_features_310[] = { 66, 0, +/* 0: MMU|FPU|SLB|RUN|DABR|NX, 1:

[PATCH v2 2/3] ppc: Rename current DAWR macros and variables

2021-03-28 Thread Ravi Bangoria
Power10 is introducing second DAWR. Use real register names (with suffix 0) from ISA for current macros and variables used by Qemu. One exception to this is KVM_REG_PPC_DAWR[X]. This is from kernel uapi header and thus not changed in kernel as well as Qemu. Signed-off-by: Ravi Bangoria

[PATCH v2 1/3] Linux headers: update from 5.12-rc3

2021-03-28 Thread Ravi Bangoria
Update against Linux 5.12-rc3 Signed-off-by: Ravi Bangoria --- include/standard-headers/drm/drm_fourcc.h | 23 ++- include/standard-headers/linux/input.h | 2 +- include/standard-headers/rdma/vmw_pvrdma-abi.h | 7 ++ linux-headers/asm-generic/unistd.h | 4

[PATCH v2 3/3] ppc: Enable 2nd DAWR support on p10

2021-03-28 Thread Ravi Bangoria
bit in guest DT using cap-dawr1 machine capability. Signed-off-by: Ravi Bangoria --- hw/ppc/spapr.c | 34 ++ hw/ppc/spapr_caps.c | 32 include/hw/ppc/spapr.h | 6 +- target/ppc/cpu.h

[PATCH v2 0/3] ppc: Enable 2nd DAWR support on Power10

2021-03-28 Thread Ravi Bangoria
ges into separate patch. (Sync headers from v5.12-rc3) [1] https://git.kernel.org/torvalds/c/bd1de1a0e6eff Ravi Bangoria (3): Linux headers: update from 5.12-rc3 ppc: Rename current DAWR macros and variables ppc: Enable 2nd DAWR support on p10 hw/ppc/spap

[PATCH 0/2] ppc: Enable 2nd DAWR support on p10

2020-07-23 Thread Ravi Bangoria
This series enables 2nd DAWR support on p10 qemu/kvm guest. This series depends on kernel patches: https://lore.kernel.org/linuxppc-dev/20200723102058.312282-1-ravi.bango...@linux.ibm.com Patches apply fine on qemu/master branch (c8004fe6bbfc) Ravi Bangoria (2): ppc: Rename current DAWR macros

[PATCH 1/2] ppc: Rename current DAWR macros

2020-07-23 Thread Ravi Bangoria
Power10 is introducing second DAWR. Use real register names (with suffix 0) from ISA for current macros. Signed-off-by: Ravi Bangoria --- include/hw/ppc/spapr.h | 2 +- linux-headers/asm-powerpc/kvm.h | 4 ++-- target/ppc/cpu.h| 4 ++-- target/ppc/translate_init.inc.c

[PATCH 2/2] ppc: Enable 2nd DAWR support on p10

2020-07-23 Thread Ravi Bangoria
so the guest kernel can support 2nd DAWR. Signed-off-by: Ravi Bangoria --- hw/ppc/spapr.c | 33 + include/hw/ppc/spapr.h | 1 + linux-headers/asm-powerpc/kvm.h | 4 linux-headers/linux/kvm.h | 1 + target/ppc/cpu.h