Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2024-03-11 Thread Richard Bagley
LUI and AUIPC would naturally be used to build an address. If you want to supply a signed decimal number to build an immediate, there is always the pseudo-instruction LI. On Mon, Mar 11, 2024 at 11:56 AM Richard Bagley wrote: > I have realized that *the patch is indeed a fix*, not a workaro

Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2024-03-11 Thread Richard Bagley
rew Jones wrote: > On Fri, Mar 08, 2024 at 08:22:01PM -0800, Richard Bagley wrote: > > post-nack, one further comment: > > > > One could argue that this change also aligns QEMU with supporting tools > (as > > Andrew observed), and it makes sense to merge this change

Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2024-03-08 Thread Richard Bagley
with other tools is not as strong. In the meantime, I have adjusted my change locally to include AUIPC, and written a substantive, and I hope, clear commit description. If you would like me to resubmit a patch with this updated change, please let me know. On Thu, Mar 7, 2024 at 4:08 PM Richard Bagley

Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2024-03-07 Thread Richard Bagley
10, 2023 at 06:27:50PM +0200, Andrew Jones wrote: > > > On Thu, Aug 10, 2023 at 09:12:42AM -0700, Palmer Dabbelt wrote: > > > > On Thu, 10 Aug 2023 08:31:46 PDT (-0700), ajo...@ventanamicro.com > wrote: > > > > > On Mon, Jul 31, 2023 at 11:33:20AM -0700, Ric

Re: [PATCH] disas/riscv: Further correction to LUI disassembly

2023-08-07 Thread Richard Bagley
derson < richard.hender...@linaro.org> wrote: > On 7/31/23 11:33, Richard Bagley wrote: > > The recent commit 36df75a0a9 corrected one aspect of LUI disassembly > > by recovering the immediate argument from the result of LUI with a > > shift right by 12. However

[PATCH] disas/riscv: Further correction to LUI disassembly

2023-07-31 Thread Richard Bagley
includes a sign bit). Example: 0xf000 >> 12 = 0x 0xf000 >> 12 & 0xf = 0x000f Fixes: 36df75a0a9 ("riscv/disas: Fix disas output of upper immediates") Signed-off-by: Richard Bagley --- disas/riscv.c | 9 ++--- 1 file changed, 6 insertions(+),