On Wed, Sep 29, 2021 at 10:01:55AM +0200, Michal Privoznik wrote:
> Apparently, parsing vmx.genid is not as easy as I thought. Anyway, it
> was brought up in a private thread that libvirt doesn't report correct
> UUIDs. For instance for the following input:
>
> vm.genid = "-8536691797830587195"
On Mon, Sep 27, 2021 at 04:18:34PM -0500, Eric Blake wrote:
> On Fri, Jul 23, 2021 at 11:33:03AM +0100, Richard W.M. Jones wrote:
> > Under SELinux, Unix domain sockets have two labels. One is on the
> > disk and can be set with commands such as chcon(1). There is a
> > d
On Wed, Sep 15, 2021 at 10:15:20AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 14.09.2021 19:32, Richard W.M. Jones wrote:
> >On Tue, Sep 14, 2021 at 06:21:58PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> >>14.09.2021 17:52, Richard W.M. Jones wrote:
> >>>On the
&g
On Tue, Sep 14, 2021 at 06:21:58PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 14.09.2021 17:52, Richard W.M. Jones wrote:
> > On the
> >server side when the server receives NBD_CMD_DISC it must complete any
> >in-flight requests, but there's no requirement for the server
On Tue, Sep 14, 2021 at 05:40:59PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 13.09.2021 18:19, Richard W.M. Jones wrote:
> >$ rm -f /tmp/sock /tmp/pid
> >$ qemu-img create -f qcow2 /tmp/disk.qcow2 1M
> >$ qemu-nbd -t --format=qcow2 --socket=/tmp/sock --pid-file=/tmp/pi
On Mon, Sep 13, 2021 at 09:19:22AM -0700, Richard Henderson wrote:
> On 9/13/21 4:07 AM, Richard W.M. Jones wrote:
> >>[0.00] Linux version 5.14.0-60.fc36.armv7hl
> >>(mockbu...@buildvm-a32-12.iad2.fedoraproject.org) (gcc (GCC) 11.2.1
> >>20210728 (Red Hat
sage
was not printed:
$ nbdsh -u 'nbd+unix:///?socket=/tmp/sock' -c 'h.get_size()' -c 'h.shutdown()'
Signed-off-by: Richard W.M. Jones
---
nbd/server.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/nbd/server.c b/nbd/server.c
index 3927f7789d..e0a43802b2 100644
--- a/nbd/serv
On Mon, Sep 13, 2021 at 05:07:12PM +0200, Kevin Wolf wrote:
> > > if (ret < 0) {
> > > -error_prepend(_err, "Failed to send reply: ");
> > > +if (errno != EPIPE) {
> > > +error_prepend(_err, "Failed to send reply: ");
> > > +} else {
> > > +
instructions that we emit.
>
> Remove the assertion in temp_allocate_frame, limit natural alignment
> to the provided stack alignment, and add a comment.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Richard Henderson
> ---
>
> I haven't seen the assertion wit
instructions that we emit.
>
> Remove the assertion in temp_allocate_frame, limit natural alignment
> to the provided stack alignment, and add a comment.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Richard Henderson
> ---
>
> I haven't seen the assertion wit
Just commenting from the libguestfs POV:
We don't care about migration, and:
On Wed, Sep 08, 2021 at 05:08:08PM +0100, Daniel P. Berrangé wrote:
> On non-x86 emulators I see graphics=off has semantic effects beyond
> just controlling whether the firmware prints to the serial or not
> though.
On Mon, Sep 06, 2021 at 06:45:08PM +0300, Konstantin Kostiuk wrote:
> Hi All,
>
> I reviewed glib, libguestfs, and libosinfo tools. All tools read the registry
> to get information about Windows but read different registry values. All
> information is returned in a localized form.
> Related key:
his lets Fedora kernels boot once again.
>
> Signed-off-by: Daniel P. Berrangé
> Tested-by: Richard W.M. Jones
I tested it again and it still works:
$ LIBGUESTFS_BACKEND_SETTINGS=force_tcg LIBGUESTFS_HV=$PWD/qemu-system-x86_64
libguestfs-test-tool
...
= TEST FINISHED OK =
On Thu, Sep 02, 2021 at 02:36:51PM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 02, 2021 at 03:36:01PM +0300, Konstantin Kostiuk wrote:
> > Hi Team,
> >
> > We have several bugs related to 'guest-get-osinfo' command in Windows Guest
> > Agent:
> >
On Thu, Sep 02, 2021 at 08:36:56AM +0100, Peter Maydell wrote:
> On Wed, 1 Sept 2021 at 21:24, Richard W.M. Jones wrote:
> >
> > On Wed, Sep 01, 2021 at 09:17:07PM +0100, Peter Maydell wrote:
> > > On Wed, 1 Sept 2021 at 19:51, Richard W.M. Jones
> > > wrot
On Wed, Sep 01, 2021 at 09:17:07PM +0100, Peter Maydell wrote:
> On Wed, 1 Sept 2021 at 19:51, Richard W.M. Jones wrote:
> >
> > On Wed, Sep 01, 2021 at 07:41:21PM +0100, Peter Maydell wrote:
> > > Is the failure case short enough to allow -d ... logging to
> > >
On Wed, Sep 01, 2021 at 07:41:21PM +0100, Peter Maydell wrote:
> Is the failure case short enough to allow -d ... logging to
> be taken? That's usually the most useful info, but it's so huge
> it's often not feasible.
I can try -- what exact -d option would be useful?
Rich.
--
Richard Jones,
On Wed, Sep 01, 2021 at 07:18:03PM +0100, Peter Maydell wrote:
> On Wed, 1 Sept 2021 at 18:01, Richard W.M. Jones wrote:
> >
> > This avoids the following assertion when the kernel initializes X.509
> > certificates:
> >
> > [7.315373] Loading compiled-in X
https://www.mail-archive.com/qemu-devel@nongnu.org/msg833146.html
I tested this patch which simply increases the stack alignment to 16
bytes and it fixes the assertion failure and otherwise appears to work
(in as far as it boots the libguestfs appliance). However I've no
idea if this is the
tps://bugzilla.redhat.com/show_bug.cgi?id=1999878
Cc: qemu-sta...@nongnu.org
Tested-by: Richard W.M. Jones
Signed-off-by: Richard W.M. Jones
---
tcg/arm/tcg-target.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/arm/tcg-target.h b/tcg/arm/tcg-target.h
index d113b7f8db..09df3b3
On Sat, Jun 19, 2021 at 11:14:49AM -0700, Richard Henderson wrote:
> This function should have been updated for vector types
> when they were introduced.
>
> Fixes: d2fd745fe8b
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/367
> Cc: qemu-sta...@nongnu.org
> Tested-by: Stefan Weil
>
| CR4_FSGSBASE_MASK | CR4_PCIDE_MASK | CR4_OSXSAVE_MASK \
> | CR4_SMEP_MASK | CR4_SMAP_MASK | CR4_PKE_MASK |
> CR4_PKS_MASK))
First thing to say is I tested this locally and it fixes the
problem seen in https://bugzilla.redhat.com/show_bug.cgi?id=1999700.
On Thu, Jul 22, 2021 at 05:36:05PM +0200, Paolo Bonzini wrote:
> From: Lara Lazier
>
> All MBZ bits in CR4 must be zero. (APM2 15.5)
> Added reserved bitmask and added checks in both
> helper_vmrun and helper_write_crN.
>
> Signed-off-by: Lara Lazier
> Message-Id:
sh
you would read the beginning and end bytes of the written part to
approximate a check that the whole write has been flushed so parts of
it are not hanging around in the cache of the first connection.
Anyway the patch as written seems fine to me so:
Reviewed-by: Richard W.M. Jones
Rich.
--
R
On Fri, Jul 23, 2021 at 06:18:55PM +0200, Kevin Wolf wrote:
> Am 23.07.2021 um 12:33 hat Richard W.M. Jones geschrieben:
> > Under SELinux, Unix domain sockets have two labels. One is on the
> > disk and can be set with commands such as chcon(1). There is a
> > different l
: https://bugzilla.redhat.com/show_bug.cgi?id=1984938
Signed-off-by: Richard W.M. Jones
---
configure | 9 -
meson.build | 10 +-
meson_options.txt | 3 ++
qemu-nbd.c
v1 was here:
https://lists.nongnu.org/archive/html/qemu-block/2021-07/threads.html#00713
v2 adds the changes to CI docker files as suggested by
Dan Berrange in his review.
Rich.
: https://bugzilla.redhat.com/show_bug.cgi?id=1984938
Signed-off-by: Richard W.M. Jones
---
configure | 9 -
meson.build | 10 +-
meson_options.txt | 3 +++
qemu-nbd.c| 33 +
4 files changed, 53 insertions(+), 2 deletions(-)
diff
https://bugzilla.redhat.com/show_bug.cgi?id=1984938
The purpose of the patch is explained in the commit message / bug. In
the cover I want to explain a couple of design choices.
If libselinux isn't available at build time then the --selinux-label
option is still present. It does not appear in
sage
was not printed:
$ nbdsh -u 'nbd+unix:///?socket=/tmp/sock' -c 'h.get_size()' -c 'h.shutdown()'
Signed-off-by: Richard W.M. Jones
---
nbd/server.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/nbd/server.c b/nbd/server.c
index b60ebc3ab6..0f86535b88 100644
--- a/nbd/serv
This simple patch suppresses a warning message from qemu-nbd when a
client abruptly disconnects. There is a way to work around this in
the client (by shutting down the connection properly). Nevertheless
the "Broken pipe" error seems unnecessary to me as it does not convey
any useful information
t for SHA256 which has been supported in libssh since
> the 0.8.1 release.
>
> Signed-off-by: Daniel P. Berrangé
Patch looks sensible:
Acked-by: Richard W.M. Jones
Would you mind taking a look at nbdkit-ssh-plugin? This is arguably
more important (for Red Hat) since we no long
0.8 from Git, and those snapshots did not
> -# have updated version numbers (still referring to 0.7.0).
> -
> -if test "$libssh" = "yes"; then
> - cat > $TMPC < -#include
> -int main(void) { return ssh_get_server_publickey(NULL, NULL); }
> -EOF
> -
_listen().
> > >>
> > >> Drop the num argument from socket_get_fd() since this function is also
> > >> called by socket_connect() where a listen backlog value does not make
> > >> sense.
> > >>
> > >>
_listen().
> > >>
> > >> Drop the num argument from socket_get_fd() since this function is also
> > >> called by socket_connect() where a listen backlog value does not make
> > >> sense.
> > >>
> > >>
On Thu, Apr 29, 2021 at 04:08:22PM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 29, 2021 at 04:00:38PM +0100, Richard W.M. Jones wrote:
> > On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote:
> > > On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wrot
On Thu, Apr 29, 2021 at 04:08:22PM +0100, Daniel P. Berrangé wrote:
> On Thu, Apr 29, 2021 at 04:00:38PM +0100, Richard W.M. Jones wrote:
> > On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote:
> > > On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wro
On Thu, Apr 29, 2021 at 03:41:29PM +0100, Stefan Hajnoczi wrote:
> On Thu, Apr 29, 2021 at 03:22:59PM +0100, Richard W.M. Jones wrote:
> > On Thu, Apr 29, 2021 at 03:05:50PM +0100, Stefan Hajnoczi wrote:
> > > The purpose of this preview release is to discuss both the API design
On Thu, Apr 29, 2021 at 03:05:50PM +0100, Stefan Hajnoczi wrote:
> The purpose of this preview release is to discuss both the API design
> and general direction of the project. API documentation is available
> here:
>
> https://gitlab.com/libblkio/libblkio/-/blob/v0.1.0/docs/blkio.rst
libvirt
; called by socket_connect() where a listen backlog value does not make
> sense.
>
> Fixes: e5b6353cf25c99c3f08bf51e29933352f7140e8f ("socket: Add backlog
> parameter to socket_listen")
> Reported-by: Richard W.M. Jones
> Cc: Juan Quintela
> Cc: Eric Blake
> Signed-o
from launching for a given pid file.
>
> QEMU, qemu-nbd, qemu-ga, virtiofsd, and qemu-pr-helper all support the
> --pidfile option. Add it to qemu-storage-daemon too.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Stefan Hajnoczi
> ---
> v3:
> * Add --pidfile
from launching for a given pid file.
>
> QEMU, qemu-nbd, qemu-ga, virtiofsd, and qemu-pr-helper all support the
> --pidfile option. Add it to qemu-storage-daemon too.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Stefan Hajnoczi
> ---
> v2:
> * Add docum
For the series:
Reviewed-by: Richard W.M. Jones
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows
gt;
> > The pid file also acts as a lock to prevent multiple instances of the
> > daemon from launching for a given pid file.
> >
> > QEMU, qemu-nbd, qemu-ga, virtiofsd, and qemu-pr-helper all support the
> > --pidfile option. Add it to qemu-storage-daemon too.
>
iting, which may delay startup due to arbitrary sleep() calls.
>
> This Python example is inspired by the test case written for libnbd by
> Richard W.M. Jones :
> https://gitlab.com/nbdkit/libnbd/-/commit/89113f484effb0e6c322314ba75c1cbe07a04543
>
> Thanks to Daniel P. Berr
On Fri, Feb 19, 2021 at 02:31:20PM +0100, Philippe Mathieu-Daudé wrote:
> Hi Peter,
>
> [+John/Richards/Paolo/Gueunter]
>
> On 2/18/21 3:22 PM, Peter Maydell wrote:
> > On Thu, 18 Feb 2021 at 14:07, Bin Meng wrote:
> >> On Thu, Feb 18, 2021 at 9:26 PM Peter Maydell
> >> wrote:
> >>> Fails to
where
> our low backlog prevents libnbd from connecting as many parallel
> clients as it wants.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Eric Blake
> CC: qemu-sta...@nongnu.org
> ---
> blockdev-nbd.c | 7 ++-
> qemu-nbd.c | 10 +-
> 2 fil
bugzilla.redhat.com/1925045 for a demonstration of where
> our low backlog prevents libnbd from connecting as many parallel
> clients as it wants.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Eric Blake
> ---
>
> v2: target the correct API used by qemu-nbd, rather than an un
On Thu, Feb 04, 2021 at 02:44:03PM -0600, Eric Blake wrote:
> On 2/4/21 2:09 PM, Peter Lieven wrote:
> > Am 02.02.21 um 16:51 schrieb Eric Blake:
> >> On 1/28/21 8:07 AM, Peter Lieven wrote:
> >>> Signed-off-by: Peter Lieven
> >> Your commit message says 'what', but not 'why'. Generally, the
On Thu, Feb 04, 2021 at 01:07:08PM -0600, Eric Blake wrote:
> The value '1.1k' is inexact; 1126.4 bytes is not possible, so we
> happen to truncate it to 1126. Our use of fractional sizes is
> intended for convenience, but when a user specifies a fraction that is
> not a clean translation to
On Fri, Feb 05, 2021 at 01:25:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 04.02.2021 22:07, Eric Blake wrote:
> >Supporting '0x20M' looks odd, particularly since we have an 'E' suffix
>
> What about also deprecating 'E' suffix? (just my problem of reviewing
> previous patch)
Ha! What if
On Thu, Feb 04, 2021 at 01:07:06PM -0600, Eric Blake wrote:
> We have multiple clients of qemu_strtosz (qemu-io, the opts visitor,
> the keyval visitor), and it gets annoying that edge-case testing is
> impacted by implicit rounding to 53 bits of precision due to parsing
> with strtod(). As an
retrying.
>
> See https://bugzilla.redhat.com/1925045 for a demonstration of where
> our low backlog prevents libnbd from connecting as many parallel
> clients as it wants.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Eric Blake
> ---
> util/qemu-sockets.c | 2 +-
> 1
sing through the
> intermediate type and back to the desired common type (all at
> one expression).
>
> Fixes: a534bb15f30 ("tcg/s390: Use constant pool for cmpi")
> Reported-by: Miroslav Rezanina
> Reported-by: Richard W.M. Jones
> Suggested-by: David Hildenbrand
On Thu, Feb 04, 2021 at 05:04:22PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/4/21 10:37 AM, David Hildenbrand wrote:
> > On 04.02.21 10:29, Richard W.M. Jones wrote:
> >>>> commit 8f17a975e60b773d7c366a81c0d9bbe304f30859
> >>>> Author: Richard Henderson
I have this s390 machine for another 99 hours now, so if you want me
to test patches then send them my way.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit
> > commit 8f17a975e60b773d7c366a81c0d9bbe304f30859
> > Author: Richard Henderson
> > Date: Mon Mar 30 19:52:02 2020 -0700
> >
> > tcg/optimize: Adjust TempOptInfo allocation
> >
> > The image boots just fine on s390x/TCG as well.
>
> Let me try this in a minute on my original test
On Thu, Feb 04, 2021 at 09:38:45AM +0100, David Hildenbrand wrote:
> On 04.02.21 08:55, David Hildenbrand wrote:
> >On 04.02.21 07:41, David Hildenbrand wrote:
> >>
> >>>Am 04.02.2021 um 03:22 schrieb Richard Henderson
> >>>:
> >>&
On Mon, Feb 01, 2021 at 08:45:47PM +, Richard W.M. Jones wrote:
> This commit breaks running certain s390x binaries, at least
> the "mount" command (or a library it uses) breaks.
>
> More details in this BZ:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=
This commit breaks running certain s390x binaries, at least
the "mount" command (or a library it uses) breaks.
More details in this BZ:
https://bugzilla.redhat.com/show_bug.cgi?id=1922248
Could we revert this change since it seems to have caused other
problems as well?
Rich.
--
Richard
On Fri, Jan 08, 2021 at 01:51:35PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 07.01.2021 12:58, Richard W.M. Jones wrote:
> >On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> >>Finally to be safe with calculations, to not calculate diff
On Thu, Jan 07, 2021 at 10:56:12AM +, Richard W.M. Jones wrote:
> On Thu, Jan 07, 2021 at 09:58:17AM +0000, Richard W.M. Jones wrote:
> > On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Finally to be safe with calculations, to
On Thu, Jan 07, 2021 at 09:58:17AM +, Richard W.M. Jones wrote:
> On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Finally to be safe with calculations, to not calculate different
> > maximums for different nodes (depending
On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Finally to be safe with calculations, to not calculate different
> maximums for different nodes (depending on cluster size and
> request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30)
> as absolute
On Wed, Nov 25, 2020 at 02:27:11PM +0100, Antoine Damhet wrote:
> Hello,
>
> We recently found out that some softwares are effectively crashing
> when they detect qemu's `OEM ID` or `OEM table ID` in the ACPI tables.
>
> I see no reason not to expose the setting to the user/command-line. A
>
On Tue, Oct 27, 2020 at 10:33:48AM -0500, Eric Blake wrote:
> On 10/16/20 10:23 AM, Eric Blake wrote:
> > A rather trivial decoding; we may enhance it further if qemu extends
> > things to give an integer depth alongside its tri-state encoding.
> > ---
> >
> > I'll wait to push this to libnbd
On Tue, Oct 20, 2020 at 09:32:23AM -0500, Eric Blake wrote:
> On 10/20/20 9:22 AM, Wang, Wei W wrote:
> > On Tuesday, October 20, 2020 4:01 PM, Kevin Wolf wrote:
> >> Am 20.10.2020 um 03:31 hat Wang, Wei W geschrieben:
> >>> Hi,
> >>>
> >>> Does anyone know the reason why raw-format.c doesn't have
On Fri, Oct 09, 2020 at 10:10:18AM +0200, Markus Armbruster wrote:
> Eric Blake writes:
>
> > Allow the server to expose an additional metacontext to be requested
> > by savvy clients. qemu-nbd adds a new option -A to expose the
> > qemu:allocation-depth metacontext through
On Wed, Sep 30, 2020 at 09:49:00AM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 30, 2020 at 09:40:59AM +0100, Richard W.M. Jones wrote:
> > I understand that QSD is at an early stage of development and I'm sure
> > you have plans to fix these things. Nevertheless here are my com
I understand that QSD is at an early stage of development and I'm sure
you have plans to fix these things. Nevertheless here are my comments
after trying to add an interop test with libnbd.
(1) Documentation! (Or complete lack of it ...) I had to ask Kevin
how to construct the command line
On Mon, Sep 28, 2020 at 09:33:22AM -0500, Eric Blake wrote:
> On 9/26/20 2:33 AM, Richard W.M. Jones wrote:
> >On Fri, Sep 25, 2020 at 03:32:48PM -0500, Eric Blake wrote:
> >>+The second is related to exposing the source of various extents within
> >>+the image,
---
info/nbdinfo.c | 132 ---
info/nbdinfo.pod | 39 +-
2 files changed, 164 insertions(+), 7 deletions(-)
diff --git a/info/nbdinfo.c b/info/nbdinfo.c
index 647a24c..d1648b8 100644
--- a/info/nbdinfo.c
+++ b/info/nbdinfo.c
@@ -34,6
This is a rough-and-ready implementation of nbdinfo --map option, to
display the allocation and other metadata of NBD exports. I only
tested it lightly against nbdkit. It needs at least some tests.
Command like these should work:
nbdinfo --map nbd://localhost
nbdinfo --map=qemu:dirty-bitmap
On Fri, Sep 25, 2020 at 03:32:49PM -0500, Eric Blake wrote:
> Allow the server to expose an additional metacontext to be requested
> by savvy clients. qemu-nbd adds a new option -A to expose the
> qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this
> can also be set via QMP when
On Fri, Sep 25, 2020 at 03:32:48PM -0500, Eric Blake wrote:
> +The second is related to exposing the source of various extents within
> +the image, with a single context named:
> +
> +qemu:allocation-depth
> +
> +In the allocation depth context, bits 0 and 1 form a tri-state value:
> +
> +
On Mon, Sep 21, 2020 at 02:54:15PM +0200, Peter Krempa wrote:
> On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote:
> > Some general comments on using the patch:
> >
> > * For libguestfs I chose to add
> >
> > -compat deprecated-in
supported.
http://fedoraproject.org/wiki/MinGW
>From 90df6dc8a3278800f9f9dc23f626df5fa00b5950 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones"
Date: Mon, 21 Sep 2020 13:18:05 +0100
Subject: [PATCH] lib: direct: Pass qemu -compat to detect deprecated features.
In developer versions of li
On Mon, Sep 14, 2020 at 10:08:50AM -0500, Eric Blake wrote:
> On 9/14/20 3:47 AM, Markus Armbruster wrote:
> >Policy is separate for input and output.
> >
> >Input policy can be "accept" (accept silently), or "reject" (reject
> >the request with an error).
> >
> >Output policy can be "accept"
./configure".
Honggfuzz can be used as another external fuzzing option.
Fix compilation with glibc 2.32 which deprecates "sys_errlist".
Many examples added or extended to demonstrate uses of the new APIs
(Eric Blake).
SEE ALSO
libnbd(3).
AU
is a good idea because I would
normally associate that with getting the version of a command. But
as these are subcommand flags, that's probably not too relevant here.
So I think this is fine from my point of view.
Rich.
> Signed-off-by: Denis V. Lunev
> CC: Andrey Shinkevich
> CC: Vladim
On Thu, Jul 09, 2020 at 11:42:26PM +0400, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> block/ssh.c | 23 +++
> 1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/block/ssh.c b/block/ssh.c
> index 098dbe03c15..c8f6ad79e3c 100644
> ---
On Thu, Jul 09, 2020 at 11:42:34PM +0400, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> block/ssh.c | 75 +
> 1 file changed, 58 insertions(+), 17 deletions(-)
>
> diff --git a/block/ssh.c b/block/ssh.c
> index
On Fri, May 29, 2020 at 09:08:29PM +, Eric Wheeler wrote:
> On Fri, 29 May 2020, Richard W.M. Jones wrote:
> > On Fri, May 29, 2020 at 08:58:06AM -0500, Eric Blake wrote:
> > > On 5/29/20 8:50 AM, Daniel P. Berrangé wrote:
> > >
> > > >>>(2) Y
On Fri, May 29, 2020 at 08:58:06AM -0500, Eric Blake wrote:
> On 5/29/20 8:50 AM, Daniel P. Berrangé wrote:
>
> >>>(2) You need to persuade qemu's NBD client to read from a WebSocket.
> >>>I didn't really know anything about WebSockets until today but it
> >>>seems as if they are a full-duplex
On Wed, May 27, 2020 at 10:42:06AM +0100, Daniel P. Berrangé wrote:
> On Wed, May 27, 2020 at 10:34:09AM +0100, Richard W.M. Jones wrote:
> > According to the gcrypt documentation it's intended that
> > gcry_check_version() is called with the minimum version of gcrypt
> >
rdly
seems we need to check that. So I replaced GCRYPT_VERSION with NULL.
Perhaps in future if we move to requiring a newer version of gcrypt we
could put a literal string here.
Signed-off-by: Richard W.M. Jones
---
crypto/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cr
On Tue, Apr 28, 2020 at 03:29:05PM -0500, Eric Blake wrote:
> Now that there are no clients of bdrv_has_zero_init_truncate, none of
> the drivers need to worry about providing it.
>
> What's more, this eliminates a source of some confusion: a literal
> reading of the documentation as written in
(BlockDriverState *bs, QDict
> *options, int bdrv_flags,
> /* Go non-blocking. */
> ssh_set_blocking(s->session, 0);
>
> +if (s->attrs->type == SSH_FILEXFER_TYPE_REGULAR) {
> +bs->supported_truncate_flags = BDRV_REQ_ZERO_WRITE;
> +}
> +
As t
On Thu, Apr 02, 2020 at 08:41:31AM -0500, Eric Blake wrote:
> On 4/2/20 3:38 AM, Richard W.M. Jones wrote:
> >For the case I care about (long running virt-v2v conversions with an
> >intermittent network) we don't expect that nbdkit will be killed nor
> >gracefully shut d
On Wed, Apr 01, 2020 at 05:38:41PM -0500, Eric Blake wrote:
> I was trying to test qemu's reconnect-delay parameter by using nbdkit
> as a server that I could easily make disappear and resume. A bit of
> experimenting shows that when nbdkit is abruptly killed (SIGKILL),
> qemu detects EOF on
On Tue, Feb 11, 2020 at 08:31:01PM -0600, Eric Blake wrote:
> The NBD URI specification [1] states that only one leading slash at
> the beginning of the URI path component is stripped, not all such
> slashes. This becomes important to a patch I just proposed to nbdkit
> [2], which would allow the
On Wed, Feb 12, 2020 at 06:09:11AM -0600, Eric Blake wrote:
> On 2/12/20 1:27 AM, Wouter Verhelst wrote:
> >Hi,
> >
> >On Mon, Feb 10, 2020 at 10:52:55PM +0000, Richard W.M. Jones wrote:
> >>But anyway ... could a flag indicating that the whole image is sparse
On Mon, Feb 10, 2020 at 04:29:53PM -0600, Eric Blake wrote:
> On 2/10/20 4:12 PM, Richard W.M. Jones wrote:
> >On Mon, Feb 10, 2020 at 03:37:20PM -0600, Eric Blake wrote:
> >>For now, only 2 of those 16 bits are defined: NBD_INIT_SPARSE (the
> >>image has at least
On Mon, Feb 10, 2020 at 03:37:20PM -0600, Eric Blake wrote:
> For now, only 2 of those 16 bits are defined: NBD_INIT_SPARSE (the
> image has at least one hole) and NBD_INIT_ZERO (the image reads
> completely as zero); the two bits are orthogonal and can be set
> independently, although it is easy
On Mon, Feb 10, 2020 at 04:15:40PM +0200, Nikolay Ivanets wrote:
> пн, 10 лют. 2020 о 15:48 Kevin Wolf пише:
> >
> > Am 10.02.2020 um 12:43 hat Richard W.M. Jones geschrieben:
> > > On Sat, Feb 08, 2020 at 01:25:28AM +0200, Mykola Ivanets wrote:
> > > > From
On Mon, Feb 10, 2020 at 02:28:08PM +0200, Nikolay Ivanets wrote:
> пн, 10 лют. 2020 о 13:43 Richard W.M. Jones пише:
> >
> > On Sat, Feb 08, 2020 at 01:25:28AM +0200, Mykola Ivanets wrote:
> > > From: Nikolay Ivanets
> > >
> > > I faced with situation wh
On Sat, Feb 08, 2020 at 01:25:28AM +0200, Mykola Ivanets wrote:
> From: Nikolay Ivanets
>
> I faced with situation where libguestfs cannot recognize partitions on a
> disk image which was partitioned on a system with "4K native" sector
> size support.
Do you have a small test case for this?
>
On Fri, Jan 24, 2020 at 09:55:55AM +, Richard W.M. Jones wrote:
> On Thu, Jan 23, 2020 at 01:21:28PM -0600, Eric Blake wrote:
> > Could we also teach this to parse 'qemu-img map --output=json'
> > format? And/or add 'qemu-img map --output=XYZ' (different from the
> > c
On Thu, Jan 23, 2020 at 01:21:28PM -0600, Eric Blake wrote:
> On 1/23/20 12:35 PM, Richard W.M. Jones wrote:
> > - Hint that the target already contains zeroes. It's almost always
> >the case that we know this, but we cannot tell qemu. This was the
> >cause
On Thu, Jan 23, 2020 at 07:53:57PM +0100, Max Reitz wrote:
> On 23.01.20 19:35, Richard W.M. Jones wrote:
> > - NBD multi-conn. In my tests this makes a really massive
> >performance difference in certain situations. Again, virt-v2v has
> >a lot of informatio
101 - 200 of 1226 matches
Mail list logo
