Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-07-03 Thread Robert Hoo
On Tue, 2018-07-03 at 11:06 +0200, Paolo Bonzini wrote: > On 03/07/2018 10:48, Robert Hoo wrote: > >> > >> However, I suggest adding it to the FeatureWord enum, since everything > >> that handles FeatureWord applies to this new kind of MSR as well. > >>

Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-07-03 Thread Robert Hoo
On Thu, 2018-06-28 at 16:20 +0200, Paolo Bonzini wrote: > On 28/06/2018 11:25, Robert Hoo wrote: > >>> +uint64_t pred_cmd; > >>> +uint64_t arch_capabilities; > >> What's the purpose of those CPUX86State fields, if the migration > >> section

Re: [Qemu-devel] [PATCH v2 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-07-03 Thread Robert Hoo
On Thu, 2018-06-28 at 15:28 -0300, Eduardo Habkost wrote: > On Wed, Jun 27, 2018 at 07:27:21PM +0800, Robert Hoo wrote: > > Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as > > SPEC_CTRL. > > > > Signed-off-by: Robert Hoo > > Based on kern

Re: [Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-06-28 Thread Robert Hoo
On Wed, 2018-06-27 at 14:03 -0300, Eduardo Habkost wrote: > On Wed, Jun 27, 2018 at 07:27:20PM +0800, Robert Hoo wrote: > > IA32_PRED_CMD MSR gives software a way to issue commands that affect the > > state > > of indirect branch predictors. Enumerated by CPUID.

[Qemu-devel] [PATCH v2 0/5] Add Icelake CPU model

2018-06-27 Thread Robert Hoo
. Changelog: v2 Per Paolo's comment, remove unnecessary CPU vmstate check for write/read only IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs. Robert Hoo (5): i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES

[Qemu-devel] [PATCH v2 5/5] i386: Add new CPU model Icelake-{Server, Client}

2018-06-27 Thread Robert Hoo
Signed-off-by: Robert Hoo --- target/i386/cpu.c | 116 ++ 1 file changed, 116 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 92bfbbc..ff3273a 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2382,6 +2382,122

[Qemu-devel] [PATCH v2 3/5] i386: Add CPUID bit for PCONFIG

2018-06-27 Thread Robert Hoo
PCONFIG: Platform configuration, enumerated by CPUID.(EAX=07H, ECX=0): EDX[bit18]. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 953098c..c2c3cdb 100644

[Qemu-devel] [PATCH v2 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-06-27 Thread Robert Hoo
://software.intel.com/sites/default/files/managed/c5/63/336996-Speculative-Execution-Side-Channel-Mitigations.pdf Signed-off-by: Robert Hoo --- target/i386/cpu.h | 4 target/i386/kvm.c | 27 ++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/target/i386

[Qemu-devel] [PATCH v2 4/5] i386: Add CPUID bit for WBNOINVD

2018-06-27 Thread Robert Hoo
WBNOINVD: Write back and do not invalidate cache, enumerated by CPUID.(EAX=8008H, ECX=0):EBX[bit 9]. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index

[Qemu-devel] [PATCH v2 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-06-27 Thread Robert Hoo
Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as SPEC_CTRL. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index e6c2f8a..953098c 100644

Re: [Qemu-devel] [PATCH 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-06-26 Thread Robert Hoo
On Mon, 2018-06-25 at 14:06 +0200, Paolo Bonzini wrote: > On 25/06/2018 05:39, Robert Hoo wrote: > > Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as > > SPEC_CTRL. > > > > Signed-off-by: Robert Hoo > > --- > > target/i386/cpu.c | 2

Re: [Qemu-devel] [PATCH 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-06-26 Thread Robert Hoo
On Mon, 2018-06-25 at 13:51 +0200, Paolo Bonzini wrote: > On 25/06/2018 05:39, Robert Hoo wrote: > > IA32_PRED_CMD MSR gives software a way to issue commands that affect the > > state > > of indirect branch predictors. Enumerated by CPUID.(EAX=7H,ECX=0):EDX[26]. > >

[Qemu-devel] [PATCH 5/5] i386: Add new CPU model Icelake-{Server, Client}

2018-06-24 Thread Robert Hoo
Signed-off-by: Robert Hoo --- target/i386/cpu.c | 116 ++ 1 file changed, 116 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 821b7bd..2613e1a 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2276,6 +2276,122

[Qemu-devel] [PATCH 4/5] i386: Add CPUID bit for WBNOINVD

2018-06-24 Thread Robert Hoo
WBNOINVD: Write back and do not invalidate cache, enumerated by CPUID.(EAX=8008H, ECX=0):EBX[bit 9]. Reference: https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2

[Qemu-devel] [PATCH 3/5] i386: Add CPUID bit for PCONFIG

2018-06-24 Thread Robert Hoo
PCONFIG: Platform configuration, enumerated by CPUID.(EAX=07H, ECX=0): EDX[bit18]. Reference: https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h

[Qemu-devel] [PATCH 2/5] i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR

2018-06-24 Thread Robert Hoo
Support of IA32_PRED_CMD MSR already be enumerated by same CPUID bit as SPEC_CTRL. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 1e69e68..3134af4 100644

[Qemu-devel] [PATCH 0/5] Add Icelake CPU model

2018-06-24 Thread Robert Hoo
. Robert Hoo (5): i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs i386: Add CPUID bit and feature words for IA32_ARCH_CAPABILITIES MSR i386: Add CPUID bit for PCONFIG i386: Add CPUID bit for WBNOINVD i386: Add new CPU model Icelake-{Server,Client} target/i386/cpu.c

[Qemu-devel] [PATCH 1/5] i386: Add support for IA32_PRED_CMD and IA32_ARCH_CAPABILITIES MSRs

2018-06-24 Thread Robert Hoo
://software.intel.com/sites/default/files/managed/c5/63/336996-Speculative-Execution-Side-Channel-Mitigations.pdf Signed-off-by: Robert Hoo --- target/i386/cpu.h | 4 target/i386/kvm.c | 27 ++- target/i386/machine.c | 40 3

<    1   2   3