Re: [PATCH v3] Check and report for incomplete 'global' option format

2022-03-02 Thread Rohit Kumar
Hi Markus, thanks for the review. Please let me know if this patch needs to be rebased on top of current master or does it looks good to merge. Thanks ! On 16/02/22 7:25 pm, Markus Armbruster wrote: Rohit Kumar writes: Qemu might crash when provided incomplete '-global' option. F

[PATCH v3] Check and report for incomplete 'global' option format

2022-02-16 Thread Rohit Kumar
dumped) Fixes: 3751d7c43f795b ("vl: allow full-blown QemuOpts syntax for -global") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/604 Signed-off-by: Rohit Kumar --- diff to v2: - Avoided double reporting of error. - Added the "Fixes" line in the commit message. softmmu

Re: [PATCH v2] Check and report for incomplete 'global' option format

2022-02-15 Thread Rohit Kumar
On 15/02/22 3:00 pm, Markus Armbruster wrote: Rohit Kumar writes: Qemu might crash when provided incomplete '-global' option. For example: qemu-system-x86_64 -global driver=isa-fdc qemu-system-x86_64: ../../devel/qemu/qapi/string-input-vis

[PATCH v2] Check and report for incomplete 'global' option format

2022-02-14 Thread Rohit Kumar
mped) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/604 Signed-off-by: Rohit Kumar --- diff to v1: - Removed '\n' from error log message. softmmu/qdev-monitor.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/softmmu/qdev-monitor.c b/sof

Re: [PATCH v1] Check and report for incomplete 'global' option format

2022-01-24 Thread Rohit Kumar
Ping. Hi, please review this patch. Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg00296.html Thanks ! On 04/01/22 7:11 pm, Rohit Kumar wrote: Qemu might crash when provided incomplete '-global' option. For example: qemu-system-x86_64 -global driv

Re: [PATCH v1] Check and report for incomplete 'global' option format

2022-01-10 Thread Rohit Kumar
Ping. Please take a look at this patch. Link: https://lists.nongnu.org/archive/html/qemu-devel/2022-01/msg00296.html On 04/01/22 7:22 pm, Philippe Mathieu-Daudé wrote: Cc'ing Markus / Thomas On 4/1/22 14:41, Rohit Kumar wrote: Qemu might crash when provided incomplete '-global&#x

[PATCH v1] Check and report for incomplete 'global' option format

2022-01-04 Thread Rohit Kumar
mped) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/604 Signed-off-by: Rohit Kumar --- softmmu/qdev-monitor.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index 01f3834db5..7aee7b9882 100644 --- a/softmmu