[PATCHv2] slirp: Allow non-local DNS address when restrict is off

2019-10-01 Thread Samuel Thibault
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. Buglink: https://bugs.launchpad.net/qemu/+bug/1010484 Signed-off-by: Samuel Thibault --- Difference from first version: - handle DNS IPv6 as well - reference bug with Buglink

[PATCH] slirp: Allow non-local DNS address when restrict is off

2019-10-01 Thread Samuel Thibault
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. Buglink: https://bugs.launchpad.net/qemu/+bug/1010484 Signed-off-by: Samuel Thibault --- net/slirp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net

[PATCH] slirp: Allow non-local DNS address when restrict is off

2019-09-29 Thread Samuel Thibault
This can be used to set a DNS server to be used by the guest which is different from the one configured on the host. This fixes LP 1010484. Signed-off-by: Samuel Thibault --- net/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-09 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le lun. 09 sept. 2019 12:51:23 +0200, a ecrit: > Anyhow, if you plan to properly (with your S-o-b) commit your patch to > the libslirp repository, Actually the libslirp repository already has something there. Since IPv4/6 have a maximum of 64KB packets, it just

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-07 Thread Samuel Thibault
Hello, As usual, several things here. Chris Heinze, le mar. 03 sept. 2019 17:02:15 +0200, a ecrit: > root@guest:~# tcpdump -ni eth0 port 19003 > tcpdump: verbose output suppressed, use -v or -vv for full protocol decode > listening on eth0, link-type EN10MB (Ethernet), capture size 262144 bytes

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-06 Thread Samuel Thibault
Chris Heinze, le ven. 06 sept. 2019 12:54:24 +0200, a ecrit: > i'm not aware of any (canonical) parameters to set a max size for received > packets Ah, right. > i found no way to configure slirp (in qemu) itself except for the DEFINEs in > the if.h. Yes, that's where it is to be configured

Re: [Qemu-devel] slirp, incoming packets get truncated

2019-09-06 Thread Samuel Thibault
Hello, Chris Heinze, le mar. 03 sept. 2019 17:02:15 +0200, a ecrit: > on the guest: > root@guest:~# tcpdump -ni eth0 port 19003 > tcpdump: verbose output suppressed, use -v or -vv for full protocol decode > listening on eth0, link-type EN10MB (Ethernet), capture size 262144 bytes >

[Qemu-devel] [Bug 1837094] Re: UndefinedBehaviorSanitizer crash around slirp::ip_reass()

2019-08-29 Thread Samuel thibault
And https://gitlab.freedesktop.org/slirp/libslirp/commit/d203c81b -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1837094 Title: UndefinedBehaviorSanitizer crash around slirp::ip_reass() Status in

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-25 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le ven. 23 août 2019 17:15:32 +0200, a ecrit: > > Did you make your test with commit 126c04acbabd ("Fix heap overflow in > > ip_reass on big packet input") applied? > > Yes, unfortunately it doesn't fix the issue. Ok. Could you try the attached patch? There was

Re: [Qemu-devel] [Slirp] [PATCH 1/2] Do not reassemble fragments pointing outside of the original payload

2019-08-22 Thread Samuel Thibault
Hello, Philippe Mathieu-Daudé, le jeu. 22 août 2019 16:41:33 +0200, a ecrit: > Later the newly calculated pointer q is converted into ip structure > and values are modified, Due to the wrong calculation of the delta, > ip will be pointing to incorrect location and ip_src and ip_dst can >

Re: [Qemu-devel] [ANNOUNCE] QEMU 4.1.0-rc3 is now available

2019-08-02 Thread Samuel Thibault
Marc-André Lureau, le ven. 02 août 2019 15:07:46 +0400, a ecrit: > And Samuel probably thought the same, since he didn't update the submodule. I'm rather mostly buried under piles of things to do... > According to MAINTAINERS, this is for Samuel to take care of. But I'll > do it if he ask me.

Re: [Qemu-devel] [PATCH] ui/curses: Fix build with -m32

2019-05-27 Thread Samuel Thibault
wchar_t {aka long int} > > Fix this by casting the wchar_t value to an unsigned long and using %lx > as the conversion specifier. > > Fixes: b7b664a4fe9a955338f2e11a0f7433b29c8cbad0 > Signed-off-by: Max Reitz Reviewed-by: Samuel Thibault > --- > ui/curses

[Qemu-devel] [PULL 0/1] Update upstream slirp

2019-05-09 Thread Samuel Thibault
The following changes since commit 30302acee710881cb248ec3391adcd54dcf52396: Update upstream slirp (2019-05-09 09:58:57 +0200) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

[Qemu-devel] [PULL 1/1] Update upstream slirp

2019-05-09 Thread Samuel Thibault
Adds gitignore, README file, and fixes ident protocol parsing. Signed-off-by: Samuel Thibault --- slirp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp b/slirp index 0e79ba4856..f0da672620 16 --- a/slirp +++ b/slirp @@ -1 +1 @@ -Subproject commit

[Qemu-devel] [PULL 1/1] Update slirp submodule

2019-05-04 Thread Samuel Thibault
To fix Windows on ARM. --- slirp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slirp b/slirp index 59a1b1f165..0e79ba4856 16 --- a/slirp +++ b/slirp @@ -1 +1 @@ -Subproject commit 59a1b1f165458c2acb7ff0525b543945f7416225 +Subproject commit

[Qemu-devel] [PULL 0/1] Update slirp submodule

2019-05-04 Thread Samuel Thibault
The following changes since commit 52ec9dcc1ed5609674e7b52198c18207bb193548: Update slirp submodule (2019-05-04 14:38:05 +0200) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

Re: [Qemu-devel] [PATCH v2 1/4] Initial Windows on ARM (AArch64 64-Bit) host support

2019-05-04 Thread Samuel Thibault
Hello, Cao Jiaxi, le mer. 01 mai 2019 02:10:09 +0800, a ecrit: > This series of patches is for initial support of Windows 10 on ARM as a QEMU > host. > Currently only TCG intepreter is working correctly, it crashes when TCG JIT > is enabled. > For now we assume it is built using the clang

[Qemu-devel] [PULL 0/2] slirp: move slirp as git submodule project

2019-05-02 Thread Samuel Thibault
The following changes since commit 8482ff2eb3bb95020eb2f370a9b3ea26511e41df: Merge remote-tracking branch 'remotes/jnsnow/tags/bitmaps-pull-request' into staging (2019-05-02 12:04:51 +0100) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel

[Qemu-devel] [PULL 1/2] build-sys: pass CFLAGS & LDFLAGS to subdir-slirp

2019-05-02 Thread Samuel Thibault
From: Marc-André Lureau CFLAGS/LDFLAGS have debug and sanitizers flags, which should be passed to slirp compilation. Signed-off-by: Marc-André Lureau Message-Id: <20190424110041.8175-2-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- Makefile | 2 +- 1 file chan

[Qemu-devel] [PATCHv4 2/2] ui/curses: manipulate cchar_t with standard curses functions

2019-04-27 Thread Samuel Thibault
The chars/attr fields are curses internals, setcchar and getcchar have to be used instead. Signed-off-by: Samuel Thibault Tested-by: Kamil Rytarowski --- ui/curses.c | 43 +-- 1 file changed, 29 insertions(+), 14 deletions(-) diff --git a/ui/curses.c b

[Qemu-devel] [PATCHv4 0/2] ui/curses: BSD portability fixes

2019-04-27 Thread Samuel Thibault
. Samuel Thibault (2): ui/curses: do not assume wchar_t contains unicode ui/curses: manipulate cchar_t with standard curses functions ui/curses.c | 194 ++-- 1 file changed, 126 insertions(+), 68 deletions(-) -- 2.20.1

[Qemu-devel] [PATCHv4 1/2] ui/curses: do not assume wchar_t contains unicode

2019-04-27 Thread Samuel Thibault
E.g. BSD and Solaris even use locale-specific encoding there. We thus have to go through the native multibyte representation and use mbrtowc/wcrtomb to make a proper conversion. Signed-off-by: Samuel Thibault Tested-by: Kamil Rytarowski --- ui/curses.c | 157

Re: [Qemu-devel] [PATCHv3 1/2] ui/curses: Do not assume wchar_t contains unicode

2019-04-27 Thread Samuel Thibault
Kamil Rytarowski, le sam. 27 avril 2019 19:36:40 +0200, a ecrit: > On 27.04.2019 18:30, Samuel Thibault wrote: > > E.g. BSD and Solaris even use locale-specific encoding there. > > > > We thus have to go through the native multibyte representation and use > > mbt

[Qemu-devel] [PATCHv3 0/2] ui/curses: BSD portability fixes

2019-04-27 Thread Samuel Thibault
BSD needs a few fixes for wide character manipulations. Difference with v1: - Fix unitialized value in error message Difference with v2: - Add cchar_t manipulation fix Samuel Thibault (2): ui/curses: do not assume wchar_t contains unicode ui/curses: manipulate cchar_t with standard curses

[Qemu-devel] [PATCHv3 2/2] ui/curses: manipulate cchar_t with standard curses functions

2019-04-27 Thread Samuel Thibault
The chars/attr fields are curses internals, setcchar and getcchar have to be used instead. Signed-off-by: Samuel Thibault --- ui/curses.c | 43 +-- 1 file changed, 29 insertions(+), 14 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 395f9545e9

[Qemu-devel] [PATCHv3 1/2] ui/curses: Do not assume wchar_t contains unicode

2019-04-27 Thread Samuel Thibault
E.g. BSD and Solaris even use locale-specific encoding there. We thus have to go through the native multibyte representation and use mbtowc/wctomb to make a proper conversion. Signed-off-by: Samuel Thibault --- ui/curses.c | 151 1 file

[Qemu-devel] [PATCH] curses: do not assume wchar_t contains unicode

2019-04-27 Thread Samuel Thibault
E.g. BSD and Solaris even use locale-specific encoding there. We thus have to go through the native multibyte representation and use mbtowc/wctomb to make a proper conversion. Signed-off-by: Samuel Thibault --- ui/curses.c | 151 1 file

[Qemu-devel] [PATCH] curses: Do not assume wchar_t contains unicode

2019-04-27 Thread Samuel Thibault
E.g. BSD and Solaris even use locale-specific encoding there. We thus have to go through the native multibyte representation and use mbtowc/wctomb to make a proper conversion. Signed-off-by: Samuel Thibault --- ui/curses.c | 151 1 file

Re: [Qemu-devel] [PATCH] curses: Do not assume wchar_t contains unicode

2019-04-27 Thread Samuel Thibault
Ah, sorry, I missed putting v2 above and the change summary: I fixed an uninitalized value in an error message. Samuel Samuel Thibault, le sam. 27 avril 2019 17:58:07 +0200, a ecrit: > E.g. BSD and Solaris even use locale-specific encoding there. > > We thus have to go through t

[Qemu-devel] [PATCH] curses: Do not assume wchar_t contains unicode

2019-04-27 Thread Samuel Thibault
E.g. BSD and Solaris even use locale-specific encoding there. We thus have to go through the native multibyte representation and use mbtowc/wctomb to make a proper conversion. Signed-off-by: Samuel Thibault --- ui/curses.c | 151 1 file

[Qemu-devel] [PULL 1/1] slirp: Gcc 9 -O3 fix

2019-04-15 Thread Samuel Thibault
m> Signed-off-by: Samuel Thibault --- slirp/src/socket.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/slirp/src/socket.c b/slirp/src/socket.c index 4a3c935e25..bb752fdcae 100644 --- a/slirp/src/socket.c +++ b/slirp/src/socket.c @@ -171,6 +171,7 @@ int soread(struct socket *so

Re: [Qemu-devel] [PATCH v3] slirp: Gcc 9 -O3 fix

2019-04-15 Thread Samuel Thibault
Dr. David Alan Gilbert (git), le lun. 15 avril 2019 13:17:40 +0100, a ecrit: > From: "Dr. David Alan Gilbert" > > Gcc 9 needs some convincing that sopreprbuf really is going to fill > in iov in the call from soreadbuf, even though the failure case > shouldn't happen. > > Signed-off-by: Dr.

[Qemu-devel] [PULL 0/1] slirp gcc9 build fix

2019-04-15 Thread Samuel Thibault
The following changes since commit afccfc0c4c6134a7bc9da6375996b3b91d291de4: Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging (2019-04-12 17:06:49 +0100) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault

Re: [Qemu-devel] [PATCH v2] slirp: Gcc 9 -O3 fix

2019-04-15 Thread Samuel Thibault
Dr. David Alan Gilbert (git), le lun. 15 avril 2019 13:02:05 +0100, a ecrit: > From: "Dr. David Alan Gilbert" > > Gcc 9 needs some convincing that sopreprbuf really is going to fill > in iov in the call from soreadbuf, even though the failure case > shouldn't happen. > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH] vl: set LC_MESSAGES and LC_CTYPE in main for all code

2019-04-15 Thread Samuel Thibault
> to cope with non-UTF-8 locales fully. > > Signed-off-by: Daniel P. Berrangé Non-utf-8 environments should be rare enough that it will not be a real concern. Acked-by: Samuel Thibault

Re: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix

2019-04-12 Thread Samuel Thibault
Dr. David Alan Gilbert, le ven. 12 avril 2019 16:49:42 +0100, a ecrit: > * Samuel Thibault (samuel.thiba...@gnu.org) wrote: > > Hello, > > > > Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit: > > > 'soread' has the comment: > > > &g

Re: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix

2019-04-11 Thread Samuel Thibault
Hello, Dr. David Alan Gilbert, le lun. 08 avril 2019 09:46:53 +0100, a ecrit: > 'soread' has the comment: > > /* > * No need to check if there's enough room to read. > * soread wouldn't have been called if there weren't > */ > sopreprbuf(so, iov, ); >

Re: [Qemu-devel] [PATCH] slirp: Gcc 9 -O3 fix

2019-04-05 Thread Samuel Thibault
Hello, Dr. David Alan Gilbert (git), le ven. 05 avril 2019 19:46:48 +0100, a ecrit: > From: "Dr. David Alan Gilbert" > > Gcc 9 needs some convincing that sopreprbuf really is going to fill > in iov in the call from soreadbuf, even though the failure case > shouldn't happen; so swing the check

Re: [Qemu-devel] [PATCH v4 0/8] slirp: clarify license of slirp as BSD-3

2019-03-22 Thread Samuel Thibault
Marc-André Lureau, le ven. 22 mars 2019 17:46:12 +0100, a ecrit: > On Fri, Mar 22, 2019 at 5:43 PM Marc-André Lureau > wrote: > > > > Hi, > > > > In order to make slirp a standalone project, the project must have a > > clear license, and be compatible with the GPL or LGPL. > > > > Since commit

Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3

2019-03-16 Thread Samuel Thibault
Eric Blake, le jeu. 14 mars 2019 08:44:06 -0500, a ecrit: > However, while it does not affect compilation, it DOES have legal > ramification; I'd feel a lot better about having R-b on every patch, Sure, I was just asking for the git commit path :) I don't think it's useful to make it go through

Re: [Qemu-devel] [PATCH] curses ui: always initialize all curses_line fields

2019-03-15 Thread Samuel Thibault
Peter Maydell, le ven. 15 mars 2019 10:06:48 +, a ecrit: > > +curses_line[x] = (cchar_t) {}; > > curses_line[x].chars[0] = ch; > > -curses_line[x].chars[1] = 0; > > -curses_line[x].attr = 0; > > } > >

Re: [Qemu-devel] [PATCH] curses ui: always initialize all curses_line fields

2019-03-15 Thread Samuel Thibault
Eric Blake, le ven. 15 mars 2019 08:02:29 -0500, a ecrit: > On 3/15/19 5:06 AM, Peter Maydell wrote: > > On Fri, 15 Mar 2019 at 08:37, Samuel Thibault > > wrote: > >> > >> cchar_t can contain not only attr and chars fields, but also ext_color. > >> Init

[Qemu-devel] [PATCHv2] curses ui: always initialize all curses_line fields

2019-03-15 Thread Samuel Thibault
cchar_t can contain not only attr and chars fields, but also ext_color. Initialize the whole structure to zero instead of enumerating fields. Spotted by Coverity: CID 1399711 Signed-off-by: Samuel Thibault --- ui/curses.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH] curses ui: always initialize all curses_line fields

2019-03-15 Thread Samuel Thibault
cchar_t can contain not only attr and chars fields, but also ext_color. Initialize the whole structure to zero instead of enumerating fields. Spotted by Coverity: CID 1399711 Signed-off-by: Samuel Thibault --- ui/curses.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui

Re: [Qemu-devel] [PATCH] curses ui: add missing iconv_close

2019-03-14 Thread Samuel Thibault
Peter Maydell, le jeu. 14 mars 2019 17:21:54 +, a ecrit: > On Thu, 14 Mar 2019 at 17:20, Samuel Thibault > wrote: > > > > Signed-off-by: Samuel Thibault > > --- > > ui/curses.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

[Qemu-devel] [PATCHv2] curses ui: add missing iconv_close calls

2019-03-14 Thread Samuel Thibault
The iconv_t are opened but never closed. Spotted by Coverity: CID 1399708 Spotted by Coverity: CID 1399709 Spotted by Coverity: CID 1399713 Signed-off-by: Samuel Thibault --- Change since previous version: close all iconv_t, not only ucs_to_wchar_conv. ui/curses.c | 6 ++ 1 file changed

[Qemu-devel] [PATCH] curses ui: add missing iconv_close

2019-03-14 Thread Samuel Thibault
The iconv_t is opened but never closed. Spotted by Coverity: CID 1399708 Spotted by Coverity: CID 1399709 Spotted by Coverity: CID 1399713 Signed-off-by: Samuel Thibault --- ui/curses.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/curses.c b/ui/curses.c index 3a7e8649f3..1f83a15a1c

Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3

2019-03-14 Thread Samuel Thibault
Hello, Should this go through my tree, or perhaps it can be directly pushed to master by Peter since it's no-code-only-copyright changes? Samuel Marc-André Lureau, le jeu. 14 mars 2019 14:10:41 +0100, a ecrit: > In order to make slirp a standalone project, the project must have a > clear

Re: [Qemu-devel] [PULL 0/2] Ui 20190313 patches

2019-03-13 Thread Samuel Thibault
Peter Maydell, le mer. 13 mars 2019 22:20:03 +, a ecrit: > On Wed, 13 Mar 2019 at 07:41, Gerd Hoffmann wrote: > > > > The following changes since commit 377b155bde451d5ac545fbdcdfbf6ca17a4228f5: > > > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > > staging

Re: [Qemu-devel] [PATCH v2 1/4] slirp: relicense GPL files to BSD-3

2019-03-13 Thread Samuel Thibault
Hello, Marc-André Lureau, le mer. 13 mars 2019 18:35:09 +0100, a ecrit: > On Wed, Mar 13, 2019 at 6:32 PM Eric Blake wrote: > > > > On 3/13/19 11:42 AM, Marc-André Lureau wrote: > > > In order to make slirp a standalone project, the project must have a > > > clear license, and be compatible with

[Qemu-devel] [PULL 2/2] configure: remove slirp submodule support that doesn't exist yet

2019-03-13 Thread Samuel Thibault
erministic failures some developers are seeing with QEMU's submodule sync process. Signed-off-by: Daniel P. Berrangé Message-Id: <20190313173157.30504-1-berra...@redhat.com> Reviewed-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- configure | 11 ++- 1 file changed, 2

[Qemu-devel] [PULL 1/1] configure: remove slirp submodule support that doesn't exist yet

2019-03-13 Thread Samuel Thibault
erministic failures some developers are seeing with QEMU's submodule sync process. Signed-off-by: Daniel P. Berrangé Message-Id: <20190313173157.30504-1-berra...@redhat.com> Reviewed-by: Marc-André Lureau Signed-off-by: Samuel Thibault --- configure | 11 ++- 1 file changed, 2

[Qemu-devel] [PULL 1/2] slirp: remove empty state.h

2019-03-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20190313173949.2369-1-marcandre.lur...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Samuel Thibault --- slirp/src/state.c | 1 - slirp/src/state.h | 0 2 files changed, 1 deletion(-) delete mode 100644 sli

Re: [Qemu-devel] [PATCH] slirp: remove empty state.h

2019-03-13 Thread Samuel Thibault
Eric Blake, le mer. 13 mars 2019 13:21:23 -0500, a ecrit: > On 3/13/19 12:39 PM, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > slirp/src/state.h | 0 > > slirp/src/state.c | 1 - > > 2 files changed, 1 deletion(-) > > delete mode 100644 slirp/src/state.h > > Made

[Qemu-devel] [PULL 0/2] Slirp updates

2019-03-13 Thread Samuel Thibault
The following changes since commit cd82b1e170019c4b722ed53116ee9346315d7791: slirp: remove empty state.h (2019-03-13 22:12:23 +0100) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

[Qemu-devel] [PULL 0/1] slirp update

2019-03-13 Thread Samuel Thibault
The following changes since commit cd82b1e170019c4b722ed53116ee9346315d7791: slirp: remove empty state.h (2019-03-13 22:12:23 +0100) are available in the Git repository at: https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

Re: [Qemu-devel] [PULL 0/1] slirp update

2019-03-13 Thread Samuel Thibault
Samuel Thibault, le mer. 13 mars 2019 22:14:42 +0100, a ecrit: > The following changes since commit cd82b1e170019c4b722ed53116ee9346315d7791: > > slirp: remove empty state.h (2019-03-13 22:12:23 +0100) Oops, sorry, there was another patch to commit, you can ignore this pull request. Samuel

[Qemu-devel] [PULL 1/1] slirp: remove empty state.h

2019-03-13 Thread Samuel Thibault
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20190313173949.2369-1-marcandre.lur...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Samuel Thibault --- slirp/src/state.c | 1 - slirp/src/state.h | 0 2 files changed, 1 deletion(-) delete mode 100644 sli

Re: [Qemu-devel] [PULL 3/5] contrib: gitdm: add more individual contributors

2019-03-12 Thread Samuel Thibault
e moved them to individuals as requested. > > Cc: Fredrik Noring > Cc: Samuel Thibault > Cc: Aurelien Jarno > Cc: BALATON Zoltan > Signed-off-by: Alex Bennée > Acked-by: Richard Henderson Acked-by: Samuel Thibault Thanks! > > diff --git a/contrib/gitdm/group-map-i

Re: [Qemu-devel] [libvirt] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Samuel Thibault
Samuel Thibault, le lun. 11 mars 2019 15:08:16 +0100, a ecrit: > Daniel P. Berrangé, le lun. 11 mars 2019 13:51:16 +, a ecrit: > > On Mon, Mar 11, 2019 at 01:45:13PM +, Peter Maydell wrote: > > > On Mon, 11 Mar 2019 at 08:40, Gerd Hoffmann wrote: > > > >

Re: [Qemu-devel] [libvirt] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Samuel Thibault
Daniel P. Berrangé, le lun. 11 mars 2019 13:51:16 +, a ecrit: > On Mon, Mar 11, 2019 at 01:45:13PM +, Peter Maydell wrote: > > On Mon, 11 Mar 2019 at 08:40, Gerd Hoffmann wrote: > > > > > > The following changes since commit > > > e2a18635a400b0e68679614132e9ef6316105590: > > > > > >

[Qemu-devel] [PATCHv3 0/2] curses: Add support for wide output

2019-03-11 Thread Samuel Thibault
Hello, This adds support for wide output in the curses frontend Difference with previous version: - detect iconv from /usr/local before from /usr, in case a libiconv version is there in addition to the system-provided in /usr Samuel Thibault (2): iconv: detect and make curses depend

[Qemu-devel] [PATCHv3 2/2] curses: add option to specify VGA font encoding

2019-03-11 Thread Samuel Thibault
font. This also makes the curses backend set the LC_CTYPE locale to "" to allow curses to emit wide characters. Signed-off-by: Samuel Thibault Cc: Eddie Kohler Acked-by: Markus Armbruster --- configure | 5 +- qapi/ui.json| 14 +++ qemu-options.hx | 5 +- ui/curses.c

[Qemu-devel] [PATCHv3 1/2] iconv: detect and make curses depend on it

2019-03-11 Thread Samuel Thibault
curses will use it for proper wide output support. Signed-off-by: Samuel Thibault --- configure| 55 ui/Makefile.objs | 4 ++-- vl.c | 2 +- 3 files changed, 58 insertions(+), 3 deletions(-) diff --git a/configure b

Re: [Qemu-devel] [PULL 0/7] Ui 20190307 patches

2019-03-11 Thread Samuel Thibault
Gerd Hoffmann, le lun. 11 mars 2019 09:33:40 +0100, a ecrit: > > > curses: better wide char support. > > > vnc: acl update, stall fix. > > > Hi; this fails to build on FreeBSD; linking the qemu-system-* > > binaries fails with: > > > > /usr/bin/ld: undefined reference to symbol `libiconv_open'

Re: [Qemu-devel] [PATCHv2 0/2] curses: Add support for wide output

2019-03-07 Thread Samuel Thibault
Gerd Hoffmann, le jeu. 07 mars 2019 14:21:12 +0100, a ecrit: > On Mon, Mar 04, 2019 at 10:02:15PM +0100, Samuel Thibault wrote: > > This adds support for wide output in the curses frontend > > > > Difference with previous version: > > - Add more rationale in commit

Re: [Qemu-devel] [PULL 00/12] slirp updates

2019-03-07 Thread Samuel Thibault
Peter Maydell, le jeu. 07 mars 2019 11:27:38 +, a ecrit: > Hi; this fails to build on FreeBSD, I'm afraid: > > /var/tmp/qemu-test.Sn5gQz/slirp/src/libslirp.h:29:19: warning: type > specifier missing, defaults to 'int' [-Wimplicit-int] > typedef ssize_t (*SlirpReadCb)(void *buf, size_t len,

[Qemu-devel] [PULLv2 07/12] slirp: use libslirp migration code

2019-03-07 Thread Samuel Thibault
4-3-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- include/migration/qemu-file-types.h | 2 ++ migration/qemu-file.h | 1 - net/slirp.c | 55 + slirp/libslirp.h| 8 + slirp/s

[Qemu-devel] [PULLv2 10/12] slirp: add a standalone Makefile

2019-03-07 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/Makefile | 47 +++ 1 file changed, 47 insertions(+) create mode 100644 slirp/Makefile diff --git a/slirp/Makefile b/slirp/Makefile new file mode 100644 index 00..6d48f626ba --- /dev/null +++ b/slirp/Ma

[Qemu-devel] [PULLv2 05/12] slirp: Mark pieces missing IPv6 support

2019-03-07 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- net/slirp.c | 1 + slirp/misc.c | 3 +++ slirp/slirp.c | 5 + slirp/socket.c| 1 + slirp/tcp_input.c | 2 ++ slirp/tcp_subr.c | 2 ++ slirp/udp.c | 1 + 7 files changed, 15 insertions(+) diff --git a/net/slirp.c b/net/slirp.c

[Qemu-devel] [PULLv2 06/12] slirp: adapt a subset of QEMU vmstate code

2019-03-07 Thread Samuel Thibault
lur...@redhat.com> Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 2 + slirp/libslirp.h| 2 + slirp/stream.c | 119 + slirp/stream.h | 34 slirp/vmstate.c | 413 slirp/vmstate.h

[Qemu-devel] [PULLv2 09/12] slirp: move sources to src/ subdirectory

2019-03-07 Thread Samuel Thibault
From: Marc-André Lureau Prepare for making slirp/ a standalone project. Remove some useless includes while at it. Signed-off-by: Marc-André Lureau Message-Id: <20190212162524.31504-5-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- net/slirp.c | 2 +-

[Qemu-devel] [PULLv2 03/12] slirp: check sscanf result when emulating ident

2019-03-07 Thread Samuel Thibault
: secal...@redhat.com Message-Id: <1551476756-25749-1-git-send-email-w...@wbowling.info> Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- slirp/tcp_subr.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c

[Qemu-devel] [PULLv2 11/12] build-sys: link with slirp as an external project

2019-03-07 Thread Samuel Thibault
dre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- Makefile | 8 +++--- Makefile.objs | 1 - Makefile.target| 5 +--- configure | 65 +++--- net/Makefile.objs | 2 ++ net/slirp.c| 2 +- util/Makefile.objs | 1 + 7

[Qemu-devel] [PULLv2 12/12] slirp: remove QEMU Makefile.objs

2019-03-07 Thread Samuel Thibault
From: Marc-André Lureau QEMU no longer includes it, and treats slirp/ as a separate project. Signed-off-by: Marc-André Lureau Message-Id: <20190212162524.31504-8-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 36 -

[Qemu-devel] [PULLv2 00/12] slirp updates

2019-03-07 Thread Samuel Thibault
/samuel-thibault for you to fetch changes up to be1911ff7504be95d5cf2c18bc99ce07246a91e5: slirp: remove QEMU Makefile.objs (2019-03-07 12:46:31 +0100) Slirp updates Greg Kurz (1): slirp: Fix build with gcc 9 Marc-André Lureau (7

[Qemu-devel] [PULLv2 01/12] slirp: Fix build with gcc 9

2019-03-07 Thread Samuel Thibault
struct layout. It doesn't need to be packed actually. Just drop SLIRP_PACKED. Signed-off-by: Greg Kurz Message-Id: <155143315831.102868.17515265400523392682.st...@bahia.lan> Reviewed-by: Peter Maydell Signed-off-by: Samuel Thibault --- slirp/slirp.h | 2 +- 1 file changed, 1 insertion(+)

[Qemu-devel] [PULLv2 08/12] slirp: use "slirp_" prefix for inet_aton() win32 implementation

2019-03-07 Thread Samuel Thibault
62524.31504-4-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 2 +- slirp/util.c| 4 ++-- slirp/util.h| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/slirp/Makefile.objs b/slirp/Makefile.objs index 69e140f965..e91daf0e91 10

[Qemu-devel] [PULLv2 1/1] slirp: remove QEMU Makefile.objs

2019-03-07 Thread Samuel Thibault
From: Marc-André Lureau QEMU no longer includes it, and treats slirp/ as a separate project. Signed-off-by: Marc-André Lureau Message-Id: <20190212162524.31504-8-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 36 -

[Qemu-devel] [PULLv2 04/12] slirp: fix big/little endian conversion in ident protocol

2019-03-07 Thread Samuel Thibault
Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- Based-on: <1551476756-25749-1-git-send-email-w...@wbowling.info> --- slirp/tcp_subr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index ef9d99c154..1d7e

[Qemu-devel] [PULLv2 02/12] slirp: check for ioctlsocket error and 0-length udp payload.

2019-03-07 Thread Samuel Thibault
: <20190301064809.3074-1-llyzs@gmail.com> Signed-off-by: Samuel Thibault --- slirp/socket.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/slirp/socket.c b/slirp/socket.c index 4876ea3f31..4dc5e2907d 100644 --- a/slirp/socket.c +++ b/slirp/socket.c @@ -529,6 +

[Qemu-devel] [PULL 07/12] slirp: use libslirp migration code

2019-03-06 Thread Samuel Thibault
4-3-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- include/migration/qemu-file-types.h | 2 ++ migration/qemu-file.h | 1 - net/slirp.c | 55 + slirp/libslirp.h| 8 + slirp/s

[Qemu-devel] [PULL 09/12] slirp: move sources to src/ subdirectory

2019-03-06 Thread Samuel Thibault
From: Marc-André Lureau Prepare for making slirp/ a standalone project. Remove some useless includes while at it. Signed-off-by: Marc-André Lureau Message-Id: <20190212162524.31504-5-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- net/slirp.c | 2 +-

[Qemu-devel] [PULL 11/12] build-sys: link with slirp as an external project

2019-03-06 Thread Samuel Thibault
dre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- Makefile | 8 +++--- Makefile.objs | 1 - Makefile.target| 5 +--- configure | 65 +++--- net/Makefile.objs | 2 ++ net/slirp.c| 2 +- util/Makefile.objs | 1 + 7

[Qemu-devel] [PULL 12/12] slirp: remove QEMU Makefile.objs

2019-03-06 Thread Samuel Thibault
From: Marc-André Lureau QEMU no longer includes it, and treats slirp/ as a separate project. Signed-off-by: Marc-André Lureau Message-Id: <20190212162524.31504-8-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 36 -

[Qemu-devel] [PULL 10/12] slirp: add a standalone Makefile

2019-03-06 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- slirp/Makefile | 47 +++ 1 file changed, 47 insertions(+) create mode 100644 slirp/Makefile diff --git a/slirp/Makefile b/slirp/Makefile new file mode 100644 index 00..6d48f626ba --- /dev/null +++ b/slirp/Ma

[Qemu-devel] [PULL 06/12] slirp: adapt a subset of QEMU vmstate code

2019-03-06 Thread Samuel Thibault
lur...@redhat.com> Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 2 + slirp/libslirp.h| 1 + slirp/stream.c | 119 + slirp/stream.h | 34 slirp/vmstate.c | 413 slirp/vmstate.h

[Qemu-devel] [PULL 03/12] slirp: check sscanf result when emulating ident

2019-03-06 Thread Samuel Thibault
: secal...@redhat.com Message-Id: <1551476756-25749-1-git-send-email-w...@wbowling.info> Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- slirp/tcp_subr.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c

[Qemu-devel] [PULL 00/12] slirp updates

2019-03-06 Thread Samuel Thibault
/samuel-thibault for you to fetch changes up to dd9eff6c839db3996c157f0a6a4e18f95683e58c: slirp: remove QEMU Makefile.objs (2019-03-07 00:12:34 +0100) Slirp updates Greg Kurz (1): slirp: Fix build with gcc 9 Marc-André Lureau (7

[Qemu-devel] [PULL 05/12] slirp: Mark pieces missing IPv6 support

2019-03-06 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- net/slirp.c | 1 + slirp/misc.c | 3 +++ slirp/slirp.c | 5 + slirp/socket.c| 1 + slirp/tcp_input.c | 2 ++ slirp/tcp_subr.c | 2 ++ slirp/udp.c | 1 + 7 files changed, 15 insertions(+) diff --git a/net/slirp.c b/net/slirp.c

[Qemu-devel] [PULL 02/12] slirp: check for ioctlsocket error and 0-length udp payload.

2019-03-06 Thread Samuel Thibault
: <20190301064809.3074-1-llyzs@gmail.com> Signed-off-by: Samuel Thibault --- slirp/socket.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/slirp/socket.c b/slirp/socket.c index 4876ea3f31..4dc5e2907d 100644 --- a/slirp/socket.c +++ b/slirp/socket.c @@ -529,6 +

[Qemu-devel] [PULL 08/12] slirp: use "slirp_" prefix for inet_aton() win32 implementation

2019-03-06 Thread Samuel Thibault
62524.31504-4-marcandre.lur...@redhat.com> Signed-off-by: Samuel Thibault --- slirp/Makefile.objs | 2 +- slirp/util.c| 4 ++-- slirp/util.h| 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/slirp/Makefile.objs b/slirp/Makefile.objs index 69e140f965..e91daf0e91 10

[Qemu-devel] [PULL 04/12] slirp: fix big/little endian conversion in ident protocol

2019-03-06 Thread Samuel Thibault
Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Daudé --- Based-on: <1551476756-25749-1-git-send-email-w...@wbowling.info> --- slirp/tcp_subr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index ef9d99c154..1d7e

[Qemu-devel] [PULL 01/12] slirp: Fix build with gcc 9

2019-03-06 Thread Samuel Thibault
struct layout. It doesn't need to be packed actually. Just drop SLIRP_PACKED. Signed-off-by: Greg Kurz Message-Id: <155143315831.102868.17515265400523392682.st...@bahia.lan> Reviewed-by: Peter Maydell Signed-off-by: Samuel Thibault --- slirp/slirp.h | 2 +- 1 file changed, 1 insertion(+)

Re: [Qemu-devel] [PATCH 0/7] slirp: make it a standalone project

2019-03-06 Thread Samuel Thibault
Applied to my tree, thanks!

[Qemu-devel] [PATCHv2 2/2] curses: add option to specify VGA font encoding

2019-03-04 Thread Samuel Thibault
font. This also makes the curses backend set the LC_CTYPE locale to "" to allow curses to emit wide characters. Signed-off-by: Samuel Thibault Cc: Eddie Kohler --- configure | 5 +- qapi/ui.json| 14 +++ qemu-options.hx | 5 +- ui/curses.c

[Qemu-devel] [PATCHv2 0/2] curses: Add support for wide output

2019-03-04 Thread Samuel Thibault
Hello, This adds support for wide output in the curses frontend Difference with previous version: - Add more rationale in commit message - Move charset option to curses-only section. Samuel Thibault (2): iconv: detect and make curses depend on it curses: add option to specify VGA font

[Qemu-devel] [PATCHv2 1/2] iconv: detect and make curses depend on it

2019-03-04 Thread Samuel Thibault
curses will use it for proper wide output support. Signed-off-by: Samuel Thibault --- configure | 40 vl.c | 2 +- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 540bee19ba..9979ca708d 100755

[Qemu-devel] [PATCH] curses: support wide input

2019-03-04 Thread Samuel Thibault
value is a key code or a character (curses with wide support), or possibly both (curses without wide support). The translation tables thus also need to be separated into key code translation and character translation. The curses2foo helper makes it easier to use them. Signed-off-by: Samuel Thibault

Re: [Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding

2019-03-04 Thread Samuel Thibault
Gerd Hoffmann, le lun. 04 mars 2019 09:03:38 +0100, a ecrit: > On Sun, Mar 03, 2019 at 11:44:30AM +0100, Samuel Thibault wrote: > > This uses iconv to convert glyphs from the specified VGA font encoding to > > unicode, and makes use of cchar_t instead of chtype when using ncur

<    1   2   3   4   5   6   7   8   9   10   >