Hi Zhao,
Thanks for your proposed idea. If you are willing to take the PMU Filter
Enabling work, you can do it. I won't update this series anymore due to
the QAPI restriction. I really appreciate if you can implement that.
Thanks,
Shaoqin
On 5/13/24 14:52, Zhao Liu wrote:
Hi Daniel,
Hi Daniel,
On 4/16/24 01:29, Daniel P. Berrangé wrote:
On Mon, Apr 08, 2024 at 10:49:40PM -0400, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`kvm-pmu-filter` as -cpu sub-option
Hi Thmoas,
On 4/9/24 13:33, Thomas Huth wrote:
+ assert_has_feature(qts, "host", "kvm-pmu-filter");
So you assert here that the feature is available ...
assert_has_feature(qts, "host", "kvm-steal-time");
assert_has_feature(qts, "host", "sve");
resp =
we can see, the cycle counter has been disabled in the guest, but
other pmu events do still work.
Signed-off-by: Shaoqin Huang
---
v8->v9:
- Replace the warn_report to error_setg in some places.
- Merge the check condition to make code more clean.
- Try to use the QAPI format for the PMU Fi
Hi Eric,
On 3/19/24 23:23, Eric Auger wrote:
+if (kvm_supports_pmu_filter) {
+assert_set_feature_str(qts, "host", "kvm-pmu-filter", "");
+assert_set_feature_str(qts, "host", "kvm-pmu-filter",
+ "A:0x11-0x11");
+
Hi Kevin,
On 4/2/24 21:01, Kevin Wolf wrote:
Maybe I'm wrong. So I want to double check with if the -cpu option
support json format nowadays?
As far as I can see, -cpu doesn't support JSON yet. But even if it did,
your command line would be invalid because the 'host,' part isn't JSON.
Hi Daniel,
On 3/25/24 16:55, Daniel P. Berrangé wrote:
On Mon, Mar 25, 2024 at 01:35:58PM +0800, Shaoqin Huang wrote:
Hi Daniel,
Thanks for your reviewing. I see your comments in the v7.
I have some doubts about what you said about the QAPI. Do you want me to
convert the current design
?
Thanks,
Shaoqin
On 3/22/24 22:53, Daniel P. Berrangé wrote:
On Tue, Mar 12, 2024 at 03:48:49AM -0400, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`kvm-pmu-filter` as -cpu sub-option
we can see, the cycle counter has been disabled in the guest, but
other pmu events do still work.
Signed-off-by: Shaoqin Huang
---
v7->v8:
- Add qtest for kvm-pmu-filter.
- Do the kvm-pmu-filter syntax checking up-front in the kvm_pmu_filter_set()
function. And store the filter information a
Hi Peter,
On 2/22/24 22:28, Peter Maydell wrote:
On Wed, 21 Feb 2024 at 06:34, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`kvm-pmu-filter` as -cpu sub-option to set the PMU Event
we can see, the cycle counter has been disabled in the guest, but
other pmu events do still work.
Reviewed-by: Sebastian Ott
Signed-off-by: Shaoqin Huang
---
v6->v7:
- Check return value of sscanf.
- Improve the check condition.
v5->v6:
- Commit message improvement.
- Remove
Hi Eric,
On 2/15/24 17:13, Eric Auger wrote:
Hi Shaoqin,
On 2/1/24 09:51, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`kvm-pmu-filter` as -cpu sub-option to set the PMU Event
we can see, the cycle counter has been disabled in the guest, but
other pmu events do still work.
Reviewed-by: Sebastian Ott
Signed-off-by: Shaoqin Huang
---
v5->v6:
- Commit message improvement.
- Remove some unused code.
- Collect Reviewed-by, thanks Sebastian.
- Use g_auto(Gstr
Hi Eric,
On 1/17/24 20:59, Eric Auger wrote:
Hi Shaoqin,
On 1/15/24 09:01, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`kvm-pmu-filter` as -cpu sub-option to set the PMU Event
Hi Eric,
On 1/17/24 20:59, Eric Auger wrote:
Hi Shaoqin,
On 1/15/24 09:01, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`kvm-pmu-filter` as -cpu sub-option to set the PMU Event
sys
As we can see, the cycle counter has been disabled in the guest, but
other pmu events are still work.
Signed-off-by: Shaoqin Huang
---
v4->v5:
- Change the kvm-pmu-filter as a -cpu sub-option. [Eric]
- Comment tweak. [Gavin]
- Rebase to the lates
As we can see, the cycle counter has been disabled in the guest, but
other pmu events are still work.
Signed-off-by: Shaoqin Huang
---
v3->v4:
- Fix the wrong check for pmu_filter_init.[Sebastian]
- Fix multiple alignment issue. [Gavin]
- Report error by warn_repo
Hi Gavin,
On 12/1/23 13:37, Gavin Shan wrote:
Hi Shaoqin,
On 11/29/23 14:08, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provide the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`pmu-filter` as -accel sub-option to set the PMU Event
On 12/1/23 00:55, Sebastian Ott wrote:
On Tue, 28 Nov 2023, Shaoqin Huang wrote:
+static void kvm_arm_pmu_filter_init(CPUState *cs)
+{
+ static bool pmu_filter_init = false;
+ struct kvm_pmu_event_filter filter;
+ struct kvm_device_attr attr = {
+ .group
As we can see, the cycle counter has been disabled in the guest, but
other pmu events are still work.
Signed-off-by: Shaoqin Huang
---
v2->v3:
- Improve commits message, use kernel doc wording, add more explaination on
filter example, fix some typo error.[Eric]
- Add g_free() in kv
Hi Eric,
On 11/25/23 02:24, Eric Auger wrote:
Hi,
On 11/17/23 07:08, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provide the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`pmu-filter` as -accel sub-option to set the PMU Event Filtering
Hi Eric,
On 11/24/23 18:40, Eric Auger wrote:
Hi Shaoqin,
On 11/17/23 07:08, Shaoqin Huang wrote:
The KVM_ARM_VCPU_PMU_V3_FILTER provide the ability to let the VMM decide
which PMU events are provided to the guest. Add a new option
`pmu-filter` as -accel sub-option to set the PMU Event
event.
Signed-off-by: Salil Mehta
Reviewed-by: Shaoqin Huang
---
docs/specs/acpi_hw_reduced_hotplug.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/specs/acpi_hw_reduced_hotplug.rst
b/docs/specs/acpi_hw_reduced_hotplug.rst
index 0bd3f9399f..3acd6fcd8b 100644
conds time elapsed
0.001752000 seconds user
0.0 seconds sys
As we can see, the cycle counter has been disabled in the guest, but
other pmu events are still work.
Signed-off-by: Shaoqin Huang
---
v1->v2:
- Add more description for allow and deny meaning in
Hi Sebastian,
On 11/15/23 20:17, Sebastian Ott wrote:
Hi,
On Mon, 13 Nov 2023, Shaoqin Huang wrote:
+ ``pmu-filter={A,D}:start-end[;...]``
+ KVM implements pmu event filtering to prevent a guest from
being able to
+ sample certain events. It has the following format:
+
+ pmu
branches
1.002492480 seconds time elapsed
0.001752000 seconds user
0.0 seconds sys
As we can see, the cycle counter has been disabled in the guest, but
other pmu events are still work.
Signed-off-by: Shaoqin Huang
---
include/sysemu/kvm_int.h | 1 +
qemu-option
On 10/19/23 17:34, Salil Mehta wrote:
Hi Shaoqin,
From: Shaoqin Huang
Sent: Thursday, October 19, 2023 10:05 AM
To: Salil Mehta ; qemu-devel@nongnu.org; qemu-
a...@nongnu.org
Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron
; lpieral...@kernel.org;
peter.mayd...@linaro.org
kvm.h | 16 +++
system/physmem.c | 29
15 files changed, 184 insertions(+), 27 deletions(-)
Hi salil,
All patches looks good to me. Thanks for you effort to update it so
actively. No issues being found by simply testing and several daily use.
of CPU hotplug event initialization in the
existing GED framework.
Co-developed-by: Keqian Zhu
Signed-off-by: Keqian Zhu
Signed-off-by: Salil Mehta
Reviewed-by: Jonathan Cameron
Reviewed-by: Gavin Shan
Reviewed-by: David Hildenbrand
Tested-by: Vishnu Pajjuri
Reviewed-by: Shaoqin Huang
in the Host KVM is not destroyed and its
representative KVM vCPU object/context in Qemu is parked.
Refactor common logic so that some APIs could be reused by vCPU Hotplug code.
Signed-off-by: Salil Mehta
Reviewed-by: Gavin Shan
Tested-by: Vishnu Pajjuri
Reviewed-by: Shaoqin Huang
---
accel/kvm
in the Host KVM is not destroyed and its
representative KVM vCPU object/context in Qemu is parked.
Refactor common logic so that some APIs could be reused by vCPU Hotplug code.
Signed-off-by: Salil Mehta
Reviewed-by: Gavin Shan
Tested-by: Vishnu Pajjuri
Reviewed-by: Shaoqin Huang
---
accel/kvm
-by: Keqian Zhu
Signed-off-by: Salil Mehta
Reviewed-by: Jonathan Cameron
Reviewed-by: Gavin Shan
Reviewed-by: Shaoqin Huang
---
hw/acpi/generic_event_device.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
index
Reviewed-by: Gavin Shan
Reviewed-by: Shaoqin Huang
---
hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-stub.c
index 3fc4b14c26..c6c61bb9cd 100644
--- a/hw/acpi/acpi-cpu-hotplug-stub.c
+++ b
-by: Jonathan Cameron
Reviewed-by: Gavin Shan
Reviewed-by: David Hildenbrand
Reviewed-by: Shaoqin Huang
---
hw/acpi/cpu.c | 2 +-
include/hw/acpi/cpu_hotplug.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c
index 19c154d78f
On 9/26/23 18:04, Salil Mehta via wrote:
Factor out CPU properties code common for {hot,cold}-plugged CPUs. This allows
code reuse.
Signed-off-by: Salil Mehta
---
hw/arm/virt.c | 220 ++
include/hw/arm/virt.h | 4 +
2 files changed, 140
Hi Salil,
On 6/26/23 21:42, Salil Mehta wrote:
From: Shaoqin Huang
Sent: Monday, June 26, 2023 7:49 AM
To: qemu-devel@nongnu.org; qemu-...@nongnu.org
Cc: oliver.up...@linux.dev; Salil Mehta ;
james.mo...@arm.com; gs...@redhat.com; Shaoqin Huang ;
Cornelia Huck ; k...@vger.kernel.org; Michael S
when reset vcpu, we need to mark it as dirty to force the vcpu to
sync its register to kvm, and when reset gicv3, we need to pause all
vcpus to grab the all vcpu locks, thus when handling the psci CPU_ON
call, the vcpu can be successfuly boot up.
Signed-off-by: Shaoqin Huang
---
hw/intc
Now the psci call can only be used when tcg_enabled, we want to reuse it
when kvm_enabled, which will be used in subsequent patch which enable
the psci handling in userspace.
Signed-off-by: Shaoqin Huang
---
target/arm/helper.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Copy in the SMCCC definitions from the kernel, which will be used to
implement SMCCC handling in userspace.
Signed-off-by: Shaoqin Huang
---
linux-headers/linux/arm-smccc.h | 240
1 file changed, 240 insertions(+)
create mode 100644 linux-headers/linux/arm
Update to commit 45a3e24f65e9 ("Linux 6.4-rc7").
Signed-off-by: Shaoqin Huang
---
include/standard-headers/linux/const.h| 2 +-
include/standard-headers/linux/virtio_blk.h | 18 +++
.../standard-headers/linux/virtio_config.h| 6 +++
include/standard-hea
-by: Shaoqin Huang
---
docs/system/arm/virt.rst | 4 +++
hw/arm/virt.c| 21
include/hw/arm/virt.h| 1 +
target/arm/kvm.c | 54
4 files changed, 80 insertions(+)
diff --git a/docs/system/arm/virt.rst b/docs/system
] lore.kernel.org/20230203135043.409192-1-james.mo...@arm.com
Shaoqin Huang (5):
linux-headers: Update to v6.4-rc7
linux-headers: Import arm-smccc.h from Linux v6.4-rc7
target/arm: make psci call can be used by kvm
arm/kvm: add skeleton implementation for userspace SMCCC call handling
arm/kvm: add
Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Whlie
at it, reorder the parameters in comments to match the sequence of
parameters which defined in the CPUArchId.
Reviewed-by: Igor Mammedov
Signed-off-by: Shaoqin Huang
---
include/hw/boards.h | 4 ++--
1 file changed, 2
' to object (type
'container')
Aborted (core dumped)
Instead of abort, check for the conflicting 'id' and exit with
an error, suggesting how to remedy the issue.
Signed-off-by: Igor Mammedov
CC: th...@redhat.com
Reviewed-by: Shaoqin Huang
---
hw/core/machine.c | 8
1 file changed, 8
Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Since
we are at here, resort the parameters in comments to match the sequence
of parameters which defined in the CPUArchId.
CC: Igor Mammedov
Signed-off-by: Shaoqin Huang
---
include/hw/boards.h | 4 ++--
1 file changed, 2
Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Since
we are at here, resort the parameters in comments to match the sequence
of parameters which defined in the CPUArchId.
Signed-off-by: Shaoqin Huang
---
include/hw/boards.h | 4 ++--
1 file changed, 2 insertions(+), 2
46 matches
Mail list logo
