[BUG] scsi: vmw_pvscsi: Boot hangs during scsi under qemu, post commit e662502b3a78

Hi, Commit e662502b3a78 ("scsi: vmw_pvscsi: Set correct residual data length"), and its backports to stable trees, makes kernel hang during boot, when ran as a VM under qemu with following parameters: -drive file=$DISKFILE,if=none,id=sda -device pvscsi -device scsi-hd,bus=scsi.0,drive=sda

Re: [Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option of the removed host_net

On Mon, 5 Sep 2016 12:11:02 +0300 Shmulik Ladkani <shmulik.ladk...@gmail.com> wrote: > Upon hmp_host_net_remove(), the appropriate -net client is deleted > (according to the given vlan_id and device id), as well as the > corresponsing hub port. > > However, the r

[Qemu-devel] [PATCH] net: hmp_host_net_remove: Del the -net option of the removed host_net

associated with the given device id. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- net/net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/net.c b/net/net.c index d51cb29882..0bec096d75 100644 --- a/net/net.c +++ b/net/net.c @@ -1179,6 +1179,7 @@ void hmp_host_ne

[Qemu-devel] [PATCH v2] util: Fix assertion in iov_copy() upon zero 'bytes' and non-zero 'offset'

From: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> In cases where iov_copy() is passed with zero 'bytes' argument and a non-zero 'offset' argument, nothing gets copied - as expected. However no copy iterations are performed, so 'offset' is left unaltered, leading to the final

[Qemu-devel] [PATCH] util: Relax assertion in iov_copy()

From: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> In cases where iov_copy() is passed with zero 'bytes' argument and a non-zero 'offset' argument, nothing gets copied - as expected. However since no copy iterations are performed, 'offset' is left unaltered, leading to the final

Re: [Qemu-devel] [PATCH] scsi: pvscsi: check command descriptor ring buffer size

the ring buffer size to an arbitrary > value leading to OOB access issue. Add check to avoid it. > > Reported-by: Li Qiang <liqiang...@360.cn> > Signed-off-by: Prasad J Pandit <p...@fedoraproject.org> Reviewed-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com>

Re: [Qemu-devel] [PATCH 1/2] e1000: Fixing interrupts pace.

Hi, On Mon, 16 May 2016 08:58:32 +0300, sam...@daynix.com wrote: > This means that on a real hardware when mit_delay==0 ( don't use the timer > ) the Ethernet controller guarantees a maximum > observable interrupt rate of 7813 interrupts/sec. Unfortunately that isn't > the case in the emulated

Re: [Qemu-devel] [PATCH 1/2] e1000: Fixing interrupts pace.

Hi Sameeh, On Thu, 17 Mar 2016 09:37:57 +0200, sam...@daynix.com wrote: > @@ -357,6 +357,14 @@ set_interrupt_cause(E1000State *s, int index, uint32_t > val) > } > mit_update_delay(_delay, s->mac_reg[ITR]); > > +/* > + * According to e1000 SPEC,

Re: [Qemu-devel] [PATCH 0/3] scsi: Add support for LSI SAS1068 (mptsas) device

Hi Paolo, Seems patch 2/3 didn't arrive to the mailing list. Regards, Shmulik

Re: [Qemu-devel] [RFC PATCH v2 04/10] pcie: Introduce function for DSN capability creation

Hi Marcel, On Tue, 19 Jan 2016 16:26:31 +0200, marcel.apfelb...@gmail.com wrote: > > > > +/* DSN */ > > +#define PCI_DSN_VER 1 > > +#define PCI_DSN_SIZEOF 8 > > Are you sure the size of DSN is 8? > Looking at PCIe spec 3, chapter 7.12 I see 12, but I might be

[Qemu-devel] [PATCH] ide: Correct the CHS 'cyls_max' limit to be 65535

the 'cyls_max' argument passed to 'blkconf_geometry' in the ide_dev_initfn case was accidentally set to 65536 instead of 65535. Fix, providing the correct 'cyls_max'. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/ide/qdev.c | 2 +- 1 file changed, 1 insertion

Re: [Qemu-devel] [PATCH] spapr: Introduce SPAPR_COMPAT_2_5

Hi, On Thu, 24 Dec 2015 19:25:27 +1100, da...@gibson.dropbear.id.au wrote: > On Wed, Dec 23, 2015 at 09:33:35PM +0200, Shmulik Ladkani wrote: > > In 240240d5 'pc: Add pc-*-2.6 machine classes' HW_COMPAT_2_5 and > > PC_COMPAT_2_5 were introduced. > > > > Accordingly,

Re: [Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5

Hi, On Fri, 18 Dec 2015 09:30:02 +0200 Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> wrote: > Introduce the place-holder for 2.5 back-compat properties, and the > accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5. Please ignore this series, it'll clash. Rec

[Qemu-devel] [PATCH] spapr: Introduce SPAPR_COMPAT_2_5

In 240240d5 'pc: Add pc-*-2.6 machine classes' HW_COMPAT_2_5 and PC_COMPAT_2_5 were introduced. Accordingly, introduce SPAPR_COMPAT_2_5 that uses HW_COMPAT_2_5. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/ppc/spapr.c | 9 + 1 file changed, 9 inse

[Qemu-devel] [PATCH v2] vmw_pvscsi: x-disable-pcie, x-old-pci-configuration back-compat props are 2.5 specific

into HW_COMPAT_2_4. However since these commits were pulled post v2.5, move them to HW_COMPAT_2_5. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- include/hw/compat.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/hw/comp

[Qemu-devel] [PATCH] s390: Introduce CCW_COMPAT_2_5

In 240240d5 'pc: Add pc-*-2.6 machine classes' HW_COMPAT_2_5 and PC_COMPAT_2_5 were introduced. Accordingly, introduce CCW_COMPAT_2_5 that uses HW_COMPAT_2_5. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/s390x/s390-virtio-ccw.c | 9 + 1 file chan

[Qemu-devel] [PATCH v4 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/

[Qemu-devel] [PATCH v4 6/7] vmxnet3: Introduce 'x-disable-pcie' back-compat property

-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c| 2 ++ include/hw/compat.h | 4 2 files changed, 6 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 7ded287..f9cd02b 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -

[Qemu-devel] [PATCH v4 3/7] vmxnet3: Introduce 'x-old-msi-offsets' back-compat property

, which allows migration to older versions. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c| 2 ++ include/hw/compat.h | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 97f0aea..d

[Qemu-devel] [PATCH v4 7/7] vmxnet3: Report the Device Serial Number capability

Report the DSN extended PCI capability at 0x100. DSN value is a transformation of device MAC address, as calculated by VMware virtual hardware. DSN is reported only if device is pcie. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.

[Qemu-devel] [PATCH v4 4/7] vmxnet3: coding: Introduce VMXNET3Class

Introduce a class type for vmxnet3, and the usual DEVICE_CLASS/DEVICE_GET_CLASS macros. No semantic change. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/v

[Qemu-devel] [PATCH v4 0/7] vmxnet3: Fine-tune device capabilities

, per Jason Wang's comment Since v1: Added migration compatability, per Jason Wang's comment Shmulik Ladkani (7): vmxnet3: Change offsets of msi/msix pci capabilities vmxnet3: Change the offset of the MSIX PBA table vmxnet3: Introduce 'x-old-msi-offsets' backword compatability property vmxnet3

[Qemu-devel] [PATCH v4 1/7] vmxnet3: Change offsets of msi/msix pci capabilities

Place device reported PCI capabilities at the same offsets as placed by the VMware virtual hardware: MSI at [84], MSI-X at [9c]. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 18 +++--- 1 file changed, 15 insertions(+), 3 del

[Qemu-devel] [PATCH v4 2/7] vmxnet3: Change the offset of the MSIX PBA table

Place the PBA table at 0x1000, as placed by VMware virtual hardware. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index d323895..97f0aea

Re: [Qemu-devel] [PATCH v2 1/4] net/vmxnet3: return 1 on device activation failure

On Tue, 22 Dec 2015 22:41:34 +0200 Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> wrote: > Could it be that various other error codes might be returned from ESXi > for a VMXNET3_CMD_ACTIVATE_DEV read, depending on device condition? Thinking this over, the commit takes

Re: [Qemu-devel] [PATCH v2 1/4] net/vmxnet3: return 1 on device activation failure

Hi, On Mon, 21 Dec 2015 22:18:21 -0800 Miao Yan wrote: > When reading device status, 0 means device is successfully > activated and 1 means error. > > This behavior can be observed by the following steps: > > 1) run a Linux distro on esxi server > 2) modify vmxnet3 Linux

Re: [Qemu-devel] [PATCH v2 3/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO

like the following message: > > [ 7005.70] vmxnet3 dev_info: 0x0 > > Signed-off-by: Miao Yan <yanmiaob...@gmail.com> Reviewed-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com>

Re: [Qemu-devel] [PATCH v2 2/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command

Hi, On Mon, 21 Dec 2015 22:18:22 -0800 Miao Yan wrote: > VMXNET3_CMD_GET_DID_LO should return PCI ID of the device > and VMXNET3_CMD_GET_DID_HI should return vmxnet3 revision ID. > > This behavior can be observed by the following steps: > > 1) run a Linux distro on esxi

Re: [Qemu-devel] [PATCH v2 2/4] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command

On Mon, 21 Dec 2015 22:18:22 -0800 Miao Yan <yanmiaob...@gmail.com> wrote: > Signed-off-by: Miao Yan <yanmiaob...@gmail.com> Reviewed-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com>

[Qemu-devel] [PATCH 1/2] compat: Introduce HW_COMPAT_2_5

Introduce the place-holder for 2.5 back-compat properties, and the accompanying PC_COMPAT_2_5, CCW_COMPAT_2_5, SPAPR_COMPAT_2_5. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c | 1 + hw/ppc/s

[Qemu-devel] [PATCH 2/2] vmw_pvscsi: x-disable-pcie, x-old-pci-configuration back-compat props are 2.5 specific

into HW_COMPAT_2_4. However since these commits were pulled post v2.5, move them to HW_COMPAT_2_5. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- include/hw/compat.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/hw/comp

[Qemu-devel] [PATCH 0/2] compat: recent vmw_pvscsi back-compat props are 2.5 specific

Introduce HW_COMPAT_2_5 and move the recently added back-compat props of vmw_pvscsi to it, as they were introduced post v2.5. Shmulik Ladkani (2): compat: Introduce HW_COMPAT_2_5 vmw_pvscsi: x-disable-pcie, x-old-pci-configuration back-compat props are 2.5 specific hw/i386/pc_piix.c

Re: [Qemu-devel] [PULL 08/45] vmw_pvscsi: Introduce 'x-old-pci-configuration' backword compatability property

Hi Eric, On Thu, 17 Dec 2015 11:08:35 -0700 Eric Blake <ebl...@redhat.com> wrote: > On 12/17/2015 10:46 AM, Paolo Bonzini wrote: > > From: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> > > If there's a reason to respin: > > long subject line, and co

Re: [Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

Hi, On Mon, 14 Dec 2015 20:26:35 +0200 "Michael S. Tsirkin" wrote: > > > It's set internally by machine types to avoid breaking > > > migration. I don't see any reason for users to set it. > > > > But they do set it :) albeit only through machine types. I don't think > > it's

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

Hi Jason, On Tue, 15 Dec 2015 10:35:59 +0800 Jason Wang wrote: > > Another attempt I've made is to indroduce a new type vmxnet3e (the > > pcie variant of vmxnet3). > > I dropped this approach since it was way too cumbersome, introducing > > lots of boiler-plate code for the

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

Hi, On Mon, 14 Dec 2015 23:10:20 +0200 "Michael S. Tsirkin" wrote: > > In order to set QEMU_PCI_CAP_EXPRESS conditionally per instance > > (for example, according to the given x-pcie-disable property), the > > 'parent_dc_realize' trick was suggested. > > > > Reasoning is

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

Hi, On Mon, 14 Dec 2015 18:14:37 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote: > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > +pvs_k->parent_dc_realize = dc->realize; > > Marcel, Michael, > > this creates a really nasty dependency on the contents

Re: [Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

Hi Michael, On Mon, 14 Dec 2015 19:37:29 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote: > On Mon, Dec 14, 2015 at 06:14:37PM +0100, Paolo Bonzini wrote: > > > > On 13/12/2015 09:08, Shmulik Ladkani wrote: > > > +pvs_k->parent_dc_real

[Qemu-devel] [PATCH v2 0/6] pvscsi: Fine-tune device capabilities

Various fixes to what the vmw_pvscsi device reports in its PCI configuration space, to better align with VMware virtual hardware as exposed by ESXi/Workstation. Since v1: Added compatability properties for migration Shmulik Ladkani (6): vmw_pvscsi: Set device subsystem and revision

[Qemu-devel] [PATCH v2 6/6] vmw_pvscsi: Introduce 'x-disable-pcie' backword compatability property

. This allows migration to older versions. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 2 ++ include/hw/compat.h | 4 2 files changed, 6 insertions(+) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index fb53b24..6b4b989 100644 --- a/h

[Qemu-devel] [PATCH v2 3/6] vmw_pvscsi: Introduce 'x-old-pci-configuration' backword compatability property

config space. Setting 'x-old-pci-configuration' to 'on' preserves the old behavior, which allows migration to older versions. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 2 ++ include/hw/compat.h | 4 2 files changed, 6 insertions(+)

[Qemu-devel] [PATCH v2 5/6] vmw_pvscsi: The pvscsi device is a PCIE endpoint

Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 54 +++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvsc

[Qemu-devel] [PATCH v2 4/6] vmw_pvscsi: coding: Introduce PVSCSIClass

Introduce a class type for pvscsi, and the usual DEVICE_CLASS/DEVICE_GET_CLASS macros. No semantic change. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/scsi/vmw_pvscsi.c b/h

[Qemu-devel] [PATCH v2 2/6] vmw_pvscsi: Change offset of msi pci capability

Place device reported MSI capability at the same offset as placed by the VMware virtual hardware - at offset 0x7c. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/h

[Qemu-devel] [PATCH v2 1/6] vmw_pvscsi: Set device subsystem and revision

To be VMware PVSCSI SCSI Controller, rev 02. As reported by the VMware virtual hardware. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/hw/scsi/vmw_pv

Re: [Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

Thanks Jason, On Mon, 14 Dec 2015 14:24:36 +0800, jasow...@redhat.com wrote: > > +static void vmxnet3_realize(DeviceState *qdev, Error **errp) > > +{ > > +VMXNET3Class *vc = VMXNET3_DEVICE_GET_CLASS(qdev); > > +PCIDevice *pci_dev = PCI_DEVICE(qdev); > > +VMXNET3State *s =

[Qemu-devel] [PATCH v3 3/7] vmxnet3: Introduce 'x-old-msi-offsets' backword compatability property

, which allows migration to older versions. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c| 2 ++ include/hw/compat.h | 4 2 files changed, 6 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 97f0aea..d1fe888 100644 --

[Qemu-devel] [PATCH v3 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/

[Qemu-devel] [PATCH v3 7/7] vmxnet3: Report the Device Serial Number capability

Report the DSN extended PCI capability at 0x100. DSN value is a transformation of device MAC address, as calculated by VMware virtual hardware. DSN is reported only if device is pcie. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.

[Qemu-devel] [PATCH v3 4/7] vmxnet3: coding: Introduce VMXNET3Class

Introduce a class type for vmxnet3, and the usual DEVICE_CLASS/DEVICE_GET_CLASS macros. No semantic change. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/v

[Qemu-devel] [PATCH v3 1/7] vmxnet3: Change offsets of msi/msix pci capabilities

Place device reported PCI capabilities at the same offsets as placed by the VMware virtual hardware: MSI at [84], MSI-X at [9c]. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 18 +++--- 1 file changed, 15 insertions(+), 3 del

[Qemu-devel] [PATCH v3 0/7] vmxnet3: Fine-tune device capabilities

compatability, per Jason Wang's comment Shmulik Ladkani (7): vmxnet3: Change offsets of msi/msix pci capabilities vmxnet3: Change the offset of the MSIX PBA table vmxnet3: Introduce 'x-old-msi-offsets' backword compatability property vmxnet3: coding: Introduce VMXNET3Class vmxnet3

[Qemu-devel] [PATCH v3 2/7] vmxnet3: Change the offset of the MSIX PBA table

Place the PBA table at 0x1000, as placed by VMware virtual hardware. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index d323895..97f0aea

[Qemu-devel] [PATCH v3 6/7] vmxnet3: Introduce 'x-disable-pcie' backword compatability property

-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c| 2 ++ include/hw/compat.h | 4 2 files changed, 6 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 7ded287..f9cd02b 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -

Re: [Qemu-devel] [PATCH 0/3] vmw_pvscsi: Fine-tune device capabilities

Hi, On Thu, 19 Nov 2015 16:25:47 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote: > On 19/11/2015 15:21, Shmulik Ladkani wrote: > > Various fixes to what the vmw_pvscsi device reports in its PCI > > configuration space, to better align with VMware virtual hardware &

Re: [Qemu-devel] [PATCH v2 4/5] vmxnet3: The vmxnet3 device is a PCIE endpoint

Thanks Jason, On Fri, 4 Dec 2015 16:49:52 +0800 Jason Wang wrote: > > @@ -2257,6 +2262,10 @@ static void vmxnet3_pci_realize(PCIDevice *pci_dev, > > Error **errp) > > > > vmxnet3_net_init(s); > > > > +if (pci_is_express(pci_dev) &&

Re: [Qemu-devel] [PATCH v2 1/5] vmxnet3: Change offsets of msi/msix pci capabilities

Thanks Jason, On Fri, 4 Dec 2015 16:49:23 +0800 Jason Wang wrote: > > @@ -18,6 +18,10 @@ > > .driver = "virtio-pci",\ > > .property = "migrate-extra",\ > > .value= "off",\ > > +},{\ > > +.driver = "vmxnet3",\

[Qemu-devel] [PATCH v2 2/5] vmxnet3: Change the offset of the MSIX PBA table

Place the PBA table at 0x1000, as placed by VMware virtual hardware. The 'x-old-msi-offsets' property is used for backwards compatability. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v2 1/5] vmxnet3: Change offsets of msi/msix pci capabilities

Place device reported PCI capabilities at the same offsets as placed by the VMware virtual hardware: MSI at [84], MSI-X at [9c]. For compatability, preserve old offsets using 'x-old-msi-offsets' toggle. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmx

[Qemu-devel] [PATCH v2 0/5] Fine-tune device capabilities

Various fixes to what the vmxnet3 device reports in its PCI configuration space, in order to be aligned with VMware virtual hardware exposed by ESXi/Workstation. Since v1: Added migration compatability, per Jason Wang's comment Shmulik Ladkani (5): vmxnet3: Change offsets of msi/msix pci

[Qemu-devel] [PATCH v2 3/5] vmxnet3: coding: Introduce VMXNET3Class

Introduce a class type for vmxnet3, and the usual DEVICE_CLASS/DEVICE_GET_CLASS macros. No semantic change. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/v

[Qemu-devel] [PATCH v2 for-2.5] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

-pci's own DeviceClass realize method. This also makes code cleaner, as 'virtio_pci_realize' may now access the 'pci_is_express' predicate when needed. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- Since v1: naming change, as suggested by Marcel Apfelbaum hw/virtio/v

[Qemu-devel] [PATCH v2 5/5] vmxnet3: Report the Device Serial Number capability

Report the DSN extended PCI capability at 0x100. DSN value is a transformation of device MAC address, as calculated by VMware virtual hardware. DSN is reported only if device is pcie. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.

Re: [Qemu-devel] [PATCH] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

Hi, On Wed, 2 Dec 2015 16:00:41 +0200, mar...@redhat.com wrote: > > As I can't decide what's better, I'm following your initial suggestion > > and submit for maintainers to review. > > Sure, and thanks for the patience to get to the bottom of it. Sorry, your initial suggestion testing

[Qemu-devel] [PATCH v2 4/5] vmxnet3: The vmxnet3 device is a PCIE endpoint

Report the 'express endpoint' capability if on a PCIE bus. The 'x-disable-pcie' property is used for backwards compatability. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c| 55 - incl

[Qemu-devel] [PATCH v3 for-2.5] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

-pci's own DeviceClass realize method. This also makes code cleaner, as 'virtio_pci_realize' may now access the 'pci_is_express' predicate when needed. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- Since v2: Negate QEMU_PCI_CAP_EXPRESS capability if not an express

Re: [Qemu-devel] [PATCH v2 for-2.5] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

Hi Michael, On Wed, 2 Dec 2015 18:49:24 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 02, 2015 at 05:11:28PM +0200, Marcel Apfelbaum wrote: > > The only thing I want to mention here, (see earlier discussion: > >

Re: [Qemu-devel] [PATCH v2 for-2.5] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

Hi, On Wed, 2 Dec 2015 19:21:20 +0200 Marcel Apfelbaum wrote: > Shmulik, will you resend the patch with this minor change, or you prefer me > to do it? 2.5 closes soon. Sent a v3 with Michael's addition. Havn't had time to runtime test the new "else" part: meaning, if the

Re: [Qemu-devel] [PATCH] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

Thanks Marcel, On Tue, 1 Dec 2015 22:46:33 +0200, mar...@redhat.com wrote: > >> The reason is the device becomes express only if *all* the conditions > >> are met. > > > > I'm ok with either approaches. > > > > However it seems common practice to set QEMU_PCI_CAP_EXPRESS > > unconditionally for

Re: [Qemu-devel] [PATCH] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

Hi, On Wed, 2 Dec 2015 11:51:46 +0200, mar...@redhat.com wrote: > 2. We still have pci_is_express returning true, this is error prone because > one can use this function assuming the device is express. Maybe we should > call it "can_be_express" ? > > If you think this is good enough, you can

Re: [Qemu-devel] [PATCH] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

Hi, On Tue, 1 Dec 2015 18:36:39 +0200 Marcel Apfelbaum wrote: > > +if (pci_is_express(pci_dev) && pci_bus_is_express(pci_dev->bus) && > > +!pci_bus_is_root(pci_dev->bus)) { > > int pos; > > Here you should check only for 'pci_is_express(pci_dev)' .

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

Hi, On Tue, 10 Nov 2015 13:41:29 +0200, mar...@redhat.com wrote: > The virtio devices are converted to PCI-Express > if they are plugged into a PCI-Express bus and > the 'modern' protocol is enabled. > > @@ -1592,6 +1592,26 @@ static void virtio_pci_realize(PCIDevice *pci_dev, > Error **errp) >

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

Hi, On Tue, 1 Dec 2015 13:48:13 +0200, mar...@redhat.com wrote: > > May I suggest the following: > > - Expose 'pci_qdev_realize' > > - Have 'virtio_pci_class_init' arm it's own dc->realize, > >which will first set 'QEMU_PCI_CAP_EXPRESS' flag as needed, > >and then call 'pci_qdev_realize'

Re: [Qemu-devel] [PATCH V5] hw/virtio: Add PCIe capability to virtio devices

Hi, On Tue, 1 Dec 2015 16:01:00 +0200, mar...@redhat.com wrote: > On 12/01/2015 03:18 PM, Shmulik Ladkani wrote: > > On Tue, 1 Dec 2015 13:48:13 +0200, mar...@redhat.com wrote: > >>> May I suggest the following: > >>> - Expose 'pci_qdev_realize' > >>>

[Qemu-devel] [PATCH] virtio-pci: Set the QEMU_PCI_CAP_EXPRESS capability early in its DeviceClass realize method

-pci's own DeviceClass realize method. This also makes code cleaner, as 'virtio_pci_realize' may now access the 'pci_is_express' predicate when needed. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/virtio/virtio-pci.c | 24 +++- hw/virtio/virtio-pci.h

Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpoint

Hi, On Wed, 25 Nov 2015 16:24:39 +0800 Jason Wang wrote: > >>> @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class, > >>> void *data) > >>> c->class_id = PCI_CLASS_NETWORK_ETHERNET; > >>> c->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE; > >>>

Re: [Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpoint

Thanks Jason, On Wed, 25 Nov 2015 10:38:51 +0800, jasow...@redhat.com wrote: > > @@ -2568,6 +2572,7 @@ static void vmxnet3_class_init(ObjectClass *class, > > void *data) > > c->class_id = PCI_CLASS_NETWORK_ETHERNET; > > c->subsystem_vendor_id = PCI_VENDOR_ID_VMWARE; > >

[Qemu-devel] [PATCH 2/4] vmxnet3: Change offsets of PCI capabilities

Place device reported PCI capabilities at the same offsets as placed by the VMware virtual hardware: Express Endpoint at [48], MSI at [84], MSI-X at [9c]. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 9 ++--- 1 file changed, 6 insertions

[Qemu-devel] [PATCH 0/4] vmxnet3: Fine-tune device capabilities

Various fixes to what the vmxnet3 device reports in its PCI configuration space, in order to be aligned with VMware virtual hardware exposed by ESXi/Workstation. Shmulik Ladkani (4): vmxnet3: The vmxnet3 device is a PCIE endpoint vmxnet3: Change offsets of PCI capabilities vmxnet3: Change

[Qemu-devel] [PATCH 3/4] vmxnet3: Change the offset of the MSIX PBA table

Place the PBA table at 0x1000, as placed by VMware virtual hardware. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 48a8242..1525b7c

[Qemu-devel] [PATCH 1/4] vmxnet3: The vmxnet3 device is a PCIE endpoint

Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 5e3a233..ed286cc 100644 --- a/hw/net/vmx

[Qemu-devel] [PATCH 4/4] vmxnet3: Report the Device Serial Number capability

Report the DSN extended PCI capability at 0x100. DSN value is a transformation of device MAC address, as calculated by VMware virtual hardware. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/net/vmxnet3.c | 22 ++ 1 file changed, 22 inse

[Qemu-devel] [PATCH 1/3] vmw_pvscsi: Set device subsystem and revision

To be VMware PVSCSI SCSI Controller, rev 02. As reported by the VMware virtual hardware. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/scsi/vmw_pvscsi.c b/h

[Qemu-devel] [PATCH 0/3] vmw_pvscsi: Fine-tune device capabilities

Various fixes to what the vmw_pvscsi device reports in its PCI configuration space, to better align with VMware virtual hardware as exposed by ESXi/Workstation. Shmulik Ladkani (3): vmw_pvscsi: Set device subsystem and revision vmw_pvscsi: The pvscsi device is a PCIE endpoint vmw_pvscsi

[Qemu-devel] [PATCH 2/3] vmw_pvscsi: The pvscsi device is a PCIE endpoint

Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index df4d383..8854fd9 100644 --- a/h

[Qemu-devel] [PATCH 3/3] vmw_pvscsi: Change offsets of PCI capabilities

Place device reported PCI capabilities at the same offsets as placed by the VMware virtual hardware: Express Endpoint at [40], MSI at [7c] Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> --- hw/scsi/vmw_pvscsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

Re: [Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command

command, returning the "adaptive-ring disabled" flag. > > Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> > --- > hw/net/vmxnet3.c | 9 + > hw/net/vmxnet3.h | 6 +- > 2 files changed, 14 insertions(+), 1 deletion(-) Thanks.

Re: [Qemu-devel] [PULL 6/7] vmxnet3: Drop net_vmxnet3_info.can_receive

> > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > > Tested-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> Ping... I'm not sure what's the exact policy, but shouldn't '2734a20 vmxnet3: Drop net_vmxnet3_info.can_receive' go into stable-2.4? Otherwise

[Qemu-devel] [PATCH] vmxnet3: Support reading IMR registers on bar0

Instead of asserting, return the actual IMR register value. This is aligned with what's returned on ESXi. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com> Tested-by: Dana Rubin <dana.ru...@ravellosystems.com> --- hw/net/vmxnet3.c | 6 +- 1 file changed, 5 inse

Re: [Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

Hi, On Thu, 3 Sep 2015 17:45:34 +0100 Stefan Hajnoczi wrote: > Thanks, applied to my net tree: > https://github.com/stefanha/qemu/commits/net For some reason, the patch isn't present on Stefan's last pull requests. Can you please verify this gets merged? Thanks, Shmulik

[Qemu-devel] [PATCH] vmxnet3: Add support for VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command

Some drivers (e.g. vmware-tools) issue the VMXNET3_CMD_GET_ADAPTIVE_RING_INFO command. Currently, due to lack of support, a bogus value (-1) is returned. Support this command, returning the "adaptive-ring disabled" flag. Signed-off-by: Shmulik Ladkani <shmulik.ladk...@ravel

Re: [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets activated

Hi Stefan, On Wed, 2 Sep 2015 14:48:57 +0100 Stefan Hajnoczi wrote: > On Thu, Aug 20, 2015 at 02:45:47AM +0800, Fam Zheng wrote: > > Looks like the previous patch to fix this fell between the cracks and never > > made it to qemu.git? > > > >

Re: [Qemu-devel] [PULL 6/7] vmxnet3: Drop net_vmxnet3_info.can_receive

queued pkts when transitioning to a .can_receive=true state. But > it's OK to drop incoming packets when the link is not active. > > Signed-off-by: Fam Zheng <f...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> Tested-by: Shmulik Ladkani <shmulik.ladk...@ravellosystems.com>

[Qemu-devel] [PATCH] net/vmxnet3: Refine l2 header validation

. Signed-off-by: Dana Rubin dana.ru...@ravellosystems.com Signed-off-by: Shmulik Ladkani shmulik.ladk...@ravellosystems.com --- hw/net/vmxnet3.c | 4 +--- hw/net/vmxnet_tx_pkt.c | 19 --- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net

[Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets activated

active. Signed-off-by: Shmulik Ladkani shmulik.ladk...@ravellosystems.com --- hw/net/vmxnet3.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 59b06b8..8387571 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1561,6 +1561,7 @@ static void

[Qemu-devel] [PATCH] net/vmxnet3: Fix incorrect debug message

accidentally printed 'len' variable instead of 'pkt_len'. Fix, providing the correct argument. Signed-off-by: Dana Rubin dana.ru...@ravellosystems.com Signed-off-by: Shmulik Ladkani shmulik.ladk...@ravellosystems.com --- hw/net/vmxnet3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[Qemu-devel] [PATCH 0/2] vmxnet3: Fix RX TCP/UDP checksum of partially summed packets

into the tcp/udp header. Otherwise, the OS driver will receive a checksum-correct indication but with the actual tcp/udp checksum field having just the pseudo header csum value. Fix, by converting partially summed packets to be fully checksummed. Shmulik Ladkani: net/vmxnet3: Refactor

[Qemu-devel] [PATCH 1/2] net/vmxnet3: Refactor 'vmxnet_rx_pkt_attach_data'

Separate RX packet protocol parsing out of 'vmxnet_rx_pkt_attach_data'. Signed-off-by: Shmulik Ladkani shmulik.ladk...@ravellosystems.com --- hw/net/vmxnet3.c | 1 + hw/net/vmxnet_rx_pkt.c | 12 +--- hw/net/vmxnet_rx_pkt.h | 11 +++ 3 files changed, 21 insertions(+), 3

[Qemu-devel] [PATCH 2/2] net/vmxnet3: Fix RX TCP/UDP checksum on partially summed packets

performs forwarding, it will forward an incorrectly checksummed packet. Signed-off-by: Dana Rubin dana.ru...@ravellosystems.com Signed-off-by: Shmulik Ladkani shmulik.ladk...@ravellosystems.com --- hw/net/vmxnet3.c | 58 1 file changed, 58

Re: [Qemu-devel] [PATCH] net: Allow specifying maximum number of network NICs during configure

Hi, On Mon, 22 Jun 2015 13:13:20 +0100, stefa...@gmail.com wrote: The -device e1000,netdev=tap0,id=e1000-nic0 syntax is preferred to -net nic syntax and does not have the 8 NIC limit. Please use the -device syntax instead of -net. Very well, thanks. Shmulik

  1   2   >