Re: Timeouts in CI jobs

Am 24.04.24 um 19:09 schrieb Daniel P. Berrangé: On Wed, Apr 24, 2024 at 06:27:58PM +0200, Stefan Weil via wrote: I think the timeouts are caused by running too many parallel processes during testing. The CI uses parallel builds: make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS

Timeouts in CI jobs (was: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?)

Am 20.04.24 um 22:25 schrieb Stefan Weil: Am 16.04.24 um 14:17 schrieb Stefan Weil: Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

Am 16.04.24 um 14:17 schrieb Stefan Weil: Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI

Re: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?

Am 16.04.24 um 14:10 schrieb Peter Maydell: The cross-i686-tci job is flaky again, with persistent intermittent failures due to jobs timing out. [...] Some of these timeouts are very high -- no test should be taking 10 minutes, even given TCI and a slowish CI runner -- which suggests to me

[PATCH for-9.0] Fix some typos in documentation (found by codespell)

Signed-off-by: Stefan Weil --- docs/devel/atomics.rst | 2 +- docs/devel/ci-jobs.rst.inc | 2 +- docs/devel/clocks.rst | 2 +- docs/system/i386/sgx.rst | 2 +- qapi/qom.json | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/atomics.rst b

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 26.02.24 um 05:35 schrieb Bin Meng: On Mon, Feb 26, 2024 at 1:37 AM Stefan Weil wrote: Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU

Re: [PATCH 3/7] scripts/nsis.py: Automatically package required DLLs of QEMU executables

Am 10.09.22 um 02:37 schrieb Bin Meng: On Sat, Sep 10, 2022 at 12:49 AM Mark Cave-Ayland wrote: On 08/09/2022 14:28, Bin Meng wrote: From: Bin Meng At present packaging the required DLLs of QEMU executables is a manual process, and error prone. Actually build/config-host.mak contains a

Files without license statement

Hi Paolo, I just noticed that scripts/fix-multiline-comments.sh has a copyright statement, but no license statement. Should that be fixed? It looks like there exist more files with the same problem (if it is a problem), for example docs/devel/loads-stores.rst (written by Peter). LICENSE

[Bug 2054889] Re: pcap streams are text files which insert 0xD in Windows version

** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/2054889 Title: pcap streams are text files which insert 0xD in Windows version Status in QEMU:

Re: dropping 32-bit Windows host support

Am 19.02.24 um 17:26 schrieb Thomas Huth: On 19/02/2024 16.53, Daniel P. Berrangé wrote: On Mon, Feb 19, 2024 at 03:37:31PM +, Peter Maydell wrote: Our msys2 32-bit Windows host CI job has been failing recently because upstream MSYS2 are starting to phase out 32-bit windows host support

GPL 3.0 in TCG test code

Dear all, some QEMU code under tests/tcg uses GPL 3.0 or later: tests/tcg/aarch64/semicall.h: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/arm/semicall.h: * SPDX-License-Identifier: GPL-3.0-or-later tests/tcg/i386/system/boot.S: * SPDX-License-Identifier: GPL-3.0-or-later

Re: [PATCH v2 1/4] util/uri: Remove uri_string_unescape()

Am 23.01.24 um 19:22 schrieb Thomas Huth: uri_string_unescape() basically does the same as the glib function g_uri_unescape_segment(). So we can get rid of our implementation completely by simply using the glib function instead. Suggested-by: Stefan Weil [g_uri_unescape_string()] Suggested

Re: [PATCH 2/5] util/uri: Simplify uri_string_unescape()

g_uri_unescape_string() instead of walking through the string manually. Suggested-by: Stefan Weil Can my e-mail address be replaced by another one (s...@weilnetz.de)? Signed-off-by: Thomas Huth --- util/uri.c | 49 +++-- 1 file changed, 3 insertions(+), 46

Re: [PATCH 5/5] util/uri: Remove unused macros ISA_RESERVED() and ISA_GEN_DELIM()

Am 22.01.24 um 20:17 schrieb Thomas Huth: They are not used anywhere, so there's no need to keep them around. Signed-off-by: Thomas Huth --- util/uri.c | 13 - 1 file changed, 13 deletions(-) Reviewed-by: Stefan Weil

Re: [PATCH 4/5] util/uri: Remove unused functions uri_resolve() and uri_resolve_relative()

: Reviewed-by: Stefan Weil

Re: [PATCH 3/5] util/uri: Remove the uri_string_escape() function

-- 2 files changed, 65 deletions(-) The removed function is used in util/uri.c, so this patch breaks the compilation. That can be fixed by applying patch 4 before this one. With that re-ordering you may add my signature: Reviewed-by: Stefan Weil

Re: [PATCH 1/5] util/uri: Remove the unused "target" argument from uri_string_unescape()

deletions(-) Reviewed-by: Stefan Weil

Re: [PATCH] util/uri: Remove is_hex() function

Am 12.01.24 um 07:35 schrieb Markus Armbruster: Thomas Huth writes: We can simply use the g_ascii_isxdigit() from the glib instead. ... or even use unescape_string() from the glib? https://docs.gtk.org/glib/type_func.Uri.unescape_string.html Regards, Stefan

Re: [PATCH] mailmap: Fix Stefan Weil author email again

Am 27.12.23 um 10:12 schrieb Philippe Mathieu-Daudé: On 27/12/23 10:09, Michael Tokarev wrote: 27.12.2023 11:59, Philippe Mathieu-Daudé: Commit 5204b499a6 ("mailmap: Fix Stefan Weil author email") corrected authorship for patch received at qemu-devel@nongnu.org, correct now for patc

Re: [PATCH] target/hexagon/idef-parser/prepare: use env to invoke bash

Am 25.12.23 um 09:05 schrieb Michael Tokarev: 23.11.2023 23:57, Samuel Tardieu : This file is the only one involved in the compilation process which still uses the /bin/bash path. Signed-off-by: Samuel Tardieu ---   target/hexagon/idef-parser/prepare | 2 +-   1 file changed, 1 insertion(+), 1

[PATCH] virtio-blk: Fix potential nullpointer read access in virtio_blk_data_plane_destroy

Fixes: CID 1532828 Fixes: b6948ab01d ("virtio-blk: add iothread-vq-mapping parameter") Signed-off-by: Stefan Weil --- hw/block/dataplane/virtio-blk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-b

[PATCH for-8.2] Fix broken build for QEMU guest agent

Meson setup failed: qga/meson.build:148:4: ERROR: Unknown variable "project". Fixes commit e20d68aa ("configure, meson: use command line options [...]"). Signed-off-by: Stefan Weil --- qga/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] spelling: hw/audio/virtio-snd.c: initalize

O_SND_S_OK)) { error_setg(errp, - "Can't initalize stream params, device responded with %s.", + "Can't initialize stream params, device responded with %s.", print_code(status)); return;

[PATCH] Fix some typos in documentation and comments

Signed-off-by: Stefan Weil --- This patch was triggered by a spelling check for the generated QEMU documentation using codespell. It does not try to fix all typos which still exist in the QEMU code, but has a focus on those required to fix the documentation. Nevertheless some code comments

Re: [PATCH v2 1/1] ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

HILE_GRABBED SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0"); #endif The typo fix for the comment does not require a v3 and can be applied in the pull request. Reviewed-by: Stefan Weil

Re: source fails to compile on msys2

Am 12.04.23 um 15:13 schrieb Howard Spoelstra: Hello Peter, My source was cloned today. I just cloned again and I still see the tokens reversed: git clone https://www.gitlab.com/qemu/qemu qemu-master-clean The official URL is

Re: source fails to compile on msys2

Am 12.04.23 um 14:12 schrieb BALATON Zoltan: On Wed, 12 Apr 2023, Howard Spoelstra wrote: It seems the current source fails to compile with up to date msys2. See here: https://qemu.weilnetz.de/ I think there are some patches there that aren't upstream. I don't know why and also don't know

[PATCH for-8.0] docs/cxl: Fix sentence

Signed-off-by: Stefan Weil --- If my change is okay I suggest to apply the patch for 8.0 because it fixes documentation. Regards, Stefan W. docs/system/devices/cxl.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/devices/cxl.rst b/docs/system/devices/cxl.rst

[PATCH for-8.0] docs: Fix typo (wphx => whpx)

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1529 Signed-off-by: Stefan Weil --- I suggest to apply the patch for 8.0 because it fixes documentation. Regards Stefan W. docs/system/introduction.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system

[PATCH] hw/arm: Fix some typos in comments (most found by codespell)

Signed-off-by: Stefan Weil --- The patch does not change code and could also be applied for 8.0. hw/arm/Kconfig| 2 +- hw/arm/exynos4210.c | 4 ++-- hw/arm/musicpal.c | 2 +- hw/arm/omap1.c| 2 +- hw/arm/omap2.c| 2 +- hw/arm/virt-acpi-build.c

Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

Am 07.04.23 um 19:01 schrieb Stefan Weil: Please excuse the late report, but this old patch causes a build failure for me: I just noticed that this is already fixed in latest code (I tested the build with v8.0.0-rc0). So nothing to do. Sorry for the noise. Stefan

Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

Please excuse the late report, but this old patch causes a build failure for me: Am 20.04.22 um 15:26 schrieb marcandre.lur...@redhat.com: From: Marc-André Lureau G_NORETURN was introduced in glib 2.68, fallback to G_GNUC_NORETURN in glib-compat. Note that this attribute must be placed

Re: [PATCH-for-8.0] block/dmg: Ignore C99 prototype declaration mismatch from

solution how to implement that I thing it would look > nicer. Technically the patch looks good. > > Reviewed-by: Stefan Weil Thanks! Typically I configure the build on macOS with `./configure --extra-cflags=-I/opt/homebrew/include --extra-ldflags=-L/opt/homebrew

Re: [PATCH-for-8.0] block/dmg: Ignore C99 prototype declaration mismatch from

ing it would look nicer. Technically the patch looks good. Reviewed-by: Stefan Weil Thanks, Stefan

Re: [PATCH] Updated the FSF address to

/uri.h | 3 +-- tests/qemu-iotests/022 | 4 +--- tests/unit/rcutorture.c | 3 +-- tests/unit/test-rcu-list.c | 3 +-- util/uri.c | 3 +-- 9 files changed, 9 insertions(+), 19 deletions(-) Reviewed-by: Stefan Weil

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

Am 19.02.23 um 12:27 schrieb Reinoud Zandijk: On Fri, Feb 17, 2023 at 12:05:46PM +0100, Stefan Weil wrote: So there still seems to be a certain small need for QEMU installers for 32-bit Windows: 170 users für 32 bit only, 339 users for both 32 and 64 bit, 5132 users for 64 bit only. As you

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: Which 32-bit hosts are still useful, and why? Citing my previous mail: I now checked all downloads of the latests installers since 2022-12-30. qemu-w32-setup-20221230.exe – 509 different IP addresses

Re: [PATCH v2 1/2] qga-win: add logging to Windows event log

Am 23.01.23 um 20:38 schrieb Andrey Drobyshev: Hi Stefan, On 1/23/23 19:28, Stefan Weil wrote: Hi, cross builds fail with this code. Please see details below. Am 29.11.22 um 18:38 schrieb Andrey Drobyshev via: This commit allows QGA to write to Windows event log using Win32 API's

Re: [PATCH v2 1/2] qga-win: add logging to Windows event log

Hi, cross builds fail with this code. Please see details below. Am 29.11.22 um 18:38 schrieb Andrey Drobyshev via: This commit allows QGA to write to Windows event log using Win32 API's ReportEvent() [1], much like syslog() under *nix guests. In order to generate log message definitions we

Re: Announcement of aborting HAXM maintenance

Am 19.01.23 um 11:12 schrieb Daniel P. Berrangé: On Thu, Jan 19, 2023 at 03:56:04AM +, Wang, Wenchao wrote: Hi, Philippe, Intel decided to abort the development of HAXM and the maintenance of its QEMU part. Should we submit a patch to mark the Guest CPU Cores (HAXM) status as Orphan and

Re: MSYS2 and libfdt

Am 19.01.23 um 09:14 schrieb Thomas Huth:  Hi all, in some spare minutes, I started playing with a patch to try to remove the dtc submodule from the QEMU git repository - according to https://repology.org/project/dtc/versions our supported build platforms should now all provide the minimum

Re: building qemu on windows 11

/ Ubuntu or similar Linux host. Regards Stefan Weil

Re: [PATCH] .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job

Am 06.01.23 um 09:19 schrieb Thomas Huth: On 06/01/2023 09.15, Stefan Weil wrote: Download numbers from yesterday for my latest Windows installers: qemu-w32-setup-20221230.exe - 243 qemu-w64-setup-20221230.exe - 6540 On Wednesday the ratio was 288 : 3516. As expected the 64-bit variant

Re: [PATCH] .gitlab-ci.d/windows: Do not run the qtests in the msys2-32bit job

Am 06.01.23 um 08:49 schrieb Thomas Huth: On 05/01/2023 22.42, Philippe Mathieu-Daudé wrote: > That said, maybe it is time to deprecate the 32-bit > hosts? Certainly fine for me, but that's up to the Windows folks to decide. Maybe you could just suggest a patch to start the discussion?  

Re: [PATCH v3 04/26] configure: don't enable cross compilers unless in target_list

Am 21.10.22 um 00:10 schrieb Richard Henderson: On 10/20/22 21:51, Alex Bennée wrote: This avoids the unfortunate effect of always builds the pc-bios blobs for targets the user isn't interested in. Suggested-by: Paolo Bonzini Signed-off-by: Alex Bennée ---   configure | 9 +   1 file

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

2492 | d->Q(0) = r0;   | ^~~~ With what compiler? Is that a supported one? https://lore.kernel.org/qemu-devel/3aab489e-9d90-c1ad-0b6b-b2b5d80db...@redhat.com/ Signed-off-by: Eric Auger Suggested-by: Stefan Weil Fixes: 790684776861 ("target/i386: reimpleme

Re: [PATCH v2] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

d->Q(0) = r0; | ^~~~ Signed-off-by: Eric Auger Suggested-by: Stefan Weil Fixes: 790684776861 ("target/i386: reimplement 0x0f 0x3a, add AVX") --- target/i386/ops_sse.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/ops_sse.h b

Re: [PATCH 1/6] disas: add G_GNUC_PRINTF to gstring_printf

Am 19.12.22 um 14:02 schrieb Daniel P. Berrangé: Signed-off-by: Daniel P. Berrangé --- disas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disas.c b/disas.c index 94d3b45042..31df8f5b89 100644 --- a/disas.c +++ b/disas.c @@ -239,6 +239,7 @@ void target_disas(FILE *out, CPUState *cpu,

Re: [PATCH] mailmap: Fix Stefan Weil author email

Qemu-devel +Stefan Weil Stefan Weil via # Next, replace old addresses by a more recent one. Aleksandar Markovic Signed-off-by: Stefan Weil Thanks! OpenPGP_0xE08C21D5677450AD.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [PULL 11/21] docs: Build and install all the docs in a single manual

Am 12.01.21 um 17:57 schrieb Peter Maydell: [...] diff --git a/docs/meson.build b/docs/meson.build index fae9849b79b..bb14eaebd3b 100644 --- a/docs/meson.build +++ b/docs/meson.build @@ -46,19 +46,11 @@ if build_docs meson.source_root() / 'docs/sphinx/qmp_lexer.py',

Compiler warnings with maximum warning level (was: Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized)

Am 07.12.22 um 20:11 schrieb Stefan Weil: On 12/7/22 14:24, Eric Auger wrote: Initialize r0-3 to avoid compilation errors when -Werror=maybe-uninitialized is used ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’: ../target/i386/ops_sse.h:2495:13: error: ‘r3’ may be used uninitialized

Re: [PATCH for 7.2?] target/i386: Remove compilation errors when -Werror=maybe-uninitialized

Am 07.12.22 um 19:22 schrieb Eric Auger: On 12/7/22 17:55, Philippe Mathieu-Daudé wrote: On 7/12/22 15:33, Eric Auger wrote: On 12/7/22 15:09, Stefan Hajnoczi wrote: On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote: On 12/7/22 14:24, Eric Auger wrote: Initialize r0-3 to avoid compilation

Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi: We need to wait for Michael to agree to maintainership in patch 5. If we run out of time I suggest splitting out patch 5. Reviewed-by: Stefan Hajnoczi Citing Michael from a v2 email: "pls do". Stefan Hello Michael, I just noticed

Re: [PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic

Am 27.11.22 um 19:14 schrieb Stefan Hajnoczi: On Sat, 26 Nov 2022 at 10:25, Stefan Weil wrote: Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.

[PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/subprojects/li

[PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to section "vhost"

Signed-off-by: Stefan Weil --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index cf24910249..6966490c94 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2005,6 +2005,7 @@ F: docs/interop/vhost-user.rst F: contrib/vhost-user-*/ F: backends/vhost

[PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

ewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil --- include/net/net.h | 3 ++- net/socket.c | 2 +- net/stream.c | 6 +++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 3db75ff841..dc20b31e9f 1006

[PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings

This fix is required for 32 bit hosts. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 for-7.2 0/6] Add format attributes and fix format strings

v3: - Fix description for patch 3 - Add patches 5 and 6 The patches 3 and 5 still need reviews! [PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to [PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings [PATCH v3

[PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-3...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/libvhost-user/li

[PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvhos

Re: [PATCH for 7.2-rc? v2 0/5] continuing efforts to fix vhost-user issues

Am 25.11.22 um 18:30 schrieb Alex Bennée: Hi, This is continuing to attempt to fix the various vhost-user issues that are currently plaguing the release. One concrete bug I've come across is that all qtest MMIO devices where being treated as legacy which caused the VIRTIO_F_VERSION_1 flag to

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 23.11.22 um 07:35 schrieb Stefan Weil: Am 15.11.22 um 08:25 schrieb Stefan Weil: Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 15.11.22 um 08:25 schrieb Stefan Weil: Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil ---   subprojects/libvhost-user

Re: [PATCH for-7.2 v2 3/4] libvhost-user: Fix two more format strings

Am 05.11.22 um 11:24 schrieb Stefan Weil: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2

[PATCH for-7.2] Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues

string [-Wformat-zero-length] 182 | qemu_set_info_str(>nc, ""); | ^~ ../../../net/stream.c:170:35: warning: zero-length gnu_printf format string [-Wformat-zero-length] 170 | qemu_set_info_str(>nc, ""); Signed-off-b

Re: [PATCH] s390x: Fix spelling errors

art.S +++ b/pc-bios/s390-ccw/start.S @@ -19,7 +19,7 @@ _start: larl %r2, __bss_start larl %r3, _end slgr %r3, %r2 /* get sizeof bss */ - ltgr%r3,%r3 /* bss emtpy? */ + ltgr%r3,%r3 /* bss empty? */ jz done

[RFC: PATCH v2] Add new build targets 'check-spelling' and 'check-spelling-docs'

`make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell, a spell checker implemented in Python. 'make check-spelling-docs' checks the generated documentation. Signed-off-by: Stefan Weil --- v2: Additional target check-spelling-docs

[PATCH for-7.2] Fix several typos in documentation (found by codespell)

Those typos are in files which are used to generate the QEMU manual. Signed-off-by: Stefan Weil --- I did not fix memory_region_init_resizeable_ram. That might be done after 7.2. Stefan docs/devel/acpi-bits.rst | 2 +- docs/system/devices/can.rst| 2 +- hw/scsi/esp.c

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 22:24 schrieb Michael Tokarev: 05.11.2022 15:23, Stefan Weil via wrote: .. All typos from this series were also found by codespell. See https://qemu.weilnetz.de/test/typos7 for many more. That list was produced with `make check-spelling` from my previous patch). Yeah

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

Am 05.11.22 um 12:57 schrieb Stefan Weil via: Am 05.11.22 um 12:48 schrieb Michael Tokarev: Fixes: effaf5a240e03020f4ae953e10b764622c3e87cc Signed-off-by: Michael Tokarev ---   hw/usb/hcd-xhci.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) All typos from this series were also found

Re: [PATCH trivial for 7.2] hw/ssi/sifive_spi.c: spelling: reigster

er 0x%" + "%s: invalid write to read-only register 0x%" HWADDR_PRIx " with 0x%x\n", __func__, addr << 2, value); break; Reviewed-by: Stefan Weil OpenPGP_0xE08C21D5677450AD.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [PATCH trivial for 7.2 2/2] hw/virtio/virtio.c: spelling: suppoted

table data " -"buffers suppoted"), +"buffers supported"), FEATURE_ENTRY(VIRTIO_SCSI_F_HOTPLUG, \ "VIRTIO_SCSI_F_HOTPLUG: Reporting and handling hot-plug events " "supported"), Reviewed-by: Stefan

Re: [PATCH trivial for 7.2 1/2] hw/usb/hcd-xhci.c: spelling: tranfer

size!\n", +qemu_log_mask(LOG_GUEST_ERROR, "%s: exceeded maximum transfer ring size!\n", __func__); return -1; Reviewed-by: Stefan Weil OpenPGP_0xE08C21D5677450AD.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

[PATCH for-7.2] tests/qtest: Fix two format strings

Signed-off-by: Stefan Weil --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index d2eb107f0c..f574331b7b 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration

[PATCH for-7.2] accel/tcg: Suppress compiler warning with flag -Wclobbered

At least some versions of gcc show a warning when compiler flag -Wclobbered is used (tested with gcc on Debian bookworm i386 and with cross gcc for Windows on Debian bullseye). Signed-off-by: Stefan Weil --- accel/tcg/translate-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/accel

Re: [PATCH v2 3/4] libvhost-user: Fix two more format strings

Am 05.11.22 um 11:24 schrieb Stefan Weil via: This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. s/host/hosts/ I won't send a v3 for that. Maybe it can be fixed when merging this patch. Stefan

[PATCH v2 for-7.2 0/4] libvhost-user: Add format attribute and fix format strings

v2: Add patch 3 to fix two more format strings before applying patch 4 [PATCH v2 1/4] libvhost-user: Fix wrong type of argument to [PATCH v2 2/4] libvhost-user: Fix format strings [PATCH v2 3/4] libvhost-user: Fix two more format strings [PATCH v2 4/4] libvhost-user: Add format attribute to local

[PATCH v2 1/4] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvhos

[PATCH v2 4/4] libvhost-user: Add format attribute to local function vu_panic

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-4...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/subprojects/li

[PATCH v2 2/4] libvhost-user: Fix format strings

Signed-off-by: Stefan Weil Reviewed-by: Marc-André Lureau Message-Id: <20220422070144.1043697-3...@weilnetz.de> Signed-off-by: Laurent Vivier --- subprojects/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/subprojects/libvhost-user/li

[PATCH v2 3/4] libvhost-user: Fix two more format strings

This fix is required for 32 bit host. The bug was detected by CI for arm-linux, but is also relevant for i386-linux. Reported-by: Stefan Hajnoczi Signed-off-by: Stefan Weil --- subprojects/libvhost-user/libvhost-user.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PULL 04/10] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM)

Am 04.11.22 um 17:16 schrieb Laurent Vivier: Hi Stefan, Le 03/11/2022 à 17:17, Laurent Vivier a écrit : From: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Weil Message-Id: <20220422070144.1043697-2...@weilnetz.de> Signed-off-by: Laurent Vivier ---   subpr

Re: [PATCH] meson: avoid unused arguments of main() in compiler tests

emove argc and argv whenever they are not needed. Signed-off-by: Paolo Bonzini --- Reviewed-by: Stefan Weil Thanks, Stefan meson.build | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index 17834b3c3def..7beeac6b5194 100644 --- a/meson.b

Re: [PATCH for 7.2] Fix broken configure with -Wunused-parameter

Am 03.11.22 um 12:48 schrieb Peter Maydell: On Wed, 2 Nov 2022 at 20:24, Stefan Weil via wrote: The configure script fails because it tries to compile small C programs with a main function which is declared with arguments argc and argv although those arguments are unused. Running `configure

Re: [PATCH for 7.2] Fix broken configure with -Wunused-parameter

Am 03.11.22 um 09:58 schrieb Daniel P. Berrangé: On Wed, Nov 02, 2022 at 09:22:58PM +0100, Stefan Weil via wrote: The configure script fails because it tries to compile small C programs with a main function which is declared with arguments argc and argv although those arguments are unused

[PATCH] Add missing include statement for global xml_builtin

-by: Stefan Weil --- scripts/feature_to_c.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/feature_to_c.sh b/scripts/feature_to_c.sh index b1169899c1..c1f67c8f6a 100644 --- a/scripts/feature_to_c.sh +++ b/scripts/feature_to_c.sh @@ -56,6 +56,7 @@ for input; do done echo +echo

Re: [PATCH] Run docker probe only if docker or podman are available

Am 30.10.22 um 09:35 schrieb Stefan Weil: The docker probe uses "sudo -n" which can cause an e-mail with a security warning each time when configure is run. Therefore run docker probe only if either docker or podman are available. That avoids the problematic "sudo -n" o

[PATCH for 7.2] Fix broken configure with -Wunused-parameter

but shows the error in config.log. A cross build configure for Windows with Debian stable aborts with an error. Avoiding unused arguments fixes this. Signed-off-by: Stefan Weil --- See https://gitlab.com/qemu-project/qemu/-/issues/1295. I noticed the problem because I often compile with -Wextra

Re: [PATCH 4/5] disas/nanomips: Remove headers already included by "qemu/osdep.h"

r patch). Reviewed-by: Stefan Weil OpenPGP_0xE08C21D5677450AD.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature

Re: [PATCH 3/5] disas/nanomips: Use G_GNUC_PRINTF to avoid invalid string formats

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé: Suggested-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/nanomips.c b/disas/nanomips.c index e4b21e7c45..3f45447292 100644 --- a/disas

Re: [PATCH 2/5] disas/nanomips: Fix invalid PRIx64 format calling img_format()

u_value, count_value); ~~^~~ %llu Fixes: 4066c152b3 ("disas/nanomips: Remove IMMEDIATE functions") Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- disas/nanomips

Re: [PATCH 1/5] disas/nanomips: Fix invalid PRId64 format calling img_format()

p_value, s_value, rs); ~~ ^~~ %lld Fixes: 4066c152b3 ("disas/nanomips: Remove IMMEDIATE functions") Reported-by: Stefan Weil Signed-off-by: Philippe Mathieu-Daudé --- Reviewed-by: Stef

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

Am 01.11.22 um 10:27 schrieb Philippe Mathieu-Daudé: On 1/11/22 09:28, Stefan Weil via wrote: Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the first time through the IMMEDIATE

Re: [PATCH v3 16/24] disas/nanomips: Remove IMMEDIATE functions

Am 12.09.22 um 14:26 schrieb Milica Lazarevic: Both versions of IMMEDIATE functions have been removed. Before this patch, we'd been calling img_format twice, the first time through the IMMEDIATE to get an appropriate string and the second time to print that string. There's no more need for

Re: [RFC PATCH] Add new build target 'check-spelling'

Below I added some examples for the words which are currently ignored by codespell. Am 31.10.22 um 16:40 schrieb Philippe Mathieu-Daudé: On 31/10/22 08:43, Stefan Weil via wrote: `make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell

Re: [PATCH v2] Fix some typos in documentation and comments

Am 31.10.22 um 08:35 schrieb Thomas Huth: On 30/10/2022 11.59, Stefan Weil wrote: Most of them were found and fixed using codespell. Signed-off-by: Stefan Weil --- v2: Fixes from Peter Maydell's comments My focus was fixing typos which are relevant for the generated documentation

Re: [PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Am 31.10.22 um 11:28 schrieb Philippe Mathieu-Daudé: On 31/10/22 10:57, Stefan Weil via wrote: Signed-off-by: Stefan Weil ---   MAINTAINERS | 1 +   1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé Cc qemu-trivial

Re: [RFC PATCH] Add new build target 'check-spelling'

Am 31.10.22 um 08:52 schrieb Thomas Huth: On 31/10/2022 08.43, Stefan Weil wrote: `make check-spelling` can now be used to get a list of spelling errors. It uses the latest version of codespell, a spell checker implemented in Python. Signed-off-by: Stefan Weil --- This RFC can already

[PATCH] Add nsis.py to W32/W64 section in MAINTAINERS

Signed-off-by: Stefan Weil --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 64893e36bc..534b1b8a63 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -548,6 +548,7 @@ F: */*win32* F: include/*/*win32* X: qga/*win32* F: qemu.nsi +F: scripts/nsis.py

  1   2   3   4   5   6   7   8   9   10   >