Re: [PATCH] net: eepro100: validate various address values

2021-02-19 Thread Stefan Weil
Am 19.02.21 um 09:08 schrieb Stefan Weil: Okay, I can confirm the infinite recursion now. The test case triggers memory writes by the hardware which cause new actions of the same hardware and so on. I don't know how the real hardware would handle that case. For QEMU we can extend

Re: [PATCH] net: eepro100: validate various address values

2021-02-19 Thread Stefan Weil
Am 19.02.21 um 07:11 schrieb P J P: Hello Alex, Stefan, all +-- On Thu, 18 Feb 2021, Alexander Bulekov wrote --+ | Maybe the infinite loop mentioned in the commit message is actually a DMA | recursion issue? I'm providing a reproducer for a DMA re-entracy issue | below. With this patch

Re: [PATCH] net: eepro100: validate various address values

2021-02-18 Thread Stefan Weil
Am 18.02.21 um 15:41 schrieb Peter Maydell: On Thu, 18 Feb 2021 at 14:13, P J P wrote: From: Prasad J Pandit While processing controller commands, eepro100 emulator gets command unit(CU) base address OR receive unit (RU) base address OR command block (CB) address from guest. If these values

[Bug 1915794] Re: could not load PC BIOS 'bios-256k.bin' on latest Windows exe (*-20210203.exe)

2021-02-16 Thread Stefan Weil
See also the patch which will fix this issue upstream as soon as it was merged: https://patchwork.ozlabs.org/project/qemu- devel/patch/20210208205752.2488774-1...@weilnetz.de/. ** Tags added: windows ** Changed in: qemu Status: New => Confirmed -- You received this bug notification

[Bug 1915794] Re: could not load PC BIOS 'bios-256k.bin' on latest Windows exe (*-20210203.exe)

2021-02-16 Thread Stefan Weil
This is a known and documented problem with a simple workaround: "Known issue: currently requires start from installation directory or -L option to specify the location of the firmware files." And it is already fixed in the newer installer. -- You received this bug notification because you are

Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls

2021-02-09 Thread Stefan Weil
Am 09.02.21 um 22:15 schrieb Stefan Weil: Thanks for solving this. The patch works for me. BIOS boot time with qemu-system-i386 is about 41 s (with my code which lacks thread support and ffi it was 40 s). With qemu-system-x86_64 it is twice as fast, so it looks like in my last report

Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls

2021-02-09 Thread Stefan Weil
Am 09.02.21 um 21:46 schrieb Richard Henderson: On 2/8/21 2:55 PM, Richard Henderson wrote: Ok, I've reproduced something on a T3 (gcc102.fsffrance.org). Running the same code side-by-side vs the T5, I get different results. Brown paper bag time: the T5 build dir lost the

Re: [PATCH 0/3] fix build failures from incorrectly skipped container build jobs

2021-02-08 Thread Stefan Weil
Am 08.02.21 um 19:12 schrieb Daniel P. Berrangé: On Mon, Feb 08, 2021 at 07:08:39PM +0100, Philippe Mathieu-Daudé wrote: On 2/8/21 6:22 PM, Daniel P. Berrangé wrote: On Mon, Feb 08, 2021 at 04:33:36PM +, Daniel P. Berrangé wrote: This series fixes a problem with our gitlab CI rules that

[PATCH] util/cutils: Skip "." when looking for next directory component

2021-02-08 Thread Stefan Weil
When looking for the next directory component, a "." component is now skipped. This fixes the path(s) used for firmware lookup for the prefix == bindir case which is standard for QEMU on Windows and where the internally used bindir value ends with "/.". Signed

Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls

2021-02-08 Thread Stefan Weil
Am 08.02.21 um 18:39 schrieb Richard Henderson: On 2/8/21 5:07 AM, Stefan Weil wrote: Richard, this commit is also the one which breaks qemu-system-i386 on sparc64 for me: You'll have to give me more details than that, because qemu-system-i386 works for me on a niagara5 w/ debian sid. I

Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls

2021-02-08 Thread Stefan Weil
Am 08.02.21 um 10:35 schrieb Paolo Bonzini: On 08/02/21 10:20, Peter Maydell wrote: + +if get_option('tcg_interpreter') +  libffi = dependency('libffi', version: '>=3.0', +  static: enable_static, method: 'pkg-config', +  required: true) + 

Re: Increased execution time with TCI in latest git master (was: Re: [PULL 00/46] tcg patch queue)

2021-02-07 Thread Stefan Weil
On 07.02.21 19:37, Richard Henderson wrote: > On 2/7/21 2:50 AM, Stefan Weil wrote: >> Your latest code from the rth7680/tci-next branch is twice as fast as my code >> with BIOS boot and qemu-x86_64 on sparc64. That's great. >> >> With that code I don't get any BIOS outp

Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls

2021-02-07 Thread Stefan Weil
On 07.02.21 21:12, Richard Henderson wrote: > On 2/7/21 11:52 AM, Peter Maydell wrote: >> On Sun, 7 Feb 2021 at 17:41, Richard Henderson >> wrote: >>> >>> On 2/7/21 8:25 AM, Stefan Weil wrote: >>>>> +#include "qemu-common.h" &g

Re: [PATCH v2 63/93] tcg/tci: Use ffi for calls

2021-02-07 Thread Stefan Weil
Am 04.02.21 um 02:44 schrieb Richard Henderson: This requires adjusting where arguments are stored. Place them on the stack at left-aligned positions. Adjust the stack frame to be at entirely positive offsets. Signed-off-by: Richard Henderson --- [...] diff --git a/tcg/tci.c b/tcg/tci.c

Re: Increased execution time with TCI in latest git master (was: Re: [PULL 00/46] tcg patch queue)

2021-02-07 Thread Stefan Weil
Am 07.02.21 um 04:45 schrieb Richard Henderson: On 2/6/21 11:38 AM, Stefan Weil wrote: I am still searching what caused this detoriation. My first suspect was thread local storage, but that wasn't it. Do you have any idea? No, but since it's 1/3 of a complete patch set, I don't care

Increased execution time with TCI in latest git master (was: Re: [PULL 00/46] tcg patch queue)

2021-02-06 Thread Stefan Weil
Am 05.02.21 um 23:56 schrieb Richard Henderson: The following changes since commit d0dddab40e472ba62b5f43f11cc7dba085dabe71: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-02-05 15:27:02 +) are available in the Git repository at:

Re: [PATCH v2 00/93] TCI fixes and cleanups

2021-02-04 Thread Stefan Weil
Am 04.02.21 um 10:58 schrieb Peter Maydell: On Thu, 4 Feb 2021 at 01:49, Richard Henderson wrote: Almost 7 years ago I detailed 5 major problems in tci[1], of which three still remain: * Unaligned accesses to the bytecode stream, which means that we immediately SIGBUS on any host

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-02-02 Thread Stefan Weil
Am 02.02.21 um 21:31 schrieb Stefan Weil: The code uses NULL + offset constructs, so requires a fix. https://gitlab.com/gnutls/libtasn1/-/merge_requests/71 fixes the unit tests of libtasn1 for me, maybe also the test for QEMU which I still have to check. The QEMU test passes

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-02-02 Thread Stefan Weil
Am 02.02.21 um 18:14 schrieb Eric Blake: Yes, you do have a valid argument: any compiler that is going to optimize on our undefined behavior, but fails to give us a -Wxyz option to ferret out those spots in our code in order to avoid them in the first place, has a poor QoI, and it is worth

Re: Makefile has local changes that will be overwritten

2021-02-01 Thread Stefan Weil
Am 01.02.21 um 16:36 schrieb Programmingkid: Thank you for the suggestion. I tried it but didn't seem to help. I should report this is what I see when I try to build QEMU: Disabling PIE due to missing toolchain support error: Your local changes to the following files would be overwritten by

Re: Makefile has local changes that will be overwritten

2021-02-01 Thread Stefan Weil
Am 01.02.21 um 15:23 schrieb Programmingkid: When trying to build QEMU I see this error: error: Your local changes to the following files would be overwritten by checkout: Makefile Please commit your changes or stash them before you switch branches. Aborting What I do to see this

Re: [PATCH v3 02/24] tcg/tci: Remove TCG_TARGET_HAS_* ifdefs

2021-01-29 Thread Stefan Weil
Am 30.01.21 um 07:47 schrieb Richard Henderson: On 1/29/21 1:16 PM, Peter Maydell wrote: On Fri, 29 Jan 2021 at 20:13, Richard Henderson wrote: The opcodes always exist, regardless of whether or not they are enabled. Remove the unnecessary ifdefs. Signed-off-by: Richard Henderson ---

Re: [PATCH] tests: Replace deprecated ASN1 code

2021-01-29 Thread Stefan Weil
Am 29.01.21 um 12:47 schrieb Daniel P. Berrangé: This is really odd. I've got the 4.16.0 tar.gz for libtasn1 and it does not contain any such _Pragma / deprecation warnings. The libtasn1 git repo *does* contain these pragmas, but only in the dev tree for the unreleased 4.17.0 version. The

Re: [PATCH] tests: Replace deprecated ASN1 code

2021-01-29 Thread Stefan Weil
Am 29.01.21 um 11:06 schrieb Daniel P. Berrangé: On Thu, Jan 28, 2021 at 06:15:23PM +0100, Stefan Weil wrote: This fixes several compiler warnings on MacOS with Homebrew. Could you give an example of the warnings seen as I'm wondering why we won't have seen them already on other platforms

[PATCH] target/rx: Fix compiler errors for build with sanitizers

2021-01-28 Thread Stefan Weil
d uninitialized in this function [-Werror=maybe-uninitialized] 318 | env->psw_c = (tmp <= env->regs[2]); | ~^~~~ Rewriting the code fixes those errors. Signed-off-by: Stefan Weil --- Those error are false positives, but simple code changes help t

[PATCH] tests: Replace deprecated ASN1 code

2021-01-28 Thread Stefan Weil
This fixes several compiler warnings on MacOS with Homebrew. Signed-off-by: Stefan Weil --- tests/crypto-tls-x509-helpers.c | 10 +- tests/crypto-tls-x509-helpers.h | 2 +- tests/pkix_asn1_tab.c | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tests

[PATCH] tests: Fix runtime error in test-authz-pam

2021-01-28 Thread Stefan Weil
:2: note: nonnull attribute specified here Signed-off-by: Stefan Weil --- tests/test-authz-pam.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/test-authz-pam.c b/tests/test-authz-pam.c index 1baeadee03..4fe1ef2603 100644 --- a/tests/test-authz-pam.c +++ b

Re: [PATCH v6 00/11] hvf: Implement Apple Silicon Support

2021-01-28 Thread Stefan Weil
Am 20.01.21 um 23:44 schrieb Alexander Graf: Now that Apple Silicon is widely available, people are obviously excited to try and run virtualized workloads on them, such as Linux and Windows. This patch set implements a fully functional version to get the ball going on that. With this applied,

Re: [PATCH 21/23] tcg/tci: Remove dead code for TCG_TARGET_HAS_div2_*

2021-01-28 Thread Stefan Weil
Am 28.01.21 um 09:23 schrieb Richard Henderson: We do not simultaneously support div and div2 -- it's one or the other. TCI is already using div, so remove div2. Signed-off-by: Richard Henderson --- tcg/tci.c| 12 tcg/tci/tcg-target.c.inc | 16

[PATCH] tests/tcg: Replace /bin/true by true (required on macOS)

2021-01-28 Thread Stefan Weil
/bin/true is missing on macOS, but simply "true" is available as a shell builtin. Signed-off-by: Stefan Weil --- A similar change might be needed for tests/qemu-iotests. Regards, Stefan tests/tcg/Makefile.qemu | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 20/23] tcg/tci: Use g_assert_not_reached

2021-01-28 Thread Stefan Weil
-by: Stefan Weil

Re: [PATCH 22/23] tcg/tci: Implement 64-bit division

2021-01-28 Thread Stefan Weil
s[1]); Thanks. See my comment above where I suggest a slight modification. Reviewed-by: Stefan Weil

[Bug 1898011] Re: mmap MAP_NORESERVE of 2^42 bytes consumes 16Gb of actual RAM

2021-01-28 Thread Stefan Weil
The problem occurs for example with any program which was compiled with the address sanitizer. A simple hello program compiled with "gcc -fsanitize=address hello.c" is sufficient to show the problem. Just run it with "qemu-x86_64 a.out". It will be killed by the Linux kernel OOM handler even on a

qemu user mode fails to run programs with large VM / built with address sanitizer (was: Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available)

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 22:47 schrieb Alex Bennée: Stefan Weil writes: I recently tried running tesseract with qemu-x86_64 because I had expected that it might trigger some unimplemented TCG opcodes. qemu-x86-64 is a poor choice as a relatively under maintained front-end doesn't emulate

[PATCH] tcg/tci: Implement INDEX_op_ld16s_i32

2021-01-27 Thread Stefan Weil
That TCG opcode is used by debian-buster (arm64) running ffmpeg: qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm Reported-by: Alex Bennée Signed-off-by: Stefan Weil --- tcg/tci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index

[PATCH] tcg/tci: Implement INDEX_op_ld16s_i32

2021-01-27 Thread Stefan Weil
That TCG opcode is used by debian-buster (arm64) running ffmpeg: qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm Reported-by: Alex Bennée Signed-off-by: Stefan Weil --- tcg/tci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 22:47 schrieb Alex Bennée: Your just going to end up playing wack-a-mole: TODO ../../tcg/tci.c:620: tcg_qemu_tb_exec()me=00:00:00.00 bitrate=N/A speed= 0x ../../tcg/tci.c:620: tcg fatal error qemu: uncaught target signal 11 (Segmentation fault) - core dumped

[PATCH v2] tcg/tci: Implement INDEX_op_ld8s_i64

2021-01-27 Thread Stefan Weil
That TCG opcode is used by debian-buster (arm64) running ffmpeg: qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm Reported-by: Alex Bennée Signed-off-by: Stefan Weil --- v2: Fixed as suggested by Richard Henderson Thank you, Stefan tcg/tci.c | 5 - 1 file changed, 4

[PATCH] tcg/tci: Implement INDEX_op_ld8s_i64

2021-01-27 Thread Stefan Weil
That TCG opcode is used by debian-buster (arm64) running ffmpeg: qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm Reported-by: Alex Bennée Signed-off-by: Stefan Weil --- tcg/tci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 20:42 schrieb Stefan Weil: Am 27.01.21 um 19:59 schrieb Daniel P. Berrangé: On Wed, Jan 27, 2021 at 07:56:16PM +0100, Stefan Weil wrote: It returns ASN1_MEM_ERROR, so the input vector is too small. Hmm, that's odd - "Value is not valid" corresponds to ASN1_VALUE

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 20:52 schrieb Alex Bennée: For example - debian-buster (arm64) running ffmpeg: alex.bennee@8cd150a4b35d:~/lsrc/qemu.git/builds/all.tci$ ./qemu-aarch64 /usr/bin/ffmpeg -i theora.mkv theora.webm TODO ../../tcg/tci.c:882: tcg_qemu_tb_exec() ../../tcg/tci.c:882: tcg fatal

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 19:59 schrieb Daniel P. Berrangé: On Wed, Jan 27, 2021 at 07:56:16PM +0100, Stefan Weil wrote: It returns ASN1_MEM_ERROR, so the input vector is too small. Hmm, that's odd - "Value is not valid" corresponds to ASN1_VALUE_NOT_VALID error code. I now have buil

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 19:17 schrieb Daniel P. Berrangé: On Wed, Jan 27, 2021 at 06:05:08PM +0100, Stefan Weil wrote: Am 27.01.21 um 17:53 schrieb Daniel P. Berrangé: In $QEMU.git/crypto/init.c can you uncomment the "#define DEBUG_GNUTLS" line and then re-build and re-run the test case

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 17:53 schrieb Daniel P. Berrangé: In $QEMU.git/crypto/init.c can you uncomment the "#define DEBUG_GNUTLS" line and then re-build and re-run the test case. There's a bunch of debug logs in code paths from gnutls_x509_crt_privkey_sign that might give us useful info. Regards,

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-01-27 Thread Stefan Weil
Am 27.01.21 um 13:17 schrieb Daniel P. Berrangé: On Tue, Jan 26, 2021 at 04:41:13PM +, Peter Maydell wrote: On Tue, 26 Jan 2021 at 16:37, Daniel P. Berrangé wrote: On Tue, Jan 26, 2021 at 04:32:08PM +, Peter Maydell wrote: ** (tests/test-crypto-tlscredsx509:35180): CRITICAL **:

[PATCH v2] tcg/tci: Fix some unaligned memory accesses

2021-01-27 Thread Stefan Weil
Signed-off-by: Stefan Weil --- v2: Use inline functions from qemu/bswap.h instead of memcpy as suggested by Richard. tcg/tci.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tcg/tci.c b/tcg/tci.c index 42354d8ebb..ddbb259e1d 100644 --- a/tcg/tci.c +++ b/tcg

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 26.01.21 um 23:39 schrieb Richard Henderson: On 1/26/21 9:44 AM, Stefan Weil wrote: I was not talking about the TODO assertions. When I wrote TCI, I only enabled and included code which was triggered by my testing - that's why I said the productive code lines have 100 % test coverage. TODO

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 26.01.21 um 21:07 schrieb Paolo Bonzini: On 26/01/21 20:44, Stefan Weil wrote: Yes, I tested with latest git master and did not notice that --enable-tcg-interpreter was broken. Paolo's patch fixed that.I could reproduce the fatal assertions which were all caused by the same missing TCG

Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter

2021-01-26 Thread Stefan Weil
hieu-Daudé Message-Id: <2021012429.35563-1-richard.hender...@linaro.org> Signed-off-by: Philippe Mathieu-Daudé --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Tested-by: Stefan Weil Thanks, Stefan

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 26.01.21 um 18:24 schrieb Alex Bennée: I'm going to go out on a limb and guess you have commit: 23a77b2d18 (build-system: clean up TCG/TCI configury) which temporarily has the effect of disabling TCI. See Subject: Re: [PATCH v4 1/4] configure: Fix --enable-tcg-interpreter From:

[PATCH] tcg/tci: Implement INDEX_op_ld16u_i32

2021-01-26 Thread Stefan Weil
This fixes `make check-tcg`. Signed-off-by: Stefan Weil --- tcg/tci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index 2311aa7d3a..42354d8ebb 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -611,7 +611,10 @@ uintptr_t QEMU_DISABLE_CFI

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 25.01.21 um 23:35 schrieb Richard Henderson: On 1/25/21 11:02 AM, Stefan Weil wrote: Am 25.01.21 um 20:02 schrieb Richard Henderson: On 1/25/21 8:58 AM, Stefan Weil wrote: I have no evidence that TCI is less reliable than TCG, so I would not write that. It can't pass make check-tcg

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Stefan Weil
Am 25.01.21 um 20:02 schrieb Richard Henderson: On 1/25/21 8:58 AM, Stefan Weil wrote: I have no evidence that TCI is less reliable than TCG, so I would not write that. It can't pass make check-tcg. Where does it fail? Maybe an expected timeout problem which can be solved by increasing

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Stefan Weil
native TCG backend is available on the host architecture, mentioning this is a suboptimal configuration. Reviewed-by: Stefan Weil Reviewed-by: Thomas Huth Nitpick, the text printed is completely rewritten from what they reviewed, so I would probably have dropped their R-b for that scenario. I

Re: [PATCH] tcg/tci: Restrict tci_write_reg16() to 64-bit hosts

2021-01-23 Thread Stefan Weil
d via qemu-trivial. Reviewed-by: Stefan Weil

Re: [RFC PATCH 2/2] gitlab-ci: Add a job building TCI with Clang

2021-01-23 Thread Stefan Weil
Am 23.01.21 um 09:59 schrieb Wataru Ashihara: Actually I use TCI also on macOS. Like the use case quoted by Philippe, there're even other reasons to use TCI: 1. Learning TCG ops. 2. Debugging QEMU with gdb. e.g. diagnose codegen or stepping into helper functions from

Re: [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available

2021-01-22 Thread Stefan Weil
nto --disable-native-tcg ;-)  Thomas Both patches are fine (also optionally with the suggested addition of "slow"), so Reviewed-by: Stefan Weil I think that --enable-tci would increase the TCI/TCG confusion and suggest to keep the current --enable-tcg-interpreter as most exp

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Stefan Weil
Am 15.01.21 um 16:19 schrieb Peter Maydell: On Fri, 15 Jan 2021 at 14:01, Peter Maydell wrote: I was just trying to see what updates the qemu.nsi file needed for the merge-all-the-manuals-into-one-place change, and I discovered that it's been broken since October when we removed the Changelog

Re: Windows installer builds apparently broken since October?

2021-01-15 Thread Stefan Weil
Am 15.01.21 um 15:01 schrieb Peter Maydell: I was just trying to see what updates the qemu.nsi file needed for the merge-all-the-manuals-into-one-place change, and I discovered that it's been broken since October when we removed the Changelog file: File: "/tmp/qemu-test/src\Changelog" -> no

Re: [PATCH] configure: Add flags for MinGW32 standalone build

2021-01-10 Thread Stefan Weil
Am 11.01.21 um 08:04 schrieb Thomas Huth: On 08/01/2021 19.30, Joshua Watt wrote: On 1/8/21 1:25 AM, Thomas Huth wrote: On 07/01/2021 22.38, Joshua Watt wrote: There are two cases that need to be accounted for when compiling QEMU for MinGW32:   1) A standalone distribution, where QEMU is

Re: Various spelling fixes

2020-12-23 Thread Stefan Weil
mu_log("vector verison is not specified, " + qemu_log("vector version is not specified, " With both additional modification (see comments above) which can be applied before merging (no need to resend the patch) Reviewed-by: Stefan Weil

Re: [PATCH for-5.2] nsis: Fix build for 64 bit installer

2020-11-25 Thread Stefan Weil
Am 25.11.20 um 20:28 schrieb Peter Maydell: On Wed, 25 Nov 2020 at 19:23, Stefan Weil wrote: Pass cpu instead of cpu_family to the NSIS installer script. That script checks for "x86_64" which is the cpu value, while cpu_family is "x86". Signed-off-by: Stefan Weil -

[PATCH for-5.2] nsis: Fix build for 64 bit installer

2020-11-25 Thread Stefan Weil
Pass cpu instead of cpu_family to the NSIS installer script. That script checks for "x86_64" which is the cpu value, while cpu_family is "x86". Signed-off-by: Stefan Weil --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build

Re: Regressions in build process introduced since August

2020-11-23 Thread Stefan Weil
Am 23.11.20 um 17:20 schrieb Paolo Bonzini: On 23/11/20 16:41, Daniel P. Berrangé wrote: Relying on pkg-config should be our strong preference. I expect we're doing the old fashioned library check just for historical reasons, but even RHEL-7 supports pkg-config for libjpeg. So I think we're

Re: Regressions in build process introduced since August

2020-11-23 Thread Stefan Weil
Am 23.11.20 um 14:55 schrieb Paolo Bonzini: On 21/11/20 12:09, Stefan Weil wrote: --- a/meson.build +++ b/meson.build @@ -649,9 +649,8 @@ if get_option('vnc').enabled()     vnc = declare_dependency() # dummy dependency     png = dependency('libpng', required: get_option('vnc_png

Re: Regressions in build process introduced since August

2020-11-21 Thread Stefan Weil
One more regression: a lot of build targets are no longer supported with the new meson based build. Personally I am missing `make install-doc` and found no good replacement up to now. Regards, Stefan

Re: Regressions in build process introduced since August

2020-11-21 Thread Stefan Weil
Am 21.11.20 um 11:25 schrieb Stefan Weil: Hi, I just noticed another regression: A cross build targeting Windows no longer detects VNC JPEG support. Using pkg-config like in the patch below would fix that (and also works for native builds on Debian GNU Linux). Maybe the current

Re: Regressions in build process introduced since August

2020-11-21 Thread Stefan Weil
Hi, I just noticed another regression: A cross build targeting Windows no longer detects VNC JPEG support. Using pkg-config like in the patch below would fix that (and also works for native builds on Debian GNU Linux). Maybe the current find_library ignores --extra-cflags and

Re: Peter Maydell

2020-11-20 Thread Stefan Weil
Am 20.11.20 um 09:54 schrieb Paolo Bonzini: On 20/11/20 09:44, Liviu Ionescu wrote: On 20 Nov 2020, at 07:43, cavinnarsingh...@gmail.com wrote: This issue is about the Qemu Will the Qemu work on the new m1 macbook pro? And if yes, when will the arm version of Qemu be available for public I

Re: Regressions in build process introduced since August

2020-11-18 Thread Stefan Weil
Am 18.11.20 um 16:34 schrieb Daniel P. Berrangé: On Sun, Nov 15, 2020 at 11:57:25AM +0100, Stefan Weil wrote: *** Setting INSTALLER no longer handled meson.build sets a hard name for the Windows installer executable: installer = 'qemu-setup-' + meson.project_version() + '.exe'. Previously

[PATCH for-5.2] meson: Fix build with --disable-guest-agent-msi

2020-11-17 Thread Stefan Weil
The QGA MSI target requires several macros which are only available without --disable-guest-agent-msi. Don't define that target if configure was called with --disable-guest-agent-msi. Signed-off-by: Stefan Weil --- qga/meson.build | 36 +++- 1 file changed, 19

Re: Regressions in build process introduced since August

2020-11-17 Thread Stefan Weil
Am 17.11.20 um 19:01 schrieb Paolo Bonzini: On 17/11/20 18:50, Stefano Garzarella wrote: Running `configure [...] --extra-cflags="-I /xyz"` results in compiler flags `-I [...] /xyz`, so the `-I` and `/xyz` are separated by other compiler flags which obviously cannot work as expected. I could

[PATCH for-5.2] docs: Fix some typos (found by codespell)

2020-11-17 Thread Stefan Weil
Fix also a similar typo in a code comment. Signed-off-by: Stefan Weil --- docs/can.txt | 8 docs/interop/vhost-user.rst | 2 +- docs/replay.txt | 2 +- docs/specs/ppc-spapr-numa.rst | 2 +- docs/system/deprecated.rst| 4 ++-- docs/tools

[PATCH for-5.2] meson: Fix argument for makensis (build regression)

2020-11-17 Thread Stefan Weil
`make installer` with a DLL directory was broken. Signed-off-by: Stefan Weil --- scripts/nsis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/nsis.py b/scripts/nsis.py index e1c409344e..5135a05831 100644 --- a/scripts/nsis.py +++ b/scripts/nsis.py @@ -65,7 +65,7

Regressions in build process introduced since August

2020-11-15 Thread Stefan Weil
installer executable can be set? Or how could I reimplement the lost functionality? Kind regards Stefan Weil

Re: [PATCH 24/30] w32: Fix Lesser GPL version number

2020-10-23 Thread Stefan Weil
ion. + * version 2.1 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of LGPL 2.0 was the GNU Library General Public License, but in COPYING.LIB we already use LGPL 2.1, so Reviewed-by: Stefan Weil

Re: [PATCH v3] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2020-10-18 Thread Stefan Weil
} +_aligned_free(ptr); } void qemu_anon_ram_free(void *ptr, size_t size) Thanks. Reviewed-by: Stefan Weil

Re: [PATCH v2] mingw: fix error __USE_MINGW_ANSI_STDIO redefined

2020-10-08 Thread Stefan Weil
-#include #include "qemu/osdep.h" #include "qemu/bitmap.h" Reviewed-by: Stefan Weil Thank you, Stefan

Re: [RFC PATCH] contrib/gitdm: Add more individual contributors

2020-10-04 Thread Stefan Weil
Roeck Cc: Helge Deller Cc: Hervé Poussineau Cc: James Hogan Cc: Jean-Christophe Dubois Cc: Kővágó Zoltán Cc: Laurent Vivier Cc: Michael Rolnik Cc: Niek Linnenbank Cc: Paul Burton Cc: Paul Zimmerman Cc: Stefan Weil Cc: Subbaraya Sundeep Cc: Sven Schnelle Cc: Thomas Huth Cc: Volker Rümelin

Re: [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign

2020-09-15 Thread Stefan Weil
Am 16.09.20 um 02:46 schrieb Richard Henderson: > We do not need or want to be allocating page sized quanta. > > Signed-off-by: Richard Henderson > --- > Cc: Stefan Weil > --- > util/oslib-win32.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) >

Re: [PATCH 0/5] qom: Allow object to be aligned

2020-09-15 Thread Stefan Weil
Am 16.09.20 um 00:47 schrieb Richard Henderson: > On 9/15/20 10:46 AM, Richard Henderson wrote: >> We already have a function that can alloc with alignment, >> but we need to pass this down from the structure. We also >> don't want to use this function unconditionally, because >> the windows

Re: [PATCH v8 24/27] ci: Enable msys2 ci in cirrus

2020-09-14 Thread Stefan Weil
Am 14.09.20 um 09:38 schrieb Thomas Huth: > On 13/09/2020 00.44, Yonggang Luo wrote: >> Install msys2 in a proper way refer to >> https://github.com/cirruslabs/cirrus-ci-docs/issues/699 >> The https://wiki.qemu.org/Hosts/W32#Native_builds_with_MSYS2 need to be >> updated. > I don't think that a

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

2020-09-14 Thread Stefan Weil
hard to read. Thanks, Stefan Weil

Re: [PATCH v2] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Stefan Weil
gt; +fi > +if test "$whpx" != "no" && test "$ARCH" = "x86_64"; then > if check_include "WinHvPlatform.h" && check_include "WinHvEmulation.h"; > then > whpx="yes" > else Reviewed-by: Stefan Weil Thanks!

Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host

2020-09-09 Thread Stefan Weil
Am 09.09.20 um 20:40 schrieb Thomas Huth: > On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote: >> Hyper-V is available on 64-bit versions of Windows, >> do not try to build its support on 32-bit versions. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> configure | 3 +++ >> 1 file

Re: [PATCH 1/2] tests: Trying fixes test-replication.c on msys2/mingw.

2020-09-05 Thread Stefan Weil
be it is possible to use get_tmp_filename() (which could be simplified by using g_get_tmp_dir). And please use snprintf instead of sprintf. I am afraid that a path can be longer than PATH_MAX, even if the tmpdir path is normally rather short. You could also allocate the different filenames dynamically instead of limiting them to PATH_MAX characters. Regards Stefan Weil

Re: [PATCH] meson: add pixman dependency to UI modules

2020-08-30 Thread Stefan Weil
build target, especially UI modules that need > it due to their including ui/console.h. > > Reported-by: Stefan Weil > Signed-off-by: Paolo Bonzini > --- > ui/meson.build | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Tested-by: Stefan Weil chardev/baum.c still fai

[PATCH] meson: add pixman dependency to chardev/baum module

2020-08-30 Thread Stefan Weil
Signed-off-by: Stefan Weil --- Together with Paolo's patch (https://patchwork.kernel.org/patch/11745207/) this fixed the build with --enable-modules for me. Stefan chardev/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/meson.build b/chardev

Re: [PATCH] meson: move pixman detection to meson

2020-08-30 Thread Stefan Weil
Am 26.08.20 um 09:02 schrieb Paolo Bonzini: > When pixman is not installed (or too old), but virglrenderer is available > and "configure" has been run with "--disable-system", the build currently > aborts when trying to compile vhost-user-gpu (since it requires pixman). > > Let's skip the build

[PATCH] libvhost-user: Add GCC_FMT_ATTR and fix format string

2020-08-27 Thread Stefan Weil
Signed-off-by: Stefan Weil --- contrib/libvhost-user/libvhost-user.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c index 53f16bdf08..ff7ac876f4 100644 --- a/contrib/libvhost-user/libvhost

[PATCH] main-loop: Fix comment

2020-08-27 Thread Stefan Weil
Signed-off-by: Stefan Weil --- include/qemu/main-loop.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/main-loop.h b/include/qemu/main-loop.h index 8e98613656..d6892fd208 100644 --- a/include/qemu/main-loop.h +++ b/include/qemu/main-loop.h @@ -52,7 +52,7 @@ int

[PATCH] docs/system: Fix grammar in documentation

2020-08-27 Thread Stefan Weil
Signed-off-by: Stefan Weil --- docs/system/build-platforms.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/system/build-platforms.rst b/docs/system/build-platforms.rst index c2b92a9698..9734eba2f1 100644 --- a/docs/system/build-platforms.rst +++ b/docs/system

Re: [PATCH 11/11] dockerfiles/debian-win64-cross: Download WHPX MinGW headers

2020-08-04 Thread Stefan Weil
Am 04.08.20 um 19:00 schrieb Thomas Huth: > To compile-test the WHPX accelerator, we need to download these system > headers first (they are unfortunately not part of any released and > packaged MinGW toolchain yet). > > Idea taken from another patch by Stefan Weil. > > Signe

Re: [PATCH 10/11] configure: Allow automatic WHPX detection

2020-08-04 Thread Stefan Weil
nfigure > +++ b/configure > @@ -809,6 +809,7 @@ case $targetos in > MINGW32*) >mingw32="yes" >hax="yes" > + whpx="" >vhost_user="no" >audio_possible_drivers="dsound sdl" >if check_include dsound.h; then Reviewed-by: Stefan Weil

Re: [RFC PATCH 3/3] .github/workflows: Use matrix strategy to parallelize builds

2020-08-04 Thread Stefan Weil
Hi Philippe, just a side note: GitHub action runs parallel jobs by default. I use two jobs (32 and 64 bit builds), so both are built at the same time, see https://github.com/stweil/qemu/actions. Regards, Stefan Am 04.08.20 um 10:48 schrieb Philippe Mathieu-Daudé: > Using sequencial builds,

Re: [PATCH for-5.1] Add GitHub action for Windows build

2020-08-04 Thread Stefan Weil
Am 04.08.20 um 09:29 schrieb Philippe Mathieu-Daudé: > But I'm not keen on not using GitLab instead. > > The only point I see of using GitHub/Azureus is if we then install > and run testing in the Windows Server 2019 environment: > >

Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-04 Thread Stefan Weil
Am 04.08.20 um 09:23 schrieb Philippe Mathieu-Daudé: > On 8/4/20 8:55 AM, Stefan Weil wrote: >> Am 04.08.20 um 08:43 schrieb Thomas Huth: >> >>> On 03/08/2020 22.25, Stefan Weil wrote: >>>> We can add a CI pipeline on Microsoft infrastructure by using a Git

Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-04 Thread Stefan Weil
Am 04.08.20 um 08:43 schrieb Thomas Huth: > On 03/08/2020 22.25, Stefan Weil wrote: >> We can add a CI pipeline on Microsoft infrastructure by using a GitHub >> action. > Sorry for being ignorant, but how does that solve the legal questions > just because it is runn

Re: [PATCH v2 0/3] testing: Build WHPX enabled binaries

2020-08-03 Thread Stefan Weil
Am 03.08.20 um 13:28 schrieb Stefan Weil: > Am 03.08.20 um 12:51 schrieb Philippe Mathieu-Daudé: > >> Hi Sunil, >> >> On 8/1/20 1:31 AM, Sunil Muthuswamy wrote: >>> The ask generally sounds reasonable. But, can you help me understand the >>> full

[PATCH for-5.1] Add GitHub action for Windows build

2020-08-03 Thread Stefan Weil
The GitHub action is restricted to https://github.com/qemu/qemu. Signed-off-by: Stefan Weil --- This patch adds a GitHub action for continuous integration builds of QEMU for Windows. The CI builds run on GitHub and include the WHPX code. The action rules avoid unnecessary waste of resources

<    1   2   3   4   5   6   7   8   9   10   >