Re: [Qemu-devel] [PATCH] xen/pt: Set is_express to avoid out-of-bounds write

2017-12-08 Thread Stefano Stabellini
here: > #0 0x7ff596a94bb8 in __interceptor_calloc > (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xd9bb8) > #1 0x7ff57da66580 in g_malloc0 > (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x50580) > #2 0x55e0fdda7d3d in device_set_realized hw/core/qdev.c:914 > [...] > > Signed

Re: [Qemu-devel] [PATCH 00/12] Refactor get_phys_addr() not to return FSR values

2017-12-08 Thread Stefano Stabellini
x27;ve pushed it > to this git branch if that's more convenient: > > https://git.linaro.org/people/peter.maydell/qemu-arm.git fsr-in-faultinfo > > I have tested a bit (including a Linux KVM EL2 setup), but more > testing would definitely be useful. Stefano: in pa

Re: [Qemu-devel] [PATCH v3] xen-disk: use an IOThread per instance

2017-11-15 Thread Stefano Stabellini
On Wed, 15 Nov 2017, Paul Durrant wrote: > Anthony, Stefano, > > Ping? Acked-by: Stefano Stabellini Unless Anthony or somebody else object, I'll queue it up in my "next" branch (which I'll send upstream after 2.11 is out). Cheers, Stefano > > -O

Re: [Qemu-devel] [PATCH for-2.11] target/arm: Report GICv3 sysregs present in ID registers if needed

2017-11-07 Thread Stefano Stabellini
lized. This > means that we don't know at the point when we define the ID > registers what the correct value is. Handle this by switching > them to calling a function at runtime to read the value, where > we can fill in the GIC field appropriately. > > Signed-off-by: Peter May

Re: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-07 Thread Stefano Stabellini
On Tue, 7 Nov 2017, Peter Maydell wrote: > On 6 November 2017 at 22:16, Stefano Stabellini > wrote: > > When QEMU emulates a GICv3, it needs to advertise the presence of the > > system register interface, which is done via id_aa64pfr0. > > > > To do that,

[Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-06 Thread Stefano Stabellini
machvirt_init. Check on the boolean property from register_cp_regs_for_features and set id_aa64pfr0 accordingly. Signed-off-by: Stefano Stabellini diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 9e18b41..369d36b 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1401,6 +1401,9 @@ static void

Re: [Qemu-devel] [PATCH] arm: check regime, not current state, for ATS write PAR format

2017-11-03 Thread Stefano Stabellini
on regime. In particular, > this is necessary for Xen to be able to run in our emulation, > so this seems like a safer interim fix given that we are in freeze. > > Signed-off-by: Peter Maydell Tested-by: Stefano Stabellini > --- > I guess I should have a go at the "c

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 31 October 2017 at 18:51, Stefano Stabellini > wrote: > > On Tue, 31 Oct 2017, Peter Maydell wrote: > >> On 31 October 2017 at 17:01, Stefano Stabellini > >> wrote: > >> > Fixing QEMU is harder than

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 31 October 2017 at 17:01, Stefano Stabellini > wrote: > > Fixing QEMU is harder than I expected. Would it be possible to update > > id_aa64pfr0 at CPU reset time? Like cpu->id_aa64pfr0 |= 0x0100; ? > > At that

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 31 October 2017 at 17:07, Stefano Stabellini > wrote: > > Sorry Peter, I copy/pasted the values from arm32/page.h instead of > > arm64/page.h in Xen :-/ > > > > Xen is running at EL2, 64-bit (aarch64). The ATS instruct

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 30 October 2017 at 22:57, Stefano Stabellini > wrote: > > On Mon, 30 Oct 2017, Peter Maydell wrote: > >> What's the specific situation/bug that you're trying to fix with > >> this patch? You don't say in

Re: [Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-31 Thread Stefano Stabellini
On Tue, 31 Oct 2017, Peter Maydell wrote: > On 19 October 2017 at 15:46, Peter Maydell wrote: > > On 18 October 2017 at 01:10, Stefano Stabellini > > wrote: > >> Advertise the presence of the GIC system register interface (1<<24) > >> according to H9.2

Re: [Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-30 Thread Stefano Stabellini
On Mon, 30 Oct 2017, Peter Maydell wrote: > On 26 October 2017 at 00:28, Stefano Stabellini > wrote: > > extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception > > level 1. Instead, add an additional "el" argument to > > extended_addresses_enabled

Re: [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-27 Thread Stefano Stabellini
On Fri, 27 Oct 2017, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH v5.1 2/8] xen: restrict: use > xentoolcore_restrict_all"): > > On Fri, 20 Oct 2017, Ian Jackson wrote: > ... > > > Drop individual use of xendevicemodel_restrict and > > >

[Qemu-devel] [PULL 1/3] xen: add a global indicator for grant copy being available

2017-10-26 Thread Stefano Stabellini
: Stefano Stabellini --- hw/block/xen_disk.c | 18 ++ hw/xen/xen_backend.c | 11 +++ include/hw/xen/xen_backend.h | 1 + 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 536e2ee..62506e3

[Qemu-devel] [PULL 2/3] xen: dont try setting max grants multiple times

2017-10-26 Thread Stefano Stabellini
boot it. So instead of letting the generic backend code open the gnttab device do it in blk_connect() and close it again in blk_disconnect. Signed-off-by: Juergen Gross Acked-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/block/xen_disk.c | 16 1 file changed, 12

[Qemu-devel] [PULL 3/3] xen: Log errno rather than return value

2017-10-26 Thread Stefano Stabellini
From: Ross Lagerwall xen_modified_memory() sets errno to communicate what went wrong so log this rather than the return value which is not interesting. Signed-off-by: Ross Lagerwall Acked-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/i386/xen/xen-hvm.c | 2 +- 1 file changed

[Qemu-devel] [PULL 0/3] xen-20171026-tag

2017-10-26 Thread Stefano Stabellini
The following changes since commit 325a084c1ebccb265a3c8f1dd092ffbbfb448a00: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2017-10-24-1' into staging (2017-10-26 09:20:11 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

Re: [Qemu-devel] [PATCH v5.1 5/8] xen: move xc_interface compatibility fallback further up the file

2017-10-26 Thread Stefano Stabellini
> Signed-off-by: Ian Jackson > Acked-by: Anthony PERARD Acked-by: Stefano Stabellini > --- > v2: New patch in v2 of the series > --- > include/hw/xen/xen_common.h | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/include/hw/xen

Re: [Qemu-devel] [PATCH v5.1 1/8] xen: link against xentoolcore

2017-10-26 Thread Stefano Stabellini
restrict_all(0); > >return 0; > } > EOF > -compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs" > +compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs > -lxentoolcore" > then > -

Re: [Qemu-devel] [PATCH v5.1 7/8] os-posix: Provide new -runas : facility

2017-10-26 Thread Stefano Stabellini
CC'ing the maintainers (scripts/get_maintainer.pl is your friend) On Fri, 20 Oct 2017, Ian Jackson wrote: > This allows the caller to specify a uid and gid to use, even if there > is no corresponding password entry. This will be useful in certain > Xen configurations. > > We don't support just -

Re: [Qemu-devel] [PATCH v5.1 8/8] configure: do_compiler: Dump some extra info under bash

2017-10-26 Thread Stefano Stabellini
CC'ing the maintainers for this. On Fri, 20 Oct 2017, Ian Jackson wrote: > This makes it much easier to find a particular thing in config.log. > > The information may be lacking in other shells, resulting in harmless > empty output. (This is why we don't use the proper ${FUNCNAME[*]} > array syn

Re: [Qemu-devel] [PATCH v5.1 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > xc_interface_open etc. is not going to work if we have dropped > privilege, but xendevicemodel_shutdown will if everything is new > enough. > > xendevicemodel_shutdown is only availabe in Xen 4.10 and later, so > provide a stub for earlier versions. > > S

Re: [Qemu-devel] [PATCH v5.1 3/8] xen: defer call to xen_restrict until just before os_setup_post

2017-10-26 Thread Stefano Stabellini
This patch affects non-Xen components. CC'ing the relevant maintainers. On Fri, 20 Oct 2017, Ian Jackson wrote: > We need to restrict *all* the control fds that qemu opens. Looking in > /proc/PID/fd shows there are many; their allocation seems scattered > throughout Xen support code in qemu. > >

Re: [Qemu-devel] [PATCH v5.1 4/8] xen: destroy_hvm_domain: Move reason into a variable

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > We are going to want to reuse this. > > No functional change. > > Signed-off-by: Ian Jackson > Reviewed-by: Anthony PERARD Acked-by: Stefano Stabellini > --- > hw/i386/xen/xen-hvm.c | 5 +++-- > 1 file changed, 3

Re: [Qemu-devel] [PATCH v5.1 2/8] xen: restrict: use xentoolcore_restrict_all

2017-10-26 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Ian Jackson wrote: > And insist that it works. > > Drop individual use of xendevicemodel_restrict and > xenforeignmemory_restrict. These are not actually effective in this > version of qemu, because qemu has a large number of fds open onto > various Xen control devices. > >

[Qemu-devel] [PATCH v2] don't hardcode EL1 in extended_addresses_enabled

2017-10-25 Thread Stefano Stabellini
_target_el(env), as the target el for a debug trap can be different from the current el. Signed-off-by: Stefano Stabellini diff --git a/target/arm/helper.c b/target/arm/helper.c index 96113fe..2298428 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -500,7 +500,7 @@ static void contex

Re: [Qemu-devel] [PATCH v3] fix WFI/WFE length in syndrome register

2017-10-25 Thread Stefano Stabellini
On Wed, 25 Oct 2017, Peter Maydell wrote: > On 24 October 2017 at 18:59, Stefano Stabellini > wrote: > > WFI/E are often, but not always, 4 bytes long. When they are, we need to > > set ARM_EL_IL_SHIFT in the syndrome register. > > > > Pass the instruction le

[Qemu-devel] [PATCH v3] fix WFI/WFE length in syndrome register

2017-10-24 Thread Stefano Stabellini
in both arm_tr_translate_insn and thumb_tr_translate_insn. Signed-off-by: Stefano Stabellini --- Changes in v3: - free tmp - wfi on aarch64 is always 4 bytes - set dc->insn in arm_tr_translate_insn and thumb_tr_translate_insn - also check for dc->thumb in arm_tr_tb_stop diff --git a/t

Re: [Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

2017-10-24 Thread Stefano Stabellini
On Tue, 24 Oct 2017, Stefano Stabellini wrote: > On Tue, 24 Oct 2017, Peter Maydell wrote: > > On 24 October 2017 at 16:53, Peter Maydell wrote: > > > On 21 October 2017 at 19:09, Stefano Stabellini > > > wrote: > > >> diff --git a/target/arm/translate.

Re: [Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

2017-10-24 Thread Stefano Stabellini
On Tue, 24 Oct 2017, Peter Maydell wrote: > On 24 October 2017 at 16:53, Peter Maydell wrote: > > On 21 October 2017 at 19:09, Stefano Stabellini > > wrote: > >> diff --git a/target/arm/translate.c b/target/arm/translate.c > >> index 4da1a4c..a89518f 100644

Re: [Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

2017-10-23 Thread Stefano Stabellini
On Sat, 21 Oct 2017, no-re...@patchew.org wrote: > Makefile:30: recipe for target 'git-submodule-update' failed > make: *** [git-submodule-update] Error 1 > make: *** Waiting for unfinished jobs > make: *** wait: No child processes. Stop. > === OUTPUT END === > > Test command exited with code

[Qemu-devel] [PATCH v2] fix WFI/WFE length in syndrome register

2017-10-21 Thread Stefano Stabellini
: Stefano Stabellini diff --git a/target/arm/helper.h b/target/arm/helper.h index 2cf6f74..439d228 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -48,7 +48,7 @@ DEF_HELPER_FLAGS_3(sel_flags, TCG_CALL_NO_RWG_SE, DEF_HELPER_2(exception_internal, void, env, i32) DEF_HELPER_4

Re: [Qemu-devel] [PATCH] fix WFI/WFE length in syndrome register

2017-10-21 Thread Stefano Stabellini
On Fri, 20 Oct 2017, Peter Maydell wrote: > On 19 October 2017 at 21:56, Stefano Stabellini > wrote: > > On Thu, 19 Oct 2017, Peter Maydell wrote: > >> On 18 October 2017 at 23:03, Stefano Stabellini > >> wrote: > >> > WFI/E are 4 bytes

Re: [Qemu-devel] [PATCH] don't hardcode EL1 in extended_addresses_enabled

2017-10-19 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Peter Maydell wrote: > On 18 October 2017 at 23:41, Stefano Stabellini > wrote: > > extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception > > level 1. Instead, retrieve the current el calling arm_current_el. > > > > Sig

Re: [Qemu-devel] [PATCH] fix WFI/WFE length in syndrome register

2017-10-19 Thread Stefano Stabellini
On Thu, 19 Oct 2017, Peter Maydell wrote: > On 18 October 2017 at 23:03, Stefano Stabellini > wrote: > > WFI/E are 4 bytes long: set ARM_EL_IL_SHIFT in the syndrome. > > > > Signed-off-by: Stefano Stabellini > > > > diff --git a/target/arm/internals.h b/targ

[Qemu-devel] [PATCH] don't hardcode EL1 in extended_addresses_enabled

2017-10-18 Thread Stefano Stabellini
extended_addresses_enabled calls arm_el_is_aa64, hardcoding exception level 1. Instead, retrieve the current el calling arm_current_el. Signed-off-by: Stefano Stabellini diff --git a/target/arm/internals.h b/target/arm/internals.h index 1f6efef..63507d9 100644 --- a/target/arm/internals.h +++ b

[Qemu-devel] [PATCH] fix WFI/WFE length in syndrome register

2017-10-18 Thread Stefano Stabellini
WFI/E are 4 bytes long: set ARM_EL_IL_SHIFT in the syndrome. Signed-off-by: Stefano Stabellini diff --git a/target/arm/internals.h b/target/arm/internals.h index 1f6efef..cf8c966 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -398,6 +398,7 @@ static inline uint32_t

[Qemu-devel] [PATCH] aarch64: advertise the GIC system register interface

2017-10-17 Thread Stefano Stabellini
Advertise the presence of the GIC system register interface (1<<24) according to H9.248 of the ARM ARM. This patch allows Xen to boot on QEMU aarch64. Signed-off-by: Stefano Stabellini diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index 670c07a..a451763 100644 --- a/target/arm/c

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-13 Thread Stefano Stabellini
On Fri, 13 Oct 2017, Jan Beulich wrote: > >>> On 13.10.17 at 13:13, wrote: > > To Jan, Andrew, Stefano and Anthony, > > > > what do you think about allowing QEMU to build the entire guest ACPI > > and letting SeaBIOS to load it? ACPI builder code in hvmloader is > > still there and just bypassed

Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-12 Thread Stefano Stabellini
On Thu, 12 Oct 2017, Paul Durrant wrote: > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: 12 October 2017 10:26 > > To: Paul Durrant ; 'Stefano Stabellini' > > ; Anthony Perard > > Cc: qemu-devel@nongnu.o

Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-11 Thread Stefano Stabellini
On Wed, 11 Oct 2017, Anthony PERARD wrote: > On Tue, Oct 10, 2017 at 04:52:48PM -0700, Stefano Stabellini wrote: > > On Mon, 2 Oct 2017, Anthony PERARD wrote: > > > On Tue, Sep 26, 2017 at 02:43:39PM +, Owen Smith wrote: > > > > Writes "feature-raw-pointer&q

Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-10 Thread Stefano Stabellini
On Mon, 2 Oct 2017, Anthony PERARD wrote: > On Tue, Sep 26, 2017 at 02:43:39PM +, Owen Smith wrote: > > Writes "feature-raw-pointer" during init to indicate the backend > > can pass raw unscaled values for absolute axes to the frontend. > > Frontends set "request-raw-pointer" to indicate the ba

Re: [Qemu-devel] xen-pci-passthrough PCI Express support? (Re: [Xen-devel] [PATCH v2 4/5] pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices)

2017-10-03 Thread Stefano Stabellini
On Mon, 2 Oct 2017, Eduardo Habkost wrote: > On Thu, Sep 28, 2017 at 10:12:34AM -0300, Eduardo Habkost wrote: > > On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote: > > > >>> On 27.09.17 at 21:56, wrote: > > > > --- a/hw/xen/xen_pt.c > > > > +++ b/hw/xen/xen_pt.c > > > > @@ -964,6 +964,1

Re: [Qemu-devel] xen/disk: don't leak stack data via response ring

2017-09-25 Thread Stefano Stabellini
On Sun, 24 Sep 2017, Michael Tokarev wrote: > 23.09.2017 19:05, Michael Tokarev wrote: > > 28.06.2017 01:04, Stefano Stabellini wrote: > >> Rather than constructing a local structure instance on the stack, fill > >> the fields directly on the shared ring, just like oth

Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-21 Thread Stefano Stabellini
On Thu, 21 Sep 2017, Jan Beulich wrote: > >>> On 21.09.17 at 03:12, wrote: > > On Fri, 1 Sep 2017, Jan Beulich wrote: > >> --- a/hw/xen/xen_pt_msi.c > >> +++ b/hw/xen/xen_pt_msi.c > >> @@ -18,6 +18,11 @@ > >> > >> #define XEN_PT_AUTO_ASSIGN -1 > >> > >> +#ifndef XEN_DOMCTL_VMSI_X86_DEST_ID_MA

[Qemu-devel] [PULL 2/2] xen/pt: allow QEMU to request MSI unmasking at bind time

2017-09-20 Thread Stefano Stabellini
Stabellini Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.h | 1 + hw/xen/xen_pt_config_init.c | 20 ++-- hw/xen/xen_pt_msi.c | 13 ++--- 3 files changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index 191d9ca

[Qemu-devel] [PULL 1/2] xen-disk: use g_new0 to fix build

2017-09-20 Thread Stefano Stabellini
Reviewed-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/block/xen_disk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index d42ed70..536e2ee 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -1232

[Qemu-devel] [PULL 0/2] xen-20170920-tag

2017-09-20 Thread Stefano Stabellini
The following changes since commit b62b7ed0fc9c58e373b8946c9bd2e193be98dae6: Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging (2017-09-20 20:33:48 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2017092

Re: [Qemu-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-20 Thread Stefano Stabellini
On Fri, 1 Sep 2017, Jan Beulich wrote: > Xen and qemu having identical #define-s (with different names) is a > strong hint that these should have been part of the public interface > from the very start. Use them if they're available, falling back to > privately defined values only when using older

Re: [Qemu-devel] [PATCH v2] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-09-20 Thread Stefano Stabellini
Ping? On Wed, 6 Sep 2017, Anthony PERARD wrote: > On Wed, Aug 23, 2017 at 02:25:05PM +0100, Ross Lagerwall wrote: > > When the guest writes to the RTC, Xen emulates it and broadcasts a > > TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP event to all QMP monitors when > > this happens rather than ignoring

Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-09-20 Thread Stefano Stabellini
Ping? On Thu, 7 Sep 2017, Anthony PERARD wrote: > On Mon, Aug 21, 2017 at 04:12:27PM -0700, Stefano Stabellini wrote: > > Anthony, > > > > The code looks good. I tested this patch with Linux guests and seems to > > work OK, can you also confirm? > > I've t

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-09-11 Thread Stefano Stabellini
CC'ing xen-devel, and the Xen tools and x86 maintainers. On Mon, 11 Sep 2017, Igor Mammedov wrote: > On Mon, 11 Sep 2017 12:41:47 +0800 > Haozhong Zhang wrote: > > > This is the QEMU part patches that works with the associated Xen > > patches to enable vNVDIMM support for Xen HVM domains. Xen re

Re: [Qemu-devel] [PATCH v2] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-25 Thread Stefano Stabellini
t, it is simply > ignored. We plan on modifying XAPI to handle it. > > Signed-off-by: Ross Lagerwall Reviewed-by: Stefano Stabellini I queued it up. > --- > > Changed in v2: > * Expanded commit message. > > hw/i386/xen/xen-hvm.c | 2 ++ > 1 file changed, 2 insertions

Re: [Qemu-devel] [PATCH QEMU v4] xen/pt: allow QEMU to request MSI unmasking at bind time

2017-08-24 Thread Stefano Stabellini
> Signed-off-by: Roger Pau Monné > Reviewed-by: Jan Beulich > Reported-by: Andreas Kinzler Acked-by: Stefano Stabellini I'll queue it up. > --- > Cc: Stefano Stabellini > Cc: Anthony Perard > Cc: Jan Beulich > Cc: qemu-devel@nongnu.org > --- > Changes sinc

Re: [Qemu-devel] [PATCH] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-22 Thread Stefano Stabellini
On Tue, 22 Aug 2017, Ross Lagerwall wrote: > On 08/21/2017 11:30 PM, Stefano Stabellini wrote: > > On Mon, 21 Aug 2017, Ross Lagerwall wrote: > > > When the guest writes to the RTC, Xen emulates it and broadcasts a > > > TIMEOFFSET ioreq. Emit an RTC_CHANGE QM

Re: [Qemu-devel] [PATCH 2/2 v3] xenfb: Add [feature|request]-raw-pointer

2017-08-21 Thread Stefano Stabellini
eader in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e > > Signed-off-by: Owen Smith Reviewed-by: Stefano Stabellini > --- > hw/display/xenfb.c | 37 - > 1 file changed, 24 insertions(+), 13 deletions(-) > > diff --git a/hw/display/xenfb.

Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-08-21 Thread Stefano Stabellini
Anthony, The code looks good. I tested this patch with Linux guests and seems to work OK, can you also confirm? One comment below. On Wed, 26 Jul 2017, Owen Smith wrote: > Avoid the unneccessary calls through the input-legacy.c file by > using the qemu_input_handler_*() calls directly. This did

Re: [Qemu-devel] [PATCH] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-21 Thread Stefano Stabellini
On Mon, 21 Aug 2017, Ross Lagerwall wrote: > When the guest writes to the RTC, Xen emulates it and broadcasts a > TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP message when this happens > rather than ignoring it so that something useful can be done with the > information. Are there any handlers of the

Re: [Qemu-devel] [PATCH V2 2/3] xen-pt: bind/unbind interrupt remapping format MSI

2017-08-21 Thread Stefano Stabellini
On Tue, 15 Aug 2017, Lan Tianyu wrote: > Hi Anthony: > > On 2017年08月12日 02:04, Anthony PERARD wrote: > > On Wed, Aug 09, 2017 at 04:51:21PM -0400, Lan Tianyu wrote: > >> From: Chao Gao > >> > >> If a vIOMMU is exposed to guest, guest will configure the msi to remapping > >> format. The original c

Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Stefano Stabellini
ti-page shared rings") > > Signed-off-by: Olaf Hering Reviewed-by: Stefano Stabellini I'll add it to my queue > --- > hw/block/xen_disk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c > index d42

Re: [Qemu-devel] [PATCH v2] xen-disk: use g_new0 to fix build

2017-07-28 Thread Stefano Stabellini
On Fri, 28 Jul 2017, Philippe Mathieu-Daudé wrote: > Hi Olaf, > > On 07/28/2017 10:11 AM, Olaf Hering wrote: > > g_malloc0_n is available since glib-2.24. To allow build with older glib > > versions use the generic g_new0, which is already used in many other > > places in the code. > > Can you pr

Re: [Qemu-devel] [Xen-devel] [PULL 3/3] xen-disk: add support for multi-page shared rings

2017-07-27 Thread Stefano Stabellini
On Thu, 27 Jul 2017, Olaf Hering wrote: > On Tue, Jun 27, Stefano Stabellini wrote: > > > From: Paul Durrant > > The blkif protocol has had provision for negotiation of multi-page shared > > rings for some time now and many guest OS have support in their frontend >

Re: [Qemu-devel] [PATCH for-2.10] exec: Add lock parameter to qemu_ram_ptr_length

2017-07-26 Thread Stefano Stabellini
those > mapping should not be locked because it is used immediatly and never > used again. > > The lock parameter make it explicit in which context qemu_ram_ptr_length > is called. > > Signed-off-by: Anthony PERARD Reviewed-by: Stefano Stabellini > --- > exec.c |

Re: [Qemu-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Stefano Stabellini
On Tue, 25 Jul 2017, Paolo Bonzini wrote: > - Original Message - > > From: "Stefano Stabellini" > > To: "Paolo Bonzini" > > Cc: "Anthony PERARD" , "Stefano Stabellini" > > , > > xen-de...@lists.xen.org, qemu-dev

Re: [Qemu-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache

2017-07-25 Thread Stefano Stabellini
On Tue, 25 Jul 2017, Paolo Bonzini wrote: > > Hi, > > > > Commits 04bf2526ce (exec: use qemu_ram_ptr_length to access guest ram) > > start using qemu_ram_ptr_length() instead of qemu_map_ram_ptr(). > > That result in calling xen_map_cache() with lock=true, but this mapping > > is never invalidated

[Qemu-devel] [PULL for-2.10 1/2] xen: fix compilation on 32-bit hosts

2017-07-21 Thread Stefano Stabellini
From: Igor Druzhinin Signed-off-by: Igor Druzhinin Reviewed-by: Stefano Stabellini --- hw/i386/xen/xen-mapcache.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index 2a1fbd1..bb1078c 100644 --- a/hw/i386

[Qemu-devel] [PULL for-2.10 2/2] xen-mapcache: Fix the bug when overlapping emulated DMA operations may cause inconsistency in guest memory mappings

2017-07-21 Thread Stefano Stabellini
) on DMA unmap, resulting in a wrong MapCacheEntry being unmapped while DMA operation which uses it is still active. The above example must be extended by one more DMA transfer in order to allow unmapping as the first mapping in the list is sort of resident. The patch modifies the behavior in whic

[Qemu-devel] [PULL for-2.10 0/2] please pull xen-20170721-tag

2017-07-21 Thread Stefano Stabellini
The following changes since commit 91939262ffcd3c85ea6a4793d3029326eea1d649: configure: Drop ancient Solaris 9 and earlier support (2017-07-21 15:04:05 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20170721-tag for you to fetch

Re: [Qemu-devel] [PULL for-2.10 6/7] xen/mapcache: introduce xen_replace_cache_entry()

2017-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2017, Igor Druzhinin wrote: > On 21/07/17 14:50, Anthony PERARD wrote: > > On Tue, Jul 18, 2017 at 03:22:41PM -0700, Stefano Stabellini wrote: > > > From: Igor Druzhinin > > > > ... > > > > > +static uint8_t *xen_repl

[Qemu-devel] [PULL for-2.10 7/7] xen: don't use xenstore to save/restore physmap anymore

2017-07-18 Thread Stefano Stabellini
. The old code is left for compatibility reasons. Signed-off-by: Igor Druzhinin Reviewed-by: Paul Durrant Reviewed-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/i386/xen/xen-hvm.c | 48 ++--- hw/i386/xen/xen-mapcache.c

[Qemu-devel] [PULL for-2.10 6/7] xen/mapcache: introduce xen_replace_cache_entry()

2017-07-18 Thread Stefano Stabellini
function makes use of a new xenforeignmemory_map2() call with an extended interface that was recently introduced in libxenforeignmemory [1]. [1] https://www.mail-archive.com/xen-devel@lists.xen.org/msg113007.html Signed-off-by: Igor Druzhinin Reviewed-by: Paul Durrant Reviewed-by: Stefano Stabellini

[Qemu-devel] [PULL for-2.10 3/7] xen-platform: separate unplugging of NVMe disks

2017-07-18 Thread Stefano Stabellini
its in the protocol. [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html [2] http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=1096aa02 Signed-off-by: Paul Durrant Reviewed-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/i386/xen/xen_platf

[Qemu-devel] [PULL for-2.10 5/7] xen/mapcache: add an ability to create dummy mappings

2017-07-18 Thread Stefano Stabellini
-by: Igor Druzhinin Reviewed-by: Paul Durrant Reviewed-by: Stefano Stabellini --- hw/i386/xen/xen-mapcache.c | 44 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c index e60156c

[Qemu-devel] [PULL for-2.10 2/7] xen_pt_msi.c: Check for xen_host_pci_get_* failures in xen_pt_msix_init()

2017-07-18 Thread Stefano Stabellini
From: Peter Maydell Check the return status of the xen_host_pci_get_* functions we call in xen_pt_msix_init(), and fail device init if the reads failed rather than ploughing ahead. (Spotted by Coverity: CID 777338.) Signed-off-by: Peter Maydell Reviewed-by: Stefano Stabellini Signed-off-by

[Qemu-devel] [PULL for-2.10 4/7] xen: move physmap saving into a separate function

2017-07-18 Thread Stefano Stabellini
From: Igor Druzhinin Non-functional change. Signed-off-by: Igor Druzhinin Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/i386/xen/xen-hvm.c | 57 --- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/hw/i386/xen

[Qemu-devel] [PULL for-2.10 1/7] hw/xen: Set emu_mask for igd_opregion register

2017-07-18 Thread Stefano Stabellini
egion base address, and couldn't access it anymore. This patch set emu_mask for igd_opregion register, so guest won't set guest opregion base address to host. Signed-off-by: Xiong Zhang Acked-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt_config_init.c | 1 + 1

[Qemu-devel] [PULL for-2.0 0/7] please pull xen-20170718-tag

2017-07-18 Thread Stefano Stabellini
re Peter Maydell (1): xen_pt_msi.c: Check for xen_host_pci_get_* failures in xen_pt_msix_init() Stefano Stabellini (1): xen-platform: separate unplugging of NVMe disks Xiong Zhang (1): hw/xen: Set emu_mask for igd_opregion register configure | 18 +++ h

Re: [Qemu-devel] [PATCH v3 4/4] xen: don't use xenstore to save/restore physmap anymore

2017-07-18 Thread Stefano Stabellini
On Mon, 10 Jul 2017, Igor Druzhinin wrote: > If we have a system with xenforeignmemory_map2() implemented > we don't need to save/restore physmap on suspend/restore > anymore. In case we resume a VM without physmap - try to > recreate the physmap during memory region restore phase and > remap map c

Re: [Qemu-devel] [PATCH v3 3/4] xen/mapcache: introduce xen_replace_cache_entry()

2017-07-18 Thread Stefano Stabellini
On Mon, 10 Jul 2017, Igor Druzhinin wrote: > This new call is trying to update a requested map cache entry > according to the changes in the physmap. The call is searching > for the entry, unmaps it and maps again at the same place using > a new guest address. If the mapping is dummy this call will

Re: [Qemu-devel] [PATCH v3] xen-platform: separate unplugging of NVMe disks

2017-07-11 Thread Stefano Stabellini
see Xen > > commit [2]) and also tidies up the definitions of, and improves the > > comments regarding, the previously exiting bits in the protocol. > > > > [1] https://lists.xen.org/archives/html/xen-devel/2017-03/msg02924.html > > [2] http://xenbits.xen.org/gi

Re: [Qemu-devel] [PULL 22/42] configure: factor out list of supported Xen/KVM/HAX targets

2017-07-11 Thread Stefano Stabellini
On Mon, 10 Jul 2017, Peter Maydell wrote: > On 10 July 2017 at 17:14, Paolo Bonzini wrote: > > On 10/07/2017 17:49, Peter Maydell wrote: > >> On 5 July 2017 at 08:14, Paolo Bonzini wrote: > >>> This will be useful when the functions are called, early in the configure > >>> process, to filter out

Re: [Qemu-devel] [PATCH] build: disable Xen on ARM

2017-07-11 Thread Stefano Stabellini
On Tue, 11 Jul 2017, Paolo Bonzini wrote: > On 11/07/2017 11:53, Peter Maydell wrote: > > On 11 July 2017 at 09:23, Paolo Bonzini wrote: > >> While ARM could present the xenpv machine, it does not and trying to enable > >> it breaks compilation. > >> > >> Fixes: 3b6b75506de44c5070639943c30a0ad5850

Re: [Qemu-devel] [PATCH] xen_pt_msi.c: Check for xen_host_pci_get_* failures in xen_pt_msix_init()

2017-07-10 Thread Stefano Stabellini
l Reviewed-by: Stefano Stabellini I'll add it to my queue > --- > Disclaimer: compile tested only! > > The only other Xen-related Coverity issue outstanding is that > we don't check the return value of net_hub_id_for_client() in > xen_config_dev_nic(), but that's

Re: [Qemu-devel] [PATCH v2 3/3] xen-disk: use an IOThread per instance

2017-07-07 Thread Stefano Stabellini
On Fri, 7 Jul 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 22 June 2017 23:15 > > To: Paul Durrant > > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; qemu- > >

[Qemu-devel] [PULL 3/3] xen/pt: Fixup addr validation in xen_pt_pci_config_access_check

2017-07-07 Thread Stefano Stabellini
From: Anoob Soman xen_pt_pci_config_access_check checks if addr >= 0xFF. 0xFF is a valid address and should not be ignored. Signed-off-by: Anoob Soman Acked-by: Anthony PERARD Signed-off-by: Stefano Stabellini --- hw/xen/xen_pt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Qemu-devel] [PULL 2/3] xen-platform: Cleanup network infrastructure when emulated NICs are unplugged

2017-07-07 Thread Stefano Stabellini
: Stefano Stabellini --- hw/i386/xen/xen_platform.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 1419fc9..f231558 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -102,8 +102,19 @@ static void

[Qemu-devel] [PULL 0/3] please pull xen-20170707-tag

2017-07-07 Thread Stefano Stabellini
2017/07/07 Anoob Soman (1): xen/pt: Fixup addr validation in xen_pt_pci_config_access_check Ross Lagerwall (1): xen-platform: Cleanup network infrastructure when emulated NICs are unplugged Stefano Stabellini (1): xenfb: remove xen_init_display

[Qemu-devel] [PULL 1/3] xenfb: remove xen_init_display "temporary" hack

2017-07-07 Thread Stefano Stabellini
dependency between the two). Signed-off-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/display/xenfb.c | 81 ++-- hw/xenpv/xen_machine_pv.c| 3 -- include/hw/xen/xen_backend.h | 2 -- 3 files changed, 18 insertions(+), 68 deletion

[Qemu-devel] [PATCH v3] xenfb: remove xen_init_display "temporary" hack

2017-07-06 Thread Stefano Stabellini
dependency between the two). Signed-off-by: Stefano Stabellini --- Note that this patch conflicts with Owen's series (http://marc.info/?l=qemu-devel&m=149908803419893&w=2). However it should be very easy to rebase one on top of the other. Changes in v3: - use qemu_console_lookup_by_in

Re: [Qemu-devel] [PATCH v2] xenfb: remove xen_init_display "temporary" hack

2017-07-06 Thread Stefano Stabellini
On Thu, 29 Jun 2017, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 28 June 2017 19:37 > > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > > Cc: sstabell...@kernel.org; peter.mayd

Re: [Qemu-devel] [PATCH 2/2 v2] xenfb: Allow vkbd to connect without a DisplayState

2017-07-05 Thread Stefano Stabellini
On Mon, 3 Jul 2017, Owen Smith wrote: > If the vkbd device model is registered and the vfb device model > is not registered, the backend will not transition to connected. > If there is no DisplayState, then the absolute coordinates cannot > be scaled, and will remain in the range [0, 0x7fff]. > Bac

Re: [Qemu-devel] [PATCH 1/2 v2] xenfb: Use qemu_input_handler_* calls directly

2017-07-05 Thread Stefano Stabellini
On Mon, 3 Jul 2017, Owen Smith wrote: > The xenvkbd input device uses functions from input-legacy.c > Use the appropriate qemu_input_handler_* functions instead > of calling functions in input-legacy.c that in turn call > the correct functions. > The bulk of this patch removes the extra layer of ca

Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry()

2017-07-05 Thread Stefano Stabellini
On Wed, 5 Jul 2017, Paul Durrant wrote: > > -Original Message- > > From: Igor Druzhinin > > Sent: 04 July 2017 17:47 > > To: Paul Durrant ; xen-de...@lists.xenproject.org; > > qemu-devel@nongnu.org > > Cc: sstabell...@kernel.org; Anthony Perard ; > > pbonz...@redhat.com > > Subject: Re: [PA

Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry()

2017-07-05 Thread Stefano Stabellini
On Tue, 4 Jul 2017, Igor Druzhinin wrote: > This new call is trying to update a requested map cache entry > according to the changes in the physmap. The call is searching > for the entry, unmaps it and maps again at the same place using > a new guest address. If the mapping is dummy this call will

Re: [Qemu-devel] [PATCH v2 4/4] xen: don't use xenstore to save/restore physmap anymore

2017-07-05 Thread Stefano Stabellini
On Tue, 4 Jul 2017, Igor Druzhinin wrote: > If we have a system with xenforeignmemory_map2() implemented > we don't need to save/restore physmap on suspend/restore > anymore. In case we resume a VM without physmap - try to > recreate the physmap during memory region restore phase and > remap map ca

Re: [Qemu-devel] [PATCH v2 2/4] xen/mapcache: add an ability to create dummy mappings

2017-07-05 Thread Stefano Stabellini
planned to be used for restore on Xen. > > Signed-off-by: Igor Druzhinin Reviewed-by: Stefano Stabellini > --- > hw/i386/xen/xen-mapcache.c | 40 > 1 file changed, 32 insertions(+), 8 deletions(-) > > diff --git a/hw/i386/xen/xen-

Re: [Qemu-devel] [PATCH v2 1/4] xen: move physmap saving into a separate function

2017-07-05 Thread Stefano Stabellini
On Tue, 4 Jul 2017, Igor Druzhinin wrote: > Non-functional change. > > Signed-off-by: Igor Druzhinin Unless you change something from a previous version, please retain the acked-by and reviewed-by that were given (see alpine.DEB.2.10.1706301629170.2919@sstabellini-ThinkPad-X260). > --- > hw/i

Re: [Qemu-devel] [PATCH 2/4] xen/mapcache: add an ability to create dummy mappings

2017-07-03 Thread Stefano Stabellini
On Mon, 3 Jul 2017, Igor Druzhinin wrote: > On 01/07/17 01:06, Stefano Stabellini wrote: > > On Fri, 30 Jun 2017, Igor Druzhinin wrote: > >> Dummys are simple anonymous mappings that are placed instead > >> of regular foreign mappings in certain situations when we need

Re: [Qemu-devel] [PATCH 4/4] xen: don't use xenstore to save/restore physmap anymore

2017-06-30 Thread Stefano Stabellini
On Fri, 30 Jun 2017, Igor Druzhinin wrote: > If we have a system with xenforeignmemory_map2() implemented > we don't need to save/restore physmap on suspend/restore > anymore. In case we resume a VM without physmap - try to > recreate the physmap during memory region restore phase and > remap map c

<    1   2   3   4   5   6   7   8   9   10   >