Re: [Qemu-devel] [PATCH v2 1/3] xen-platform: re-structure unplug_disks

enames the flag and re-structures the code to be more > efficient, and readable. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: Ant

Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

On Tue, 24 Jan 2017, Greg Kurz wrote: > On Mon, 23 Jan 2017 12:20:57 -0800 (PST) > Stefano Stabellini <sstabell...@kernel.org> wrote: > > > On Sat, 21 Jan 2017, Greg Kurz wrote: > > > The current code tries to copy `read_count' bytes starting at offset > >

Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen

On Tue, 24 Jan 2017, Stefano Stabellini wrote: > On Tue, 24 Jan 2017, Roger Pau Monné wrote: > > Hello, > > > > The following commit: > > > > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894 > > Author: Juergen Gross <jgr...@suse.com> > >

Re: [Qemu-devel] Commit 3a6c9 breaks QEMU on FreeBSD/Xen

On Tue, 24 Jan 2017, Roger Pau Monné wrote: > Hello, > > The following commit: > > commit 3a6c9172ac5951e6dac2b3f6cbce3cfccdec5894 > Author: Juergen Gross > Date: Tue Nov 22 07:10:58 2016 +0100 > > xen: create qdev for each backend device > > Prevents me from running QEMU

Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

On Sat, 21 Jan 2017, Greg Kurz wrote: > The current code tries to copy `read_count' bytes starting at offset > `offset' from a `read_count`-sized iovec. This causes v9fs_pack() to > fail with ENOBUFS. > > Since the PDU iovec is already partially filled with `offset' bytes, > let's skip them when

Re: [Qemu-devel] [PATCH V5 1/2] Add a new qmp command to start/stop replication

; Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- > docs/qmp-commands.txt | 18 ++ > migration/colo.c | 23 +++ > qapi-schema.json | 19 +++ > 3 f

Re: [Qemu-devel] [RFC 0/7] Move accel, KVM, Xen, qtest files to accel/ subdir

e, should we still create an > accel/ subdir, or move xen-*, kvm-* and friends to sysemu/ too? > > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: k...@vger.kernel.org > Cc: Christoffer Dall <christoffer.d...@linaro.org> > Cc: Anthony Perard <anthony.per...@citrix.com

Re: [Qemu-devel] [PATCH for-2.9 V4 2/2] Add a new qmp command to do checkpoint, get replication error

On Fri, 16 Dec 2016, Zhang Chen wrote: > We can call this qmp command to do checkpoint outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt | 24

Re: [Qemu-devel] [PATCH for-2.9 V4 1/2] Add a new qmp command to start/stop replication

On Fri, 16 Dec 2016, Zhang Chen wrote: > We can call this qmp command to start/stop replication outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt |

Re: [Qemu-devel] [PATCH for-2.9 V4 0/2] Add new qmp commands to suppurt Xen COLO

I am OK with this, if the relevant maintainers (Migration, QMP) ack the patches. On Fri, 16 Dec 2016, Zhang Chen wrote: > Xen COLO depend on qemu COLO replication function. > So, We need new qmp commands for Xen to use qemu replication. > > Corresponding libxl patches already in xen.git. >

Re: [Qemu-devel] [PATCH for-2.9 V3 1/3] Migration: Don't load vmdesc when xen is enabled

On Fri, 9 Dec 2016, Zhang Chen wrote: > Xen doesn't need this. Could you please elaborate a bit more on what is the problem exactly, and why we don't have any issues with migration with Xen today (COLO use-case aside)? > Signed-off-by: Zhang Chen > --- >

Re: [Qemu-devel] [PATCH 0/3] Add new qmp commands to suppurt Xen COLO

Hello Zhang, Are the corresponding libxl patches already in xen.git? If so, could you please mention the commits; if not, could you please add a link to the corresponding patches? Thanks! - Stefano On Thu, 1 Dec 2016, Zhang Chen wrote: > Xen COLO depend on qemu COLO replication function. > So,

Re: [Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()

On Tue, 6 Dec 2016, Igor Mammedov wrote: > > First, to my knowledge, Xen does not use fw_cfg. The following call > > chains depend on (!xen_enabled()): > maybe not, it's just grep gave me: > xen_load_linux() -> fw_cfg_init_io() > maybe it's dead code now [...] > > > > pc_init1() |

Re: [Qemu-devel] [Xen-devel] [PATCH v2 4/4] 9pfs: introduce init_out/in_iov_from_pdu

On Fri, 2 Dec 2016, Greg Kurz wrote: > On Mon, 28 Nov 2016 13:27:24 -0800 > Stefano Stabellini <sstabell...@kernel.org> wrote: > > > Not all 9pfs transports share memory between request and response. For > > those who don't, it is necessary to know how much memory is r

[Qemu-devel] [PATCH v2 2/4] 9pfs: introduce transport specific callbacks

Don't call virtio functions from 9pfs generic code, use generic function callbacks instead. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- Changes in v2: - constify virtio_9p_transport and V9fsTransport - assert !s->transport. - code style --- hw/9pfs/9p.c

[Qemu-devel] [PATCH v2 3/4] 9pfs: call v9fs_init_qiov_from_pdu before v9fs_pack

v9fs_xattr_read should not access VirtQueueElement elems directly. Move v9fs_init_qiov_from_pdu up in the file and call v9fs_init_qiov_from_pdu before v9fs_pack. Use v9fs_pack on the new iovec. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- Changes in v2: - add

[Qemu-devel] [PATCH v2 1/4] 9pfs: move pdus to V9fsState

pdus are initialized and used in 9pfs common code. Move the array from V9fsVirtioState to V9fsState. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Reviewed-by: Greg Kurz <gr...@kaod.org> --- hw/9pfs/9p.c| 7 +++ hw/9pfs/9p.h| 1 + hw/9pfs/virtio-9

[Qemu-devel] [PATCH v2 4/4] 9pfs: introduce init_out/in_iov_from_pdu

). init_in_iov_from_pdu takes an additional size parameter to specify the memory required for the response message. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/9pfs/9p.c | 6 +- hw/9pfs/9p.h | 6 -- hw/9pfs/virtio-9p-device.

[Qemu-devel] [PATCH v2 0/4] 9pfs: clean-up for multiple transports

ion of patch #3 - introduce init_out/in_iov_from_pdu Stefano Stabellini (4): 9pfs: move pdus to V9fsState 9pfs: introduce transport specific callbacks 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack 9pfs: introduce init_out/in_iov_from_pdu hw/9pfs/9p.c |

Re: [Qemu-devel] [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu

On Thu, 24 Nov 2016, Greg Kurz wrote: > On Mon, 21 Nov 2016 13:39:32 -0800 > Stefano Stabellini <sstabell...@kernel.org> wrote: > > > Not all 9pfs transports share memory between request and response. For > > those who don't, it is necessary to know

Re: [Qemu-devel] [PATCH 3/4] 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack

On Thu, 24 Nov 2016, Greg Kurz wrote: > On Mon, 21 Nov 2016 13:39:31 -0800 > Stefano Stabellini <sstabell...@kernel.org> wrote: > > > v9fs_xattr_read should not access VirtQueueElement elems directly. > > Move v9fs_init_qiov_from_pdu up in the file and call > >

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

On Thu, 24 Nov 2016, Greg Kurz wrote: > On Thu, 24 Nov 2016 15:23:10 +0100 > Greg Kurz <gr...@kaod.org> wrote: > > > On Thu, 24 Nov 2016 09:31:52 +0100 > > Greg Kurz <gr...@kaod.org> wrote: > > > > > On Mon, 21 Nov 2016 13:39:30 -0800 > &g

Re: [Qemu-devel] [Xen-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

On Thu, 24 Nov 2016, Greg Kurz wrote: > > > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > > > index 1782e4a..e1a37a4 100644 > > > --- a/hw/9pfs/virtio-9p-device.c > > > +++ b/hw/9pfs/virtio-9p-device.c > > > @@ -20,7 +20,9 @@ > > > #include "hw/virtio/virtio-access.h" > >

[Qemu-devel] [PULL 3/4] xen: slightly simplify bufioreq handling

x.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- xen-hvm.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/xen-hvm.c b/xen-hvm.c index d74e233..124ae10 100644 --- a/xen-hvm.c ++

[Qemu-devel] [PULL 4/4] xen: ignore direction in bufioreq handling

@suse.com> Reviewed-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- xen-hvm.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen-hvm.c b/xe

[Qemu-devel] [PULL 1/4] xen_disk: split discard input to match internal representation

ned-off-by: Olaf Hering <o...@aepfle.de> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/block/xen_disk.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --gi

[Qemu-devel] [PULL 2/4] xen: fix quad word bufioreq handling

finite loop in that case. Reported-by: yanghongke <yanghon...@huawei.com> Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Paul Durrant <paul.durr...@citrix.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell.

[Qemu-devel] [PULL for-2.8 0/4] tags/xen-20161128-tag

The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20161128-tag for you to fetch changes up to

Re: [Qemu-devel] [PATCH v2 2/3] xen: slightly simplify bufioreq handling

ant <paul.durr...@citrix.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > --- a/xen-hvm.c > +++ b/xen-hvm.c > @@ -995,6 +995,8 @@ static int handle_buffered_iopage(XenIOS > } > > memset(, 0x00, sizeof(req)); > +req.state = STATE_IOREQ_READ

Re: [Qemu-devel] [PATCH v2 1/3] xen: fix quad word bufioreq handling

ing to enter an infinite loop in that case. > > Reported-by: yanghongke <yanghon...@huawei.com> > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > v2: Bail (using hw_error()) instead of just breaking the lo

Re: [Qemu-devel] [PATCH] MAINTAINERS: Update xen-devel mailing list address

On Fri, 25 Nov 2016, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> Acked-by: Stefano Stabellini <sstabell...@kernel.org> > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/

Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges

On Wed, 23 Nov 2016, Olaf Hering wrote: > On Wed, Nov 23, Olaf Hering wrote: > > > > > +if (!blk_split_discard(ioreq, req->sector_number, > > > > req->nr_sectors)) { > > > > +goto err; > > > How is error handling supposed to work here? > > In the guest the cmd is stuck,

Re: [Qemu-devel] [PATCH for-2.8 v3] xen_disk: split discard input to match internal representation

On Wed, 23 Nov 2016, Kevin Wolf wrote: > Am 23.11.2016 um 12:40 hat Eric Blake geschrieben: > > On 11/23/2016 04:39 AM, Olaf Hering wrote: > > > The guest sends discard requests as u64 sector/count pairs, but the > > > block layer operates internally with s64/s32 pairs. The conversion > > > leads

Re: [Qemu-devel] [PATCH v3] xen_disk: split discard input to match internal representation

> Fixes f313520 ("xen_disk: add discard support") > > Signed-off-by: Olaf Hering <o...@aepfle.de> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > v3: > turn tab into spaces to fix checkpatch warning > v2: > adjust overflow check &g

Re: [Qemu-devel] [PATCH 3/3] xen: ignore direction in bufioreq handling

On Wed, 23 Nov 2016, Paul Durrant wrote: > > -Original Message- > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: 23 November 2016 09:25 > > To: qemu-devel@nongnu.org > > Cc: Anthony Perard <anthony.per...@citrix.com>; Paul Durrant > > <

Re: [Qemu-devel] [PATCH 1/3] xen: fix quad word bufioreq handling

On Wed, 23 Nov 2016, Jan Beulich wrote: > >>> On 23.11.16 at 11:45, wrote: > > No, if QEMU is using a default ioreq server (i.e. the legacy way of doing > > things) then it's vulnerable to the guest messing with the rings and I'd > > forgotten that migrated-in guests

Re: [Qemu-devel] [PATCH 2/3] xen: slightly simplify bufioreq handling

On Wed, 23 Nov 2016, Jan Beulich wrote: > There's no point setting fields always receiving the same value on each > iteration, as handle_ioreq() doesn't alter them anyway. Set state and > count once ahead of the loop, drop the redundant clearing of > data_is_ptr, and avoid the meaningless setting

[Qemu-devel] [PULL 5/5] xen: attach pvusb usb bus to backend qdev

gt; Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/usb/xen-usb.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c index 1b3c2fb..8e676e6

[Qemu-devel] [PULL 3/5] qdev: add function qdev_set_id()

From: Juergen Gross <jgr...@suse.com> In order to have an easy way to add a new qdev with a specific id carve out the needed functionality from qdev_device_add() into a new function qdev_set_id(). Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Stefano Stabelli

[Qemu-devel] [PULL 4/5] xen: create qdev for each backend device

uot;) and the xen backend number of the type under which it is to be found in xenstore. Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.or

[Qemu-devel] [PULL 1/5] xen: fix ioreq handling

From: Jan Beulich <jbeul...@suse.com> Avoid double fetches and bounds check size to avoid overflowing internal variables. This is CVE-2016-9381 / XSA-197. Reported-by: yanghongke <yanghon...@huawei.com> Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Stefano St

[Qemu-devel] [PULL 2/5] xen: add an own bus for xen backend devices

From: Juergen Gross <jgr...@suse.com> Add a bus for Xen backend devices in order to be able to establish a dedicated device path for pluggable devices. Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by:

[Qemu-devel] [PULL 0/5] xen-20161122-tag

Hi Stefan, this pull request contains an XSA ("fix ioreq handling") and xen-usb bug fixes and cleanups. Please note that "qdev: add function qdev_set_id()" touches generic qdev code: I was the only one to review the patch but it is just code movement. The following changes since commit

[Qemu-devel] [PATCH 4/4] 9pfs: add a size parameter to init_iov_from_pdu

Not all 9pfs transports share memory between request and response. For those who don't, it is necessary to know how much memory is required in the response. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/9pfs/9p.c | 2 +- hw/9pfs/9p.h | 2

[Qemu-devel] [PATCH 1/4] 9pfs: move pdus to V9fsState

pdus are initialized and used in 9pfs common code. Move the array from V9fsVirtioState to V9fsState. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/9pfs/9p.c| 7 +++ hw/9pfs/9p.h| 1 + hw/9pfs/virtio-9p.h | 1 - 3 files changed, 4 insertions(+), 5 del

[Qemu-devel] [PATCH 2/4] 9pfs: introduce transport specific callbacks

Don't call virtio functions from 9pfs generic code, use generic function callbacks instead. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/9pfs/9p.c | 8 hw/9pfs/9p.h | 18 ++ hw/9pfs/virtio-9p-device.

[Qemu-devel] [PATCH 3/4] 9pfs: use v9fs_init_qiov_from_pdu instead of v9fs_pack

v9fs_xattr_read should not access VirtQueueElement elems directly. Move v9fs_init_qiov_from_pdu up in the file and call v9fs_init_qiov_from_pdu instead of v9fs_pack. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/9pfs/9p.

[Qemu-devel] [PATCH 0/4] 9pfs: clean-up for multiple transports

Hi all, this small patch series provides a few fixes and clean-ups in preparation for the introduction of a 9pfs Xen transport. Stefano Stabellini (4): 9pfs: move pdus to V9fsState 9pfs: introduce transport specific callbacks 9pfs: use v9fs_init_qiov_from_pdu instead

Re: [Qemu-devel] [PATCH v2 0/4] xed: add qdevs for each backend, correct pvUSB

Hi Juergen, it would be helpful if you could resend this series with the small changes I requested. But if it is a problem for you, I can do that myself while committing. Cheers, Stefano On Wed, 2 Nov 2016, Juergen Gross wrote: > Trying to use pvUSB in a Xen guest with a qemu emulated USB

Re: [Qemu-devel] [PATCH v2 3/4] xen: create qdev for each backend device

o[]) { > { TYPE_HOTPLUG_HANDLER }, > { } > @@ -627,6 +672,7 @@ static void xenbe_register_types(void) > { > type_register_static(_info); > type_register_static(_info); > +type_register_static(_type_info); > } > > type_init(xenbe_registe

Re: [Qemu-devel] [PATCH v2 2/4] qdev: add function qdev_set_id()

On Wed, 2 Nov 2016, Juergen Gross wrote: > In order to have an easy way to add a new qdev with a specific id > carve out the needed functionality from qdev_device_add() into a new > function qdev_set_id(). > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-b

Re: [Qemu-devel] [PATCH v2 4/4] xen: attach pvusb usb bus to backend qdev

lt;jgr...@suse.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > hw/usb/xen-usb.c | 23 ++- > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c > index 1b3c2fb..8e676e6 100644 > --

Re: [Qemu-devel] [PATCH v2 1/4] xen: add an own bus for xen backend devices

On Wed, 2 Nov 2016, Juergen Gross wrote: > Add a bus for Xen backend devices in order to be able to establish a > dedicated device path for pluggable devices. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>

[Qemu-devel] [PULL] xen: Fix xenpv machine initialisation

() fix the issue. This fix 021746c131cdfeab9d82ff918795a9f18d20d7ae. Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> Reviewed-by: Stefano Stabellini <sstabell...@ke

[Qemu-devel] [PULL 0/1] tags/xen-20161108-tag

The following changes since commit 207faf24c58859f5240f66bf6decc33b87a1776e: Merge remote-tracking branch 'pm215/tags/pull-target-arm-20161107' into staging (2016-11-07 14:02:15 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

Re: [Qemu-devel] [PATCH v2] xen: Fix xenpv machine initialisation

xen_hvm_init() fix the issue. > > This fix 021746c131cdfeab9d82ff918795a9f18d20d7ae. > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > CC: Wei Liu <wei.l...@citrix.com> > CC: Eduardo H

Re: [Qemu-devel] [PATCH] xen: Fix xenpv machine initialisation

On Mon, 7 Nov 2016, Anthony PERARD wrote: > When using QEMU for Xen PV guest, QEMU abort with: > xen-common.c:118:xen_init: Object 0x7f2b8325dcb0 is not an instance of type > generic-pc-machine > > This is because the machine 'xenpv' also use accel=xen. > > This fix

[Qemu-devel] [PULL 0/2] tags/xen-20161102-tag

The following changes since commit 4eb28abd52d48657cff6ff45e8dbbbefe4dbb414: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20161101-2' into staging (2016-11-01 16:53:05 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

[Qemu-devel] [PULL 2/2] PCMachineState: introduce acpi_build_enabled field

guest. Signed-off-by: Wei Liu <wei.l...@citrix.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> Tested-by: Sander Eikelenboom <li...@eikelenboom.

[Qemu-devel] [PULL 1/2] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

From: Thomas Huth <th...@redhat.com> Olaf Hering reported a build failure due to an undefined reference to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to fix the issue. Signed-off-by: Thomas Huth <th...@redhat.com> Signed-off-by: Stefano Stabellini <sstabell...@ke

Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

On Wed, 2 Nov 2016, Peter Maydell wrote: > On 2 November 2016 at 17:34, Stefano Stabellini <sstabell...@kernel.org> > wrote: > > On Wed, 2 Nov 2016, Thomas Huth wrote: > >> Olaf Hering reported a build failure due to an undefined reference > >> to 'qemu_log_

Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()

On Wed, 2 Nov 2016, Thomas Huth wrote: > Olaf Hering reported a build failure due to an undefined reference > to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to > fix the issue. > > Signed-off-by: Thomas Huth <th...@redhat.com> The fix makes sense: Acked-b

Re: [Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

On Tue, 1 Nov 2016, Eduardo Habkost wrote: > On Tue, Nov 01, 2016 at 05:44:16PM +, Wei Liu wrote: > > Introduce this field to control whether ACPI build is enabled by a > > particular machine or accelerator. > > > > It defaults to true if the machine itself supports ACPI build. Xen > >

Re: [Qemu-devel] [PATCH v2] PCMachineState: introduce acpi_build_enabled field

g ACPI > tables for the guest. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > Cc: Igor Mammedov <imamm...@redhat.com> > Cc: Eduardo Habkost <ehabk...@redhat.com> > Cc: Anthony PERARD <a

[Qemu-devel] [PULL 12/13] xen: Rename xen_be_find_xendev

From: Emil Condrea <emilcond...@gmail.com> Prepare xen_be_find_xendev to be shared with frontends: * xen_be_find_xendev -> xen_pv_find_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Quan X

[Qemu-devel] [PULL 08/13] xen: Rename xen_be_printf to xen_pv_printf

From: Emil Condrea <emilcond...@gmail.com> Prepare xen_be_printf to be used by both backend and frontends: * xen_be_printf -> xen_pv_printf Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Quan X

[Qemu-devel] [PULL 13/13] xen: Rename xen_be_del_xendev

From: Emil Condrea <emilcond...@gmail.com> Prepare xen_be_del_xendev to be shared with frontends: * xen_be_del_xendev -> xen_pv_del_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Quan X

[Qemu-devel] [PULL 10/13] xen: Rename xen_be_send_notify

From: Emil Condrea <emilcond...@gmail.com> Prepare xen_be_send_notify to be shared with frontends: * xen_be_send_notify -> xen_pv_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Quan X

[Qemu-devel] [PULL 11/13] xen: Rename xen_be_evtchn_event

From: Emil Condrea <emilcond...@gmail.com> Prepare xen_be_evtchn_event to be shared with frontends: * xen_be_evtchn_event -> xen_pv_evtchn_event Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-

[Qemu-devel] [PULL 05/13] xen: Move evtchn functions to xen_pvdev.c

From: Emil Condrea <emilcond...@gmail.com> The name of the functions moved: * xen_be_evtchn_event * xen_be_unbind_evtchn * xen_be_send_notify Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off

[Qemu-devel] [PULL 06/13] xen: Prepare xendev qtail to be shared with frontends

From: Emil Condrea <emilcond...@gmail.com> * move xendevs qtail to xen_pvdev.c * change xen_be_get_xendev to use a new function: xen_pv_insert_xendev Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off

[Qemu-devel] [PULL 07/13] xen: Move xenstore cleanup and mkdir functions

From: Emil Condrea <emilcond...@gmail.com> The name of the functions moved to xen_pvdev.c: * xenstore_cleanup_dir * xen_config_cleanup * xenstore_mkdir Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off

[Qemu-devel] [PULL 09/13] xen: Rename xen_be_unbind_evtchn

From: Emil Condrea <emilcond...@gmail.com> Prepare xen_be_unbind_evtchn to be shared with frontends: * xen_be_unbind_evtchn -> xen_pv_unbind_evtchn Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-

[Qemu-devel] [PULL 01/13] xen: Fix coding style errors

should be "(foo *)" Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Quan Xu <xuqu...@huawei.com> Acked-by: Anthony PERARD <anthony.per...@citrix.com> --- hw/char/xen_conso

[Qemu-devel] [PULL 03/13] xen: Create a new file xen_pvdev.c

From: Emil Condrea <emilcond...@gmail.com> The purpose of the new file is to store generic functions shared by frontend and backends such as xenstore operations, xendevs. Signed-off-by: Quan Xu <quan...@intel.com> Signed-off-by: Emil Condrea <emilcond...@gmail.com> Sign

[Qemu-devel] [PULL 04/13] xen: Move xenstore_update to xen_pvdev.c

From: Emil Condrea <emilcond...@gmail.com> * xenstore_update -> xen_pvdev.c Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Quan Xu <xuqu...@huawei.com> Acked-by: Anthony PERARD <anthony.

[Qemu-devel] [PULL 02/13] xen: Fix coding style warnings

From: Emil Condrea <emilcond...@gmail.com> Fixes: * WARNING: line over 80 characters Signed-off-by: Emil Condrea <emilcond...@gmail.com> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Quan Xu <xuqu...@huawei.com> Acked-by: Anthony PERARD &l

[Qemu-devel] [PULL 00/13] xen-20161028-tag

The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into staging (2016-10-28 17:59:04 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xenfv: set has_acpi_build to false

On Fri, 28 Oct 2016, Wei Liu wrote: > On Thu, Oct 27, 2016 at 11:58:29AM -0700, Stefano Stabellini wrote: > > On Thu, 27 Oct 2016, Sander Eikelenboom wrote: > > > Thursday, October 27, 2016, 3:51:09 PM, you wrote: > > > > > > > Xen's toolstack is in charge o

Re: [Qemu-devel] [Xen-devel] [PATCH v2] xenfv: set has_acpi_build to false

pc,accel=xen. That case wouldn't be fixed by this patch. Wei, you can test it by adding "xen_platform_pci=0" to the VM config file. That's why we probably need a new option, similar to has_acpi_build, but that can be changed at accelerator init time. > > --- > > Cc: Igor Mammedov

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

On Wed, 26 Oct 2016, Stefano Stabellini wrote: > On Wed, 26 Oct 2016, Wei Liu wrote: > > On Wed, Oct 26, 2016 at 05:09:52PM +0200, Igor Mammedov wrote: > > > On Tue, 25 Oct 2016 18:28:04 +0100 > > > Wei Liu <wei.l...@citrix.com> wrote: > > > > > &

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

d and load ACPI tables (which are > never going to be used by Xen guests), causing the guest to exceeds its > limit. What if libxl passes -no-acpi to QEMU? > > > --- > > > Cc: Anthony PERARD <anthony.per...@citrix.com> > > > Cc: Stefano Stabellini <sstab

Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests

hine and for the PC machine when accel=xen. Thoughts? > Cc: Anthony PERARD <anthony.per...@citrix.com> > Cc: Stefano Stabellini <sstabell...@kernel.org> > > RFC because I'm not sure this is the best way to fix it. > --- > hw/i386/acpi-build.c | 6 ++ > 1 file cha

[Qemu-devel] [PULL 1/3] xen-usb: do not reference PAGE_SIZE

PAGE_SIZE is undefined on ARM64. Use XC_PAGE_SIZE instead, which is always 4096 even when page granularity is 64K. For this to actually work with 64K pages, more changes are required. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> Reviewed-by: Juergen Gross <jgr...@suse.com

[Qemu-devel] [PULL 3/3] xen_platform: SUSE xenlinux unplug for emulated PCI

E 12.3. In addition old (pre-2011) VMDP versions are handled as well. Signed-off-by: Olaf Hering <o...@aepfle.de> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/i386/xen/xen_platform.c | 27 +++

[Qemu-devel] [PULL 2/3] xen_platform: unplug also SCSI disks

pv sda disk2=pv sda Signed-off-by: Olaf Hering <o...@aepfle.de> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> --- hw/i386/xen/xen_platform.c | 4 1 file changed, 4 insertions(+)

[Qemu-devel] [PULL 0/3] tags/xen-20161021-tag

Olaf Hering (2): xen_platform: unplug also SCSI disks xen_platform: SUSE xenlinux unplug for emulated PCI Stefano Stabellini (1): xen-usb: do not reference PAGE_SIZE hw/i386/xen/xen_platform.c | 31 ++- hw/usb/xen-usb.c

Re: [Qemu-devel] [PATCH v3 1/2] xen_platform: unplug also SCSI disks

after: pvops: disk0=pv xvda > disk1=not accessible by blkfront, index hda==index sda > disk2=pv xvdb > classic: disk0=pv hda > disk1=pv sda > disk2=pv sda > > Signed-off-by: Olaf Hering <o...@aepfle.de>

Re: [Qemu-devel] [PATCH v3 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

to SLES11SP3 and > openSUSE 12.3. > In addition old (pre-2011) VMDP versions are handled as well. > > Signed-off-by: Olaf Hering <o...@aepfle.de> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > hw/i386/xen/xen_platform.c | 27 ++- > 1

Re: [Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

> On Tue, Oct 18, 2016 at 12:09:55PM -0700, Stefano Stabellini wrote: > > >>>> Hi all, > > >>>> > > >>>> While I was investigating the recent libxl ARM64 build issue, I found > > >>>> another ARM64 build pro

[Qemu-devel] [PATCH] xen-usb.c/usbif.h: fix ARM64 build issue

s been shipped with too many Xen releases to be able to solve the problem at the source. This patch define PAGE_SIZE as XC_PAGE_SIZE when undefined. Signed-off-by: Stefano Stabellini <sstabell...@kernel.org> diff --git a/hw/usb/xen-usb.c b/hw/usb/xen-usb.c index 174d715..ca9df87 100644 --- a/h

Re: [Qemu-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

On Fri, 2 Sep 2016, Olaf Hering wrote: > Implement SUSE specific unplug protocol for emulated PCI devices > in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. > This protocol was implemented and used since Xen 3.0.4. > It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and >

Re: [Qemu-devel] qdevification of xen_disk

Hi Kevin, I agree with you, and if you would be so kind to send the patches, even untested, they would be much appreciated. Anthony or I will make sure to test them appropriately and fix them, if they turn out to be incomplete or partially broken. Would that be OK? Cheers, Stefano P.S. FYI Xen

Re: [Qemu-devel] [PATCH] xenpv: Fix qemu_uuid compiling error

n_domainbuild.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> Acked-by: Stefano Stabellini <sstabell...@kernel.org> > > > > diff --git a/hw/xenpv/xen_domainbuild.c b/hw/xenpv/xen_domainbuild.c > >

[Qemu-devel] [PULL 1/1] qdisk - hw/block/xen_disk: grant copy implementation

ration is supported by a guest. Signed-off-by: Paulina Szubarczyk <paulinaszubarc...@gmail.com> Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> Acked-by: Anthony PERARD <anthony.per...@citrix.com> Acked-by: Roger Pau Monné <roger@citrix.com> --- configure

[Qemu-devel] [PULL 0/1] tags/xen-20160927-tag

The following changes since commit 25930ed60aad49f1fdd7de05272317c86ce1275b: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request' into staging (2016-09-27 23:10:12 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

Re: [Qemu-devel] [PATCH v7 0/2] qemu-qdisk: Implementation of grant copy operation.

Hi Wei, I am happy to queue up this for QEMU, but I'll wait for the first patch to be committed to Xen before sending a pull request. Is that OK? Cheers, Stefano On Wed, 14 Sep 2016, Paulina Szubarczyk wrote: > Hi, > > It is a proposition for implementation of grant copy operation in

Re: [Qemu-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

On Fri, 2 Sep 2016, Olaf Hering wrote: > Implement SUSE specific unplug protocol for emulated PCI devices > in PVonHVM guests. Its a simple 'outl(1, (ioaddr + 4));'. > This protocol was implemented and used since Xen 3.0.4. > It is used in all SUSE/SLES/openSUSE releases up to SLES11SP3 and >

Re: [Qemu-devel] [PATCH v2 1/2] xen_platform: unplug also SCSI disks

On Fri, 2 Sep 2016, Olaf Hering wrote: > Using 'vdev=sd[a-o]' will create an emulated LSI controller, which can > be used by the emulated BIOS to boot from disk. If the HVM domU has also > PV driver the disk may appear twice in the guest. To avoid this an > unplug of the emulated hardware is

Re: [Qemu-devel] [PATCH v6 2/2] qdisk - hw/block/xen_disk: grant copy implementation

On Thu, 8 Sep 2016, Paulina Szubarczyk wrote: > > > @@ -582,6 +722,9 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > > > } > > > default: > > > /* unknown operation (shouldn't happen -- parse catches this) */ > > > +if (!ioreq->blkdev->feature_grant_copy) {

<    2   3   4   5   6   7   8   9   10   11   >