Re: [Qemu-devel] [PATCH v2] xen_pt: fix failure of attaching & detaching a PCI device to VM repeatedly

2015-12-09 Thread Stefano Stabellini
On Wed, 9 Dec 2015, Jianzhong,Chang wrote: > Add pci = [ '$VF_BDF1', '$VF_BDF2', '$VF_BDF3'] in > hvm guest configuration file. After the guest boot up, > detach the VFs in sequence by > "xl pci-detach $DOMID $VF_BDF1" > "xl pci-detach $DOMID $VF_BDF2" > "xl pci-detach $DOMID $VF_BDF3" > and

Re: [Qemu-devel] [PATCH v2 1/4] xen/MSI-X: latch MSI-X table writes

2015-12-08 Thread Stefano Stabellini
On Mon, 7 Dec 2015, Jan Beulich wrote: > >>> On 07.12.15 at 13:41, wrote: > > I know that in your opinion is superfluous, nonetheless could you please > > add 2-3 lines of in-code comment right here, to explain what you are > > doing with the check? Something

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-07 Thread Stefano Stabellini
On Mon, 7 Dec 2015, Jan Beulich wrote: > >>> On 07.12.15 at 13:45, wrote: > > On Tue, 24 Nov 2015, Jan Beulich wrote: > >> Now that the hypervisor intercepts all config space writes and monitors > >> changes to the masking flags, this undoes the main effect of

Re: [Qemu-devel] [PATCH v2 1/4] xen/MSI-X: latch MSI-X table writes

2015-12-07 Thread Stefano Stabellini
On Tue, 24 Nov 2015, Jan Beulich wrote: > The remaining log message in pci_msix_write() is wrong, as there guest > behavior may only appear to be wrong: For one, the old logic didn't > take the mask-all bit into account. And then this shouldn't depend on > host device state (i.e. the host may have

Re: [Qemu-devel] [PATCH v2 3/4] xen/pass-through: correctly deal with RW1C bits

2015-12-07 Thread Stefano Stabellini
On Tue, 24 Nov 2015, Jan Beulich wrote: > Introduce yet another mask for them, so that the generic routine can > handle them, at once rendering xen_pt_pmcsr_reg_write() superfluous. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Stefano Stabellin

Re: [Qemu-devel] [PATCH RFC v2 4/4] xen/MSI: re-expose masking capability

2015-12-07 Thread Stefano Stabellini
On Tue, 24 Nov 2015, Jan Beulich wrote: > Now that the hypervisor intercepts all config space writes and monitors > changes to the masking flags, this undoes the main effect of the > XSA-129 fix, exposing the masking capability again to guests. > > Signed-off-by: Jan Beulich >

Re: [Qemu-devel] [PATCH] xen_pt: fix failure of attaching & detaching a PCI device to VM repeatedly

2015-12-04 Thread Stefano Stabellini
On Thu, 3 Dec 2015, Jianzhong,Chang wrote: > From: jianzhong,Chang > > Add pci = [ '$VF_BDF', '$VF_BDF', '$VF_BDF'] in This is a bit confusing: it is not actually correct to assign the same device, even an SR_IOV VF, multiple times, so these must be all different.

Re: [Qemu-devel] [PATCH QEMU-XEN v6 4/8] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_pages

2015-12-04 Thread Stefano Stabellini
circumstances > xendev->dev can be NULL or if anything elsewhere ensures the value > fits into an int. For now I just use a temporary xen_pfn_t to in > effect upcast the pointer from int* to xen_pfn_t*. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-

Re: [Qemu-devel] [PATCH QEMU-XEN v6 5/8] xen: Switch uses of xc_map_foreign_{pages, bulk} to use libxenforeignmemory API.

2015-12-04 Thread Stefano Stabellini
On Thu, 3 Dec 2015, Ian Campbell wrote: > diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h > index 2cadd4f..8fbaf07 100644 > --- a/include/hw/xen/xen_common.h > +++ b/include/hw/xen/xen_common.h > @@ -41,6 +41,7 @@ static inline void *xc_map_foreign_bulk(int xc_handle, >

Re: [Qemu-devel] [PATCH QEMU-XEN v6 6/8] xen: Use stable library interfaces when they are available.

2015-12-04 Thread Stefano Stabellini
6 (inclusive) and the patches targetting > 4.7 which adds these libraries. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > v6: Two minor formatting things. > Rebase onto "xen: fix us

[Qemu-devel] [PATCH] xen_disk: treat "vhd" as "vpc"

2015-12-04 Thread Stefano Stabellini
The Xen toolstack uses "vhd" to specify a disk in VHD format, however the name of the driver in QEMU is "vpc". Replace "vhd" with "vpc", so that QEMU can find the right driver to use for it. Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citr

Re: [Qemu-devel] Highlighting changes in QEMU 2.5

2015-12-03 Thread Stefano Stabellini
On Wed, 2 Dec 2015, Eduardo Habkost wrote: > On Tue, Dec 01, 2015 at 05:46:05PM +0530, Amit Shah wrote: > > Ping. > > > > I haven't received any responses so far, please let me know if you're > > planning on doing this. > > Sorry for taking so long to reply. I don't feel comfortable > recording

[Qemu-devel] [PATCH] fix MSI injection on Xen

2015-12-02 Thread Stefano Stabellini
have been remapped into pirqs. Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> diff --git a/hw/pci/msi.c b/hw/pci/msi.c index f9c0484..3998725 100644 --- a/hw/pci/msi.c +++ b/hw/pci/msi.c @@ -19,6 +19,7 @@ */ #include "hw/pci/msi.h" +#include "hw

Re: [Qemu-devel] [PATCH] fix MSI injection on Xen

2015-12-02 Thread Stefano Stabellini
On Wed, 2 Dec 2015, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 04:56:21PM +0000, Stefano Stabellini wrote: > > On Xen MSIs can be remapped into pirqs, which are a type of event > > channels. It's mostly for the benefit of PCI passthrough devices, to > > avoid the ov

Re: [Qemu-devel] [PATCH for-2.5] xen_disk: Remove ioreq.postsync

2015-11-25 Thread Stefano Stabellini
On Wed, 25 Nov 2015, Alberto Garcia wrote: > This code has been dead for three years (since commit 7e7b7cba1). > > Signed-off-by: Alberto Garcia <be...@igalia.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Kevin, I'll send it out together w

[Qemu-devel] [PULL for-4.5 1/2] xen: fix usage of xc_domain_create in domain builder

2015-11-25 Thread Stefano Stabellini
called xen_domain_create that encapsulates the correct call to xc_domain_create depending on the libxc version detected. Signed-off-by: Roger Pau Monné <roger@citrix.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellini <stefano.sta

[Qemu-devel] [PULL for-4.5 2/2] xen_disk: Remove ioreq.postsync

2015-11-25 Thread Stefano Stabellini
From: Alberto Garcia <be...@igalia.com> This code has been dead for three years (since commit 7e7b7cba1). Signed-off-by: Alberto Garcia <be...@igalia.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Reviewed-by: Stefano Stabellini <stefano.sta

[Qemu-devel] [PULL for-2.5 0/2] xen-20151125

2015-11-25 Thread Stefano Stabellini
The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-20151125 for you to fetch changes up to

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2015, Paolo Bonzini wrote: > On 19/11/2015 16:32, Stefano Stabellini wrote: > > > In addition to Kevin's replies, I have a high-level question: can VFIO > > > be used by QEMU for both KVM and Xen? > > > > No. VFIO cannot be used with Xen toda

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2015, Jike Song wrote: > Hi Alex, thanks for the discussion. > > In addition to Kevin's replies, I have a high-level question: can VFIO > be used by QEMU for both KVM and Xen? No. VFIO cannot be used with Xen today. When running on Xen, the IOMMU is owned by Xen.

Re: [Qemu-devel] [PATCH QEMU v3 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
all stub called xen_domain_create that encapsulates the correct call > to xc_domain_create depending on the libxc version detected. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> I'll apply it t

Re: [Qemu-devel] [PATCH QEMU 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
f-by: Roger Pau Monné <roger@citrix.com> Give a look at include/hw/xen/xen_common.h and add a compatibility shim there. Keep in mind that QEMU needs to build against any version of Xen from 4.0 onward. > Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > Cc: qemu-d

Re: [Qemu-devel] [PATCH QEMU v2 2/2] xen: fix usage of xc_domain_create in domain builder

2015-11-13 Thread Stefano Stabellini
-email-ian.campb...@citrix.com Is the corresponding libxc change already in Xen? > Cc: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > Cc: qemu-devel@nongnu.org > --- > Changes since v1: > - Add a compat layer to support previous libxc versions. > - Add machinery to

Re: [Qemu-devel] [PATCH QEMU-XEN v5 9/9] xen: make it possible to build without the Xen PV domain builder

2015-11-10 Thread Stefano Stabellini
is is another step towards only using Xen libraries which provide a > stable inteface. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > v5: XEN_CREATE entirely wihtin CONFIG_XEN_PV_DOMA

Re: [Qemu-devel] [PATCH QEMU-XEN v5 7/9] xen: Use stable library interfaces when they are available.

2015-11-10 Thread Stefano Stabellini
6 (inclusive) and the patches targetting > 4.7 which adds these libraries. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Two formatting issues below: > v5: Remove ifdef check when undeffin

Re: [Qemu-devel] [PATCH QEMU-XEN v5 3/9] xen: Switch to libxengnttab interface for compat shims.

2015-11-10 Thread Stefano Stabellini
upport for actually using > libxengnttab, it just adjusts the existing shims. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > v4: Ran checkpatch, fixed all errors > Allocate correct

Re: [Qemu-devel] [PATCH v2 1/2] xen_platform: switch to realize

2015-10-26 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Eduardo Habkost wrote: > From: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > > Use realize to initialize the xen_platform device > > Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > Signed-off-by: Eduardo Habkost

[Qemu-devel] [PULL 1/3] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-26 Thread Stefano Stabellini
ild_property() will access msix->mmio's obj. But the whole msix struct has already been freed by xen_pt_msix_delete. This will cause segment fault when msix->mmio has been overwritten. This patch is to fix the issue. Signed-off-by: Lan Tianyu <tianyu@intel.com> Reviewe

[Qemu-devel] [PULL 3/3] xen-platform: Replace assert() with appropriate error reporting

2015-10-26 Thread Stefano Stabellini
o Habkost <ehabk...@redhat.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> --- hw/i386/xen/xen_platform.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/i38

Re: [Qemu-devel] [PATCH v2 2/2] xen-platform: Replace assert() with appropriate error reporting

2015-10-26 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Eduardo Habkost wrote: > Commit dbb7405d8caad0814ceddd568cb49f163a847561 made it possible to > trigger an assert using "-device xen-platform". Replace it with > appropriate error reporting. > > Before: > > $ qemu-system-x86_64 -device xen-platform > qemu-system-x86_64:

[Qemu-devel] [PULL 2/3] xen_platform: switch to realize

2015-10-26 Thread Stefano Stabellini
Use realize to initialize the xen_platform device Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> --- hw/i386/xen/xen_platform.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a

[Qemu-devel] [PULL 0/3] xen-2015-10-26

2015-10-26 Thread Stefano Stabellini
Eduardo Habkost (1): xen-platform: Replace assert() with appropriate error reporting Lan Tianyu (1): Qemu/Xen: Fix early freeing MSIX MMIO memory region Stefano Stabellini (1): xen_platform: switch to realize hw/i386/xen/xen_platform.c | 12

Re: [Qemu-devel] [PATCH QEMU-XEN v4 2/9] xen: Switch to libxenevtchn interface for compat shims.

2015-10-23 Thread Stefano Stabellini
> Note that this patch does not add any support for actually using > libxenevtchn, it just adjusts the existing shims. > > Note that xc_evtchn_alloc_unbound functionality remains in libxenctrl, > since that functionality is not exposed by /dev/xen/evtchn. > > Signe

Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > Until the previous patch this relied on xc_fd(), which was only > implemented for Xen 4.0 and earlier. > > Given this wasn't working since Xen 4.0 I have marked this as disabled > by default. > > Removing this support drops the use of a bunch of symbols

Re: [Qemu-devel] [PATCH QEMU-XEN v4 9/9] xen: make it possible to build without the Xen PV domain builder

2015-10-23 Thread Stefano Stabellini
On Fri, 23 Oct 2015, Ian Campbell wrote: > On Fri, 2015-10-23 at 12:12 +0100, Stefano Stabellini wrote: > > @@ -2113,6 +2117,15 @@ if test "$xen_pci_passthrough" != "no"; then > > >fi > > > fi > > > > > > +if test "$xen

Re: [Qemu-devel] [PATCH QEMU-XEN v4 3/9] xen: Switch to libxengnttab interface for compat shims.

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > One such library will be libxengnttab which provides access to grant > tables. > > In

Re: [Qemu-devel] [PATCH QEMU-XEN v4 6/9] xen: Switch uses of xc_map_foreign_bulk to use libxenforeignmemory API.

2015-10-23 Thread Stefano Stabellini
dding an extra API to > the libxenforeignmemory interface to replace a foreign mapping with > anonymous shared memory, but I'd prefer not to. > > Build tested with 4.0 and 4.5. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-by: Stefano Stabellini <stefan

Re: [Qemu-devel] [PATCH QEMU-XEN v4 4/9] xen: Switch uses of xc_map_foreign_range into xc_map_foreign_bulk

2015-10-23 Thread Stefano Stabellini
fn_t to in > effect upcast the pointer from int* to xen_pfn_t*. > > Build tested with 4.0 and 4.5. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > v4: Ran checkpatch, fixed all errors >

Re: [Qemu-devel] [PATCH QEMU-XEN v4 7/9] xen: Use stable library interfaces when they are available.

2015-10-23 Thread Stefano Stabellini
On Wed, 21 Oct 2015, Ian Campbell wrote: > In Xen 4.7 we are refactoring parts libxenctrl into a number of > separate libraries which will provide backward and forward API and ABI > compatiblity. > > Specifically libxenevtchn, libxengnttab and libxenforeignmemory. > > Previous patches have

Re: [Qemu-devel] [PATCH QEMU-XEN v4 1/9] xen_console: correctly cleanup primary console on teardown.

2015-10-22 Thread Stefano Stabellini
gt; > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > v4: New patch based on feedback to "xen: Switch uses of > xc_map_foreign_bulk to use libxenforeignmemory API." > --- > hw/char/xen_consol

Re: [Qemu-devel] [PATCH] xen-platform: Replace assert() with appropriate error reporting

2015-10-20 Thread Stefano Stabellini
On Mon, 19 Oct 2015, Paolo Bonzini wrote: > On 19/10/2015 20:39, Eduardo Habkost wrote: > > Commit dbb7405d8caad0814ceddd568cb49f163a847561 made it possible to > > trigger an assert using "-device xen-platform". Replace it with > > appropriate error reporting. > > > > Before: > > > > $

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-20 Thread Stefano Stabellini
On Mon, 19 Oct 2015, Laszlo Ersek wrote: > On 10/16/15 21:09, Laszlo Ersek wrote: > > On 10/16/15 13:34, Fabio Fantoni wrote: > >> Il 16/10/2015 12:47, Stefano Stabellini ha scritto: > >>> On Fri, 16 Oct 2015, Fabio Fantoni wrote: > >>>> I

Re: [Qemu-devel] [PATCH] xen: fix invalid assertion

2015-10-20 Thread Stefano Stabellini
On Mon, 19 Oct 2015, Paolo Bonzini wrote: > Asserting "true" is not that useful. > > Reported by Coverity. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > hw/xen/xen_pt_con

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-20 Thread Stefano Stabellini
On Tue, 20 Oct 2015, Laszlo Ersek wrote: > On 10/20/15 13:59, Stefano Stabellini wrote: > > On Mon, 19 Oct 2015, Laszlo Ersek wrote: > >> Could that be related to the issue you are experiencing with OVMF? > >> Because, OVMF implies HVM (or PV-on-HVM), and your report (

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Stefano Stabellini
On Mon, 19 Oct 2015, Gerd Hoffmann wrote: > Hi, > > > > I'm trying to follow this discussion as best as I am able, but my lack > > > of experience with Xen prevents me from really participating in a > > > meaningful way. > > > > > > (I see that Laszlo is still discussing some CD-ROM issues

[Qemu-devel] [PULL 1/2] pc: Require xen when initializing xenfv machine

2015-10-19 Thread Stefano Stabellini
From: Eduardo Habkost <ehabk...@redhat.com> Without this check, the xen-platform device will crash on reset if using the accel option with anything other than xen (e.g. "-machine xenfv,accel=kvm"). Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Reviewed-

[Qemu-devel] [PULL 2/2] xen-platform: Ensure xen is enabled when initializing

2015-10-19 Thread Stefano Stabellini
ecause the device is not hotpluggable, and the only code creating it (at pc_xen_hvm_init()) already checks xen_enabled(). Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellini <stefano.sta

[Qemu-devel] [PULL 0/2] Xen 2015-10-19-tag

2015-10-19 Thread Stefano Stabellini
The following changes since commit aedc8806172dd1ae904f04169ee3b19fce1d7893: Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20151019-1' into staging (2015-10-19 10:06:56 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Stefano Stabellini
On Fri, 16 Oct 2015, John Snow wrote: > On 10/13/2015 01:10 PM, Stefano Stabellini wrote: > > On Tue, 13 Oct 2015, John Snow wrote: > >> On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > >>> I added ahci disk support in libxl and using it for week seems that was >

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Stefano Stabellini
On Mon, 19 Oct 2015, Fabio Fantoni wrote: > Il 19/10/2015 12:18, Stefano Stabellini ha scritto: > > On Fri, 16 Oct 2015, John Snow wrote: > > > On 10/13/2015 01:10 PM, Stefano Stabellini wrote: > > > > On Tue, 13 Oct 2015, John Snow wrote: > > > > >

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Stefano Stabellini
On Mon, 19 Oct 2015, John Snow wrote: > On 10/19/2015 07:44 AM, Stefano Stabellini wrote: > > On Mon, 19 Oct 2015, Gerd Hoffmann wrote: > >> Hi, > >> > >>>> I'm trying to follow this discussion as best as I am able, but my lack > >>>> of

[Qemu-devel] [PATCH] xen_platform: switch to realize

2015-10-19 Thread Stefano Stabellini
Use realize to initialize the xen_platform device Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c index 8682c42..5bb701f 100644 --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@

Re: [Qemu-devel] [Xen-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Stefano Stabellini
On Fri, 16 Oct 2015, Laszlo Ersek wrote: > On 10/16/15 11:06, Stefano Stabellini wrote: > > On Thu, 15 Oct 2015, Kevin O'Connor wrote: > >> On Fri, Oct 16, 2015 at 01:10:54AM +0200, Laszlo Ersek wrote: > >>> On 10/14/15 13:27, Ian Campbell wrote: > >>>&g

Re: [Qemu-devel] [Xen-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Stefano Stabellini
On Thu, 15 Oct 2015, Kevin O'Connor wrote: > On Fri, Oct 16, 2015 at 01:10:54AM +0200, Laszlo Ersek wrote: > > On 10/14/15 13:27, Ian Campbell wrote: > > > On Wed, 2015-10-14 at 12:06 +0100, Stefano Stabellini wrote: > > >>> Can't you just teach SeaBI

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-16 Thread Stefano Stabellini
io Fantoni wrote: > > > > > Il 14/10/2015 13:06, Stefano Stabellini ha scritto: > > > > > > I would suggest Fabio to avoid AHCI disks altogether and just use > > > > > > OVMF > > > > > > with PV disks only and Anthony's pa

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Kevin Wolf wrote: > [ CC qemu-block ] > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > > On Tue, 13 Oct 2015, John Snow wrote: > > > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > > > I added ahci disk support

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-14 Thread Stefano Stabellini
On Wed, 14 Oct 2015, Kevin Wolf wrote: > Am 14.10.2015 um 13:06 hat Stefano Stabellini geschrieben: > > On Wed, 14 Oct 2015, Kevin Wolf wrote: > > > [ CC qemu-block ] > > > > > > Am 13.10.2015 um 19:10 hat Stefano Stabellini geschrieben: > >

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-13 Thread Stefano Stabellini
On Tue, 13 Oct 2015, John Snow wrote: > On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > > I added ahci disk support in libxl and using it for week seems that was > > ok, after a reply of Stefano Stabellini seems that xen disk unplug > > support only ide disks: > > http

Re: [Qemu-devel] [PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-12 Thread Stefano Stabellini
On Sun, 11 Oct 2015, Lan Tianyu wrote: > From: > > > msix->mmio is added to XenPCIPassthroughState's object as property. > object_finalize_child_property is called for XenPCIPassthroughState's > object, which calls object_property_del_all, which is going to try to > delete

Re: [Qemu-devel] [PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-12 Thread Stefano Stabellini
On Mon, 12 Oct 2015, Paolo Bonzini wrote: > On 12/10/2015 13:09, Stefano Stabellini wrote: > > On Sun, 11 Oct 2015, Lan Tianyu wrote: > >> From: <tianyu@intel.com>> > >> > >> msix->mmio is added to XenPCIPassthroughState's object as propert

Re: [Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-10-06 Thread Stefano Stabellini
On Fri, 25 Sep 2015, Ian Campbell wrote: > On Fri, 2015-09-18 at 16:30 +0800, Tiejun Chen wrote: > > Although we already have 'gfx_passthru' in b_info, this doesn't suffice > > after we want to handle IGD specifically. Now we define a new field of > > type, gfx_passthru_kind, to indicate we're

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-06 Thread Stefano Stabellini
On Tue, 6 Oct 2015, Paolo Bonzini wrote: > On 05/10/2015 18:53, Stefano Stabellini wrote: > >> This patch is to fix the issue via moving MSIX MMIO memory region into > >> struct XenPCIPassthroughState and free it together with pt device's obj. > > > > Give

Re: [Qemu-devel] [Fix PATCH] Qemu/Xen: Fix early freeing MSIX MMIO memory region

2015-10-05 Thread Stefano Stabellini
Hi Lan, thanks for the patch. On Wed, 30 Sep 2015, Lan Tianyu wrote: > MSIX MMIO memory region is added to pt device's obj as property. msix->mmio is added to XenPCIPassthroughState's object as property > When pt device is unplugged, all properties will be deleted and > memory region's obj is

Re: [Qemu-devel] qemu-system-arm: xen-domid not supported for this target

2015-10-02 Thread Stefano Stabellini
On Fri, 2 Oct 2015, Peter Maydell wrote: > On 2 October 2015 at 07:27, Alexander B. Ustinov > wrote: > > Hello, list. Hi! > > I'm trying to get arm guest running on amd64 dom0 system. Unfortunately it is not possible to run ARM guests on an x86 system with Xen. >

Re: [Qemu-devel] [PATCH 0/2] xen: Fix crash of "-machine xenfv, accel=kvm"

2015-09-30 Thread Stefano Stabellini
On Mon, 28 Sep 2015, Eduardo Habkost wrote: > This series fixes the following crash: > > $ ./x86_64-softmmu/qemu-system-x86_64 -machine xenfv,accel=kvm > Segmentation fault (core dumped) > > The crash happens because xen-platform calls xc_hvm_set_mem_type() with a NULL > xen_xc on reset, at

Re: [Qemu-devel] [PATCH 2/2] xen-platform: Ensure xen is enabled when initializing

2015-09-30 Thread Stefano Stabellini
he user because the device is not > hotpluggable, and the only code creating it (at pc_xen_hvm_init()) > already checks xen_enabled(). > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > hw

Re: [Qemu-devel] [PATCH 1/2] pc: Require xen when initializing xenfv machine

2015-09-30 Thread Stefano Stabellini
On Mon, 28 Sep 2015, Eduardo Habkost wrote: > Without this check, the xen-platform device will crash on reset > if using the accel option with anything other than xen (e.g. > "-machine xenfv,accel=kvm"). > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>

Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-29 Thread Stefano Stabellini
On Mon, 28 Sep 2015, Pasi Kärkkäinen wrote: > Hi, > > On Mon, Sep 28, 2015 at 11:01:11AM +0100, Stefano Stabellini wrote: > > No, unfortunately it is not possible at this stage of the release cycle. > > But users can still use QEMU 2.5 (as soon as it is released, which >

Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-28 Thread Stefano Stabellini
: > On 9/22/2015 12:03 AM, Stefano Stabellini wrote: > > It is going to be in QEMU 2.5 and qemu-xen 4.7. > > Thanks for your reply. > > Do we have any possibility of just merging this series into qemu-xen 4.6? We > really want to support IGD passthrough on xen 4.6 if possible

Re: [Qemu-devel] [Xen-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-21 Thread Stefano Stabellini
> > Thanks > Tiejun > > On 9/9/2015 1:21 AM, Stefano Stabellini wrote: > > The following changes since commit 8611280505119e296757a60711a881341603fa5a: > > > >target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200) > > > > are ava

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-17 Thread Stefano Stabellini
On Wed, 16 Sep 2015, Chen, Tiejun wrote: > On 9/15/2015 7:00 PM, Paolo Bonzini wrote: > > > > > > On 15/09/2015 11:55, Stefano Stabellini wrote: > > > On Mon, 14 Sep 2015, Paolo Bonzini wrote: > > > > > On 10/09/2015 12:29, Stefano Stabellini wrote

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-15 Thread Stefano Stabellini
On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 12:29, Stefano Stabellini wrote: > > +if (lseek(config_fd, pos, SEEK_SET) != pos) { > > +return -errno; > > +} > > do { > > -rc = pread(config_fd, (uint8_t *), len, pos);

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

2015-09-15 Thread Stefano Stabellini
CC Konrad On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 19:15, Stefano Stabellini wrote: > > + > > +switch (reg->size) { > > +case 1: rc = xen_host_pci_get_byte(>real_device, offset, > > (uint8_t *)); > > A bit ugly, and it

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

2015-09-15 Thread Stefano Stabellini
On Tue, 15 Sep 2015, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 15, 2015 at 11:07:02AM +0100, Stefano Stabellini wrote: > > CC Konrad > > > > On Mon, 14 Sep 2015, Paolo Bonzini wrote: > > > On 10/09/2015 19:15, Stefano Stabellini wrote: > > >

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > was set by configure. That won't be the case on OSX or Windows, where > > the Xen headers don't exist. > > > > Okay. This actually shouldn't be enabled on Windows so what about

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > As you see this short log, "hw/pci-assign: split pci-assign.c", so this > > > means I just extract something from the original hw/i386/kvm/pci-assign.c, > > > and here so I just keep those original head files residing > > > hw/i386/kvm/pci-assign.c,

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
CC Michael On Thu, 10 Sep 2015, Stefano Stabellini wrote: > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > xen-host-pci-device.c is only compiled if CONFIG_XEN_PCI_PASSTHROUGH > > > was set by configure. That won't be the case on OSX or Windows, where > > &g

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > CC Michael > > > > On Thu, 10 Sep 2015, Stefano Stabellini wrote: > > > On Thu, 10 Sep 2015, Chen, Tiejun wrote: > > > >

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-10 Thread Stefano Stabellini
On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > On Thu, Sep 10, 2015 at 12:26:21PM +0100, Stefano Stabellini wrote: > > On Thu, 10 Sep 2015, Michael S. Tsirkin wrote: > > > On Thu, Sep 10, 2015 at 11:29:18AM +0100, Stefano Stabellini wrote: > > > > CC Michael > &

[Qemu-devel] [PULL 01/29] xen-hvm: Add trace to ioreq

2015-09-10 Thread Stefano Stabellini
From: Don Slutz <dsl...@verizon.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Don Slutz <dsl...@verizon.com> --- trace-events |7 +++ xen-hvm.c| 21 + 2 files changed, 28 insertions(+) diff --git a/tr

[Qemu-devel] [PULL 10/29] xen, gfx passthrough: register host bridge specific to passthrough

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen <tiejun.c...@intel.com> Just register that pci host bridge specific to passthrough. Signed-off-by: Tiejun Chen <tiejun.c...@intel.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@e

[Qemu-devel] [PULL 04/29] piix: create host bridge to passthrough

2015-09-10 Thread Stefano Stabellini
ed-off-by: Tiejun Chen <tiejun.c...@intel.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> --- hw/pci-host/piix.c | 85 ++ include/hw/i386/pc.h |2 ++ 2 file

[Qemu-devel] [PULL 00/29] xen-2015-09-10-tag

2015-09-10 Thread Stefano Stabellini
The following changes since commit 8611280505119e296757a60711a881341603fa5a: target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-09-10-tag for you to fetch changes up

[Qemu-devel] [PULL 03/29] pc_init1: pass parameters just with types

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen <tiejun.c...@intel.com> Pass types to configure pc_init1(). Signed-off-by: Tiejun Chen <tiejun.c...@intel.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> --- hw/i386/pc_piix.c

[Qemu-devel] [PULL 06/29] xen, gfx passthrough: basic graphics passthrough support

2015-09-10 Thread Stefano Stabellini
ntel.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> --- hw/core/machine.c| 20 hw/xen/Makefile.objs |1 + hw/xen/xen-host-pci-device.c |5 ++ hw/xen/xen-host

[Qemu-devel] [PULL 07/29] xen, gfx passthrough: retrieve VGA BIOS to work

2015-09-10 Thread Stefano Stabellini
;tiejun.c...@intel.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> --- hw/xen/xen_pt.c | 10 ++ hw/xen/xen_pt.h |5 +++ hw/xen/

[Qemu-devel] [PULL 08/29] igd gfx passthrough: create a isa bridge

2015-09-10 Thread Stefano Stabellini
adwell). Signed-off-by: Tiejun Chen <tiejun.c...@intel.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> --- hw/i386/pc_piix.c| 112 ++ include/hw/i38

[Qemu-devel] [PULL 05/29] hw/pci-assign: split pci-assign.c

2015-09-10 Thread Stefano Stabellini
; Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Acked-by: Michael S. Tsirkin <m...@redhat.com> --- hw/i386/Makefile.objs |1 + hw/i386/kvm/pci-assign.c | 82 - hw/i386/pci-

[Qemu-devel] [PULL 09/29] xen, gfx passthrough: register a isa bridge

2015-09-10 Thread Stefano Stabellini
From: Tiejun Chen <tiejun.c...@intel.com> Currently we just register this isa bridge when we use IGD passthrough in Xen side. Signed-off-by: Tiejun Chen <tiejun.c...@intel.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellin

[Qemu-devel] [PULL 02/29] i440fx: make types configurable at run-time

2015-09-10 Thread Stefano Stabellini
From: "Michael S. Tsirkin" <m...@redhat.com> IGD passthrough wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Tiejun Chen <tiejun.c...@intel.co

[Qemu-devel] [PULL 14/29] xen/pt: Update comments with proper function name.

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> It has changed but the comments still refer to the old names. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Signed-off-by: Stefano Stabellin

[Qemu-devel] [PULL 23/29] xen/pt: Remove XenPTReg->data field.

2015-09-10 Thread Stefano Stabellini
change also exposes some mis-use: - In 'xen_pt_status_reg_init' we used u32 for the Capabilities Pointer register, but said register is an an u16. - In 'xen_pt_msgdata_reg_write' we used u32 but should have only use u16. Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Sign

[Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code.

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> We seem to only use these functions when de-activating the MSI - so just log errors. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Sign

[Qemu-devel] [PULL 24/29] xen/pt: Log xen_host_pci_get in two init functions

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> To help with troubleshooting in the field. Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Signed-off-by: Stefano Stabellini <stefano.sta

[Qemu-devel] [PULL 19/29] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.

2015-09-10 Thread Stefano Stabellini
rnings. This is not the case now but with the "xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config" we will hit - so this sync up the function to the rest of them. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w.

[Qemu-devel] [PULL 15/29] xen/pt: Make xen_pt_msi_set_enable static

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> As we do not use it outside our code. Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@e

[Qemu-devel] [PULL 17/29] xen: use errno instead of rc for xc_domain_add_to_physmap

2015-09-10 Thread Stefano Stabellini
libxc functions mentioned (same parameters) so we piggyback on the fact that Xen 4.6 has a new function: commit 504ed2053362381ac01b98db9313454488b7db40 "tools/libxc: Expose new hypercall xc_reserved_device_memory_map" and check for that. Reviewed-by: Stefano Stabellini <stefano.stabel

[Qemu-devel] [PULL 26/29] xen/pt: Make xen_pt_unregister_device idempotent

2015-09-10 Thread Stefano Stabellini
.exit (or for fun does it before calling .init!). Reviewed-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> --- hw/xen/xen-host-pci-device.c |

[Qemu-devel] [PULL 12/29] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting

2015-09-10 Thread Stefano Stabellini
From: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> .errors - as it will most likely have the proper error value. Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> Acked-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> Signed-off-by: Stefano Stabellin

[Qemu-devel] [PULL 13/29] xen/HVM: atomically access pointers in bufioreq handling

2015-09-10 Thread Stefano Stabellini
eulich <jbeul...@suse.com> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> --- configure | 27 +++ include/hw/xen/xen_common.h | 12 +++- xen-hvm.c | 26 ++ 3 files chan

<    5   6   7   8   9   10   11   12   13   14   >