Re: [PATCH v4] target: ppc: Use MSR_HVB bit to get the target endianness for memory dump

LE > LE powernv(OPAL/PowerNV) BE > LE pseries(OPAL/PowerNV/pSeries) KVMHV LE > LE pseries TCG LE > > Fixes: 5609400a4228 ("target/ppc: Set the correct endianness for powernv > memory > dumps") > Signed-off-by: Narayana Murty N Reviewed-by: Vaibhav Jain -- Cheers ~ Vaibhav

Re: [PATCH] target: ppc: Correctly initialize HILE in HID-0 for book3s processors

Hi Fabiano, Thanks for looking into this patch and apologies for the delayed reponse. Fabiano Rosas writes: > Narayana Murty N writes: > >> On PPC64 the HILE(Hypervisor Interrupt Little Endian) bit in HID-0 >> register needs to be initialized as per isa 3.0b[1] section >> 2.10. This bit gets

[PATCH v2] travis.yml: Add missing 'flex', 'bison' packages to 'GCC (user)' job

'bison' to the list of addon apt-packages for the 'GCC (user)' job. Signed-off-by: Vaibhav Jain --- Changelog: Since v1: Link: https://lore.kernel.org/qemu-devel/20230414210645.820204-2-vaib...@linux.ibm.com/ - Added 'bison' also to the addon package list (Thomas) - Updated the patch description

Re: [PATCH 2/2] travis.yml: Add missing 'flex' package to 'GCC (user)' job

Hi Thomas, Thanks for looking into this patch. My responses inline below: Thomas Huth writes: > On 14/04/2023 23.06, Vaibhav Jain wrote: >> Since commit fd8171fe52b5e("target/hexagon: import lexer for idef-parser") >> the >> hexagon target uses 'flex' to gener

Re: [PATCH 1/2] travis.yml: Add missing clang-10 package to the 'Clang (disable-tcg)' job

Hi Thomas, Thanks for reviewing this patch. My responses inline below: Thomas Huth writes: > On 14/04/2023 23.06, Vaibhav Jain wrote: >> Since commit 74a1b256d775("configure: Bump minimum Clang version to 10.0") >> qemu >> needs Clang version 10.0 as th

[PATCH 1/2] travis.yml: Add missing clang-10 package to the 'Clang (disable-tcg)' job

containers' '--disable-tcg' '--enable-kvm' '--disable-tools' '--enable-fdt=system' '--host-cc=clang' '--cxx=clang++' Fix this by adding 'clang-10' to the 'apt_packages' section of the "[s390x] Clang (disable-tcg)" job and updating the compiler to 'clang-10'. Signed-off-by: Vaibhav Jain

[PATCH 2/2] travis.yml: Add missing 'flex' package to 'GCC (user)' job

r)' job. Signed-off-by: Vaibhav Jain --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index 11894eb810..8dc71c294d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -237,6 +237,7 @@ jobs: - libglib2.0-dev - libgnutls28-dev

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

;target/ppc: Convert to tcg_ops restore_state_to_opc") > Fixes: 670f1da374 ("target/ppc: Implement hashst and hashchk") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/377 This should be Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1319 >

Re: [PATCH-for-7.2] target/ppc: Fix build warnings when building with 'disable-tcg'

Hi Philippe, Philippe Mathieu-Daudé writes: > > Oops sorry. > > Fixes: 61bd1d2942 ("target/ppc: Convert to tcg_ops restore_state_to_opc") Thanks for figuring and pointing this out > >> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c >> index a05a2ed595..94adcb766b 100644 >>

Re: [PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

Greg Kurz writes: > Hi Vaibhav, > Hey Greg, Good to see you, > Nice to see some people are still building QEMU at IBM ;-) Yeah, and will hopefully continue to do this in future :-) >> Reported-by: Kowshik Jois B S >> Signed-off-by: Vaibhav Jain >> --- > >

[PATCH] target/ppc: Fix build warnings when building with 'disable-tcg'

*cs, Fix this by wrapping these function definitions in 'ifdef CONFIG_TCG' so that they are only defined if qemu is compiled with '--enable-tcg' Reported-by: Kowshik Jois B S Signed-off-by: Vaibhav Jain --- target/ppc/cpu_init.c| 2 ++ target/ppc/excp_helper.c | 2 ++ 2 files changed, 4

[RFC PATCH v4] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

m: Fetch nvdimm performance stats from PHYP" https://lore.kernel.org/r/20200731064153.182203-2-vaib...@linux.ibm.com Signed-off-by: Vaibhav Jain --- Changelog Since RFC-v3: * Introduced consistent types 'perf_stat_id/val' for handling perf-stats in code rather than switching between u64 an

Re: [RFC PATCH v3] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

Thanks for looking into this patch David and Groug, David Gibson writes: > On Sat, May 15, 2021 at 01:07:59PM +0530, Vaibhav Jain wrote: >> Add support for H_SCM_PERFORMANCE_STATS described at [1] for >> spapr nvdimms. This enables guest to fetch performance stats[2] like &

[RFC PATCH v3] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

m: Fetch nvdimm performance stats from PHYP" https://lore.kernel.org/r/20200731064153.182203-2-vaib...@linux.ibm.com Signed-off-by: Vaibhav Jain --- Changelog Since RFC-v2: * s/SCM_STATS_MAX_OUTPUT_BUFFER/SCM_STATS_MIN_OUTPUT_BUFFER/ thats the minimum size buffer needed to return all s

Re: [RFC PATCH v2] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

Thanks for looking into this patch David David Gibson writes: > On Thu, May 06, 2021 at 08:19:24AM +0530, Vaibhav Jain wrote: >> Add support for H_SCM_PERFORMANCE_STATS described at [1] for >> spapr nvdimms. This enables guest to fetch performance stats[2] like >> expec

Re: [RFC-PATCH] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

:06:18PM +0530, Vaibhav Jain wrote: >> Thanks for looking into this patch David, >> >> David Gibson writes: >> >> > On Thu, Apr 15, 2021 at 01:23:43PM +0530, Vaibhav Jain wrote: >> >> Add support for H_SCM_PERFORMANCE_STATS described at [1] for

[RFC PATCH v2] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

m: Fetch nvdimm performance stats from PHYP" https://lore.kernel.org/r/20200731064153.182203-2-vaib...@linux.ibm.com Signed-off-by: Vaibhav Jain --- Changelog RFC-v1: * Removed empty lines from code [ David ] * Updated struct papr_scm_perf_stat to use uint64_t for statistic_id. * Added a hard

Re: [RFC-PATCH] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

Thanks for looking into this patch David, David Gibson writes: > On Thu, Apr 15, 2021 at 01:23:43PM +0530, Vaibhav Jain wrote: >> Add support for H_SCM_PERFORMANCE_STATS described at [1] for >> spapr nvdimms. This enables guest to fetch performance stats[2] like >> expec

[RFC-PATCH] ppc/spapr: Add support for H_SCM_PERFORMANCE_STATS hcall

://lore.kernel.org/r/20200731064153.182203-2-vaib...@linux.ibm.com Signed-off-by: Vaibhav Jain --- hw/ppc/spapr_nvdimm.c | 243 + include/hw/ppc/spapr.h | 19 +++- 2 files changed, 261 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_nvdimm.c b/hw/ppc/

[PATCH v3] ppc/spapr: Add support for implement support for H_SCM_HEALTH

ernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst#n220 [2] "powerpc/papr_scm: Mark nvdimm as unarmed if needed during probe" https://lore.kernel.org/linux-nvdimm/20210329113103.476760-1-vaib...@linux.ibm.com/ Signed-off-by: Vaibhav

Re: [PATCH v2] ppc/spapr: Add support for implement support for H_SCM_HEALTH

Hi Greg, Thanks for looking into this patch. Greg Kurz writes: > On Thu, 1 Apr 2021 13:26:11 +1100 > David Gibson wrote: > >> On Thu, Apr 01, 2021 at 06:35:19AM +0530, Vaibhav Jain wrote: >> > Add support for H_SCM_HEALTH hcall described at [1] for spapr >>

Re: [PATCH v2] ppc/spapr: Add support for implement support for H_SCM_HEALTH

Hi David, Thanks for looking into this patch David Gibson writes: > On Thu, Apr 01, 2021 at 06:35:19AM +0530, Vaibhav Jain wrote: >> Add support for H_SCM_HEALTH hcall described at [1] for spapr >> nvdimms. This enables guest to detect the 'unarmed' status of a >>

[PATCH v2] ppc/spapr: Add support for implement support for H_SCM_HEALTH

ernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst#n220 [2] "powerpc/papr_scm: Mark nvdimm as unarmed if needed during probe" https://lore.kernel.org/linux-nvdimm/20210329113103.476760-1-vaib...@linux.ibm.com/ Signed-off-by: Vaibhav

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

Thanks for looking into this patch, David Gibson writes: >> H_SCM_HEALTH specifications is already documented in linux kernel >> documentation at >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst > > Putting a reference to that in

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

Thanks for looking into this patch Greg. My responses below inline. Greg Kurz writes: > Hi Vaibhav, > > Great to see you around :-) :-) > > On Mon, 29 Mar 2021 21:52:59 +0530 > Vaibhav Jain wrote: > >> Add support for H_SCM_HEALTH hcall described at [1] for spa

Re: [PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

Hi Shiva, Thanks for reviweing this patch. My responses inline below; Shivaprasad G Bhat writes: >> >> +static target_ulong h_scm_health(PowerPCCPU *cpu, SpaprMachineState *spapr, >> + target_ulong opcode, target_ulong *args) >> +{ >> +uint32_t

[PATCH] ppc/spapr: Add support for implement support for H_SCM_HEALTH

ernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/powerpc/papr_hcalls.rst [2] "powerpc/papr_scm: Mark nvdimm as unarmed if needed during probe" https://lore.kernel.org/linux-nvdimm/20210329113103.476760-1-vaib...@linux.ibm.com/ Signed-off-by: Vaibhav Jain ---