On Wed, 2017-11-15 at 04:47 +0100, Marc-André Lureau wrote:
> Hi
>
> On Wed, Nov 15, 2017 at 2:16 AM, Stefan Berger
> wrote:
> >
> > On 11/14/2017 06:40 PM, Marc-André Lureau wrote:
> > >
> > >
> > > Hi
> > >
> > > On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
> > > wrote:
> > > >
> > > >
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> Commit c37cacabf22 moved tpm_cleanup() in the main loop exit, however
> this
> function is not available when compiling with --disable-tpm.
>
> Provides necessary stubs to keep code clean of #ifdef'fery.
>
> Reported-by: BALATON Z
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> Makefile.objs now checks for $(CONFIG_TPM).
>
> Suggested-by: Stefan Berger
> Signed-off-by: Philippe Mathieu-Daudé
> ---
Reviewed-by: Amarnath Valluri
> tpm.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/tpm.
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> a stub is now provided.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Tested-by: Richard W.M. Jones
Reviewed-by: Amarnath Valluri
> ---
> vl.c | 2 --
> 1 file changed, 2 deletions(-)
> Reviewed-by:
> diff --git a/vl.c b/vl.c
>
On Tue, 2017-10-24 at 08:35 +0200, Juan Quintela wrote:
> Commit
> c37cacabf2285b0731b44c1f667781fdd4f2b658
>
> broke compilation without tpm. Just add an #ifdef
>
> CC: Amarnath Valluri
> Signed-off-by: Juan Quintela
> ---
> tpm.c | 6 +-
> vl.c | 2 ++
> 2 files changed, 7 insertion
Sorry for causing build break :(
I would prefer the way tpm_init() was handled in vl.c, even
tpm_cleanup() shuould be guarded behind #ifdef CONFIG_TPM.
- Amarnath
On Wed, 2017-10-18 at 11:27 +0200, Juan Quintela wrote:
> Laurent Vivier wrote:
> >
> > On 18/10/2017 10:33, Juan Quintela wrote:
>
On Tue, 2017-10-10 at 06:47 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> >
> > On Tue, 2017-10-10 at 00:56 +0200, Marc-André Lureau wrote:
> > >
> > > Signed-off-by: Marc-André Lureau
> > > ---
> > > include/sysemu/tpm_backend.h | 2 +-
> > > hw/tpm/tpm_emulator.c
On Tue, 2017-10-10 at 00:56 +0200, Marc-André Lureau wrote:
> Store the TPM interface, the actual object may be different from
> TPMState. Keep a reference on the interface, and check the backend
> wasn't already initialized.
>
> Signed-off-by: Marc-André Lureau
> ---
> include/sysemu/tpm_backen
On Tue, 2017-10-10 at 00:56 +0200, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau
> ---
> include/sysemu/tpm_backend.h | 2 +-
> hw/tpm/tpm_emulator.c| 12 +++-
> hw/tpm/tpm_passthrough.c | 9 +++--
> tpm.c| 3 ++-
> 4 files changed,
>
> >
> > -.opts = tpm_emulator_cmdline_opts,
> > -.desc = "TPM emulator backend driver",
> And i feel, the above two members are better suited for Object
> members than Class.
>
Please ignore this comment, i was wrong.
- Amarnath
On Tue, 2017-10-10 at 00:55 +0200, Marc-André Lureau wrote:
> Use TPMBackendClass to hold class methods/fields.
>
> Signed-off-by: Marc-André Lureau
> ---
> include/sysemu/tpm_backend.h | 15 +--
> backends/tpm.c | 31 ---
> hw/tpm/tpm_emulat
On Tue, 2017-10-03 at 17:21 -0400, Stefan Berger wrote:
> On 09/29/2017 07:10 AM, Amarnath Valluri wrote:
> >
> > This change introduces a new TPM backend driver that can
> > communicate with
> > swtpm(software TPM emulator) using unix domain socket interface.
> > QEMU talks to
> > TPM emulator us
On Tue, 2017-09-26 at 14:24 +0200, Marc-André Lureau wrote:
> Hi
>
> On Tue, Sep 26, 2017 at 2:05 PM, Valluri, Amarnath
> wrote:
> >
> > Hi Marc,
> >
> > Thanks for your time reviewing this patchset. Please find my inline
> > comments.
> >
&
Hi Marc,
Thanks for your time reviewing this patchset. Please find my inline
comments.
On Sun, 2017-09-24 at 20:52 +0200, Marc-André Lureau wrote:
> Hi
>
> Thanks for the nice update, removing the exec() code, using chardev
> and a private socketpair. Some comments below:
>
> On Fri, Sep 22, 20
On Fri, 2017-09-22 at 17:35 +0200, Marc-André Lureau wrote:
> Hi
>
> On Fri, Sep 22, 2017 at 2:33 PM, Amarnath Valluri
> wrote:
> >
> > TPM configuration options are backend implementation details and
> > shall not be
> > part of base TPMBackend object, and these shall not be accessed
> > direct
On Tue, 2017-07-18 at 10:39 -0400, Stefan Berger wrote:
> On 07/18/2017 04:49 AM, Amarnath Valluri wrote:
> >
> > diff --git a/hw/tpm/Makefile.objs b/hw/tpm/Makefile.objs
> > index 64cecc3..41f0b7a 100644
> > --- a/hw/tpm/Makefile.objs
> > +++ b/hw/tpm/Makefile.objs
> > @@ -1,2 +1,3 @@
> > commo
On Mon, 2017-06-12 at 15:26 -0400, Stefan Berger wrote:
> On 06/05/2017 03:25 AM, Valluri, Amarnath wrote:
> >
> > On Wed, 2017-05-24 at 11:15 -0400, Stefan Berger wrote:
> > >
> > > On 05/16/2017 03:58 AM, Amarnath Valluri wrote:
> > > >
> >
On Wed, 2017-05-24 at 11:15 -0400, Stefan Berger wrote:
> On 05/16/2017 03:58 AM, Amarnath Valluri wrote:
> >
> > This change introduces a new TPM backend driver that can
> > communicate with
> > swtpm(software TPM emulator) using unix domain socket interface.
> >
> > Swtpm uses two unix sockets,
On Wed, 2017-05-24 at 14:34 +, Marc-André Lureau wrote:
Hi
On Tue, May 16, 2017 at 12:00 PM Amarnath Valluri
mailto:amarnath.vall...@intel.com>> wrote:
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class
member. The only possible reason for keeping in TPMBackend wa
Gentle request to review this patchset
> -Original Message-
> From: Valluri, Amarnath
> Sent: Tuesday, May 16, 2017 10:58 AM
> To: qemu-devel@nongnu.org
> Cc: Valluri, Amarnath
> Subject: [Qemu-devel][PATCH v4 0/8] Provide support for the software TPM
> emulator
>
20 matches
Mail list logo
