Re: [PATCH] i386: removes microvm from default build since microvm doesn't support Xen accel.

2024-06-03 Thread Vilhelm Gyda
On Mon, Jun 3, 2024 at 11:53 AM Paolo Bonzini wrote: > > On 6/2/24 12:38, Will Gyda wrote: > > i386: removes microvm from default build since microvm doesn't support Xen > > accel. > > > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2294 > > This is already done in (what will be) QEMU

Re: [PATCH] i386: removes microvm from default build since microvm doesn't support Xen accel.

2024-06-03 Thread Vilhelm Gyda
On Mon, Jun 3, 2024 at 1:10 PM Michael Tokarev wrote: > > 03.06.2024 10:31, Vilhelm Gyda wrote: > > We can remove Xen from default build too. Though, I think, regardless > > of Xen being in our out of default build, the "depends on" change in > > `hw/i386/Kconfi

Re: [PATCH] i386: removes microvm from default build since microvm doesn't support Xen accel.

2024-06-03 Thread Vilhelm Gyda
We can remove Xen from default build too. Though, I think, regardless of Xen being in our out of default build, the "depends on" change in `hw/i386/Kconfig` is essential in itself to cover the case when a user builds with Xen only. In case of a Xen only build by user, without the proposed Kconfig c

Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64

2024-05-29 Thread Vilhelm Gyda
On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis wrote: > What about TCG? Will it be available if we only build with tcg? I will try doing this, and report back, and will make the suggested changes, and re-submit. On Wed, May 29, 2024 at 3:58 PM Manos Pitsidianakis wrote: > > On Tue, 28 May

Re: [PATCH] Issue #2294 | Machine microvm doesn't run under Xen accel for x86_64

2024-05-29 Thread Vilhelm Gyda
@philmd commented on gitlab: Discussed with @epilys on IRC, only Xen machines (xenpv/xenfv) configure Xen so can run under it. But if we want to make it work under Xen. Any ideas how to move in that direction? On Wed, May 29, 2024 at 12:37 PM Paolo Bonzini wrote: > > On 5/28/24 12:23, Will Gyda

Re: [PATCH] migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro

2024-04-25 Thread Vilhelm Gyda
ocs/master/devel/submitting-a-patch.html > > > > > On Thu, Apr 25, 2024 at 06:08:58PM +0530, Vilhelm Gyda wrote: > > > Hi, I am new here. This trivial patch is my first contribution. I am > > > not sure who to cc for the review. Checking qemu/MAINTAINERS you guys

Issue#414 and qemu_mutex_lock() API Conversion

2024-04-19 Thread Vilhelm Gyda
Hi, I am new here, so I found some issues suitable for beginners at [1]. I am currently looking at the API Conversion task of replacing `qemu_mutex_lock()` and `qemu_mutex_unlock()` with `QEMU_LOCK_GUARD()` After reading the macro definition of `QEMU_LOCK_GUARD()` and `WITH_QEMU_LOCK_GUARD()`, I