Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-12 Thread Yehuda Sadeh Weinraub
On Sun, Sep 11, 2011 at 8:17 PM, Yehuda Sadeh Weinraub yehud...@gmail.com wrote: On Sun, Sep 11, 2011 at 8:14 PM, Sage Weil s...@newdream.net wrote: On Fri, 9 Sep 2011, Kevin Wolf wrote: Am 08.09.2011 18:36, schrieb Sage Weil: On Thu, 8 Sep 2011, Kevin Wolf wrote: Am 08.09.2011 01:06

Re: [Qemu-devel] [PATCH 1/1] qemu-img: async write to block device when converting image

2011-09-12 Thread Yehuda Sadeh Weinraub
Note that I assumed qemu-img runs in a single context (like qemu), and there are no concurrency issues. If that's not the case, the callback, error handling need to be fixed. Yehuda On Mon, Sep 12, 2011 at 7:26 AM, Yehuda Sadeh yeh...@hq.newdream.net wrote: In order to improve image conversion

Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-11 Thread Yehuda Sadeh Weinraub
On Sun, Sep 11, 2011 at 8:14 PM, Sage Weil s...@newdream.net wrote: On Fri, 9 Sep 2011, Kevin Wolf wrote: Am 08.09.2011 18:36, schrieb Sage Weil: On Thu, 8 Sep 2011, Kevin Wolf wrote: Am 08.09.2011 01:06, schrieb Yehuda Sadeh: The following set of patches improve the qemu-img conversion

[Qemu-devel] Re: [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-04-07 Thread Yehuda Sadeh Weinraub
On Thu, Apr 7, 2011 at 2:54 AM, Yoshiaki Tamura tamura.yoshi...@gmail.com wrote: 2011/4/7 Stefan Hajnoczi stefa...@gmail.com: On Thu, Apr 07, 2011 at 10:14:03AM +0900, Yoshiaki Tamura wrote: 2011/3/29 Josh Durgin josh.dur...@dreamhost.com: The new format is

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-12-06 Thread Yehuda Sadeh Weinraub
On Mon, Dec 6, 2010 at 4:48 AM, Kevin Wolf kw...@redhat.com wrote: What's the easiest way to try it out? I tried to use vstart.sh and copy the generated ceph.conf to /etc/ceph/ceph.conf so that qemu-img etc. find the monitor address. However, that leads to a hang when I try rbd list or

Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v8)

2010-11-29 Thread Yehuda Sadeh Weinraub
On Mon, 2010-11-29 at 11:02 +0100, Kevin Wolf wrote: Am 29.11.2010 09:59, schrieb Kevin Wolf: Am 27.11.2010 08:12, schrieb Stefan Hajnoczi: On Fri, Nov 26, 2010 at 9:59 PM, Christian Brunner c.m.brun...@gmail.com wrote: Thanks for the review. What am I supposed to do now? Kevin is the

[Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v7)

2010-11-15 Thread Yehuda Sadeh Weinraub
On Mon, Nov 15, 2010 at 9:04 AM, Christian Brunner c.m.brun...@gmail.com wrote: Hi Stefan, thanks for your feedback. Yehuda and Sage have already committed some pathes to our git repository. What I'm not sure about is the rados_(de)initialization for multiple rbd images. I suspect that

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v6)

2010-10-14 Thread Yehuda Sadeh Weinraub
See my comments below, updated patch will follow later: On Tue, Oct 12, 2010 at 3:57 PM, Anthony Liguori anth...@codemonkey.ws wrote: ... + +static int rbd_parsename(const char *filename, char *pool, char **snap, +                         char *name) +{ +    const char *rbdname; +    char

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v6)

2010-10-14 Thread Yehuda Sadeh Weinraub
See my comments: On Wed, Oct 13, 2010 at 1:41 AM, Stefan Hajnoczi stefa...@gmail.com wrote: + +    cpu_to_le32s(snap_count); +    cpu_to_le64s(snap_names_len); Redone all endianity conversions, made it so that it keeps the header as little endian, and whenever reading the header, do the

Re: [Qemu-devel] [PATCH -v5] ceph/rbd block driver for qemu-kvm

2010-10-09 Thread Yehuda Sadeh Weinraub
On Sat, Oct 9, 2010 at 2:21 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Oct 8, 2010 at 8:00 PM, Yehuda Sadeh yeh...@hq.newdream.net wrote: No flush operation is supported.  Can the guest be sure written data is on stable storage when it receives completion? That's part of the

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-08 Thread Yehuda Sadeh Weinraub
On Fri, Oct 8, 2010 at 7:06 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/07/2010 05:45 PM, Sage Weil wrote: I'm sorry, I'm having a hard time understanding what it is you're objecting to, or what you would prefer, as there are two different things we're talking about here (callbacks

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 7:12 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 08/03/2010 03:14 PM, Christian Brunner wrote: +#include qemu-common.h +#include qemu-error.h +#includesys/types.h +#includestdbool.h + +#includeqemu-common.h This looks to be unnecessary.  Generally, system

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 11:38 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/07/2010 01:08 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 7:12 AM, Anthony Liguorianth...@codemonkey.ws  wrote: On 08/03/2010 03:14 PM, Christian Brunner wrote: +#include qemu-common.h

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 12:51 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/07/2010 01:41 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 11:38 AM, Anthony Liguorianth...@codemonkey.ws  wrote: On 10/07/2010 01:08 PM, Yehuda Sadeh Weinraub wrote: On Thu, Oct 7, 2010 at 7:12

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-10-07 Thread Yehuda Sadeh Weinraub
On Thu, Oct 7, 2010 at 2:04 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/07/2010 03:47 PM, Yehuda Sadeh Weinraub wrote: How is that possible?  Are the callbacks delivered in the context of a different thread?  If so, don't you need locking? Not sure I'm completely following you

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v4)

2010-09-22 Thread Yehuda Sadeh Weinraub
Following up on this one, I'd like to know whether there is any pending issue preventing rbd from being included upstream. Thanks, Yehuda On Tue, Aug 3, 2010 at 1:14 PM, Christian Brunner c...@muc.de wrote: On Tue, Aug 03, 2010 at 12:37:18AM +0400, malc wrote: Thare are whitespace issues in

Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-07-13 Thread Yehuda Sadeh Weinraub
On Sat, Jun 19, 2010 at 8:48 AM, Christian Brunner c...@muc.de wrote: Are you going to send a final version which includes Simone's patch or should I apply them as two patches and just accept that rbd is broken after the first one? Or were there any other problems that need to be solved

Re: [Qemu-devel] Re: [PATCH] ceph/rbd block driver for qemu-kvm (v3)

2010-07-13 Thread Yehuda Sadeh Weinraub
On Tue, Jul 13, 2010 at 12:23 PM, Christian Brunner c...@muc.de wrote: On Tue, Jul 13, 2010 at 11:27:03AM -0700, Yehuda Sadeh Weinraub wrote: There is another problem with very large i/o requests. I suspect that this can be triggered only with qemu-io and not in kvm, but I'll try to get

Re: [Qemu-devel] [RFC PATCH 1/1] ceph/rbd block driver for qemu-kvm

2010-05-23 Thread Yehuda Sadeh Weinraub
On Sun, May 23, 2010 at 12:59 AM, Blue Swirl blauwir...@gmail.com wrote: On Thu, May 20, 2010 at 11:02 PM, Yehuda Sadeh Weinraub yehud...@gmail.com wrote: On Thu, May 20, 2010 at 1:31 PM, Blue Swirl blauwir...@gmail.com wrote: On Wed, May 19, 2010 at 7:22 PM, Christian Brunner c...@muc.de