[PATCH v5 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 52 ++ meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v5 1/4] docs: Fixes build docs on msys2/mingw

2020-10-16 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Add the perl as the first parameter Signed-off-by: Yonggang Luo --- docs/sphinx/kerneldoc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/kerneldoc.py b/docs/sphinx/kerneldoc.py index 3e879

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 4:05 PM Paolo Bonzini wrote: > > On 16/10/20 09:57, Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > >> > >>> build_docs = false > >>> if sphinx_build.found() > >>> # This is a bit awkward

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 3:57 PM Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > > > >> build_docs = false > >> if sphinx_build.found() > >> # This is a bit awkward but works: create a trivial document and > >> # try to ru

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 3:57 PM Paolo Bonzini wrote: > > On 16/10/20 09:52, 罗勇刚(Yonggang Luo) wrote: > > > >> build_docs = false > >> if sphinx_build.found() > >> # This is a bit awkward but works: create a trivial document and > >> # try to ru

Re: [PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-16 Thread Yonggang Luo
ot build_docs > if sphinx_build_option != '' > warning('@0@ exists but it is either too old or uses too old a Python version'.format(sphinx_build_option)) > endif > if get_option('docs').enabled() > error('Install a Python 3 version

Re: [PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 6:19 AM Paolo Bonzini wrote: > > > > Il ven 16 ott 2020, 00:06 Yonggang Luo ha scritto: >> >> meson didn't support running ../scripts/kernel-do directly > > > Can you explain why this matters? Meson does not look at docs/conf.py. >

[PATCH v4 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++--- docs/meson.build | 4 +-- meson.build | 60 +++ meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v4 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v4 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 --- a

[PATCH v4 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
false v1 - v2 Also move the docs configure part from configure to meson, this also fixed the pending ninjatool removal caused issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is.

[PATCH v4 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$o

Re: [PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 5:53 AM Paolo Bonzini wrote: > > Looks good, apart from the CR removal patch that can simply be dropped. Resend with fixes, the CR removal patch composite two part. > > Paolo > > Il gio 15 ott 2020, 22:10 Yonggang Luo ha scritto: >> >>

[PATCH v3 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 59 ++- meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v3 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v3 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
re to meson, this also fixed the pending ninjatool removal caused issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is. meson: Move the detection logic for sphinx to meson c

[PATCH v3 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$o

[PATCH v3 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
meson didn't support running ../scripts/kernel-do directly Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/conf.py b/docs/conf.py index 00e1b750e2..e584f68393 100644 --- a

Re: [PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Grep qemu_docdir and docdir in configure, you will know why, qemu_docdir not used at all in configure, On Fri, Oct 16, 2020 at 5:24 AM Paolo Bonzini wrote: > > Why? > > Paolo > > Il gio 15 ott 2020, 22:11 Yonggang Luo ha scritto: >> >> Signed-off-by: Yonggang

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
It's tests, running by make On Fri, Oct 16, 2020 at 5:23 AM Paolo Bonzini wrote: > > > > Il gio 15 ott 2020, 22:30 Peter Maydell ha scritto: >> >> On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: >> > >> > Signed-off-by: Yonggang Luo &g

Re: [PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
On Fri, Oct 16, 2020 at 4:30 AM Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 21:13, Yonggang Luo wrote: > > > > Signed-off-by: Yonggang Luo > > --- > > docs/conf.py | 2 +- > > docs/sphinx/kerneldoc.py | 2 +- >

[PATCH v3 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-10-15 Thread Yonggang Luo
n-void function [-Werror=return-type] 752 | } | ^ On msys2/mingw, there is no st_blocks in struct _stat64 yet, we disable the usage of it on msys2/mingw, and create a typedef long long blkcnt_t; for further implementation Signed-off-by: Yonggang Luo --- block/nfs.c | 15

[PATCH v3 0/2] Fixes building nfs on msys2/mingw

2020-10-15 Thread Yonggang Luo
Revise the commit message of * block: enable libnfs on msys2/mingw in cirrus.yml V1-V2 Apply suggestion from Peter Lieven Yonggang Luo (2): block: Fixes nfs compiling error on msys2/mingw block: enable libnfs on msys2/mingw in cirrus.yml .cirrus.yml | 1 + block/nfs.c | 15

[PATCH v3 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-10-15 Thread Yonggang Luo
Initially, libnfs has not been enabled, and now it's fixed, so enable it on cirrus. Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index f42ccb956a..2c6bf45e6d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -109,6 +

[PATCH v2 3/4] meson: Move the detection logic for sphinx to meson

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 59 +++ docs/meson.build | 4 +-- meson.build | 59 ++- meson_options.txt | 5 ++- tests/qapi-schema/meson.build | 2 +- 5

[PATCH v2 0/4] Fixes docs building on msys2/mingw

2020-10-15 Thread Yonggang Luo
v1 - v2 Also move the docs configure part from configure to meson, this also fixed the pending ninjatool removal caused issue that docs can not be build under msys2/mingw Yonggang Luo (4): docs: Fixes build docs on msys2/mingw configure: the docdir option should passed to meson as is

[PATCH v2 2/4] configure: the docdir option should passed to meson as is.

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- configure | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure b/configure index f839c2a557..1ce31f97b4 100755 --- a/configure +++ b/configure @@ -971,7 +971,7 @@ for opt do ;; --with-suffix=*) qemu_suffix="$o

[PATCH v2 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-15 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v2 1/4] docs: Fixes build docs on msys2/mingw

2020-10-15 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 scripts/rst

Re: [PATCH 0/7] build: replace ninjatool with ninja

2020-10-15 Thread Yonggang Luo
t-replication.exe tests/test-shift128.exe tests/test-string-input-visitor.exe tests/test-string-output-visitor.exe tests/test-thread-pool.exe tests/test-throttle.exe tests/test-timed-average.exe tests/test-util-sockets.exe tests/test-uuid.exe tests/test-visitor-serialization.exe tests/test-vmstate.exe tests/test-write-threshold.exe tests/test-x86-cpuid.exe tests/test-xbzrle.exe | cat ``` That's because currently sphinx-build are found in configure not in meson, maybe it's worth to move the sphinx related thing into meson totally. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] meson.build: don't condition iconv detection on library detection

2020-10-14 Thread Yonggang Luo
ncies: [libiconv]) > + iconv = declare_dependency(dependencies: [libiconv]) >endif > endif > if get_option('iconv').enabled() and not iconv.found() > -- > 2.28.0 > Reviewed-by: Yonggang Luouoyongg...@gmail.com> -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 5/9] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

2020-10-14 Thread Yonggang Luo
If iconv installed then it's the meson's probme that didn't found the iconv properly On Thu, Oct 15, 2020 at 2:22 AM Bruce Rogers wrote: > > On Wed, 2020-10-14 at 10:21 +0200, Gerd Hoffmann wrote: > > From: Yonggang Luo > > > > The mingw pkg-config

Re: [PULL 5/9] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

2020-10-14 Thread Yonggang Luo
Because you didn't install the iconv. On Thu, Oct 15, 2020 at 2:22 AM Bruce Rogers wrote: > > On Wed, 2020-10-14 at 10:21 +0200, Gerd Hoffmann wrote: > > From: Yonggang Luo > > > > The mingw pkg-config are showing following absolute path and co

Re: [PATCH v3 RESEND] fcntl: Add 32bit filesystem mode

2020-10-13 Thread Yonggang Luo
*/ > +/* > + * This instructs the kernel to provide 32bit semantics (such as hashes) from > + * the file system layer, when running a userland that depend on 32bit > + * semantics on a kernel that supports 64bit userland, but does not use the > + * compat ioctl() for e.g. open(), so that the kernel would otherwise assume > + * that the userland process is capable of dealing with 64bit semantics. > + */ > +#define FD_32BIT_MODE 2 > > /* for posix fcntl() and lockf() */ > #ifndef F_RDLCK > -- > 2.26.2 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v7 2/4] gitignore: ignore a bit more

2020-10-13 Thread Yonggang Luo
On Tue, Oct 13, 2020 at 5:02 PM Thomas Huth wrote: > > On 13/10/2020 10.53, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé < phi...@redhat.com > > <mailto:phi...@redhat.com>> wrote: > >> > >>

Re: [PATCH v7 2/4] gitignore: ignore a bit more

2020-10-13 Thread Yonggang Luo
On Tue, Oct 13, 2020 at 4:38 PM Philippe Mathieu-Daudé wrote: > > On 10/13/20 1:37 AM, Yonggang Luo wrote: > > Enable the creating multiple build directory at the source root. > > Ignore /meson/ and /roms/ for better search experience. > > > > Signed-off-by: Yonggang

[PATCH 2/2] gcrypt: Enable crypto tests under msys2/mingw

2020-10-12 Thread Yonggang Luo
no properly. Use g_remove instead unlink Use g_mkdir instead mkdir Signed-off-by: Yonggang Luo --- include/qemu/osdep.h | 1 + include/sysemu/os-win32.h| 5 +++ tests/crypto-tls-psk-helpers.c | 4 +- tests/crypto-tls-x509-helpers.c | 6 ++- tests/crypto-tls-x509-helper

[PATCH 1/2] gcrypt: test_tls_psk_init should write binary file instead text file.

2020-10-12 Thread Yonggang Luo
On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/crypto-tls-p

[PATCH 0/2] Fixes gcrypt testing on msys2/mingw

2020-10-12 Thread Yonggang Luo
gcrypt: test_tls_psk_init should write binary file instead text file. gcrypt: Enable crypto tests under msys2/mingw by implement custom qemu_socket= pair Yonggang Luo (2): gcrypt: test_tls_psk_init should write binary file instead text file. gcrypt: Enable crypto tests under msys2/mingw

[PATCH v6 5/5] cirrus: Enable plugins in cirrus for windows

2020-10-12 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index 2c6bf45e6d..56ccb25bec 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -129,6 +129,7 @@ windows_msys2_task: script: - C:\tools\msys64\usr\bin\bash.exe -lc "

[PATCH v6 4/5] plugins: Getting qemu-plugin.h can be included in multiple source file

2020-10-12 Thread Yonggang Luo
user and should use extern Signed-off-by: Yonggang Luo --- contrib/plugins/hotblocks.c | 1 + contrib/plugins/hotpages.c | 1 + contrib/plugins/howvec.c| 1 + contrib/plugins/lockstep.c | 1 + include/qemu/qemu-plugin.h | 6 ++ plugins/core.c | 1 + tests/plugin/bb.c

[PATCH v6 3/5] plugins: Getting qemu-plugin works under win32.

2020-10-12 Thread Yonggang Luo
loading it in qemu_plugin_initialize, so we need a list of function pointer deceleration such as QEMU_PLUGIN_EXTERN qemu_plugin_uninstall_t qemu_plugin_uninstall; Signed-off-by: Yonggang Luo --- Makefile | 1 - configure| 71 - include/qemu/qemu

[PATCH v6 0/5] Enable plugin support on msys2/mingw

2020-10-12 Thread Yonggang Luo
dlsym f= unctional. Yonggang Luo (5): plugins: getting qemu_plugin_get_hwaddr only expose one function prototype plugins: Fixes typo in qemu-plugin.h plugins: Getting qemu-plugin works under win32. plugins: Getting qemu-plugin.h can be included in multiple source file cirrus: Enable

[PATCH v6 2/5] plugins: Fixes typo in qemu-plugin.h

2020-10-12 Thread Yonggang Luo
Getting the comment consistence with the function name Signed-off-by: Yonggang Luo --- include/qemu/qemu-plugin.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index bab8b0d4b3..daac8291b8 100644 --- a/include

[PATCH v6 1/5] plugins: getting qemu_plugin_get_hwaddr only expose one function prototype

2020-10-12 Thread Yonggang Luo
This is used for counting how much function are export to qemu plugin. Signed-off-by: Yonggang Luo Reviewed-by: Alex Bennée --- plugins/api.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/plugins/api.c b/plugins/api.c index bbdc5a4eb4..13177d3578 100644 --- a

[PATCH v2 2/2] block: enable libnfs on msys2/mingw in cirrus.yml

2020-10-12 Thread Yonggang Luo
At the begging libnfs are not enabled because of compiling error, now it's fixed so enable it Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index f42ccb956a..2c6bf45e6d 100644 --- a/.cirrus.yml +++ b/.cirru

[PATCH v2 1/2] block: Fixes nfs compiling error on msys2/mingw

2020-10-12 Thread Yonggang Luo
n-void function [-Werror=return-type] 752 | } | ^ On msys2/mingw, there is no st_blocks in struct _stat64 yet, we disable the usage of it on msys2/mingw, and create a typedef long long blkcnt_t; for further implementation Signed-off-by: Yonggang Luo --- block/nfs.c | 15

[PATCH v2 0/2] Fixes building nfs on msys2/mingw

2020-10-12 Thread Yonggang Luo
V1-V2 Apply suggestion from Peter Lieven Yonggang Luo (2): block: Fixes nfs compiling error on msys2/mingw block: enable libnfs on msys2/mingw in cirrus.yml .cirrus.yml | 1 + block/nfs.c | 15 +++ 2 files changed, 16 insertions(+) -- 2.28.0.windows.1

[PATCH v9 4/5] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw

2020-10-12 Thread Yonggang Luo
nline char *__CRTDECL ctime_r(const time_t *_Time, char *_Str) { return ctime_s(_Str, 0x7fff, _Time) ? NULL : _Str; } __forceinline char *__CRTDECL asctime_r(const struct tm *_Tm, char * _Str) { return asctime_s(_Str, 0x7fff, _Tm) ? NULL : _Str; } #endif ``` Signed-off-by: Yonggang Luo

[PATCH v9 3/5] curses: Fixes curses compiling errors.

2020-10-12 Thread Yonggang Luo
^ cc1.exe: all warnings being treated as errors gcc version 10.2.0 (Rev1, Built by MSYS2 project) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/c

[PATCH v9 5/5] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

2020-10-12 Thread Yonggang Luo
-I/usr/include/ncursesw -lcursesw Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann --- configure | 118 +++--- meson.build | 83 +++- meson_options.txt | 4 ++ ui/meson.build| 2 +- 4 files changed

[PATCH v9 2/5] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw

2020-10-12 Thread Yonggang Luo
using g_get_codeset instead of nl_langinfo(CODESET) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- configure | 5 + ui/curses.c | 10 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/configure b/configure index

[PATCH v9 1/5] configure: fixes indent of $meson setup

2020-10-12 Thread Yonggang Luo
convert these line from tab to space Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index b553288c5e..1b63488521 100755 --- a/configure +++ b/configure

[PATCH v9 0/5] Fixes curses on msys2/mingw

2020-10-12 Thread Yonggang Luo
detection. Add * configure: fixes indent of $meson setup Yonggang Luo (5): configure: fixes indent of $meson setup curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw curses: Fixes curses compiling errors. win32: Simplify gmtime_r detection no

[PATCH v7 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-12 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Remove the need of university mirror, the main repo are recovered. Signed-off-by: Yonggang Luo --- .cirrus.yml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index

[PATCH v7 3/4] docs: Fixes build docs on msys2/mingw

2020-10-12 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 scripts/rst

[PATCH v7 0/4] Improve cirrus msys2

2020-10-12 Thread Yonggang Luo
downloading archive file V2-V3 Add one more patch: cirrus: msys2/mingw speed is up, add excluded target back Do not build sphinx on windows, that's failing set the number of parallel count to fixed number 8 V1-V2 Resolve the cirrus conflict Yonggang Luo (4): scripts: Convert qemu-version.sh to

[PATCH v7 1/4] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-12 Thread Yonggang Luo
CYGWIN=noglob and MSYS=noglob in the environment variable for disable wildcard expanding in msys or cygwin git, and setting the shell=False Signed-off-by: Yonggang Luo Message-Id: <20201006112139.700-1-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- meson.build | 2 +- s

[PATCH v7 2/4] gitignore: ignore a bit more

2020-10-12 Thread Yonggang Luo
Enable the creating multiple build directory at the source root. Ignore /meson/ and /roms/ for better search experience. Signed-off-by: Yonggang Luo --- .gitignore | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index b32bca1315..f78ee9f297 100644

What's this error means? On windows, it's randomly failing

2020-10-09 Thread Yonggang Luo
, Yonggang Luo

Re: How about using clang-format instead checkpatch for fixing style?

2020-10-09 Thread Yonggang Luo
On Fri, Oct 9, 2020 at 9:25 PM Paolo Bonzini wrote: > > On 09/10/20 15:02, 罗勇刚(Yonggang Luo) wrote: > > We can even using clang-format to format the whole repository. > > checkpatch does other checks than formatting. > > Reformatting the whole repository has been ment

Re: How about using clang-format instead checkpatch for fixing style?

2020-10-09 Thread Yonggang Luo
On Fri, Oct 9, 2020 at 9:38 PM Daniel P. Berrangé wrote: > > On Fri, Oct 09, 2020 at 03:25:04PM +0200, Paolo Bonzini wrote: > > On 09/10/20 15:02, 罗勇刚(Yonggang Luo) wrote: > > > We can even using clang-format to format the whole repository. > > > > checkpatch

Re: How about using clang-format instead checkpatch for fixing style?

2020-10-09 Thread Yonggang Luo
On Fri, Oct 9, 2020 at 9:25 PM Paolo Bonzini wrote: > > On 09/10/20 15:02, 罗勇刚(Yonggang Luo) wrote: > > We can even using clang-format to format the whole repository. > > checkpatch does other checks than formatting. > > Reformatting the whole repository has been ment

How about using clang-format instead checkpatch for fixing style?

2020-10-09 Thread Yonggang Luo
We can even using clang-format to format the whole repository. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v6 0/4] Improve cirrus msys2

2020-10-09 Thread Yonggang Luo
Hi, alex, the msys2 main repo are back, so I removed the university mirror On Fri, Oct 9, 2020 at 7:08 PM Yonggang Luo wrote: > > Fixes the broken msys2/mingw ci and speed it up. > > V5-V6 > Remove the university mirror, the main repo are back. > rename to setup_script. >

[PATCH v6 1/4] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-09 Thread Yonggang Luo
/html/qemu-devel/2020-10/msg00072.html Signed-off-by: Yonggang Luo --- .cirrus.yml | 111 +++- 1 file changed, 66 insertions(+), 45 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index d58782ce67..ed3db10e45 100644 --- a/.cirrus.yml +++ b

[PATCH v6 4/4] cirrus: Enable doc build on msys2/mingw

2020-10-09 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Signed-off-by: Yonggang Luo --- .cirrus.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index d1fe63b343..599fd299e3 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -110,6 +110,11

[PATCH v6 0/4] Improve cirrus msys2

2020-10-09 Thread Yonggang Luo
er of parallel count to fixed number 8 V1-V2 Resolve the cirrus conflict Yonggang Luo (4): cirrus: Fixing and speedup the msys2/mingw CI cirrus: msys2/mingw speed is up, add excluded target back docs: Fixes build docs on msys2/mingw cirrus: Enable doc build on msys2/mingw .cirru

[PATCH v6 2/4] cirrus: msys2/mingw speed is up, add excluded target back

2020-10-09 Thread Yonggang Luo
The following target are add back: i386-softmmu,arm-softmmu,ppc-softmmu,mips-softmmu Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index ed3db10e45..d1fe63b343 100644 --- a/.cirrus.yml +++ b

[PATCH v6 3/4] docs: Fixes build docs on msys2/mingw

2020-10-09 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 scripts/rst

[PATCH 2/2] cirrus: Enable doc build on msys2/mingw

2020-10-08 Thread Yonggang Luo
Currently rST depends on old version sphinx-2.x. Install it by downloading it. Signed-off-by: Yonggang Luo --- .cirrus.yml | 8 1 file changed, 8 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 77cfd99afe..b1725bd0c1 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -73,6 +73,7

Re:

2020-10-08 Thread Yonggang Luo
Oh, I've fixed it and patch are sent. On Fri, Oct 9, 2020 at 3:24 AM Paolo Bonzini wrote: > > On 08/10/20 20:30, 罗勇刚(Yonggang Luo) wrote: > > > > > > The text files are in tests/qapi-schema. > > "C:/CI-Tools/msys64/mingw64/bin/python3.exe" > > &

[PATCH 1/2] docs: Fixes build docs on msys2/mingw

2020-10-08 Thread Yonggang Luo
Signed-off-by: Yonggang Luo --- docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py | 21 + tests/qapi-schema/meson.build | 5 +++-- 4 files changed, 26 insertions(+), 4 deletions(-) create mode 100644 scripts/rst

[PATCH 0/2] Fixes docs building on msys2/mingw

2020-10-08 Thread Yonggang Luo
The cirrus are based on non-merged patches Yonggang Luo (2): docs: Fixes build docs on msys2/mingw cirrus: Enable doc build on msys2/mingw .cirrus.yml | 8 docs/conf.py | 2 +- docs/sphinx/kerneldoc.py | 2 +- scripts/rst-sanitize.py

[no subject]

2020-10-08 Thread Yonggang Luo
t;C:/work/xemu/qemu/meson/meson.py" "--internal" "exe" "--capture" "tests/qapi-schema/doc-good.txt.nocr" "--" "perl" "-pe" "$x = chr 13; s/$x$//" "tests/qapi-schema/doc-good.txt" && if test -e tests/qapi-schema/doc-good.txt.nocr; then printf '%s\n' tests/qapi-schema/doc-good.txt.nocr > tests/qapi-schema/doc-good.txt.nocr.stamp; fi syntax error at -e line 1, near "=" Execution of -e aborted due to compilation errors. make: *** [Makefile.ninja:2555:tests/qapi-schema/doc-good.txt.nocr.stamp] 错误 255 -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v10] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
dn't know what's happened to the msys's git, but git-for-windows are works fine. > > Paolo > > > Il mer 7 ott 2020, 22:00 Yonggang Luo ha scritto: >> >> The sh script are harder to maintain for compatible different >> xsh environment so conve

[PATCH v10] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
under Ubuntu/msys2/mingw. Signed-off-by: Yonggang Luo Message-Id: <20201006112139.700-1-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- meson.build | 2 +- scripts/qemu-version.py | 37 + scripts/qemu-version.s

[PATCH v9] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
And using --match=v\\* to resolve wildcard problem on windows. Tested under Ubuntu/msys2/mingw. Signed-off-by: Yonggang Luo Message-Id: <20201006112139.700-1-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- meson.build | 2 +- scripts/qemu

[PATCH v8] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
And using --match=v\\* to resolve wildcard problem on windows. Tested under Ubuntu/msys2/mingw. Signed-off-by: Yonggang Luo Message-Id: <20201006112139.700-1-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- meson.build | 2 +- scripts/qemu

[PATCH v7] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
n retrieve, and also resolve the Windows wildcard match problem. only when the .git parallel folder have filenames start with --match=v such as --match=v123 would cause issue, and that's rare. Signed-off-by: Yonggang Luo Message-Id: <20201006112139.700-1-luoyongg...@gmail.com> Signed-

Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
On Thu, Oct 8, 2020 at 12:43 AM Paolo Bonzini wrote: > > On 07/10/20 18:23, 罗勇刚(Yonggang Luo) wrote: > >> +if not pkgversion and os.path.exists('.git'): > >> +# The quote of v* should preserve, otherwise git command > > would fail > >&g

[PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
: Yonggang Luo Message-Id: <20201006112139.700-1-luoyongg...@gmail.com> Signed-off-by: Paolo Bonzini --- meson.build | 2 +- scripts/qemu-version.py | 34 ++ scripts/qemu-version.sh | 25 - 3 files changed, 35 insertions(

Re: [PATCH v6] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-07 Thread Yonggang Luo
Hi Paolo, the qemu-version script you queued are mis removed the quote of "'v*'", that's would cause the building of qemu failed. please queue this instead. I also revised the commit message On Thu, Oct 8, 2020 at 12:21 AM Yonggang Luo wrote: > > The sh sc

Re: [PATCH v5 1/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-07 Thread Yonggang Luo
On Wed, Oct 7, 2020 at 11:12 PM Thomas Huth wrote: > > On 07/10/2020 16.52, Yonggang Luo wrote: > > Use cache of cirrus caching msys2 > > The install of msys2 are refer to https://github.com/msys2/setup-msys2 > > The first time install msys2 would be time consuming, so in

[PATCH v5 1/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-07 Thread Yonggang Luo
/html/qemu-devel/2020-10/msg00072.html Signed-off-by: Yonggang Luo --- .cirrus.yml | 110 +++- 1 file changed, 66 insertions(+), 44 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index d58782ce67..a1145d0366 100644 --- a/.cirrus.yml +++ b

Re: [PATCH v5 0/2] Improve cirrus msys2

2020-10-07 Thread Yonggang Luo
CC Alex, now it's really fixed On Wed, Oct 7, 2020 at 10:53 PM Yonggang Luo wrote: > > Fixes the broken msys2/mingw ci and speed it up. > > V4-V5 > Now the cache are usefull by using 7zip to archive msys64 > Saved about 18min, compare > https://cirrus-ci.com/tas

[PATCH v5 2/2] cirrus: msys2/mingw speed is up, add excluded target back

2020-10-07 Thread Yonggang Luo
The following target are add back: i386-softmmu,arm-softmmu,ppc-softmmu,mips-softmmu Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index a1145d0366..639f0b51c4 100644 --- a/.cirrus.yml +++ b

[PATCH v5 0/2] Improve cirrus msys2

2020-10-07 Thread Yonggang Luo
archive file V2-V3 Add one more patch: cirrus: msys2/mingw speed is up, add excluded target back Do not build sphinx on windows, that's failing set the number of parallel count to fixed number 8 V1-V2 Resolve the cirrus conflict Yonggang Luo (2): cirrus: Fixing and speedup the msys2/min

Re: [PATCH v4 0/2] Improve cirrus msys2

2020-10-07 Thread Yonggang Luo
On Wed, Oct 7, 2020 at 9:08 PM Alex Bennée wrote: > > > Yonggang Luo writes: > > > Fixes the broken msys2/mingw ci and speed it up. > > Queued to testing/next, thanks. Hi alex, still have issue, the cirrus cache are rather slow, waiting for my v5 version &

[PATCH v4 2/2] cirrus: msys2/mingw speed is up, add excluded target back

2020-10-07 Thread Yonggang Luo
The following target are add back: i386-softmmu,arm-softmmu,ppc-softmmu,mips-softmmu Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index b58fb63521..fc4b066170 100644 --- a/.cirrus.yml +++ b

[PATCH v4 1/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-07 Thread Yonggang Luo
/html/qemu-devel/2020-10/msg00072.html Signed-off-by: Yonggang Luo --- .cirrus.yml | 104 +--- 1 file changed, 59 insertions(+), 45 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index d58782ce67..b58fb63521 100644 --- a/.cirrus.yml +++ b

[PATCH v4 0/2] Improve cirrus msys2

2020-10-07 Thread Yonggang Luo
count to fixed number 8 V1-V2 Resolve the cirrus conflict Yonggang Luo (2): cirrus: Fixing and speedup the msys2/mingw CI cirrus: msys2/mingw speed is up, add excluded target back .cirrus.yml | 107 +--- 1 file changed, 60 insertions(+), 47 dele

Re: [PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-07 Thread Yonggang Luo
See https://cirrus-ci.org/guide/writing-tasks/#cache-instruction > ... then we're a little bit more independent from downloading the msys2 for > each CI run. Looks good for me, let's me investigate > > Thomas > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

[PATCH v3 3/3] cirrus: msys2/mingw speed is up, add excluded target back

2020-10-06 Thread Yonggang Luo
The following target are add back: i386-softmmu,arm-softmmu,ppc-softmmu,mips-softmmu Signed-off-by: Yonggang Luo --- .cirrus.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index bf5a0990ec..39a175d569 100644 --- a/.cirrus.yml +++ b

[PATCH v3 0/3] Improve cirrus msys2

2020-10-06 Thread Yonggang Luo
Fixes the broken msys2/mingw ci and speed it up. V2-V3 Add one more patch: cirrus: msys2/mingw speed is up, add excluded target back Do not build sphinx on windows, that's failing set the number of parallel count to fixed number 8 V1-V2 Resolve the cirrus conflict Yonggang Luo (3): d

[PATCH v3 2/3] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-06 Thread Yonggang Luo
Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz for speed up the msys2/mingw prepare speed on the cirrus CI. This file are generated by the msys2.docker Signed-off-by: Yonggang Luo --- .cirrus.yml | 60

[PATCH v3 1/3] docker: Add win32/msys2/mingw64 docker

2020-10-06 Thread Yonggang Luo
This docker is used to preparing a msys2/mingw with basic software installed. Signed-off-by: Yonggang Luo --- tests/docker/dockerfiles/msys2.docker | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 tests/docker/dockerfiles/msys2.docker diff --git a/tests

[PATCH v2 2/2] cirrus: Fixing and speedup the msys2/mingw CI

2020-10-06 Thread Yonggang Luo
Using a prepared https://github.com/lygstate/qemu/releases/download/v5.1.0/msys2-x86_64.tar.xz for speed up the msys2/mingw prepare speed on the cirrus CI. This file are generated by the msys2.docker Signed-off-by: Yonggang Luo --- .cirrus.yml | 58

[PATCH v2 1/2] docker: Add win32/msys2/mingw64 docker

2020-10-06 Thread Yonggang Luo
This docker is used to preparing a msys2/mingw with basic software installed. Signed-off-by: Yonggang Luo --- tests/docker/dockerfiles/msys2.docker | 57 +++ 1 file changed, 57 insertions(+) create mode 100644 tests/docker/dockerfiles/msys2.docker diff --git a/tests

[PATCH v2 0/2] Improve cirrus msys2

2020-10-06 Thread Yonggang Luo
Fixes the broken msys2/mingw ci and speed it up. V1-V2 Resolve the cirrus conflict Yonggang Luo (2): docker: Add win32/msys2/mingw64 docker cirrus: Fixing and speedup the msys2/mingw CI .cirrus.yml | 58 +++ tests/docker/dockerfiles/msys2

<    1   2   3   4   5   6   7   8   >