[PATCH v5 0/4] Fixes curses on msys2/mingw

And also convert related configure script to meson. Yonggang Luo (4): curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw curses: Fixes curses compiling errors. win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2

[PATCH] configure: fixes indent of $meson setup

convert these line from tab to space Signed-off-by: Yonggang Luo --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 3757e48b17..422b1ef2a3 100755 --- a/configure +++ b/configure @@ -7850,10 +7850,10 @@ NINJA=${ninja:-$PWD

[PATCH] configure: fixes indent of $meson setup

convert these line from tab to space Signed-off-by: Yonggang Luo --- configure | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 3757e48b17..6acd13a436 100755 --- a/configure +++ b/configure @@ -7850,10 +7850,10 @@ NINJA=${ninja:-$PWD

Re: [PATCH 0/3] gitlab: add jobs for checking paches

causes conflicts of course). > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org-o- https://www.instagram.com/dberrange :| > > agreed, and ineed patchew are broken now. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

On Fri, Sep 18, 2020 at 8:58 PM Paolo Bonzini wrote: > > On 18/09/20 10:42, 罗勇刚(Yonggang Luo) wrote: > > I also have a question that how about convert > > --disable-capstone) capstone="no" > > ;; > > --enable-capstone) capstone="yes" &g

Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson

s_key('CONFIG_ZSTD')} > summary_info += {'NUMA host support': config_host.has_key('CONFIG_NUMA')} > summary_info += {'libxml2': config_host.has_key('CONFIG_LIBXML2')} > -summary_info += {'tcmalloc support': config_host.has_key('CONFIG_TCMALLOC')} > -summary_info += {'jemalloc support': config_host.has_key('CONFIG_JEMALLOC')} > +summary_info += {'memory allocator': get_option('malloc')} > summary_info += {'avx2 optimization': config_host.has_key('CONFIG_AVX2_OPT')} > summary_info += {'avx512f optimization': config_host.has_key('CONFIG_AVX512F_OPT')} > summary_info += {'replication support': config_host.has_key('CONFIG_REPLICATION')} > diff --git a/meson_options.txt b/meson_options.txt > index 543cf70043..894e006799 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -6,6 +6,11 @@ option('docdir', type : 'string', value : 'doc', > option('gettext', type : 'boolean', value : true, > description: 'Localization of the GTK+ user interface') > > +option('malloc_trim', type : 'feature', value : 'auto', > + description: 'enable libc malloc_trim() for memory optimization') > +option('malloc', type : 'combo', choices : ['system', 'tcmalloc', 'jemalloc'], > + value: 'system', description: 'choose memory allocator to use') > + > option('sdl', type : 'feature', value : 'auto', > description: 'SDL user interface') > option('sdl_image', type : 'feature', value : 'auto', > -- > 2.26.2 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

o-error', '-w', > > + > > +# Include all configuration defines via a header file, which will wind up > > +# as a dependency on the object file, and thus changes here will result > > +# in a rebuild. > > +'-include', 'capstone-defs.h' > > + ] > > + > > + libcapstone = static_library('capstone', > > + sources: capstone_files, > > + c_args: capstone_cargs, > > + include_directories: 'capstone/include') > > + capstone = declare_dependency(link_with: libcapstone, > > +include_directories: 'capstone/include') > > +endif > > +config_host_data.set('CONFIG_CAPSTONE', capstone.found()) > > + > > +genh += configure_file(output: 'config-host.h', configuration: config_host_data) > > + > > # Generators > > > > hxtool = find_program('scripts/hxtool') > > @@ -1512,7 +1609,7 @@ summary_info += {'vvfat support': config_host.has_key('CONFIG_VVFAT')} > > summary_info += {'qed support': config_host.has_key('CONFIG_QED')} > > summary_info += {'parallels support': config_host.has_key('CONFIG_PARALLELS')} > > summary_info += {'sheepdog support': config_host.has_key('CONFIG_SHEEPDOG')} > > -summary_info += {'capstone': config_host.has_key('CONFIG_CAPSTONE')} > > +summary_info += {'capstone': capstone_opt} > > summary_info += {'libpmem support': config_host.has_key('CONFIG_LIBPMEM')} > > summary_info += {'libdaxctl support': config_host.has_key('CONFIG_LIBDAXCTL')} > > summary_info += {'libudev': config_host.has_key('CONFIG_LIBUDEV')} > > diff --git a/meson_options.txt b/meson_options.txt > > index 543cf70043..e650a937e7 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -22,3 +22,7 @@ option('vnc_sasl', type : 'feature', value : 'auto', > > description: 'SASL authentication for VNC server') > > option('xkbcommon', type : 'feature', value : 'auto', > > description: 'xkbcommon support') > > + > > +option('capstone', type: 'combo', value: 'auto', > > + choices: ['no', 'yes', 'auto', 'system', 'internal'], > > + description: 'Whether and how to find the capstone library') > > > > I also have a question that how about convert --disable-capstone) capstone="no" ;; --enable-capstone) capstone="yes" ;; to --disable-capstone) capstone="disabled" ;; --enable-capstone) capstone="enabled" ;; for consistence with meson -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

How to convert fowlloing code from configure to meson.build

$curses_lib" ; then curses_found=yes break fi done if test "$curses_found" = yes ; then break fi done unset IFS if test "$curses_found" = "yes" ; then curses=yes else if test "$curses" = "yes" ; then feature_not_found "curses" "Install ncurses devel" fi curses=no fi fi seems that need compile a program, but I didn't found a demo -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

sources: capstone_files, > + c_args: capstone_cargs, > + include_directories: 'capstone/include') > + capstone = declare_dependency(link_with: libcapstone, > + include_directories: 'capstone/include') > +endif > +config_host_data.set('CONFIG_CAPSTONE', capstone.found()) > + > +genh += configure_file(output: 'config-host.h', configuration: config_host_data) > + > # Generators > > hxtool = find_program('scripts/hxtool') > @@ -1512,7 +1609,7 @@ summary_info += {'vvfat support': config_host.has_key('CONFIG_VVFAT')} > summary_info += {'qed support': config_host.has_key('CONFIG_QED')} > summary_info += {'parallels support': config_host.has_key('CONFIG_PARALLELS')} > summary_info += {'sheepdog support': config_host.has_key('CONFIG_SHEEPDOG')} > -summary_info += {'capstone': config_host.has_key('CONFIG_CAPSTONE')} > +summary_info += {'capstone': capstone_opt} > summary_info += {'libpmem support': config_host.has_key('CONFIG_LIBPMEM')} > summary_info += {'libdaxctl support': config_host.has_key('CONFIG_LIBDAXCTL')} > summary_info += {'libudev': config_host.has_key('CONFIG_LIBUDEV')} > diff --git a/meson_options.txt b/meson_options.txt > index 543cf70043..e650a937e7 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -22,3 +22,7 @@ option('vnc_sasl', type : 'feature', value : 'auto', > description: 'SASL authentication for VNC server') > option('xkbcommon', type : 'feature', value : 'auto', > description: 'xkbcommon support') > + > +option('capstone', type: 'combo', value: 'auto', > + choices: ['no', 'yes', 'auto', 'system', 'internal'], > + description: 'Whether and how to find the capstone library') > -- > 2.25.1 > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

the time much, and indeed they can be compiled. --target-list-exclude=i386-softmmu,arm-softmmu,ppc-softmmu,mips-softmmu" > > Thomas > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PULL 00/24] qtests, unit tests and Cirrus-CI fixes / improvements

commits -- after two hours still not finished. Github have far more hardware resources. except doesn't have freebsd. When I using github with wind32, it's running around 1hour with full build(all target build). That's because when trigger github ci, it's will allocating resouce instantly 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: Use patchew to push successfully applied series to GitLab

ards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org-o- https://www.instagram.com/dberrange :| > > I agreed all, from these days experience on contributing to qemu, you suggestion improve most aspect I feel not good. -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v10 00/26] W32, W64 msys2/mingw patches

On Wed, Sep 16, 2020 at 7:52 PM Thomas Huth wrote: > > On 15/09/2020 19.12, Yonggang Luo wrote: > [...] > > It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and > > disable partial test-char tests. > > And then fixes all unit tests failure on

Re: [PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

On Wed, Sep 16, 2020 at 1:55 AM Philippe Mathieu-Daudé wrote: > > On 9/15/20 7:41 PM, 罗勇刚(Yonggang Luo) wrote: > > On Wed, Sep 16, 2020 at 12:41 AM Philippe Mathieu-Daudé > > mailto:phi...@redhat.com>> wrote: > >> > >> On 9/15/20 6:33 PM, Yonggang L

Re: [PATCH v10 15/26] cirrus: Building freebsd in a single short

On Wed, Sep 16, 2020 at 1:48 AM Philippe Mathieu-Daudé wrote: > > Typo "single shot" in subject? Yeap, single shot, hope the maintainer fix it > > > On 9/15/20 7:12 PM, Yonggang Luo wrote: > > This reverts commit 45f7b7b9f38f5c4d1529a37c93dedfc26a231bba >

[PATCH v10 25/26] block: Fixes nfs compiling error on msys2/mingw

tat64 yet, we disable the usage of it on msys2/mingw, and create a typedef long long blkcnt_t; for further implementation Signed-off-by: Yonggang Luo --- block/nfs.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/block/nfs.c b/block/nf

[PATCH v10 23/26] meson: upgrade meson for execute custom ninjatool under msys2 properly

* Bump versions to 0.55.2 for release * Tag Info: object 008d13038f95e7c7d8ad553f14e408da5b94c360 type commit tag 0.55.2 tagger Jussi Pakkanen 2020/9/11 1:24:47 Signed-off-by: Yonggang Luo --- meson | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson b/meson index

[PATCH v10 26/26] block: enable libnfs on msys2/mingw in cirrus.yml

At the begging libnfs are not enabled because of compiling error, now it's fixed so enable it Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index 90ed891865..ca4d7db64f 100644 --- a/.cirrus.yml +++ b/.cirrus.yml

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

On Wed, Sep 16, 2020 at 1:14 AM Paolo Bonzini wrote: > > On 15/09/20 19:07, 罗勇刚(Yonggang Luo) wrote: > > > > Linux distributions generally do not want to have bundled libraries, so > > > > Yes, bundled libraries is a bad idea, but static linked library is >

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

On Wed, Sep 16, 2020 at 1:00 AM Paolo Bonzini wrote: > On 15/09/20 18:12, 罗勇刚(Yonggang Luo) wrote: > > > > I suggest remove the capstone=system option cause the system library > > may not satisfy the requirements of qemu and create in-consistence > > expereince when

[PATCH v10 22/26] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full

drain_call_rcu is necessary on win32, because under win32, if you don't close the file before remove it, the remove would be fail. Signed-off-by: Yonggang Luo --- tests/test-logging.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test-logging.c b/tests/test-logging.c index

[PATCH v10 21/26] tests: Fixes test-qdev-global-props.c

On win32 the line ending are \r\n, so we skip the \n in function test_dynamic_globalprop Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-qdev-global-props.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/test-qdev-global-props.c b

[PATCH v10 24/26] ci: Enable msys2 ci in cirrus

we using environment variable settings: MSYS: winsymlinks:nativestrict MSYSTEM: MINGW64 CHERE_INVOKING: 1 to opening mingw64 native shell. Now all enabled msys2/tests are passed Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- .cirrus.yml | 61

[PATCH v10 19/26] tests: Fixes test-io-channel-file by mask only owner file state mask bits

ile.c:59:test_io_channel_file_helper: assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438) Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-io-channel-file.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests

[PATCH v10 00/26] W32, W64 msys2/mingw patches

ement drain_call_rcu Yonggang Luo (25): ci: fixes msys2 build by upgrading capstone to 4.0.2 configure: Fixes ncursesw detection under msys2/mingw and enable curses win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS. curses: Fixes curses compiling errors.

[PATCH v10 04/26] win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS.

to guard the localtime_r and counterpart functions Signed-off-by: Yonggang Luo --- configure | 34 -- include/sysemu/os-win32.h | 4 ++-- util/oslib-win32.c| 2 +- 3 files changed, 3 insertions(+), 37 deletions(-) diff --git a/configure b/configu

[PATCH v10 20/26] tests: fix test-util-sockets.c

:test_socket_fd_pass_name_good: assertion failed (fd != -1): (-1 != -1) First should call to qemu_init_main_loop before socket_init, then on win32 doesn't support for SOCKET_ADDRESS_TYPE_FD socket type Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-util-sockets.c | 6 +- 1 file

[PATCH v10 18/26] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c

)' failed And the idea comes from https://patchwork.kernel.org/patch/9975239/ Signed-off-by: Yonggang Luo --- util/aio-win32.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/util/aio-win32.c b/util/aio-win32.c index 953c56ab48..49bd90e62e 100644 --- a/util/aio-win32.c

[PATCH v10 16/26] tests: Convert g_free to g_autofree macro in test-logging.c

g_autofree are prefer than g_free when possible. Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- tests/test-logging.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test-logging.c b/tests/test-logging.c index

[PATCH v10 01/26] rcu: Implement drain_call_rcu

From: Maxim Levitsky This will allow is to preserve the semantics of hmp_device_del, that the device is deleted immediatly which was changed by previos patch that delayed this to RCU callback Signed-off-by: Maxim Levitsky Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi ---

[PATCH v10 03/26] configure: Fixes ncursesw detection under msys2/mingw and enable curses

/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv test.c:4:10: fatal error: langinfo.h: No such file or directory 4 | #include | ^~~~ compilation terminated. So we using g_get_codeset instead of nl_langinfo(CODESET) Signed-off-by: Yonggang Luo

[PATCH v10 17/26] tests: Fixes test-io-channel-socket.c tests under msys2/mingw

(@__tmainCRTStartup:142) mainCRTStartup (@1400014f6..140001539:3) BaseThreadInitThunk (@BaseThreadInitThunk:9) RtlUserThreadStart (@RtlUserThreadStart:12) Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-io-channel-socket.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v10 02/26] ci: fixes msys2 build by upgrading capstone to 4.0.2

1 error generated. Signed-off-by: Yonggang Luo --- capstone | 2 +- configure | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/capstone b/capstone index 22ead3e0bf..1d23053284 16 --- a/capstone +++ b/capstone @@ -1 +1 @@ -Subproject commit 22ead3e0bfdb87516656

[PATCH v10 05/26] curses: Fixes curses compiling errors.

as errors gcc version 10.2.0 (Rev1, Built by MSYS2 project) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 12bc682cf9..e4f9588c3e

[PATCH v10 07/26] tests: Fixes test-replication.c on msys2/mingw.

On Windows there is no path like /tmp/s_local_disk.XX Use g_get_tmp_dir instead of /tmp. Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-replication.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c

[PATCH v10 08/26] tests: test-replication disable /replication/secondary/* on msys2/mingw.

of secondary tests > ok 7 /replication/secondary/read > ok 8 /replication/secondary/write > Unexpected error in bdrv_reopen_prepare() at ../block.c:4191: > Block format 'file' used by node '#block4287' does not support reopening > files Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Be

[PATCH v10 11/26] gcrypt: test_tls_psk_init should write binary file instead text file.

On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/crypto-tls-psk-he

[PATCH v10 06/26] tests: disable /char/stdio/* tests in test-char.c on win32

These tests are blocking test-char to be finished. Disable them by using variable is_win32, so we doesn't need macro to open it. and easy recover those function latter. Signed-off-by: Yonggang Luo --- tests/test-char.c | 27 +-- 1 file changed, 17 insertions(+), 10

[PATCH v10 10/26] meson: Use -b to ignore CR vs. CR-LF issues on Windows

Ideally we would use the '--strip-trailing-cr' option, but not being POSIX is a portability problem (i.e. BSDs and Solaris based OSes). Instead use the '-b' option which, although doing slightly more, produce the expected result on Windows." Signed-off-by: Yonggang Luo Reviewed-by: Eric

[PATCH v10 14/26] vmstate: Fixes test-vmstate.c on msys2/mingw

The vmstate are valid on win32, just need generate tmp path properly Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/test-vmstate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[PATCH v10 15/26] cirrus: Building freebsd in a single short

little We should not hide the error by split them Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé Reviewed-by: Ed Maste --- .cirrus.yml | 35 --- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 3dd9fcff7f..

[PATCH v10 13/26] meson: remove empty else and duplicated gio deps

Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/meson.build b/meson.build index 690723b470..23cb1b8742 100644 --- a/meson.build +++ b/meson.build @@ -317,7 +317,6 @@ opengl = not_found if 'CONFIG_OPENGL

[PATCH v10 12/26] tests: Enable crypto tests under msys2/mingw

instead unlink Use g_mkdir instead mkdir Signed-off-by: Yonggang Luo --- include/qemu/osdep.h | 1 + include/sysemu/os-win32.h| 5 +++ tests/crypto-tls-psk-helpers.c | 4 +- tests/crypto-tls-x509-helpers.c | 6 ++- tests/crypto-tls-x509-helpers.h | 5 ++- tests/test

[PATCH v10 09/26] osdep: file locking functions are not available on Win32

-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- include/qemu/osdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 412962d91a..e80fddd1e8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -502,11 +502,11

[PATCH] guest agent: Fixes for windows guest agent building on msys2/mingw

n32.c.obj] 错误 1 (已忽略） This error comes from qemu configure didn't add predefined macro -DUNICODE -D_UNICODE in QEMU_CFLAGS, and these too macro are standard config for win32 if using windows wide api. in cfgmgr32.h CMAPI CONFIGRET WINAPI CM_Get_DevNode_PropertyW(DEVINST dnDevInst, const

Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits

xpereince when bug or error happens about capstone. We either have git submodule capstone or nothing at all > > > r~ > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v9 04/26] win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS.

On Tue, Sep 15, 2020 at 9:00 PM Daniel P. Berrangé wrote: > > On Tue, Sep 15, 2020 at 08:12:56PM +0800, Yonggang Luo wrote: > > First, this reduce the size of configure, configure are tending to removal in future, > > and this didn't introduce any new feature or remove

[PATCH v9 26/26] block: enable libnfs on msys2/mingw in cirrus.yml

At the begging libnfs are not enabled because of compiling error, now it's fixed so enable it Signed-off-by: Yonggang Luo --- .cirrus.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.cirrus.yml b/.cirrus.yml index 176ccba76c..9566ec0439 100644 --- a/.cirrus.yml +++ b/.cirrus.yml

[PATCH v9 24/26] ci: Enable msys2 ci in cirrus

we using environment variable settings: MSYS: winsymlinks:nativestrict MSYSTEM: MINGW64 CHERE_INVOKING: 1 to opening mingw64 native shell. We now running tests with make -i check to skip tests errors. Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- .cirrus.yml | 61

[PATCH v9 21/26] tests: Fixes test-qdev-global-props.c

On win32 the line ending are \r\n, so we skip the \n in function test_dynamic_globalprop Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-qdev-global-props.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-qdev-global-props.c b

[PATCH v9 23/26] meson: upgrade meson for execute custom ninjatool under msys2 properly

* Bump versions to 0.55.2 for release * Tag Info: object 008d13038f95e7c7d8ad553f14e408da5b94c360 type commit tag 0.55.2 tagger Jussi Pakkanen 2020/9/11 1:24:47 Signed-off-by: Yonggang Luo --- meson | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson b/meson index

[PATCH v9 20/26] tests: fix test-util-sockets.c

:test_socket_fd_pass_name_good: assertion failed (fd != -1): (-1 != -1) First should call to qemu_init_main_loop before socket_init, then on win32 doesn't support for SOCKET_ADDRESS_TYPE_FD socket type Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-util-sockets.c | 6 +- 1 file

[PATCH v9 18/26] tests: fixes aio-win32 about aio_remove_fd_handler, get it consistence with aio-posix.c

)' failed And the idea comes from https://patchwork.kernel.org/patch/9975239/ Signed-off-by: Yonggang Luo --- util/aio-win32.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/util/aio-win32.c b/util/aio-win32.c index 953c56ab48..9899546a8a 100644 --- a/util/aio-win32.c

[PATCH v9 15/26] cirrus: Building freebsd in a single short

little We should not hide the error by split them Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé Reviewed-by: Ed Maste --- .cirrus.yml | 35 --- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 3dd9fcff7f..

[PATCH v9 14/26] vmstate: Fixes test-vmstate.c on msys2/mingw

The vmstate are valid on win32, just need generate tmp path properly Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrangé --- tests/test-vmstate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests

[PATCH v9 13/26] meson: remove empty else and duplicated gio deps

Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- meson.build | 6 -- 1 file changed, 6 deletions(-) diff --git a/meson.build b/meson.build index 690723b470..23cb1b8742 100644 --- a/meson.build +++ b/meson.build @@ -317,7 +317,6 @@ opengl = not_found if 'CONFIG_OPENGL

[PATCH v9 25/26] block: Fixes nfs compiling error on msys2/mingw

tat64 yet, we disable the usage of it on msys2/mingw, and create a typedef long long blkcnt_t; for further implementation Signed-off-by: Yonggang Luo --- block/nfs.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/block/nfs.c b/block/nf

[PATCH v9 10/26] meson: Use -b to ignore CR vs. CR-LF issues on Windows

Ideally we would use the '--strip-trailing-cr' option, but not being POSIX is a portability problem (i.e. BSDs and Solaris based OSes). Instead use the '-b' option which, although doing slightly more, produce the expected result on Windows." Signed-off-by: Yonggang Luo Reviewed-by: Eric

[PATCH v9 22/26] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full

drain_call_rcu is necessary on win32, because under win32, if you don't close the file before remove it, the remove would be fail. Signed-off-by: Yonggang Luo --- tests/test-logging.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test-logging.c b/tests/test-logging.c index

[PATCH v9 12/26] tests: Enable crypto tests under msys2/mingw

instead unlink Use g_mkdir instead mkdir Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 2 +- tests/crypto-tls-x509-helpers.c | 106 ++- tests/crypto-tls-x509-helpers.h | 9 ++- tests/test-crypto-tlscredsx509.c | 47 +++--- tests/test

[PATCH v9 08/26] tests: test-replication disable /replication/secondary/* on msys2/mingw.

of secondary tests > ok 7 /replication/secondary/read > ok 8 /replication/secondary/write > Unexpected error in bdrv_reopen_prepare() at ../block.c:4191: > Block format 'file' used by node '#block4287' does not support reopening > files Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Be

[PATCH v9 07/26] tests: Fixes test-replication.c on msys2/mingw.

On Windows there is no path like /tmp/s_local_disk.XX Use g_get_tmp_dir instead of /tmp. Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-replication.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tests/test-replication.c

[PATCH v9 11/26] gcrypt: test_tls_psk_init should write binary file instead text file.

On windows, if open file with "w", it's will automatically convert "\n" to "\r\n" when writing to file. Signed-off-by: Yonggang Luo --- tests/crypto-tls-psk-helpers.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/crypto-tls-psk-he

[PATCH v9 02/26] ci: fixes msys2 build by upgrading capstone to 4.0.2

1 error generated. Signed-off-by: Yonggang Luo --- capstone | 2 +- configure | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/capstone b/capstone index 22ead3e0bf..1d23053284 16 --- a/capstone +++ b/capstone @@ -1 +1 @@ -Subproject commit 22ead3e0bfdb87516656

[PATCH v9 06/26] tests: disable /char/stdio/* tests in test-char.c on win32

These tests are blocking test-char to be finished. Disable them by using variable is_win32, so we doesn't need macro to open it. and easy recover those function latter. Signed-off-by: Yonggang Luo --- tests/test-char.c | 26 -- 1 file changed, 16 insertions(+), 10

[PATCH v9 09/26] osdep: file locking functions are not available on Win32

-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- include/qemu/osdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 412962d91a..e80fddd1e8 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@ -502,11 +502,11

[PATCH v9 19/26] tests: Fixes test-io-channel-file by mask only owner file state mask bits

ile.c:59:test_io_channel_file_helper: assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438) Signed-off-by: Yonggang Luo --- tests/test-io-channel-file.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/test-io-channel-file.c b/tests/test-i

[PATCH v9 04/26] win32: Simplify gmtime_r detection direct base on _POSIX_THREAD_SAFE_FUNCTIONS.

to guard the localtime_r and counterpart functions Signed-off-by: Yonggang Luo --- configure | 34 -- include/sysemu/os-win32.h | 4 ++-- util/oslib-win32.c| 2 +- 3 files changed, 3 insertions(+), 37 deletions(-) diff --git a/configure b/configu

[PATCH v9 17/26] tests: Fixes test-io-channel-socket.c tests under msys2/mingw

(@__tmainCRTStartup:142) mainCRTStartup (@1400014f6..140001539:3) BaseThreadInitThunk (@BaseThreadInitThunk:9) RtlUserThreadStart (@RtlUserThreadStart:12) Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-io-channel-socket.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v9 03/26] configure: Fixes ncursesw detection under msys2/mingw and enable curses

/mingw64/include/ncursesw -pipe -lncursesw -lgnurx -ltre -lintl -liconv test.c:4:10: fatal error: langinfo.h: No such file or directory 4 | #include | ^~~~ compilation terminated. So we using g_get_codeset instead of nl_langinfo(CODESET) Signed-off-by: Yonggang Luo

[PATCH v9 16/26] tests: Convert g_free to g_autofree macro in test-logging.c

g_autofree are prefer than g_free when possible. Signed-off-by: Yonggang Luo Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé --- tests/test-logging.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test-logging.c b/tests/test-logging.c index

[PATCH v9 05/26] curses: Fixes curses compiling errors.

as errors gcc version 10.2.0 (Rev1, Built by MSYS2 project) Signed-off-by: Yonggang Luo Reviewed-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrangé --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 12bc682cf9..e4f9588c3e

[PATCH v9 01/26] rcu: Implement drain_call_rcu

From: Maxim Levitsky This will allow is to preserve the semantics of hmp_device_del, that the device is deleted immediatly which was changed by previos patch that delayed this to RCU callback Signed-off-by: Maxim Levitsky Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi ---

[PATCH v9 00/26] W32, W64 msys2/mingw patches

sted in the mailling list All cirrus CI are passed Maxim Levitsky (1): rcu: Implement drain_call_rcu Yonggang Luo (25): ci: fixes msys2 build by upgrading capstone to 4.0.2 configure: Fixes ncursesw detection under msys2/mingw and enable curses win32: Simplify gmtime_r d

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On Tue, Sep 15, 2020 at 7:44 PM Thomas Huth wrote: > On 13/09/2020 16.08, Paolo Bonzini wrote: > > On 13/09/20 00:44, Yonggang Luo wrote: > >> This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > >> > >> The --ninja option doesn't need anymore

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Tue, Sep 15, 2020 at 12:14 AM Daniel P. Berrangé wrote: > > On Mon, Sep 14, 2020 at 11:58:24PM +0800, 罗勇刚(Yonggang Luo) wrote: > > On Mon, Sep 14, 2020 at 7:07 PM Thomas Huth wrote: > > > > > > On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > > &g

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

On Mon, Sep 14, 2020 at 10:41 PM Peter Maydell wrote: > On Sun, 13 Sep 2020 at 19:51, Philippe Mathieu-Daudé > wrote: > > > > On 9/13/20 6:01 PM, 罗勇刚(Yonggang Luo) wrote: > > > > > > > > > On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Mon, Sep 14, 2020 at 7:07 PM Thomas Huth wrote: > > On 14/09/2020 10.19, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth > <mailto:th...@redhat.com>> wrote: > >> > >> On 13/09/2020 00.44, Yonggang

Re: [PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw

How about using the following patch with +#if !defined (_WIN32) .bdrv_get_allocated_file_size = nfs_get_allocated_file_size, +#endif Also, +static blkcnt_t nfs_get_st_blocks(const struct nfs_stat *st) +{ +#if defined(_WIN32) +return (st->st_size + 511) / 512; +#else +return

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

s for, is that a perl script? -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH] tests/check-block: Do not run the iotests with old versions of bash

he qemu-iotests." > -- > 2.18.2 > > Is that worth to convert the check-block.sh script to python script? so it can even running under msys2/mingw？ -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On Mon, Sep 14, 2020 at 4:45 PM Paolo Bonzini wrote: > > On 13/09/20 18:14, 罗勇刚(Yonggang Luo) wrote: > > I am hurry to revert --ninja option because when the meson are changed, the > > make -j10 can not automatically re configure, that would raise ninja can > >

Re: [PATCH v8 13/27] tests: Enable crypto tests under msys2/mingw

On Mon, Sep 14, 2020 at 3:23 PM Thomas Huth wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > Fixes following tests on msys2/mingw > > 'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c', 'pkix_asn1_tab.c', > >tasn1,

Re: [PATCH v8 03/27] ci: fixes msys2 build by upgrading capstone to 4.0.2

On Mon, Sep 14, 2020 at 3:10 PM Thomas Huth wrote: > > On 13/09/2020 00.44, Yonggang Luo wrote: > > The currently random version capstone have the following compiling issue: > > CC /c/work/xemu/qemu/build/slirp/src/arp_table.o > > make[1]: *** No rule to make t

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

to patchew-de...@redhat.com I also have a question about this, This series seems to have some coding style problems, but where to find the logging, seems the logs of patchew are failed(out of disk) -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

On Mon, Sep 14, 2020 at 2:38 PM Stefan Weil wrote: > > Am 14.09.20 um 08:27 schrieb 罗勇刚(Yonggang Luo): > > > Thanks, I am learning how to submit patches properly, in old days, when I am using pull request on github have no such problems. easy to follow up > > > May I a

Re: [PATCH v8 00/27] W32, W64 msys2/mingw patches

On Mon, Sep 14, 2020 at 2:10 PM Thomas Huth wrote: > On 13/09/2020 00.44, Yonggang Luo wrote: > > It first introduce msys2 CI on cirrus by fixes nfs, capstone, curses and > > disable partial test-char tests. > > And then fixes all unit tests failure on msys2/mingw >

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On Mon, Sep 14, 2020 at 12:12 AM Paolo Bonzini wrote: > On 13/09/20 18:03, 罗勇刚(Yonggang Luo) wrote: > > > > _WIN32 are more precise and only depends on the compiler, on the > > other hand, CONFIG_POSIX and CONFIG_WIN32 need configure > > scripts. I prefer _WIN

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On Sun, Sep 13, 2020 at 10:08 PM Paolo Bonzini wrote: > On 13/09/20 00:44, Yonggang Luo wrote: > > This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > > > > The --ninja option doesn't need anymore because of upgrade meson to > 0.55.2 > > At that versi

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

On Sun, Sep 13, 2020 at 10:08 PM Paolo Bonzini wrote: > On 13/09/20 00:44, Yonggang Luo wrote: > > This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. > > > > The --ninja option doesn't need anymore because of upgrade meson to > 0.55.2 > > At that versi

Re: [PATCH v8 11/27] meson: Use -b to ignore CR vs. CR-LF issues on Windows

On Sun, Sep 13, 2020 at 11:35 PM Philippe Mathieu-Daudé wrote: > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > On windows, a difference in line endings causes testsuite failures > > complaining that every single line in files such as > > 'tests/qapi-schemadoc-good

Re: [PATCH v8 02/27] block: Fixes nfs compiling error on msys2/mingw

On Sun, Sep 13, 2020 at 11:47 PM Philippe Mathieu-Daudé wrote: > On 9/13/20 12:44 AM, Yonggang Luo wrote: > > These compiling errors are fixed: > > ../block/nfs.c:27:10: fatal error: poll.h: No such file or directory > >27 | #include > > | ^~~~

Re: [RFC PATCH 0/3] Automatically convert configure options to meson build options

| 35 +-- > meson-buildoptions.json | 130 > scripts/configure-parse-buildoptions.py | 94 + > 5 files changed, 280 insertions(+), 92 deletions(-) > create mode 100644 meson-buildoptions.json > create mode 100644 scripts/configure-parse-buildoptions.py > > -- > 2.26.2 > > > -- 此致 礼 罗勇刚 Yours sincerely, Yonggang Luo

[PATCH v8 27/27] Revert "configure: add --ninja option"

This reverts commit 48328880fddf0145bdccc499160fb24dfabfbd41. The --ninja option doesn't need anymore because of upgrade meson to 0.55.2 At that version we can use ninjatool Signed-off-by: Yonggang Luo --- configure | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff

[PATCH v8 26/27] meson: remove --ninja option in configure.

Signed-off-by: Yonggang Luo --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.cirrus.yml b/.cirrus.yml index 1ff9f0a72f..87bd110d28 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -99,7 +99,7 @@ windows_msys2_task: mingw-w64-x86_64-zstd" s

[PATCH v8 24/27] ci: Enable msys2 ci in cirrus

we using environment variable settings: MSYS: winsymlinks:nativestrict MSYSTEM: MINGW64 CHERE_INVOKING: 1 to opening mingw64 native shell. We now running tests with make -i check to skip tests errors. Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- .cirrus.yml | 60

[PATCH v8 25/27] meson: upgrade meson for execute custom ninjatool under msys2 properly

* Bump versions to 0.55.2 for release * Tag Info: object 008d13038f95e7c7d8ad553f14e408da5b94c360 type commit tag 0.55.2 tagger Jussi Pakkanen 2020/9/11 1:24:47 Signed-off-by: Yonggang Luo --- meson | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson b/meson index

[PATCH v8 20/27] tests: Fixes test-io-channel-file by mask only owner file state mask bits

ile.c:59:test_io_channel_file_helper: assertion failed (TEST_MASK & ~mask == st.st_mode & 0777): (384 == 438) Signed-off-by: Yonggang Luo --- tests/test-io-channel-file.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tests/test-io-channel-file.c b/tests/test-i

[PATCH v8 23/27] rcu: fixes test-logging.c by call drain_call_rcu before rmdir_full

drain_call_rcu is necessary on win32, because under win32, if you don't close the file before remove it, the remove would be fail. Signed-off-by: Yonggang Luo --- tests/test-logging.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/test-logging.c b/tests/test-logging.c index

[PATCH v8 22/27] tests: Fixes test-qdev-global-props.c

On win32 the line ending are \r\n, so we skip the \n in function test_dynamic_globalprop Signed-off-by: Yonggang Luo Reviewed-by: Daniel P. Berrangé --- tests/test-qdev-global-props.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-qdev-global-props.c b

<    1   2   3   4   5   6   7   8   >